@monorepolint/rules 0.5.0-alpha.9 → 0.5.0-alpha.95

package/src/nestedWorkspaces.ts

@@ -0,0 +1,59 @@
+/*!
+ * Copyright 2019 Palantir Technologies, Inc.
+ *
+ * Licensed under the MIT license. See LICENSE file in the project root for details.
+ *
+ */
+
+import { Context, RuleModule } from "@monorepolint/core";
+import globby from "globby";
+import path from "path";
+import * as r from "runtypes";
+
+export const Options = r.Undefined;
+
+type Options = r.Static<typeof Options>;
+
+// Enforce that the root package.json contains all of the workspaces in the repo (including nested packages)
+export const nestedWorkspaces: RuleModule<typeof Options> = {
+  check: (context: Context) => {
+    const rootPackageJson = context.getWorkspaceContext().getPackageJson();
+
+    // Expand a set of globs covering all package.json files in the entire repo (except the root)
+    const packageJsonPaths = globby.sync(["*/**/package.json", "!**/node_modules/**"]);
+
+    const workspaces = Array.isArray(rootPackageJson.workspaces)
+      ? rootPackageJson.workspaces
+      : rootPackageJson.workspaces !== undefined
+      ? rootPackageJson.workspaces.packages
+      : undefined;
+
+    if (workspaces === undefined && packageJsonPaths.length > 0) {
+      context.addError({
+        file: context.getPackageJsonPath(),
+        message: 'The "workspace" field is missing, even though there are workspaces in the repository.',
+      });
+      return;
+    }
+
+    // Build a set of globs for each package.json that exists in packages specified by a workspace.
+    const workspacePackageJsons = (workspaces || []).map((item) => `${item}/package.json`);
+
+    // Expand the globs to get an array of all package.json files that are in packages specified by a workspace.
+    const expandedWorkspacesGlobs = globby.sync([...workspacePackageJsons, "!**/node_modules/**"]);
+
+    // Ensure there are no package.jsons which are not included in the globbed workspaces set
+    const difference = packageJsonPaths.filter((packageJsonPath) => !expandedWorkspacesGlobs.includes(packageJsonPath));
+
+    if (difference.length !== 0) {
+      const differencesList = difference.map((packageJsonPath) => path.dirname(packageJsonPath)).join(", ");
+      context.addError({
+        file: context.getPackageJsonPath(),
+        message:
+          `The "workspace" field is missing one or more values: ${differencesList}. ` +
+          'You may be able to use a glob to avoid listing each workspace individually, e.g. "packages/nested-workspace/*".',
+      });
+    }
+  },
+  optionsRuntype: Options,
+};

package/src/packageEntry.ts

@@ -10,37 +10,80 @@ import { mutateJson, PackageJson } from "@monorepolint/utils";
 import diff from "jest-diff";
 import * as r from "runtypes";
 
-export const Options = r.Record({
-  entries: r.Dictionary(r.Unknown), // string => unknown
-});
+export const Options = r.Union(
+  r
+    .Record({
+      entries: r.Dictionary(r.Unknown), // string => unknown, enforces existence of keys and their values
+    })
+    .And(
+      r.Partial({
+        entriesExist: r.Undefined,
+      })
+    ),
+  r
+    .Record({
+      entriesExist: r.Array(r.String), // enforces existence of keys, but not values
+    })
+    .And(
+      r.Partial({
+        entries: r.Undefined,
+      })
+    ),
+  r.Record({
+    entries: r.Dictionary(r.Unknown), // string => unknown, enforces existence of keys and their values
+    entriesExist: r.Array(r.String),
+  })
+);
 
 export type Options = r.Static<typeof Options>;
 
-export const packageEntry = {
+export const packageEntry: RuleModule<typeof Options> = {
   check: function expectPackageEntry(context: Context, options: Options) {
     const packageJson = context.getPackageJson();
 
-    for (const key of Object.keys(options.entries)) {
-      const value = options.entries[key];
-
-      const entryDiff = diff(JSON.stringify(value) + "\n", (JSON.stringify(packageJson[key]) || "") + "\n");
-      if (
-        (typeof value !== "object" && value !== packageJson[key]) ||
-        (entryDiff == null || !entryDiff.includes("Compared values have no visual difference"))
-      ) {
-        context.addError({
-          file: context.getPackageJsonPath(),
-          message: `Expected standardized entry for '${key}'`,
-          longMessage: entryDiff,
-          fixer: () => {
-            mutateJson<PackageJson>(context.getPackageJsonPath(), input => {
-              input[key] = value;
-              return input;
-            });
-          },
-        });
+    if (options.entries) {
+      for (const key of Object.keys(options.entries)) {
+        const value = options.entries[key];
+
+        const entryDiff = diff(JSON.stringify(value) + "\n", (JSON.stringify(packageJson[key]) || "") + "\n");
+        if (
+          (typeof value !== "object" && value !== packageJson[key]) ||
+          entryDiff == null ||
+          !entryDiff.includes("Compared values have no visual difference")
+        ) {
+          context.addError({
+            file: context.getPackageJsonPath(),
+            message: createStandardizedEntryErrorMessage(key),
+            longMessage: entryDiff,
+            fixer: () => {
+              mutateJson<PackageJson>(context.getPackageJsonPath(), context.host, (input) => {
+                input[key] = value;
+                return input;
+              });
+            },
+          });
+        }
+      }
+    }
+
+    if (options.entriesExist) {
+      for (const key of options.entriesExist) {
+        if (packageJson[key] === undefined) {
+          context.addError({
+            file: context.getPackageJsonPath(),
+            message: createExpectedEntryErrorMessage(key),
+          });
+        }
       }
     }
   },
   optionsRuntype: Options,
-} as RuleModule<typeof Options>;
+};
+
+export function createStandardizedEntryErrorMessage(key: string) {
+  return `Expected standardized entry for '${key}'`;
+}
+
+export function createExpectedEntryErrorMessage(key: string) {
+  return `Expected entry for '${key}' to exist`;
+}

package/src/packageOrder.ts

@@ -6,7 +6,6 @@
  */
 
 import { Context, RuleModule } from "@monorepolint/core";
-import { writeJson } from "@monorepolint/utils";
 import diff from "jest-diff";
 import * as r from "runtypes";
 
@@ -23,6 +22,7 @@ type Options = r.Static<typeof Options>;
 const defaultKeyOrder = [
   "name",
   "version",
+  "description",
   "author",
   "contributors",
   "url",
@@ -55,10 +55,10 @@ export const packageOrder = {
 
     const order: string[] | OrderFunction = opts === undefined ? defaultKeyOrder : opts.order;
 
-    const compartor = isOrderFunction(order) ? order(context) : createCompartor(order);
+    const comparator = isOrderFunction(order) ? order(context) : createComparator(order);
 
     const actualOrder = Object.keys(packageJson);
-    const expectedOrder = actualOrder.slice().sort(compartor); // sort mutates, so we need to copy the previous result
+    const expectedOrder = actualOrder.slice().sort(comparator); // sort mutates, so we need to copy the previous result
 
     if (!arrayOrderCompare(actualOrder, expectedOrder)) {
       context.addError({
@@ -68,11 +68,11 @@ export const packageOrder = {
         fixer: () => {
           const expectedPackageJson: Record<string, any> = {};
 
-          expectedOrder.forEach(key => {
+          expectedOrder.forEach((key) => {
             expectedPackageJson[key] = packageJson[key];
           });
 
-          writeJson(packagePath, expectedPackageJson);
+          context.host.writeJson(packagePath, expectedPackageJson);
         },
       });
     }
@@ -90,7 +90,7 @@ function arrayOrderCompare(a: ReadonlyArray<string>, b: ReadonlyArray<string>) {
   return true;
 }
 
-function createCompartor(order: ReadonlyArray<string>) {
+function createComparator(order: ReadonlyArray<string>) {
   return (a: string, b: string) => {
     const aIndex = order.indexOf(a);
     const bIndex = order.indexOf(b);

package/src/packageScript.ts

@@ -39,7 +39,7 @@ export const packageScript = {
         file: context.getPackageJsonPath(),
         message: MSG_NO_SCRIPTS_BLOCK,
         fixer: () => {
-          mutateJson<PackageJson>(context.getPackageJsonPath(), input => {
+          mutateJson<PackageJson>(context.getPackageJsonPath(), context.host, (input) => {
             input.scripts = {};
             return input;
           });
@@ -75,7 +75,7 @@ export const packageScript = {
         if (fixValue !== false && (fixValue !== undefined || fixToEmpty === true)) {
           const q = fixValue;
           fixer = () => {
-            mutateJson<PackageJson>(context.getPackageJsonPath(), input => {
+            mutateJson<PackageJson>(context.getPackageJsonPath(), context.host, (input) => {
               if (fixToEmpty && q === undefined) {
                 delete input.scripts![name];
               } else {
@@ -87,7 +87,7 @@ export const packageScript = {
         }
 
         const validOptionsString = Array.from(allowedValues.values())
-          .map(a => (a === undefined ? "(empty)" : `'${a}'`))
+          .map((a) => (a === undefined ? "(empty)" : `'${a}'`))
           .join(", ");
 
         context.addError({

package/src/requireDependency.ts

@@ -0,0 +1,69 @@
+/*!
+ * Copyright 2019 Palantir Technologies, Inc.
+ *
+ * Licensed under the MIT license. See LICENSE file in the project root for details.
+ *
+ */
+
+import { Context, RuleModule } from "@monorepolint/core";
+import { mutateJson, PackageJson } from "@monorepolint/utils";
+import diff from "jest-diff";
+import * as r from "runtypes";
+
+const Options = r.Partial({
+  dependencies: r.Dictionary(r.String),
+  devDependencies: r.Dictionary(r.String),
+  peerDependencies: r.Dictionary(r.String),
+  optionalDependencies: r.Dictionary(r.String),
+});
+
+type Options = r.Static<typeof Options>;
+
+export const requireDependency = {
+  check: function expectPackageEntry(context: Context, options: Options) {
+    const packageJson = context.getPackageJson();
+    const packageJsonPath = context.getPackageJsonPath();
+
+    [
+      "dependencies" as const,
+      "devDependencies" as const,
+      "peerDependencies" as const,
+      "optionalDependencies" as const,
+    ].forEach((type) => {
+      if (!options[type]) {
+        return;
+      }
+
+      if (packageJson[type] === undefined) {
+        context.addError({
+          file: packageJsonPath,
+          message: `No ${type} block, cannot add required ${type}.`,
+          fixer: () => {
+            mutateJson<PackageJson>(packageJsonPath, context.host, (input) => {
+              input[type] = options[type];
+              return input;
+            });
+          },
+        });
+        return;
+      }
+
+      for (const [dep, version] of Object.entries(options[type]!)) {
+        if (packageJson[type][dep] !== version) {
+          context.addError({
+            file: packageJsonPath,
+            message: `Expected dependency ${dep}@${version}`,
+            longMessage: diff(`${dep}@${version}\n`, `${dep}@${packageJson[type][dep] || "missing"}\n`)!,
+            fixer: () => {
+              mutateJson<PackageJson>(packageJsonPath, context.host, (input) => {
+                input[type] = { ...input[type], [dep]: version };
+                return input;
+              });
+            },
+          });
+        }
+      }
+    });
+  },
+  optionsRuntype: Options,
+} as RuleModule<typeof Options>;

package/src/standardTsconfig.ts

@@ -6,19 +6,22 @@
  */
 
 import { Context, RuleModule } from "@monorepolint/core";
-import { getPackageNameToDir } from "@monorepolint/utils";
-import { existsSync, readFileSync, writeFileSync } from "fs";
+import { matchesAnyGlob } from "@monorepolint/utils";
 import diff from "jest-diff";
-import minimatch from "minimatch";
 import * as path from "path";
 import * as r from "runtypes";
 
+const DEFAULT_TSCONFIG_FILENAME = "tsconfig.json";
+
 const Options = r
   .Partial({
+    file: r.String,
     generator: r.Function,
+    tsconfigReferenceFile: r.String,
     template: r.Record({}).Or(r.String),
     templateFile: r.String,
     excludedReferences: r.Array(r.String).Or(r.Undefined),
+    additionalReferences: r.Array(r.String).Or(r.Undefined),
   })
   .withConstraint(({ generator, template, templateFile }) => {
     let count = 0;
@@ -39,11 +42,14 @@ export type Options = r.Static<typeof Options>;
 
 export const standardTsconfig = {
   check: function expectStandardTsconfig(context: Context, opts: Options) {
-    const fullPath = path.resolve(context.packageDir, "tsconfig.json");
+    const tsconfigFileName = opts.file ?? DEFAULT_TSCONFIG_FILENAME;
+    const fullPath = path.resolve(context.packageDir, tsconfigFileName);
     const generator = getGenerator(context, opts);
     const expectedContent = generator(context);
 
-    const actualContent = existsSync(fullPath) ? readFileSync(fullPath, "utf-8") : undefined;
+    const actualContent = context.host.exists(fullPath)
+      ? context.host.readFile(fullPath, { encoding: "utf-8" })
+      : undefined;
 
     if (expectedContent === undefined) {
       context.addWarning({
@@ -59,7 +65,9 @@ export const standardTsconfig = {
         message: "Expect file contents to match",
         longMessage: diff(expectedContent, actualContent, { expand: true }),
         fixer: () => {
-          writeFileSync(fullPath, expectedContent);
+          context.host.writeFile(fullPath, expectedContent, {
+            encoding: "utf-8",
+          });
         },
       });
     }
@@ -73,37 +81,51 @@ function getGenerator(context: Context, opts: Options) {
   } else if (opts.templateFile) {
     const { packageDir: workspacePackageDir } = context.getWorkspaceContext();
     const fullPath = path.resolve(workspacePackageDir, opts.templateFile);
-    const template = JSON.parse(readFileSync(fullPath, "utf-8"));
+    const template = JSON.parse(context.host.readFile(fullPath, { encoding: "utf-8" }));
 
-    return makeGenerator(template, opts.excludedReferences);
+    return makeGenerator(template, opts.excludedReferences, opts.additionalReferences, opts.tsconfigReferenceFile);
   } else if (opts.template) {
-    return makeGenerator(opts.template, opts.excludedReferences);
+    return makeGenerator(opts.template, opts.excludedReferences, opts.additionalReferences, opts.tsconfigReferenceFile);
   } else {
     throw new Error("Unable to make generator");
   }
 }
 
-function makeGenerator(template: any, excludedReferences: ReadonlyArray<string> = []) {
+function makeGenerator(
+  template: any,
+  excludedReferences: ReadonlyArray<string> | undefined,
+  additionalReferences: ReadonlyArray<string> | undefined,
+  tsconfigReferenceFile?: string
+) {
   return function generator(context: Context) {
     template = {
       ...template,
       references: [],
     }; // make a copy and ensure we have a references array
 
-    const nameToDirectory = getPackageNameToDir(context.getWorkspaceContext().packageDir);
+    const nameToDirectory = context.getWorkspaceContext().getPackageNameToDir();
 
     const packageJson = context.getPackageJson();
     const deps = [...Object.keys(packageJson.dependencies || {}), ...Object.keys(packageJson.devDependencies || {})];
 
-    deps
-      .filter(
-        name => nameToDirectory.has(name) && !excludedReferences.some(excludedRef => minimatch(name, excludedRef))
-      )
-      .forEach(packageName => {
+    for (const dep of deps) {
+      const packageDir = nameToDirectory.get(dep);
+      if (packageDir !== undefined && (excludedReferences === undefined || matchesAnyGlob(dep, excludedReferences))) {
+        const absoluteReferencePath =
+          tsconfigReferenceFile !== undefined ? path.join(packageDir, tsconfigReferenceFile) : packageDir;
         template.references.push({
-          path: path.relative(context.packageDir, nameToDirectory.get(packageName)!),
+          path: path.relative(context.packageDir, absoluteReferencePath),
         });
-      });
+      }
+    }
+
+    if (additionalReferences) {
+      for (const additionalReference of additionalReferences) {
+        template.references.push({
+          path: additionalReference,
+        });
+      }
+    }
 
     return JSON.stringify(template, undefined, 2) + "\n";
   };

package/src/util/checkAlpha.ts

@@ -0,0 +1,59 @@
+/*!
+ * Copyright 2019 Palantir Technologies, Inc.
+ *
+ * Licensed under the MIT license. See LICENSE file in the project root for details.
+ *
+ */
+
+import { Context } from "@monorepolint/core";
+import diff from "jest-diff";
+
+export function checkAlpha(
+  context: Context,
+  block: "dependencies" | "devDependencies" | "peerDependencies" | "scripts"
+) {
+  const packageJson = context.getPackageJson();
+  const packagePath = context.getPackageJsonPath();
+
+  const blockToSort = packageJson[block];
+
+  if (blockToSort === undefined) {
+    return;
+  }
+
+  const actualOrder = Object.keys(blockToSort);
+  const expectedOrder = actualOrder.slice().sort(); // sort mutates, so we need to copy the previous result
+
+  if (!arrayOrderCompare(actualOrder, expectedOrder)) {
+    context.addError({
+      file: packagePath,
+      message: createIncorrectOrderErrorMessage(block, packageJson.name!),
+      longMessage: diff(expectedOrder, actualOrder, { expand: true }),
+      fixer: () => {
+        const expectedDependencies: Record<string, string> = {};
+
+        expectedOrder.forEach((dep) => {
+          expectedDependencies[dep] = blockToSort[dep];
+        });
+
+        const newPackageJson = { ...packageJson };
+        newPackageJson[block] = expectedDependencies;
+        context.host.writeJson(packagePath, newPackageJson);
+      },
+    });
+  }
+}
+
+function arrayOrderCompare(a: ReadonlyArray<string>, b: ReadonlyArray<string>) {
+  for (let index = 0; index < a.length; index++) {
+    if (a[index] !== b[index]) {
+      return false;
+    }
+  }
+
+  return true;
+}
+
+export function createIncorrectOrderErrorMessage(block: string, packageName: string) {
+  return `Incorrect order of ${block} in ${packageName}'s package.json`;
+}

package/src/util/makeDirectory.ts

@@ -0,0 +1,24 @@
+/*!
+ * Copyright 2019 Palantir Technologies, Inc.
+ *
+ * Licensed under the MIT license. See LICENSE file in the project root for details.
+ *
+ */
+
+import { existsSync, mkdirSync } from "fs";
+import * as path from "path";
+
+export function makeDirectoryRecursively(directoryPath: string) {
+  // node < 10 doesn't support mkdirSync w/ recursive: true
+  // so we manually do it instead
+  const dirSegments = directoryPath.split(path.sep);
+  for (let i = 0; i < dirSegments.length; i++) {
+    if (dirSegments[i].length > 0) {
+      // we skip the empty segment
+      const curDirPath = dirSegments.slice(0, i + 1).join(path.sep);
+      if (!existsSync(curDirPath)) {
+        mkdirSync(curDirPath);
+      }
+    }
+  }
+}

package/src/util/packageDependencyGraphService.ts

@@ -0,0 +1,114 @@
+/**
+ * @license Copyright 2019 Palantir Technologies, Inc. All rights reserved.
+ */
+
+import { Host, PackageJson } from "@monorepolint/utils";
+import path from "path";
+import resolvePackagePath from "resolve-package-path";
+
+/** Interface for a node in a package dependency graph. */
+export interface IPackageDependencyGraphNode {
+  packageJson: PackageJson;
+  dependencies: Map<string, IPackageDependencyGraphNode>;
+  paths: {
+    packageJsonPath: string;
+    rootDirectory: string;
+  };
+}
+
+/** Service abstraction for constructing and traversing package dependency graphs. */
+export interface IPackageDependencyGraphService {
+  /** Construct a graph of package dependencies. */
+  buildDependencyGraph(packageJsonPath: string, host: Host, maxDepth?: number): IPackageDependencyGraphNode;
+
+  /** Traverse a package dependency graph. */
+  traverse(
+    root: IPackageDependencyGraphNode,
+    opts?: {
+      /** Traverse each unique path to a given package (potentially slow). */
+      traverseAllPaths?: boolean;
+    }
+  ): IterableIterator<IPackageDependencyGraphNode & { importPath: IPackageDependencyGraphNode[] }>;
+}
+
+/** Default implementation of the package dependency graph service. */
+export class PackageDependencyGraphService implements IPackageDependencyGraphService {
+  /** Construct a graph of package dependencies and return the root node. */
+  public buildDependencyGraph(
+    startPackageJsonPath: string,
+    host: Host,
+    maxDepth?: number
+  ): IPackageDependencyGraphNode {
+    const nodes = new Map<string, IPackageDependencyGraphNode>();
+    const visit = (packageJsonPath: string, currentDepth: number): IPackageDependencyGraphNode => {
+      if (nodes.has(packageJsonPath)) {
+        return nodes.get(packageJsonPath)!;
+      }
+
+      const packageJson: PackageJson = host.readJson(packageJsonPath);
+      const node: IPackageDependencyGraphNode = {
+        packageJson,
+        dependencies: new Map<string, IPackageDependencyGraphNode>(),
+        paths: {
+          packageJsonPath,
+          rootDirectory: path.dirname(packageJsonPath),
+        },
+      };
+
+      // It's important that we register the node before visiting its dependencies to avoid cycles
+      nodes.set(packageJsonPath, node);
+
+      const nextDepth = currentDepth + 1;
+      if (maxDepth == null || nextDepth <= maxDepth) {
+        const dependencies = packageJson.dependencies != null ? Object.keys(packageJson.dependencies) : [];
+        for (const dependency of dependencies) {
+          const dependencyPackageJsonPath = resolvePackagePath(dependency, node.paths.rootDirectory);
+          if (dependencyPackageJsonPath == null) {
+            throw new Error(`Could not resolve ${dependency} from ${node.paths.rootDirectory}`);
+          }
+
+          node.dependencies.set(dependency, visit(dependencyPackageJsonPath, nextDepth));
+        }
+      }
+
+      return node;
+    };
+
+    return visit(startPackageJsonPath, 0);
+  }
+
+  /** Traverse a package dependency graph with an iterator. */
+  public *traverse(
+    root: IPackageDependencyGraphNode,
+    opts = { traverseAllPaths: false }
+  ): IterableIterator<IPackageDependencyGraphNode & { importPath: IPackageDependencyGraphNode[] }> {
+    const visited = new Set<IPackageDependencyGraphNode>();
+
+    function* visit(
+      node: IPackageDependencyGraphNode,
+      importPath: IPackageDependencyGraphNode[] = []
+    ): IterableIterator<IPackageDependencyGraphNode & { importPath: IPackageDependencyGraphNode[] }> {
+      // Don't visit a package more than once unless explicitly asked to traverse all paths
+      if (!opts.traverseAllPaths && visited.has(node)) {
+        return;
+      }
+
+      // Break cycles when traversing all paths
+      if (importPath.indexOf(node) !== -1) {
+        return;
+      }
+
+      // Visit the node
+      visited.add(node);
+      importPath = [...importPath, node];
+      yield { ...node, importPath };
+
+      // Recursively visit the node's dependencies
+      for (const dependency of node.dependencies.values()) {
+        yield* visit(dependency, importPath);
+      }
+    }
+
+    yield* visit(root);
+  }
+}