@monorepolint/rules 0.5.0-alpha.7 → 0.5.0-alpha.73

package/lib/util/makeDirectory.js

@@ -0,0 +1,28 @@
+"use strict";
+/*!
+ * Copyright 2019 Palantir Technologies, Inc.
+ *
+ * Licensed under the MIT license. See LICENSE file in the project root for details.
+ *
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.makeDirectoryRecursively = void 0;
+const tslib_1 = require("tslib");
+const fs_1 = require("fs");
+const path = tslib_1.__importStar(require("path"));
+function makeDirectoryRecursively(directoryPath) {
+    // node < 10 doesn't support mkdirSync w/ recursive: true
+    // so we manually do it instead
+    const dirSegments = directoryPath.split(path.sep);
+    for (let i = 0; i < dirSegments.length; i++) {
+        if (dirSegments[i].length > 0) {
+            // we skip the empty segment
+            const curDirPath = dirSegments.slice(0, i + 1).join(path.sep);
+            if (!fs_1.existsSync(curDirPath)) {
+                fs_1.mkdirSync(curDirPath);
+            }
+        }
+    }
+}
+exports.makeDirectoryRecursively = makeDirectoryRecursively;
+//# sourceMappingURL=makeDirectory.js.map

package/lib/util/makeDirectory.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"makeDirectory.js","sourceRoot":"","sources":["../../src/util/makeDirectory.ts"],"names":[],"mappings":";AAAA;;;;;GAKG;;;;AAEH,2BAA2C;AAC3C,mDAA6B;AAE7B,SAAgB,wBAAwB,CAAC,aAAqB;IAC5D,yDAAyD;IACzD,+BAA+B;IAC/B,MAAM,WAAW,GAAG,aAAa,CAAC,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IAClD,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,WAAW,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE;QAC3C,IAAI,WAAW,CAAC,CAAC,CAAC,CAAC,MAAM,GAAG,CAAC,EAAE;YAC7B,4BAA4B;YAC5B,MAAM,UAAU,GAAG,WAAW,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;YAC9D,IAAI,CAAC,eAAU,CAAC,UAAU,CAAC,EAAE;gBAC3B,cAAS,CAAC,UAAU,CAAC,CAAC;aACvB;SACF;KACF;AACH,CAAC;AAbD,4DAaC"}

package/lib/util/packageDependencyGraphService.d.ts

@@ -0,0 +1,37 @@
+/**
+ * @license Copyright 2019 Palantir Technologies, Inc. All rights reserved.
+ */
+import { PackageJson } from "@monorepolint/utils";
+/** Interface for a node in a package dependency graph. */
+export interface IPackageDependencyGraphNode {
+    packageJson: PackageJson;
+    dependencies: Map<string, IPackageDependencyGraphNode>;
+    paths: {
+        packageJsonPath: string;
+        rootDirectory: string;
+    };
+}
+/** Service abstraction for constructing and traversing package dependency graphs. */
+export interface IPackageDependencyGraphService {
+    /** Construct a graph of package dependencies. */
+    buildDependencyGraph(packageJsonPath: string, maxDepth?: number): IPackageDependencyGraphNode;
+    /** Traverse a package dependency graph. */
+    traverse(root: IPackageDependencyGraphNode, opts?: {
+        /** Traverse each unique path to a given package (potentially slow). */
+        traverseAllPaths?: boolean;
+    }): IterableIterator<IPackageDependencyGraphNode & {
+        importPath: IPackageDependencyGraphNode[];
+    }>;
+}
+/** Default implementation of the package dependency graph service. */
+export declare class PackageDependencyGraphService implements IPackageDependencyGraphService {
+    /** Construct a graph of package dependencies and return the root node. */
+    buildDependencyGraph(startPackageJsonPath: string, maxDepth?: number): IPackageDependencyGraphNode;
+    /** Traverse a package dependency graph with an iterator. */
+    traverse(root: IPackageDependencyGraphNode, opts?: {
+        traverseAllPaths: boolean;
+    }): IterableIterator<IPackageDependencyGraphNode & {
+        importPath: IPackageDependencyGraphNode[];
+    }>;
+}
+//# sourceMappingURL=packageDependencyGraphService.d.ts.map

package/lib/util/packageDependencyGraphService.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"packageDependencyGraphService.d.ts","sourceRoot":"","sources":["../../src/util/packageDependencyGraphService.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AAIlD,0DAA0D;AAC1D,MAAM,WAAW,2BAA2B;IAC1C,WAAW,EAAE,WAAW,CAAC;IACzB,YAAY,EAAE,GAAG,CAAC,MAAM,EAAE,2BAA2B,CAAC,CAAC;IACvD,KAAK,EAAE;QACL,eAAe,EAAE,MAAM,CAAC;QACxB,aAAa,EAAE,MAAM,CAAC;KACvB,CAAC;CACH;AAED,qFAAqF;AACrF,MAAM,WAAW,8BAA8B;IAC7C,iDAAiD;IACjD,oBAAoB,CAAC,eAAe,EAAE,MAAM,EAAE,QAAQ,CAAC,EAAE,MAAM,GAAG,2BAA2B,CAAC;IAE9F,2CAA2C;IAC3C,QAAQ,CACN,IAAI,EAAE,2BAA2B,EACjC,IAAI,CAAC,EAAE;QACL,uEAAuE;QACvE,gBAAgB,CAAC,EAAE,OAAO,CAAC;KAC5B,GACA,gBAAgB,CAAC,2BAA2B,GAAG;QAAE,UAAU,EAAE,2BAA2B,EAAE,CAAA;KAAE,CAAC,CAAC;CAClG;AAED,sEAAsE;AACtE,qBAAa,6BAA8B,YAAW,8BAA8B;IAClF,0EAA0E;IACnE,oBAAoB,CAAC,oBAAoB,EAAE,MAAM,EAAE,QAAQ,CAAC,EAAE,MAAM,GAAG,2BAA2B;IAwCzG,4DAA4D;IACpD,QAAQ,CACd,IAAI,EAAE,2BAA2B,EACjC,IAAI;;KAA8B,GACjC,gBAAgB,CAAC,2BAA2B,GAAG;QAAE,UAAU,EAAE,2BAA2B,EAAE,CAAA;KAAE,CAAC;CA8BjG"}

package/lib/util/packageDependencyGraphService.js

@@ -0,0 +1,70 @@
+"use strict";
+/**
+ * @license Copyright 2019 Palantir Technologies, Inc. All rights reserved.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.PackageDependencyGraphService = void 0;
+const tslib_1 = require("tslib");
+const path_1 = tslib_1.__importDefault(require("path"));
+const resolve_package_path_1 = tslib_1.__importDefault(require("resolve-package-path"));
+/** Default implementation of the package dependency graph service. */
+class PackageDependencyGraphService {
+    /** Construct a graph of package dependencies and return the root node. */
+    buildDependencyGraph(startPackageJsonPath, maxDepth) {
+        const nodes = new Map();
+        const visit = (packageJsonPath, currentDepth) => {
+            if (nodes.has(packageJsonPath)) {
+                return nodes.get(packageJsonPath);
+            }
+            const packageJson = require(packageJsonPath);
+            const node = {
+                packageJson,
+                dependencies: new Map(),
+                paths: {
+                    packageJsonPath,
+                    rootDirectory: path_1.default.dirname(packageJsonPath),
+                },
+            };
+            // It's important that we register the node before visiting its dependencies to avoid cycles
+            nodes.set(packageJsonPath, node);
+            const nextDepth = currentDepth + 1;
+            if (maxDepth == null || nextDepth <= maxDepth) {
+                const dependencies = packageJson.dependencies != null ? Object.keys(packageJson.dependencies) : [];
+                for (const dependency of dependencies) {
+                    const dependencyPackageJsonPath = resolve_package_path_1.default(dependency, node.paths.rootDirectory);
+                    if (dependencyPackageJsonPath == null) {
+                        throw new Error(`Could not resolve ${dependency} from ${node.paths.rootDirectory}`);
+                    }
+                    node.dependencies.set(dependency, visit(dependencyPackageJsonPath, nextDepth));
+                }
+            }
+            return node;
+        };
+        return visit(startPackageJsonPath, 0);
+    }
+    /** Traverse a package dependency graph with an iterator. */
+    *traverse(root, opts = { traverseAllPaths: false }) {
+        const visited = new Set();
+        function* visit(node, importPath = []) {
+            // Don't visit a package more than once unless explicitly asked to traverse all paths
+            if (!opts.traverseAllPaths && visited.has(node)) {
+                return;
+            }
+            // Break cycles when traversing all paths
+            if (importPath.indexOf(node) !== -1) {
+                return;
+            }
+            // Visit the node
+            visited.add(node);
+            importPath = [...importPath, node];
+            yield { ...node, importPath };
+            // Recursively visit the node's dependencies
+            for (const dependency of node.dependencies.values()) {
+                yield* visit(dependency, importPath);
+            }
+        }
+        yield* visit(root);
+    }
+}
+exports.PackageDependencyGraphService = PackageDependencyGraphService;
+//# sourceMappingURL=packageDependencyGraphService.js.map

package/lib/util/packageDependencyGraphService.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"packageDependencyGraphService.js","sourceRoot":"","sources":["../../src/util/packageDependencyGraphService.ts"],"names":[],"mappings":";AAAA;;GAEG;;;;AAGH,wDAAwB;AACxB,wFAAsD;AA2BtD,sEAAsE;AACtE,MAAa,6BAA6B;IACxC,0EAA0E;IACnE,oBAAoB,CAAC,oBAA4B,EAAE,QAAiB;QACzE,MAAM,KAAK,GAAG,IAAI,GAAG,EAAuC,CAAC;QAE7D,MAAM,KAAK,GAAG,CAAC,eAAuB,EAAE,YAAoB,EAA+B,EAAE;YAC3F,IAAI,KAAK,CAAC,GAAG,CAAC,eAAe,CAAC,EAAE;gBAC9B,OAAO,KAAK,CAAC,GAAG,CAAC,eAAe,CAAE,CAAC;aACpC;YAED,MAAM,WAAW,GAAgB,OAAO,CAAC,eAAe,CAAC,CAAC;YAC1D,MAAM,IAAI,GAAgC;gBACxC,WAAW;gBACX,YAAY,EAAE,IAAI,GAAG,EAAuC;gBAC5D,KAAK,EAAE;oBACL,eAAe;oBACf,aAAa,EAAE,cAAI,CAAC,OAAO,CAAC,eAAe,CAAC;iBAC7C;aACF,CAAC;YAEF,4FAA4F;YAC5F,KAAK,CAAC,GAAG,CAAC,eAAe,EAAE,IAAI,CAAC,CAAC;YAEjC,MAAM,SAAS,GAAG,YAAY,GAAG,CAAC,CAAC;YACnC,IAAI,QAAQ,IAAI,IAAI,IAAI,SAAS,IAAI,QAAQ,EAAE;gBAC7C,MAAM,YAAY,GAAG,WAAW,CAAC,YAAY,IAAI,IAAI,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,WAAW,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;gBACnG,KAAK,MAAM,UAAU,IAAI,YAAY,EAAE;oBACrC,MAAM,yBAAyB,GAAG,8BAAkB,CAAC,UAAU,EAAE,IAAI,CAAC,KAAK,CAAC,aAAa,CAAC,CAAC;oBAC3F,IAAI,yBAAyB,IAAI,IAAI,EAAE;wBACrC,MAAM,IAAI,KAAK,CAAC,qBAAqB,UAAU,SAAS,IAAI,CAAC,KAAK,CAAC,aAAa,EAAE,CAAC,CAAC;qBACrF;oBAED,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,UAAU,EAAE,KAAK,CAAC,yBAAyB,EAAE,SAAS,CAAC,CAAC,CAAC;iBAChF;aACF;YAED,OAAO,IAAI,CAAC;QACd,CAAC,CAAC;QAEF,OAAO,KAAK,CAAC,oBAAoB,EAAE,CAAC,CAAC,CAAC;IACxC,CAAC;IAED,4DAA4D;IACrD,CAAC,QAAQ,CACd,IAAiC,EACjC,IAAI,GAAG,EAAE,gBAAgB,EAAE,KAAK,EAAE;QAElC,MAAM,OAAO,GAAG,IAAI,GAAG,EAA+B,CAAC;QAEvD,QAAQ,CAAC,CAAC,KAAK,CACb,IAAiC,EACjC,aAA4C,EAAE;YAE9C,qFAAqF;YACrF,IAAI,CAAC,IAAI,CAAC,gBAAgB,IAAI,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE;gBAC/C,OAAO;aACR;YAED,yCAAyC;YACzC,IAAI,UAAU,CAAC,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE;gBACnC,OAAO;aACR;YAED,iBAAiB;YACjB,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;YAClB,UAAU,GAAG,CAAC,GAAG,UAAU,EAAE,IAAI,CAAC,CAAC;YACnC,MAAM,EAAE,GAAG,IAAI,EAAE,UAAU,EAAE,CAAC;YAE9B,4CAA4C;YAC5C,KAAK,MAAM,UAAU,IAAI,IAAI,CAAC,YAAY,CAAC,MAAM,EAAE,EAAE;gBACnD,KAAK,CAAC,CAAC,KAAK,CAAC,UAAU,EAAE,UAAU,CAAC,CAAC;aACtC;QACH,CAAC;QAED,KAAK,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IACrB,CAAC;CACF;AA5ED,sEA4EC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@monorepolint/rules",
-  "version": "0.5.0-alpha.7+e67adbd",
+  "version": "0.5.0-alpha.73+1a78d3c",
   "author": "Eric L Anderson (https://github.com/ericanderson)",
   "contributors": [
     "Mac Lockard (https://github.com/maclockard)"
@@ -10,29 +10,33 @@
   "main": "lib/index.js",
   "typings": "lib/index.d.ts",
   "scripts": {
-    "clean": "rm -rf build lib node_modules *.tgz",
+    "clean": "rm -rf build lib node_modules *.tgz tsconfig.tsbuildinfo",
     "compile:typescript": "../../node_modules/.bin/tsc",
-    "jest:watch": "../../node_modules/.bin/jest --config ../../jest.config.js --watch",
     "jest": "../../node_modules/.bin/jest --config ../../jest.config.js",
+    "jest:watch": "../../node_modules/.bin/jest --config ../../jest.config.js --watch",
     "lint:typescript": "../../node_modules/.bin/tslint --config ../../tslint.json --project .",
-    "test:watch": "../../node_modules/.bin/jest --colors --passWithNoTests --watch",
-    "test": "../../node_modules/.bin/jest --colors --passWithNoTests"
+    "test": "../../node_modules/.bin/jest --colors --passWithNoTests",
+    "test:watch": "../../node_modules/.bin/jest --colors --passWithNoTests --watch"
   },
   "dependencies": {
-    "@monorepolint/core": "^0.5.0-alpha.7+e67adbd",
-    "@monorepolint/utils": "^0.5.0-alpha.7+e67adbd",
-    "jest-diff": "^24.9.0",
+    "@monorepolint/core": "^0.5.0-alpha.73+1a78d3c",
+    "@monorepolint/utils": "^0.5.0-alpha.73+1a78d3c",
+    "globby": "^11.0.1",
+    "jest-diff": "^26.0.1",
     "minimatch": "^3.0.4",
-    "runtypes": "^4.0.0"
+    "resolve-package-path": "^3.1.0",
+    "runtypes": "^4.0.0",
+    "semver": "^7.3.2"
   },
   "devDependencies": {
-    "@types/jest-diff": "^20.0.0",
+    "@types/jest-diff": "^24.3.0",
     "@types/minimatch": "^3.0.3",
-    "@types/tmp": "^0.1.0",
-    "tmp": "^0.1.0"
+    "@types/semver": "^7.2.0",
+    "@types/tmp": "^0.2.0",
+    "tmp": "^0.2.1"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "e67adbda77a0b2e8ab4ff14a807b677018a32a26"
+  "gitHead": "1a78d3c44f9ed73aedb73bd49d297b243a707893"
 }

package/src/__tests__/alphabeticalScripts.spec.ts

@@ -0,0 +1,76 @@
+/*!
+ * Copyright 2019 Palantir Technologies, Inc.
+ *
+ * Licensed under the MIT license. See LICENSE file in the project root for details.
+ *
+ */
+
+// tslint:disable:no-console
+import { createMockFiles, jsonToString } from "./utils";
+
+// done first since this also mocks 'fs'
+const mockFiles: Map<string, string> = createMockFiles();
+
+import { Failure, PackageContext } from "@monorepolint/core";
+import { alphabeticalScripts } from "../alphabeticalScripts";
+
+const PACKAGE_SCRIPTS_SORTED = jsonToString({
+  name: "foo-lib",
+  scripts: {
+    a: "a-",
+    b: "b-",
+    c: "c-",
+  },
+});
+
+const PACKAGE_SCRIPTS_UNSORTED = jsonToString({
+  name: "foo-lib",
+  scripts: {
+    c: "c-",
+    a: "a-",
+    b: "b-",
+  },
+});
+
+describe("alphabeticalScripts", () => {
+  afterEach(() => {
+    mockFiles.clear();
+  });
+
+  describe("fix: true", () => {
+    const context = new PackageContext(".", {
+      rules: [],
+      fix: true,
+      verbose: false,
+      silent: true,
+    });
+    const spy = jest.spyOn(context, "addError");
+
+    afterEach(() => {
+      spy.mockClear();
+    });
+
+    it("fixes unsorted scripts", () => {
+      mockFiles.set("package.json", PACKAGE_SCRIPTS_UNSORTED);
+
+      alphabeticalScripts.check(context, undefined);
+
+      expect(spy).toHaveBeenCalledTimes(1);
+
+      const failure: Failure = spy.mock.calls[0][0];
+      expect(failure.file).toBe("package.json");
+      expect(failure.fixer).not.toBeUndefined();
+      expect(failure.message).toBe("Incorrect order of scripts in foo-lib's package.json");
+
+      expect(mockFiles.get("package.json")).toEqual(PACKAGE_SCRIPTS_SORTED);
+    });
+
+    it("does nothing if already sorted", () => {
+      mockFiles.set("package.json", PACKAGE_SCRIPTS_SORTED);
+
+      alphabeticalScripts.check(context, undefined);
+
+      expect(spy).toHaveBeenCalledTimes(0);
+    });
+  });
+});

package/src/__tests__/bannedDependencies.spec.ts

@@ -0,0 +1,117 @@
+/*!
+ * Copyright 2020 Palantir Technologies, Inc.
+ *
+ * Licensed under the MIT license. See LICENSE file in the project root for details.
+ *
+ */
+import { WorkspaceContext } from "@monorepolint/core";
+import { writeFileSync } from "fs";
+import * as path from "path";
+import * as tmp from "tmp";
+import { bannedDependencies, Options } from "../bannedDependencies";
+import { makeDirectoryRecursively } from "../util/makeDirectory";
+import { jsonToString } from "./utils";
+
+const EMPTY_PACKAGE = jsonToString({});
+
+describe("bannedDependencies", () => {
+  tmp.setGracefulCleanup();
+
+  let cleanupJobs: Array<() => void> = [];
+  let cwd: string | undefined;
+
+  beforeEach(() => {
+    const dir = tmp.dirSync({ unsafeCleanup: true });
+    cleanupJobs.push(() => dir.removeCallback());
+    cwd = dir.name;
+
+    const spy = jest.spyOn(process, "cwd");
+    spy.mockReturnValue(cwd);
+  });
+
+  afterEach(() => {
+    for (const cleanupJob of cleanupJobs) {
+      cleanupJob();
+    }
+    cleanupJobs = [];
+  });
+
+  function makeWorkspace() {
+    const workspaceContext = new WorkspaceContext(cwd!, {
+      rules: [],
+      fix: false,
+      verbose: false,
+      silent: true,
+    });
+
+    function checkAndSpy(options: Options) {
+      const addErrorSpy = jest.spyOn(workspaceContext, "addError");
+      bannedDependencies.check(workspaceContext, {
+        ...options,
+      });
+      return { addErrorSpy };
+    }
+
+    function addFile(filePath: string, content: string) {
+      const dirPath = path.resolve(cwd!, path.dirname(filePath));
+      const resolvedFilePath = path.resolve(cwd!, filePath);
+
+      makeDirectoryRecursively(dirPath);
+      writeFileSync(resolvedFilePath, content);
+      return resolvedFilePath;
+    }
+
+    return { addFile, workspaceContext, checkAndSpy };
+  }
+
+  it("Flags banned dependencies correctly", async () => {
+    const { addFile, checkAndSpy } = makeWorkspace();
+    const rootPackageJson = jsonToString({
+      dependencies: {
+        aaa: "0.0.1",
+        ccc: "0.0.1",
+      },
+    });
+    addFile("./package.json", rootPackageJson);
+
+    const { addErrorSpy: addErrorSpy1 } = checkAndSpy({ bannedDependencies: ["ccc"] });
+    expect(addErrorSpy1).toHaveBeenCalledTimes(1);
+    addErrorSpy1.mockReset();
+
+    const { addErrorSpy: addErrorSpy2 } = checkAndSpy({ bannedDependencies: ["ddd"] });
+    expect(addErrorSpy2).toHaveBeenCalledTimes(0);
+    addErrorSpy2.mockReset();
+
+    const { addErrorSpy: addErrorSpy3 } = checkAndSpy({ bannedDependencies: ["ccc", "ddd"] });
+    expect(addErrorSpy3).toHaveBeenCalledTimes(1);
+    addErrorSpy3.mockReset();
+  });
+
+  it("Flags banned transitives correctly", async () => {
+    const { addFile, checkAndSpy } = makeWorkspace();
+    const rootPackageJson = jsonToString({
+      dependencies: {
+        aaa: "0.0.1",
+      },
+    });
+    addFile("./package.json", rootPackageJson);
+
+    const aaaPackageJson = jsonToString({
+      dependencies: {
+        bbb: "0.0.1",
+        ccc: "0.0.1",
+      },
+    });
+    addFile("./node_modules/aaa/package.json", aaaPackageJson);
+    const bbbPackageJson = jsonToString({
+      dependencies: {
+        ddd: "0.0.1",
+      },
+    });
+    addFile("./node_modules/aaa/node_modules/bbb/package.json", bbbPackageJson);
+    addFile("./node_modules/aaa/node_modules/bbb/node_modules/ddd/package.json", EMPTY_PACKAGE);
+    addFile("./node_modules/aaa/node_modules/ccc/package.json", EMPTY_PACKAGE);
+
+    expect(checkAndSpy({ bannedTransitiveDependencies: ["ccc", "ddd"] }).addErrorSpy).toHaveBeenCalledTimes(2);
+  });
+});

package/src/__tests__/consistentDependencies.spec.ts

@@ -5,14 +5,12 @@
  *
  */
 import { WorkspaceContext } from "@monorepolint/core";
-import { mkdirSync, readFileSync, writeFileSync } from "fs";
+import { readFileSync, writeFileSync } from "fs";
 import * as path from "path";
 import * as tmp from "tmp";
-import { consistentDependencies } from "../consistentDependencies";
-
-function jsonToString(obj: {}) {
-  return JSON.stringify(obj, undefined, 2) + "\n";
-}
+import { consistentDependencies, Options } from "../consistentDependencies";
+import { makeDirectoryRecursively } from "../util/makeDirectory";
+import { jsonToString } from "./utils";
 
 const PACKAGE_ROOT = jsonToString({
   workspaces: {
@@ -29,6 +27,12 @@ const PACKAGE_CHILD_WITH_STAR = jsonToString({
   },
 });
 
+const PACKAGE_CHILD_WITH_LATEST = jsonToString({
+  dependencies: {
+    foo: "latest",
+  },
+});
+
 const PACKAGE_CHILD_WITH_RIGHT_VERSION = jsonToString({
   dependencies: {
     foo: "5",
@@ -54,26 +58,28 @@ describe("consistentDependencies", () => {
   });
 
   function makeWorkspace({ fix }: { fix: boolean }) {
-    const dir: tmp.DirResult = tmp.dirSync();
+    const dir: tmp.DirResult = tmp.dirSync({ unsafeCleanup: true });
     cleanupJobs.push(() => dir.removeCallback());
 
     const workspaceContext = new WorkspaceContext(dir.name, {
       rules: [],
       fix,
       verbose: false,
+      silent: true,
     });
 
-    function checkAndSpy(q: string) {
+    function checkAndSpy(q: string, opts?: Options) {
       const context = workspaceContext.createChildContext(path.resolve(dir.name, q));
       const addErrorSpy = jest.spyOn(context, "addError");
-      consistentDependencies.check(context, undefined);
+      consistentDependencies.check(context, opts);
       return { context, addErrorSpy };
     }
 
     function addFile(filePath: string, content: string) {
       const dirPath = path.resolve(dir.name, path.dirname(filePath));
       const resolvedFilePath = path.resolve(dir.name, filePath);
-      mkdirSync(dirPath, { recursive: true });
+
+      makeDirectoryRecursively(dirPath);
       writeFileSync(resolvedFilePath, content);
     }
 
@@ -88,6 +94,7 @@ describe("consistentDependencies", () => {
     const { addFile, workspaceContext, checkAndSpy } = makeWorkspace({ fix: false });
     addFile("./package.json", PACKAGE_ROOT);
     addFile("./packages/star/package.json", PACKAGE_CHILD_WITH_STAR);
+    addFile("./packages/latest/package.json", PACKAGE_CHILD_WITH_LATEST);
     addFile("./packages/right/package.json", PACKAGE_CHILD_WITH_RIGHT_VERSION);
     addFile("./packages/wrong/package.json", PACKAGE_CHILD_WITH_WRONG_VERSION);
 
@@ -96,6 +103,9 @@ describe("consistentDependencies", () => {
     const star = checkAndSpy("./packages/star");
     expect(star.addErrorSpy).toHaveBeenCalledTimes(0);
 
+    const latest = checkAndSpy("./packages/latest");
+    expect(latest.addErrorSpy).toHaveBeenCalledTimes(0);
+
     const right = checkAndSpy("./packages/right");
     expect(right.addErrorSpy).toHaveBeenCalledTimes(0);
 
@@ -114,4 +124,13 @@ describe("consistentDependencies", () => {
     const contents = readFile("./packages/wrong/package.json");
     expect(contents).toEqual(PACKAGE_CHILD_WITH_RIGHT_VERSION);
   });
+
+  it("ignores ignored dependencies", () => {
+    const { addFile, checkAndSpy } = makeWorkspace({ fix: false });
+    addFile("./package.json", PACKAGE_ROOT);
+    addFile("./packages/wrong/package.json", PACKAGE_CHILD_WITH_WRONG_VERSION);
+
+    const ignored = checkAndSpy("./packages/wrong", { ignoredDependencies: ["foo"] });
+    expect(ignored.addErrorSpy).toHaveBeenCalledTimes(0);
+  });
 });