@monorepolint/rules 0.5.0-alpha.12 → 0.5.0-alpha.125

package/{lib → build/types}/util/checkAlpha.d.ts

@@ -4,6 +4,7 @@
  * Licensed under the MIT license. See LICENSE file in the project root for details.
  *
  */
-import { Context } from "@monorepolint/core";
+import { Context } from "@monorepolint/config";
 export declare function checkAlpha(context: Context, block: "dependencies" | "devDependencies" | "peerDependencies" | "scripts"): void;
+export declare function createIncorrectOrderErrorMessage(block: string, packageName: string): string;
 //# sourceMappingURL=checkAlpha.d.ts.map

package/build/types/util/checkAlpha.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"checkAlpha.d.ts","sourceRoot":"","sources":["../../../src/util/checkAlpha.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,EAAE,OAAO,EAAE,MAAM,sBAAsB,CAAC;AAG/C,wBAAgB,UAAU,CACxB,OAAO,EAAE,OAAO,EAChB,KAAK,EAAE,cAAc,GAAG,iBAAiB,GAAG,kBAAkB,GAAG,SAAS,QAgC3E;AAYD,wBAAgB,gCAAgC,CAAC,KAAK,EAAE,MAAM,EAAE,WAAW,EAAE,MAAM,UAElF"}

package/build/types/util/makeDirectory.d.ts

@@ -0,0 +1,8 @@
+/*!
+ * Copyright 2019 Palantir Technologies, Inc.
+ *
+ * Licensed under the MIT license. See LICENSE file in the project root for details.
+ *
+ */
+export declare function makeDirectoryRecursively(directoryPath: string): void;
+//# sourceMappingURL=makeDirectory.d.ts.map

package/build/types/util/makeDirectory.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"makeDirectory.d.ts","sourceRoot":"","sources":["../../../src/util/makeDirectory.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAKH,wBAAgB,wBAAwB,CAAC,aAAa,EAAE,MAAM,QAa7D"}

package/build/types/util/makeRule.d.ts

@@ -0,0 +1,12 @@
+import { Context, RuleEntry, RuleModule } from "@monorepolint/config";
+export declare function makeRule<X>({ name, check, validateOptions, printStats, }: {
+    name: string;
+    check: (context: Context, options: X, extra: {
+        id: string;
+    }) => Promise<unknown> | unknown;
+    printStats?: () => void;
+    validateOptions: (options: unknown) => asserts options is X;
+}): RuleFunction<X>;
+type RuleFunction<T> = (ruleEntry: RuleEntry<T>) => RuleModule<T>;
+export {};
+//# sourceMappingURL=makeRule.d.ts.map

package/build/types/util/makeRule.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"makeRule.d.ts","sourceRoot":"","sources":["../../../src/util/makeRule.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,MAAM,sBAAsB,CAAC;AAGtE,wBAAgB,QAAQ,CAAC,CAAC,EAAE,EAC1B,IAAI,EACJ,KAAK,EACL,eAAe,EACf,UAAU,GACX,EAAE;IACD,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,EAAE,CAAC,OAAO,EAAE,OAAO,EAAE,OAAO,EAAE,CAAC,EAAE,KAAK,EAAE;QAAE,EAAE,EAAE,MAAM,CAAA;KAAE,KAAK,OAAO,CAAC,OAAO,CAAC,GAAG,OAAO,CAAC;IAC3F,UAAU,CAAC,EAAE,MAAM,IAAI,CAAC;IACxB,eAAe,EAAE,CAAC,OAAO,EAAE,OAAO,KAAK,OAAO,CAAC,OAAO,IAAI,CAAC,CAAC;CAC7D,GAAG,YAAY,CAAC,CAAC,CAAC,CAalB;AAED,KAAK,YAAY,CAAC,CAAC,IAAI,CAAC,SAAS,EAAE,SAAS,CAAC,CAAC,CAAC,KAAK,UAAU,CAAC,CAAC,CAAC,CAAC"}

package/build/types/util/packageDependencyGraphService.d.ts

@@ -0,0 +1,37 @@
+/**
+ * @license Copyright 2019 Palantir Technologies, Inc. All rights reserved.
+ */
+import { Host, PackageJson } from "@monorepolint/utils";
+/** Interface for a node in a package dependency graph. */
+export interface IPackageDependencyGraphNode {
+    packageJson: PackageJson;
+    dependencies: Map<string, IPackageDependencyGraphNode>;
+    paths: {
+        packageJsonPath: string;
+        rootDirectory: string;
+    };
+}
+/** Service abstraction for constructing and traversing package dependency graphs. */
+export interface IPackageDependencyGraphService {
+    /** Construct a graph of package dependencies. */
+    buildDependencyGraph(packageJsonPath: string, host: Host, maxDepth?: number): IPackageDependencyGraphNode;
+    /** Traverse a package dependency graph. */
+    traverse(root: IPackageDependencyGraphNode, opts?: {
+        /** Traverse each unique path to a given package (potentially slow). */
+        traverseAllPaths?: boolean;
+    }): IterableIterator<IPackageDependencyGraphNode & {
+        importPath: IPackageDependencyGraphNode[];
+    }>;
+}
+/** Default implementation of the package dependency graph service. */
+export declare class PackageDependencyGraphService implements IPackageDependencyGraphService {
+    /** Construct a graph of package dependencies and return the root node. */
+    buildDependencyGraph(startPackageJsonPath: string, host: Host, maxDepth?: number): IPackageDependencyGraphNode;
+    /** Traverse a package dependency graph with an iterator. */
+    traverse(root: IPackageDependencyGraphNode, opts?: {
+        traverseAllPaths: boolean;
+    }): IterableIterator<IPackageDependencyGraphNode & {
+        importPath: IPackageDependencyGraphNode[];
+    }>;
+}
+//# sourceMappingURL=packageDependencyGraphService.d.ts.map

package/build/types/util/packageDependencyGraphService.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"packageDependencyGraphService.d.ts","sourceRoot":"","sources":["../../../src/util/packageDependencyGraphService.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,EAAE,IAAI,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AAIxD,0DAA0D;AAC1D,MAAM,WAAW,2BAA2B;IAC1C,WAAW,EAAE,WAAW,CAAC;IACzB,YAAY,EAAE,GAAG,CAAC,MAAM,EAAE,2BAA2B,CAAC,CAAC;IACvD,KAAK,EAAE;QACL,eAAe,EAAE,MAAM,CAAC;QACxB,aAAa,EAAE,MAAM,CAAC;KACvB,CAAC;CACH;AAED,qFAAqF;AACrF,MAAM,WAAW,8BAA8B;IAC7C,iDAAiD;IACjD,oBAAoB,CAAC,eAAe,EAAE,MAAM,EAAE,IAAI,EAAE,IAAI,EAAE,QAAQ,CAAC,EAAE,MAAM,GAAG,2BAA2B,CAAC;IAE1G,2CAA2C;IAC3C,QAAQ,CACN,IAAI,EAAE,2BAA2B,EACjC,IAAI,CAAC,EAAE;QACL,uEAAuE;QACvE,gBAAgB,CAAC,EAAE,OAAO,CAAC;KAC5B,GACA,gBAAgB,CAAC,2BAA2B,GAAG;QAAE,UAAU,EAAE,2BAA2B,EAAE,CAAA;KAAE,CAAC,CAAC;CAClG;AAED,sEAAsE;AACtE,qBAAa,6BAA8B,YAAW,8BAA8B;IAClF,0EAA0E;IACnE,oBAAoB,CACzB,oBAAoB,EAAE,MAAM,EAC5B,IAAI,EAAE,IAAI,EACV,QAAQ,CAAC,EAAE,MAAM,GAChB,2BAA2B;IAuC9B,4DAA4D;IACpD,QAAQ,CACd,IAAI,EAAE,2BAA2B,EACjC,IAAI;;KAA8B,GACjC,gBAAgB,CAAC,2BAA2B,GAAG;QAAE,UAAU,EAAE,2BAA2B,EAAE,CAAA;KAAE,CAAC;CA8BjG"}

package/package.json

@@ -1,38 +1,63 @@
 {
   "name": "@monorepolint/rules",
-  "version": "0.5.0-alpha.12+7cf8550",
+  "version": "0.5.0-alpha.125+a94c83e",
   "author": "Eric L Anderson (https://github.com/ericanderson)",
   "contributors": [
     "Mac Lockard (https://github.com/maclockard)"
   ],
   "url": "https://github.com/monorepolint/monorepolint",
   "license": "MIT",
-  "main": "lib/index.js",
-  "typings": "lib/index.d.ts",
+  "type": "module",
+  "exports": {
+    ".": {
+      "types": "./build/types/index.d.ts",
+      "import": "./build/js/index.js"
+    },
+    "./*": {
+      "types": "./build/types/public/*.d.ts",
+      "import": "./build/js/public/*.js"
+    }
+  },
+  "engines": {
+    "node": ">=18"
+  },
   "scripts": {
-    "clean": "rm -rf build lib node_modules *.tgz",
-    "compile:typescript": "../../node_modules/.bin/tsc",
-    "jest": "../../node_modules/.bin/jest --config ../../jest.config.js",
-    "jest:watch": "../../node_modules/.bin/jest --config ../../jest.config.js --watch",
-    "lint:typescript": "../../node_modules/.bin/tslint --config ../../tslint.json --project .",
-    "test": "../../node_modules/.bin/jest --colors --passWithNoTests",
-    "test:watch": "../../node_modules/.bin/jest --colors --passWithNoTests --watch"
+    "clean": "rm -rf build dist lib node_modules *.tgz tsconfig.tsbuildinfo",
+    "compile-typescript": "tsc --build",
+    "lint": "eslint .",
+    "test": "NODE_OPTIONS=--experimental-vm-modules jest --colors --passWithNoTests",
+    "test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --colors --passWithNoTests --watch",
+    "transpile-typescript": "tsup --config ../../tsup.config.cjs"
   },
   "dependencies": {
-    "@monorepolint/core": "^0.5.0-alpha.12+7cf8550",
-    "@monorepolint/utils": "^0.5.0-alpha.12+7cf8550",
-    "jest-diff": "^24.9.0",
-    "minimatch": "^3.0.4",
-    "runtypes": "^4.0.0"
+    "@monorepolint/config": "^0.5.0-alpha.125+a94c83e",
+    "@monorepolint/core": "^0.5.0-alpha.125+a94c83e",
+    "@monorepolint/utils": "^0.5.0-alpha.125+a94c83e",
+    "globby": "^14.0.0",
+    "jest-diff": "^29.7.0",
+    "resolve-package-path": "^4.0.3",
+    "runtypes": "^6.7.0",
+    "semver": "^7.5.4",
+    "tslib": "^2.6.2"
   },
   "devDependencies": {
-    "@types/jest-diff": "^20.0.0",
-    "@types/minimatch": "^3.0.3",
-    "@types/tmp": "^0.1.0",
-    "tmp": "^0.1.0"
+    "@jest/globals": "^29.7.0",
+    "@types/jest": "^29.5.10",
+    "@types/semver": "^7.5.6",
+    "@types/tmp": "^0.2.6",
+    "@typescript-eslint/eslint-plugin": "^6.13.1",
+    "@typescript-eslint/parser": "^6.13.1",
+    "eslint": "^8.54.0",
+    "jest": "^29.7.0",
+    "prettier": "^3.1.0",
+    "tmp": "^0.2.1",
+    "ts-jest": "^29.1.1",
+    "tslib": "^2.6.2",
+    "tsup": "^8.0.1",
+    "typescript": "^5.3.2"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "7cf85507b1b968a26b8e501bec25aefc12558c6e"
+  "gitHead": "a94c83edd6800fbd70dce53643b251fa6b769fd8"
 }

package/src/__tests__/alphabeticalScripts.spec.ts

@@ -6,15 +6,14 @@
  */
 
 // tslint:disable:no-console
-import { createMockFiles, jsonToString } from "./utils";
-
-// done first since this also mocks 'fs'
-const mockFiles: Map<string, string> = createMockFiles();
-
-import { Failure, PackageContext } from "@monorepolint/core";
-import { alphabeticalScripts } from "../alphabeticalScripts";
+import { describe, expect, it, beforeEach, jest } from "@jest/globals";
+import { AddErrorSpy, createTestingWorkspace, HOST_FACTORIES, jsonToString, TestingWorkspace } from "./utils.js";
+import { Context, Failure } from "@monorepolint/config";
+import { alphabeticalScripts } from "../alphabeticalScripts.js";
+import { createIncorrectOrderErrorMessage } from "../util/checkAlpha.js";
 
 const PACKAGE_SCRIPTS_SORTED = jsonToString({
+  name: "foo-lib",
   scripts: {
     a: "a-",
     b: "b-",
@@ -23,6 +22,7 @@ const PACKAGE_SCRIPTS_SORTED = jsonToString({
 });
 
 const PACKAGE_SCRIPTS_UNSORTED = jsonToString({
+  name: "foo-lib",
   scripts: {
     c: "c-",
     a: "a-",
@@ -30,43 +30,45 @@ const PACKAGE_SCRIPTS_UNSORTED = jsonToString({
   },
 });
 
-describe("alphabeticalScripts", () => {
-  afterEach(() => {
-    mockFiles.clear();
-  });
-
+describe.each(HOST_FACTORIES)("alphabeticalScripts ($name)", (hostFactory) => {
   describe("fix: true", () => {
-    const context = new PackageContext(".", {
-      rules: [],
-      fix: true,
-      verbose: false,
-      silent: true,
-    });
-    const spy = jest.spyOn(context, "addError");
-
-    afterEach(() => {
-      spy.mockClear();
+    let workspace: TestingWorkspace;
+    let spy: AddErrorSpy;
+    let context: Context;
+
+    beforeEach(async () => {
+      workspace = await createTestingWorkspace({
+        fixFlag: true,
+        host: hostFactory.make(),
+      });
+      context = workspace.context; // minimizing delta
+
+      spy = jest.spyOn(workspace.context, "addError");
     });
 
     it("fixes unsorted scripts", () => {
-      mockFiles.set("package.json", PACKAGE_SCRIPTS_UNSORTED);
+      workspace.writeFile("package.json", PACKAGE_SCRIPTS_UNSORTED);
 
-      alphabeticalScripts.check(context, undefined);
+      alphabeticalScripts({}).check(context);
 
       expect(spy).toHaveBeenCalledTimes(1);
 
       const failure: Failure = spy.mock.calls[0][0];
-      expect(failure.file).toBe("package.json");
-      expect(failure.fixer).not.toBeUndefined();
-      expect(failure.message).toBe("Incorrect order of scripts in package.json");
-
-      expect(mockFiles.get("package.json")).toEqual(PACKAGE_SCRIPTS_SORTED);
+      expect(failure).toMatchObject(
+        workspace.failureMatcher({
+          file: "package.json",
+          hasFixer: true,
+          message: createIncorrectOrderErrorMessage("scripts", "foo-lib"),
+        })
+      );
+
+      expect(workspace.readFile("package.json")).toEqual(PACKAGE_SCRIPTS_SORTED);
     });
 
     it("does nothing if already sorted", () => {
-      mockFiles.set("package.json", PACKAGE_SCRIPTS_SORTED);
+      workspace.writeFile("package.json", PACKAGE_SCRIPTS_SORTED);
 
-      alphabeticalScripts.check(context, undefined);
+      alphabeticalScripts({}).check(context);
 
       expect(spy).toHaveBeenCalledTimes(0);
     });

package/src/__tests__/bannedDependencies.spec.ts

@@ -0,0 +1,189 @@
+/*!
+ * Copyright 2020 Palantir Technologies, Inc.
+ *
+ * Licensed under the MIT license. See LICENSE file in the project root for details.
+ *
+ */
+import { describe, expect, it, beforeEach, jest, afterEach } from "@jest/globals";
+import { WorkspaceContextImpl } from "@monorepolint/core";
+import { SimpleHost } from "@monorepolint/utils";
+import { writeFileSync } from "fs";
+import * as path from "path";
+import * as tmp from "tmp";
+import { bannedDependencies, Options } from "../bannedDependencies.js";
+import { makeDirectoryRecursively } from "../util/makeDirectory.js";
+import { jsonToString } from "./utils.js";
+const EMPTY_PACKAGE = jsonToString({});
+
+describe("bannedDependencies", () => {
+  tmp.setGracefulCleanup();
+
+  let cleanupJobs: Array<() => void> = [];
+  let cwd: string | undefined;
+
+  beforeEach(() => {
+    const dir = tmp.dirSync({ unsafeCleanup: true });
+    cleanupJobs.push(() => dir.removeCallback());
+    cwd = dir.name;
+
+    const spy = jest.spyOn(process, "cwd");
+    spy.mockReturnValue(cwd);
+  });
+
+  afterEach(() => {
+    for (const cleanupJob of cleanupJobs) {
+      cleanupJob();
+    }
+    cleanupJobs = [];
+  });
+
+  function makeWorkspace() {
+    const workspaceContext = new WorkspaceContextImpl(
+      cwd!,
+      {
+        rules: [],
+        fix: false,
+        verbose: false,
+        silent: true,
+      },
+      new SimpleHost()
+    );
+
+    function checkAndSpy(options: Options) {
+      const addErrorSpy = jest.spyOn(workspaceContext, "addError");
+      bannedDependencies({ options }).check(workspaceContext);
+      return { addErrorSpy };
+    }
+
+    function addFile(filePath: string, content: string) {
+      const dirPath = path.resolve(cwd!, path.dirname(filePath));
+      const resolvedFilePath = path.resolve(cwd!, filePath);
+
+      makeDirectoryRecursively(dirPath);
+      writeFileSync(resolvedFilePath, content);
+      return resolvedFilePath;
+    }
+
+    return { addFile, workspaceContext, checkAndSpy };
+  }
+
+  it("Flags banned dependencies correctly", async () => {
+    const { addFile, checkAndSpy } = makeWorkspace();
+    const rootPackageJson = jsonToString({
+      dependencies: {
+        aaa: "0.0.1",
+        ccc: "0.0.1",
+      },
+    });
+    addFile("./package.json", rootPackageJson);
+
+    const { addErrorSpy: addErrorSpy1 } = checkAndSpy({ bannedDependencies: ["ccc"] });
+    expect(addErrorSpy1).toHaveBeenCalledTimes(1);
+    addErrorSpy1.mockReset();
+
+    const { addErrorSpy: addErrorSpy2 } = checkAndSpy({ bannedDependencies: ["ddd"] });
+    expect(addErrorSpy2).toHaveBeenCalledTimes(0);
+    addErrorSpy2.mockReset();
+
+    const { addErrorSpy: addErrorSpy3 } = checkAndSpy({ bannedDependencies: ["ccc", "ddd"] });
+    expect(addErrorSpy3).toHaveBeenCalledTimes(1);
+    addErrorSpy3.mockReset();
+  });
+
+  it("Flags banned dependencies correctly w legacy globs", async () => {
+    const { addFile, checkAndSpy } = makeWorkspace();
+    const rootPackageJson = jsonToString({
+      dependencies: {
+        aaa: "0.0.1",
+        ccc: "0.0.1",
+      },
+    });
+    addFile("./package.json", rootPackageJson);
+
+    const { addErrorSpy: addErrorSpy1 } = checkAndSpy({ bannedDependencies: ["c*c"] });
+    expect(addErrorSpy1).toHaveBeenCalledTimes(1);
+    addErrorSpy1.mockReset();
+
+    const { addErrorSpy: addErrorSpy2 } = checkAndSpy({ bannedDependencies: ["d*d"] });
+    expect(addErrorSpy2).toHaveBeenCalledTimes(0);
+    addErrorSpy2.mockReset();
+
+    const { addErrorSpy: addErrorSpy3 } = checkAndSpy({ bannedDependencies: ["c*c", "d*d"] });
+    expect(addErrorSpy3).toHaveBeenCalledTimes(1);
+    addErrorSpy3.mockReset();
+  });
+
+  it("Flags banned dependencies correctly w new globs", async () => {
+    const { addFile, checkAndSpy } = makeWorkspace();
+    const rootPackageJson = jsonToString({
+      dependencies: {
+        aaa: "0.0.1",
+        ccc: "0.0.1",
+      },
+    });
+    addFile("./package.json", rootPackageJson);
+
+    const { addErrorSpy: addErrorSpy1 } = checkAndSpy({ bannedDependencies: { glob: ["c*c"] } });
+    expect(addErrorSpy1).toHaveBeenCalledTimes(1);
+    addErrorSpy1.mockReset();
+
+    const { addErrorSpy: addErrorSpy2 } = checkAndSpy({ bannedDependencies: { glob: ["d*d"] } });
+    expect(addErrorSpy2).toHaveBeenCalledTimes(0);
+    addErrorSpy2.mockReset();
+
+    const { addErrorSpy: addErrorSpy3 } = checkAndSpy({ bannedDependencies: { glob: ["c*c", "d*d"] } });
+    expect(addErrorSpy3).toHaveBeenCalledTimes(1);
+    addErrorSpy3.mockReset();
+  });
+
+  it("Flags banned dependencies correctly w exact", async () => {
+    const { addFile, checkAndSpy } = makeWorkspace();
+    const rootPackageJson = jsonToString({
+      dependencies: {
+        aaa: "0.0.1",
+        ccc: "0.0.1",
+      },
+    });
+    addFile("./package.json", rootPackageJson);
+
+    const { addErrorSpy: addErrorSpy1 } = checkAndSpy({ bannedDependencies: { exact: ["ccc"] } });
+    expect(addErrorSpy1).toHaveBeenCalledTimes(1);
+    addErrorSpy1.mockReset();
+
+    const { addErrorSpy: addErrorSpy2 } = checkAndSpy({ bannedDependencies: { exact: ["ddd"] } });
+    expect(addErrorSpy2).toHaveBeenCalledTimes(0);
+    addErrorSpy2.mockReset();
+
+    const { addErrorSpy: addErrorSpy3 } = checkAndSpy({ bannedDependencies: { exact: ["ccc", "ddd"] } });
+    expect(addErrorSpy3).toHaveBeenCalledTimes(1);
+    addErrorSpy3.mockReset();
+  });
+
+  it("Flags banned transitives correctly", async () => {
+    const { addFile, checkAndSpy } = makeWorkspace();
+    const rootPackageJson = jsonToString({
+      dependencies: {
+        aaa: "0.0.1",
+      },
+    });
+    addFile("./package.json", rootPackageJson);
+
+    const aaaPackageJson = jsonToString({
+      dependencies: {
+        bbb: "0.0.1",
+        ccc: "0.0.1",
+      },
+    });
+    addFile("./node_modules/aaa/package.json", aaaPackageJson);
+    const bbbPackageJson = jsonToString({
+      dependencies: {
+        ddd: "0.0.1",
+      },
+    });
+    addFile("./node_modules/aaa/node_modules/bbb/package.json", bbbPackageJson);
+    addFile("./node_modules/aaa/node_modules/bbb/node_modules/ddd/package.json", EMPTY_PACKAGE);
+    addFile("./node_modules/aaa/node_modules/ccc/package.json", EMPTY_PACKAGE);
+
+    expect(checkAndSpy({ bannedTransitiveDependencies: ["ccc", "ddd"] }).addErrorSpy).toHaveBeenCalledTimes(2);
+  });
+});

package/src/__tests__/consistentDependencies.spec.ts

@@ -4,12 +4,15 @@
  * Licensed under the MIT license. See LICENSE file in the project root for details.
  *
  */
-import { WorkspaceContext } from "@monorepolint/core";
-import { existsSync, mkdirSync, readFileSync, writeFileSync } from "fs";
+import { WorkspaceContextImpl } from "@monorepolint/core";
+import { SimpleHost } from "@monorepolint/utils";
+import { readFileSync, writeFileSync } from "fs";
 import * as path from "path";
 import * as tmp from "tmp";
-import { consistentDependencies } from "../consistentDependencies";
-import { jsonToString } from "./utils";
+import { consistentDependencies, Options } from "../consistentDependencies.js";
+import { makeDirectoryRecursively } from "../util/makeDirectory.js";
+import { jsonToString } from "./utils.js";
+import { describe, expect, it, afterEach, jest } from "@jest/globals";
 
 const PACKAGE_ROOT = jsonToString({
   workspaces: {
@@ -26,6 +29,12 @@ const PACKAGE_CHILD_WITH_STAR = jsonToString({
   },
 });
 
+const PACKAGE_CHILD_WITH_LATEST = jsonToString({
+  dependencies: {
+    foo: "latest",
+  },
+});
+
 const PACKAGE_CHILD_WITH_RIGHT_VERSION = jsonToString({
   dependencies: {
     foo: "5",
@@ -51,20 +60,24 @@ describe("consistentDependencies", () => {
   });
 
   function makeWorkspace({ fix }: { fix: boolean }) {
-    const dir: tmp.DirResult = tmp.dirSync();
+    const dir: tmp.DirResult = tmp.dirSync({ unsafeCleanup: true });
     cleanupJobs.push(() => dir.removeCallback());
 
-    const workspaceContext = new WorkspaceContext(dir.name, {
-      rules: [],
-      fix,
-      verbose: false,
-      silent: true,
-    });
-
-    function checkAndSpy(q: string) {
+    const workspaceContext = new WorkspaceContextImpl(
+      dir.name,
+      {
+        rules: [],
+        fix,
+        verbose: false,
+        silent: true,
+      },
+      new SimpleHost()
+    );
+
+    function checkAndSpy(q: string, opts?: Options) {
       const context = workspaceContext.createChildContext(path.resolve(dir.name, q));
       const addErrorSpy = jest.spyOn(context, "addError");
-      consistentDependencies.check(context, undefined);
+      consistentDependencies({ options: opts }).check(context);
       return { context, addErrorSpy };
     }
 
@@ -72,17 +85,7 @@ describe("consistentDependencies", () => {
       const dirPath = path.resolve(dir.name, path.dirname(filePath));
       const resolvedFilePath = path.resolve(dir.name, filePath);
 
-      // node < 10 doesn't support mkdirSync w/ recursive: true
-      // so we manually do it instead
-      const dirSegments = dirPath.split(path.sep);
-      for (let i = 2; i <= dirSegments.length; i++) {
-        // we skip the empty segment
-        const curDirPath = dirSegments.slice(0, i).join(path.sep);
-        if (!existsSync(curDirPath)) {
-          mkdirSync(curDirPath);
-        }
-      }
-
+      makeDirectoryRecursively(dirPath);
       writeFileSync(resolvedFilePath, content);
     }
 
@@ -97,14 +100,18 @@ describe("consistentDependencies", () => {
     const { addFile, workspaceContext, checkAndSpy } = makeWorkspace({ fix: false });
     addFile("./package.json", PACKAGE_ROOT);
     addFile("./packages/star/package.json", PACKAGE_CHILD_WITH_STAR);
+    addFile("./packages/latest/package.json", PACKAGE_CHILD_WITH_LATEST);
     addFile("./packages/right/package.json", PACKAGE_CHILD_WITH_RIGHT_VERSION);
     addFile("./packages/wrong/package.json", PACKAGE_CHILD_WITH_WRONG_VERSION);
 
-    consistentDependencies.check(workspaceContext, undefined);
+    consistentDependencies({}).check(workspaceContext);
 
     const star = checkAndSpy("./packages/star");
     expect(star.addErrorSpy).toHaveBeenCalledTimes(0);
 
+    const latest = checkAndSpy("./packages/latest");
+    expect(latest.addErrorSpy).toHaveBeenCalledTimes(0);
+
     const right = checkAndSpy("./packages/right");
     expect(right.addErrorSpy).toHaveBeenCalledTimes(0);
 
@@ -123,4 +130,13 @@ describe("consistentDependencies", () => {
     const contents = readFile("./packages/wrong/package.json");
     expect(contents).toEqual(PACKAGE_CHILD_WITH_RIGHT_VERSION);
   });
+
+  it("ignores ignored dependencies", () => {
+    const { addFile, checkAndSpy } = makeWorkspace({ fix: false });
+    addFile("./package.json", PACKAGE_ROOT);
+    addFile("./packages/wrong/package.json", PACKAGE_CHILD_WITH_WRONG_VERSION);
+
+    const ignored = checkAndSpy("./packages/wrong", { ignoredDependencies: ["foo"] });
+    expect(ignored.addErrorSpy).toHaveBeenCalledTimes(0);
+  });
 });