@monoes/monodesign 1.2.18 → 1.2.22

package/skill/scripts/hook-admin.mjs

@@ -21,7 +21,6 @@
 
 import fs from 'node:fs';
 import path from 'node:path';
-import { MONODESIGN_COMMAND } from './lib/provider.mjs';
 
 import {
   getConfigPath,
@@ -29,241 +28,17 @@ import {
   getCachePath,
   getPendingPath,
   readConfig,
-  DEFAULT_CONFIG,
-  ensureHookGitExcludes,
-  normalizeIgnoreValue,
-  normalizeIgnoreValueEntries,
 } from './hook-lib.mjs';
+import {
+  readRawConfigFile,
+  readRawHookConfig,
+  mergeHookConfig,
+  writeHookConfig,
+} from './hook-admin-config.mjs';
+import { repairHookManifests } from './hook-admin-manifest.mjs';
+import { addIgnoreRule, addIgnoreFile, addIgnoreValue } from './hook-admin-ignore.mjs';
 
 const ACTIONS = new Set(['status', 'on', 'off', 'ignore-rule', 'ignore-file', 'ignore-value', 'reset']);
-const MONODESIGN_HOOK_COMMAND_MARKERS = [
-  'skills/monodesign/scripts/hook-probe.mjs',
-  'skills/monodesign/scripts/hook.mjs',
-  'skills/monodesign/scripts/hook-before-edit.mjs',
-  'skills/monodesign/scripts/hook-after-edit.mjs',
-  'skills/monodesign/scripts/hook-stop.mjs',
-];
-const TIMEOUT_SECONDS = 5;
-const STATUS_MESSAGE = 'Checking UI changes';
-
-const HOOK_MANIFEST_TARGETS = [
-  {
-    provider: '.claude',
-    skillRel: '.claude/skills/monodesign',
-    destRel: '.claude/settings.local.json',
-    sharedDestRel: '.claude/settings.json',
-    manifest: () => ({
-      description: 'Monodesign design detector: runs after Edit/Write/MultiEdit on UI files and surfaces findings as system reminders.',
-      hooks: {
-        PostToolUse: [
-          {
-            matcher: 'Edit|Write|MultiEdit',
-            hooks: [
-              {
-                type: 'command',
-                command: 'node "${CLAUDE_PROJECT_DIR}/.claude/skills/monodesign/scripts/hook.mjs"',
-                timeout: TIMEOUT_SECONDS,
-                statusMessage: STATUS_MESSAGE,
-              },
-            ],
-          },
-        ],
-      },
-    }),
-  },
-  {
-    provider: '.agents',
-    skillRel: '.agents/skills/monodesign',
-    destRel: '.codex/config.toml',
-    format: 'toml',
-    manifest: () => [
-      '# monodesign:start native-hook',
-      '[[hooks.PostToolUse]]',
-      'matcher = "Edit|Write|apply_patch"',
-      '[[hooks.PostToolUse.hooks]]',
-      'type = "command"',
-      'command = "node .agents/skills/monodesign/scripts/hook.mjs"',
-      `timeout = ${TIMEOUT_SECONDS}`,
-      `statusMessage = "${STATUS_MESSAGE}"`,
-      '# monodesign:end native-hook',
-      '',
-    ].join('\n'),
-  },
-  {
-    provider: '.cursor',
-    skillRel: '.cursor/skills/monodesign',
-    destRel: '.cursor/hooks.json',
-    manifest: () => ({
-      version: 1,
-      hooks: {
-        preToolUse: [
-          {
-            command: 'node ".cursor/skills/monodesign/scripts/hook-before-edit.mjs"',
-            timeout: TIMEOUT_SECONDS,
-          },
-        ],
-      },
-    }),
-  },
-  {
-    // GitHub Copilot reads repo-level hooks from `.github/hooks/*.json`. The same
-    // manifest is honored by the CLI (once committed to the default branch) and
-    // the cloud/app agent. Schema differs: lowercase `postToolUse`, flat entries,
-    // `bash`/`timeoutSec`, and a `matcher` regex against the `edit`/`create` tools.
-    provider: '.github',
-    skillRel: '.github/skills/monodesign',
-    destRel: '.github/hooks/monodesign.json',
-    manifest: () => ({
-      version: 1,
-      hooks: {
-        postToolUse: [
-          {
-            type: 'command',
-            matcher: 'edit|create|apply_patch',
-            bash: 'node "$(git rev-parse --show-toplevel)/.github/skills/monodesign/scripts/hook.mjs"',
-            timeoutSec: TIMEOUT_SECONDS,
-          },
-        ],
-      },
-    }),
-  },
-];
-
-function readRawConfigFile(filePath) {
-  if (!fs.existsSync(filePath)) return { exists: false, malformed: false, raw: null };
-  try {
-    return { exists: true, malformed: false, raw: JSON.parse(fs.readFileSync(filePath, 'utf-8')) };
-  } catch {
-    return { exists: true, malformed: true, raw: null };
-  }
-}
-
-const DETECTOR_CONFIG_KEYS = new Set(['ignoreRules', 'ignoreFiles', 'ignoreValues', 'designSystem']);
-
-function hookSection(unified) {
-  return unified && typeof unified === 'object' && !Array.isArray(unified) && unified.hook && typeof unified.hook === 'object' && !Array.isArray(unified.hook)
-    ? unified.hook
-    : null;
-}
-
-function detectorSection(unified) {
-  return unified && typeof unified === 'object' && !Array.isArray(unified) && unified.detector && typeof unified.detector === 'object' && !Array.isArray(unified.detector)
-    ? unified.detector
-    : null;
-}
-
-function readRawHookConfig(cwd, opts = {}) {
-  const unified = readRawConfigFile(opts.local ? getLocalConfigPath(cwd) : getConfigPath(cwd)).raw;
-  return hookSection(unified);
-}
-
-function readRawDetectorConfig(cwd, opts = {}) {
-  const unified = readRawConfigFile(opts.local ? getLocalConfigPath(cwd) : getConfigPath(cwd)).raw;
-  const merged = mergeDetectorConfig(hookSection(unified));
-  return mergeDetectorConfig(detectorSection(unified), merged);
-}
-
-function stripDetectorKeys(raw) {
-  if (!raw || typeof raw !== 'object' || Array.isArray(raw)) return {};
-  const out = {};
-  for (const [key, value] of Object.entries(raw)) {
-    if (!DETECTOR_CONFIG_KEYS.has(key)) out[key] = value;
-  }
-  return out;
-}
-
-// Write hook runtime config under `hook`, leaving detector filters in
-// `detector` and preserving sibling keys such as updateCheck.
-function writeHookConfig(cwd, hookConfig, opts = {}) {
-  const filePath = opts.local ? getLocalConfigPath(cwd) : getConfigPath(cwd);
-  if (opts.local) ensureHookGitExcludes(cwd);
-  const existingRaw = readRawConfigFile(filePath).raw;
-  const existing = existingRaw && typeof existingRaw === 'object' && !Array.isArray(existingRaw) ? existingRaw : {};
-  const existingHook = stripDetectorKeys(hookSection(existing));
-  // Merge over the existing hook object so fields the merge helpers don't manage
-  // (consent, quiet, auditLog) survive an Monodesign hooks edit.
-  const next = { ...existing, hook: { ...existingHook, ...hookConfig } };
-  fs.mkdirSync(path.dirname(filePath), { recursive: true });
-  fs.writeFileSync(filePath, `${JSON.stringify(next, null, 2)}\n`);
-  return filePath;
-}
-
-function writeDetectorConfig(cwd, detectorConfig, opts = {}) {
-  const filePath = opts.local ? getLocalConfigPath(cwd) : getConfigPath(cwd);
-  if (opts.local) ensureHookGitExcludes(cwd);
-  const existingRaw = readRawConfigFile(filePath).raw;
-  const existing = existingRaw && typeof existingRaw === 'object' && !Array.isArray(existingRaw) ? existingRaw : {};
-  const nextHook = stripDetectorKeys(hookSection(existing));
-  const existingDetector = mergeDetectorConfig(detectorSection(existing));
-  const next = {
-    ...existing,
-    detector: mergeDetectorConfig(detectorConfig, existingDetector),
-  };
-  if (Object.keys(nextHook).length > 0) next.hook = nextHook;
-  else delete next.hook;
-  fs.mkdirSync(path.dirname(filePath), { recursive: true });
-  fs.writeFileSync(filePath, `${JSON.stringify(next, null, 2)}\n`);
-  return filePath;
-}
-
-function mergeHookConfig(existing) {
-  const base = existing && typeof existing === 'object' ? existing : {};
-  return {
-    enabled: base.enabled !== false,
-    limits: {
-      maxFindings: Number.isFinite(base?.limits?.maxFindings) ? base.limits.maxFindings : DEFAULT_CONFIG.limits.maxFindings,
-      maxChars: Number.isFinite(base?.limits?.maxChars) ? base.limits.maxChars : DEFAULT_CONFIG.limits.maxChars,
-    },
-  };
-}
-
-function mergeDetectorConfig(existing, seed = null) {
-  const base = existing && typeof existing === 'object' ? existing : {};
-  const out = seed ? {
-    ignoreRules: [...seed.ignoreRules],
-    ignoreFiles: [...seed.ignoreFiles],
-    ignoreValues: normalizeIgnoreValueEntries(seed.ignoreValues),
-  } : {
-    ignoreRules: [],
-    ignoreFiles: [],
-    ignoreValues: [],
-  };
-  if (seed?.designSystem && typeof seed.designSystem === 'object' && !Array.isArray(seed.designSystem)) {
-    out.designSystem = { ...seed.designSystem };
-  }
-  if (base.designSystem && typeof base.designSystem === 'object' && !Array.isArray(base.designSystem)) {
-    out.designSystem = {
-      ...(out.designSystem || {}),
-      enabled: base.designSystem.enabled !== false,
-    };
-  }
-  if (Array.isArray(base.ignoreRules)) {
-    out.ignoreRules = Array.from(new Set([...out.ignoreRules, ...base.ignoreRules.map(String)]));
-  }
-  if (Array.isArray(base.ignoreFiles)) {
-    out.ignoreFiles = Array.from(new Set([...out.ignoreFiles, ...base.ignoreFiles.map(String)]));
-  }
-  if (Array.isArray(base.ignoreValues)) {
-    out.ignoreValues = mergeIgnoreValueEntries(out.ignoreValues, base.ignoreValues);
-  }
-  return out;
-}
-
-function mergeIgnoreValueEntries(existing, incoming) {
-  const map = new Map();
-  for (const entry of normalizeIgnoreValueEntries(existing)) {
-    map.set(ignoreValueEntryKey(entry), entry);
-  }
-  for (const entry of normalizeIgnoreValueEntries(incoming)) {
-    map.set(ignoreValueEntryKey(entry), entry);
-  }
-  return Array.from(map.values());
-}
-
-function ignoreValueEntryKey(entry) {
-  const files = Array.isArray(entry.files) && entry.files.length > 0 ? entry.files.join('\x1f') : '';
-  return `${entry.rule}\0${entry.value}\0${files}`;
-}
 
 function statusReport(cwd) {
   const shared = readRawConfigFile(getConfigPath(cwd));
@@ -324,314 +99,6 @@ function setEnabled(cwd, value) {
   return parts.join(' ');
 }
 
-function repairHookManifests(cwd) {
-  const result = { written: [], already: [], backups: [] };
-  for (const target of HOOK_MANIFEST_TARGETS) {
-    if (!fs.existsSync(path.join(cwd, target.skillRel))) continue;
-    const dest = path.join(cwd, target.destRel);
-    const sharedDest = target.sharedDestRel ? path.join(cwd, target.sharedDestRel) : null;
-
-    if (target.format === 'toml') {
-      const current = fs.existsSync(dest) ? safeReadText(dest) : '';
-      const next = mergeCodexHookConfig(current || '', target.manifest());
-      if (current === next) {
-        result.already.push(target.provider);
-        continue;
-      }
-      fs.mkdirSync(path.dirname(dest), { recursive: true });
-      fs.writeFileSync(dest, next);
-      result.written.push(target.provider);
-      continue;
-    }
-
-    if (sharedDest && fileHasMonodesignHookMarker(sharedDest)) {
-      pruneMonodesignHookFromManifest(dest);
-      result.already.push(target.provider);
-      continue;
-    }
-
-    const fresh = target.manifest();
-    let next = fresh;
-    if (fs.existsSync(dest)) {
-      try {
-        next = mergeHookManifests(JSON.parse(fs.readFileSync(dest, 'utf-8')), fresh);
-      } catch {
-        const backup = `${dest}.bak`;
-        fs.copyFileSync(dest, backup);
-        result.backups.push(backup);
-      }
-    }
-
-    const serialized = `${JSON.stringify(next, null, 2)}\n`;
-    const current = fs.existsSync(dest) ? safeReadText(dest) : null;
-    if (current === serialized) {
-      result.already.push(target.provider);
-      continue;
-    }
-    fs.mkdirSync(path.dirname(dest), { recursive: true });
-    fs.writeFileSync(dest, serialized);
-    result.written.push(target.provider);
-  }
-  return result;
-}
-
-function mergeCodexHookConfig(existing, hookBlock) {
-  const completeBlock = /# monodesign:start native-hook[\s\S]*?# monodesign:end native-hook\n?/m;
-  const incompleteBlock = /# monodesign:start native-hook[\s\S]*$/m;
-  let merged = existing;
-  if (completeBlock.test(merged)) merged = merged.replace(completeBlock, hookBlock);
-  else if (incompleteBlock.test(merged)) merged = merged.replace(incompleteBlock, hookBlock);
-  else merged = `${merged.trimEnd()}${merged.trim() ? '\n\n' : ''}${hookBlock}`;
-  return enableCodexHooks(merged);
-}
-
-function enableCodexHooks(config) {
-  if (!/^\[features\]\s*$/m.test(config)) {
-    return `[features]\nhooks = true\n\n${config}`;
-  }
-  const lines = config.split(/\r?\n/);
-  const start = lines.findIndex((line) => /^\[features\]\s*$/.test(line));
-  let end = start + 1;
-  while (end < lines.length && !/^\[\[?[^\]]+\]\]?\s*$/.test(lines[end])) end++;
-  const hookIndex = lines.slice(start + 1, end).findIndex((line) => /^hooks\s*=/.test(line));
-  if (hookIndex === -1) lines.splice(end, 0, 'hooks = true');
-  else lines[start + 1 + hookIndex] = 'hooks = true';
-  return lines.join('\n');
-}
-
-function safeReadText(filePath) {
-  try {
-    return fs.readFileSync(filePath, 'utf-8');
-  } catch {
-    return null;
-  }
-}
-
-function mergeHookManifests(existing, fresh) {
-  const existingObject = existing && typeof existing === 'object' && !Array.isArray(existing) ? existing : {};
-  const freshObject = fresh && typeof fresh === 'object' && !Array.isArray(fresh) ? fresh : {};
-  const existingHooks = existingObject.hooks && typeof existingObject.hooks === 'object' && !Array.isArray(existingObject.hooks)
-    ? existingObject.hooks
-    : {};
-  const freshHooks = freshObject.hooks && typeof freshObject.hooks === 'object' && !Array.isArray(freshObject.hooks)
-    ? freshObject.hooks
-    : {};
-
-  const merged = { ...existingObject, hooks: {} };
-  if (freshObject.version !== undefined) merged.version = freshObject.version;
-  if (freshObject.description !== undefined) merged.description = freshObject.description;
-
-  const hookEvents = new Set([...Object.keys(existingHooks), ...Object.keys(freshHooks)]);
-  for (const event of hookEvents) {
-    const preserved = stripMonodesignHookEntries(existingHooks[event]);
-    const added = Array.isArray(freshHooks[event]) ? freshHooks[event] : [];
-    const mergedEntries = [...preserved, ...added];
-    if (mergedEntries.length > 0) merged.hooks[event] = mergedEntries;
-  }
-  return merged;
-}
-
-function fileHasMonodesignHookMarker(filePath) {
-  if (!fs.existsSync(filePath)) return false;
-  let parsed;
-  try {
-    parsed = JSON.parse(fs.readFileSync(filePath, 'utf-8'));
-  } catch {
-    return false;
-  }
-  if (!parsed || typeof parsed !== 'object' || Array.isArray(parsed)) return false;
-  if (!parsed.hooks || typeof parsed.hooks !== 'object') return false;
-  return valueHasMonodesignHookMarker(parsed.hooks);
-}
-
-function valueHasMonodesignHookMarker(value) {
-  if (typeof value === 'string') {
-    return MONODESIGN_HOOK_COMMAND_MARKERS.some((marker) => value.includes(marker));
-  }
-  if (Array.isArray(value)) return value.some(valueHasMonodesignHookMarker);
-  if (value && typeof value === 'object') return Object.values(value).some(valueHasMonodesignHookMarker);
-  return false;
-}
-
-function stripMonodesignHookEntry(entry) {
-  if (!entry || typeof entry !== 'object') return entry;
-  // `command`/`args`: Claude/Codex/Cursor. `bash`/`powershell`: GitHub Copilot's
-  // flat entry shape, where the marker lives under the shell-command keys.
-  if (valueHasMonodesignHookMarker(entry.command) || valueHasMonodesignHookMarker(entry.args)
-    || valueHasMonodesignHookMarker(entry.bash) || valueHasMonodesignHookMarker(entry.powershell)) {
-    return null;
-  }
-  if (!Array.isArray(entry.hooks)) return entry;
-
-  const strippedHooks = entry.hooks
-    .map(stripMonodesignHookEntry)
-    .filter(Boolean);
-
-  if (strippedHooks.length === 0 && entry.hooks.some(valueHasMonodesignHookMarker)) {
-    return null;
-  }
-  return { ...entry, hooks: strippedHooks };
-}
-
-function stripMonodesignHookEntries(entries) {
-  if (!Array.isArray(entries)) return [];
-  return entries
-    .map(stripMonodesignHookEntry)
-    .filter(Boolean);
-}
-
-function pruneMonodesignHookFromManifest(manifestPath) {
-  if (!fileHasMonodesignHookMarker(manifestPath)) return false;
-  let parsed;
-  try {
-    parsed = JSON.parse(fs.readFileSync(manifestPath, 'utf-8'));
-  } catch {
-    return false;
-  }
-
-  const existingHooks = parsed.hooks && typeof parsed.hooks === 'object' && !Array.isArray(parsed.hooks)
-    ? parsed.hooks
-    : {};
-  const cleanedHooks = {};
-  for (const [event, entries] of Object.entries(existingHooks)) {
-    const kept = stripMonodesignHookEntries(entries);
-    if (kept.length > 0) cleanedHooks[event] = kept;
-  }
-
-  const next = { ...parsed };
-  if (Object.keys(cleanedHooks).length > 0) {
-    next.hooks = cleanedHooks;
-  } else {
-    delete next.hooks;
-    delete next.description;
-    delete next.version;
-  }
-
-  if (Object.keys(next).length === 0) {
-    fs.rmSync(manifestPath, { force: true });
-  } else {
-    fs.writeFileSync(manifestPath, `${JSON.stringify(next, null, 2)}\n`);
-  }
-  return true;
-}
-
-function normalizeRuleId(rule) {
-  return String(rule || '').trim().toLowerCase();
-}
-
-function parseIgnoreRuleArgs(args) {
-  const positionals = [];
-  let allValues = false;
-
-  for (let i = 0; i < args.length; i++) {
-    const arg = String(args[i] || '');
-    if (arg === '--all-values') {
-      allValues = true;
-    } else if (arg === '--reason') {
-      while (i + 1 < args.length && !String(args[i + 1]).startsWith('--')) i++;
-    } else if (arg.startsWith('--reason=')) {
-      // Accepted for command symmetry; ignoreRules stores rule ids only.
-    } else if (arg.startsWith('--')) {
-      throw new Error(`Unknown ignore-rule flag: ${arg}`);
-    } else {
-      positionals.push(arg);
-    }
-  }
-
-  return {
-    rule: normalizeRuleId(positionals[0]),
-    allValues,
-  };
-}
-
-function addIgnoreRule(cwd, args) {
-  const parsed = parseIgnoreRuleArgs(args);
-  const rule = parsed.rule;
-  if (!rule) throw new Error(`Pass a rule id, e.g. ${MONODESIGN_COMMAND} hooks ignore-rule side-tab`);
-  if (rule === 'overused-font' && !parsed.allValues) {
-    throw new Error(`overused-font is value-specific by default. Use ${MONODESIGN_COMMAND} hooks ignore-value overused-font <font> for a confirmed font, or ${MONODESIGN_COMMAND} hooks ignore-rule overused-font --all-values only when the user asked to ignore overused fonts generally.`);
-  }
-  const config = mergeDetectorConfig(readRawDetectorConfig(cwd));
-  if (!config.ignoreRules.includes(rule)) config.ignoreRules.push(rule);
-  writeDetectorConfig(cwd, config);
-  return `Added "${rule}" to detector.ignoreRules. Current: ${config.ignoreRules.join(', ')}`;
-}
-
-function addIgnoreFile(cwd, glob) {
-  if (!glob) throw new Error(`Pass a glob, e.g. ${MONODESIGN_COMMAND} hooks ignore-file "src/legacy/**"`);
-  const config = mergeDetectorConfig(readRawDetectorConfig(cwd));
-  if (!config.ignoreFiles.includes(glob)) config.ignoreFiles.push(glob);
-  writeDetectorConfig(cwd, config);
-  return `Added "${glob}" to detector.ignoreFiles. Current: ${config.ignoreFiles.join(', ')}`;
-}
-
-function parseIgnoreValueArgs(args) {
-  const positionals = [];
-  let shared = false;
-  let local = false;
-  let reason = '';
-
-  for (let i = 0; i < args.length; i++) {
-    const arg = args[i];
-    if (arg === '--shared') {
-      shared = true;
-    } else if (arg === '--local') {
-      local = true;
-    } else if (arg === '--reason') {
-      const chunks = [];
-      while (i + 1 < args.length && !String(args[i + 1]).startsWith('--')) {
-        chunks.push(args[++i]);
-      }
-      reason = chunks.join(' ').trim();
-    } else if (String(arg).startsWith('--reason=')) {
-      reason = String(arg).slice('--reason='.length).trim();
-    } else {
-      positionals.push(arg);
-    }
-  }
-
-  const [rule, ...valueParts] = positionals;
-  return {
-    rule: String(rule || '').trim().toLowerCase(),
-    value: normalizeIgnoreValue(valueParts.join(' ')),
-    shared,
-    local,
-    reason,
-  };
-}
-
-function addIgnoreValue(cwd, args) {
-  const parsed = parseIgnoreValueArgs(args);
-  if (!parsed.rule || !parsed.value) {
-    throw new Error(`Pass a rule id and value, e.g. ${MONODESIGN_COMMAND} hooks ignore-value overused-font Inter`);
-  }
-
-  if (parsed.shared && parsed.local) {
-    throw new Error('Pass only one scope flag: --shared or --local');
-  }
-
-  const local = parsed.local;
-  const config = mergeDetectorConfig(readRawDetectorConfig(cwd, { local }));
-  const key = `${parsed.rule}\0${parsed.value}`;
-  const existing = config.ignoreValues.find((entry) => `${entry.rule}\0${entry.value}` === key);
-
-  if (existing) {
-    if (parsed.reason) existing.reason = parsed.reason;
-  } else {
-    const entry = {
-      rule: parsed.rule,
-      value: parsed.value,
-      createdAt: new Date().toISOString(),
-    };
-    if (parsed.reason) entry.reason = parsed.reason;
-    config.ignoreValues.push(entry);
-  }
-
-  const target = writeDetectorConfig(cwd, config, { local });
-  const scope = local ? 'local detector.ignoreValues' : 'shared detector.ignoreValues';
-  return `Added ${parsed.rule}=${parsed.value} to ${scope} (${path.relative(cwd, target).split(path.sep).join('/') || target}).`;
-}
-
 function reset(cwd) {
   const removed = [];
   // Unified files may hold non-hook keys (e.g. updateCheck); strip only the