@monoes/monobrowse 2.24.1 → 2.24.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@monoes/monobrowse",
-  "version": "2.24.1",
+  "version": "2.24.2",
   "description": "Native browser automation via Chrome DevTools Protocol — the engine powering monomind browse",
   "type": "module",
   "bin": {
@@ -37,13 +37,6 @@
   "engines": {
     "node": ">=22.12.0"
   },
-  "scripts": {
-    "build": "tsc && node ../../../scripts/build-fs.mjs copy-into dist/src/browser/dashboard src/browser/dashboard/ui.html",
-    "test": "vitest run",
-    "test:coverage": "vitest run --coverage",
-    "prebuild": "node ../../../scripts/build-fs.mjs clean dist tsconfig.tsbuildinfo",
-    "prepublishOnly": "npm run build"
-  },
   "keywords": [
     "browser-automation",
     "cdp",
@@ -70,5 +63,11 @@
   "devDependencies": {
     "typescript": "^7.0.2",
     "vitest": "^4.1.4"
+  },
+  "scripts": {
+    "build": "tsc && node ../../../scripts/build-fs.mjs copy-into dist/src/browser/dashboard src/browser/dashboard/ui.html",
+    "test": "vitest run",
+    "test:coverage": "vitest run --coverage",
+    "prebuild": "node ../../../scripts/build-fs.mjs clean dist tsconfig.tsbuildinfo"
   }
-}
+}

package/src/__tests__/open-url-navigate-error.test.ts

@@ -54,3 +54,36 @@ describe('openUrl navigation-failure detection', () => {
     expect(calls).toHaveLength(0);
   });
 });
+
+describe('openUrl on a page with a persistent connection (#670)', () => {
+  it('resolves once the page has loaded even though the network never goes idle', async () => {
+    vi.useFakeTimers();
+    try {
+      const handlers = new Map<string, (p: Record<string, unknown>, sid?: string) => void>();
+      const client = {
+        send: vi.fn(async (method: string) => {
+          if (method === 'Page.navigate') return { frameId: 'f1' };
+          if (method === 'Runtime.evaluate') return { result: { value: true } };
+          return {};
+        }),
+        on: vi.fn((event: string, fn: (p: Record<string, unknown>, sid?: string) => void) => {
+          handlers.set(event, fn);
+          // An SSE/long-poll request that never finishes.
+          if (event === 'Network.requestWillBeSent') {
+            queueMicrotask(() => fn({ requestId: 'sse' }, 'sess-1'));
+          }
+          return () => handlers.delete(event);
+        }),
+      } as unknown as CdpClient;
+
+      const done = openUrl(client, 'sess-1', 'http://127.0.0.1:1/login').then(
+        () => 'ok',
+        (e: Error) => e.message,
+      );
+      await vi.advanceTimersByTimeAsync(31_000);
+      await expect(done).resolves.toBe('ok');
+    } finally {
+      vi.useRealTimers();
+    }
+  });
+});

package/src/browser/browser-page.ts

@@ -58,7 +58,11 @@ export async function openUrl(client: CdpClient, sessionId: string, url: string)
   // connection previously reported success against that error page.
   const nav = await client.send<{ errorText?: string }>('Page.navigate', { url }, sessionId);
   if (nav.errorText) throw new Error(`Navigation to ${url} failed: ${nav.errorText}`);
-  await waitForNetworkIdle(client, sessionId, 500, 30_000);
+  await waitForLoad(client, sessionId, 'load', 30_000);
+  // Best-effort settle for SPAs that keep fetching after `load`. A page holding
+  // an SSE/long-poll connection (e.g. the monomind dashboard) never goes idle,
+  // so a timeout here is not a failure (#670).
+  await waitForNetworkIdle(client, sessionId, 500, 5_000).catch(() => undefined);
 }
 
 export async function waitForLoad(