@mondaydotcomorg/z2h-cli 0.11.0 → 0.11.1

package/dist/esm/util/git/repo.mjs

@@ -26,7 +26,7 @@ function defaultS3Remote(app) {
 async function initRepo(dir, remote) {
     await ensureGitignore(dir);
     await execGit(['init', '-b', 'master'], dir);
-    await overrideGlobalHooks(dir);
+    await disableLocalHooks(dir);
     await execGit(['add', '.'], dir);
     await execGit(['commit', '-m', 'Initial commit'], dir);
     await execGit(['remote', 'add', 'origin', remote], dir);
@@ -49,7 +49,7 @@ async function guardCleanTree(dir) {
 }
 async function cloneRepo(remote, dir, env = {}) {
     await execa('git', ['clone', remote, dir], { env: { ...process.env, ...env } });
-    await overrideGlobalHooks(dir);
+    await disableLocalHooks(dir);
 }
 async function safeBackupIfDirty(dir) {
     let status;
@@ -136,25 +136,17 @@ async function gatherConflictInfo(dir, gitEnv) {
     return { localCommits, remoteCommits, conflictingFiles };
 }
 /**
- * If the user has a global core.hooksPath (e.g. ~/.global-git-hooks with a
- * prevent-push-to-master script), override it locally so Z2H's non-interactive
- * pushes aren't blocked. Other repos on the machine stay protected.
+ * Z2H repos are agent-driven and non-interactive — git hooks (whether from
+ * global core.hooksPath, init.templateDir, or manually placed .git/hooks/*)
+ * serve no purpose and break non-interactive pushes. Point core.hooksPath to an
+ * empty local directory so all hook sources are bypassed for this repo only.
  */
-async function overrideGlobalHooks(dir) {
+async function disableLocalHooks(dir) {
     if (await fs.pathExists(path.join(dir, LOCAL_HOOKS_DIR))) {
         return;
     }
-    const globalHooksPath = await execGit(['config', '--global', 'core.hooksPath'], dir)
-        .then(r => r.stdout.trim())
-        .catch(() => '');
-    if (!globalHooksPath) {
-        return;
-    }
     await fs.ensureDir(path.join(dir, LOCAL_HOOKS_DIR));
     await execGit(['config', '--local', 'core.hooksPath', LOCAL_HOOKS_DIR], dir);
-    // eslint-disable-next-line no-console
-    console.warn(`⚠️  Detected global git hooks at ${globalHooksPath}\n` +
-        `   Overriding locally for this Z2H project (your other repos are unaffected).`);
 }
 async function ensureGitignore(dir) {
     const gitignorePath = path.join(dir, '.gitignore');

package/dist/util/git/repo.js

@@ -33,7 +33,7 @@ function defaultS3Remote(app) {
 async function initRepo(dir, remote) {
     await ensureGitignore(dir);
     await execGit(['init', '-b', 'master'], dir);
-    await overrideGlobalHooks(dir);
+    await disableLocalHooks(dir);
     await execGit(['add', '.'], dir);
     await execGit(['commit', '-m', 'Initial commit'], dir);
     await execGit(['remote', 'add', 'origin', remote], dir);
@@ -56,7 +56,7 @@ async function guardCleanTree(dir) {
 }
 async function cloneRepo(remote, dir, env = {}) {
     await execa.execa('git', ['clone', remote, dir], { env: { ...process.env, ...env } });
-    await overrideGlobalHooks(dir);
+    await disableLocalHooks(dir);
 }
 async function safeBackupIfDirty(dir) {
     let status;
@@ -143,25 +143,17 @@ async function gatherConflictInfo(dir, gitEnv) {
     return { localCommits, remoteCommits, conflictingFiles };
 }
 /**
- * If the user has a global core.hooksPath (e.g. ~/.global-git-hooks with a
- * prevent-push-to-master script), override it locally so Z2H's non-interactive
- * pushes aren't blocked. Other repos on the machine stay protected.
+ * Z2H repos are agent-driven and non-interactive — git hooks (whether from
+ * global core.hooksPath, init.templateDir, or manually placed .git/hooks/*)
+ * serve no purpose and break non-interactive pushes. Point core.hooksPath to an
+ * empty local directory so all hook sources are bypassed for this repo only.
  */
-async function overrideGlobalHooks(dir) {
+async function disableLocalHooks(dir) {
     if (await fs__default.default.pathExists(path__default.default.join(dir, LOCAL_HOOKS_DIR))) {
         return;
     }
-    const globalHooksPath = await execGit(['config', '--global', 'core.hooksPath'], dir)
-        .then(r => r.stdout.trim())
-        .catch(() => '');
-    if (!globalHooksPath) {
-        return;
-    }
     await fs__default.default.ensureDir(path__default.default.join(dir, LOCAL_HOOKS_DIR));
     await execGit(['config', '--local', 'core.hooksPath', LOCAL_HOOKS_DIR], dir);
-    // eslint-disable-next-line no-console
-    console.warn(`⚠️  Detected global git hooks at ${globalHooksPath}\n` +
-        `   Overriding locally for this Z2H project (your other repos are unaffected).`);
 }
 async function ensureGitignore(dir) {
     const gitignorePath = path__default.default.join(dir, '.gitignore');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mondaydotcomorg/z2h-cli",
-  "version": "0.11.0",
+  "version": "0.11.1",
   "bin": "./bin/z2h-cli.js",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",

package/src/util/git/__tests__/repo.test.ts

@@ -53,7 +53,7 @@ describe('defaultS3Remote', () => {
 describe('cloneRepo', () => {
   it('calls git clone with correct args', async () => {
     mockExeca.mockResolvedValueOnce(execaOk()); // git clone
-    mockExeca.mockRejectedValueOnce(new Error('no global hooksPath')); // git config --global (no override needed)
+    mockExeca.mockResolvedValueOnce(execaOk()); // git config --local core.hooksPath
     await cloneRepo('s3://bucket/my-app/git', DIR);
     expect(mockExeca).toHaveBeenCalledWith(
       'git',
@@ -64,15 +64,14 @@ describe('cloneRepo', () => {
 
   it('merges supplied env into process.env for git subprocess', async () => {
     mockExeca.mockResolvedValueOnce(execaOk()); // git clone
-    mockExeca.mockRejectedValueOnce(new Error('no global hooksPath')); // git config --global
+    mockExeca.mockResolvedValueOnce(execaOk()); // git config --local core.hooksPath
     await cloneRepo('s3://bucket/my-app/git', DIR, { AWS_ACCESS_KEY_ID: 'KEY' });
     const opts = (mockExeca.mock.calls[0] as unknown as unknown[])[2] as { env: Record<string, string> };
     expect(opts.env['AWS_ACCESS_KEY_ID']).toBe('KEY');
   });
 
-  it('overrides global hooks locally when core.hooksPath is set', async () => {
+  it('disables hooks locally after clone', async () => {
     mockExeca.mockResolvedValueOnce(execaOk()); // git clone
-    mockExeca.mockResolvedValueOnce(execaOk('/Users/dev/.global-git-hooks')); // git config --global core.hooksPath
     mockExeca.mockResolvedValueOnce(execaOk()); // git config --local core.hooksPath
     await cloneRepo('s3://bucket/my-app/git', DIR);
     expect(mockExeca).toHaveBeenCalledWith(
@@ -81,6 +80,13 @@ describe('cloneRepo', () => {
       expect.objectContaining({})
     );
   });
+
+  it('skips disabling hooks when .zth/hooks already exists', async () => {
+    mockExeca.mockResolvedValueOnce(execaOk()); // git clone
+    mockFs.pathExists.mockResolvedValueOnce(true as never); // .zth/hooks exists
+    await cloneRepo('s3://bucket/my-app/git', DIR);
+    expect(mockExeca).toHaveBeenCalledTimes(1); // only the clone call
+  });
 });
 
 // ── guardCleanTree ───────────────────────────────────────────────────────────

package/src/util/git/repo.ts

@@ -39,7 +39,7 @@ export function defaultS3Remote(app: string): string {
 export async function initRepo(dir: string, remote: string): Promise<void> {
   await ensureGitignore(dir);
   await execGit(['init', '-b', 'master'], dir);
-  await overrideGlobalHooks(dir);
+  await disableLocalHooks(dir);
   await execGit(['add', '.'], dir);
   await execGit(['commit', '-m', 'Initial commit'], dir);
   await execGit(['remote', 'add', 'origin', remote], dir);
@@ -65,7 +65,7 @@ export async function guardCleanTree(dir: string): Promise<void> {
 
 export async function cloneRepo(remote: string, dir: string, env: Record<string, string> = {}): Promise<void> {
   await execa('git', ['clone', remote, dir], { env: { ...process.env, ...env } });
-  await overrideGlobalHooks(dir);
+  await disableLocalHooks(dir);
 }
 
 export async function safeBackupIfDirty(dir: string): Promise<void> {
@@ -158,31 +158,18 @@ async function gatherConflictInfo(dir: string, gitEnv?: GitEnv): Promise<Conflic
 }
 
 /**
- * If the user has a global core.hooksPath (e.g. ~/.global-git-hooks with a
- * prevent-push-to-master script), override it locally so Z2H's non-interactive
- * pushes aren't blocked. Other repos on the machine stay protected.
+ * Z2H repos are agent-driven and non-interactive — git hooks (whether from
+ * global core.hooksPath, init.templateDir, or manually placed .git/hooks/*)
+ * serve no purpose and break non-interactive pushes. Point core.hooksPath to an
+ * empty local directory so all hook sources are bypassed for this repo only.
  */
-async function overrideGlobalHooks(dir: string): Promise<void> {
+async function disableLocalHooks(dir: string): Promise<void> {
   if (await fs.pathExists(path.join(dir, LOCAL_HOOKS_DIR))) {
     return;
   }
 
-  const globalHooksPath = await execGit(['config', '--global', 'core.hooksPath'], dir)
-    .then(r => r.stdout.trim())
-    .catch(() => '');
-
-  if (!globalHooksPath) {
-    return;
-  }
-
   await fs.ensureDir(path.join(dir, LOCAL_HOOKS_DIR));
   await execGit(['config', '--local', 'core.hooksPath', LOCAL_HOOKS_DIR], dir);
-
-  // eslint-disable-next-line no-console
-  console.warn(
-    `⚠️  Detected global git hooks at ${globalHooksPath}\n` +
-      `   Overriding locally for this Z2H project (your other repos are unaffected).`
-  );
 }
 
 async function ensureGitignore(dir: string): Promise<void> {