@mondaydotcomorg/monday-authorization 3.9.4-feat-shaime-fix-timeout-5ff7b3a → 3.9.4-feat-shaime-fix-timeout-53ee888

package/dist/authorization-internal-service.d.ts

@@ -5,6 +5,9 @@ import type { AuthorizationFetchOptions } from './types/fetch-options';
 export declare const MAX_RETRIES = 3;
 export declare const RETRY_DELAY_MS = 20;
 export declare const logger: import("bunyan");
+/**
+ * Key used to retrieve retry configuration from Ignite.
+ */
 export declare const IGNITE_RETRY_CONFIG_KEY = "authorization_retry_config";
 export declare const onRetryCallback: OnRetryCallback;
 /**
@@ -26,6 +29,7 @@ export declare class AuthorizationInternalService {
     static generateInternalAuthToken(accountId: number, userId: number): string;
     static setRequestFetchOptions(customMondayFetchOptions: AuthorizationFetchOptions): void;
     static getRequestFetchOptions(): AuthorizationFetchOptions;
+    static resetRequestFetchOptions(): void;
     static setIgniteClient(client: IgniteClient): void;
     static getRequestTimeout(): number;
     static getRetriesPolicy(): RetryPolicy;

package/dist/authorization-internal-service.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"authorization-internal-service.d.ts","sourceRoot":"","sources":["../src/authorization-internal-service.ts"],"names":[],"mappings":"AAEA,OAAO,EAEL,eAAe,EACf,QAAQ,EACR,WAAW,EAEZ,MAAM,mCAAmC,CAAC;AAC3C,OAAO,EAAE,YAAY,EAAE,MAAM,6BAA6B,CAAC;AAC3D,OAAO,EAAE,WAAW,EAAE,MAAM,iBAAiB,CAAC;AAC9C,OAAO,KAAK,EAAE,yBAAyB,EAAE,MAAM,uBAAuB,CAAC;AAGvE,eAAO,MAAM,WAAW,IAAI,CAAC;AAC7B,eAAO,MAAM,cAAc,KAAK,CAAC;AACjC,eAAO,MAAM,MAAM,kBAA2B,CAAC;AAE/C,eAAO,MAAM,uBAAuB,+BAA+B,CAAC;AA4IpE,eAAO,MAAM,eAAe,EAAE,eAkB7B,CAAC;AAEF;;;;GAIG;AACH,eAAO,MAAM,qBAAqB,GAAI,kBAAkB;IAAE,YAAY,EAAE,MAAM,CAAA;CAAE,KAAG,MAOlF,CAAC;AAMF,qBAAa,4BAA4B;IACvC,MAAM,KAAK,YAAY,IAAI,YAAY,GAAG,SAAS,CAElD;IAED,MAAM,KAAK,YAAY,CAAC,MAAM,EAAE,YAAY,GAAG,SAAS,EAEvD;IACD,MAAM,CAAC,iBAAiB,CAAC,OAAO,EAAE,WAAW,GAAG,IAAI;IAIpD,MAAM,CAAC,cAAc,CAAC,OAAO,EAAE,WAAW,GAAG,IAAI;IAIjD,MAAM,CAAC,+BAA+B,CAAC,OAAO,EAAE,WAAW,GAAG,IAAI;IAMlE,MAAM,CAAC,wBAAwB,CAAC,QAAQ,EAAE,QAAQ,EAAE,SAAS,EAAE,MAAM,GAAG,IAAI;IAc5E,MAAM,CAAC,gBAAgB,CAAC,MAAM,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,GAAG,KAAK;IAQjE,MAAM,CAAC,yBAAyB,CAAC,SAAS,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM;IAIlE,MAAM,CAAC,sBAAsB,CAAC,wBAAwB,EAAE,yBAAyB;IAWjF,MAAM,CAAC,sBAAsB,IAAI,yBAAyB;IAI1D,MAAM,CAAC,eAAe,CAAC,MAAM,EAAE,YAAY;IAI3C,MAAM,CAAC,iBAAiB;IA0BxB,MAAM,CAAC,gBAAgB,IAAI,WAAW;CAuBvC"}
+{"version":3,"file":"authorization-internal-service.d.ts","sourceRoot":"","sources":["../src/authorization-internal-service.ts"],"names":[],"mappings":"AAEA,OAAO,EAEL,eAAe,EACf,QAAQ,EACR,WAAW,EAEZ,MAAM,mCAAmC,CAAC;AAC3C,OAAO,EAAE,YAAY,EAAE,MAAM,6BAA6B,CAAC;AAC3D,OAAO,EAAE,WAAW,EAAE,MAAM,iBAAiB,CAAC;AAC9C,OAAO,KAAK,EAAE,yBAAyB,EAAE,MAAM,uBAAuB,CAAC;AAGvE,eAAO,MAAM,WAAW,IAAI,CAAC;AAC7B,eAAO,MAAM,cAAc,KAAK,CAAC;AACjC,eAAO,MAAM,MAAM,kBAA2B,CAAC;AAE/C;;GAEG;AACH,eAAO,MAAM,uBAAuB,+BAA+B,CAAC;AA8JpE,eAAO,MAAM,eAAe,EAAE,eAkB7B,CAAC;AAEF;;;;GAIG;AACH,eAAO,MAAM,qBAAqB,GAAI,kBAAkB;IAAE,YAAY,EAAE,MAAM,CAAA;CAAE,KAAG,MAOlF,CAAC;AAIF,qBAAa,4BAA4B;IACvC,MAAM,KAAK,YAAY,IAAI,YAAY,GAAG,SAAS,CAElD;IAED,MAAM,KAAK,YAAY,CAAC,MAAM,EAAE,YAAY,GAAG,SAAS,EAEvD;IACD,MAAM,CAAC,iBAAiB,CAAC,OAAO,EAAE,WAAW,GAAG,IAAI;IAIpD,MAAM,CAAC,cAAc,CAAC,OAAO,EAAE,WAAW,GAAG,IAAI;IAIjD,MAAM,CAAC,+BAA+B,CAAC,OAAO,EAAE,WAAW,GAAG,IAAI;IAMlE,MAAM,CAAC,wBAAwB,CAAC,QAAQ,EAAE,QAAQ,EAAE,SAAS,EAAE,MAAM,GAAG,IAAI;IAc5E,MAAM,CAAC,gBAAgB,CAAC,MAAM,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,GAAG,KAAK;IAQjE,MAAM,CAAC,yBAAyB,CAAC,SAAS,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM;IAIlE,MAAM,CAAC,sBAAsB,CAAC,wBAAwB,EAAE,yBAAyB;IAWjF,MAAM,CAAC,sBAAsB,IAAI,yBAAyB;IAI1D,MAAM,CAAC,wBAAwB;IAI/B,MAAM,CAAC,eAAe,CAAC,MAAM,EAAE,YAAY;IAI3C,MAAM,CAAC,iBAAiB;IA0BxB,MAAM,CAAC,gBAAgB,IAAI,WAAW;CA2BvC"}

package/dist/authorization-internal-service.js

@@ -27,6 +27,9 @@ const INTERNAL_APP_NAME = 'internal_ms';
 const MAX_RETRIES = 3;
 const RETRY_DELAY_MS = 20;
 const logger = MondayLogger__namespace.getLogger();
+/**
+ * Key used to retrieve retry configuration from Ignite.
+ */
 const IGNITE_RETRY_CONFIG_KEY = 'authorization_retry_config';
 let igniteClient;
 const defaultRetryConfig = {
@@ -41,11 +44,17 @@ const defaultRetryConfig = {
  * Sanitizes retry configuration values to ensure they are within valid ranges
  */
 function sanitizeRetryConfig(config) {
+    const merged = { ...defaultRetryConfig, ...config };
     return {
-        ...config,
-        retries: Math.max(0, Math.min(5, config.retries)),
-        exponentBase: Math.max(1, Math.min(100, config.exponentBase)),
-        jitterMinMs: Math.max(0, config.jitterMinMs),
+        ...merged,
+        retries: Math.max(0, Math.min(5, merged.retries)),
+        baseDelayMs: Math.max(0, merged.baseDelayMs),
+        exponentBase: Math.max(1, Math.min(100, merged.exponentBase)),
+        jitterMinMs: Math.max(0, merged.jitterMinMs),
+        jitterMaxMs: Math.max(0, merged.jitterMaxMs),
+        retryOnStatusPatterns: Array.isArray(merged.retryOnStatusPatterns)
+            ? merged.retryOnStatusPatterns
+            : defaultRetryConfig.retryOnStatusPatterns,
     };
 }
 function getRetryConfig() {
@@ -67,6 +76,10 @@ function randomIntInclusive(min, max) {
     }
     return Math.floor(min + Math.random() * (max - min + 1));
 }
+/**
+ * Helper to build status matchers from config patterns.
+ * @param patterns Array of patterns like "429", "5**", "5*9"
+ */
 function buildHttpStatusMatchers(patterns) {
     const matchers = [];
     const addWildcardMatcher = (wildcard) => {
@@ -119,13 +132,6 @@ function buildHttpStatusMatchers(patterns) {
     }
     return matchers;
 }
-function shouldRetryOnResponseStatus(responseOrStatus, statusMatchers) {
-    const status = responseOrStatus?.status;
-    if (typeof status !== 'number') {
-        return false;
-    }
-    return statusMatchers.some(matcher => matcher(status));
-}
 const onRetryCallback = (attempt, error, response, isTimeoutError) => {
     const effectiveMaxRetries = getRetryConfig().retries;
     if (attempt == effectiveMaxRetries) {
@@ -148,9 +154,7 @@ const calcDelayDurationInMs = ({ attemptCount }) => {
     const jitter = randomIntInclusive(jitterMin, jitterMax);
     return expDelay + jitter;
 };
-let mondayFetchOptions = {
-    retries: defaultRetryConfig.retries,
-};
+let mondayFetchOptions = {};
 class AuthorizationInternalService {
     static get igniteClient() {
         return igniteClient;
@@ -166,7 +170,7 @@ class AuthorizationInternalService {
     }
     static failIfNotCoveredByAuthorization(request) {
         if (!request.authorizationCheckPerformed && !request.authorizationSkipPerformed) {
-            throw 'Endpoint is not covered by authorization check';
+            throw new Error('Endpoint is not covered by authorization check');
         }
     }
     static throwOnHttpErrorIfNeeded(response, placement) {
@@ -190,13 +194,16 @@ class AuthorizationInternalService {
             sanitizedOptions.retries = Math.max(0, Math.min(5, sanitizedOptions.retries));
         }
         mondayFetchOptions = {
-            ...defaultRetryConfig,
+            ...mondayFetchOptions,
             ...sanitizedOptions,
         };
     }
     static getRequestFetchOptions() {
         return mondayFetchOptions;
     }
+    static resetRequestFetchOptions() {
+        mondayFetchOptions = {};
+    }
     static setIgniteClient(client) {
         igniteClient = client;
     }
@@ -206,8 +213,8 @@ class AuthorizationInternalService {
         if (!this.igniteClient) {
             return defaultTimeout;
         }
-        const overrideTimeouts = this.igniteClient.configuration.getObjectValue('override-outgoing-request-timeout-ms', {});
         try {
+            const overrideTimeouts = this.igniteClient.configuration.getObjectValue('override-outgoing-request-timeout-ms', {});
             if (process.env.APP_NAME && process.env.APP_NAME in overrideTimeouts) {
                 return overrideTimeouts[process.env.APP_NAME];
             }
@@ -224,8 +231,12 @@ class AuthorizationInternalService {
         const fetchOptions = AuthorizationInternalService.getRequestFetchOptions();
         const retryConfig = getRetryConfig();
         const statusMatchers = buildHttpStatusMatchers(retryConfig.retryOnStatusPatterns);
-        const defaultRetryOn = (_attempt, _error, response, isTimeoutError) => {
-            return isTimeoutError ? true : shouldRetryOnResponseStatus(response ?? undefined, statusMatchers);
+        const defaultRetryOn = (_attempt, error, response, isTimeoutError) => {
+            if (isTimeoutError) {
+                return true;
+            }
+            const status = response?.status ?? error?.status;
+            return typeof status === 'number' ? statusMatchers.some(matcher => matcher(status)) : false;
         };
         // Sanitize retries from fetchOptions: clamp between 0 and 5
         const rawMaxRetries = fetchOptions?.retries ?? retryConfig.retries;

package/dist/esm/authorization-internal-service.d.ts

@@ -5,6 +5,9 @@ import type { AuthorizationFetchOptions } from './types/fetch-options';
 export declare const MAX_RETRIES = 3;
 export declare const RETRY_DELAY_MS = 20;
 export declare const logger: import("bunyan");
+/**
+ * Key used to retrieve retry configuration from Ignite.
+ */
 export declare const IGNITE_RETRY_CONFIG_KEY = "authorization_retry_config";
 export declare const onRetryCallback: OnRetryCallback;
 /**
@@ -26,6 +29,7 @@ export declare class AuthorizationInternalService {
     static generateInternalAuthToken(accountId: number, userId: number): string;
     static setRequestFetchOptions(customMondayFetchOptions: AuthorizationFetchOptions): void;
     static getRequestFetchOptions(): AuthorizationFetchOptions;
+    static resetRequestFetchOptions(): void;
     static setIgniteClient(client: IgniteClient): void;
     static getRequestTimeout(): number;
     static getRetriesPolicy(): RetryPolicy;

package/dist/esm/authorization-internal-service.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"authorization-internal-service.d.ts","sourceRoot":"","sources":["../../src/authorization-internal-service.ts"],"names":[],"mappings":"AAEA,OAAO,EAEL,eAAe,EACf,QAAQ,EACR,WAAW,EAEZ,MAAM,mCAAmC,CAAC;AAC3C,OAAO,EAAE,YAAY,EAAE,MAAM,6BAA6B,CAAC;AAC3D,OAAO,EAAE,WAAW,EAAE,MAAM,iBAAiB,CAAC;AAC9C,OAAO,KAAK,EAAE,yBAAyB,EAAE,MAAM,uBAAuB,CAAC;AAGvE,eAAO,MAAM,WAAW,IAAI,CAAC;AAC7B,eAAO,MAAM,cAAc,KAAK,CAAC;AACjC,eAAO,MAAM,MAAM,kBAA2B,CAAC;AAE/C,eAAO,MAAM,uBAAuB,+BAA+B,CAAC;AA4IpE,eAAO,MAAM,eAAe,EAAE,eAkB7B,CAAC;AAEF;;;;GAIG;AACH,eAAO,MAAM,qBAAqB,GAAI,kBAAkB;IAAE,YAAY,EAAE,MAAM,CAAA;CAAE,KAAG,MAOlF,CAAC;AAMF,qBAAa,4BAA4B;IACvC,MAAM,KAAK,YAAY,IAAI,YAAY,GAAG,SAAS,CAElD;IAED,MAAM,KAAK,YAAY,CAAC,MAAM,EAAE,YAAY,GAAG,SAAS,EAEvD;IACD,MAAM,CAAC,iBAAiB,CAAC,OAAO,EAAE,WAAW,GAAG,IAAI;IAIpD,MAAM,CAAC,cAAc,CAAC,OAAO,EAAE,WAAW,GAAG,IAAI;IAIjD,MAAM,CAAC,+BAA+B,CAAC,OAAO,EAAE,WAAW,GAAG,IAAI;IAMlE,MAAM,CAAC,wBAAwB,CAAC,QAAQ,EAAE,QAAQ,EAAE,SAAS,EAAE,MAAM,GAAG,IAAI;IAc5E,MAAM,CAAC,gBAAgB,CAAC,MAAM,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,GAAG,KAAK;IAQjE,MAAM,CAAC,yBAAyB,CAAC,SAAS,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM;IAIlE,MAAM,CAAC,sBAAsB,CAAC,wBAAwB,EAAE,yBAAyB;IAWjF,MAAM,CAAC,sBAAsB,IAAI,yBAAyB;IAI1D,MAAM,CAAC,eAAe,CAAC,MAAM,EAAE,YAAY;IAI3C,MAAM,CAAC,iBAAiB;IA0BxB,MAAM,CAAC,gBAAgB,IAAI,WAAW;CAuBvC"}
+{"version":3,"file":"authorization-internal-service.d.ts","sourceRoot":"","sources":["../../src/authorization-internal-service.ts"],"names":[],"mappings":"AAEA,OAAO,EAEL,eAAe,EACf,QAAQ,EACR,WAAW,EAEZ,MAAM,mCAAmC,CAAC;AAC3C,OAAO,EAAE,YAAY,EAAE,MAAM,6BAA6B,CAAC;AAC3D,OAAO,EAAE,WAAW,EAAE,MAAM,iBAAiB,CAAC;AAC9C,OAAO,KAAK,EAAE,yBAAyB,EAAE,MAAM,uBAAuB,CAAC;AAGvE,eAAO,MAAM,WAAW,IAAI,CAAC;AAC7B,eAAO,MAAM,cAAc,KAAK,CAAC;AACjC,eAAO,MAAM,MAAM,kBAA2B,CAAC;AAE/C;;GAEG;AACH,eAAO,MAAM,uBAAuB,+BAA+B,CAAC;AA8JpE,eAAO,MAAM,eAAe,EAAE,eAkB7B,CAAC;AAEF;;;;GAIG;AACH,eAAO,MAAM,qBAAqB,GAAI,kBAAkB;IAAE,YAAY,EAAE,MAAM,CAAA;CAAE,KAAG,MAOlF,CAAC;AAIF,qBAAa,4BAA4B;IACvC,MAAM,KAAK,YAAY,IAAI,YAAY,GAAG,SAAS,CAElD;IAED,MAAM,KAAK,YAAY,CAAC,MAAM,EAAE,YAAY,GAAG,SAAS,EAEvD;IACD,MAAM,CAAC,iBAAiB,CAAC,OAAO,EAAE,WAAW,GAAG,IAAI;IAIpD,MAAM,CAAC,cAAc,CAAC,OAAO,EAAE,WAAW,GAAG,IAAI;IAIjD,MAAM,CAAC,+BAA+B,CAAC,OAAO,EAAE,WAAW,GAAG,IAAI;IAMlE,MAAM,CAAC,wBAAwB,CAAC,QAAQ,EAAE,QAAQ,EAAE,SAAS,EAAE,MAAM,GAAG,IAAI;IAc5E,MAAM,CAAC,gBAAgB,CAAC,MAAM,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,GAAG,KAAK;IAQjE,MAAM,CAAC,yBAAyB,CAAC,SAAS,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM;IAIlE,MAAM,CAAC,sBAAsB,CAAC,wBAAwB,EAAE,yBAAyB;IAWjF,MAAM,CAAC,sBAAsB,IAAI,yBAAyB;IAI1D,MAAM,CAAC,wBAAwB;IAI/B,MAAM,CAAC,eAAe,CAAC,MAAM,EAAE,YAAY;IAI3C,MAAM,CAAC,iBAAiB;IA0BxB,MAAM,CAAC,gBAAgB,IAAI,WAAW;CA2BvC"}

package/dist/esm/authorization-internal-service.mjs

@@ -5,6 +5,9 @@ const INTERNAL_APP_NAME = 'internal_ms';
 const MAX_RETRIES = 3;
 const RETRY_DELAY_MS = 20;
 const logger = MondayLogger.getLogger();
+/**
+ * Key used to retrieve retry configuration from Ignite.
+ */
 const IGNITE_RETRY_CONFIG_KEY = 'authorization_retry_config';
 let igniteClient;
 const defaultRetryConfig = {
@@ -19,11 +22,17 @@ const defaultRetryConfig = {
  * Sanitizes retry configuration values to ensure they are within valid ranges
  */
 function sanitizeRetryConfig(config) {
+    const merged = { ...defaultRetryConfig, ...config };
     return {
-        ...config,
-        retries: Math.max(0, Math.min(5, config.retries)),
-        exponentBase: Math.max(1, Math.min(100, config.exponentBase)),
-        jitterMinMs: Math.max(0, config.jitterMinMs),
+        ...merged,
+        retries: Math.max(0, Math.min(5, merged.retries)),
+        baseDelayMs: Math.max(0, merged.baseDelayMs),
+        exponentBase: Math.max(1, Math.min(100, merged.exponentBase)),
+        jitterMinMs: Math.max(0, merged.jitterMinMs),
+        jitterMaxMs: Math.max(0, merged.jitterMaxMs),
+        retryOnStatusPatterns: Array.isArray(merged.retryOnStatusPatterns)
+            ? merged.retryOnStatusPatterns
+            : defaultRetryConfig.retryOnStatusPatterns,
     };
 }
 function getRetryConfig() {
@@ -45,6 +54,10 @@ function randomIntInclusive(min, max) {
     }
     return Math.floor(min + Math.random() * (max - min + 1));
 }
+/**
+ * Helper to build status matchers from config patterns.
+ * @param patterns Array of patterns like "429", "5**", "5*9"
+ */
 function buildHttpStatusMatchers(patterns) {
     const matchers = [];
     const addWildcardMatcher = (wildcard) => {
@@ -97,13 +110,6 @@ function buildHttpStatusMatchers(patterns) {
     }
     return matchers;
 }
-function shouldRetryOnResponseStatus(responseOrStatus, statusMatchers) {
-    const status = responseOrStatus?.status;
-    if (typeof status !== 'number') {
-        return false;
-    }
-    return statusMatchers.some(matcher => matcher(status));
-}
 const onRetryCallback = (attempt, error, response, isTimeoutError) => {
     const effectiveMaxRetries = getRetryConfig().retries;
     if (attempt == effectiveMaxRetries) {
@@ -126,9 +132,7 @@ const calcDelayDurationInMs = ({ attemptCount }) => {
     const jitter = randomIntInclusive(jitterMin, jitterMax);
     return expDelay + jitter;
 };
-let mondayFetchOptions = {
-    retries: defaultRetryConfig.retries,
-};
+let mondayFetchOptions = {};
 class AuthorizationInternalService {
     static get igniteClient() {
         return igniteClient;
@@ -144,7 +148,7 @@ class AuthorizationInternalService {
     }
     static failIfNotCoveredByAuthorization(request) {
         if (!request.authorizationCheckPerformed && !request.authorizationSkipPerformed) {
-            throw 'Endpoint is not covered by authorization check';
+            throw new Error('Endpoint is not covered by authorization check');
         }
     }
     static throwOnHttpErrorIfNeeded(response, placement) {
@@ -168,13 +172,16 @@ class AuthorizationInternalService {
             sanitizedOptions.retries = Math.max(0, Math.min(5, sanitizedOptions.retries));
         }
         mondayFetchOptions = {
-            ...defaultRetryConfig,
+            ...mondayFetchOptions,
             ...sanitizedOptions,
         };
     }
     static getRequestFetchOptions() {
         return mondayFetchOptions;
     }
+    static resetRequestFetchOptions() {
+        mondayFetchOptions = {};
+    }
     static setIgniteClient(client) {
         igniteClient = client;
     }
@@ -184,8 +191,8 @@ class AuthorizationInternalService {
         if (!this.igniteClient) {
             return defaultTimeout;
         }
-        const overrideTimeouts = this.igniteClient.configuration.getObjectValue('override-outgoing-request-timeout-ms', {});
         try {
+            const overrideTimeouts = this.igniteClient.configuration.getObjectValue('override-outgoing-request-timeout-ms', {});
             if (process.env.APP_NAME && process.env.APP_NAME in overrideTimeouts) {
                 return overrideTimeouts[process.env.APP_NAME];
             }
@@ -202,8 +209,12 @@ class AuthorizationInternalService {
         const fetchOptions = AuthorizationInternalService.getRequestFetchOptions();
         const retryConfig = getRetryConfig();
         const statusMatchers = buildHttpStatusMatchers(retryConfig.retryOnStatusPatterns);
-        const defaultRetryOn = (_attempt, _error, response, isTimeoutError) => {
-            return isTimeoutError ? true : shouldRetryOnResponseStatus(response ?? undefined, statusMatchers);
+        const defaultRetryOn = (_attempt, error, response, isTimeoutError) => {
+            if (isTimeoutError) {
+                return true;
+            }
+            const status = response?.status ?? error?.status;
+            return typeof status === 'number' ? statusMatchers.some(matcher => matcher(status)) : false;
         };
         // Sanitize retries from fetchOptions: clamp between 0 and 5
         const rawMaxRetries = fetchOptions?.retries ?? retryConfig.retries;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mondaydotcomorg/monday-authorization",
-  "version": "3.9.4-feat-shaime-fix-timeout-5ff7b3a",
+  "version": "3.9.4-feat-shaime-fix-timeout-53ee888",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "license": "BSD-3-Clause",

package/src/authorization-internal-service.ts

@@ -16,6 +16,9 @@ export const MAX_RETRIES = 3;
 export const RETRY_DELAY_MS = 20;
 export const logger = MondayLogger.getLogger();
 
+/**
+ * Key used to retrieve retry configuration from Ignite.
+ */
 export const IGNITE_RETRY_CONFIG_KEY = 'authorization_retry_config';
 
 let igniteClient: IgniteClient | undefined;
@@ -48,12 +51,18 @@ const defaultRetryConfig: RetryConfig = {
 /**
  * Sanitizes retry configuration values to ensure they are within valid ranges
  */
-function sanitizeRetryConfig(config: RetryConfig): RetryConfig {
+function sanitizeRetryConfig(config: Partial<RetryConfig>): RetryConfig {
+  const merged = { ...defaultRetryConfig, ...config };
   return {
-    ...config,
-    retries: Math.max(0, Math.min(5, config.retries)),
-    exponentBase: Math.max(1, Math.min(100, config.exponentBase)),
-    jitterMinMs: Math.max(0, config.jitterMinMs),
+    ...merged,
+    retries: Math.max(0, Math.min(5, merged.retries)),
+    baseDelayMs: Math.max(0, merged.baseDelayMs),
+    exponentBase: Math.max(1, Math.min(100, merged.exponentBase)),
+    jitterMinMs: Math.max(0, merged.jitterMinMs),
+    jitterMaxMs: Math.max(0, merged.jitterMaxMs),
+    retryOnStatusPatterns: Array.isArray(merged.retryOnStatusPatterns)
+      ? merged.retryOnStatusPatterns
+      : defaultRetryConfig.retryOnStatusPatterns,
   };
 }
 
@@ -62,7 +71,10 @@ function getRetryConfig(): RetryConfig {
     return defaultRetryConfig;
   }
   try {
-    const config = igniteClient.configuration.getObjectValue<RetryConfig>(IGNITE_RETRY_CONFIG_KEY, defaultRetryConfig);
+    const config = igniteClient.configuration.getObjectValue<Partial<RetryConfig>>(
+      IGNITE_RETRY_CONFIG_KEY,
+      defaultRetryConfig
+    );
     return sanitizeRetryConfig(config);
   } catch (error) {
     logger.error(
@@ -82,6 +94,10 @@ function randomIntInclusive(min: number, max: number): number {
 
 type StatusMatcher = (status: number) => boolean;
 
+/**
+ * Helper to build status matchers from config patterns.
+ * @param patterns Array of patterns like "429", "5**", "5*9"
+ */
 function buildHttpStatusMatchers(patterns: string[]): StatusMatcher[] {
   const matchers: StatusMatcher[] = [];
 
@@ -145,6 +161,11 @@ function buildHttpStatusMatchers(patterns: string[]): StatusMatcher[] {
   return matchers;
 }
 
+/**
+ * Determines if a request should be retried based on the response status.
+ * @param responseOrStatus The response object or null/undefined
+ * @param statusMatchers Array of matchers to check against
+ */
 function shouldRetryOnResponseStatus(
   responseOrStatus: Response | null | undefined,
   statusMatchers: StatusMatcher[]
@@ -190,9 +211,7 @@ export const calcDelayDurationInMs = ({ attemptCount }: { attemptCount: number }
   return expDelay + jitter;
 };
 
-let mondayFetchOptions: AuthorizationFetchOptions = {
-  retries: defaultRetryConfig.retries,
-};
+let mondayFetchOptions: AuthorizationFetchOptions = {};
 
 export class AuthorizationInternalService {
   static get igniteClient(): IgniteClient | undefined {
@@ -212,7 +231,7 @@ export class AuthorizationInternalService {
 
   static failIfNotCoveredByAuthorization(request: BaseRequest): void {
     if (!request.authorizationCheckPerformed && !request.authorizationSkipPerformed) {
-      throw 'Endpoint is not covered by authorization check';
+      throw new Error('Endpoint is not covered by authorization check');
     }
   }
 
@@ -248,7 +267,7 @@ export class AuthorizationInternalService {
       sanitizedOptions.retries = Math.max(0, Math.min(5, sanitizedOptions.retries));
     }
     mondayFetchOptions = {
-      ...defaultRetryConfig,
+      ...mondayFetchOptions,
       ...sanitizedOptions,
     };
   }
@@ -257,6 +276,10 @@ export class AuthorizationInternalService {
     return mondayFetchOptions;
   }
 
+  static resetRequestFetchOptions() {
+    mondayFetchOptions = {};
+  }
+
   static setIgniteClient(client: IgniteClient) {
     igniteClient = client;
   }
@@ -268,11 +291,11 @@ export class AuthorizationInternalService {
       return defaultTimeout;
     }
 
-    const overrideTimeouts = this.igniteClient.configuration.getObjectValue<Record<string, number>>(
-      'override-outgoing-request-timeout-ms',
-      {}
-    );
     try {
+      const overrideTimeouts = this.igniteClient.configuration.getObjectValue<Record<string, number>>(
+        'override-outgoing-request-timeout-ms',
+        {}
+      );
       if (process.env.APP_NAME && process.env.APP_NAME in overrideTimeouts) {
         return overrideTimeouts[process.env.APP_NAME];
       } else {
@@ -291,8 +314,12 @@ export class AuthorizationInternalService {
     const fetchOptions = AuthorizationInternalService.getRequestFetchOptions();
     const retryConfig = getRetryConfig();
     const statusMatchers = buildHttpStatusMatchers(retryConfig.retryOnStatusPatterns);
-    const defaultRetryOn = (_attempt, _error, response, isTimeoutError) => {
-      return isTimeoutError ? true : shouldRetryOnResponseStatus(response ?? undefined, statusMatchers);
+    const defaultRetryOn = (_attempt, error, response, isTimeoutError) => {
+      if (isTimeoutError) {
+        return true;
+      }
+      const status = response?.status ?? (error as any)?.status;
+      return typeof status === 'number' ? statusMatchers.some(matcher => matcher(status)) : false;
     };
     // Sanitize retries from fetchOptions: clamp between 0 and 5
     const rawMaxRetries = fetchOptions?.retries ?? retryConfig.retries;