@mondaydotcomorg/monday-authorization 3.6.0-feat-shaime-support-entity-attributes-3-edf2a0b → 3.6.1

package/src/authorization-attributes-service.ts

@@ -1,46 +1,48 @@
 import { AuthorizationAttributesMsService } from './authorization-attributes-ms-service';
 import { AuthorizationAttributesSnsService } from './authorization-attributes-sns-service';
-import { AuthorizationAttributesService as IAuthorizationAttributesService } from './types/authorization-attributes-service.interface';
+import { BaseAuthorizationAttributesService as IAuthorizationAttributesService } from './base-authorization-attributes-service';
 
 /**
  * Main service class for managing resource and entity attributes.
- * Provides access to both direct (MS) and SNS operations.
+ * Provides access to both HTTP (direct microservice) and SNS (async messaging) operations.
  *
  * @example
  * const service = new AuthorizationAttributesService();
  *
- * // Use direct operations
- * await service.direct().upsertResourceAttributes(accountId, assignments);
+ * // Use HTTP operations (direct calls to microservice)
+ * await service.http().updateResourceAttributes(accountId, appName, actionId, operation);
  *
- * // Use SNS operations
- * await service.sns().upsertResourceAttributes(accountId, assignments, appName, actionId);
+ * // Use SNS operations (async messaging, then to microservice)
+ * await service.sns().updateResourceAttributes(accountId, appName, actionId, operation);
  * ```
  */
 export class AuthorizationAttributesService {
-  private _directService: AuthorizationAttributesMsService | null = null;
-  private _snsService: AuthorizationAttributesSnsService | null = null;
+  private httpService: AuthorizationAttributesMsService | null = null;
+  private snsService: AuthorizationAttributesSnsService | null = null;
 
   /**
-   * Gets the direct (MS) service instance.
+   * Gets the HTTP service instance.
+   * Performs direct HTTP calls to the authorization microservice.
    * Initializes the service on first access (lazy initialization).
    * @returns IAuthorizationAttributesService instance
    */
-  direct(): IAuthorizationAttributesService {
-    if (this._directService === null) {
-      this._directService = new AuthorizationAttributesMsService();
+  http(): IAuthorizationAttributesService {
+    if (this.httpService === null) {
+      this.httpService = new AuthorizationAttributesMsService();
     }
-    return this._directService;
+    return this.httpService;
   }
 
   /**
    * Gets the SNS service instance.
+   * Sends operations via SNS messaging, which are then processed by the microservice asynchronously.
    * Initializes the service on first access (lazy initialization).
    * @returns IAuthorizationAttributesService instance
    */
   sns(): IAuthorizationAttributesService {
-    if (this._snsService === null) {
-      this._snsService = new AuthorizationAttributesSnsService();
+    if (this.snsService === null) {
+      this.snsService = new AuthorizationAttributesSnsService();
     }
-    return this._snsService;
+    return this.snsService;
   }
 }

package/src/authorization-attributes-sns-service.ts

@@ -1,7 +1,6 @@
 import chunk from 'lodash/chunk.js';
 import { getTopicAttributes, sendToSns } from '@mondaydotcomorg/monday-sns';
 import {
-  AttributeOperation,
   ResourceAttributeUpsertOperation,
   EntityAttributeUpsertOperation,
   EntityAttributeDeleteOperation,
@@ -20,16 +19,15 @@ import {
   ENTITY_SNS_DEV_TEST_NAME,
   SnsTopicType,
 } from './constants/sns';
-import { AuthorizationAttributesService } from './types/authorization-attributes-service.interface';
+import { BaseAuthorizationAttributesService } from './base-authorization-attributes-service';
 import { EntityType } from './entity-attributes-constants';
-import { ValidationUtils } from './utils/validation';
 import type { TopicAttributesMap } from 'aws-sdk/clients/sns';
 
 /**
  * Service class for managing resource attributes asynchronously via SNS.
  * Provides asynchronous operations to create/update and delete attributes on resources.
  */
-export class AuthorizationAttributesSnsService implements AuthorizationAttributesService {
+export class AuthorizationAttributesSnsService extends BaseAuthorizationAttributesService {
   private static LOG_TAG = 'authorization_attributes';
   private resourceSnsArn: string;
   private entitySnsArn: string;
@@ -38,6 +36,7 @@ export class AuthorizationAttributesSnsService implements AuthorizationAttribute
    * Public constructor to create the AuthorizationAttributesSnsService instance.
    */
   constructor() {
+    super();
     this.resourceSnsArn = AuthorizationAttributesSnsService.getSnsTopicArn(SnsTopicType.RESOURCE);
     this.entitySnsArn = AuthorizationAttributesSnsService.getSnsTopicArn(SnsTopicType.ENTITY);
   }
@@ -62,17 +61,11 @@ export class AuthorizationAttributesSnsService implements AuthorizationAttribute
     if (!appName || !callerActionIdentifier) {
       throw new Error('appName and callerActionIdentifier are required for SNS service');
     }
-    ValidationUtils.validatDeleteResourceAssignment({
-      resourceType: resource.type,
-      resourceId: resource.id,
-      key: attributeKey,
-    });
-    const operation: ResourceAttributeDeleteOperation = {
-      resourceType: resource.type,
-      resourceId: resource.id,
-      key: attributeKey,
-      operationType: AttributeOperation.DELETE,
-    };
+    const operation: ResourceAttributeDeleteOperation = await super.deleteResourceAttributes(
+      accountId,
+      resource,
+      attributeKey
+    );
     const [result] = await this.sendOperationsToSns(
       this.resourceSnsArn,
       accountId,
@@ -108,13 +101,12 @@ export class AuthorizationAttributesSnsService implements AuthorizationAttribute
     if (!appName || !callerActionIdentifier) {
       throw new Error('appName and callerActionIdentifier are required for SNS service');
     }
-    ValidationUtils.validatDeleteEntityAssignment({ entityId, entityType, key: attributeKey });
-    const operation: EntityAttributeDeleteOperation = {
-      entityType: entityType,
+    const operation: EntityAttributeDeleteOperation = await super.deleteEntityAttributes(
+      accountId,
+      entityType,
       entityId,
-      key: attributeKey,
-      operationType: AttributeOperation.DELETE,
-    };
+      attributeKey
+    );
     const [result] = await this.sendOperationsToSns(
       this.entitySnsArn,
       accountId,
@@ -142,7 +134,7 @@ export class AuthorizationAttributesSnsService implements AuthorizationAttribute
     callerActionIdentifier: string,
     resourceAttributeOperation: ResourceAttributeUpsertOperation
   ): Promise<ResourceAttributeUpsertOperation> {
-    ValidationUtils.validatUpsertResourceAssignment(resourceAttributeOperation);
+    await super.updateResourceAttributes(accountId, appName, callerActionIdentifier, resourceAttributeOperation);
     const [result] = await this.sendOperationsToSns(
       this.resourceSnsArn,
       accountId,
@@ -170,7 +162,7 @@ export class AuthorizationAttributesSnsService implements AuthorizationAttribute
     callerActionIdentifier: string,
     entityAttributeOperation: EntityAttributeUpsertOperation
   ): Promise<EntityAttributeUpsertOperation> {
-    ValidationUtils.validatUpsertEntityAssignment(entityAttributeOperation);
+    await super.updateEntityAttributes(accountId, appName, callerActionIdentifier, entityAttributeOperation);
     const [result] = await this.sendOperationsToSns(
       this.entitySnsArn,
       accountId,

package/src/base-authorization-attributes-service.ts

@@ -0,0 +1,90 @@
+import { EntityType } from './entity-attributes-constants';
+import {
+  ResourceAttributeDeleteOperation,
+  EntityAttributeDeleteOperation,
+  ResourceAttributeUpsertOperation,
+  EntityAttributeUpsertOperation,
+  AttributeOperation,
+} from './types/authorization-attributes-contracts';
+import { Resource } from './types/general';
+import { ValidationUtils } from './utils/validation';
+
+/**
+ * Abstract base class for authorization attributes operations.
+ * Both MS (HTTP) and SNS (async) services extend this class.
+ */
+export abstract class BaseAuthorizationAttributesService {
+  /**
+   * Deletes a resource attribute.
+   * Returns Promise<ResourceAttributeDeleteOperation>
+   */
+  deleteResourceAttributes(
+    accountId: number,
+    resource: Resource,
+    attributeKey: string,
+    _appName?: string,
+    _callerActionIdentifier?: string
+  ): Promise<ResourceAttributeDeleteOperation> {
+    const operation: ResourceAttributeDeleteOperation = {
+      resourceType: resource.type,
+      resourceId: resource.id,
+      key: attributeKey,
+      operationType: AttributeOperation.DELETE,
+    };
+    ValidationUtils.validateInteger(accountId);
+    ValidationUtils.validatDeleteResourceAssignment(operation);
+    return Promise.resolve(operation);
+  }
+
+  /**
+   * Deletes an entity attribute.
+   * Returns Promise<EntityAttributeDeleteOperation>
+   */
+  deleteEntityAttributes(
+    accountId: number,
+    entityType: EntityType,
+    entityId: number,
+    attributeKey: string
+  ): Promise<EntityAttributeDeleteOperation> {
+    const operation: EntityAttributeDeleteOperation = {
+      entityType: entityType,
+      entityId: entityId,
+      key: attributeKey,
+      operationType: AttributeOperation.DELETE,
+    };
+    ValidationUtils.validateInteger(accountId);
+    ValidationUtils.validatDeleteEntityAssignment(operation);
+    return Promise.resolve(operation);
+  }
+
+  /**
+   * Updates a resource attribute (single operation - upsert only).
+   * For MS service: performs upsert operation
+   * For SNS service: returns Promise<ResourceAttributeUpsertOperation>
+   */
+  updateResourceAttributes(
+    accountId: number,
+    _appName: string,
+    _callerActionIdentifier: string,
+    resourceAttributeOperation: ResourceAttributeUpsertOperation
+  ): Promise<ResourceAttributeUpsertOperation> {
+    ValidationUtils.validateInteger(accountId);
+    ValidationUtils.validatUpsertResourceAssignment(resourceAttributeOperation);
+    return Promise.resolve(resourceAttributeOperation);
+  }
+  /**
+   * Updates an entity attribute (single operation - upsert only).
+   * For MS service: performs upsert operation
+   * For SNS service: returns Promise<EntityAttributeUpsertOperation>
+   */
+  updateEntityAttributes(
+    accountId: number,
+    _appName: string,
+    _callerActionIdentifier: string,
+    entityAttributeOperation: EntityAttributeUpsertOperation
+  ): Promise<EntityAttributeUpsertOperation> {
+    ValidationUtils.validateInteger(accountId);
+    ValidationUtils.validatUpsertEntityAssignment(entityAttributeOperation);
+    return Promise.resolve(entityAttributeOperation);
+  }
+}

package/src/index.ts

@@ -84,6 +84,6 @@ export {
   ResourceAttributeAssignment as ResourceAttributeAssignmentContract,
   EntityAttributeAssignment as EntityAttributeAssignmentContract,
 } from './types/authorization-attributes-contracts';
-export { AuthorizationAttributesService as IAuthorizationAttributesService } from './types/authorization-attributes-service.interface';
+export { BaseAuthorizationAttributesService as IAuthorizationAttributesService } from './base-authorization-attributes-service';
 
 export { TestKit };

package/src/resource-attribute-assignment.ts

@@ -1,6 +1,7 @@
 import { ResourceType } from './resource-attributes-constants';
 import { BaseAttributeAssignment } from './base-attribute-assignment';
 import { ResourceAttributeAssignment as ResourceAttributeAssignmentContract } from './types/authorization-attributes-contracts';
+import { ValidationUtils } from './utils/validation';
 
 export class ResourceAttributeAssignment extends BaseAttributeAssignment<
   ResourceType,
@@ -10,6 +11,12 @@ export class ResourceAttributeAssignment extends BaseAttributeAssignment<
   public readonly resourceType: ResourceType;
 
   constructor(resourceId: number, resourceType: ResourceType, attributeKey: string, attributeValue: string) {
+    ValidationUtils.validatUpsertResourceAssignment({
+      resourceId,
+      resourceType,
+      key: attributeKey,
+      value: attributeValue,
+    });
     super(resourceId, resourceType, attributeKey, attributeValue);
     this.resourceId = resourceId;
     this.resourceType = this.type;

package/src/resource-attributes-constants.ts

@@ -22,6 +22,7 @@ export enum ResourceType {
   Document = 'document',
   Crm = 'crm',
   Feature = 'feature',
+  POST = 'post',
 }
 
 // Define the array of strings and use 'as const' to make its contents literal types

package/src/utils/validation.ts

@@ -76,7 +76,7 @@ export class ValidationUtils {
   static validatDeleteResourceAssignment(resource: ResourceAttributeDeleteAssignment): void {
     const valid = resourceDeleteAssignmentSchema(resource);
     if (!valid) {
-      const errorMessage = this.formatValidationErrors(resourceUpsertAssignmentSchema.errors);
+      const errorMessage = this.formatValidationErrors(resourceDeleteAssignmentSchema.errors);
       throw new ArgumentError(
         errorMessage
           ? `Invalid resource attribute assignment: ${errorMessage}`
@@ -108,7 +108,7 @@ export class ValidationUtils {
    * Formats AJV validation errors into a readable error message
    */
   private static formatValidationErrors(errors: ErrorObject[] | null | undefined): string {
-    if (!errors || errors.length === 0) {
+    if (!errors || !errors.length) {
       return '';
     }
 

package/dist/esm/types/authorization-attributes-service.interface.d.ts

@@ -1,32 +0,0 @@
-import { EntityType } from '../entity-attributes-constants';
-import { ResourceAttributeDeleteOperation, EntityAttributeDeleteOperation, ResourceAttributeUpsertOperation, EntityAttributeUpsertOperation } from './authorization-attributes-contracts';
-import { Resource } from './general';
-/**
- * Interface for authorization attributes operations.
- * Both MS (direct) and SNS (async) services implement this interface.
- */
-export interface AuthorizationAttributesService {
-    /**
-     * Deletes a resource attribute.
-     * Returns Promise<ResourceAttributeDeleteOperation>
-     */
-    deleteResourceAttributes(accountId: number, resource: Resource, attributeKey: string, appName?: string, callerActionIdentifier?: string): Promise<ResourceAttributeDeleteOperation>;
-    /**
-     * Deletes an entity attribute.
-     * Returns Promise<EntityAttributeDeleteOperation>
-     */
-    deleteEntityAttributes(accountId: number, entityType: EntityType | string, entityId: number, attributeKey: string, appName?: string, callerActionIdentifier?: string): Promise<EntityAttributeDeleteOperation>;
-    /**
-     * Updates a resource attribute (single operation - upsert only).
-     * For MS service: performs upsert operation
-     * For SNS service: returns Promise<ResourceAttributeUpsertOperation>
-     */
-    updateResourceAttributes(accountId: number, appName: string, callerActionIdentifier: string, resourceAttributeOperation: ResourceAttributeUpsertOperation): Promise<ResourceAttributeUpsertOperation>;
-    /**
-     * Updates an entity attribute (single operation - upsert only).
-     * For MS service: performs upsert operation
-     * For SNS service: returns Promise<EntityAttributeUpsertOperation>
-     */
-    updateEntityAttributes(accountId: number, appName: string, callerActionIdentifier: string, entityAttributeOperation: EntityAttributeUpsertOperation): Promise<EntityAttributeUpsertOperation>;
-}
-//# sourceMappingURL=authorization-attributes-service.interface.d.ts.map

package/dist/esm/types/authorization-attributes-service.interface.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"authorization-attributes-service.interface.d.ts","sourceRoot":"","sources":["../../../src/types/authorization-attributes-service.interface.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,gCAAgC,CAAC;AAC5D,OAAO,EACL,gCAAgC,EAChC,8BAA8B,EAC9B,gCAAgC,EAChC,8BAA8B,EAC/B,MAAM,sCAAsC,CAAC;AAC9C,OAAO,EAAE,QAAQ,EAAE,MAAM,WAAW,CAAC;AAErC;;;GAGG;AACH,MAAM,WAAW,8BAA8B;IAC7C;;;OAGG;IACH,wBAAwB,CACtB,SAAS,EAAE,MAAM,EACjB,QAAQ,EAAE,QAAQ,EAClB,YAAY,EAAE,MAAM,EACpB,OAAO,CAAC,EAAE,MAAM,EAChB,sBAAsB,CAAC,EAAE,MAAM,GAC9B,OAAO,CAAC,gCAAgC,CAAC,CAAC;IAE7C;;;OAGG;IACH,sBAAsB,CACpB,SAAS,EAAE,MAAM,EACjB,UAAU,EAAE,UAAU,GAAG,MAAM,EAC/B,QAAQ,EAAE,MAAM,EAChB,YAAY,EAAE,MAAM,EACpB,OAAO,CAAC,EAAE,MAAM,EAChB,sBAAsB,CAAC,EAAE,MAAM,GAC9B,OAAO,CAAC,8BAA8B,CAAC,CAAC;IAE3C;;;;OAIG;IACH,wBAAwB,CACtB,SAAS,EAAE,MAAM,EACjB,OAAO,EAAE,MAAM,EACf,sBAAsB,EAAE,MAAM,EAC9B,0BAA0B,EAAE,gCAAgC,GAC3D,OAAO,CAAC,gCAAgC,CAAC,CAAC;IAE7C;;;;OAIG;IACH,sBAAsB,CACpB,SAAS,EAAE,MAAM,EACjB,OAAO,EAAE,MAAM,EACf,sBAAsB,EAAE,MAAM,EAC9B,wBAAwB,EAAE,8BAA8B,GACvD,OAAO,CAAC,8BAA8B,CAAC,CAAC;CAC5C"}

package/dist/esm/types/authorization-attributes-service.interface.mjs

@@ -1 +0,0 @@
-

package/dist/types/authorization-attributes-service.interface.d.ts

@@ -1,32 +0,0 @@
-import { EntityType } from '../entity-attributes-constants';
-import { ResourceAttributeDeleteOperation, EntityAttributeDeleteOperation, ResourceAttributeUpsertOperation, EntityAttributeUpsertOperation } from './authorization-attributes-contracts';
-import { Resource } from './general';
-/**
- * Interface for authorization attributes operations.
- * Both MS (direct) and SNS (async) services implement this interface.
- */
-export interface AuthorizationAttributesService {
-    /**
-     * Deletes a resource attribute.
-     * Returns Promise<ResourceAttributeDeleteOperation>
-     */
-    deleteResourceAttributes(accountId: number, resource: Resource, attributeKey: string, appName?: string, callerActionIdentifier?: string): Promise<ResourceAttributeDeleteOperation>;
-    /**
-     * Deletes an entity attribute.
-     * Returns Promise<EntityAttributeDeleteOperation>
-     */
-    deleteEntityAttributes(accountId: number, entityType: EntityType | string, entityId: number, attributeKey: string, appName?: string, callerActionIdentifier?: string): Promise<EntityAttributeDeleteOperation>;
-    /**
-     * Updates a resource attribute (single operation - upsert only).
-     * For MS service: performs upsert operation
-     * For SNS service: returns Promise<ResourceAttributeUpsertOperation>
-     */
-    updateResourceAttributes(accountId: number, appName: string, callerActionIdentifier: string, resourceAttributeOperation: ResourceAttributeUpsertOperation): Promise<ResourceAttributeUpsertOperation>;
-    /**
-     * Updates an entity attribute (single operation - upsert only).
-     * For MS service: performs upsert operation
-     * For SNS service: returns Promise<EntityAttributeUpsertOperation>
-     */
-    updateEntityAttributes(accountId: number, appName: string, callerActionIdentifier: string, entityAttributeOperation: EntityAttributeUpsertOperation): Promise<EntityAttributeUpsertOperation>;
-}
-//# sourceMappingURL=authorization-attributes-service.interface.d.ts.map

package/dist/types/authorization-attributes-service.interface.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"authorization-attributes-service.interface.d.ts","sourceRoot":"","sources":["../../src/types/authorization-attributes-service.interface.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,gCAAgC,CAAC;AAC5D,OAAO,EACL,gCAAgC,EAChC,8BAA8B,EAC9B,gCAAgC,EAChC,8BAA8B,EAC/B,MAAM,sCAAsC,CAAC;AAC9C,OAAO,EAAE,QAAQ,EAAE,MAAM,WAAW,CAAC;AAErC;;;GAGG;AACH,MAAM,WAAW,8BAA8B;IAC7C;;;OAGG;IACH,wBAAwB,CACtB,SAAS,EAAE,MAAM,EACjB,QAAQ,EAAE,QAAQ,EAClB,YAAY,EAAE,MAAM,EACpB,OAAO,CAAC,EAAE,MAAM,EAChB,sBAAsB,CAAC,EAAE,MAAM,GAC9B,OAAO,CAAC,gCAAgC,CAAC,CAAC;IAE7C;;;OAGG;IACH,sBAAsB,CACpB,SAAS,EAAE,MAAM,EACjB,UAAU,EAAE,UAAU,GAAG,MAAM,EAC/B,QAAQ,EAAE,MAAM,EAChB,YAAY,EAAE,MAAM,EACpB,OAAO,CAAC,EAAE,MAAM,EAChB,sBAAsB,CAAC,EAAE,MAAM,GAC9B,OAAO,CAAC,8BAA8B,CAAC,CAAC;IAE3C;;;;OAIG;IACH,wBAAwB,CACtB,SAAS,EAAE,MAAM,EACjB,OAAO,EAAE,MAAM,EACf,sBAAsB,EAAE,MAAM,EAC9B,0BAA0B,EAAE,gCAAgC,GAC3D,OAAO,CAAC,gCAAgC,CAAC,CAAC;IAE7C;;;;OAIG;IACH,sBAAsB,CACpB,SAAS,EAAE,MAAM,EACjB,OAAO,EAAE,MAAM,EACf,sBAAsB,EAAE,MAAM,EAC9B,wBAAwB,EAAE,8BAA8B,GACvD,OAAO,CAAC,8BAA8B,CAAC,CAAC;CAC5C"}

package/dist/types/authorization-attributes-service.interface.js

@@ -1 +0,0 @@
-

package/src/types/authorization-attributes-service.interface.ts

@@ -1,63 +0,0 @@
-import { EntityType } from '../entity-attributes-constants';
-import {
-  ResourceAttributeDeleteOperation,
-  EntityAttributeDeleteOperation,
-  ResourceAttributeUpsertOperation,
-  EntityAttributeUpsertOperation,
-} from './authorization-attributes-contracts';
-import { Resource } from './general';
-
-/**
- * Interface for authorization attributes operations.
- * Both MS (direct) and SNS (async) services implement this interface.
- */
-export interface AuthorizationAttributesService {
-  /**
-   * Deletes a resource attribute.
-   * Returns Promise<ResourceAttributeDeleteOperation>
-   */
-  deleteResourceAttributes(
-    accountId: number,
-    resource: Resource,
-    attributeKey: string,
-    appName?: string,
-    callerActionIdentifier?: string
-  ): Promise<ResourceAttributeDeleteOperation>;
-
-  /**
-   * Deletes an entity attribute.
-   * Returns Promise<EntityAttributeDeleteOperation>
-   */
-  deleteEntityAttributes(
-    accountId: number,
-    entityType: EntityType | string,
-    entityId: number,
-    attributeKey: string,
-    appName?: string,
-    callerActionIdentifier?: string
-  ): Promise<EntityAttributeDeleteOperation>;
-
-  /**
-   * Updates a resource attribute (single operation - upsert only).
-   * For MS service: performs upsert operation
-   * For SNS service: returns Promise<ResourceAttributeUpsertOperation>
-   */
-  updateResourceAttributes(
-    accountId: number,
-    appName: string,
-    callerActionIdentifier: string,
-    resourceAttributeOperation: ResourceAttributeUpsertOperation
-  ): Promise<ResourceAttributeUpsertOperation>;
-
-  /**
-   * Updates an entity attribute (single operation - upsert only).
-   * For MS service: performs upsert operation
-   * For SNS service: returns Promise<EntityAttributeUpsertOperation>
-   */
-  updateEntityAttributes(
-    accountId: number,
-    appName: string,
-    callerActionIdentifier: string,
-    entityAttributeOperation: EntityAttributeUpsertOperation
-  ): Promise<EntityAttributeUpsertOperation>;
-}