@mondaydotcomorg/monday-authorization 1.1.9-featuremosheauthorizationesm.3695 → 1.1.9-featuremosheauthorizationesm.3696

package/dist/attributions-service.js

@@ -8,7 +8,7 @@ const APP_NAME_HEADER_NAME = 'x-caller-app-name-from-sdk';
 const FROM_SDK_HEADER_SUFFIX = `-from-sdk`;
 let didSendFailureLogOnce = false;
 function getAttributionsFromApi() {
-    let callerAppNameFromSdk = {
+    const callerAppNameFromSdk = {
         [APP_NAME_HEADER_NAME]: tryJsonParse(getEnvVariable(APP_NAME_VARIABLE_KEY)),
     };
     try {
@@ -17,7 +17,7 @@ function getAttributionsFromApi() {
             return callerAppNameFromSdk;
         }
         const { runtimeAttributions } = tridentContext;
-        let runtimeAttributionsOutgoingHeaders = runtimeAttributions?.buildOutgoingHeaders('HTTP_INTERNAL');
+        const runtimeAttributionsOutgoingHeaders = runtimeAttributions?.buildOutgoingHeaders('HTTP_INTERNAL');
         if (!runtimeAttributionsOutgoingHeaders) {
             return callerAppNameFromSdk;
         }

package/dist/authorization-attributes-service.js

@@ -2,10 +2,10 @@ Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
 
 const chunk = require('lodash/chunk');
 const mondayFetch = require('@mondaydotcomorg/monday-fetch');
-const authorizationInternalService = require('./authorization-internal-service.js');
-const attributionsService = require('./attributions-service.js');
 const tridentBackendApi = require('@mondaydotcomorg/trident-backend-api');
 const mondaySns = require('@mondaydotcomorg/monday-sns');
+const authorizationInternalService = require('./authorization-internal-service.js');
+const attributionsService = require('./attributions-service.js');
 const constants_sns = require('./constants/sns.js');
 
 const _interopDefault = e => e && e.__esModule ? e : { default: e };
@@ -13,7 +13,7 @@ const _interopDefault = e => e && e.__esModule ? e : { default: e };
 const chunk__default = /*#__PURE__*/_interopDefault(chunk);
 
 class AuthorizationAttributesService {
-    static LOG_TAG = "authorization_attributes";
+    static LOG_TAG = 'authorization_attributes';
     /**
      * Upsert resource attributes synchronously, performing http call to the authorization MS to assign the given attributes to the given resource.
      * @param accountId
@@ -90,14 +90,14 @@ class AuthorizationAttributesService {
                 callerAppName: appName,
                 callerActionIdentifier: callerActionIdentifier,
                 operations: operations,
-            }
+            },
         };
         try {
             await mondaySns.sendToSns(payload, topicArn);
             return operations;
         }
         catch (error) {
-            authorizationInternalService.logger.error({ error, tag: this.LOG_TAG }, "Authorization resource attributes async update: failed to send operations to SNS");
+            authorizationInternalService.logger.error({ error, tag: this.LOG_TAG }, 'Authorization resource attributes async update: failed to send operations to SNS');
             return [];
         }
     }
@@ -128,14 +128,14 @@ class AuthorizationAttributesService {
         try {
             const requestedTopicArn = this.getSnsTopicArn();
             const attributes = await mondaySns.getTopicAttributes(requestedTopicArn);
-            const isHealthy = !(!attributes || !("TopicArn" in attributes) || attributes.TopicArn !== requestedTopicArn);
+            const isHealthy = !(!attributes || !('TopicArn' in attributes) || attributes.TopicArn !== requestedTopicArn);
             if (!isHealthy) {
-                authorizationInternalService.logger.error({ requestedTopicArn, snsReturnedAttributes: attributes, tag: this.LOG_TAG }, "authorization-attributes-service failed in health check");
+                authorizationInternalService.logger.error({ requestedTopicArn, snsReturnedAttributes: attributes, tag: this.LOG_TAG }, 'authorization-attributes-service failed in health check');
             }
             return isHealthy;
         }
         catch (error) {
-            authorizationInternalService.logger.error({ error, tag: this.LOG_TAG }, "authorization-attributes-service got error during health check");
+            authorizationInternalService.logger.error({ error, tag: this.LOG_TAG }, 'authorization-attributes-service got error during health check');
             return false;
         }
     }

package/dist/authorization-internal-service.d.ts

@@ -1,5 +1,5 @@
-import { Request } from 'express';
 import { fetch, MondayFetchOptions } from '@mondaydotcomorg/monday-fetch';
+import type { Request } from 'express';
 export declare const logger: import("bunyan");
 export declare class AuthorizationInternalService {
     static skipAuthorization(requset: Request): void;

package/dist/authorization-internal-service.js

@@ -28,6 +28,7 @@ const defaultMondayFetchOptions = {
     retries: 3,
     callback: logOnFetchFail,
 };
+const logger = MondayLogger__namespace.getLogger();
 function logOnFetchFail(retriesLeft, error) {
     if (retriesLeft == 0) {
         logger.error({ retriesLeft, error }, 'Authorization attempt failed due to network issues');
@@ -37,7 +38,6 @@ function logOnFetchFail(retriesLeft, error) {
     }
 }
 let mondayFetchOptions = defaultMondayFetchOptions;
-const logger = MondayLogger__namespace.getLogger();
 class AuthorizationInternalService {
     static skipAuthorization(requset) {
         requset.authorizationSkipPerformed = true;

package/dist/authorization-middleware.d.ts

@@ -1,5 +1,5 @@
-import { NextFunction } from 'express';
 import { Action, BaseRequest, BaseResponse, Context, ContextGetter, ResourceGetter } from './types/general';
+import type { NextFunction } from 'express';
 export declare function getAuthorizationMiddleware(action: Action, resourceGetter: ResourceGetter, contextGetter?: ContextGetter): (request: BaseRequest, response: BaseResponse, next: NextFunction) => Promise<void>;
 export declare function skipAuthorizationMiddleware(request: BaseRequest, response: BaseResponse, next: NextFunction): void;
 export declare function authorizationCheckMiddleware(request: BaseRequest, response: BaseResponse, next: NextFunction): void;

package/dist/authorization-service.d.ts

@@ -7,7 +7,6 @@ export interface AuthorizeResponse {
     unauthorizedObjects?: AuthorizationObject[];
 }
 export declare function setRequestFetchOptions(customMondayFetchOptions: MondayFetchOptions): void;
-export declare function setRedisClient(client: any, grantedFeatureRedisExpirationInSeconds?: number): void;
 export declare class AuthorizationService {
     static redisClient?: any;
     static grantedFeatureRedisExpirationInSeconds?: number;
@@ -27,3 +26,4 @@ export declare class AuthorizationService {
     private static isAuthorizedSingular;
     private static isAuthorizedMultiple;
 }
+export declare function setRedisClient(client: any, grantedFeatureRedisExpirationInSeconds?: number): void;

package/dist/authorization-service.js

@@ -1,7 +1,7 @@
 Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
 
-const lodash = require('lodash');
 const perf_hooks = require('perf_hooks');
+const lodash = require('lodash');
 const mondayFetch = require('@mondaydotcomorg/monday-fetch');
 const prometheusService = require('./prometheus-service.js');
 const authorizationInternalService = require('./authorization-internal-service.js');
@@ -11,16 +11,6 @@ const GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS = 5 * 60;
 function setRequestFetchOptions(customMondayFetchOptions) {
     authorizationInternalService.AuthorizationInternalService.setRequestFetchOptions(customMondayFetchOptions);
 }
-function setRedisClient(client, grantedFeatureRedisExpirationInSeconds = GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS) {
-    AuthorizationService.redisClient = client;
-    if (grantedFeatureRedisExpirationInSeconds && grantedFeatureRedisExpirationInSeconds > 0) {
-        AuthorizationService.grantedFeatureRedisExpirationInSeconds = grantedFeatureRedisExpirationInSeconds;
-    }
-    else {
-        authorizationInternalService.logger.warn({ grantedFeatureRedisExpirationInSeconds }, 'Invalid input for grantedFeatureRedisExpirationInSeconds, must be positive number. using default ttl.');
-        AuthorizationService.grantedFeatureRedisExpirationInSeconds = GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS;
-    }
-}
 class AuthorizationService {
     static redisClient;
     static grantedFeatureRedisExpirationInSeconds;
@@ -36,27 +26,27 @@ class AuthorizationService {
         }
     }
     static async isUserGrantedWithFeature(accountId, userId, featureName, options = {}) {
-        let cachedKey = this.getCachedKeyName(userId, featureName);
+        const cachedKey = this.getCachedKeyName(userId, featureName);
         const shouldSkipCache = options.shouldSkipCache ?? false;
         if (this.redisClient && !shouldSkipCache) {
-            let grantedFeatureValue = await this.redisClient.get(cachedKey);
+            const grantedFeatureValue = await this.redisClient.get(cachedKey);
             if (!(grantedFeatureValue === undefined || grantedFeatureValue === null)) {
                 // redis returns the value as string
                 return grantedFeatureValue === 'true';
             }
         }
-        let grantedFeatureValue = await this.fetchIsUserGrantedWithFeature(featureName, accountId, userId);
+        const grantedFeatureValue = await this.fetchIsUserGrantedWithFeature(featureName, accountId, userId);
         if (this.redisClient) {
             await this.redisClient.set(cachedKey, grantedFeatureValue, 'EX', this.grantedFeatureRedisExpirationInSeconds);
         }
         return grantedFeatureValue;
     }
     static async fetchIsUserGrantedWithFeature(featureName, accountId, userId) {
-        let authorizationObject = {
+        const authorizationObject = {
             action: featureName,
             resource_type: 'feature',
         };
-        let authorizeResponsePromise = await this.isAuthorized(accountId, userId, [authorizationObject]);
+        const authorizeResponsePromise = await this.isAuthorized(accountId, userId, [authorizationObject]);
         return authorizeResponsePromise.isAuthorized;
     }
     static getCachedKeyName(userId, featureName) {
@@ -148,6 +138,16 @@ class AuthorizationService {
         return { isAuthorized: true };
     }
 }
+function setRedisClient(client, grantedFeatureRedisExpirationInSeconds = GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS) {
+    AuthorizationService.redisClient = client;
+    if (grantedFeatureRedisExpirationInSeconds && grantedFeatureRedisExpirationInSeconds > 0) {
+        AuthorizationService.grantedFeatureRedisExpirationInSeconds = grantedFeatureRedisExpirationInSeconds;
+    }
+    else {
+        authorizationInternalService.logger.warn({ grantedFeatureRedisExpirationInSeconds }, 'Invalid input for grantedFeatureRedisExpirationInSeconds, must be positive number. using default ttl.');
+        AuthorizationService.grantedFeatureRedisExpirationInSeconds = GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS;
+    }
+}
 function createAuthorizationParams(resources, action) {
     const params = {
         authorizationObjects: resources.map((resource) => {

package/dist/esm/attributions-service.mjs

@@ -6,7 +6,7 @@ const APP_NAME_HEADER_NAME = 'x-caller-app-name-from-sdk';
 const FROM_SDK_HEADER_SUFFIX = `-from-sdk`;
 let didSendFailureLogOnce = false;
 function getAttributionsFromApi() {
-    let callerAppNameFromSdk = {
+    const callerAppNameFromSdk = {
         [APP_NAME_HEADER_NAME]: tryJsonParse(getEnvVariable(APP_NAME_VARIABLE_KEY)),
     };
     try {
@@ -15,7 +15,7 @@ function getAttributionsFromApi() {
             return callerAppNameFromSdk;
         }
         const { runtimeAttributions } = tridentContext;
-        let runtimeAttributionsOutgoingHeaders = runtimeAttributions?.buildOutgoingHeaders('HTTP_INTERNAL');
+        const runtimeAttributionsOutgoingHeaders = runtimeAttributions?.buildOutgoingHeaders('HTTP_INTERNAL');
         if (!runtimeAttributionsOutgoingHeaders) {
             return callerAppNameFromSdk;
         }

package/dist/esm/authorization-attributes-service.mjs

@@ -1,13 +1,13 @@
 import chunk from 'lodash/chunk';
 import { fetch } from '@mondaydotcomorg/monday-fetch';
-import { AuthorizationInternalService, logger } from './authorization-internal-service.mjs';
-import { getAttributionsFromApi } from './attributions-service.mjs';
 import { Api } from '@mondaydotcomorg/trident-backend-api';
 import { sendToSns, getTopicAttributes } from '@mondaydotcomorg/monday-sns';
+import { AuthorizationInternalService, logger } from './authorization-internal-service.mjs';
+import { getAttributionsFromApi } from './attributions-service.mjs';
 import { ASYNC_RESOURCE_ATTRIBUTES_MAX_OPERATIONS_PER_MESSAGE, RESOURCE_ATTRIBUTES_SNS_ARN_SECRET_NAME, RESOURCE_ATTRIBUTES_SNS_UPDATE_OPERATION_MESSAGE_KIND } from './constants/sns.mjs';
 
 class AuthorizationAttributesService {
-    static LOG_TAG = "authorization_attributes";
+    static LOG_TAG = 'authorization_attributes';
     /**
      * Upsert resource attributes synchronously, performing http call to the authorization MS to assign the given attributes to the given resource.
      * @param accountId
@@ -84,14 +84,14 @@ class AuthorizationAttributesService {
                 callerAppName: appName,
                 callerActionIdentifier: callerActionIdentifier,
                 operations: operations,
-            }
+            },
         };
         try {
             await sendToSns(payload, topicArn);
             return operations;
         }
         catch (error) {
-            logger.error({ error, tag: this.LOG_TAG }, "Authorization resource attributes async update: failed to send operations to SNS");
+            logger.error({ error, tag: this.LOG_TAG }, 'Authorization resource attributes async update: failed to send operations to SNS');
             return [];
         }
     }
@@ -122,14 +122,14 @@ class AuthorizationAttributesService {
         try {
             const requestedTopicArn = this.getSnsTopicArn();
             const attributes = await getTopicAttributes(requestedTopicArn);
-            const isHealthy = !(!attributes || !("TopicArn" in attributes) || attributes.TopicArn !== requestedTopicArn);
+            const isHealthy = !(!attributes || !('TopicArn' in attributes) || attributes.TopicArn !== requestedTopicArn);
             if (!isHealthy) {
-                logger.error({ requestedTopicArn, snsReturnedAttributes: attributes, tag: this.LOG_TAG }, "authorization-attributes-service failed in health check");
+                logger.error({ requestedTopicArn, snsReturnedAttributes: attributes, tag: this.LOG_TAG }, 'authorization-attributes-service failed in health check');
             }
             return isHealthy;
         }
         catch (error) {
-            logger.error({ error, tag: this.LOG_TAG }, "authorization-attributes-service got error during health check");
+            logger.error({ error, tag: this.LOG_TAG }, 'authorization-attributes-service got error during health check');
             return false;
         }
     }

package/dist/esm/authorization-internal-service.d.ts

@@ -1,5 +1,5 @@
-import { Request } from 'express';
 import { fetch, MondayFetchOptions } from '@mondaydotcomorg/monday-fetch';
+import type { Request } from 'express';
 export declare const logger: import("bunyan");
 export declare class AuthorizationInternalService {
     static skipAuthorization(requset: Request): void;

package/dist/esm/authorization-internal-service.mjs

@@ -6,6 +6,7 @@ const defaultMondayFetchOptions = {
     retries: 3,
     callback: logOnFetchFail,
 };
+const logger = MondayLogger.getLogger();
 function logOnFetchFail(retriesLeft, error) {
     if (retriesLeft == 0) {
         logger.error({ retriesLeft, error }, 'Authorization attempt failed due to network issues');
@@ -15,7 +16,6 @@ function logOnFetchFail(retriesLeft, error) {
     }
 }
 let mondayFetchOptions = defaultMondayFetchOptions;
-const logger = MondayLogger.getLogger();
 class AuthorizationInternalService {
     static skipAuthorization(requset) {
         requset.authorizationSkipPerformed = true;

package/dist/esm/authorization-middleware.d.ts

@@ -1,5 +1,5 @@
-import { NextFunction } from 'express';
 import { Action, BaseRequest, BaseResponse, Context, ContextGetter, ResourceGetter } from './types/general';
+import type { NextFunction } from 'express';
 export declare function getAuthorizationMiddleware(action: Action, resourceGetter: ResourceGetter, contextGetter?: ContextGetter): (request: BaseRequest, response: BaseResponse, next: NextFunction) => Promise<void>;
 export declare function skipAuthorizationMiddleware(request: BaseRequest, response: BaseResponse, next: NextFunction): void;
 export declare function authorizationCheckMiddleware(request: BaseRequest, response: BaseResponse, next: NextFunction): void;

package/dist/esm/authorization-service.d.ts

@@ -7,7 +7,6 @@ export interface AuthorizeResponse {
     unauthorizedObjects?: AuthorizationObject[];
 }
 export declare function setRequestFetchOptions(customMondayFetchOptions: MondayFetchOptions): void;
-export declare function setRedisClient(client: any, grantedFeatureRedisExpirationInSeconds?: number): void;
 export declare class AuthorizationService {
     static redisClient?: any;
     static grantedFeatureRedisExpirationInSeconds?: number;
@@ -27,3 +26,4 @@ export declare class AuthorizationService {
     private static isAuthorizedSingular;
     private static isAuthorizedMultiple;
 }
+export declare function setRedisClient(client: any, grantedFeatureRedisExpirationInSeconds?: number): void;

package/dist/esm/authorization-service.mjs

@@ -1,5 +1,5 @@
-import { mapKeys, snakeCase, camelCase } from 'lodash';
 import { performance } from 'perf_hooks';
+import { mapKeys, snakeCase, camelCase } from 'lodash';
 import { fetch } from '@mondaydotcomorg/monday-fetch';
 import { sendAuthorizationChecksPerRequestMetric, sendAuthorizationCheckResponseTimeMetric } from './prometheus-service.mjs';
 import { AuthorizationInternalService, logger } from './authorization-internal-service.mjs';
@@ -9,16 +9,6 @@ const GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS = 5 * 60;
 function setRequestFetchOptions(customMondayFetchOptions) {
     AuthorizationInternalService.setRequestFetchOptions(customMondayFetchOptions);
 }
-function setRedisClient(client, grantedFeatureRedisExpirationInSeconds = GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS) {
-    AuthorizationService.redisClient = client;
-    if (grantedFeatureRedisExpirationInSeconds && grantedFeatureRedisExpirationInSeconds > 0) {
-        AuthorizationService.grantedFeatureRedisExpirationInSeconds = grantedFeatureRedisExpirationInSeconds;
-    }
-    else {
-        logger.warn({ grantedFeatureRedisExpirationInSeconds }, 'Invalid input for grantedFeatureRedisExpirationInSeconds, must be positive number. using default ttl.');
-        AuthorizationService.grantedFeatureRedisExpirationInSeconds = GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS;
-    }
-}
 class AuthorizationService {
     static redisClient;
     static grantedFeatureRedisExpirationInSeconds;
@@ -34,27 +24,27 @@ class AuthorizationService {
         }
     }
     static async isUserGrantedWithFeature(accountId, userId, featureName, options = {}) {
-        let cachedKey = this.getCachedKeyName(userId, featureName);
+        const cachedKey = this.getCachedKeyName(userId, featureName);
         const shouldSkipCache = options.shouldSkipCache ?? false;
         if (this.redisClient && !shouldSkipCache) {
-            let grantedFeatureValue = await this.redisClient.get(cachedKey);
+            const grantedFeatureValue = await this.redisClient.get(cachedKey);
             if (!(grantedFeatureValue === undefined || grantedFeatureValue === null)) {
                 // redis returns the value as string
                 return grantedFeatureValue === 'true';
             }
         }
-        let grantedFeatureValue = await this.fetchIsUserGrantedWithFeature(featureName, accountId, userId);
+        const grantedFeatureValue = await this.fetchIsUserGrantedWithFeature(featureName, accountId, userId);
         if (this.redisClient) {
             await this.redisClient.set(cachedKey, grantedFeatureValue, 'EX', this.grantedFeatureRedisExpirationInSeconds);
         }
         return grantedFeatureValue;
     }
     static async fetchIsUserGrantedWithFeature(featureName, accountId, userId) {
-        let authorizationObject = {
+        const authorizationObject = {
             action: featureName,
             resource_type: 'feature',
         };
-        let authorizeResponsePromise = await this.isAuthorized(accountId, userId, [authorizationObject]);
+        const authorizeResponsePromise = await this.isAuthorized(accountId, userId, [authorizationObject]);
         return authorizeResponsePromise.isAuthorized;
     }
     static getCachedKeyName(userId, featureName) {
@@ -146,6 +136,16 @@ class AuthorizationService {
         return { isAuthorized: true };
     }
 }
+function setRedisClient(client, grantedFeatureRedisExpirationInSeconds = GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS) {
+    AuthorizationService.redisClient = client;
+    if (grantedFeatureRedisExpirationInSeconds && grantedFeatureRedisExpirationInSeconds > 0) {
+        AuthorizationService.grantedFeatureRedisExpirationInSeconds = grantedFeatureRedisExpirationInSeconds;
+    }
+    else {
+        logger.warn({ grantedFeatureRedisExpirationInSeconds }, 'Invalid input for grantedFeatureRedisExpirationInSeconds, must be positive number. using default ttl.');
+        AuthorizationService.grantedFeatureRedisExpirationInSeconds = GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS;
+    }
+}
 function createAuthorizationParams(resources, action) {
     const params = {
         authorizationObjects: resources.map((resource) => {

package/dist/esm/prometheus-service.mjs

@@ -31,7 +31,9 @@ function sendAuthorizationChecksPerRequestMetric(responseStatus, amountOfAuthori
             authorizationChecksPerRequestMetric.labels(responseStatus).observe(amountOfAuthorizationObjects);
         }
     }
-    catch (e) { }
+    catch (e) {
+        // ignore
+    }
 }
 function sendAuthorizationCheckResponseTimeMetric(resourceType, action, isAuthorized, responseStatus, time) {
     try {
@@ -39,7 +41,9 @@ function sendAuthorizationCheckResponseTimeMetric(resourceType, action, isAuthor
             authorizationCheckResponseTimeMetric.labels(resourceType, action, isAuthorized, responseStatus).observe(time);
         }
     }
-    catch (e) { }
+    catch (e) {
+        // ignore
+    }
 }
 
 export { METRICS, getMetricsManager, sendAuthorizationCheckResponseTimeMetric, sendAuthorizationChecksPerRequestMetric, setPrometheus };

package/dist/esm/testKit/index.d.ts

@@ -1,5 +1,5 @@
-import { NextFunction } from "express";
-import { Action, BaseRequest, BaseResponse, ContextGetter, Resource, ResourceGetter } from "../types/general";
+import { Action, BaseRequest, BaseResponse, ContextGetter, Resource, ResourceGetter } from '../types/general';
+import type { NextFunction } from 'express';
 export type TestPermittedAction = {
     accountId: number;
     userId: number;

package/dist/esm/testKit/index.mjs

@@ -10,20 +10,20 @@ const clearTestPermittedActions = () => {
 };
 const isActionAuthorized = (accountId, userId, resources, action) => {
     return {
-        isAuthorized: resources.every(resource => {
+        isAuthorized: resources.every(_ => {
             return testPermittedActions.some(combination => {
-                return combination.accountId === accountId &&
+                return (combination.accountId === accountId &&
                     combination.userId === userId &&
                     combination.action === action &&
                     combination.resources.some(combinationResource => {
                         return resources.some(resource => {
-                            return combinationResource.id === resource.id &&
+                            return (combinationResource.id === resource.id &&
                                 combinationResource.type === resource.type &&
-                                JSON.stringify(combinationResource.wrapperData) === JSON.stringify(resource.wrapperData);
+                                JSON.stringify(combinationResource.wrapperData) === JSON.stringify(resource.wrapperData));
                         });
-                    });
+                    }));
             });
-        })
+        }),
     };
 };
 const getTestAuthorizationMiddleware = (action, resourceGetter, contextGetter) => {

package/dist/esm/types/general.d.ts

@@ -1,16 +1,14 @@
-import { Request, Response } from 'express';
+import type { Request, Response } from 'express';
 export interface Resource {
     id?: number;
     type: string;
     wrapperData?: object;
 }
 export type Action = string;
-export type ResourceGetter = (request: BaseRequest) => Resource[];
 export interface Context {
     accountId: number;
     userId: number;
 }
-export type ContextGetter = (request: BaseRequest) => Context;
 export interface AuthorizationObject {
     resource_id?: Resource['id'];
     resource_type: Resource['type'];
@@ -20,11 +18,15 @@ export interface AuthorizationObject {
 export interface AuthorizationParams {
     authorizationObjects: AuthorizationObject[];
 }
-type BasicObject = {};
+type BasicObject = {
+    [key: string]: string;
+};
 export type BaseParameters = BasicObject;
 export type BaseResponseBody = BasicObject;
 export type BaseBodyParameters = BasicObject;
 export type BaseQueryParameters = BasicObject;
 export type BaseRequest = Request<BaseParameters, BaseResponseBody, BaseBodyParameters, BaseQueryParameters>;
 export type BaseResponse = Response<BaseResponseBody>;
+export type ResourceGetter = (request: BaseRequest) => Resource[];
+export type ContextGetter = (request: BaseRequest) => Context;
 export {};

package/dist/prometheus-service.js

@@ -33,7 +33,9 @@ function sendAuthorizationChecksPerRequestMetric(responseStatus, amountOfAuthori
             authorizationChecksPerRequestMetric.labels(responseStatus).observe(amountOfAuthorizationObjects);
         }
     }
-    catch (e) { }
+    catch (e) {
+        // ignore
+    }
 }
 function sendAuthorizationCheckResponseTimeMetric(resourceType, action, isAuthorized, responseStatus, time) {
     try {
@@ -41,7 +43,9 @@ function sendAuthorizationCheckResponseTimeMetric(resourceType, action, isAuthor
             authorizationCheckResponseTimeMetric.labels(resourceType, action, isAuthorized, responseStatus).observe(time);
         }
     }
-    catch (e) { }
+    catch (e) {
+        // ignore
+    }
 }
 
 exports.METRICS = METRICS;

package/dist/testKit/index.d.ts

@@ -1,5 +1,5 @@
-import { NextFunction } from "express";
-import { Action, BaseRequest, BaseResponse, ContextGetter, Resource, ResourceGetter } from "../types/general";
+import { Action, BaseRequest, BaseResponse, ContextGetter, Resource, ResourceGetter } from '../types/general';
+import type { NextFunction } from 'express';
 export type TestPermittedAction = {
     accountId: number;
     userId: number;

package/dist/testKit/index.js

@@ -12,20 +12,20 @@ const clearTestPermittedActions = () => {
 };
 const isActionAuthorized = (accountId, userId, resources, action) => {
     return {
-        isAuthorized: resources.every(resource => {
+        isAuthorized: resources.every(_ => {
             return testPermittedActions.some(combination => {
-                return combination.accountId === accountId &&
+                return (combination.accountId === accountId &&
                     combination.userId === userId &&
                     combination.action === action &&
                     combination.resources.some(combinationResource => {
                         return resources.some(resource => {
-                            return combinationResource.id === resource.id &&
+                            return (combinationResource.id === resource.id &&
                                 combinationResource.type === resource.type &&
-                                JSON.stringify(combinationResource.wrapperData) === JSON.stringify(resource.wrapperData);
+                                JSON.stringify(combinationResource.wrapperData) === JSON.stringify(resource.wrapperData));
                         });
-                    });
+                    }));
             });
-        })
+        }),
     };
 };
 const getTestAuthorizationMiddleware = (action, resourceGetter, contextGetter) => {

package/dist/types/general.d.ts

@@ -1,16 +1,14 @@
-import { Request, Response } from 'express';
+import type { Request, Response } from 'express';
 export interface Resource {
     id?: number;
     type: string;
     wrapperData?: object;
 }
 export type Action = string;
-export type ResourceGetter = (request: BaseRequest) => Resource[];
 export interface Context {
     accountId: number;
     userId: number;
 }
-export type ContextGetter = (request: BaseRequest) => Context;
 export interface AuthorizationObject {
     resource_id?: Resource['id'];
     resource_type: Resource['type'];
@@ -20,11 +18,15 @@ export interface AuthorizationObject {
 export interface AuthorizationParams {
     authorizationObjects: AuthorizationObject[];
 }
-type BasicObject = {};
+type BasicObject = {
+    [key: string]: string;
+};
 export type BaseParameters = BasicObject;
 export type BaseResponseBody = BasicObject;
 export type BaseBodyParameters = BasicObject;
 export type BaseQueryParameters = BasicObject;
 export type BaseRequest = Request<BaseParameters, BaseResponseBody, BaseBodyParameters, BaseQueryParameters>;
 export type BaseResponse = Response<BaseResponseBody>;
+export type ResourceGetter = (request: BaseRequest) => Resource[];
+export type ContextGetter = (request: BaseRequest) => Context;
 export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mondaydotcomorg/monday-authorization",
-  "version": "1.1.9-featuremosheauthorizationesm.3695+dabe70b1e",
+  "version": "1.1.9-featuremosheauthorizationesm.3696+a0b925038",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "license": "BSD-3-Clause",
@@ -23,8 +23,7 @@
     "@mondaydotcomorg/monday-jwt": "^3.0.14",
     "@mondaydotcomorg/monday-logger": "^4.0.11",
     "@mondaydotcomorg/monday-sns": "^1.0.6",
-    "@mondaydotcomorg/trident-backend-api": "^0.23.10",
-    "@types/lodash": "^4.17.10",
+    "@mondaydotcomorg/trident-backend-api": "^0.24.3",
     "lodash": "^4.17.21",
     "node-fetch": "^2.6.7",
     "on-headers": "^1.0.2",
@@ -33,27 +32,26 @@
   "devDependencies": {
     "@mondaydotcomorg/trident-library": "^0.6.53",
     "@types/express": "^4.17.20",
-    "@types/jest": "^27.4.1",
-    "@types/mocha": "^8.2.2",
+    "@types/lodash": "^4.17.10",
     "@types/on-headers": "^1.0.0",
     "@types/supertest": "^2.0.11",
     "express": "^4.17.1",
     "ioredis": "^5.2.4",
     "ioredis-mock": "^8.2.2",
-    "jest": "^27.5.1",
-    "mocha": "^9.0.1",
     "supertest": "^6.1.3",
-    "ts-jest": "^27.1.3",
-    "tsconfig-paths": "^3.9.0",
-    "typescript": "^5.1.6"
+    "typescript": "^5.2.2"
   },
   "files": [
     "dist/"
   ],
+  "eslintConfig": {
+    "extends": "@mondaydotcomorg/trident-library",
+    "root": true
+  },
   "trident": {
     "build": {
       "esmMjsRename": true
     }
   },
-  "gitHead": "dabe70b1ee6b4bee07fdd8ca06eb4944d62a4c96"
+  "gitHead": "a0b925038818937a00502a1f81800ec3b4789262"
 }