@mondaydotcomorg/monday-authorization 1.0.8 → 1.0.10

package/dist/lib/authorization-middleware.js

@@ -25,7 +25,7 @@ function getAuthorizationMiddleware(action, resourceGetter, contextGetter) {
             const isAuthorized = yield authorization_service_1.AuthorizationService.isAuthorized(accountId, userId, resources, action);
             authorization_internal_service_1.AuthorizationInternalService.markAuthorized(request);
             if (!isAuthorized) {
-                response.status(401).json({ message: 'Access denied' });
+                response.status(403).json({ message: 'Access denied' });
                 return;
             }
             next();
@@ -41,7 +41,9 @@ exports.skipAuthorizationMiddleware = skipAuthorizationMiddleware;
 function authorizationCheckMiddleware(request, response, next) {
     if (process.env.NODE_ENV === 'development' || process.env.NODE_ENV === 'test') {
         on_headers_1.default(response, function () {
-            authorization_internal_service_1.AuthorizationInternalService.failIfNotCoveredByAuthorization(request);
+            if (response.statusCode < 400) {
+                authorization_internal_service_1.AuthorizationInternalService.failIfNotCoveredByAuthorization(request);
+            }
         });
     }
     next();

package/dist/lib/authorization-service.js

@@ -34,7 +34,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.AuthorizationService = void 0;
 const monday_jwt_1 = require("@mondaydotcomorg/monday-jwt");
 const MondayLogger = __importStar(require("@mondaydotcomorg/monday-logger"));
-const node_fetch_1 = __importDefault(require("node-fetch"));
+const monday_fetch_1 = __importDefault(require("@mondaydotcomorg/monday-fetch"));
 const INTERNAL_APP_NAME = 'internal_ms';
 const URL = `${process.env.MONDAY_INTERNAL_URL}/internal_ms/authorization/authorize`;
 const IS_DEV_ENV = process.env.NODE_ENV === 'development';
@@ -45,7 +45,7 @@ class AuthorizationService {
         return __awaiter(this, void 0, void 0, function* () {
             const internalAuthToken = monday_jwt_1.signAuthorizationHeader(INTERNAL_APP_NAME, accountId);
             const params = createAuthorizationParams(resources, action);
-            const response = yield node_fetch_1.default(URL, {
+            const response = yield monday_fetch_1.default(URL, {
                 method: 'POST',
                 headers: { Authorization: internalAuthToken, 'Content-Type': 'application/json' },
                 timeout: REQUEST_TIMEOUT,
@@ -53,7 +53,7 @@ class AuthorizationService {
                     user_id: userId,
                     authorize_request_objects: params.authorizationObjects,
                 }),
-            });
+            }, { retries: 3, callback: logOnFetchFail });
             if (!response.ok) {
                 logger.error({ status: response.status }, 'Authorization middleware: authorization request failed');
                 return false;
@@ -92,3 +92,6 @@ function createAuthorizationParams(resources, action) {
     };
     return params;
 }
+function logOnFetchFail(retries, error, response) {
+    logger.error({ attempt: retries, error }, 'Authorization attempt failed due to network issues');
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mondaydotcomorg/monday-authorization",
-  "version": "1.0.8",
+  "version": "1.0.10",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "license": "BSD-3-Clause",
@@ -10,6 +10,7 @@
   },
   "dependencies": {
     "@mondaydotcomorg/monday-authentication": "^5.0.4",
+    "@mondaydotcomorg/monday-fetch": "^0.0.2",
     "@mondaydotcomorg/monday-jwt": "^2.0.4",
     "@mondaydotcomorg/monday-logger": "^2.1.2",
     "@types/express": "^4.17.12",
@@ -30,5 +31,5 @@
   "files": [
     "dist/"
   ],
-  "gitHead": "d5e5facf35ce8e4258f753f0369100acd5561c8b"
+  "gitHead": "27da993cbc76e1787a3a006ee5f78df9a1192ff9"
 }