@mondaydotcomorg/monday-authorization 1.0.44-featureyoniadd-granted-feature-sdk-api.560 → 1.0.44-featureyuvalflexible-dependencies-types.283

package/README.md

@@ -15,7 +15,7 @@ show is the action, post is the resource.
 ```
 yarn add @mondaydotcomorg/monday-authorization
 ```
-
+First init the package in order for it to work properly <br>
 app.ts:
 
 ```ts

package/dist/lib/authorization-service.d.ts

@@ -7,8 +7,8 @@ export interface AuthorizeResponse {
 export declare function setRequestFetchOptions(customMondayFetchOptions: MondayFetchOptions): void;
 export declare function setRedisClient(client: any, grantedFeatureRedisExpirationInSeconds?: number): void;
 export declare class AuthorizationService {
-    static redisClient: any;
-    static grantedFeatureRedisExpirationInSeconds: number;
+    static redisClient?: any;
+    static grantedFeatureRedisExpirationInSeconds?: number;
     /**
      * @deprecated use the second form with authorizationRequestObjects instead,
      * support of this function will be dropped gradually
@@ -17,7 +17,7 @@ export declare class AuthorizationService {
     static isAuthorized(accountId: number, userId: number, authorizationRequestObjects: AuthorizationObject[]): Promise<AuthorizeResponse>;
     static isUserGrantedWithFeature(accountId: number, userId: number, featureName: string): Promise<boolean>;
     private static fetchIsUserGrantedWithFeature;
-    private static getCachedKey;
+    private static getCachedKeyName;
     private static isAuthorizedSingular;
     private static isAuthorizedMultiple;
 }

package/dist/lib/authorization-service.js

@@ -36,6 +36,7 @@ const monday_fetch_1 = require("@mondaydotcomorg/monday-fetch");
 const prometheus_service_1 = require("./prometheus-service");
 const INTERNAL_APP_NAME = 'internal_ms';
 const logger = MondayLogger.getLogger();
+const GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS = 5 * 60;
 const defaultMondayFetchOptions = {
     retries: 3,
     callback: logOnFetchFail,
@@ -45,11 +46,15 @@ function setRequestFetchOptions(customMondayFetchOptions) {
     mondayFetchOptions = Object.assign(Object.assign({}, defaultMondayFetchOptions), customMondayFetchOptions);
 }
 exports.setRequestFetchOptions = setRequestFetchOptions;
-function setRedisClient(client, grantedFeatureRedisExpirationInSeconds = 5 * 60) {
+function setRedisClient(client, grantedFeatureRedisExpirationInSeconds = GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS) {
     AuthorizationService.redisClient = client;
     if (grantedFeatureRedisExpirationInSeconds && grantedFeatureRedisExpirationInSeconds > 0) {
         AuthorizationService.grantedFeatureRedisExpirationInSeconds = grantedFeatureRedisExpirationInSeconds;
     }
+    else {
+        logger.warn({ grantedFeatureRedisExpirationInSeconds }, 'Invalid input for grantedFeatureRedisExpirationInSeconds, must be positive number. using default ttl.');
+        AuthorizationService.grantedFeatureRedisExpirationInSeconds = GRANTED_FEATURE_CACHE_EXPIRATION_SECONDS;
+    }
 }
 exports.setRedisClient = setRedisClient;
 class AuthorizationService {
@@ -68,7 +73,7 @@ class AuthorizationService {
     }
     static isUserGrantedWithFeature(accountId, userId, featureName) {
         return __awaiter(this, void 0, void 0, function* () {
-            let cachedKey = this.getCachedKey(userId, featureName);
+            let cachedKey = this.getCachedKeyName(userId, featureName);
             if (this.redisClient) {
                 let grantedFeatureValue = yield this.redisClient.get(cachedKey);
                 if (!(grantedFeatureValue === undefined || grantedFeatureValue === null)) {
@@ -93,7 +98,7 @@ class AuthorizationService {
             return authorizeResponsePromise.isAuthorized;
         });
     }
-    static getCachedKey(userId, featureName) {
+    static getCachedKeyName(userId, featureName) {
         return `granted-feature-${featureName}-${userId}`;
     }
     static isAuthorizedSingular(accountId, userId, resources, action) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mondaydotcomorg/monday-authorization",
-  "version": "1.0.44-featureyoniadd-granted-feature-sdk-api.560+aa13dbf4",
+  "version": "1.0.44-featureyuvalflexible-dependencies-types.283+83f3cbe7",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "license": "BSD-3-Clause",
@@ -11,7 +11,7 @@
   "dependencies": {
     "@mondaydotcomorg/monday-fetch": "^0.0.7",
     "@mondaydotcomorg/monday-jwt": "^2.0.4",
-    "@mondaydotcomorg/monday-logger": "^3.0.7",
+    "@mondaydotcomorg/monday-logger": "^3.0.8-featureyuvalflexible-dependencies-types.283+83f3cbe7",
     "@types/express": "^4.17.12",
     "node-fetch": "^2.6.7",
     "ts-node": "^10.0.0"
@@ -21,7 +21,7 @@
     "@types/on-headers": "^1.0.0",
     "@types/supertest": "^2.0.11",
     "express": "^4.17.1",
-    "ioredis": "^5.2.3",
+    "ioredis": "^5.2.4",
     "ioredis-mock": "^8.2.2",
     "mocha": "^9.0.1",
     "on-headers": "^1.0.2",
@@ -32,5 +32,5 @@
   "files": [
     "dist/"
   ],
-  "gitHead": "aa13dbf433d5ef55c0b59c19fedab103d4d707b4"
+  "gitHead": "83f3cbe727ed46a5a36f35122b7ced4be22bbea2"
 }