@mondaydotcomorg/monday-authorization 1.0.18 → 1.0.20

package/dist/lib/authorization-service.js

@@ -38,9 +38,6 @@ const MondayLogger = __importStar(require("@mondaydotcomorg/monday-logger"));
 const monday_fetch_1 = __importDefault(require("@mondaydotcomorg/monday-fetch"));
 const prometheus_service_1 = require("./prometheus-service");
 const INTERNAL_APP_NAME = 'internal_ms';
-const URL = `${process.env.MONDAY_INTERNAL_URL}/internal_ms/authorization/authorize`;
-const IS_DEV_ENV = process.env.NODE_ENV === 'development';
-const REQUEST_TIMEOUT = IS_DEV_ENV ? 60000 : 2000;
 const logger = MondayLogger.getLogger();
 class AuthorizationService {
     static isAuthorized(accountId, userId, resources, action) {
@@ -48,10 +45,10 @@ class AuthorizationService {
             const internalAuthToken = monday_jwt_1.signAuthorizationHeader(INTERNAL_APP_NAME, accountId);
             const { authorizationObjects } = createAuthorizationParams(resources, action);
             const startTime = perf_hooks_1.performance.now();
-            const response = yield monday_fetch_1.default(URL, {
+            const response = yield monday_fetch_1.default(getUrl(), {
                 method: 'POST',
                 headers: { Authorization: internalAuthToken, 'Content-Type': 'application/json' },
-                timeout: REQUEST_TIMEOUT,
+                timeout: getRequestTimeout(),
                 body: JSON.stringify({
                     user_id: userId,
                     authorize_request_objects: authorizationObjects,
@@ -82,7 +79,7 @@ class AuthorizationService {
                 logger.info({
                     resources: JSON.stringify(unauthorizedObjects),
                 }, 'AuthorizationService: resource is unauthorized');
-                const unauthorizedIds = unauthorizedObjects.map(obj => obj.resource_id);
+                const unauthorizedIds = unauthorizedObjects.filter(obj => !!obj.resource_id).map(obj => obj.resource_id);
                 return { isAuthorized: false, unauthorizedIds };
             }
             return { isAuthorized: true };
@@ -109,3 +106,10 @@ function createAuthorizationParams(resources, action) {
 function logOnFetchFail(retries, error, response) {
     logger.error({ attempt: retries, error }, 'Authorization attempt failed due to network issues');
 }
+function getUrl() {
+    return `${process.env.MONDAY_INTERNAL_URL}/internal_ms/authorization/authorize`;
+}
+function getRequestTimeout() {
+    const isDevEnv = process.env.NODE_ENV === 'development';
+    return isDevEnv ? 60000 : 2000;
+}

package/dist/lib/types/general.d.ts

@@ -1,6 +1,6 @@
 import { Request, Response } from 'express';
 export interface Resource {
-    id: number;
+    id?: number;
     type: string;
     wrapperData?: object;
 }
@@ -12,7 +12,7 @@ export interface Context {
 }
 export declare type ContextGetter = (request: BaseRequest) => Context;
 export interface AuthorizationObject {
-    resource_id: Resource['id'];
+    resource_id?: Resource['id'];
     resource_type: Resource['type'];
     wrapper_data?: Resource['wrapperData'];
     action: Action;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mondaydotcomorg/monday-authorization",
-  "version": "1.0.18",
+  "version": "1.0.20",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "license": "BSD-3-Clause",
@@ -31,5 +31,5 @@
   "files": [
     "dist/"
   ],
-  "gitHead": "003096557ca719ae941f421a0960c170e74d5cc1"
+  "gitHead": "885a2695f0c341cf28613bb0a49d26a2c96d01d7"
 }