@momsfriendlydevco/eslint-config 2.2.1 → 2.3.1

package/index.js

@@ -1,4 +1,5 @@
 import eslintParser from 'vue-eslint-parser';
+import globals from 'globals';
 import pluginEslintJS from '@eslint/js';
 import pluginJSDoc from 'eslint-plugin-jsdoc';
 import pluginUnicorn from 'eslint-plugin-unicorn';
@@ -12,15 +13,17 @@ export let JSCommon = {
 	// Generic rules
 	'html-closing-bracket-spacing': ['off'], // Annoying doesn't allow <this-kind-of-thing/>
 	'no-debugger': ['warn'], // Debuggers are fine, just warn
+	'no-extra-boolean-cast': ['off'], // ESlint being a mama bear over boolean casting shorthand (`!!thing`)
 	'no-useless-escape': ['off'], // ESlint frequently gets what should and shouldn't be escaped wrong
 	'no-unused-vars': ['warn'], // Dont make unused vars the end of the world
 
 	// JSDoc
 	'jsdoc/check-alignment': ['off'],  // Disable the JSDoc parser insisting on correct indents
 	'jsdoc/check-tag-names': ['warn', { // Extend JSDoc allowed tags
-		definedTags: ['date', 'fixme', 'note', 'slot', 'url'],
+		definedTags: ['date', 'env', 'fixme', 'note', 'slot', 'url'],
 	}],
 	'jsdoc/check-types': ['off'], // Disable the JSDoc parser being fussy about `@param {String}` vs `@param {string}`
+	'jsdoc/empty-tags': ['off'], // Disable JSDoc being fussy about using stuff like `@override` with any other description parts
 	'jsdoc/no-defaults': ['off'], // Disable the JSDoc parser that complains about optional params as its just silly
 	'jsdoc/no-undefined-types': ['warn', {disableReporting: true}], // Disable the JSDoc parser for "undefined" types which it usually gets wrong. Ask eslint to still mark these as used though
 	'jsdoc/require-returns-description': ['off'], // Disable the JSDoc parse being fussy about return descriptions
@@ -28,23 +31,18 @@ export let JSCommon = {
 };
 
 export default [
+
 	// Generic globals {{{
 	{
 		languageOptions: {
 			globals: {
-				clearInterval: 'readonly',
-				clearTimeout: 'readonly',
-				console: 'readonly',
-				fetch: 'readonly',
-				setInterval: 'readonly',
-				setTimeout: 'readonly',
-				window: 'readonly',
+				...globals.node,
 			},
 		},
 	},
 	// }}}
 
-	// eslint-plugin-jsdoc (with custom settings)
+	// eslint-plugin-jsdoc (with custom settings) {{{
 	{
 		...pluginJSDoc.configs['flat/recommended'],
 		settings: {
@@ -60,6 +58,7 @@ export default [
 			},
 		},
 	},
+	// }}}
 
 	// eslint-plugin-unicorn {{{
 	{
@@ -101,14 +100,31 @@ export default [
 	...pluginVue.configs['flat/recommended'],
 	// }}}
 
+	// Cloudflare workers {{{
+	{
+		files: ['**/workers/**/*.js'],
+
+		// Wrangler ignore rules
+		languageOptions: {
+			globals: {
+				// Global Cloudflare Worker Classes
+				...globals.worker,
+			},
+		},
+		rules: {
+			...JSCommon,
+		},
+	},
+	// }}}
+
 	// .doop backend Files {{{
 	{
 		files: ['**/*.doop'],
 		languageOptions: {
 			parser: eslintParser,
 			globals: {
-				app: 'readable', // Global backend App object
-				db: 'readable', // Global app.db shortcut
+				app: 'readonly', // Global backend App object
+				db: 'readonly', // Global app.db shortcut
 			},
 		},
 		rules: {
@@ -121,19 +137,25 @@ export default [
 	// .mjs / .js regular files {{{
 	{
 		files: ['**/*.js', '**/*.mjs'],
+		languageOptions: {
+			globals: {
+				...globals.node,
+			},
+		},
 		rules: {
 			...JSCommon,
 		},
 	},
 	// }}}
 
-	// Mocha test files {{{
+	// Mocha/Chai test files {{{
 	{
 		files: ['**/test/**/*.js'],
 		languageOptions: {
 			globals: {
-				it: 'readonly',
-				describe: 'readonly',
+				...globals.chai,
+				...globals.mocha,
+				...globals.node,
 			},
 		},
 	},
@@ -144,11 +166,10 @@ export default [
 		files: ['**/*.vue'],
 		languageOptions: {
 			globals: {
-				$: 'readable', // jQuery
-				_: 'readable', // Lodash
-				app: 'readable', // Global frontend app object
-				document: 'readable',
-				window: 'readable',
+				// Not-really-a-thing-but-I'll-allow-it globals
+				app: 'readonly', // Generally the Vue.$root frontend app object
+
+				...globals.browser,
 			},
 			parser: eslintParser,
 			parserOptions: {
@@ -273,4 +294,5 @@ export default [
 		},
 	},
 	// }}}
+
 ]

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@momsfriendlydevco/eslint-config",
   "description": "ESLint plugin for @MomsFriendlyDevCo projects",
-  "version": "2.2.1",
+  "version": "2.3.1",
   "type": "module",
   "scripts": {
     "test": "eslint --config index.js test/data"
@@ -24,10 +24,11 @@
   },
   "homepage": "https://github.com/MomsFriendlyDevCo/eslint#readme",
   "dependencies": {
-    "eslint-plugin-jsdoc": "^51.0.1",
+    "eslint-plugin-jsdoc": "^51.3.4",
     "eslint-plugin-unicorn": "^59.0.1",
-    "eslint-plugin-vue": "^10.2.0",
-    "vue-eslint-parser": "^10.1.3"
+    "eslint-plugin-vue": "^10.3.0",
+    "globals": "^16.3.0",
+    "vue-eslint-parser": "^10.2.0"
   },
   "peerDependencies": {
     "eslint": "^9.26.0"