@momsfriendlydevco/eslint-config 2.0.5 → 2.1.1

package/index.js

@@ -1,5 +1,6 @@
 import eslintParser from 'vue-eslint-parser';
 import pluginJSDoc from 'eslint-plugin-jsdoc';
+import pluginUnicorn from 'eslint-plugin-unicorn';
 import pluginVue from 'eslint-plugin-vue';
 
 // Rules shared by both .doop + .vue files
@@ -40,6 +41,38 @@ export default [
 		},
 	},
 
+	// eslint-plugin-unicorn
+	{
+		...pluginUnicorn.configs['flat/recommended'],
+		rules: {
+			...pluginUnicorn.configs['flat/recommended'].rules,
+			'unicorn/no-anonymous-default-export': ['off'],
+			'unicorn/prefer-string-replace-all': ['off'], // Gets annoying pretty fast and its rarely correct
+			'unicorn/prefer-dom-node-append': ['warn'],
+			'unicorn/prefer-global-this': ['warn'], // Disabled in .vue files to allow 'window' directly
+			'unicorn/prefer-ternary': ['warn'],
+			'unicorn/no-magic-array-flat-depth': ['warn'],
+			'unicorn/switch-case-braces': ['warn', 'avoid'],
+			'unicorn/consistent-function-scoping': ['off'], // This rule means well and its more optimal but makes functions with constants harder to read
+			'unicorn/prefer-ternary': ['off'], // This rule means well but it can screw up perfectly readable code
+			'unicorn/catch-error-name': ['off'],
+			'unicorn/explicit-length-check': ['off'],
+			'unicorn/filename-case': ['off'], // Disabled globally (gets re-enabled for .vue files)
+			'unicorn/no-array-callback-reference': ['off'], // Overly aggressively attaches itself to all .find() operations
+			'unicorn/no-await-expression-member': ['off'], // There is nothing wrong with `(await thing).prop`
+			'unicorn/no-empty-file': ['off'], // Breaks interface files + schema files with just JSDoc
+			'unicorn/prefer-logical-operator-over-ternary': ['off'],
+			'unicorn/prefer-string-raw': ['off'], // Just a downright weird rule
+			'unicorn/prefer-spread': ['off'],
+			'unicorn/no-array-reduce': ['off'],
+			'unicorn/no-nested-ternary': ['off'],
+			'unicorn/no-negated-condition': ['off'],
+			'unicorn/no-array-for-each': ['off'],
+			'unicorn/no-null': ['off'],
+			'unicorn/prevent-abbreviations': ['off'],
+		},
+	},
+
 	// eslint-plugin-vue
 	...pluginVue.configs['flat/recommended'],
 
@@ -118,7 +151,12 @@ export default [
 			'vue/html-closing-bracket-spacing': ['warn', {
 				selfClosingTag: 'never'
 			}],
-			'vue/html-indent': ['warn', 'tab'],
+			'vue/html-indent': ['warn', 'tab', {
+				ignores: [ // Don't enforce indent rules for attributes that get complicated
+					'[class]',
+					'[v-tooltip]',
+				],
+			}],
 			'vue/html-self-closing': ['warn', {
 				html: {
 					void: 'always',
@@ -175,6 +213,15 @@ export default [
 				ignoreWhenNoAttributes: true,
 				ignores: ['pre', 'textarea', 'div', 'INLINE_ELEMENTS'],
 			}],
+
+			'unicorn/prefer-global-this': ['off'], // Allow direct use of `window.`
+			'unicorn/filename-case': ['warn', {
+				case: 'kebabCase',
+				ignore: [
+					'^App.vue$', // Vite projects
+				],
+			}],
+
 			...jsCommonRules,
 		},
 	},

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@momsfriendlydevco/eslint-config",
   "description": "ESLint plugin for @MomsFriendlyDevCo projects",
-  "version": "2.0.5",
+  "version": "2.1.1",
   "type": "module",
   "scripts": {
     "test": "eslint --config index.js test/data"
@@ -24,8 +24,9 @@
   },
   "homepage": "https://github.com/MomsFriendlyDevCo/eslint#readme",
   "dependencies": {
-    "eslint-plugin-jsdoc": "^48.8.3",
-    "eslint-plugin-vue": "^9.27.0",
+    "eslint-plugin-jsdoc": "^50.6.2",
+    "eslint-plugin-unicorn": "^56.0.1",
+    "eslint-plugin-vue": "^9.32.0",
     "vue-eslint-parser": "^9.4.3"
   },
   "peerDependencies": {