@momo-kits/foundation 0.169.4 → 0.169.5-beta.1

package/Application/__tests__/KitAdoptionStore.test.ts

@@ -0,0 +1,110 @@
+import { AdoptionStore } from '../KitAdoption/AdoptionStore';
+import type { ScreenSnapshot } from '../KitAdoption/types';
+
+/** Snapshot with the given K/R/O counts for one app and screen. */
+const makeSnapshot = (
+  screen: string,
+  counts: { K: number; R: number; O: number },
+  appId = 'app-1',
+): ScreenSnapshot => ({
+  counts,
+  kit: {},
+  rn: {},
+  other: {},
+  top_transparent: [],
+  fibers: 0,
+  truncated: false,
+  status: 'ok',
+  app_id: appId,
+  screen_name: screen,
+  platform: 'ios',
+  ts: 0,
+  walk_ms: 0,
+});
+
+describe('AdoptionStore save', () => {
+  it('keeps the existing snapshot when it has more nodes', () => {
+    const store = new AdoptionStore();
+    store.save(makeSnapshot('Home', { K: 3, R: 0, O: 0 }));
+    store.save(makeSnapshot('Home', { K: 1, R: 0, O: 0 }));
+
+    expect(store.getAll()).toHaveLength(1);
+    expect(store.getAll()[0].counts.K).toBe(3);
+  });
+
+  it('replaces the existing snapshot when the new one has more nodes', () => {
+    const store = new AdoptionStore();
+    store.save(makeSnapshot('Home', { K: 1, R: 0, O: 0 }));
+    store.save(makeSnapshot('Home', { K: 2, R: 2, O: 1 }));
+
+    expect(store.getAll()[0].counts).toEqual({ K: 2, R: 2, O: 1 });
+  });
+
+  it('keys snapshots by app and screen', () => {
+    const store = new AdoptionStore();
+    store.save(makeSnapshot('Home', { K: 1, R: 0, O: 0 }, 'app-1'));
+    store.save(makeSnapshot('Home', { K: 1, R: 0, O: 0 }, 'app-2'));
+
+    expect(store.getAll()).toHaveLength(2);
+  });
+
+  it('getLatest returns the most recently saved screen', () => {
+    const store = new AdoptionStore();
+    store.save(makeSnapshot('Home', { K: 1, R: 0, O: 0 }));
+    store.save(makeSnapshot('Detail', { K: 1, R: 0, O: 0 }));
+
+    expect(store.getLatest()?.screen_name).toBe('Detail');
+  });
+
+  it('clear empties the store and getLatest', () => {
+    const store = new AdoptionStore();
+    store.save(makeSnapshot('Home', { K: 1, R: 0, O: 0 }));
+    store.clear();
+
+    expect(store.getAll()).toEqual([]);
+    expect(store.getLatest()).toBeUndefined();
+  });
+});
+
+describe('AdoptionStore subscribe', () => {
+  it('notifies listeners on save and stops after unsubscribe', () => {
+    const store = new AdoptionStore();
+    const listener = jest.fn();
+    const unsubscribe = store.subscribe(listener);
+
+    store.save(makeSnapshot('Home', { K: 1, R: 0, O: 0 }));
+    expect(listener).toHaveBeenCalledTimes(1);
+
+    unsubscribe();
+    store.save(makeSnapshot('Detail', { K: 1, R: 0, O: 0 }));
+    expect(listener).toHaveBeenCalledTimes(1);
+  });
+});
+
+describe('AdoptionStore active measurer', () => {
+  it('remeasureActive calls the active measurer', () => {
+    const store = new AdoptionStore();
+    const measure = jest.fn();
+    store.setActive(measure);
+
+    store.remeasureActive();
+
+    expect(measure).toHaveBeenCalledTimes(1);
+  });
+
+  it('clearActive only clears the measurer that is still active', () => {
+    const store = new AdoptionStore();
+    const first = jest.fn();
+    const second = jest.fn();
+    store.setActive(first);
+    store.setActive(second);
+
+    store.clearActive(first);
+    store.remeasureActive();
+    expect(second).toHaveBeenCalledTimes(1);
+
+    store.clearActive(second);
+    store.remeasureActive();
+    expect(second).toHaveBeenCalledTimes(1);
+  });
+});

package/Application/__tests__/modalLayout.test.ts

@@ -16,10 +16,10 @@ describe('getModalLayout', () => {
     expect(layout.isFoldable).toBe(false);
     expect(layout.popup.width).toBe(342);
     expect(layout.popup.maxHeight).toBeUndefined();
-    expect(layout.popup.radius).toBe(24);
+    expect(layout.popup.radius).toBe(16);
     expect(layout.sheet.width).toBeUndefined();
     expect(layout.sheet.maxHeight).toBeUndefined();
-    expect(layout.sheet.radius).toBe(24);
+    expect(layout.sheet.radius).toBe(12);
     expect(layout.scrimOpacity).toBe(0.6);
   });
 
@@ -33,7 +33,7 @@ describe('getModalLayout', () => {
     expect(layout.isFoldable).toBe(false);
     expect(layout.popup.width).toBe(844 - 48);
     expect(layout.popup.maxHeight).toBeUndefined();
-    expect(layout.popup.radius).toBe(24);
+    expect(layout.popup.radius).toBe(16);
     expect(layout.sheet.width).toBeUndefined();
     expect(layout.scrimOpacity).toBe(0.6);
   });

package/Application/modalLayout.ts

@@ -112,9 +112,9 @@ const getModalLayout = ({
         minWidth: popupWidth,
         maxWidth: popupWidth,
         margin: Spacing.XL,
-        radius: Radius.XL,
+        radius: Radius.L,
       },
-      sheet: { margin: 0, radius: Radius.XL },
+      sheet: { margin: 0, radius: Radius.M },
       scrimOpacity: SCRIM_OPACITY,
     };
   }

package/Popup/PopupNotify.tsx

@@ -183,12 +183,18 @@ const PopupNotify: React.FC<PopupNotifyProps> = ({
   const body = (
     <>
       {!!image && (
-        <Image source={{ uri: image }} style={styles.image} />
+        <Image
+          source={{ uri: image }}
+          style={[
+            styles.image,
+            { borderTopLeftRadius: radius, borderTopRightRadius: radius },
+          ]}
+        />
       )}
       <View style={[styles.content, isFoldable && styles.shrink]}>
         <Text
           typography={'header_default_bold'}
-          numberOfLines={2}
+          numberOfLines={3}
           accessibilityLabel={'title_popup_notify'}
           // keeps the title clear of the close button on a text only popup
           style={
@@ -244,7 +250,6 @@ const PopupNotify: React.FC<PopupNotifyProps> = ({
           width: popupWidth,
           maxHeight,
         },
-        styles.card,
         showBaseLineDebug && styles.debugBaseLine,
       ]}
     >
@@ -257,10 +262,9 @@ const PopupNotify: React.FC<PopupNotifyProps> = ({
 
 const styles = StyleSheet.create({
   debugBaseLine: { borderWidth: 1, borderColor: Colors.green_06 },
-  // clips the image and content to the card radius
-  card: { overflow: 'hidden' },
   image: {
     aspectRatio: 1.7777,
+    overflow: 'hidden',
   },
   shrink: { flexShrink: 1 },
   content: { padding: Spacing.XL },

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@momo-kits/foundation",
-    "version": "0.169.4",
+    "version": "0.169.5-beta.1",
     "description": "React Native Component Kits",
     "main": "index.ts",
     "scripts": {},