@momo-kits/foundation 0.164.1-beta.2 → 0.164.1-beta.4

package/Application/utils.tsx

@@ -374,14 +374,28 @@ const getSwipeGestureValue = (
  * one light tick once the swipe back has travelled far enough to read as
  * recognised. iOS only, mirroring `gestureEnabled` in getStackOptions.
  *
- * the listener is scoped to the `swiping === 1` window on purpose: the same
- * animated value also drives the programmatic push and pop animations, so an
- * unscoped listener would buzz on every navigation.
+ * both listeners are installed on mount and never lazily inside the gesture:
+ * on the New Architecture `addListener` queues `startListeningToAnimatedNodeValue`
+ * via `queueOperationBlock`, and that queue is only drained by a React mount
+ * commit — which never happens during a native driven pan. subscribing when the
+ * swipe starts installs an observer that the release flush tears down again
+ * before a single frame is delivered, so it must stay on mount.
+ *
+ * `gesture` also drives the programmatic push and pop animations, so it is the
+ * JS `isSwiping` flag, not the subscription lifetime, that keeps the tick
+ * exclusive to a real finger drag.
  */
 const useSwipeBackHaptic = () => {
   const { navigator } = useContext<any>(ApplicationContext);
   const animation = useContext(CardAnimationContext);
 
+  /**
+   * the latch has to outlive the effect. `animation` identity changes on every
+   * navigator render, so a `hasFired` local re-arms several times per drag and
+   * the tick then repeats on every frame past the threshold
+   */
+  const hasFired = useRef(false);
+
   useEffect(() => {
     if (Platform.OS !== 'ios' || !animation) {
       return;
@@ -393,47 +407,44 @@ const useSwipeBackHaptic = () => {
       return;
     }
 
-    let hasFired = false;
-    let gestureListener: string | undefined;
+    /**
+     * `animation` identity is not stable, so this effect can re-run mid swipe.
+     * seed from the live value instead of waiting for a 0 -> 1 transition that
+     * has already been missed
+     */
+    let isSwiping = readAnimatedValue(swiping, 0) === 1;
 
-    const detachGesture = () => {
-      if (gestureListener !== undefined) {
-        gesture.removeListener(gestureListener);
-        gestureListener = undefined;
-      }
-      hasFired = false;
-    };
+    /**
+     * sign, not magnitude: a leftward overdrag reports a negative
+     * translation and must not count as progress toward dismissal
+     */
+    const direction = readAnimatedValue(inverted, 1);
 
     const swipingListener = swiping.addListener(({ value }) => {
-      if (value !== 1) {
-        detachGesture();
+      isSwiping = value === 1;
+      if (!isSwiping) {
+        hasFired.current = false;
+      }
+    });
+
+    const gestureListener = gesture.addListener(({ value: translation }) => {
+      if (!isSwiping) {
         return;
       }
 
-      if (gestureListener !== undefined) {
+      if (translation * direction < SWIPE_BACK_HAPTIC_THRESHOLD) {
+        hasFired.current = false;
         return;
       }
 
-      /**
-       * sign, not magnitude: a leftward overdrag reports a negative
-       * translation and must not count as progress toward dismissal
-       */
-      const direction = readAnimatedValue(inverted, 1);
-      gestureListener = gesture.addListener(({ value: translation }) => {
-        if (translation * direction < SWIPE_BACK_HAPTIC_THRESHOLD) {
-          hasFired = false;
-          return;
-        }
-
-        if (!hasFired) {
-          hasFired = true;
-          navigator?.maxApi?.triggerEventVibration?.('light');
-        }
-      });
+      if (!hasFired.current) {
+        hasFired.current = true;
+        navigator?.maxApi?.triggerEventVibration?.('light');
+      }
     });
 
     return () => {
-      detachGesture();
+      gesture.removeListener(gestureListener);
       swiping.removeListener(swipingListener);
     };
   }, [animation, navigator]);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@momo-kits/foundation",
-    "version": "0.164.1-beta.2",
+    "version": "0.164.1-beta.4",
     "description": "React Native Component Kits",
     "main": "index.ts",
     "scripts": {},