@momo-kits/camerakit 0.161.2-beta.2 → 0.161.2-beta.26

package/ios/ReactNativeCameraKit/CameraView.swift

@@ -71,6 +71,10 @@ public class CameraView: UIView {
 
     // This is used to delay camera setup until we have both granted permission & received default props
     var hasCameraBeenSetup = false
+    // [CKCameraKit][perf] TEMP measurement — remove before publish. Captured when the
+    // view is constructed so we can see how long the OUTSIDE path (permission grant +
+    // first props) takes before camera.setup() is even called.
+    private let viewCreatedAt = CFAbsoluteTimeGetCurrent()
     var hasPropBeenSetup = false {
         didSet {
             setupCamera()
@@ -84,6 +88,8 @@ public class CameraView: UIView {
     private func setupCamera() {
         if hasPropBeenSetup && hasPermissionBeenGranted && !hasCameraBeenSetup {
             hasCameraBeenSetup = true
+            // [CKCameraKit][perf] TEMP measurement — remove before publish.
+            print(String(format: "[CKCameraKit][perf] view→setupCalled=%.0fms (permission+props before setup)", (CFAbsoluteTimeGetCurrent() - viewCreatedAt) * 1000))
             #if targetEnvironment(macCatalyst)
             // Force front camera on Mac Catalyst during initial setup
             camera.setup(cameraType: .front, supportedBarcodeType: scanBarcode && onReadCode != nil ? supportedBarcodeType : [])

package/ios/ReactNativeCameraKit/RealCamera.swift

@@ -72,6 +72,23 @@ class RealCamera: NSObject, CameraProtocol, AVCaptureMetadataOutputObjectsDelega
 
     // MARK: - Lifecycle
 
+    override init() {
+        super.init()
+        #if DEBUG
+        assert(Thread.isMainThread, "RealCamera must be initialized on the main thread (it wires the preview CALayer).")
+        #endif
+        // Wire the preview to the (idle, never-started) session AND set its gravity
+        // ONCE here at init, on the main thread, before anything starts. Benefits:
+        //  (a) the preview renders the instant the first frame arrives (~camera warm-up)
+        //      instead of waiting for a late post-setup attach → less black.
+        //  (b) assigning previewLayer.session opens an implicit AVFoundation config
+        //      transaction; doing it now (session idle, no startRunning yet, never
+        //      reassigned) makes it impossible to race startRunning() → the begin/commit
+        //      crash class is closed by construction, on every device.
+        cameraPreview.session = session
+        cameraPreview.previewLayer.videoGravity = .resizeAspectFill
+    }
+
     func cameraRemovedFromSuperview() {
         sessionQueue.async { [weak self] in
             guard let self, self.setupResult == .success else { return }
@@ -114,8 +131,11 @@ class RealCamera: NSObject, CameraProtocol, AVCaptureMetadataOutputObjectsDelega
     // MARK: - Public
 
     func setup(cameraType: CameraType, supportedBarcodeType: [CodeFormat]) {
+        // [CKCameraKit][perf] TEMP measurement — remove before publish.
+        let tCall = CFAbsoluteTimeGetCurrent()
         sessionQueue.async { [weak self] in
             guard let self else { return }
+            let tBlock = CFAbsoluteTimeGetCurrent()
 
             // Idempotency guard: a RealCamera configures its session exactly once.
             // A fresh instance is created on every mount / Fabric recycle, so this
@@ -133,24 +153,33 @@ class RealCamera: NSObject, CameraProtocol, AVCaptureMetadataOutputObjectsDelega
             //  calls to beginConfiguration and commitConfiguration".
             self.setupResult = self.configureSession(cameraType: cameraType,
                                                      supportedBarcodeType: supportedBarcodeType)
+            let tConfigured = CFAbsoluteTimeGetCurrent()
 
             guard self.setupResult == .success else { return }
 
-            // Order matches the previous behaviour: start, then observe, then torch.
-            self.startSessionIfNeeded()
-            self.addObservers()
-            self.update(torchMode: self.torchMode)
-
-            // Only the preview LAYER is touched on the main queue. Connecting an
-            // AVCaptureVideoPreviewLayer to a session from the main thread is
-            // sanctioned by AVFoundation (see Apple's AVCam) and does NOT open a
-            // session configuration transaction, so it cannot race startRunning().
+            // Set the preview orientation on the main queue NOW — BEFORE the (~145ms)
+            // startRunning below — so the very first frame renders at the correct
+            // orientation instead of appearing once and then snapping ("giật 1 nhịp").
+            // The preview's `.session` and gravity are already wired at init; this is a
+            // pure connection-property write (no session config transaction → no race
+            // with startRunning). The connection exists because configureSession has
+            // committed the video input above.
             DispatchQueue.main.async { [weak self] in
                 guard let self else { return }
-                self.cameraPreview.session = self.session
-                self.cameraPreview.previewLayer.videoGravity = .resizeAspectFill
                 self.setVideoOrientationToInterfaceOrientation()
             }
+
+            // Order matches the previous behaviour: start, then observe, then torch.
+            self.startSessionIfNeeded()
+            let tStarted = CFAbsoluteTimeGetCurrent()
+            // [CKCameraKit][perf] TEMP measurement — remove before publish.
+            print(String(format: "[CKCameraKit][perf] queueWait=%.0fms configure=%.0fms startRunning=%.0fms setupTotal=%.0fms",
+                         (tBlock - tCall) * 1000,
+                         (tConfigured - tBlock) * 1000,
+                         (tStarted - tConfigured) * 1000,
+                         (tStarted - tCall) * 1000))
+            self.addObservers()
+            self.update(torchMode: self.torchMode)
         }
 
         DispatchQueue.global(qos: .utility).async { [weak self] in

package/package.json

@@ -1,41 +1,41 @@
 {
-  "name": "@momo-kits/camerakit",
-  "version": "0.161.2-beta.2",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/teslamotors/react-native-camera-kit.git"
-  },
-  "publishConfig": {
-    "registry": "https://registry.npmjs.org/"
-  },
-  "description": "A high performance, fully featured, rock solid camera library for React Native applications",
-  "nativePackage": true,
-  "scripts": {
-    "build": "echo",
-    "test": "jest",
-    "lint": "yarn eslint -c .eslintrc.js"
-  },
-  "main": "./src/index.ts",
-  "dependencies": {},
-  "license": "MIT",
-  "devDependencies": {
-    "react": "19.0.0",
-    "react-native": "0.80.1"
-  },
-  "peerDependencies": {
-    "react": "*",
-    "react-native": "*"
-  },
-  "engines": {
-    "node": ">=18"
-  },
-  "codegenConfig": {
-    "name": "rncamerakit_specs",
-    "type": "all",
-    "jsSrcsDir": "src/specs",
-    "android": {
-      "javaPackageName": "com.rncamerakit"
-    }
-  },
-  "packageManager": "yarn@1.22.22"
-}
+    "name": "@momo-kits/camerakit",
+    "version": "0.161.2-beta.26",
+    "repository": {
+        "type": "git",
+        "url": "https://github.com/teslamotors/react-native-camera-kit.git"
+    },
+    "publishConfig": {
+        "registry": "https://registry.npmjs.org/"
+    },
+    "description": "A high performance, fully featured, rock solid camera library for React Native applications",
+    "nativePackage": true,
+    "scripts": {
+        "build": "echo",
+        "test": "jest",
+        "lint": "yarn eslint -c .eslintrc.js"
+    },
+    "main": "./src/index.ts",
+    "dependencies": {},
+    "license": "MIT",
+    "devDependencies": {
+        "react": "19.0.0",
+        "react-native": "0.80.1"
+    },
+    "peerDependencies": {
+        "react": "*",
+        "react-native": "*"
+    },
+    "engines": {
+        "node": ">=18"
+    },
+    "codegenConfig": {
+        "name": "rncamerakit_specs",
+        "type": "all",
+        "jsSrcsDir": "src/specs",
+        "android": {
+            "javaPackageName": "com.rncamerakit"
+        }
+    },
+    "packageManager": "yarn@1.22.22"
+}