@momentiq/dark-factory-cli 1.0.0 → 2.0.0

package/dist/cycle-doc-validator/validate_cycle_doc.py

@@ -41,9 +41,14 @@ aligned with CONTRIBUTING.md "Trailers" section):
   1. **Type detection.** Plan PR if title starts with ``docs(roadmap):``
      or ``docs(<cycle>):``, OR PR has label ``plan-pr``, AND every
      changed path is under ``docs/`` (or is the repo-root ``AGENTS.md``
-     / ``CLAUDE.md``). The "docs only" check is broader than just
-     cycle-doc paths so a plan PR can include supporting ADR / engineering
-     docs in the same change without being misclassified as a code PR.
+     / ``CLAUDE.md``), AND at least one changed file is itself a cycle
+     doc matching ``docs/roadmap/cycles/cycle*.md``. The "docs only"
+     check is broader than just cycle-doc paths so a plan PR can include
+     supporting ADR / engineering docs in the same change without being
+     misclassified as a code PR. The "at least one cycle doc" check
+     (issue #25) prevents routine roadmap-index refreshes
+     (``docs/roadmap/roadmap-overview.md``, ``docs/roadmap/dark-factory-
+     roadmap.md``) from being forced through the full plan-PR contract.
      Otherwise code PR.
 
   2. **Bot/automation exemption.** PRs with any of the labels
@@ -651,6 +656,21 @@ def _parse_paginated_commit_messages(raw: str) -> str:
     return "\n\n".join(_parse_paginated_commits_to_list(raw))
 
 
+def _is_cycle_doc_path(path: str) -> bool:
+    """Match ``docs/roadmap/cycles/cycle<id>(-<slug>)?.md``.
+
+    The classifier counts only files whose basename starts with
+    ``cycle`` followed by an id character. Sibling files like
+    ``docs/roadmap/cycles/README.md`` are index/meta content and do
+    NOT trigger the plan-PR contract.
+    """
+    prefix = "docs/roadmap/cycles/cycle"
+    if not path.startswith(prefix) or not path.endswith(".md"):
+        return False
+    next_char = path[len(prefix) : len(prefix) + 1]
+    return next_char.isdigit()
+
+
 def is_plan_pr(
     title: str,
     labels: Iterable[str],
@@ -658,13 +678,22 @@ def is_plan_pr(
 ) -> bool:
     """Plan PR detection per Component 2 rule 1.
 
-    A PR is a plan PR if BOTH conditions hold:
+    A PR is a plan PR if ALL three conditions hold:
       - title matches ``docs(roadmap):`` OR ``docs(<cycle>):``,
         OR the PR has the label ``plan-pr``;
-      - AND every changed file is under ``docs/`` (no code paths). We
-        use the broader ``docs/`` rather than just cycle-doc paths so
-        that a plan PR can add supporting docs (ADR, engineering doc)
-        in the same change.
+      - every changed file is under ``docs/`` (no code paths) — a plan
+        PR may include supporting docs (ADR, engineering doc) in the
+        same change, so we accept the broader ``docs/`` prefix here;
+      - AND at least one changed file is itself a cycle doc matching
+        ``docs/roadmap/cycles/cycle*.md``.
+
+    The third condition narrows what used to be a too-broad classifier
+    (issue #25): editing only ``docs/roadmap/dark-factory-roadmap.md``
+    or ``docs/roadmap/roadmap-overview.md`` is a routine index refresh,
+    not a plan PR — forcing the full plan-PR trailer contract on those
+    edits required manufacturing throwaway cycle docs + tracking
+    issues. The plan-PR contract now fires only when the diff actually
+    creates or updates a cycle doc.
     """
     label_match = any(label.strip().lower() == "plan-pr" for label in labels)
     title_match = bool(PLAN_TITLE_RE.match(title or ""))
@@ -672,7 +701,8 @@ def is_plan_pr(
     if not files:
         return False
     docs_only = all(p.startswith("docs/") or p == "AGENTS.md" or p == "CLAUDE.md" for p in files)
-    return (label_match or title_match) and docs_only
+    cycle_doc_in_diff = any(_is_cycle_doc_path(p) for p in files)
+    return (label_match or title_match) and docs_only and cycle_doc_in_diff
 
 
 def status_completion_in_diff(diff: str) -> list[str]:

package/dist/doctor.d.ts

@@ -1,7 +1,7 @@
 import type { AdapterRegistry } from "./adapters/critic.js";
 import type { LoadedConfig } from "./policy/config.js";
 import type { BootstrapResult } from "./doppler-bootstrap.js";
-import type { DoctorCheck } from "@momentiq/dark-factory-schemas";
+import type { AgentReviewConfig, DoctorCheck } from "@momentiq/dark-factory-schemas";
 export interface DoctorOptions {
     loaded: LoadedConfig;
     registry: AdapterRegistry;
@@ -9,4 +9,54 @@ export interface DoctorOptions {
     profileName?: string;
 }
 export declare function runDoctor(options: DoctorOptions): Promise<DoctorCheck[]>;
+export declare const CLOUD_ENV_MARKERS: readonly ["CODESPACES", "REMOTE_CONTAINERS", "CLAUDE_CODE_SANDBOX", "DEVCONTAINER"];
+export type CloudEnvMarker = (typeof CLOUD_ENV_MARKERS)[number];
+export interface CloudEnvDetection {
+    detected: boolean;
+    /**
+     * The subset of `CLOUD_ENV_MARKERS` whose values were truthy in
+     * `process.env` at detection time (each one of "true", "1", "yes",
+     * case-insensitive; presence-only markers like a non-empty
+     * `CODESPACE_NAME` are NOT considered — keep the contract explicit
+     * boolean-ish to avoid false positives from generic env-set state).
+     */
+    markers: CloudEnvMarker[];
+}
+export interface DetectCloudEnvOptions {
+    env?: NodeJS.ProcessEnv;
+}
+export declare function detectCloudEnv(options?: DetectCloudEnvOptions): CloudEnvDetection;
+export type DoctorTriageState = "config_missing" | "auth_pending" | "ok";
+export interface ClassifyDoctorStateOptions {
+    config: AgentReviewConfig;
+    /**
+     * The resolved profile name the CLI used. `undefined` means the
+     * caller invoked `df doctor` without `--profile` AND no
+     * `AGENT_REVIEW_PROFILE` was set — only meaningful in back-compat
+     * configs that have no `profiles` map at all.
+     */
+    profileName: string | undefined;
+    /**
+     * The per-check DoctorCheck array `runDoctor` returns. The
+     * classifier inspects only the per-critic auth checks
+     * (`<criticId>.<probe>` names) — base-infra checks are intentionally
+     * ignored so a missing node binary doesn't masquerade as a
+     * subscription-auth failure.
+     */
+    perCriticChecks: readonly DoctorCheck[];
+}
+export interface DoctorTriageResult {
+    state: DoctorTriageState;
+    /**
+     * Single-line headline (no embedded newlines). Format: `[<TAG>] ...`
+     * where TAG is one of `CONFIG`, `AUTH`, `OK`. The bracketed prefix
+     * makes the line greppable AND distinguishes it from the per-check
+     * `[OK]/[INFO]/[FAIL]` lines `cmdDoctor` emits underneath.
+     */
+    line: string;
+}
+export declare function classifyDoctorState(options: ClassifyDoctorStateOptions): DoctorTriageResult;
+export declare function sweepOrphanLocks(artifactDir: string): DoctorCheck;
+export declare const CACHE_TREE_CORRUPTION_REGEX: RegExp;
+export declare function probeCacheTree(repoRoot: string): Promise<DoctorCheck>;
 //# sourceMappingURL=doctor.d.ts.map

package/dist/doctor.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"doctor.d.ts","sourceRoot":"","sources":["../src/doctor.ts"],"names":[],"mappings":"AAiCA,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAC;AAC5D,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAC;AACvD,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AAM9D,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,gCAAgC,CAAC;AAIlE,MAAM,WAAW,aAAa;IAC5B,MAAM,EAAE,YAAY,CAAC;IACrB,QAAQ,EAAE,eAAe,CAAC;IAK1B,SAAS,CAAC,EAAE,eAAe,CAAC;IAO5B,WAAW,CAAC,EAAE,MAAM,CAAC;CACtB;AAED,wBAAsB,SAAS,CAAC,OAAO,EAAE,aAAa,GAAG,OAAO,CAAC,WAAW,EAAE,CAAC,CAwI9E"}
+{"version":3,"file":"doctor.d.ts","sourceRoot":"","sources":["../src/doctor.ts"],"names":[],"mappings":"AA0CA,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAC;AAC5D,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAC;AACvD,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AAM9D,OAAO,KAAK,EACV,iBAAiB,EACjB,WAAW,EACZ,MAAM,gCAAgC,CAAC;AAIxC,MAAM,WAAW,aAAa;IAC5B,MAAM,EAAE,YAAY,CAAC;IACrB,QAAQ,EAAE,eAAe,CAAC;IAK1B,SAAS,CAAC,EAAE,eAAe,CAAC;IAO5B,WAAW,CAAC,EAAE,MAAM,CAAC;CACtB;AAED,wBAAsB,SAAS,CAAC,OAAO,EAAE,aAAa,GAAG,OAAO,CAAC,WAAW,EAAE,CAAC,CA4L9E;AAuBD,eAAO,MAAM,iBAAiB,qFAKpB,CAAC;AAEX,MAAM,MAAM,cAAc,GAAG,CAAC,OAAO,iBAAiB,CAAC,CAAC,MAAM,CAAC,CAAC;AAEhE,MAAM,WAAW,iBAAiB;IAChC,QAAQ,EAAE,OAAO,CAAC;IAClB;;;;;;OAMG;IACH,OAAO,EAAE,cAAc,EAAE,CAAC;CAC3B;AAED,MAAM,WAAW,qBAAqB;IACpC,GAAG,CAAC,EAAE,MAAM,CAAC,UAAU,CAAC;CACzB;AAED,wBAAgB,cAAc,CAC5B,OAAO,GAAE,qBAA0B,GAClC,iBAAiB,CAYnB;AAiPD,MAAM,MAAM,iBAAiB,GACzB,gBAAgB,GAChB,cAAc,GACd,IAAI,CAAC;AAET,MAAM,WAAW,0BAA0B;IACzC,MAAM,EAAE,iBAAiB,CAAC;IAC1B;;;;;OAKG;IACH,WAAW,EAAE,MAAM,GAAG,SAAS,CAAC;IAChC;;;;;;OAMG;IACH,eAAe,EAAE,SAAS,WAAW,EAAE,CAAC;CACzC;AAED,MAAM,WAAW,kBAAkB;IACjC,KAAK,EAAE,iBAAiB,CAAC;IACzB;;;;;OAKG;IACH,IAAI,EAAE,MAAM,CAAC;CACd;AAED,wBAAgB,mBAAmB,CACjC,OAAO,EAAE,0BAA0B,GAClC,kBAAkB,CAiDpB;AA0BD,wBAAgB,gBAAgB,CAAC,WAAW,EAAE,MAAM,GAAG,WAAW,CAwDjE;AAoED,eAAO,MAAM,2BAA2B,QACQ,CAAC;AA8GjD,wBAAsB,cAAc,CAAC,QAAQ,EAAE,MAAM,GAAG,OAAO,CAAC,WAAW,CAAC,CA6F3E"}