@momentiq/dark-factory-cli 0.1.0-alpha.4

package/LICENSE

@@ -0,0 +1,201 @@
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for describing the origin of the Work and
+      reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Support. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or support.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright 2026 Momentiq AI
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

package/README.md

@@ -0,0 +1,150 @@
+# @momentiq/dark-factory-cli
+
+Dark Factory OSS CLI — multi-vendor adversarial critic orchestration.
+
+## What this package gives you
+
+All nine Dark Factory services extracted from sage3c, today consumable as a
+TypeScript library and (for the Python-backed and Phase D services) as `df`
+subcommands:
+
+1. **Critic Orchestrator** (`./adapters/*`) — vendor-neutral adapter contract
+   (`CriticAdapter`) with concrete adapters for Cursor SDK, OpenAI Codex SDK,
+   Google Gemini, and Grok (xAI via OpenAI-compatible API).
+2. **Policy Engine** (`./policy/*`) — gate evaluation, min-complete-quorum
+   aggregation, TDD classifier, finding-rubric strip, verification routes,
+   profile resolution, and config loading.
+3. **Trusted-Surface Rebind** (`./trusted-surface/*`) — when a commit modifies
+   the trusted policy surface (config + guidance files + prompt fragments),
+   the rebind reads those inputs from the parent ref so the commit is reviewed
+   against the prior baseline (self-modification guard).
+4. **Per-SHA Evidence Store** (`./evidence/*`) — canonical per-SHA quality-gate
+   evidence path layout + runner that writes/reads evidence files atomically.
+5. **Cycle-Doc Trailer Validator** (`./cycle-doc-validator/*` + `df validate-cycle-doc`)
+   — enforces per-PR `Cycle:` / `Issue:` / `ProjectItem:` trailer rules.
+6. **Merge Queue Admission Policy** (`./policy/merge-queue.ts` + `df admit-pr`) —
+   plan-vs-code PR classifier (the same heuristic sage3c's plan-PR review gate
+   uses) + the typed ruleset shape (`defaultMainRulesetShape`,
+   `defaultCeReviewRulesetShape`, `defaultMergeQueueRule`) that consumers
+   declare so the branch-protection auditor can detect drift against it.
+7. **Branch-Protection Drift Detector** (`./branch-protection/*` + `df audit-branch-protection`)
+   — compares a declarative `spec.yaml` against the live GitHub ruleset.
+8. **Audit / Compliance Trail** (`./evidence/audit-trail.ts` + `df audit stats`) —
+   the `_runs.ndjson` NDJSON sink + read/summarize/agreement-rate/quorum-stats
+   helpers behind the legacy `make agent-review-stats`. Every critic run,
+   every gate verdict, every bypass invocation appends here.
+9. **Cycle Tracker Sync + PR Attribution** (`./cycle-tracker-sync/*` + `df sync-trackers` + `df attribute-pr`)
+   — reconciles GitHub tracker issues with cycle docs + writes the
+   `Cycle Ref` custom field on PR project items.
+
+After Phase D all nine services are present in the package. Phase E adds the
+reusable GitHub workflows that consumers wire up via `uses:`, plus stub
+subcommands (`status-check`, `critic`) so those workflows can satisfy the
+five required-status-check contexts in dark-factory's own ruleset while real
+critic / aggregator logic lands in Phase F.
+
+## Status
+
+`0.1.0-alpha.3` — extracted from `momentiq-ai/sage3c:tools/agent-review/` +
+`scripts/ci/` per cycle 331.1 Phases B, C, D, and E. Library API is stable;
+the binary's `review`/`gate`/`doctor` subcommands are still stubs (Phase F);
+the Phase E stubs (`status-check`, `critic`) intentionally exit 0 so the
+reusable workflow shapes can break the dogfood chicken-and-egg.
+
+## Install
+
+```bash
+npm install @momentiq/dark-factory-cli
+```
+
+## Library usage
+
+```ts
+import {
+  runReview,
+  evaluateCommitGate,
+  buildReviewPacket,
+  loadAgentReviewConfig,
+  runValidateCycleDoc,
+  runAuditBranchProtection,
+  runSyncCycleTrackers,
+  runAttributePrCycleRef,
+} from "@momentiq/dark-factory-cli";
+
+const loaded = await loadAgentReviewConfig(repoRoot);
+const outcome = await runReview({ loaded, /* ... */ });
+
+// Service #5 — validate a PR's cycle/issue trailers (subprocess-wraps the
+// bundled Python script). Inherits stdio by default.
+await runValidateCycleDoc({
+  env: { PR_NUMBER: "1234", PR_TITLE: "feat: ...", PR_BODY: "..." },
+});
+```
+
+## CLI
+
+```bash
+df --help
+df --version
+
+# Phase C subcommands — each forwards remaining argv to the bundled Python
+# script verbatim, so `df <sub> --help` returns the Python argparse banner.
+df validate-cycle-doc --help
+df audit-branch-protection --use-bundled-default-spec --repo owner/repo
+df sync-trackers --dry-run
+df attribute-pr  # env-driven; needs PR_NUMBER, PR_NODE_ID, PR_BODY_FILE, PROJECT_TOKEN
+
+# Phase D subcommands — pure-TS, parse flags directly.
+df audit stats --path .git/agent-reviews/_runs.ndjson
+df admit-pr --files-stdin   # newline-separated file paths on stdin
+df admit-pr --files docs/roadmap/cycles/cycle331.md,packages/cli/src/cli.ts
+```
+
+> **Note on `--use-bundled-default-spec`**: the bundled `spec-default.yaml`
+> mirrors the sage3c-shaped branch-protection posture (e.g., asserts the
+> `agent-critic` and `cycle-doc-validation` required contexts). It exists
+> as a working starting point for first-run audits and the standalone
+> repo's own dogfood gate. Consumers SHOULD author their own `spec.yaml`
+> matching their repo's actual posture — running the bundled default
+> against an arbitrary repo will surface drift against contexts that
+> don't exist there.
+
+The Phase F subcommands (`review`, `gate`, `doctor`) are stubbed and exit 2
+with a "not implemented" message pointing at the library API. The Phase E
+stubs (`status-check`, `critic`) intentionally exit 0 so the five reusable
+workflows can satisfy dark-factory's own ruleset while real critic
+orchestration lands in Phase F.
+
+## System requirements
+
+- **Node.js >=20**
+- **Python 3.11+** — required for services #5, #7, #9. The Phase C extraction
+  bundles the original Python scripts (`validate_cycle_doc.py`,
+  `audit_branch_protection.py`, `sync_cycle_trackers.py`,
+  `attribute_pr_cycle_ref.py`) and wraps each in a TypeScript subprocess
+  spawn. The pure-TS rewrite is tracked as Phase C-PORT follow-up and will
+  eliminate this dependency in a future release.
+- **`gh` CLI** (authenticated) — all four Python scripts shell out to `gh api`
+  for GitHub queries. CI invocations provide `GH_TOKEN` / `PROJECT_TOKEN`
+  via environment.
+- **`git`** on `PATH` — the rebind + config-from-ref code paths shell out
+  to git, and the Python scripts use `git rev-parse --show-toplevel` to
+  discover the consumer repo root.
+
+### Repo root detection for Python-backed services
+
+The bundled Python scripts resolve the consumer repo root in this order:
+
+1. `$DF_REPO_ROOT` environment variable (explicit override).
+2. `git rev-parse --show-toplevel` from the current working directory.
+3. Legacy `__file__`-relative fallback (preserved for in-tree dev-mode
+   pytest runs).
+
+The TypeScript wrappers set `DF_REPO_ROOT` automatically when a `repoRoot`
+option is supplied — pass it when invoking outside a git worktree.
+
+## License
+
+Apache-2.0. The OSS critic surface is a public artifact. Calibrated prompts
+and the App's calibrated bypass-classifier are out-of-scope here and live in
+private repos (see [parent cycle 331](https://github.com/momentiq-ai/sage3c/blob/main/docs/roadmap/cycles/cycle331-dark-factory-platformization.md)).

package/dist/adapters/_shared.d.ts

@@ -0,0 +1,45 @@
+import { type CriticConfig, type CriticResult, type ModelConfig } from "@momentiq/dark-factory-schemas";
+export interface ParseAssistantJsonOk {
+    ok: true;
+    value: unknown;
+}
+export interface ParseAssistantJsonFail {
+    ok: false;
+    message: string;
+}
+export type ParseAssistantJsonResult = ParseAssistantJsonOk | ParseAssistantJsonFail;
+export declare function parseAssistantJson(text: string): ParseAssistantJsonResult;
+export interface BuildErrorResultArgs {
+    critic: CriticConfig;
+    message: string;
+    retryable: boolean;
+    rawSamplePath?: string;
+    agentId?: string;
+    runId?: string;
+    code?: string;
+    retryCount?: number;
+}
+export declare function buildErrorResult(args: BuildErrorResultArgs): CriticResult;
+export interface MergeAdapterMetadataArgs {
+    critic: CriticConfig;
+    runtimeModel?: ModelConfig | {
+        id: string;
+        params?: Array<{
+            id: string;
+            value: string;
+        }>;
+    };
+    agentId?: string;
+    runId?: string;
+}
+export declare function mergeAdapterMetadata(raw: unknown, args: MergeAdapterMetadataArgs): unknown;
+export declare function normalizeCriticEcho(raw: unknown): unknown;
+export interface WriteRedactedDiagnosticArgs {
+    diagnosticsDir: string | undefined;
+    criticId: string;
+    commit: string;
+    rawText: string;
+}
+export declare function writeRedactedDiagnostic(args: WriteRedactedDiagnosticArgs): string | undefined;
+export declare function shouldEnableCursorSandbox(env?: NodeJS.ProcessEnv): boolean;
+//# sourceMappingURL=_shared.d.ts.map

package/dist/adapters/_shared.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"_shared.d.ts","sourceRoot":"","sources":["../../src/adapters/_shared.ts"],"names":[],"mappings":"AAgCA,OAAO,EAEL,KAAK,YAAY,EACjB,KAAK,YAAY,EACjB,KAAK,WAAW,EACjB,MAAM,gCAAgC,CAAC;AAkBxC,MAAM,WAAW,oBAAoB;IACnC,EAAE,EAAE,IAAI,CAAC;IACT,KAAK,EAAE,OAAO,CAAC;CAChB;AAED,MAAM,WAAW,sBAAsB;IACrC,EAAE,EAAE,KAAK,CAAC;IACV,OAAO,EAAE,MAAM,CAAC;CACjB;AAED,MAAM,MAAM,wBAAwB,GAAG,oBAAoB,GAAG,sBAAsB,CAAC;AAErF,wBAAgB,kBAAkB,CAAC,IAAI,EAAE,MAAM,GAAG,wBAAwB,CAmBzE;AAcD,MAAM,WAAW,oBAAoB;IACnC,MAAM,EAAE,YAAY,CAAC;IACrB,OAAO,EAAE,MAAM,CAAC;IAChB,SAAS,EAAE,OAAO,CAAC;IACnB,aAAa,CAAC,EAAE,MAAM,CAAC;IACvB,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,KAAK,CAAC,EAAE,MAAM,CAAC;IAEf,IAAI,CAAC,EAAE,MAAM,CAAC;IAEd,UAAU,CAAC,EAAE,MAAM,CAAC;CACrB;AAED,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,oBAAoB,GAAG,YAAY,CAyBzE;AAqBD,MAAM,WAAW,wBAAwB;IACvC,MAAM,EAAE,YAAY,CAAC;IACrB,YAAY,CAAC,EAAE,WAAW,GAAG;QAAE,EAAE,EAAE,MAAM,CAAC;QAAC,MAAM,CAAC,EAAE,KAAK,CAAC;YAAE,EAAE,EAAE,MAAM,CAAC;YAAC,KAAK,EAAE,MAAM,CAAA;SAAE,CAAC,CAAA;KAAE,CAAC;IAC3F,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,KAAK,CAAC,EAAE,MAAM,CAAC;CAChB;AAED,wBAAgB,oBAAoB,CAAC,GAAG,EAAE,OAAO,EAAE,IAAI,EAAE,wBAAwB,GAAG,OAAO,CAqB1F;AA2BD,wBAAgB,mBAAmB,CAAC,GAAG,EAAE,OAAO,GAAG,OAAO,CAoBzD;AAiBD,MAAM,WAAW,2BAA2B;IAC1C,cAAc,EAAE,MAAM,GAAG,SAAS,CAAC;IACnC,QAAQ,EAAE,MAAM,CAAC;IACjB,MAAM,EAAE,MAAM,CAAC;IACf,OAAO,EAAE,MAAM,CAAC;CACjB;AAED,wBAAgB,uBAAuB,CAAC,IAAI,EAAE,2BAA2B,GAAG,MAAM,GAAG,SAAS,CAa7F;AA8BD,wBAAgB,yBAAyB,CAAC,GAAG,GAAE,MAAM,CAAC,UAAwB,GAAG,OAAO,CAGvF"}

package/dist/adapters/_shared.js

@@ -0,0 +1,200 @@
+// Cycle 322.2 — adapter helpers shared across all critic adapters
+// (Cursor, Gemini, and future Grok). The helpers here centralize the
+// security-critical paths — evidence-redaction at the diagnostic boundary
+// and JSON-parse-fallback for assistant responses — so a new adapter
+// cannot accidentally drift from the contract by reimplementing the
+// pattern locally.
+// Touched (comment-only, no semantic change) for issue #1434 dogfood —
+// validates that a trusted-surface no-op PR produces a real agent-critic
+// verdict in CI under the new parent-baseline rebind. Remove this line in
+// the next cleanup pass if it bothers you.
+//
+// Each helper is pure (or pure-with-narrow-IO for the redaction writer)
+// and unit-tested in `tests/shared-helpers.test.ts` (parseAssistantJson,
+// buildErrorResult, mergeAdapterMetadata, writeRedactedDiagnostic) and
+// `tests/normalize-echo-shared.test.ts` (normalizeCriticEcho — added in
+// issue #1484 when this helper was hoisted from cursor-sdk.ts). A
+// separate boundary test (`tests/shared-boundary.test.ts`) statically
+// scans every adapter file under this directory for direct
+// `writeFileSync` calls — if a future adapter sidesteps
+// `writeRedactedDiagnostic`, the test fails the suite (the lightweight
+// equivalent of the custom ESLint rule the cycle 322.2 plan called for;
+// the project does not currently use ESLint).
+//
+// Usage discipline: adapters MUST import these helpers from `_shared.ts`,
+// not duplicate the patterns. The `criticId` tag (Phase F) is woven through
+// the `mergeAdapterMetadata` and `buildErrorResult` shapes so per-critic
+// telemetry segmentation works for every adapter without per-adapter glue.
+import { mkdirSync, writeFileSync } from "node:fs";
+import { resolve } from "node:path";
+import { redactSecrets } from "../security.js";
+import { parseQualityGateResult, } from "@momentiq/dark-factory-schemas";
+export function parseAssistantJson(text) {
+    if (!text.trim())
+        return { ok: false, message: "assistant response was empty" };
+    let candidate = text.trim();
+    const fence = candidate.match(/^```(?:json)?\s*([\s\S]*?)```\s*$/);
+    if (fence)
+        candidate = (fence[1] ?? "").trim();
+    try {
+        return { ok: true, value: JSON.parse(candidate) };
+    }
+    catch {
+        const start = candidate.indexOf("{");
+        const end = candidate.lastIndexOf("}");
+        if (start === -1 || end === -1 || end <= start) {
+            return { ok: false, message: "no JSON object found" };
+        }
+        try {
+            return { ok: true, value: JSON.parse(candidate.slice(start, end + 1)) };
+        }
+        catch (err) {
+            return { ok: false, message: err.message };
+        }
+    }
+}
+export function buildErrorResult(args) {
+    return {
+        criticId: args.critic.id,
+        status: "error",
+        requiresHumanJudgment: false,
+        reviewer: {
+            name: args.critic.name,
+            adapter: args.critic.adapter,
+            model: args.critic.model,
+            runtime: args.critic.runtime,
+            ...(args.agentId !== undefined ? { agentId: args.agentId } : {}),
+            ...(args.runId !== undefined ? { runId: args.runId } : {}),
+        },
+        summary: args.message,
+        findings: [],
+        validation: { qualityGateResults: [], qualityGatesMissing: [] },
+        confidence: "unknown",
+        error: {
+            message: args.message,
+            retryable: args.retryable,
+            ...(args.rawSamplePath !== undefined ? { rawSamplePath: args.rawSamplePath } : {}),
+            ...(args.code !== undefined ? { code: args.code } : {}),
+            ...(args.retryCount !== undefined ? { retryCount: args.retryCount } : {}),
+        },
+    };
+}
+export function mergeAdapterMetadata(raw, args) {
+    if (typeof raw !== "object" || raw === null)
+        return raw;
+    const obj = { ...raw };
+    obj["criticId"] = args.critic.id;
+    const reviewerRaw = obj["reviewer"];
+    const reviewer = reviewerRaw && typeof reviewerRaw === "object"
+        ? { ...reviewerRaw }
+        : {};
+    reviewer["name"] = reviewer["name"] ?? args.critic.name;
+    reviewer["adapter"] = args.critic.adapter;
+    reviewer["runtime"] = reviewer["runtime"] ?? args.critic.runtime;
+    // Echo what the SDK actually resolved to, falling back to config only
+    // when the SDK doesn't expose its resolved model selection. Operators
+    // reading the artifact rely on this echo as the proof signal that the
+    // configured tier engaged.
+    reviewer["model"] = args.runtimeModel ?? args.critic.model;
+    if (args.agentId !== undefined)
+        reviewer["agentId"] = args.agentId;
+    if (args.runId !== undefined)
+        reviewer["runId"] = args.runId;
+    obj["reviewer"] = reviewer;
+    return obj;
+}
+// ---------------------------------------------------------------------------
+// normalizeCriticEcho — strip schema-invalid entries from the critic's
+// echoed `validation.qualityGateResults[]` BEFORE strict schema validation.
+//
+// Why this lives here (issue #1484): the critic's validation block is
+// informational only — the adapter overwrites it with deterministic packet
+// evidence after parsing. But strict `parseCriticResult` rejects the entire
+// run when any echoed entry is misshapen (e.g. model emits `gate` instead of
+// the schema-required `command` field). Cursor's first-party model happens
+// to converge on the right field names; Gemini, Grok, and Codex sometimes
+// guess `gate`/`name`/`step` and trip the schema. The fix is to drop the
+// malformed entries at the adapter boundary so the high-value payload
+// (findings, verdict, summary) is preserved.
+//
+// Uses `parseQualityGateResult` itself as the predicate — that is the
+// single source of truth for "well-formed", so this normalizer cannot drift
+// from it. The downstream `parseCriticResult` will overwrite the validation
+// block anyway with the deterministic packet evidence, so any well-formed
+// entry that survives normalization is also discarded — the survivors only
+// exist to keep the strict parse happy.
+//
+// Originally introduced in `cursor-sdk.ts` (cycle 322.1) but moved here
+// in #1484 so every adapter routes through one source of truth instead of
+// each adapter duplicating the pattern.
+export function normalizeCriticEcho(raw) {
+    if (typeof raw !== "object" || raw === null)
+        return raw;
+    const obj = raw;
+    const validation = obj["validation"];
+    if (typeof validation !== "object" || validation === null)
+        return raw;
+    const v = validation;
+    const list = v["qualityGateResults"];
+    if (!Array.isArray(list))
+        return raw;
+    const cleaned = list.filter((entry, i) => {
+        try {
+            parseQualityGateResult(entry, `$.validation.qualityGateResults[${i}]`);
+            return true;
+        }
+        catch {
+            return false;
+        }
+    });
+    return {
+        ...obj,
+        validation: { ...v, qualityGateResults: cleaned },
+    };
+}
+export function writeRedactedDiagnostic(args) {
+    if (!args.diagnosticsDir)
+        return undefined;
+    try {
+        mkdirSync(args.diagnosticsDir, { recursive: true });
+        const path = resolve(args.diagnosticsDir, `${args.commit}-${args.criticId}-${Date.now()}.txt`);
+        writeFileSync(path, redactSecrets(args.rawText), "utf8");
+        return path;
+    }
+    catch {
+        return undefined;
+    }
+}
+// dogfood: trusted-surface no-op to validate #1549 fix end-to-end in CI agent-critic
+// ---------------------------------------------------------------------------
+// shouldEnableCursorSandbox — environment-aware sandbox toggle for the
+// Cursor SDK's `local.sandboxOptions.enabled` flag.
+//
+// On local dev workstations we ENABLE the SDK's defense-in-depth sandbox so
+// the critic process can't write outside its sandbox even if a malicious diff
+// convinces the model to try. On GitHub Actions runners the SDK's sandbox
+// primitive is unavailable and the SDK fails the run permanently with:
+//
+//   "Local SDK sandboxing was requested, but sandboxing is not supported
+//    in this environment. Disable local.sandboxOptions.enabled or remove
+//    ~/.cursor/sandbox.json to run without sandboxing."
+//
+// (Tracked at #1577.) Detecting CI and flipping the flag off keeps the
+// local defense in place while letting the CI replay actually run.
+//
+// Both `cursor-sdk.ts` (production critic adapter) and `spike.ts` (empirical
+// SDK fixture generator) call this helper so the two paths can NEVER drift
+// — the spike's comment explicitly says "Match the production adapter's
+// local options exactly; defenses must be identical." A single source of
+// truth enforces that invariant.
+//
+// `CI` is set by GitHub Actions, GitLab, CircleCI, Travis, and most other
+// CI systems. `GITHUB_ACTIONS` is GHA-specific and covers the case where
+// `CI` was somehow unset. The check is conservative: if either signals CI,
+// disable the sandbox. Locally neither is normally set, so the default
+// (sandbox enabled) holds.
+export function shouldEnableCursorSandbox(env = process.env) {
+    const isCI = env["CI"] === "true" || env["GITHUB_ACTIONS"] === "true";
+    return !isCI;
+}
+//# sourceMappingURL=_shared.js.map

package/dist/adapters/_shared.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"_shared.js","sourceRoot":"","sources":["../../src/adapters/_shared.ts"],"names":[],"mappings":"AAAA,kEAAkE;AAClE,qEAAqE;AACrE,0EAA0E;AAC1E,qEAAqE;AACrE,oEAAoE;AACpE,mBAAmB;AACnB,uEAAuE;AACvE,yEAAyE;AACzE,0EAA0E;AAC1E,2CAA2C;AAC3C,EAAE;AACF,wEAAwE;AACxE,yEAAyE;AACzE,uEAAuE;AACvE,wEAAwE;AACxE,kEAAkE;AAClE,sEAAsE;AACtE,2DAA2D;AAC3D,wDAAwD;AACxD,uEAAuE;AACvE,wEAAwE;AACxE,8CAA8C;AAC9C,EAAE;AACF,0EAA0E;AAC1E,4EAA4E;AAC5E,yEAAyE;AACzE,2EAA2E;AAE3E,OAAO,EAAE,SAAS,EAAE,aAAa,EAAE,MAAM,SAAS,CAAC;AACnD,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAEpC,OAAO,EAAE,aAAa,EAAE,MAAM,gBAAgB,CAAC;AAC/C,OAAO,EACL,sBAAsB,GAIvB,MAAM,gCAAgC,CAAC;AA8BxC,MAAM,UAAU,kBAAkB,CAAC,IAAY;IAC7C,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE;QAAE,OAAO,EAAE,EAAE,EAAE,KAAK,EAAE,OAAO,EAAE,8BAA8B,EAAE,CAAC;IAChF,IAAI,SAAS,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;IAC5B,MAAM,KAAK,GAAG,SAAS,CAAC,KAAK,CAAC,mCAAmC,CAAC,CAAC;IACnE,IAAI,KAAK;QAAE,SAAS,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;IAC/C,IAAI,CAAC;QACH,OAAO,EAAE,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,CAAC,KAAK,CAAC,SAAS,CAAC,EAAE,CAAC;IACpD,CAAC;IAAC,MAAM,CAAC;QACP,MAAM,KAAK,GAAG,SAAS,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC;QACrC,MAAM,GAAG,GAAG,SAAS,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC;QACvC,IAAI,KAAK,KAAK,CAAC,CAAC,IAAI,GAAG,KAAK,CAAC,CAAC,IAAI,GAAG,IAAI,KAAK,EAAE,CAAC;YAC/C,OAAO,EAAE,EAAE,EAAE,KAAK,EAAE,OAAO,EAAE,sBAAsB,EAAE,CAAC;QACxD,CAAC;QACD,IAAI,CAAC;YACH,OAAO,EAAE,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,CAAC,KAAK,CAAC,SAAS,CAAC,KAAK,CAAC,KAAK,EAAE,GAAG,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC;QAC1E,CAAC;QAAC,OAAO,GAAG,EAAE,CAAC;YACb,OAAO,EAAE,EAAE,EAAE,KAAK,EAAE,OAAO,EAAG,GAAa,CAAC,OAAO,EAAE,CAAC;QACxD,CAAC;IACH,CAAC;AACH,CAAC;AA2BD,MAAM,UAAU,gBAAgB,CAAC,IAA0B;IACzD,OAAO;QACL,QAAQ,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE;QACxB,MAAM,EAAE,OAAO;QACf,qBAAqB,EAAE,KAAK;QAC5B,QAAQ,EAAE;YACR,IAAI,EAAE,IAAI,CAAC,MAAM,CAAC,IAAI;YACtB,OAAO,EAAE,IAAI,CAAC,MAAM,CAAC,OAAO;YAC5B,KAAK,EAAE,IAAI,CAAC,MAAM,CAAC,KAAK;YACxB,OAAO,EAAE,IAAI,CAAC,MAAM,CAAC,OAAO;YAC5B,GAAG,CAAC,IAAI,CAAC,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,OAAO,EAAE,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;YAChE,GAAG,CAAC,IAAI,CAAC,KAAK,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,KAAK,EAAE,IAAI,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;SAC3D;QACD,OAAO,EAAE,IAAI,CAAC,OAAO;QACrB,QAAQ,EAAE,EAAE;QACZ,UAAU,EAAE,EAAE,kBAAkB,EAAE,EAAE,EAAE,mBAAmB,EAAE,EAAE,EAAE;QAC/D,UAAU,EAAE,SAAS;QACrB,KAAK,EAAE;YACL,OAAO,EAAE,IAAI,CAAC,OAAO;YACrB,SAAS,EAAE,IAAI,CAAC,SAAS;YACzB,GAAG,CAAC,IAAI,CAAC,aAAa,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,aAAa,EAAE,IAAI,CAAC,aAAa,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;YAClF,GAAG,CAAC,IAAI,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;YACvD,GAAG,CAAC,IAAI,CAAC,UAAU,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,UAAU,EAAE,IAAI,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;SAC1E;KACF,CAAC;AACJ,CAAC;AA4BD,MAAM,UAAU,oBAAoB,CAAC,GAAY,EAAE,IAA8B;IAC/E,IAAI,OAAO,GAAG,KAAK,QAAQ,IAAI,GAAG,KAAK,IAAI;QAAE,OAAO,GAAG,CAAC;IACxD,MAAM,GAAG,GAA4B,EAAE,GAAI,GAA+B,EAAE,CAAC;IAC7E,GAAG,CAAC,UAAU,CAAC,GAAG,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;IACjC,MAAM,WAAW,GAAG,GAAG,CAAC,UAAU,CAAC,CAAC;IACpC,MAAM,QAAQ,GACZ,WAAW,IAAI,OAAO,WAAW,KAAK,QAAQ;QAC5C,CAAC,CAAC,EAAE,GAAI,WAAuC,EAAE;QACjD,CAAC,CAAC,EAAE,CAAC;IACT,QAAQ,CAAC,MAAM,CAAC,GAAG,QAAQ,CAAC,MAAM,CAAC,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC;IACxD,QAAQ,CAAC,SAAS,CAAC,GAAG,IAAI,CAAC,MAAM,CAAC,OAAO,CAAC;IAC1C,QAAQ,CAAC,SAAS,CAAC,GAAG,QAAQ,CAAC,SAAS,CAAC,IAAI,IAAI,CAAC,MAAM,CAAC,OAAO,CAAC;IACjE,sEAAsE;IACtE,sEAAsE;IACtE,sEAAsE;IACtE,2BAA2B;IAC3B,QAAQ,CAAC,OAAO,CAAC,GAAG,IAAI,CAAC,YAAY,IAAI,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC;IAC3D,IAAI,IAAI,CAAC,OAAO,KAAK,SAAS;QAAE,QAAQ,CAAC,SAAS,CAAC,GAAG,IAAI,CAAC,OAAO,CAAC;IACnE,IAAI,IAAI,CAAC,KAAK,KAAK,SAAS;QAAE,QAAQ,CAAC,OAAO,CAAC,GAAG,IAAI,CAAC,KAAK,CAAC;IAC7D,GAAG,CAAC,UAAU,CAAC,GAAG,QAAQ,CAAC;IAC3B,OAAO,GAAG,CAAC;AACb,CAAC;AAED,8EAA8E;AAC9E,uEAAuE;AACvE,4EAA4E;AAC5E,EAAE;AACF,sEAAsE;AACtE,2EAA2E;AAC3E,4EAA4E;AAC5E,6EAA6E;AAC7E,2EAA2E;AAC3E,0EAA0E;AAC1E,yEAAyE;AACzE,sEAAsE;AACtE,6CAA6C;AAC7C,EAAE;AACF,sEAAsE;AACtE,4EAA4E;AAC5E,4EAA4E;AAC5E,0EAA0E;AAC1E,2EAA2E;AAC3E,wCAAwC;AACxC,EAAE;AACF,wEAAwE;AACxE,0EAA0E;AAC1E,wCAAwC;AAExC,MAAM,UAAU,mBAAmB,CAAC,GAAY;IAC9C,IAAI,OAAO,GAAG,KAAK,QAAQ,IAAI,GAAG,KAAK,IAAI;QAAE,OAAO,GAAG,CAAC;IACxD,MAAM,GAAG,GAAG,GAA8B,CAAC;IAC3C,MAAM,UAAU,GAAG,GAAG,CAAC,YAAY,CAAC,CAAC;IACrC,IAAI,OAAO,UAAU,KAAK,QAAQ,IAAI,UAAU,KAAK,IAAI;QAAE,OAAO,GAAG,CAAC;IACtE,MAAM,CAAC,GAAG,UAAqC,CAAC;IAChD,MAAM,IAAI,GAAG,CAAC,CAAC,oBAAoB,CAAC,CAAC;IACrC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC;QAAE,OAAO,GAAG,CAAC;IACrC,MAAM,OAAO,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,CAAC,EAAE,EAAE;QACvC,IAAI,CAAC;YACH,sBAAsB,CAAC,KAAK,EAAE,mCAAmC,CAAC,GAAG,CAAC,CAAC;YACvE,OAAO,IAAI,CAAC;QACd,CAAC;QAAC,MAAM,CAAC;YACP,OAAO,KAAK,CAAC;QACf,CAAC;IACH,CAAC,CAAC,CAAC;IACH,OAAO;QACL,GAAG,GAAG;QACN,UAAU,EAAE,EAAE,GAAG,CAAC,EAAE,kBAAkB,EAAE,OAAO,EAAE;KAClD,CAAC;AACJ,CAAC;AAwBD,MAAM,UAAU,uBAAuB,CAAC,IAAiC;IACvE,IAAI,CAAC,IAAI,CAAC,cAAc;QAAE,OAAO,SAAS,CAAC;IAC3C,IAAI,CAAC;QACH,SAAS,CAAC,IAAI,CAAC,cAAc,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QACpD,MAAM,IAAI,GAAG,OAAO,CAClB,IAAI,CAAC,cAAc,EACnB,GAAG,IAAI,CAAC,MAAM,IAAI,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,GAAG,EAAE,MAAM,CACpD,CAAC;QACF,aAAa,CAAC,IAAI,EAAE,aAAa,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,MAAM,CAAC,CAAC;QACzD,OAAO,IAAI,CAAC;IACd,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,SAAS,CAAC;IACnB,CAAC;AACH,CAAC;AACD,qFAAqF;AAErF,8EAA8E;AAC9E,uEAAuE;AACvE,oDAAoD;AACpD,EAAE;AACF,4EAA4E;AAC5E,8EAA8E;AAC9E,0EAA0E;AAC1E,uEAAuE;AACvE,EAAE;AACF,yEAAyE;AACzE,yEAAyE;AACzE,wDAAwD;AACxD,EAAE;AACF,uEAAuE;AACvE,mEAAmE;AACnE,EAAE;AACF,6EAA6E;AAC7E,2EAA2E;AAC3E,wEAAwE;AACxE,yEAAyE;AACzE,iCAAiC;AACjC,EAAE;AACF,0EAA0E;AAC1E,yEAAyE;AACzE,2EAA2E;AAC3E,uEAAuE;AACvE,2BAA2B;AAC3B,MAAM,UAAU,yBAAyB,CAAC,MAAyB,OAAO,CAAC,GAAG;IAC5E,MAAM,IAAI,GAAG,GAAG,CAAC,IAAI,CAAC,KAAK,MAAM,IAAI,GAAG,CAAC,gBAAgB,CAAC,KAAK,MAAM,CAAC;IACtE,OAAO,CAAC,IAAI,CAAC;AACf,CAAC"}