@molecule/api-code-sandbox-flyio 1.2.1 → 1.2.3

package/LICENSE

@@ -1,3 +1,4 @@
+
                                  Apache License
                            Version 2.0, January 2004
                         http://www.apache.org/licenses/
@@ -34,21 +35,33 @@
 
       "Work" shall mean the work of authorship, whether in Source or
       Object form, made available under the License, as indicated by a
-      copyright notice that is included in or attached to the work.
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
 
       "Derivative Works" shall mean any work, whether in Source or Object
       form, that is based on (or derived from) the Work and for which the
       editorial revisions, annotations, elaborations, or other modifications
-      represent, as a whole, an original work of authorship.
-
-      "Contribution" shall mean any work of authorship, including the
-      original version of the Work and any modifications or additions
-      to that Work, that is intentionally submitted to the Licensor for
-      inclusion in the Work by the copyright owner or by an individual or
-      Legal Entity authorized to submit on behalf of the copyright owner.
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
 
       "Contributor" shall mean Licensor and any individual or Legal Entity
-      on behalf of whom a Contribution has been received by the Licensor and
+      on behalf of whom a Contribution has been received by Licensor and
       subsequently incorporated within the Work.
 
    2. Grant of Copyright License. Subject to the terms and conditions of
@@ -61,8 +74,18 @@
    3. Grant of Patent License. Subject to the terms and conditions of
       this License, each Contributor hereby grants to You a perpetual,
       worldwide, non-exclusive, no-charge, royalty-free, irrevocable
-      patent license to make, have made, use, offer to sell, sell, import,
-      and otherwise transfer the Work.
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
 
    4. Redistribution. You may reproduce and distribute copies of the
       Work or Derivative Works thereof in any medium, with or without
@@ -84,23 +107,87 @@
       (d) If the Work includes a "NOTICE" text file as part of its
           distribution, then any Derivative Works that You distribute must
           include a readable copy of the attribution notices contained
-          within such NOTICE file.
-
-   5. Submission of Contributions.
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
 
    6. Trademarks. This License does not grant permission to use the trade
-      names, trademarks, service marks, or product names of the Licensor.
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
 
    7. Disclaimer of Warranty. Unless required by applicable law or
-      agreed to in writing, Licensor provides the Work on an "AS IS" BASIS,
-      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND.
-
-   8. Limitation of Liability. In no event and under no legal theory shall
-      any Contributor be liable to You for damages.
-
-   9. Accepting Warranty or Additional Liability.
-
-   Copyright 2026 Molecule Dev, Inc.
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [yyyy] [name of copyright owner]
 
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.

package/dist/provider.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"provider.d.ts","sourceRoot":"","sources":["../src/provider.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAMH,OAAO,KAAK,EAWV,eAAe,EAGhB,MAAM,4BAA4B,CAAA;AAGnC,OAAO,EAAE,YAAY,EAAgC,MAAM,UAAU,CAAA;AAwBrE,OAAO,EAAmD,KAAK,WAAW,EAAE,MAAM,cAAc,CAAA;AAEhG,OAAO,KAAK,EAIV,WAAW,EAUZ,MAAM,YAAY,CAAA;AA0tEnB;;;;;;;;;GASG;AACH,wBAAgB,cAAc,CAC5B,MAAM,CAAC,EAAE,WAAW,EACpB,MAAM,CAAC,EAAE,YAAY,EACrB,KAAK,CAAC,EAAE,WAAW,GAAG,IAAI,GACzB,eAAe,CAEjB"}
+{"version":3,"file":"provider.d.ts","sourceRoot":"","sources":["../src/provider.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAMH,OAAO,KAAK,EAWV,eAAe,EAGhB,MAAM,4BAA4B,CAAA;AAGnC,OAAO,EAAE,YAAY,EAAgC,MAAM,UAAU,CAAA;AAwBrE,OAAO,EAAmD,KAAK,WAAW,EAAE,MAAM,cAAc,CAAA;AAEhG,OAAO,KAAK,EAIV,WAAW,EAUZ,MAAM,YAAY,CAAA;AA8yEnB;;;;;;;;;GASG;AACH,wBAAgB,cAAc,CAC5B,MAAM,CAAC,EAAE,WAAW,EACpB,MAAM,CAAC,EAAE,YAAY,EACrB,KAAK,CAAC,EAAE,WAAW,GAAG,IAAI,GACzB,eAAe,CAEjB"}

package/dist/provider.js

@@ -19,6 +19,18 @@ import { createTemplateStore, MAX_PRESIGN_EXPIRY_SECONDS } from './storage.js';
 import * as templates from './templates.js';
 import { shellQuote } from './utilities.js';
 const logger = getLogger();
+/**
+ * Words a failed `destroy()` step so the caller's log and retry say which step failed.
+ * @param step - The step that failed (`machine delete` or `app delete`).
+ * @param id - The composite sandbox id.
+ * @param error - The underlying failure.
+ * @returns The error message, naming the step and the HTTP status when known.
+ */
+function describeDestroyFailure(step, id, error) {
+    const status = error instanceof FlyApiError ? `HTTP ${error.status}` : 'no HTTP status';
+    const reason = error instanceof Error ? error.message : String(error);
+    return `Fly sandbox destroy failed at the ${step} for ${id} (${status}): ${reason}`;
+}
 /**
  * Default sandbox image. Fly pulls images itself, so this MUST be a reference
  * Fly can resolve — a tag in the org's `registry.fly.io` repository or a public
@@ -358,6 +370,7 @@ class FlyioSandboxProvider {
      */
     async ensureApp(app, options = {}) {
         const existing = await this.client.request(`/apps/${app}`, { nullOn: [404] });
+        let createdHere = false;
         if (!existing) {
             const body = { name: app, org_slug: this.orgSlug() };
             const network = this.networkFor(app);
@@ -379,13 +392,47 @@ class FlyioSandboxProvider {
                     throw error;
                 }
             }
-            if (created && this.config.assignSharedIpv4)
+            createdHere = created;
+        }
+        try {
+            if (createdHere && this.config.assignSharedIpv4)
                 await this.assignSharedIpv4(app);
+            await this.applyEgressPolicy(app);
+            if (options.privateRoutes === false)
+                return { routes: {}, created: createdHere };
+            return {
+                routes: await this.ensurePrivateRoutes(app, Boolean(existing)),
+                created: createdHere,
+            };
+        }
+        catch (error) {
+            if (createdHere)
+                await this.discardCreatedApp(app, {});
+            throw error;
         }
-        await this.applyEgressPolicy(app);
-        if (options.privateRoutes === false)
-            return {};
-        return this.ensurePrivateRoutes(app, Boolean(existing));
+    }
+    /**
+     * Deletes an app THIS call created, after a later step of the same create
+     * failed. Without it every failed create leaves an app behind with its
+     * addresses and volume: on 2026-09-28, 34 empty `mol-prod-*` apps had piled
+     * up in production, one per deploy that hit the organization's Machine limit
+     * (`POST /machines` → 422) after its app was already made. An app that
+     * existed before the call is never touched — it may hold a working Machine.
+     * @param app - The app this call created.
+     * @param privateRoutes - Flycast addresses already allocated for it.
+     */
+    async discardCreatedApp(app, privateRoutes) {
+        try {
+            await this.client.request(`/apps/${app}`, { method: 'DELETE', nullOn: [404] });
+            logger.info('Deleted a Fly sandbox app whose create failed', { app });
+        }
+        catch (error) {
+            logger.error('Failed to delete a Fly sandbox app after its create failed — it leaks', {
+                app,
+                error,
+            });
+        }
+        await this.releasePrivateRoutes(privateRoutes);
     }
     /**
      * Allocates a Flycast private address on every declared service app, INTO this
@@ -880,7 +927,26 @@ class FlyioSandboxProvider {
         // leave in a Machine config.
         assertPrivateRoutesForEnv({ ...config.env, ...config.selfDeliveredEnv }, this.privateServices());
         const app = this.resolveApp(config.projectId);
-        const privateRoutes = await this.ensureApp(app);
+        const { routes: privateRoutes, created } = await this.ensureApp(app);
+        try {
+            return await this.createInApp(app, privateRoutes, config, manifest);
+        }
+        catch (error) {
+            if (created && this.appPerProject())
+                await this.discardCreatedApp(app, privateRoutes);
+            throw error;
+        }
+    }
+    /**
+     * The part of {@link create} that runs once the app exists: clear stale
+     * Machines, provision the volume, create the Machine and wait for it.
+     * @param app - The app.
+     * @param privateRoutes - Flycast addresses allocated for the app.
+     * @param config - The sandbox config.
+     * @param manifest - The template manifest, when creating from a template.
+     * @returns The running sandbox.
+     */
+    async createInApp(app, privateRoutes, config, manifest) {
         // Clear any stale Machine from a prior failed/partial create before
         // provisioning — otherwise it still holds the app's single-attach volume and
         // `POST /machines` fails with `412 volume already claimed`. Makes create
@@ -1206,6 +1272,9 @@ class FlyioSandboxProvider {
      * are read from the Machine's metadata FIRST — the Machine is the only record
      * of which address belongs to which network — and released last.
      * @param id - The composite sandbox id.
+     * @throws {Error} When the Machine delete or the app delete fails with anything
+     * other than a 404 (which counts as already gone), naming the failed step and
+     * HTTP status, so the caller can retry instead of forgetting a billed app.
      */
     async destroy(id) {
         const { app, machineId } = parseSandboxId(id);
@@ -1236,19 +1305,30 @@ class FlyioSandboxProvider {
             });
         }
         catch (error) {
-            logger.warn('Failed to destroy Fly Machine', { id, error });
+            // The app delete is not attempted: removing the app under a Machine that
+            // is still alive would hide it. The private addresses are left for the
+            // retry, which re-reads them from the Machine's metadata.
+            logger.error('Failed to destroy Fly Machine', { id, error });
+            throw new Error(describeDestroyFailure('machine delete', id, error), { cause: error });
         }
         if (this.appPerProject()) {
+            let appError;
             try {
                 await this.client.request(`/apps/${app}`, { method: 'DELETE', nullOn: [404] });
             }
             catch (error) {
-                logger.warn('Failed to delete Fly sandbox app — its volumes and 6PN network may leak', {
+                appError = error;
+                logger.error('Failed to delete Fly sandbox app — its volumes and 6PN network may leak', {
                     app,
                     error,
                 });
             }
+            // Released even when the app delete failed: the Machine is gone, so a
+            // retry could no longer read these addresses from its metadata.
             await this.releasePrivateRoutes(privateRoutes);
+            if (appError !== undefined) {
+                throw new Error(describeDestroyFailure('app delete', id, appError), { cause: appError });
+            }
             return;
         }
         for (const volumeId of volumeIds) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@molecule/api-code-sandbox-flyio",
-  "version": "1.2.1",
+  "version": "1.2.3",
   "description": "Fly.io Machines (Firecracker microVM) code sandbox provider",
   "type": "module",
   "main": "dist/index.js",