@molecule/api-code-sandbox-flyio 1.2.1 → 1.2.2

package/dist/provider.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"provider.d.ts","sourceRoot":"","sources":["../src/provider.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAMH,OAAO,KAAK,EAWV,eAAe,EAGhB,MAAM,4BAA4B,CAAA;AAGnC,OAAO,EAAE,YAAY,EAAgC,MAAM,UAAU,CAAA;AAwBrE,OAAO,EAAmD,KAAK,WAAW,EAAE,MAAM,cAAc,CAAA;AAEhG,OAAO,KAAK,EAIV,WAAW,EAUZ,MAAM,YAAY,CAAA;AA0tEnB;;;;;;;;;GASG;AACH,wBAAgB,cAAc,CAC5B,MAAM,CAAC,EAAE,WAAW,EACpB,MAAM,CAAC,EAAE,YAAY,EACrB,KAAK,CAAC,EAAE,WAAW,GAAG,IAAI,GACzB,eAAe,CAEjB"}
+{"version":3,"file":"provider.d.ts","sourceRoot":"","sources":["../src/provider.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAMH,OAAO,KAAK,EAWV,eAAe,EAGhB,MAAM,4BAA4B,CAAA;AAGnC,OAAO,EAAE,YAAY,EAAgC,MAAM,UAAU,CAAA;AAwBrE,OAAO,EAAmD,KAAK,WAAW,EAAE,MAAM,cAAc,CAAA;AAEhG,OAAO,KAAK,EAIV,WAAW,EAUZ,MAAM,YAAY,CAAA;AAmxEnB;;;;;;;;;GASG;AACH,wBAAgB,cAAc,CAC5B,MAAM,CAAC,EAAE,WAAW,EACpB,MAAM,CAAC,EAAE,YAAY,EACrB,KAAK,CAAC,EAAE,WAAW,GAAG,IAAI,GACzB,eAAe,CAEjB"}

package/dist/provider.js

@@ -358,6 +358,7 @@ class FlyioSandboxProvider {
      */
     async ensureApp(app, options = {}) {
         const existing = await this.client.request(`/apps/${app}`, { nullOn: [404] });
+        let createdHere = false;
         if (!existing) {
             const body = { name: app, org_slug: this.orgSlug() };
             const network = this.networkFor(app);
@@ -379,13 +380,47 @@ class FlyioSandboxProvider {
                     throw error;
                 }
             }
-            if (created && this.config.assignSharedIpv4)
+            createdHere = created;
+        }
+        try {
+            if (createdHere && this.config.assignSharedIpv4)
                 await this.assignSharedIpv4(app);
+            await this.applyEgressPolicy(app);
+            if (options.privateRoutes === false)
+                return { routes: {}, created: createdHere };
+            return {
+                routes: await this.ensurePrivateRoutes(app, Boolean(existing)),
+                created: createdHere,
+            };
+        }
+        catch (error) {
+            if (createdHere)
+                await this.discardCreatedApp(app, {});
+            throw error;
         }
-        await this.applyEgressPolicy(app);
-        if (options.privateRoutes === false)
-            return {};
-        return this.ensurePrivateRoutes(app, Boolean(existing));
+    }
+    /**
+     * Deletes an app THIS call created, after a later step of the same create
+     * failed. Without it every failed create leaves an app behind with its
+     * addresses and volume: on 2026-09-28, 34 empty `mol-prod-*` apps had piled
+     * up in production, one per deploy that hit the organization's Machine limit
+     * (`POST /machines` → 422) after its app was already made. An app that
+     * existed before the call is never touched — it may hold a working Machine.
+     * @param app - The app this call created.
+     * @param privateRoutes - Flycast addresses already allocated for it.
+     */
+    async discardCreatedApp(app, privateRoutes) {
+        try {
+            await this.client.request(`/apps/${app}`, { method: 'DELETE', nullOn: [404] });
+            logger.info('Deleted a Fly sandbox app whose create failed', { app });
+        }
+        catch (error) {
+            logger.error('Failed to delete a Fly sandbox app after its create failed — it leaks', {
+                app,
+                error,
+            });
+        }
+        await this.releasePrivateRoutes(privateRoutes);
     }
     /**
      * Allocates a Flycast private address on every declared service app, INTO this
@@ -880,7 +915,26 @@ class FlyioSandboxProvider {
         // leave in a Machine config.
         assertPrivateRoutesForEnv({ ...config.env, ...config.selfDeliveredEnv }, this.privateServices());
         const app = this.resolveApp(config.projectId);
-        const privateRoutes = await this.ensureApp(app);
+        const { routes: privateRoutes, created } = await this.ensureApp(app);
+        try {
+            return await this.createInApp(app, privateRoutes, config, manifest);
+        }
+        catch (error) {
+            if (created && this.appPerProject())
+                await this.discardCreatedApp(app, privateRoutes);
+            throw error;
+        }
+    }
+    /**
+     * The part of {@link create} that runs once the app exists: clear stale
+     * Machines, provision the volume, create the Machine and wait for it.
+     * @param app - The app.
+     * @param privateRoutes - Flycast addresses allocated for the app.
+     * @param config - The sandbox config.
+     * @param manifest - The template manifest, when creating from a template.
+     * @returns The running sandbox.
+     */
+    async createInApp(app, privateRoutes, config, manifest) {
         // Clear any stale Machine from a prior failed/partial create before
         // provisioning — otherwise it still holds the app's single-attach volume and
         // `POST /machines` fails with `412 volume already claimed`. Makes create

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@molecule/api-code-sandbox-flyio",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "Fly.io Machines (Firecracker microVM) code sandbox provider",
   "type": "module",
   "main": "dist/index.js",