@molecule/api-code-sandbox-docker 1.1.2 → 1.1.3

package/dist/provider.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"provider.d.ts","sourceRoot":"","sources":["../src/provider.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAQH,OAAO,KAAK,EAcV,eAAe,EAOhB,MAAM,4BAA4B,CAAA;AAoBnC,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,YAAY,CAAA;AA4K9C;;;;;;;;;;;;GAYG;AACH,wBAAgB,mBAAmB,CAAC,KAAK,CAAC,EAAE,MAAM,EAAE,GAAG,MAAM,EAAE,CAQ9D;AAkCD;;;;;;;;;;;;;;;;;;;;;;;;;GAyBG;AACH,wBAAsB,kBAAkB,CAAC,CAAC,EACxC,EAAE,EAAE,MAAM,OAAO,CAAC,CAAC,CAAC,EACpB,IAAI,EAAE;IACJ,KAAK,EAAE,MAAM,CAAA;IACb,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB,OAAO,CAAC,EAAE,MAAM,OAAO,CAAC,CAAC,GAAG,IAAI,CAAC,CAAA;IACjC,OAAO,CAAC,EAAE,CAAC,OAAO,EAAE,MAAM,KAAK,MAAM,CAAA;IACrC,GAAG,CAAC,EAAE;QAAE,IAAI,EAAE,CAAC,OAAO,EAAE,MAAM,EAAE,IAAI,CAAC,EAAE,OAAO,KAAK,IAAI,CAAA;KAAE,CAAA;CAC1D,GACA,OAAO,CAAC,CAAC,CAAC,CA2BZ;AA07CD;;;;;;GAMG;AACH,wBAAgB,cAAc,CAAC,MAAM,CAAC,EAAE,YAAY,GAAG,eAAe,CAErE"}
+{"version":3,"file":"provider.d.ts","sourceRoot":"","sources":["../src/provider.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAQH,OAAO,KAAK,EAcV,eAAe,EAOhB,MAAM,4BAA4B,CAAA;AAoBnC,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,YAAY,CAAA;AA4K9C;;;;;;;;;;;;GAYG;AACH,wBAAgB,mBAAmB,CAAC,KAAK,CAAC,EAAE,MAAM,EAAE,GAAG,MAAM,EAAE,CAQ9D;AAyED;;;;;;;;;;;;;;;;;;;;;;;;;GAyBG;AACH,wBAAsB,kBAAkB,CAAC,CAAC,EACxC,EAAE,EAAE,MAAM,OAAO,CAAC,CAAC,CAAC,EACpB,IAAI,EAAE;IACJ,KAAK,EAAE,MAAM,CAAA;IACb,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB,OAAO,CAAC,EAAE,MAAM,OAAO,CAAC,CAAC,GAAG,IAAI,CAAC,CAAA;IACjC,OAAO,CAAC,EAAE,CAAC,OAAO,EAAE,MAAM,KAAK,MAAM,CAAA;IACrC,GAAG,CAAC,EAAE;QAAE,IAAI,EAAE,CAAC,OAAO,EAAE,MAAM,EAAE,IAAI,CAAC,EAAE,OAAO,KAAK,IAAI,CAAA;KAAE,CAAA;CAC1D,GACA,OAAO,CAAC,CAAC,CAAC,CA2BZ;AAg9CD;;;;;;GAMG;AACH,wBAAgB,cAAc,CAAC,MAAM,CAAC,EAAE,YAAY,GAAG,eAAe,CAErE"}

package/dist/provider.js

@@ -190,6 +190,41 @@ export function resolvePublishPorts(ports) {
     }
     return [...new Set(ports)];
 }
+/**
+ * Give an imported tree to whoever owns the sandbox's workspace root.
+ *
+ * Docker's putArchive preserves the tar's uid/gid — 0 — while the sandbox runs
+ * as the image's USER. Everything the sandbox does afterwards is done by that
+ * user, so an unrepaired import is a tree it cannot write.
+ *
+ * It has to be done from here, and as root: an ordinary exec runs as the same
+ * non-root user and `chown` answers "Operation not permitted" (which a pipe
+ * then hides behind exit 0 — that is how the repair went unnoticed).
+ *
+ * @param dockerApi - The provider's API client, bound by the caller.
+ * @param containerId - The sandbox to repair.
+ * @param path - The absolute path that was just imported.
+ */
+async function chownImportedTree(dockerApi, containerId, path) {
+    try {
+        const created = (await dockerApi(`/containers/${containerId}/exec`, 'POST', {
+            // `|| true` so an image whose workspace root is already the running user
+            // (or a path that vanished) is a no-op rather than a thrown import.
+            Cmd: ['sh', '-c', `chown -R --reference=/workspace ${shellQuote(path)} || true`],
+            User: 'root',
+            AttachStdout: false,
+            AttachStderr: false,
+        }));
+        if (created?.Id) {
+            await dockerApi(`/exec/${created.Id}/start`, 'POST', { Detach: false, Tty: false });
+        }
+    }
+    catch (_error) {
+        // Intentional noop: best-effort repair. A daemon that refuses a root exec
+        // leaves the tree exactly as the tar delivered it — the behaviour before
+        // this existed — and an import must not fail over it.
+    }
+}
 /**
  * Available memory in bytes, or `null` when it cannot be read.
  *
@@ -1011,6 +1046,24 @@ class DockerSandboxProvider {
                     download: (p, timeoutMs) => provider.dockerDownload(p, timeoutMs),
                     upload: (p, body, timeoutMs) => provider.dockerUpload(p, body, timeoutMs),
                 }, containerId, path, archive);
+                // Docker's putArchive preserves the tar's uid/gid, which is 0, while the
+                // sandbox runs as the image's USER (`node`, uid 1000). Without this the
+                // imported tree belongs to a user nothing runs as: the executor cannot
+                // write a file it just received, npm install cannot touch node_modules,
+                // and Vite cannot create `node_modules/.vite-temp/…`, so the dev server
+                // never starts.
+                //
+                // A caller cannot repair it afterwards — an ordinary exec runs as that
+                // same non-root user and `chown` answers "Operation not permitted". The
+                // repair has to happen here, on a root exec, which is a docker-ism and
+                // belongs in the docker bond. (E2B has no equivalent step: it extracts
+                // with --no-same-owner, so files already arrive on the executor's user.)
+                //
+                // `--reference=/workspace` takes the answer from the image itself
+                // rather than naming a user, so it is correct for a root-based image
+                // and a non-root one alike. Best-effort: a failure here must not fail
+                // the import, and on an already-correct tree it is a no-op.
+                await chownImportedTree((p, method, body) => provider.dockerApi(p, method, body), containerId, path);
             },
             onFileChange(_cb) {
                 let active = true;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@molecule/api-code-sandbox-docker",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "description": "Docker-based code sandbox container provider",
   "type": "module",
   "main": "dist/index.js",