@mojaloop/sdk-scheme-adapter 24.9.8-snapshot.2 → 24.9.8-snapshot.3

package/.ncurc.yaml

@@ -12,6 +12,5 @@ reject: [
   ## esLint 9.15.0 caused the error: TypeError: Error while loading rule '@typescript-eslint/no-unused-expressions': Cannot read properties of undefined (reading 'allowShortCircuit')
   "eslint",
   ## express >5 introduces breaking changes that are not compatible with the current codebase.
-  "express",
-  "@mojaloop/central-services-shared"
+  "express"
 ]

package/modules/api-svc/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter-api-svc",
-  "version": "21.0.0-snapshot.40",
+  "version": "21.0.0-snapshot.41",
   "description": "An adapter for connecting to Mojaloop API enabled switches.",
   "main": "src/index.js",
   "types": "src/index.d.ts",
@@ -68,7 +68,7 @@
     "@mojaloop/central-services-error-handling": "13.1.0",
     "@mojaloop/central-services-logger": "11.9.0",
     "@mojaloop/central-services-metrics": "12.6.0",
-    "@mojaloop/central-services-shared": "18.26.2",
+    "@mojaloop/central-services-shared": "18.27.0",
     "@mojaloop/event-sdk": "14.5.1",
     "@mojaloop/logging-bc-client-lib": "0.5.8",
     "@mojaloop/ml-schema-transformer-lib": "2.7.1",
@@ -86,6 +86,7 @@
     "javascript-state-machine": "3.1.0",
     "js-yaml": "4.1.0",
     "json-schema-ref-parser": "9.0.9",
+    "knex": "3.1.0",
     "koa": "3.0.0",
     "koa-body": "6.0.1",
     "lodash": "4.17.21",
@@ -95,7 +96,7 @@
     "prom-client": "15.1.3",
     "promise-timeout": "1.3.0",
     "random-word-slugs": "0.1.7",
-    "redis": "5.1.1",
+    "redis": "5.5.5",
     "uuidv4": "6.2.13",
     "ws": "8.18.2"
   },

package/modules/api-svc/src/InboundServer/api.yaml

@@ -67,7 +67,9 @@ paths:
         - ping
       operationId: handlePostPing
       requestBody:
-        description: The object sent in the POST/PUT `/ping` requests with validation request ID.
+        description: >-
+          The object sent in the POST/PUT `/ping` requests with validation
+          request ID.
         required: true
         content:
           application/json:

package/modules/api-svc/src/InboundServer/index.js

@@ -26,7 +26,6 @@
  ******/
 const Koa = require('koa');
 
-const _ = require('lodash');
 const assert = require('assert').strict;
 const https = require('https');
 const http = require('http');
@@ -87,19 +86,6 @@ class InboundApi extends EventEmitter {
         return this._api.callback();
     }
 
-    _updatePeerJwsKeys(peerJwsKeys) {
-        // Security Risk only for testing purposes.
-        this._logger && this._logger.isDebugEnabled && this._logger.debug('Old peer JWS keys:', Object.entries(this._jwsVerificationKeys).map(([k, v]) => [k, v.toString()]));
-        this._logger && this._logger.isDebugEnabled && this._logger.debug('New peer JWS keys:', Object.entries(peerJwsKeys).map(([k, v]) => [k, v.toString()]));
-        if (this._conf.pm4mlEnabled && !_.isEqual(this._jwsVerificationKeys, peerJwsKeys) &&
-            this._jwsVerificationKeys && typeof this._jwsVerificationKeys === 'object') {
-            this._logger && this._logger.isVerboseEnabled && this._logger.verbose('Clearing existing JWS verification keys');
-            Object.keys(this._jwsVerificationKeys).forEach(key => delete this._jwsVerificationKeys[key]);
-            this._logger && this._logger.isVerboseEnabled && this._logger.verbose('Assigning new peer JWS keys');
-            Object.assign(this._jwsVerificationKeys, peerJwsKeys);
-        }
-    }
-
     _startJwsWatcher() {
         const FS_EVENT_TYPES = {
             CHANGE: 'change',

package/modules/api-svc/src/index.js

@@ -140,8 +140,50 @@ class Server extends EventEmitter {
     }
 
     _shouldUpdateInboundServer(newConf) {
-        return !_.isEqual(this.conf.inbound, newConf.inbound)
-            || !_.isEqual(this.conf.outbound, newConf.outbound);
+        const isInboundDifferent = !_.isEqual(this.conf.inbound, newConf.inbound);
+        const isOutboundDifferent = !_.isEqual(this.conf.outbound, newConf.outbound);
+        const isPeerJWSKeysDifferent = !_.isEqual(this.conf.peerJWSKeys, newConf.peerJWSKeys);
+
+        if (isInboundDifferent) {
+            this.logger.debug('Inbound config is different', {
+                oldInbound: this.conf.inbound,
+                newInbound: newConf.inbound
+            });
+        }
+        if (isOutboundDifferent) {
+            this.logger.debug('Outbound config is different (checked in inbound update)', {
+                oldOutbound: this.conf.outbound,
+                newOutbound: newConf.outbound
+            });
+        }
+        if (isPeerJWSKeysDifferent) {
+            this.logger.debug('Peer JWS Keys config is different', {
+                oldPeerJWSKeys: this.conf.peerJWSKeys,
+                newPeerJWSKeys: newConf.peerJWSKeys
+            });
+        }
+
+        return isInboundDifferent || isOutboundDifferent || isPeerJWSKeysDifferent;
+    }
+
+    _shouldUpdateOutboundServer(newConf) {
+        const isOutboundDifferent = !_.isEqual(this.conf.outbound, newConf.outbound);
+        const isJwsSigningKeyDifferent = !_.isEqual(this.conf.jwsSigningKey, newConf.jwsSigningKey);
+
+        if (isOutboundDifferent) {
+            this.logger.debug('Outbound config is different', {
+                oldOutbound: this.conf.outbound,
+                newOutbound: newConf.outbound
+            });
+        }
+        if (isJwsSigningKeyDifferent) {
+            this.logger.debug('JWS signing key is different', {
+                oldJwsSigningKey: this.conf.jwsSigningKey,
+                newJwsSigningKey: newConf.jwsSigningKey
+            });
+        }
+
+        return isOutboundDifferent || isJwsSigningKeyDifferent;
     }
 
     async start() {
@@ -247,10 +289,8 @@ class Server extends EventEmitter {
             restartActionsTaken.updateInboundServer = true;
         }
 
-        this.inboundServer._api._updatePeerJwsKeys(newConf.peerJWSKeys);
-
         this.logger.isDebugEnabled && this.logger.push({ oldConf: this.conf.outbound, newConf: newConf.outbound }).debug('Outbound server configuration');
-        const updateOutboundServer = !_.isEqual(this.conf.outbound, newConf.outbound);
+        const updateOutboundServer = this._shouldUpdateOutboundServer(this.conf, newConf);
         if (updateOutboundServer) {
             await this.outboundServer.stop();
             this.outboundServer = new OutboundServer(

package/modules/api-svc/test/unit/InboundServer.test.js

@@ -490,59 +490,5 @@ describe('Inbound Server', () => {
 
             expect(Jws.validator.__validationKeys['mock-jws'].toString()).toEqual('foo-key-updated');
         });
-
-        it('should overwrite an existing peer JWS key when _updatePeerJwsKeys is called with the same key name', async () => {
-            // Arrange
-            const serverConfig = JSON.parse(JSON.stringify(defaultConfig));
-            serverConfig.validateInboundJws = true;
-            const cache = new Cache({
-                cacheUrl: serverConfig.cacheUrl,
-                logger: logger.push({ component: 'cache' }),
-                unsubscribeTimeoutMs: serverConfig.unsubscribeTimeoutMs,
-            });
-            serverConfig.validateInboundJws = true;
-            serverConfig.pm4mlEnabled = true;
-            serverConfig.peerJWSKeys = {
-                'peer1': 'original-key'
-            };
-            const svr = new InboundServer(serverConfig, logger, cache);
-
-            // Save reference before update
-            const keysRef = svr._api._jwsVerificationKeys;
-
-            // Act: Overwrite the key
-            svr._api._updatePeerJwsKeys({ 'peer1': 'new-key' });
-
-            // Assert
-            expect(svr._api._jwsVerificationKeys['peer1']).toBe('new-key');
-            expect(svr._api._jwsVerificationKeys).toBe(keysRef); // memory reference unchanged
-        });
-
-        it('should add a new peer JWS key when _updatePeerJwsKeys is called with a new key name', async () => {
-            // Arrange
-            const serverConfig = JSON.parse(JSON.stringify(defaultConfig));
-            serverConfig.validateInboundJws = true;
-            const cache = new Cache({
-                cacheUrl: serverConfig.cacheUrl,
-                logger: logger.push({ component: 'cache' }),
-                unsubscribeTimeoutMs: serverConfig.unsubscribeTimeoutMs,
-            });
-            serverConfig.validateInboundJws = true;
-            serverConfig.pm4mlEnabled = true;
-            serverConfig.peerJWSKeys = {
-                'peer1': 'original-key'
-            };
-            const svr = new InboundServer(serverConfig, logger, cache);
-
-            // Save reference before update
-            const keysRef = svr._api._jwsVerificationKeys;
-
-            // Act: Add a new key
-            svr._api._updatePeerJwsKeys({ 'peer1': 'original-key', 'peer2': 'another-key' });
-            // Assert
-            expect(svr._api._jwsVerificationKeys['peer1']).toBe('original-key');
-            expect(svr._api._jwsVerificationKeys['peer2']).toBe('another-key');
-            expect(svr._api._jwsVerificationKeys).toBe(keysRef); // memory reference unchanged
-        });
     });
 });

package/modules/outbound-command-event-handler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter-outbound-command-event-handler",
-  "version": "0.3.0-snapshot.36",
+  "version": "0.3.0-snapshot.38",
   "description": "Mojaloop sdk scheme adapter command event handler",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/sdk-scheme-adapter/",
@@ -42,7 +42,7 @@
   },
   "dependencies": {
     "@mojaloop/api-snippets": "17.10.3",
-    "@mojaloop/central-services-shared": "18.26.2",
+    "@mojaloop/central-services-shared": "18.27.0",
     "@mojaloop/logging-bc-client-lib": "0.5.8",
     "@mojaloop/logging-bc-public-types-lib": "0.5.5",
     "@mojaloop/sdk-scheme-adapter-private-shared-lib": "workspace:^",
@@ -51,7 +51,7 @@
     "convict": "6.2.4",
     "express": "4.21.2",
     "openapi-backend": "5.12.0",
-    "redis": "5.1.1",
+    "redis": "5.5.5",
     "swagger-ui-express": "5.0.1",
     "yamljs": "0.3.0"
   },

package/modules/outbound-domain-event-handler/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@mojaloop/sdk-scheme-adapter-outbound-domain-event-handler",
-    "version": "0.3.0-snapshot.36",
+    "version": "0.3.0-snapshot.38",
     "description": "mojaloop sdk scheme adapter outbound domain event handler",
     "license": "Apache-2.0",
     "homepage": "https://github.com/mojaloop/sdk-scheme-adapter/",
@@ -49,7 +49,7 @@
         "convict": "6.2.4",
         "express": "4.21.2",
         "openapi-backend": "5.12.0",
-        "redis": "5.1.1",
+        "redis": "5.5.5",
         "swagger-ui-express": "5.0.1",
         "yamljs": "0.3.0"
     },

package/modules/private-shared-lib/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter-private-shared-lib",
-  "version": "0.4.0-snapshot.36",
+  "version": "0.4.0-snapshot.38",
   "description": "SDK Scheme Adapter private shared library.",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/accounts-and-balances-bc/tree/main/modules/private-types",
@@ -30,12 +30,12 @@
   },
   "dependencies": {
     "@mojaloop/api-snippets": "17.10.3",
-    "@mojaloop/central-services-shared": "18.26.2",
+    "@mojaloop/central-services-shared": "18.27.0",
     "@mojaloop/logging-bc-public-types-lib": "0.5.5",
     "@mojaloop/platform-shared-lib-messaging-types-lib": "0.7.2",
     "@mojaloop/platform-shared-lib-nodejs-kafka-client-lib": "0.5.18",
     "ajv": "8.17.1",
-    "redis": "5.1.1",
+    "redis": "5.5.5",
     "uuid": "11.1.0"
   },
   "devDependencies": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter",
-  "version": "24.9.8-snapshot.2",
+  "version": "24.9.8-snapshot.3",
   "description": "mojaloop sdk-scheme-adapter",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/sdk-scheme-adapter",
@@ -77,7 +77,6 @@
     "wait-4-docker": "node ./scripts/_wait4_all.js"
   },
   "dependencies": {
-    "@mojaloop/central-services-shared": "18.26.2",
     "nx": "16.5.0",
     "tslib": "2.8.1"
   },