@mojaloop/sdk-scheme-adapter 24.15.0 → 24.15.2

package/modules/api-svc/test/unit/{index.configPolling.test.js → SdkServer.configPolling.test.js}

@@ -35,8 +35,8 @@ jest.mock('~/lib/cache');
 jest.mock('~/ControlAgent');
 
 const promClient = require('prom-client');
+const SdkServer = require('../../src/SdkServer');
 const ControlAgent = require('~/ControlAgent');
-const { Server } = require('~/index');
 const { logger } = require('~/lib/logger');
 const testConfig = require('./data/defaultConfig.json');
 
@@ -92,7 +92,7 @@ describe('Config Polling Tests -->', () => {
             }
         };
 
-        server = new Server(config, logger);
+        server = new SdkServer(config, logger);
         await server.start();
 
         await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS * 2);
@@ -105,7 +105,7 @@ describe('Config Polling Tests -->', () => {
             pm4mlEnabled: false,
         };
 
-        server = new Server(config, logger);
+        server = new SdkServer(config, logger);
         await server.start();
 
         await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS * 2);
@@ -113,7 +113,7 @@ describe('Config Polling Tests -->', () => {
     });
 
     it('should poll at configured interval', async () => {
-        server = new Server(mockConfig, logger);
+        server = new SdkServer(mockConfig, logger);
         await server.start();
         expect(mockControlAgent.getUpdatedConfig).toHaveBeenCalledTimes(0);
 
@@ -130,7 +130,7 @@ describe('Config Polling Tests -->', () => {
             jwsSigningKey: newJwsKey
         });
 
-        server = new Server(mockConfig, logger);
+        server = new SdkServer(mockConfig, logger);
         const restartSpy = jest.spyOn(server, 'restart');
 
         await server.start();
@@ -150,7 +150,7 @@ describe('Config Polling Tests -->', () => {
     it('should handle unchanged config efficiently (no-op)', async () => {
         mockControlAgent.getUpdatedConfig.mockResolvedValue({});
 
-        server = new Server(mockConfig, logger);
+        server = new SdkServer(mockConfig, logger);
         const restartSpy = jest.spyOn(server, 'restart');
         await server.start();
 
@@ -165,7 +165,7 @@ describe('Config Polling Tests -->', () => {
     it('should prevent race condition when update already in progress', async () => {
         mockControlAgent.getUpdatedConfig.mockResolvedValue({ jwsSigningKey: 'new-key' });
 
-        server = new Server(mockConfig, logger);
+        server = new SdkServer(mockConfig, logger);
         await server.start();
         // Simulate restart in progress
         server._configUpdateInProgress = true;
@@ -176,7 +176,7 @@ describe('Config Polling Tests -->', () => {
     });
 
     it('should skip polling when WebSocket not OPEN', async () => {
-        server = new Server(mockConfig, logger);
+        server = new SdkServer(mockConfig, logger);
         await server.start();
 
         mockControlAgent.getUpdatedConfig.mockClear();
@@ -190,7 +190,7 @@ describe('Config Polling Tests -->', () => {
         it('should handle network errors gracefully during polling', async () => {
             mockControlAgent.getUpdatedConfig.mockRejectedValue(new Error('Connection refused'));
 
-            server = new Server(mockConfig, logger);
+            server = new SdkServer(mockConfig, logger);
             await server.start();
             await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS);
 
@@ -204,7 +204,7 @@ describe('Config Polling Tests -->', () => {
         it('should handle missing config response', async () => {
             mockControlAgent.getUpdatedConfig.mockResolvedValue(null);
 
-            server = new Server(mockConfig, logger);
+            server = new SdkServer(mockConfig, logger);
             await server.start();
             await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS);
 
@@ -214,7 +214,7 @@ describe('Config Polling Tests -->', () => {
     });
 
     it('should stop polling when server stops', async () => {
-        server = new Server(mockConfig, logger);
+        server = new SdkServer(mockConfig, logger);
         await server.start();
 
         expect(server._configPollInterval).toBeDefined();

package/modules/api-svc/test/unit/lib/model/InboundTransfersModel.test.js

@@ -41,6 +41,7 @@ jest.mock('~/lib/model/lib/requests',() => require('./mockedLibRequests'));
 
 const randomUUID = require('@mojaloop/central-services-shared').Util.id({type: 'ulid'});
 const { MojaloopRequests, Ilp } = require('@mojaloop/sdk-standard-components');
+const axios = require('axios');
 const { logger } = require('~/lib/logger');
 const { BackendRequests, HTTPResponseError } = require('~/lib/model/lib/requests');
 const Cache = require('~/lib/cache');
@@ -1426,4 +1427,218 @@ describe('inboundModel', () => {
         });
         // todo: add error case tests
     });
+    describe('sendNotificationToPayee: retry logic for 4xx errors', () => {
+        const transferId = '1234';
+        let cache;
+
+        beforeEach(async () => {
+            cache = new Cache({
+                cacheUrl: 'redis://dummy:1234',
+                logger,
+                unsubscribeTimeoutMs: 5000
+            });
+            await cache.connect();
+        });
+
+        afterEach(async () => {
+            await cache.disconnect();
+        });
+
+        test('does not retry notification to fsp backend on 4xx error', async () => {
+            const error = new axios.AxiosError(
+                'Bad Request',
+                'ERR_BAD_REQUEST',
+                {
+                    method: 'put',
+                    url: '/transfersNotification',
+                    headers: {},
+                    data: {},
+                },
+                {},
+                {
+                    status: 400,
+                    statusText: 'Bad Request',
+                    headers: {},
+                    config: {},
+                    data: {
+                        statusCode: '400',
+                        message: 'Bad Request'
+                    }
+                }
+            );
+            const mockFn = jest.fn().mockRejectedValue(error);
+            BackendRequests.__putTransfersNotification = mockFn;
+
+            const notif = JSON.parse(JSON.stringify(notificationToPayee));
+            const model = new Model({
+                ...config,
+                cache,
+                logger,
+                backendRequestRetry: {
+                    enabled: true,
+                    maxRetries: 3,
+                    retryDelayMs: 10,
+                    maxRetryDelayMs: 20,
+                    backoffFactor: 1
+                }
+            });
+
+            await model.sendNotificationToPayee(notif.data, transferId);
+            // Should only be called once, no retry
+            expect(BackendRequests.__putTransfersNotification).toHaveBeenCalledTimes(1);
+        });
+
+        test('does not retry notification to fsp backend on 404 error', async () => {
+
+            const error = new axios.AxiosError(
+                'Not Found',
+                'ERR_BAD_REQUEST',
+                {
+                    method: 'put',
+                    url: '/transfersNotification',
+                    headers: {},
+                    data: {},
+                },
+                {},
+                {
+                    status: 404,
+                    statusText: 'Not Found',
+                    headers: {},
+                    config: {},
+                    data: {
+                        statusCode: '404',
+                        message: 'Not Found'
+                    }
+                }
+            );
+            const mockFn = jest.fn().mockRejectedValue(error);
+            BackendRequests.__putTransfersNotification = mockFn;
+
+            const notif = JSON.parse(JSON.stringify(notificationToPayee));
+            const model = new Model({
+                ...config,
+                cache,
+                logger,
+                backendRequestRetry: {
+                    enabled: true,
+                    maxRetries: 3,
+                    retryDelayMs: 10,
+                    maxRetryDelayMs: 20,
+                    backoffFactor: 1
+                }
+            });
+
+            await model.sendNotificationToPayee(notif.data, transferId);
+            // Should only be called once, no retry
+            expect(BackendRequests.__putTransfersNotification).toHaveBeenCalledTimes(1);
+        });
+    });
+
+    describe('sendFxPutNotificationToBackend: retry logic for 4xx errors', () => {
+        const conversionId = '1234';
+        let cache;
+
+        beforeEach(async () => {
+            cache = new Cache({
+                cacheUrl: 'redis://dummy:1234',
+                logger,
+                unsubscribeTimeoutMs: 5000
+            });
+            await cache.connect();
+        });
+
+        afterEach(async () => {
+            await cache.disconnect();
+        });
+
+        test('does not retry notification to backend on 4xx error', async () => {
+            const error = new axios.AxiosError(
+                'Bad Request',
+                'ERR_BAD_REQUEST',
+                {
+                    method: 'put',
+                    url: '/fxTransfersNotification',
+                    headers: {},
+                    data: {},
+                },
+                {},
+                {
+                    status: 400,
+                    statusText: 'Bad Request',
+                    headers: {},
+                    config: {},
+                    data: {
+                        statusCode: '400',
+                        message: 'Bad Request'
+                    }
+                }
+            );
+            const mockFn = jest.fn().mockRejectedValue(error);
+            BackendRequests.__putFxTransfersNotification = mockFn;
+
+            const notif = JSON.parse(JSON.stringify(fxNotificationToBackend));
+            const model = new Model({
+                ...config,
+                cache,
+                logger,
+                backendRequestRetry: {
+                    enabled: true,
+                    maxRetries: 3,
+                    retryDelayMs: 10,
+                    maxRetryDelayMs: 20,
+                    backoffFactor: 1
+                }
+            });
+            model.saveFxState = jest.fn().mockReturnValue(Promise.resolve({}));
+
+            await model.sendFxPutNotificationToBackend(notif.data, conversionId);
+            // Should only be called once, no retry
+            expect(BackendRequests.__putFxTransfersNotification).toHaveBeenCalledTimes(1);
+        });
+
+        test('does not retry notification to backend on 404 error', async () => {
+            const error = new axios.AxiosError(
+                'Not Found',
+                'ERR_BAD_REQUEST',
+                {
+                    method: 'put',
+                    url: '/fxTransfersNotification',
+                    headers: {},
+                    data: {},
+                },
+                {},
+                {
+                    status: 404,
+                    statusText: 'Not Found',
+                    headers: {},
+                    config: {},
+                    data: {
+                        statusCode: '404',
+                        message: 'Not Found'
+                    }
+                }
+            );
+            const mockFn = jest.fn().mockRejectedValue(error);
+            BackendRequests.__putFxTransfersNotification = mockFn;
+
+            const notif = JSON.parse(JSON.stringify(fxNotificationToBackend));
+            const model = new Model({
+                ...config,
+                cache,
+                logger,
+                backendRequestRetry: {
+                    enabled: true,
+                    maxRetries: 3,
+                    retryDelayMs: 10,
+                    maxRetryDelayMs: 20,
+                    backoffFactor: 1
+                }
+            });
+            model.saveFxState = jest.fn().mockReturnValue(Promise.resolve({}));
+
+            await model.sendFxPutNotificationToBackend(notif.data, conversionId);
+            // Should only be called once, no retry
+            expect(BackendRequests.__putFxTransfersNotification).toHaveBeenCalledTimes(1);
+        });
+    });
 });

package/modules/outbound-command-event-handler/package.json

@@ -42,7 +42,7 @@
   },
   "dependencies": {
     "@mojaloop/api-snippets": "18.2.0",
-    "@mojaloop/central-services-shared": "18.34.1",
+    "@mojaloop/central-services-shared": "18.34.2",
     "@mojaloop/logging-bc-client-lib": "0.5.8",
     "@mojaloop/logging-bc-public-types-lib": "0.5.6",
     "@mojaloop/sdk-scheme-adapter-private-shared-lib": "workspace:^",
@@ -60,13 +60,13 @@
     "@types/convict": "6.1.6",
     "@types/express": "5.0.3",
     "@types/jest": "30.0.0",
-    "@types/node": "24.7.0",
+    "@types/node": "24.8.1",
     "@types/node-cache": "4.2.5",
     "@types/supertest": "6.0.3",
     "@types/swagger-ui-express": "4.1.8",
     "@types/yamljs": "0.2.34",
-    "@typescript-eslint/eslint-plugin": "8.46.0",
-    "@typescript-eslint/parser": "8.46.0",
+    "@typescript-eslint/eslint-plugin": "8.46.1",
+    "@typescript-eslint/parser": "8.46.1",
     "copyfiles": "2.4.1",
     "eslint": "9.15.0",
     "jest": "29.7.0",
@@ -74,7 +74,7 @@
     "npm-check-updates": "16.7.10",
     "replace": "1.2.2",
     "standard-version": "9.5.0",
-    "ts-jest": "29.4.4",
+    "ts-jest": "29.4.5",
     "ts-node": "10.9.2",
     "typescript": "5.9.3"
   },

package/modules/outbound-domain-event-handler/package.json

@@ -57,13 +57,13 @@
         "@types/convict": "6.1.6",
         "@types/express": "5.0.3",
         "@types/jest": "30.0.0",
-        "@types/node": "24.7.0",
+        "@types/node": "24.8.1",
         "@types/node-cache": "4.2.5",
         "@types/supertest": "6.0.3",
         "@types/swagger-ui-express": "4.1.8",
         "@types/yamljs": "0.2.34",
-        "@typescript-eslint/eslint-plugin": "8.46.0",
-        "@typescript-eslint/parser": "8.46.0",
+        "@typescript-eslint/eslint-plugin": "8.46.1",
+        "@typescript-eslint/parser": "8.46.1",
         "copyfiles": "2.4.1",
         "eslint": "9.15.0",
         "jest": "29.7.0",
@@ -71,7 +71,7 @@
         "npm-check-updates": "16.7.10",
         "replace": "1.2.2",
         "standard-version": "9.5.0",
-        "ts-jest": "29.4.4",
+        "ts-jest": "29.4.5",
         "ts-node": "10.9.2",
         "typescript": "5.9.3"
     },

package/modules/private-shared-lib/package.json

@@ -30,7 +30,7 @@
   },
   "dependencies": {
     "@mojaloop/api-snippets": "18.2.0",
-    "@mojaloop/central-services-shared": "18.34.1",
+    "@mojaloop/central-services-shared": "18.34.2",
     "@mojaloop/logging-bc-public-types-lib": "0.5.6",
     "@mojaloop/platform-shared-lib-messaging-types-lib": "0.7.3",
     "@mojaloop/platform-shared-lib-nodejs-kafka-client-lib": "0.5.18",
@@ -40,16 +40,16 @@
   },
   "devDependencies": {
     "@eslint/compat": "1.4.0",
-    "@types/node": "24.7.0",
+    "@types/node": "24.8.1",
     "@types/uuid": "10.0.0",
-    "@typescript-eslint/eslint-plugin": "8.46.0",
-    "@typescript-eslint/parser": "8.46.0",
+    "@typescript-eslint/eslint-plugin": "8.46.1",
+    "@typescript-eslint/parser": "8.46.1",
     "eslint": "9.15.0",
     "jest": "29.7.0",
     "npm-check-updates": "16.7.10",
     "replace": "1.2.2",
     "standard-version": "9.5.0",
-    "ts-jest": "29.4.4",
+    "ts-jest": "29.4.5",
     "tslib": "2.8.1",
     "typescript": "5.9.3"
   },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter",
-  "version": "24.15.0",
+  "version": "24.15.2",
   "description": "mojaloop sdk-scheme-adapter",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/sdk-scheme-adapter",
@@ -83,10 +83,10 @@
   },
   "devDependencies": {
     "@types/jest": "30.0.0",
-    "@types/node": "24.7.0",
+    "@types/node": "24.8.1",
     "@types/node-cache": "4.2.5",
-    "@typescript-eslint/eslint-plugin": "8.46.0",
-    "@typescript-eslint/parser": "8.46.0",
+    "@typescript-eslint/eslint-plugin": "8.46.1",
+    "@typescript-eslint/parser": "8.46.1",
     "audit-ci": "7.1.0",
     "eslint": "9.15.0",
     "eslint-config-airbnb-typescript": "18.0.0",
@@ -98,7 +98,7 @@
     "npm-check-updates": "16.7.10",
     "replace": "1.2.2",
     "standard-version": "9.5.0",
-    "ts-jest": "29.4.4",
+    "ts-jest": "29.4.5",
     "ts-node": "10.9.2",
     "typescript": "5.9.3",
     "yarn-audit-fix": "10.1.1"