@mojaloop/sdk-scheme-adapter 24.13.0 → 24.14.0-snapshot.1

package/modules/api-svc/test/unit/index.configPolling.test.js

@@ -0,0 +1,229 @@
+/*****
+ License
+ --------------
+ Copyright © 2020-2025 Mojaloop Foundation
+ The Mojaloop files are made available by the Mojaloop Foundation under the Apache License, Version 2.0 (the "License") and you may not use these files except in compliance with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, the Mojaloop files are distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+
+ Contributors
+ --------------
+ This is the official list of the Mojaloop project contributors for this file.
+ Names of the original copyright holders (individuals or organizations)
+ should be listed with a '*' in the first column. People who have
+ contributed from an organization can be listed under the organization
+ that actually holds the copyright for their contributions (see the
+ Mojaloop Foundation for an example). Those individuals should have
+ their names indented and be marked with a '-'. Email address can be added
+ optionally within square brackets <email>.
+
+ * Mojaloop Foundation
+ * Eugen Klymniuk <eugen.klymniuk@infitx.com>
+
+ --------------
+ ******/
+
+process.env.PEER_ENDPOINT = 'localhost:4000';
+process.env.BACKEND_ENDPOINT = 'localhost:4000';
+process.env.CACHE_URL = 'redis://localhost:6379';
+process.env.MGMT_API_WS_URL = 'localhost';
+process.env.SUPPORTED_CURRENCIES = 'XXX';
+
+jest.mock('~/lib/cache');
+jest.mock('~/ControlAgent');
+
+const promClient = require('prom-client');
+const ControlAgent = require('~/ControlAgent');
+const { Server } = require('~/index');
+const { logger } = require('~/lib/logger');
+const testConfig = require('./data/defaultConfig.json');
+
+const POLL_INTERVAL_MS = 60_000;
+
+describe('Config Polling Tests -->', () => {
+    let server;
+    let mockConfig;
+    let mockControlAgent;
+
+    beforeEach(() => {
+        jest.clearAllMocks();
+        jest.useFakeTimers();
+        promClient.register.clear(); // to prevent "metric already been registered" error
+
+        mockConfig = {
+            ...testConfig,
+            pm4mlEnabled: true,
+            control: {
+                mgmtAPIWsUrl: 'localhost',
+                mgmtAPIWsPort: 4005,
+                mgmtAPILatencyAssumption: 2000,
+                mgmtAPIPollIntervalMs: POLL_INTERVAL_MS,
+            }
+        };
+
+        // Mock WebSocket client
+        mockControlAgent = {
+            getUpdatedConfig: jest.fn().mockResolvedValue({}),
+            readyState: 1, // OPEN
+            on: jest.fn(),
+            once: jest.fn(),
+            send: jest.fn(),
+            receive: jest.fn(),
+            stop: jest.fn().mockResolvedValue(true),
+            removeAllListeners: jest.fn(),
+        };
+
+        ControlAgent.createConnectedControlAgentWs = jest.fn().mockResolvedValue(mockControlAgent);
+    });
+
+    afterEach(async () => {
+        await server?.stop();
+        jest.useRealTimers();
+    });
+
+    it('should not start polling when MANAGEMENT_API_POLL_INTERVAL_MS is not configured', async () => {
+        const config = {
+            ...mockConfig,
+            control: {
+                ...mockConfig.control,
+                mgmtAPIPollIntervalMs: undefined,
+            }
+        };
+
+        server = new Server(config, logger);
+        await server.start();
+
+        await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS * 2);
+        expect(mockControlAgent.getUpdatedConfig).not.toHaveBeenCalled();
+    });
+
+    it('should not start polling when PM4ML is disabled', async () => {
+        const config = {
+            ...mockConfig,
+            pm4mlEnabled: false,
+        };
+
+        server = new Server(config, logger);
+        await server.start();
+
+        await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS * 2);
+        expect(ControlAgent.Client.Create).not.toHaveBeenCalled();
+    });
+
+    it('should poll at configured interval', async () => {
+        server = new Server(mockConfig, logger);
+        await server.start();
+        expect(mockControlAgent.getUpdatedConfig).toHaveBeenCalledTimes(0);
+
+        await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS);
+        expect(mockControlAgent.getUpdatedConfig).toHaveBeenCalledTimes(1); // First poll
+
+        await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS);
+        expect(mockControlAgent.getUpdatedConfig).toHaveBeenCalledTimes(2); // Second poll
+    });
+
+    it('should call restart with merged config from polling', async () => {
+        const newJwsKey = 'new-jws-signing-key';
+        mockControlAgent.getUpdatedConfig.mockResolvedValue({
+            jwsSigningKey: newJwsKey
+        });
+
+        server = new Server(mockConfig, logger);
+        const restartSpy = jest.spyOn(server, 'restart');
+
+        await server.start();
+        restartSpy.mockClear();
+
+
+        await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS);
+
+        expect(restartSpy).toHaveBeenCalledWith(
+            expect.objectContaining({
+                jwsSigningKey: newJwsKey
+            }),
+            { source: 'polling' }
+        );
+    });
+
+    it('should handle unchanged config efficiently (no-op)', async () => {
+        mockControlAgent.getUpdatedConfig.mockResolvedValue({});
+
+        server = new Server(mockConfig, logger);
+        const restartSpy = jest.spyOn(server, 'restart');
+        await server.start();
+
+        await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS - 10);
+        expect(restartSpy).toHaveBeenCalledTimes(1); // ping timeout
+
+        await jest.advanceTimersByTimeAsync(10);
+
+        expect(restartSpy).toHaveBeenCalledTimes(2);
+    });
+
+    it('should prevent race condition when update already in progress', async () => {
+        mockControlAgent.getUpdatedConfig.mockResolvedValue({ jwsSigningKey: 'new-key' });
+
+        server = new Server(mockConfig, logger);
+        await server.start();
+        // Simulate restart in progress
+        server._configUpdateInProgress = true;
+
+        await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS * 2);
+
+        expect(mockControlAgent.getUpdatedConfig).not.toHaveBeenCalled();
+    });
+
+    it('should skip polling when WebSocket not OPEN', async () => {
+        server = new Server(mockConfig, logger);
+        await server.start();
+
+        mockControlAgent.getUpdatedConfig.mockClear();
+        mockControlAgent.readyState = 0; // CONNECTING
+        await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS);
+
+        expect(mockControlAgent.getUpdatedConfig).not.toHaveBeenCalled();
+    });
+
+    describe('Error handling Tests -->', () => {
+        it('should handle network errors gracefully during polling', async () => {
+            mockControlAgent.getUpdatedConfig.mockRejectedValue(new Error('Connection refused'));
+
+            server = new Server(mockConfig, logger);
+            await server.start();
+            await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS);
+
+            // Error logged but polling continues - next poll should work
+            mockControlAgent.getUpdatedConfig.mockResolvedValue({});
+            await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS);
+
+            expect(mockControlAgent.getUpdatedConfig).toHaveBeenCalledTimes(2); // failed + success calls
+        });
+
+        it('should handle missing config response', async () => {
+            mockControlAgent.getUpdatedConfig.mockResolvedValue(null);
+
+            server = new Server(mockConfig, logger);
+            await server.start();
+            await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS);
+
+            // Should not crash, just log warning
+            expect(server).toBeDefined();
+        });
+    });
+
+    it('should stop polling when server stops', async () => {
+        server = new Server(mockConfig, logger);
+        await server.start();
+
+        expect(server._configPollInterval).toBeDefined();
+        await server.stop();
+        expect(server._configPollInterval).toBeNull();
+
+        mockControlAgent.getUpdatedConfig.mockClear();
+        await jest.advanceTimersByTimeAsync(POLL_INTERVAL_MS * 2);
+
+        expect(mockControlAgent.getUpdatedConfig).not.toHaveBeenCalled();
+    });
+});

package/modules/api-svc/test/unit/lib/model/InboundPingModel.test.js

@@ -69,7 +69,7 @@ const pingHeadersDto = ({
     ...(signature && { [Headers.FSPIOP.SIGNATURE]: signature })
 });
 
-describe.skip('InboundPingModel Tests -->', () => {
+describe('InboundPingModel Tests -->', () => {
     beforeEach(() => {
         mockAxios.reset();
     });
@@ -86,7 +86,7 @@ describe.skip('InboundPingModel Tests -->', () => {
         const sourceFspId = 'fromDfsp';
         const dfspId = 'theSDK';
         mockAxios.onPut().reply((reqConfig) => {
-            expect(reqConfig.url).toBe(`/ping/${requestId}/`);
+            expect(reqConfig.url).toBe(`/ping/${requestId}`);
             expect(reqConfig.headers[Headers.FSPIOP.SOURCE]).toBe(dfspId);
             expect(reqConfig.headers[Headers.FSPIOP.DESTINATION]).toBe(sourceFspId);
             return [200];

package/modules/outbound-command-event-handler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter-outbound-command-event-handler",
-  "version": "0.3.0-snapshot.65",
+  "version": "0.3.0-snapshot.67",
   "description": "Mojaloop sdk scheme adapter command event handler",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/sdk-scheme-adapter/",
@@ -42,7 +42,7 @@
   },
   "dependencies": {
     "@mojaloop/api-snippets": "18.2.0",
-    "@mojaloop/central-services-shared": "18.34.0",
+    "@mojaloop/central-services-shared": "18.34.1",
     "@mojaloop/logging-bc-client-lib": "0.5.8",
     "@mojaloop/logging-bc-public-types-lib": "0.5.6",
     "@mojaloop/sdk-scheme-adapter-private-shared-lib": "workspace:^",
@@ -65,8 +65,8 @@
     "@types/supertest": "6.0.3",
     "@types/swagger-ui-express": "4.1.8",
     "@types/yamljs": "0.2.34",
-    "@typescript-eslint/eslint-plugin": "8.45.0",
-    "@typescript-eslint/parser": "8.45.0",
+    "@typescript-eslint/eslint-plugin": "8.46.0",
+    "@typescript-eslint/parser": "8.46.0",
     "copyfiles": "2.4.1",
     "eslint": "9.15.0",
     "jest": "29.7.0",

package/modules/outbound-domain-event-handler/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@mojaloop/sdk-scheme-adapter-outbound-domain-event-handler",
-    "version": "0.3.0-snapshot.65",
+    "version": "0.3.0-snapshot.67",
     "description": "mojaloop sdk scheme adapter outbound domain event handler",
     "license": "Apache-2.0",
     "homepage": "https://github.com/mojaloop/sdk-scheme-adapter/",
@@ -62,8 +62,8 @@
         "@types/supertest": "6.0.3",
         "@types/swagger-ui-express": "4.1.8",
         "@types/yamljs": "0.2.34",
-        "@typescript-eslint/eslint-plugin": "8.45.0",
-        "@typescript-eslint/parser": "8.45.0",
+        "@typescript-eslint/eslint-plugin": "8.46.0",
+        "@typescript-eslint/parser": "8.46.0",
         "copyfiles": "2.4.1",
         "eslint": "9.15.0",
         "jest": "29.7.0",

package/modules/private-shared-lib/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter-private-shared-lib",
-  "version": "0.4.0-snapshot.65",
+  "version": "0.4.0-snapshot.67",
   "description": "SDK Scheme Adapter private shared library.",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/accounts-and-balances-bc/tree/main/modules/private-types",
@@ -30,7 +30,7 @@
   },
   "dependencies": {
     "@mojaloop/api-snippets": "18.2.0",
-    "@mojaloop/central-services-shared": "18.34.0",
+    "@mojaloop/central-services-shared": "18.34.1",
     "@mojaloop/logging-bc-public-types-lib": "0.5.6",
     "@mojaloop/platform-shared-lib-messaging-types-lib": "0.7.3",
     "@mojaloop/platform-shared-lib-nodejs-kafka-client-lib": "0.5.18",
@@ -42,8 +42,8 @@
     "@eslint/compat": "1.4.0",
     "@types/node": "24.7.0",
     "@types/uuid": "10.0.0",
-    "@typescript-eslint/eslint-plugin": "8.45.0",
-    "@typescript-eslint/parser": "8.45.0",
+    "@typescript-eslint/eslint-plugin": "8.46.0",
+    "@typescript-eslint/parser": "8.46.0",
     "eslint": "9.15.0",
     "jest": "29.7.0",
     "npm-check-updates": "16.7.10",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter",
-  "version": "24.13.0",
+  "version": "24.14.0-snapshot.1",
   "description": "mojaloop sdk-scheme-adapter",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/sdk-scheme-adapter",
@@ -18,7 +18,7 @@
     "Yevhen Kyriukha <yevhen.kyriukha@modusbox.com>",
     "Vijay Kumar Guthi <vijaya.guthi@modusbox.com>"
   ],
-  "packageManager": "yarn@4.10.2",
+  "packageManager": "yarn@4.10.3",
   "engines": {
     "yarn": "3.2.0"
   },
@@ -85,8 +85,8 @@
     "@types/jest": "30.0.0",
     "@types/node": "24.7.0",
     "@types/node-cache": "4.2.5",
-    "@typescript-eslint/eslint-plugin": "8.45.0",
-    "@typescript-eslint/parser": "8.45.0",
+    "@typescript-eslint/eslint-plugin": "8.46.0",
+    "@typescript-eslint/parser": "8.46.0",
     "audit-ci": "7.1.0",
     "eslint": "9.15.0",
     "eslint-config-airbnb-typescript": "18.0.0",