@mojaloop/sdk-scheme-adapter 24.11.0-snapshot.5 → 24.12.0-snapshot.0

package/.yarnrc.yml

@@ -4,4 +4,4 @@ enableGlobalCache: false
 
 nodeLinker: node-modules
 
-yarnPath: .yarn/releases/yarn-4.9.4.cjs
+yarnPath: .yarn/releases/yarn-4.10.1.cjs

package/CHANGELOG.md

@@ -1,4 +1,16 @@
 # Changelog: [mojaloop/sdk-scheme-adapter](https://github.com/mojaloop/sdk-scheme-adapter)
+## [24.11.0](https://github.com/mojaloop/sdk-scheme-adapter/compare/v24.10.11...v24.11.0) (2025-09-18)
+
+
+### Features
+
+* **csi-1807:** improve transfer status delivery effort ([#614](https://github.com/mojaloop/sdk-scheme-adapter/issues/614)) ([65c9d1a](https://github.com/mojaloop/sdk-scheme-adapter/commit/65c9d1a5835af0e35b1c0bbe06990f7e26bc4b35))
+
+
+### Chore
+
+* **sbom:** update sbom [skip ci] ([bdb946f](https://github.com/mojaloop/sdk-scheme-adapter/commit/bdb946f94d330b8f1d0f7f2a13b8962c4b410b11))
+
 ### [24.10.11](https://github.com/mojaloop/sdk-scheme-adapter/compare/v24.10.10...v24.10.11) (2025-09-15)
 
 

package/docker/ml-testing-toolkit/spec_files/user_config.json

@@ -55,7 +55,7 @@
     "TEST_CASES_REPO_OWNER": "mojaloop",
     "TEST_CASES_REPO_NAME": "testing-toolkit-test-cases",
     "TEST_CASES_REPO_DEFAULT_RELEASE_TAG": "latest",
-    "TEST_CASES_REPO_BASE_PATH": "collections/dfsp",
+    "TEST_CASES_REPO_BASE_PATH": "collections/pm4ml",
     "TEST_CASES_REPO_HUB_GP_PATH": "collections/hub/golden_path",
     "TEST_CASES_REPO_HUB_PROVISIONING_PATH": "collections/hub/provisioning"
   },

package/modules/api-svc/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter-api-svc",
-  "version": "21.0.0-snapshot.63",
+  "version": "21.0.0-snapshot.64",
   "description": "An adapter for connecting to Mojaloop API enabled switches.",
   "main": "src/index.js",
   "types": "src/index.d.ts",

package/modules/api-svc/src/OutboundServer/handlers.js

@@ -130,6 +130,7 @@ const createOutboundTransfersModel = (ctx) => new OutboundTransfersModel({
     logger: ctx.state.logger,
     wso2: ctx.state.wso2,
     metricsClient: ctx.state.metricsClient,
+    sharedAgents: ctx.state.sharedAgents,
 });
 
 const createOutboundBulkTransfersModel = (ctx) => new OutboundBulkTransfersModel({
@@ -466,6 +467,7 @@ const postAccounts = async (ctx) => {
             cache: ctx.state.cache,
             logger: ctx.state.logger,
             wso2: ctx.state.wso2,
+            sharedAgents: ctx.state.sharedAgents,
         });
 
         const state = {
@@ -496,6 +498,7 @@ const deleteAccountByTypeAndId = async (ctx) => {
             cache: ctx.state.cache,
             logger: ctx.state.logger,
             wso2: ctx.state.wso2,
+            sharedAgents: ctx.state.sharedAgents,
         });
 
         const args = {

package/modules/api-svc/src/OutboundServer/index.js

@@ -25,6 +25,7 @@
  --------------
  ******/
 const http = require('http');
+const https = require('https');
 
 const Koa = require('koa');
 const koaBody = require('koa-body').default;
@@ -51,7 +52,7 @@ const _validator = new Validate({ logExcludePaths });
 let _initialize;
 
 class OutboundApi extends EventEmitter {
-    constructor(conf, logger, cache, validator, metricsClient, wso2, eventProducer, eventLogger) {
+    constructor(conf, logger, cache, validator, metricsClient, wso2, eventProducer, eventLogger, sharedAgents) {
         super({ captureExceptions: true });
         this._logger = logger.push({ component: this.constructor.name });
         this._api = new Koa();
@@ -72,7 +73,8 @@ class OutboundApi extends EventEmitter {
             metricsClient,
             logExcludePaths,
             eventProducer,
-            eventLogger
+            eventLogger,
+            sharedAgents
         }));
         this._api.use(middlewares.createLogger(this._logger));
 
@@ -110,6 +112,27 @@ class OutboundServer extends EventEmitter {
         this._conf = conf;
         this._logger = logger.push({ app: this.constructor.name });
         this._server = null;
+
+        // Create shared HTTP and HTTPS agents to prevent agent recreation per request
+        this._httpAgent = new http.Agent({
+            keepAlive: true,
+            maxSockets: conf.outbound.maxSockets || 256,
+        });
+
+        // Create HTTPS agent based on TLS configuration
+        const httpsAgentOptions = {
+            keepAlive: true,
+            maxSockets: conf.outbound.maxSockets || 256,
+        };
+
+        // Apply TLS configuration if mTLS is enabled
+        if (conf.outbound.tls.mutualTLS.enabled && conf.outbound.tls.creds) {
+            Object.assign(httpsAgentOptions, conf.outbound.tls.creds);
+        }
+
+        this._httpsAgent = new https.Agent(httpsAgentOptions);
+
+        this._logger.isInfoEnabled && this._logger.info('Created shared HTTP and HTTPS agents with keepAlive enabled');
         if (conf.backendEventHandler.enabled) {
             this._eventLogger = new DefaultLogger(BC_CONFIG.bcName, 'backend-api-handler', '0.0.1', conf.logLevel);
             this._eventProducer = new KafkaDomainEventProducer(conf.backendEventHandler.domainEventProducer, this._eventLogger);
@@ -124,6 +147,10 @@ class OutboundServer extends EventEmitter {
             wso2,
             this._eventProducer,
             this._eventLogger,
+            {
+                httpAgent: this._httpAgent,
+                httpsAgent: this._httpsAgent
+            }
         );
         this._api.on('error', (...args) => {
             this.emit('error', ...args);

package/modules/api-svc/src/lib/model/AccountsModel.js

@@ -48,8 +48,9 @@ class AccountsModel {
         this._logger = config.logger;
         this._requestProcessingTimeoutSeconds = config.requestProcessingTimeoutSeconds;
         this._dfspId = config.dfspId;
+        this._sharedAgents = config.sharedAgents;
 
-        this._requests = new MojaloopRequests({
+        const mojaloopRequestsConfig = {
             logger: this._logger,
             peerEndpoint: config.alsEndpoint,
             dfspId: config.dfspId,
@@ -62,7 +63,16 @@ class AccountsModel {
             wso2: config.wso2,
             resourceVersions: config.resourceVersions,
             apiType: config.apiType
-        });
+        };
+
+        // Add shared agents to prevent HTTPS agent recreation per request
+        if (this._sharedAgents) {
+            mojaloopRequestsConfig.httpAgent = this._sharedAgents.httpAgent;
+            mojaloopRequestsConfig.httpsAgent = this._sharedAgents.httpsAgent;
+            this._logger.isDebugEnabled && this._logger.debug('Using shared HTTP/HTTPS agents for AccountsModel MojaloopRequests');
+        }
+
+        this._requests = new MojaloopRequests(mojaloopRequestsConfig);
     }
 
 

package/modules/api-svc/src/lib/model/OutboundTransfersModel.js

@@ -71,6 +71,7 @@ class OutboundTransfersModel {
         this._useQuoteSourceFSPAsTransferPayeeFSP = config.useQuoteSourceFSPAsTransferPayeeFSP;
         this._checkIlp = config.checkIlp;
         this._multiplePartiesResponse = config.multiplePartiesResponse;
+        this._sharedAgents = config.sharedAgents;
         this._multiplePartiesResponseSeconds = config.multiplePartiesResponseSeconds;
         this._sendFinalNotificationIfRequested = config.sendFinalNotificationIfRequested;
         this._apiType = config.apiType;
@@ -82,7 +83,7 @@ class OutboundTransfersModel {
 
         this._cacheTtl = config.redisCacheTtl;
 
-        this._requests = new MojaloopRequests({
+        const mojaloopRequestsConfig = {
             logger: this._logger,
             peerEndpoint: config.peerEndpoint,
             alsEndpoint: config.alsEndpoint,
@@ -102,7 +103,16 @@ class OutboundTransfersModel {
             wso2: config.wso2,
             resourceVersions: config.resourceVersions,
             apiType: config.apiType,
-        });
+        };
+
+        // Add shared agents to prevent HTTPS agent recreation per request
+        if (this._sharedAgents) {
+            mojaloopRequestsConfig.httpAgent = this._sharedAgents.httpAgent;
+            mojaloopRequestsConfig.httpsAgent = this._sharedAgents.httpsAgent;
+            this._logger.isDebugEnabled && this._logger.debug('Using shared HTTP/HTTPS agents for MojaloopRequests');
+        }
+
+        this._requests = new MojaloopRequests(mojaloopRequestsConfig);
 
         // default to ILP 1 unless v4 is set
         const ilpVersion = config.ilpVersion === '4' ? Ilp.ILP_VERSIONS.v4 : Ilp.ILP_VERSIONS.v1;

package/modules/api-svc/test/unit/inboundApi/handlers-iso20022.test.js

@@ -325,7 +325,6 @@ describe('Inbound API handlers transforming incoming ISO20022 message bodies', (
             expect(transferRequestSpy.mock.calls[0][0]).not.toEqual(isoBodies.patchTransfersRequest);
             expect(transferRequestSpy.mock.calls[0][0].transferState).toBe('COMMITTED');
             expect(mockContext.response.status).toBe(200);
-            console.log('Response body:', mockContext.response);
         });
     });
 

package/modules/api-svc/test/unit/lib/model/InboundTransfersModel.test.js

@@ -1036,7 +1036,7 @@ describe('inboundModel', () => {
         });
 
         test('does not retry notification to fsp backend if disabled', async () => {
-            const mockFn = jest.fn().mockResolvedValue({ status: 200 });
+            const mockFn = jest.fn().mockRejectedValue(new Error('fail'));
             BackendRequests.__putTransfersNotification = mockFn;
 
             const notif = JSON.parse(JSON.stringify(notificationToPayee));
@@ -1202,68 +1202,6 @@ describe('inboundModel', () => {
             await expect(model.sendNotificationToPayee(notif.data, 'some-transfer-id')).resolves.toBeUndefined();
         });
 
-        test('retries notification to backend on failure for sendFxPutNotificationToBackend if enabled', async () => {
-            // Simulate failure for first 2 attempts, then success
-            const mockFn = jest.fn()
-            .mockRejectedValueOnce(new Error('fail1'))
-            .mockRejectedValueOnce(new Error('fail2'))
-            .mockResolvedValue({ status: 200 });
-            BackendRequests.__putFxTransfersNotification = mockFn;
-
-            const notif = JSON.parse(JSON.stringify(fxNotificationToBackend));
-            const model = new Model({
-            ...config,
-            cache,
-            logger,
-            backendRequestRetry: {
-                enabled: true,
-                maxRetries: 3,
-                retryDelayMs: 10,
-                maxRetryDelayMs: 20,
-                backoffFactor: 1
-            }
-            });
-            model.saveFxState = jest.fn().mockReturnValue(Promise.resolve({}));
-
-            await model.sendFxPutNotificationToBackend(notif.data, conversionId);
-            expect(BackendRequests.__putFxTransfersNotification).toHaveBeenCalledTimes(3);
-        });
-
-        test('does not retry notification to backend for sendFxPutNotificationToBackend if disabled', async () => {
-            const mockFn = jest.fn().mockResolvedValue({ status: 200 });
-            BackendRequests.__putFxTransfersNotification = mockFn;
-
-            const notif = JSON.parse(JSON.stringify(fxNotificationToBackend));
-            const model = new Model({
-            ...config,
-            cache,
-            logger,
-            backendRequestRetry: {
-                enabled: false
-            }
-            });
-            model.saveFxState = jest.fn().mockReturnValue(Promise.resolve({}));
-
-            await model.sendFxPutNotificationToBackend(notif.data, conversionId);
-            expect(BackendRequests.__putFxTransfersNotification).toHaveBeenCalledTimes(1);
-        });
-
-        test('sendFxPutNotificationToBackend handles error and still saves state', async () => {
-            BackendRequests.__putFxTransfersNotification = jest.fn().mockRejectedValue(new Error('fail'));
-            const notif = JSON.parse(JSON.stringify(fxNotificationToBackend));
-            const model = new Model({
-            ...config,
-            cache,
-            logger,
-            backendRequestRetry: {
-                enabled: false
-            }
-            });
-            const saveFxStateSpy = jest.spyOn(model, 'saveFxState').mockResolvedValue({});
-            await expect(model.sendFxPutNotificationToBackend(notif.data, conversionId)).resolves.toBeUndefined();
-            expect(saveFxStateSpy).toHaveBeenCalled();
-        });
-
         test('sendNotificationToPayee handles error and still returns', async () => {
             BackendRequests.__putTransfersNotification = jest.fn().mockRejectedValue(new Error('fail'));
             const notif = JSON.parse(JSON.stringify(notificationToPayee));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter",
-  "version": "24.11.0-snapshot.5",
+  "version": "24.12.0-snapshot.0",
   "description": "mojaloop sdk-scheme-adapter",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/sdk-scheme-adapter",
@@ -18,7 +18,7 @@
     "Yevhen Kyriukha <yevhen.kyriukha@modusbox.com>",
     "Vijay Kumar Guthi <vijaya.guthi@modusbox.com>"
   ],
-  "packageManager": "yarn@4.9.4",
+  "packageManager": "yarn@4.10.1",
   "engines": {
     "yarn": "3.2.0"
   },