@mojaloop/sdk-scheme-adapter 24.11.0-snapshot.4 → 24.11.0

package/CHANGELOG.md

@@ -1,4 +1,16 @@
 # Changelog: [mojaloop/sdk-scheme-adapter](https://github.com/mojaloop/sdk-scheme-adapter)
+## [24.11.0](https://github.com/mojaloop/sdk-scheme-adapter/compare/v24.10.11...v24.11.0) (2025-09-18)
+
+
+### Features
+
+* **csi-1807:** improve transfer status delivery effort ([#614](https://github.com/mojaloop/sdk-scheme-adapter/issues/614)) ([65c9d1a](https://github.com/mojaloop/sdk-scheme-adapter/commit/65c9d1a5835af0e35b1c0bbe06990f7e26bc4b35))
+
+
+### Chore
+
+* **sbom:** update sbom [skip ci] ([bdb946f](https://github.com/mojaloop/sdk-scheme-adapter/commit/bdb946f94d330b8f1d0f7f2a13b8962c4b410b11))
+
 ### [24.10.11](https://github.com/mojaloop/sdk-scheme-adapter/compare/v24.10.10...v24.10.11) (2025-09-15)
 
 

package/modules/api-svc/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter-api-svc",
-  "version": "21.0.0-snapshot.62",
+  "version": "21.0.0-snapshot.63",
   "description": "An adapter for connecting to Mojaloop API enabled switches.",
   "main": "src/index.js",
   "types": "src/index.d.ts",
@@ -66,7 +66,7 @@
     "@koa/cors": "5.0.0",
     "@mojaloop/api-snippets": "18.1.1",
     "@mojaloop/central-services-error-handling": "13.1.2",
-    "@mojaloop/central-services-logger": "11.9.3",
+    "@mojaloop/central-services-logger": "11.10.0",
     "@mojaloop/central-services-metrics": "12.7.1",
     "@mojaloop/central-services-shared": "18.33.2",
     "@mojaloop/event-sdk": "14.7.0",

package/modules/api-svc/src/lib/model/InboundTransfersModel.js

@@ -530,6 +530,7 @@ class InboundTransfersModel {
                                         // Mark as notified to prevent duplicate notification
                                         await this._cache.set(cacheKey, true, 60);
                                         // Send notification to payee
+                                        this._logger.isInfoEnabled && this._logger.push({ transferId }).info('Received transfer callback for GET /transfers/{ID} request, sending notification to payee');
                                         await this.sendNotificationToPayee(message.data.body, transferId);
                                         break;
                                     }
@@ -1056,14 +1057,17 @@ class InboundTransfersModel {
                 await new Promise((resolve) => {
                     operation.attempt(async (currentAttempt) => {
                         try {
+                            log.verbose(`putFxTransfersNotification attempt ${currentAttempt} for conversionId ${conversionId}`);
                             res = await this._backendRequests.putFxTransfersNotification(responseBody, conversionId);
                             // Consider success as long as it doesn't throw
                             // `sendRequest` only seems to return `data` of the request which could
                             // be empty for a 200 response
-                            return resolve();
+                            log.verbose(`putFxTransfersNotification attempt ${currentAttempt} succeeded for conversionId ${conversionId}`);
+                            resolve();
                         } catch (err) {
                             log.warn(`putFxTransfersNotification attempt ${currentAttempt} threw error, retrying...`, err);
                             if (!operation.retry(err)) {
+                                log.verbose(`putFxTransfersNotification giving up after ${currentAttempt} attempts`);
                                 resolve();
                             }
                         }
@@ -1071,6 +1075,7 @@ class InboundTransfersModel {
                 });
             } else {
                 try {
+                    log.verbose(`putFxTransfersNotification no-retry mode for conversionId ${conversionId}`);
                     res = await this._backendRequests.putFxTransfersNotification(responseBody, conversionId);
                 } catch (err) {
                     log.error('putFxTransfersNotification failed', err);
@@ -1085,6 +1090,7 @@ class InboundTransfersModel {
     * Forwards Switch notification for fulfiled transfer to the DFSP backend, when acting as a payee
     */
     async sendNotificationToPayee(body, transferId) {
+        const log = this._logger.child({ transferId });
         try {
             // load any cached state for this transfer e.g. quote request/response etc...
             this.data = await this._load(transferId);
@@ -1133,16 +1139,19 @@ class InboundTransfersModel {
                 await new Promise((resolve) => {
                     operation.attempt(async (currentAttempt) => {
                         try {
+                            log.verbose(`putTransfersNotification attempt ${currentAttempt} for transferId ${transferId}`);
                             res = await this._backendRequests.putTransfersNotification(this.data, transferId);
                             // Consider success as long as it doesn't throw
                             // `sendRequest` only seems to return `data` of the request which could
                             // be empty for a 200 response
                             const cacheKey = `patchNotificationSent_${transferId}`;
                             await this._cache.set(cacheKey, true, 60);
-                            return resolve();
+                            log.verbose(`putTransfersNotification attempt ${currentAttempt} succeeded for transferId ${transferId}`);
+                            resolve();
                         } catch (err) {
                             this._logger.warn(`putTransfersNotification attempt ${currentAttempt} threw error, retrying...`, err);
                             if (!operation.retry(err)) {
+                                log.verbose(`putTransfersNotification giving up after ${currentAttempt} attempts`);
                                 resolve();
                             }
                         }
@@ -1150,6 +1159,7 @@ class InboundTransfersModel {
                 });
             } else {
                 try {
+                    log.verbose(`putTransfersNotification no-retry mode for transferId ${transferId}`);
                     res = await this._backendRequests.putTransfersNotification(this.data, transferId);
                     const cacheKey = `patchNotificationSent_${transferId}`;
                     await this._cache.set(cacheKey, true, 60);

package/modules/api-svc/test/unit/inboundApi/handlers-iso20022.test.js

@@ -325,7 +325,6 @@ describe('Inbound API handlers transforming incoming ISO20022 message bodies', (
             expect(transferRequestSpy.mock.calls[0][0]).not.toEqual(isoBodies.patchTransfersRequest);
             expect(transferRequestSpy.mock.calls[0][0].transferState).toBe('COMMITTED');
             expect(mockContext.response.status).toBe(200);
-            console.log('Response body:', mockContext.response);
         });
     });
 

package/modules/api-svc/test/unit/lib/model/InboundTransfersModel.test.js

@@ -1036,7 +1036,7 @@ describe('inboundModel', () => {
         });
 
         test('does not retry notification to fsp backend if disabled', async () => {
-            const mockFn = jest.fn().mockResolvedValue({ status: 200 });
+            const mockFn = jest.fn().mockRejectedValue(new Error('fail'));
             BackendRequests.__putTransfersNotification = mockFn;
 
             const notif = JSON.parse(JSON.stringify(notificationToPayee));
@@ -1202,68 +1202,6 @@ describe('inboundModel', () => {
             await expect(model.sendNotificationToPayee(notif.data, 'some-transfer-id')).resolves.toBeUndefined();
         });
 
-        test('retries notification to backend on failure for sendFxPutNotificationToBackend if enabled', async () => {
-            // Simulate failure for first 2 attempts, then success
-            const mockFn = jest.fn()
-            .mockRejectedValueOnce(new Error('fail1'))
-            .mockRejectedValueOnce(new Error('fail2'))
-            .mockResolvedValue({ status: 200 });
-            BackendRequests.__putFxTransfersNotification = mockFn;
-
-            const notif = JSON.parse(JSON.stringify(fxNotificationToBackend));
-            const model = new Model({
-            ...config,
-            cache,
-            logger,
-            backendRequestRetry: {
-                enabled: true,
-                maxRetries: 3,
-                retryDelayMs: 10,
-                maxRetryDelayMs: 20,
-                backoffFactor: 1
-            }
-            });
-            model.saveFxState = jest.fn().mockReturnValue(Promise.resolve({}));
-
-            await model.sendFxPutNotificationToBackend(notif.data, conversionId);
-            expect(BackendRequests.__putFxTransfersNotification).toHaveBeenCalledTimes(3);
-        });
-
-        test('does not retry notification to backend for sendFxPutNotificationToBackend if disabled', async () => {
-            const mockFn = jest.fn().mockResolvedValue({ status: 200 });
-            BackendRequests.__putFxTransfersNotification = mockFn;
-
-            const notif = JSON.parse(JSON.stringify(fxNotificationToBackend));
-            const model = new Model({
-            ...config,
-            cache,
-            logger,
-            backendRequestRetry: {
-                enabled: false
-            }
-            });
-            model.saveFxState = jest.fn().mockReturnValue(Promise.resolve({}));
-
-            await model.sendFxPutNotificationToBackend(notif.data, conversionId);
-            expect(BackendRequests.__putFxTransfersNotification).toHaveBeenCalledTimes(1);
-        });
-
-        test('sendFxPutNotificationToBackend handles error and still saves state', async () => {
-            BackendRequests.__putFxTransfersNotification = jest.fn().mockRejectedValue(new Error('fail'));
-            const notif = JSON.parse(JSON.stringify(fxNotificationToBackend));
-            const model = new Model({
-            ...config,
-            cache,
-            logger,
-            backendRequestRetry: {
-                enabled: false
-            }
-            });
-            const saveFxStateSpy = jest.spyOn(model, 'saveFxState').mockResolvedValue({});
-            await expect(model.sendFxPutNotificationToBackend(notif.data, conversionId)).resolves.toBeUndefined();
-            expect(saveFxStateSpy).toHaveBeenCalled();
-        });
-
         test('sendNotificationToPayee handles error and still returns', async () => {
             BackendRequests.__putTransfersNotification = jest.fn().mockRejectedValue(new Error('fail'));
             const notif = JSON.parse(JSON.stringify(notificationToPayee));

package/modules/outbound-command-event-handler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter-outbound-command-event-handler",
-  "version": "0.3.0-snapshot.58",
+  "version": "0.3.0-snapshot.59",
   "description": "Mojaloop sdk scheme adapter command event handler",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/sdk-scheme-adapter/",
@@ -60,7 +60,7 @@
     "@types/convict": "6.1.6",
     "@types/express": "5.0.3",
     "@types/jest": "30.0.0",
-    "@types/node": "24.5.1",
+    "@types/node": "24.5.2",
     "@types/node-cache": "4.2.5",
     "@types/supertest": "6.0.3",
     "@types/swagger-ui-express": "4.1.8",
@@ -74,7 +74,7 @@
     "npm-check-updates": "16.7.10",
     "replace": "1.2.2",
     "standard-version": "9.5.0",
-    "ts-jest": "29.4.2",
+    "ts-jest": "29.4.3",
     "ts-node": "10.9.2",
     "typescript": "5.9.2"
   },

package/modules/outbound-domain-event-handler/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@mojaloop/sdk-scheme-adapter-outbound-domain-event-handler",
-    "version": "0.3.0-snapshot.58",
+    "version": "0.3.0-snapshot.59",
     "description": "mojaloop sdk scheme adapter outbound domain event handler",
     "license": "Apache-2.0",
     "homepage": "https://github.com/mojaloop/sdk-scheme-adapter/",
@@ -57,7 +57,7 @@
         "@types/convict": "6.1.6",
         "@types/express": "5.0.3",
         "@types/jest": "30.0.0",
-        "@types/node": "24.5.1",
+        "@types/node": "24.5.2",
         "@types/node-cache": "4.2.5",
         "@types/supertest": "6.0.3",
         "@types/swagger-ui-express": "4.1.8",
@@ -71,7 +71,7 @@
         "npm-check-updates": "16.7.10",
         "replace": "1.2.2",
         "standard-version": "9.5.0",
-        "ts-jest": "29.4.2",
+        "ts-jest": "29.4.3",
         "ts-node": "10.9.2",
         "typescript": "5.9.2"
     },

package/modules/private-shared-lib/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter-private-shared-lib",
-  "version": "0.4.0-snapshot.58",
+  "version": "0.4.0-snapshot.59",
   "description": "SDK Scheme Adapter private shared library.",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/accounts-and-balances-bc/tree/main/modules/private-types",
@@ -40,7 +40,7 @@
   },
   "devDependencies": {
     "@eslint/compat": "1.3.2",
-    "@types/node": "24.5.1",
+    "@types/node": "24.5.2",
     "@types/uuid": "10.0.0",
     "@typescript-eslint/eslint-plugin": "8.44.0",
     "@typescript-eslint/parser": "8.44.0",
@@ -49,7 +49,7 @@
     "npm-check-updates": "16.7.10",
     "replace": "1.2.2",
     "standard-version": "9.5.0",
-    "ts-jest": "29.4.2",
+    "ts-jest": "29.4.3",
     "tslib": "2.8.1",
     "typescript": "5.9.2"
   },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter",
-  "version": "24.11.0-snapshot.4",
+  "version": "24.11.0",
   "description": "mojaloop sdk-scheme-adapter",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/sdk-scheme-adapter",
@@ -82,7 +82,7 @@
   },
   "devDependencies": {
     "@types/jest": "30.0.0",
-    "@types/node": "24.5.1",
+    "@types/node": "24.5.2",
     "@types/node-cache": "4.2.5",
     "@typescript-eslint/eslint-plugin": "8.44.0",
     "@typescript-eslint/parser": "8.44.0",
@@ -97,7 +97,7 @@
     "npm-check-updates": "16.7.10",
     "replace": "1.2.2",
     "standard-version": "9.5.0",
-    "ts-jest": "29.4.2",
+    "ts-jest": "29.4.3",
     "ts-node": "10.9.2",
     "typescript": "5.9.2",
     "yarn-audit-fix": "10.1.1"