@mojaloop/sdk-scheme-adapter 24.11.0-snapshot.2 → 24.11.0-snapshot.5

package/modules/api-svc/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter-api-svc",
-  "version": "21.0.0-snapshot.60",
+  "version": "21.0.0-snapshot.63",
   "description": "An adapter for connecting to Mojaloop API enabled switches.",
   "main": "src/index.js",
   "types": "src/index.d.ts",
@@ -66,9 +66,9 @@
     "@koa/cors": "5.0.0",
     "@mojaloop/api-snippets": "18.1.1",
     "@mojaloop/central-services-error-handling": "13.1.2",
-    "@mojaloop/central-services-logger": "11.9.3",
+    "@mojaloop/central-services-logger": "11.10.0",
     "@mojaloop/central-services-metrics": "12.7.1",
-    "@mojaloop/central-services-shared": "18.33.0",
+    "@mojaloop/central-services-shared": "18.33.2",
     "@mojaloop/event-sdk": "14.7.0",
     "@mojaloop/logging-bc-client-lib": "0.5.8",
     "@mojaloop/ml-schema-transformer-lib": "2.7.8",

package/modules/api-svc/src/lib/model/InboundTransfersModel.js

@@ -530,6 +530,7 @@ class InboundTransfersModel {
                                         // Mark as notified to prevent duplicate notification
                                         await this._cache.set(cacheKey, true, 60);
                                         // Send notification to payee
+                                        this._logger.isInfoEnabled && this._logger.push({ transferId }).info('Received transfer callback for GET /transfers/{ID} request, sending notification to payee');
                                         await this.sendNotificationToPayee(message.data.body, transferId);
                                         break;
                                     }
@@ -1042,8 +1043,8 @@ class InboundTransfersModel {
             log.verbose('sendFxPutNotificationToBackend body sent to cc: ', { responseBody });
 
             const { enabled, maxRetries, retryDelayMs, maxRetryDelayMs, backoffFactor } = this._backendRequestRetry || {};
-            let res;
             const shouldRetry = enabled !== false; // default to true if not set
+            let res;
 
             if (shouldRetry) {
                 const operation = retry.operation({
@@ -1056,30 +1057,28 @@ class InboundTransfersModel {
                 await new Promise((resolve) => {
                     operation.attempt(async (currentAttempt) => {
                         try {
+                            log.verbose(`putFxTransfersNotification attempt ${currentAttempt} for conversionId ${conversionId}`);
                             res = await this._backendRequests.putFxTransfersNotification(responseBody, conversionId);
-                            if (res) {
-                                return resolve();
-                            }
-                            log.warn(`putFxTransfersNotification attempt ${currentAttempt} got no response, retrying...`);
-                            if (!operation.retry(new Error('No response'))) {
-                                resolve();
-                            }
+                            // Consider success as long as it doesn't throw
+                            // `sendRequest` only seems to return `data` of the request which could
+                            // be empty for a 200 response
+                            log.verbose(`putFxTransfersNotification attempt ${currentAttempt} succeeded for conversionId ${conversionId}`);
+                            resolve();
                         } catch (err) {
                             log.warn(`putFxTransfersNotification attempt ${currentAttempt} threw error, retrying...`, err);
                             if (!operation.retry(err)) {
+                                log.verbose(`putFxTransfersNotification giving up after ${currentAttempt} attempts`);
                                 resolve();
                             }
                         }
                     });
                 });
-
-                if (!res) {
-                    log.error(`putFxTransfersNotification failed after ${operation.attempts()} attempts`);
-                }
             } else {
-                res = await this._backendRequests.putFxTransfersNotification(responseBody, conversionId);
-                if (!res) {
-                    log.error('putFxTransfersNotification failed');
+                try {
+                    log.verbose(`putFxTransfersNotification no-retry mode for conversionId ${conversionId}`);
+                    res = await this._backendRequests.putFxTransfersNotification(responseBody, conversionId);
+                } catch (err) {
+                    log.error('putFxTransfersNotification failed', err);
                 }
             }
             return res;
@@ -1091,6 +1090,7 @@ class InboundTransfersModel {
     * Forwards Switch notification for fulfiled transfer to the DFSP backend, when acting as a payee
     */
     async sendNotificationToPayee(body, transferId) {
+        const log = this._logger.child({ transferId });
         try {
             // load any cached state for this transfer e.g. quote request/response etc...
             this.data = await this._load(transferId);
@@ -1139,32 +1139,32 @@ class InboundTransfersModel {
                 await new Promise((resolve) => {
                     operation.attempt(async (currentAttempt) => {
                         try {
+                            log.verbose(`putTransfersNotification attempt ${currentAttempt} for transferId ${transferId}`);
                             res = await this._backendRequests.putTransfersNotification(this.data, transferId);
-                            if (res) {
-                                const cacheKey = `patchNotificationSent_${transferId}`;
-                                await this._cache.set(cacheKey, true, 60);
-                                return resolve();
-                            }
-                            this._logger.warn(`putTransfersNotification attempt ${currentAttempt} got no response, retrying...`);
-                            if (!operation.retry(new Error('No response'))) {
-                                resolve();
-                            }
+                            // Consider success as long as it doesn't throw
+                            // `sendRequest` only seems to return `data` of the request which could
+                            // be empty for a 200 response
+                            const cacheKey = `patchNotificationSent_${transferId}`;
+                            await this._cache.set(cacheKey, true, 60);
+                            log.verbose(`putTransfersNotification attempt ${currentAttempt} succeeded for transferId ${transferId}`);
+                            resolve();
                         } catch (err) {
                             this._logger.warn(`putTransfersNotification attempt ${currentAttempt} threw error, retrying...`, err);
                             if (!operation.retry(err)) {
+                                log.verbose(`putTransfersNotification giving up after ${currentAttempt} attempts`);
                                 resolve();
                             }
                         }
                     });
                 });
-
-                if (!res) {
-                    this._logger.error(`putTransfersNotification failed after ${operation.attempts()} attempts`);
-                }
             } else {
-                res = await this._backendRequests.putTransfersNotification(this.data, transferId);
-                if (!res) {
-                    this._logger.error('putTransfersNotification failed');
+                try {
+                    log.verbose(`putTransfersNotification no-retry mode for transferId ${transferId}`);
+                    res = await this._backendRequests.putTransfersNotification(this.data, transferId);
+                    const cacheKey = `patchNotificationSent_${transferId}`;
+                    await this._cache.set(cacheKey, true, 60);
+                } catch (err) {
+                    this._logger.error('putTransfersNotification failed', err);
                 }
             }
             return res;

package/modules/outbound-command-event-handler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter-outbound-command-event-handler",
-  "version": "0.3.0-snapshot.56",
+  "version": "0.3.0-snapshot.59",
   "description": "Mojaloop sdk scheme adapter command event handler",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/sdk-scheme-adapter/",
@@ -42,7 +42,7 @@
   },
   "dependencies": {
     "@mojaloop/api-snippets": "18.1.1",
-    "@mojaloop/central-services-shared": "18.33.0",
+    "@mojaloop/central-services-shared": "18.33.2",
     "@mojaloop/logging-bc-client-lib": "0.5.8",
     "@mojaloop/logging-bc-public-types-lib": "0.5.6",
     "@mojaloop/sdk-scheme-adapter-private-shared-lib": "workspace:^",
@@ -60,7 +60,7 @@
     "@types/convict": "6.1.6",
     "@types/express": "5.0.3",
     "@types/jest": "30.0.0",
-    "@types/node": "24.5.1",
+    "@types/node": "24.5.2",
     "@types/node-cache": "4.2.5",
     "@types/supertest": "6.0.3",
     "@types/swagger-ui-express": "4.1.8",
@@ -74,7 +74,7 @@
     "npm-check-updates": "16.7.10",
     "replace": "1.2.2",
     "standard-version": "9.5.0",
-    "ts-jest": "29.4.2",
+    "ts-jest": "29.4.3",
     "ts-node": "10.9.2",
     "typescript": "5.9.2"
   },

package/modules/outbound-domain-event-handler/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@mojaloop/sdk-scheme-adapter-outbound-domain-event-handler",
-    "version": "0.3.0-snapshot.56",
+    "version": "0.3.0-snapshot.59",
     "description": "mojaloop sdk scheme adapter outbound domain event handler",
     "license": "Apache-2.0",
     "homepage": "https://github.com/mojaloop/sdk-scheme-adapter/",
@@ -57,7 +57,7 @@
         "@types/convict": "6.1.6",
         "@types/express": "5.0.3",
         "@types/jest": "30.0.0",
-        "@types/node": "24.5.1",
+        "@types/node": "24.5.2",
         "@types/node-cache": "4.2.5",
         "@types/supertest": "6.0.3",
         "@types/swagger-ui-express": "4.1.8",
@@ -71,7 +71,7 @@
         "npm-check-updates": "16.7.10",
         "replace": "1.2.2",
         "standard-version": "9.5.0",
-        "ts-jest": "29.4.2",
+        "ts-jest": "29.4.3",
         "ts-node": "10.9.2",
         "typescript": "5.9.2"
     },

package/modules/private-shared-lib/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter-private-shared-lib",
-  "version": "0.4.0-snapshot.56",
+  "version": "0.4.0-snapshot.59",
   "description": "SDK Scheme Adapter private shared library.",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/accounts-and-balances-bc/tree/main/modules/private-types",
@@ -30,7 +30,7 @@
   },
   "dependencies": {
     "@mojaloop/api-snippets": "18.1.1",
-    "@mojaloop/central-services-shared": "18.33.0",
+    "@mojaloop/central-services-shared": "18.33.2",
     "@mojaloop/logging-bc-public-types-lib": "0.5.6",
     "@mojaloop/platform-shared-lib-messaging-types-lib": "0.7.3",
     "@mojaloop/platform-shared-lib-nodejs-kafka-client-lib": "0.5.18",
@@ -40,7 +40,7 @@
   },
   "devDependencies": {
     "@eslint/compat": "1.3.2",
-    "@types/node": "24.5.1",
+    "@types/node": "24.5.2",
     "@types/uuid": "10.0.0",
     "@typescript-eslint/eslint-plugin": "8.44.0",
     "@typescript-eslint/parser": "8.44.0",
@@ -49,7 +49,7 @@
     "npm-check-updates": "16.7.10",
     "replace": "1.2.2",
     "standard-version": "9.5.0",
-    "ts-jest": "29.4.2",
+    "ts-jest": "29.4.3",
     "tslib": "2.8.1",
     "typescript": "5.9.2"
   },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/sdk-scheme-adapter",
-  "version": "24.11.0-snapshot.2",
+  "version": "24.11.0-snapshot.5",
   "description": "mojaloop sdk-scheme-adapter",
   "license": "Apache-2.0",
   "homepage": "https://github.com/mojaloop/sdk-scheme-adapter",
@@ -82,7 +82,7 @@
   },
   "devDependencies": {
     "@types/jest": "30.0.0",
-    "@types/node": "24.5.1",
+    "@types/node": "24.5.2",
     "@types/node-cache": "4.2.5",
     "@typescript-eslint/eslint-plugin": "8.44.0",
     "@typescript-eslint/parser": "8.44.0",
@@ -97,7 +97,7 @@
     "npm-check-updates": "16.7.10",
     "replace": "1.2.2",
     "standard-version": "9.5.0",
-    "ts-jest": "29.4.2",
+    "ts-jest": "29.4.3",
     "ts-node": "10.9.2",
     "typescript": "5.9.2",
     "yarn-audit-fix": "10.1.1"