@mojaloop/database-lib 11.1.3 → 11.1.4-snapshot.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/database-lib",
-  "version": "11.1.3",
+  "version": "11.1.4-snapshot.2",
   "description": "Shared database code for central services",
   "main": "src/index.js",
   "license": "Apache-2.0",
@@ -43,7 +43,8 @@
     "release": "standard-version --releaseCommitMessageFormat 'chore(release): {{currentTag}} [skip ci]'"
   },
   "dependencies": {
-    "@mojaloop/central-services-error-handling": "13.0.6",
+    "@mojaloop/central-services-error-handling": "13.0.7",
+    "async-exit-hook": "^2.0.1",
     "knex": "3.1.0",
     "lodash": "4.17.21",
     "mysql": "2.18.1"
@@ -70,9 +71,9 @@
     "yargs-parser": "21.1.1"
   },
   "devDependencies": {
-    "@mojaloop/sdk-standard-components": ">=19.x.x",
+    "@mojaloop/sdk-standard-components": "19.10.3",
     "audit-ci": "^7.1.0",
-    "npm-check-updates": "17.1.14",
+    "npm-check-updates": "17.1.15",
     "nyc": "17.1.0",
     "pre-commit": "1.2.2",
     "proxyquire": "2.1.3",

package/src/database.js

@@ -4,6 +4,7 @@ const Knex = require('knex')
 const ErrorHandler = require('@mojaloop/central-services-error-handling')
 const Table = require('./table')
 const Utils = require('./utils.js')
+const exitHook = require('async-exit-hook')
 
 /* Default config to fall back to when using deprecated URI connection string */
 const defaultConfig = {
@@ -78,6 +79,8 @@ class Database {
     this._knex = await configureKnex(config)
     this._tables = await this._listTables()
     await this._setTableProperties()
+
+    exitHook(() => this.disconnect())
   }
 
   async disconnect () {

package/test/unit/database.test.js

@@ -13,6 +13,7 @@ Test('database', databaseTest => {
   let knexConnStub
   let Database
   let dbInstance
+  let exitHookStub
 
   const connectionConfig = {
     client: 'mysql',
@@ -52,6 +53,8 @@ Test('database', databaseTest => {
   databaseTest.beforeEach(t => {
     sandbox = Sinon.createSandbox()
 
+    exitHookStub = sandbox.stub()
+
     knexConnStub = sandbox.stub()
     knexConnStub.destroy = sandbox.stub()
     knexConnStub.client = { config: { client: 'mysql' }, pool: { numPendingAcquires () {} } }
@@ -62,7 +65,7 @@ Test('database', databaseTest => {
 
     tableStub = sandbox.stub()
 
-    Database = Proxyquire(`${src}/database`, { knex: knexStub, './table': tableStub })
+    Database = Proxyquire(`${src}/database`, { knex: knexStub, './table': tableStub, 'async-exit-hook': exitHookStub })
     dbInstance = new Database()
 
     t.end()
@@ -382,5 +385,40 @@ Test('database', databaseTest => {
     getPendingAcquiresTest.end()
   })
 
+  databaseTest.test('connect should', connectTest => {
+    connectTest.test('register exit hook', async test => {
+      // Act
+      await dbInstance.connect(connectionConfig)
+
+      // Assert
+      test.ok(exitHookStub.calledOnce)
+      test.ok(exitHookStub.calledWith(Sinon.match.func))
+
+      // Cleanup
+      test.end()
+    })
+
+    connectTest.test('call disconnect on process exit', async test => {
+      // Arrange
+      // Simulate process exit by manually calling the registered function
+      await dbInstance.connect(connectionConfig)
+      const exitCallback = exitHookStub.firstCall.args[0] // Get the first function registered
+      const disconnectStub = sandbox.stub(dbInstance, 'disconnect').resolves()
+
+      // Act
+      exitCallback() // Simulate process exit
+
+      // Assert
+      test.ok(exitHookStub.calledOnce)
+      test.ok(disconnectStub.calledOnce)
+
+      // Cleanup
+      disconnectStub.restore()
+      test.end()
+    })
+
+    connectTest.end()
+  })
+
   databaseTest.end()
 })