@mojaloop/central-services-shared 15.3.0-snapshot.2 → 17.0.1

package/.circleci/config.yml

@@ -1,4 +1,4 @@
-# CircleCI v2.1 Config
+# CircleCI v2 Config
 version: 2.1
 
 ##
@@ -7,9 +7,9 @@ version: 2.1
 # Orbs used in this pipeline
 ##
 orbs:
-  slack: circleci/slack@3.4.2
-  github-release: h-matsuo/github-release@0.1.3
-  pr-tools: mojaloop/pr-tools@0.1.8
+  slack: circleci/slack@4.9.3 # Ref: https://github.com/mojaloop/ci-config/tree/master/slack-templates
+  pr-tools: mojaloop/pr-tools@0.1.10 # Ref: https://github.com/mojaloop/ci-config/
+  gh: circleci/github-cli@2.1.0
 
 ##
 # defaults
@@ -21,25 +21,24 @@ defaults_Dependencies: &defaults_Dependencies |
     apk --no-cache add ca-certificates
     apk --no-cache add curl
     apk --no-cache add openssh-client
-    apk --no-cache add bash
-    apk add --no-cache -t build-dependencies make gcc g++ python libtool autoconf automake jq
+    apk add --no-cache -t build-dependencies make gcc g++ python3 libtool autoconf automake jq
     npm config set unsafe-perm true
     npm install -g node-gyp
 
 defaults_awsCliDependencies: &defaults_awsCliDependencies |
-    apk upgrade --no-cache
-    apk --no-cache add \
-            python3 \
-            py3-pip \
-            groff \
-            less \
-            mailcap
-    pip3 install --upgrade pip awscli==1.14.5 s3cmd==2.0.1 python-magic
+    apk --no-cache add aws-cli
+
+defaults_license_scanner: &defaults_license_scanner
+  name: Install and set up license-scanner
+  command: |
+    git clone https://github.com/mojaloop/license-scanner /tmp/license-scanner
+    cd /tmp/license-scanner && make build default-files set-up
 
 defaults_npm_auth: &defaults_npm_auth
   name: Update NPM registry auth token
   command: echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" > .npmrc
 
+
 defaults_npm_publish_release: &defaults_npm_publish_release
   name: Publish NPM $RELEASE_TAG artifact
   command: |
@@ -47,18 +46,18 @@ defaults_npm_publish_release: &defaults_npm_publish_release
     echo "Publishing tag $RELEASE_TAG"
     npm publish --tag $RELEASE_TAG --access public
 
-defaults_npm_publish_version: &defaults_npm_publish
-  name: Update version to prerelease
+defaults_export_version_from_package: &defaults_export_version_from_package
+  name: Format the changelog into the github release body and get release tag
   command: |
-    source $BASH_ENV
-    echo "Publishing tag $CIRCLE_TAG"
-    npm publish --tag $CIRCLE_TAG --access public
+    git diff --no-indent-heuristic master~1 HEAD CHANGELOG.md | sed -n '/^+[^+]/ s/^+//p' > /tmp/changes
+    echo 'export RELEASE_CHANGES=`cat /tmp/changes`' >> $BASH_ENV
+    echo 'export RELEASE_TAG=`cat package-lock.json | jq -r .version`' >> $BASH_ENV
 
-defaults_license_scanner: &defaults_license_scanner
-  name: Install and set up license-scanner
+defaults_configure_git: &defaults_configure_git
+  name: Configure git
   command: |
-    git clone https://github.com/mojaloop/license-scanner /tmp/license-scanner
-    cd /tmp/license-scanner && make build default-files set-up
+    git config user.email ${GIT_CI_EMAIL}
+    git config user.name ${GIT_CI_USER}
 
 ##
 # Executors
@@ -67,19 +66,15 @@ defaults_license_scanner: &defaults_license_scanner
 ##
 executors:
   default-docker:
-    working_directory: /home/circleci/project
+    working_directory: &WORKING_DIR /home/circleci/project
     docker:
-      - image: node:12.16.1-alpine
+      - image: node:16.15.0-alpine
 
   default-machine:
+    working_directory: *WORKING_DIR
     machine:
-      image: ubuntu-1604:201903-01
+      image: ubuntu-2004:current
 
-##
-# Jobs
-#
-# A map of CircleCI jobs
-##
 jobs:
   setup:
     executor: default-docker
@@ -88,23 +83,40 @@ jobs:
           name: Install general dependencies
           command: *defaults_Dependencies
       - checkout
-      - restore_cache:
-          keys:
-            - dependency-cache-{{ checksum "package-lock.json" }}
-      - run:
-          name: Access npm folder as root
-          command: cd $(npm root -g)/npm
       - run:
           name: Update NPM install
           command: npm ci
-      - run:
-          name: Delete build dependencies
-          command: apk del build-dependencies
       - save_cache:
-          key: dependency-cache-{{ checksum "package-lock.json" }}
+          key: dependency-cache-{{ .Environment.CIRCLE_SHA1 }}
           paths:
             - node_modules
 
+  test-dependencies:
+    executor: default-docker
+    steps:
+      - run:
+          name: Install general dependencies
+          command: *defaults_Dependencies
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Environment.CIRCLE_SHA1 }}
+      - run:
+          name: Execute dependency tests
+          command: npm run dep:check
+
+  test-lint:
+    executor: default-docker
+    steps:
+      - run:
+          name: Install general dependencies
+          command: *defaults_Dependencies
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Environment.CIRCLE_SHA1 }}
+      - run:
+          name: Execute lint tests
+          command: npm run lint
+
   test-unit:
     executor: default-docker
     steps:
@@ -113,22 +125,23 @@ jobs:
           command: *defaults_Dependencies
       - checkout
       - restore_cache:
-          key: dependency-cache-{{ checksum "package-lock.json" }}
+          key: dependency-cache-{{ .Environment.CIRCLE_SHA1 }}
+      - run:
+          # This is needed for legacy core tests. Remove this once 'tape' is fully deprecated.
+          name: Install tape, tapes and tap-xunit
+          command: npm install tape tapes tap-xunit
       - run:
           name: Create dir for test results
           command: mkdir -p ./test/results
-      - run:
-          name: Install testing dependencies
-          command: npm install tape tapes tap-xunit
       - run:
           name: Execute unit tests
-          command: npm -s run test:xunit > ./test/results/tape.xml
+          command: npm -s run test:xunit
       - store_artifacts:
           path: ./test/results
           prefix: test
       - store_test_results:
           path: ./test/results
-  
+
   test-coverage:
     executor: default-docker
     steps:
@@ -140,10 +153,7 @@ jobs:
           command: *defaults_awsCliDependencies
       - checkout
       - restore_cache:
-          key: dependency-cache-{{ checksum "package-lock.json" }}
-      - run:
-          name: Install testing dependencies
-          command: npm install tape tapes tap-xunit
+          key: dependency-cache-{{ .Environment.CIRCLE_SHA1 }}
       - run:
           name: Execute code coverage check
           command: npm -s run test:coverage-check
@@ -151,14 +161,14 @@ jobs:
           path: coverage
           prefix: test
       - store_test_results:
-          path: coverage/lcov.info
+          path: coverage
       - run:
           name: Copy code coverage to SonarQube
           command: |
             if [ "${CIRCLE_BRANCH}" == "master" ];
             then
                 echo "Sending lcov.info to SonarQube..."
-                aws s3 cp coverage/lcov.info $AWS_S3_DIR_SONARQUBE/central-services-shared/lcov.info
+                aws s3 cp coverage/lcov.info $AWS_S3_DIR_SONARQUBE/${CIRCLE_PROJECT_REPONAME}/lcov.info
             else
                 echo "Not a release (env CIRCLE_BRANCH != 'master'), skipping sending lcov.info to SonarQube."
             fi
@@ -171,7 +181,7 @@ jobs:
           command: *defaults_Dependencies
       - checkout
       - restore_cache:
-          key: dependency-cache-{{ checksum "package-lock.json" }}
+          key: dependency-cache-{{ .Environment.CIRCLE_SHA1 }}
       - run:
           name: Create dir for test results
           command: mkdir -p ./audit/results
@@ -188,14 +198,11 @@ jobs:
       - run:
           name: Install general dependencies
           command: *defaults_Dependencies
-      - checkout
       - run:
           <<: *defaults_license_scanner
+      - checkout
       - restore_cache:
-          key: dependency-cache-{{ checksum "package-lock.json" }}
-      - run:
-          name: Prune non-production packages before running license-scanner
-          command: npm prune --production
+          key: dependency-cache-{{ .Environment.CIRCLE_SHA1 }}
       - run:
           name: Run the license-scanner
           command: cd /tmp/license-scanner && pathToRepo=$CIRCLE_WORKING_DIRECTORY make run
@@ -212,25 +219,26 @@ jobs:
       - checkout
       - restore_cache:
           keys:
-          - dependency-cache-{{ checksum "package-lock.json" }}
+          - dependency-cache-{{ .Environment.CIRCLE_SHA1 }}
       - run:
-          name: Configure git
-          command: |
-            git config user.email ${GIT_CI_EMAIL}
-            git config user.name ${GIT_CI_USER}
-            git checkout ${CIRCLE_BRANCH}
+          <<: *defaults_configure_git
       - run:
-          name: Configure ssh
+          name: Setup Slack config
           command: |
-            mkdir -p ~/.ssh
-            ssh-keyscan -p 443 ssh.github.com >> ~/.ssh/known_hosts
-            ssh-keyscan github.com >> ~/.ssh/known_hosts
+            echo "export SLACK_PROJECT_NAME=${CIRCLE_PROJECT_REPONAME}" >> $BASH_ENV
+            echo "export SLACK_RELEASE_TYPE='GitHub Release'" >> $BASH_ENV
+            echo "export SLACK_RELEASE_TAG='${RELEASE_TAG} on ${CIRCLE_BRANCH} branch'" >> $BASH_ENV
+            echo "export SLACK_BUILD_ID=${CIRCLE_BUILD_NUM}" >> $BASH_ENV
+            echo "export SLACK_CI_URL=${CIRCLE_BUILD_URL}" >> $BASH_ENV
       - run:
           name: Generate changelog and bump package version
-          command: npm run release
+          command: npm run release -- --no-verify
       - run:
           name: Push the release
           command: git push --follow-tags origin ${CIRCLE_BRANCH}
+      - slack/notify:
+          event: fail
+          template: SLACK_TEMP_RELEASE_FAILURE
 
   github-release:
     executor: default-machine
@@ -239,34 +247,40 @@ jobs:
           name: Install git
           command: |
             sudo apt-get update && sudo apt-get install -y git
+      - gh/install
       - checkout
+      - run:
+          <<: *defaults_configure_git
       - run:
           name: Fetch updated release branch
           command: |
-            git config user.email ${GIT_CI_EMAIL}
-            git config user.name ${GIT_CI_USER}
             git fetch origin
             git checkout origin/${CIRCLE_BRANCH}
       - run:
-          # Note: this is rather imperfect, but will do for now
-          name: Format the changelog into the github release body and get release tag
-          command: |
-            git diff --no-indent-heuristic master~1 HEAD CHANGELOG.md | sed -n '/^+[^+]/ s/^+//p' > /tmp/changes
-            echo 'export RELEASE_CHANGES=`cat /tmp/changes`' >> $BASH_ENV
-            echo 'export RELEASE_TAG=`cat package.json | jq -r .version`' >> $BASH_ENV
+          <<: *defaults_export_version_from_package
       - run:
-          name: check the release changes
+          name: Check the release changes
           command: |
             echo "Changes are: ${RELEASE_CHANGES}"
-      - github-release/create:
-          github-token-variable: ${GITHUB_TOKEN}
-          tag: v${RELEASE_TAG}
-          title: v${RELEASE_TAG} Release
-          description: ${RELEASE_CHANGES}
-          file-path: CHANGELOG.md
-      - slack/status:
-          webhook: "$SLACK_WEBHOOK_ANNOUNCEMENT"
-          success_message: '*"${CIRCLE_PROJECT_REPONAME}"* - Release \`"v${RELEASE_TAG}"\` \nhttps://github.com/mojaloop/"${CIRCLE_PROJECT_REPONAME}"/releases/tag/"v${RELEASE_TAG}"'
+      - run:
+          name: Setup Slack config
+          command: |
+            echo "export SLACK_PROJECT_NAME=${CIRCLE_PROJECT_REPONAME}" >> $BASH_ENV
+            echo "export SLACK_RELEASE_TYPE='Github Release'" >> $BASH_ENV
+            echo "export SLACK_RELEASE_TAG=v${RELEASE_TAG}" >> $BASH_ENV
+            echo "export SLACK_RELEASE_URL=https://github.com/mojaloop/${CIRCLE_PROJECT_REPONAME}/releases/tag/v${RELEASE_TAG}" >> $BASH_ENV
+            echo "export SLACK_BUILD_ID=${CIRCLE_BUILD_NUM}" >> $BASH_ENV
+            echo "export SLACK_CI_URL=${CIRCLE_BUILD_URL}" >> $BASH_ENV
+      - run:
+          name: Create Release
+          command: |
+            gh release create "v${RELEASE_TAG}" --title "v${RELEASE_TAG} Release" --draft=false --notes "${RELEASE_CHANGES}" ./CHANGELOG.md
+      - slack/notify:
+          event: pass
+          template: SLACK_TEMP_RELEASE_SUCCESS
+      - slack/notify:
+          event: fail
+          template: SLACK_TEMP_RELEASE_FAILURE
 
   publish:
     executor: default-docker
@@ -276,34 +290,114 @@ jobs:
           command: *defaults_Dependencies
       - checkout
       - restore_cache:
-          key: dependency-cache-{{ checksum "package-lock.json" }}
+          key: dependency-cache-{{ .Environment.CIRCLE_SHA1 }}
+      - run:
+          name: Setup for LATEST release
+          command: |
+            echo "export RELEASE_TAG=$RELEASE_TAG_PROD" >> $BASH_ENV
+            echo "RELEASE_TAG=$RELEASE_TAG_PROD"
+
+            PACKAGE_VERSION=$(cat package-lock.json | jq -r .version)
+            echo "export PACKAGE_VERSION=${PACKAGE_VERSION}" >> $BASH_ENV
+            echo "PACKAGE_VERSION=${PACKAGE_VERSION}"
       - run:
-          name: setup environment vars for LATEST release
+          name: Setup Slack config
           command: |
-            echo 'export RELEASE_TAG=$RELEASE_TAG_PROD' >> $BASH_ENV
+            echo "export SLACK_PROJECT_NAME=${CIRCLE_PROJECT_REPONAME}" >> $BASH_ENV
+            echo "export SLACK_RELEASE_TYPE='NPM Release'" >> $BASH_ENV
+            echo "export SLACK_RELEASE_TAG=v${CIRCLE_TAG:1}" >> $BASH_ENV
+            echo "export SLACK_RELEASE_URL=https://www.npmjs.com/package/@mojaloop/${CIRCLE_PROJECT_REPONAME}/v/${CIRCLE_TAG:1}" >> $BASH_ENV
+            echo "export SLACK_BUILD_ID=${CIRCLE_BUILD_NUM}" >> $BASH_ENV
+            echo "export SLACK_CI_URL=${CIRCLE_BUILD_URL}" >> $BASH_ENV
       - run:
           <<: *defaults_npm_auth
       - run:
           <<: *defaults_npm_publish_release
+      - slack/notify:
+          event: pass
+          template: SLACK_TEMP_RELEASE_SUCCESS
+      - slack/notify:
+          event: fail
+          template: SLACK_TEMP_RELEASE_FAILURE
+
+  publish-snapshot:
+    executor: default-docker
+    steps:
+      - run:
+          name: Install general dependencies
+          command: *defaults_Dependencies
+      - checkout
+      - restore_cache:
+          key: dependency-cache-{{ .Environment.CIRCLE_SHA1 }}
+      - run:
+          name: Setup for SNAPSHOT release
+          command: |
+            echo "export RELEASE_TAG=${RELEASE_TAG_SNAPSHOT}" >> $BASH_ENV
+            echo "RELEASE_TAG=${RELEASE_TAG_SNAPSHOT}"
+
+            echo "Override package version: ${CIRCLE_TAG:1}"
+            npx standard-version --skip.tag --skip.commit --skip.changelog --release-as ${CIRCLE_TAG:1}
+
+            PACKAGE_VERSION=$(cat package-lock.json | jq -r .version)
+            echo "export PACKAGE_VERSION=${PACKAGE_VERSION}" >> $BASH_ENV
+            echo "PACKAGE_VERSION=${PACKAGE_VERSION}"
+      - run:
+          name: Setup Slack config
+          command: |
+            echo "export SLACK_PROJECT_NAME=${CIRCLE_PROJECT_REPONAME}" >> $BASH_ENV
+            echo "export SLACK_RELEASE_TYPE='NPM Snapshot'" >> $BASH_ENV
+            echo "export SLACK_RELEASE_TAG=v${CIRCLE_TAG:1}" >> $BASH_ENV
+            echo "export SLACK_RELEASE_URL=https://www.npmjs.com/package/@mojaloop/${CIRCLE_PROJECT_REPONAME}/v/${CIRCLE_TAG:1}" >> $BASH_ENV
+            echo "export SLACK_BUILD_ID=${CIRCLE_BUILD_NUM}" >> $BASH_ENV
+            echo "export SLACK_CI_URL=${CIRCLE_BUILD_URL}" >> $BASH_ENV
+      - run:
+          <<: *defaults_npm_auth
+      - run:
+          <<: *defaults_npm_publish_release
+      - slack/notify:
+          event: pass
+          template: SLACK_TEMP_RELEASE_SUCCESS
+      - slack/notify:
+          event: fail
+          template: SLACK_TEMP_RELEASE_FAILURE
 
-##
-# Workflows
-#
-# CircleCI Workflow config
-##
 workflows:
   version: 2
   build_and_test:
     jobs:
       - pr-tools/pr-title-check:
           context: org-global
-
       - setup:
           context: org-global
           filters:
             tags:
               only: /.*/
-
+            branches:
+              ignore:
+                - /feature*/
+                - /bugfix*/
+      - test-dependencies:
+          context: org-global
+          requires:
+            - setup
+          filters:
+            tags:
+              only: /.*/
+            branches:
+              ignore:
+                - /feature*/
+                - /bugfix*/
+      - test-lint:
+          context: org-global
+          requires:
+            - setup
+          filters:
+            tags:
+              only: /.*/
+            branches:
+              ignore:
+                - /feature*/
+                - /bugfix*/
       - test-unit:
           context: org-global
           requires:
@@ -311,7 +405,10 @@ workflows:
           filters:
             tags:
               only: /.*/
-
+            branches:
+              ignore:
+                - /feature*/
+                - /bugfix*/
       - test-coverage:
           context: org-global
           requires:
@@ -319,38 +416,48 @@ workflows:
           filters:
             tags:
               only: /.*/
-
+            branches:
+              ignore:
+                - /feature*/
+                - /bugfix*/
       - vulnerability-check:
           context: org-global
           requires:
             - setup
-            - test-unit
-            - test-coverage
           filters:
             tags:
               only: /.*/
-
+            branches:
+              ignore:
+                - /feature*/
+                - /bugfix*/
       - audit-licenses:
           context: org-global
           requires:
             - setup
-            - test-unit
-            - test-coverage
           filters:
             tags:
               only: /.*/
-
+            branches:
+              ignore:
+                - /feature*/
+                - /bugfix*/
       # New commits to master release automatically
       - release:
           context: org-global
           requires:
-            - audit-licenses
+            - pr-tools/pr-title-check
+            - test-dependencies
+            - test-lint
+            - test-unit
+            - test-coverage
             - vulnerability-check
+            - audit-licenses
           filters:
             branches:
               only:
                 - master
-
+                - /release\/v.*/
       - github-release:
           context: org-global
           requires:
@@ -359,15 +466,34 @@ workflows:
             branches:
               only:
                 - master
-
+                - /release\/v.*/
       - publish:
           context: org-global
           requires:
+            - pr-tools/pr-title-check
+            - test-lint
+            - test-unit
+            - test-coverage
             - vulnerability-check
             - audit-licenses
           filters:
             tags:
-              only: /.*/
+              only: /v[0-9]+(\.[0-9]+)*/
+            branches:
+              ignore:
+                - /.*/
+      - publish-snapshot:
+          context: org-global
+          requires:
+            - pr-tools/pr-title-check
+            - test-lint
+            - test-unit
+            - test-coverage
+            - vulnerability-check
+            - audit-licenses
+          filters:
+            tags:
+              only: /v[0-9]+(\.[0-9]+)*\-snapshot+((\.[0-9]+)?)/
             branches:
               ignore:
                 - /.*/

package/.ncurc.js

@@ -0,0 +1,7 @@
+module.exports = {
+  reject: [
+    // TODO: Added "@hapi/catbox", "@hapi/catbox-memory" to ncurc for dep:check to ignore updates due to breaking changes which should be handled by another story
+    "@hapi/catbox",
+    "@hapi/catbox-memory"
+  ]
+}

package/.nvmrc

@@ -1 +1 @@
-12.16.0
+16.15.0

package/CHANGELOG.md

@@ -2,6 +2,35 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [17.0.1](https://github.com/mojaloop/central-services-shared/compare/v17.0.0...v17.0.1) (2022-05-19)
+
+
+### Bug Fixes
+
+* removed typescript build from ci config ([cc75c8a](https://github.com/mojaloop/central-services-shared/commit/cc75c8ab6326b2ef3fb1116a328f3aa3792bcd7e))
+
+## [17.0.0](https://github.com/mojaloop/central-services-shared/compare/v16.0.0...v17.0.0) (2022-05-19)
+
+
+### ⚠ BREAKING CHANGES
+
+* **mojaloop/#2092:** major version bump for node v16 LTS support, and re-structuring of project directories to align to core Mojaloop repositories!
+
+### Features
+
+* **mojaloop/#2092:** upgrade nodeJS version for core services ([#330](https://github.com/mojaloop/central-services-shared/issues/330)) ([4778864](https://github.com/mojaloop/central-services-shared/commit/477886485299940b08a29d3db5a4ceaab431d47d)), closes [mojaloop/#2092](https://github.com/mojaloop/project/issues/2092)
+
+## [16.0.0](https://github.com/mojaloop/central-services-shared/compare/v15.3.0...v16.0.0) (2022-03-03)
+
+
+### ⚠ BREAKING CHANGES
+
+* **mojaloop/#2704:** - headerValidation.FSPIOPHeaderValidation now expects the`supportedProtocolContentVersions` options argument to be a list, the same as `supportedProtocolAcceptVersions`
+
+### Features
+
+* **mojaloop/#2704:** core-services support for non-breaking backward api compatibility ([#325](https://github.com/mojaloop/central-services-shared/issues/325)) ([cb81f7e](https://github.com/mojaloop/central-services-shared/commit/cb81f7ec92376e0d6ce45e2ce046379ce1996167)), closes [mojaloop/#2704](https://github.com/mojaloop/project/issues/2704)
+
 ## [15.3.0](https://github.com/mojaloop/central-services-shared/compare/v15.2.0...v15.3.0) (2022-02-07)
 
 
@@ -14,7 +43,7 @@ All notable changes to this project will be documented in this file. See [standa
 
 ### Features
 
-* **mojaloop/#2608:** injected resource versions config for outbound requests ([#319](https://github.com/mojaloop/central-services-shared/issues/319)) ([13a3d9d](https://github.com/mojaloop/central-services-shared/commit/13a3d9dc8ab8d4815db2aea22563317e3670a19b)), closes [mojaloop/#2608](https://github.com/mojaloop/central-services-shared/issues/2608)
+* **mojaloop/#2608:** injected resource versions config for outbound requests ([#319](https://github.com/mojaloop/central-services-shared/issues/319)) ([13a3d9d](https://github.com/mojaloop/central-services-shared/commit/13a3d9dc8ab8d4815db2aea22563317e3670a19b)), closes [mojaloop/#2608](https://github.com/mojaloop/project/issues/2608)
 
 ## [15.1.0](https://github.com/mojaloop/central-services-shared/compare/v15.0.1...v15.1.0) (2021-11-17)
 
@@ -39,7 +68,7 @@ All notable changes to this project will be documented in this file. See [standa
 
 ### Bug Fixes
 
-* **mojaloop/#2536:** fspiop api version negotiation not handled by transfers service ([#315](https://github.com/mojaloop/central-services-shared/issues/315)) ([e3a8748](https://github.com/mojaloop/central-services-shared/commit/e3a874829794ed8b85b6487dd58bcb58f31a5dd1)), closes [mojaloop/#2536](https://github.com/mojaloop/central-services-shared/issues/2536) [mojaloop/#2536](https://github.com/mojaloop/central-services-shared/issues/2536)
+* **mojaloop/#2536:** fspiop api version negotiation not handled by transfers service ([#315](https://github.com/mojaloop/central-services-shared/issues/315)) ([e3a8748](https://github.com/mojaloop/central-services-shared/commit/e3a874829794ed8b85b6487dd58bcb58f31a5dd1)), closes [mojaloop/#2536](https://github.com/mojaloop/project/issues/2536)
 
 ## [14.0.0](https://github.com/mojaloop/central-services-shared/compare/v13.4.1...v14.0.0) (2021-09-10)
 
@@ -50,7 +79,7 @@ All notable changes to this project will be documented in this file. See [standa
 
 ### Bug Fixes
 
-* **mojaloop/#2470:** central-services-shared streamingprotocol encode/decode functionality fix ([#313](https://github.com/mojaloop/central-services-shared/issues/313)) ([cedc359](https://github.com/mojaloop/central-services-shared/commit/cedc3595508ebe2fd67517f732e8e1da35635171)), closes [mojaloop/#2470](https://github.com/mojaloop/central-services-shared/issues/2470)
+* **mojaloop/#2470:** central-services-shared streamingprotocol encode/decode functionality fix ([#313](https://github.com/mojaloop/central-services-shared/issues/313)) ([cedc359](https://github.com/mojaloop/central-services-shared/commit/cedc3595508ebe2fd67517f732e8e1da35635171)), closes [mojaloop/#2470](https://github.com/mojaloop/project/issues/2470)
 
 ### [13.4.1](https://github.com/mojaloop/central-services-shared/compare/v13.4.0...v13.4.1) (2021-08-25)
 

package/README.md

@@ -6,3 +6,51 @@
 [![CircleCI](https://circleci.com/gh/mojaloop/central-services-shared.svg?style=svg)](https://circleci.com/gh/mojaloop/central-services-shared)
 
 Shared code for central services
+
+## Auditing Dependencies
+
+We use `npm-audit-resolver` along with `npm audit` to check dependencies for node vulnerabilities, and keep track of resolved dependencies with an `audit-resolve.json` file.
+
+To start a new resolution process, run:
+
+```bash
+npm run audit:resolve
+```
+
+You can then check to see if the CI will pass based on the current dependencies with:
+
+```bash
+npm run audit:check
+```
+
+And commit the changed `audit-resolve.json` to ensure that CircleCI will build correctly.
+
+## Automated Releases
+
+As part of our CI/CD process, we use a combination of CircleCI, standard-version
+npm package and github-release CircleCI orb to automatically trigger our releases
+and image builds. This process essentially mimics a manual tag and release.
+
+On a merge to master, CircleCI is configured to use the mojaloopci github account
+to push the latest generated CHANGELOG and package version number.
+
+Once those changes are pushed, CircleCI will pull the updated master, tag and
+push a release triggering another subsequent build that also publishes a docker image.
+
+### Potential problems
+
+* There is a case where the merge to master workflow will resolve successfully, triggering
+  a release. Then that tagged release workflow subsequently failing due to the image scan,
+  audit check, vulnerability check or other "live" checks.
+
+  This will leave master without an associated published build. Fixes that require
+  a new merge will essentially cause a skip in version number or require a clean up
+  of the master branch to the commit before the CHANGELOG and bump.
+
+  This may be resolved by relying solely on the previous checks of the
+  merge to master workflow to assume that our tagged release is of sound quality.
+  We are still mulling over this solution since catching bugs/vulnerabilities/etc earlier
+  is a boon.
+
+* It is unknown if a race condition might occur with multiple merges with master in
+  quick succession, but this is a suspected edge case.

package/audit-resolve.json

@@ -1,98 +1,59 @@
 {
   "decisions": {
-    "1002401|widdershins>yargs>string-width>strip-ansi>ansi-regex": {
+    "1067553|better-ajv-errors>jsonpointer": {
       "decision": "ignore",
-      "madeAt": 1636372052422,
-      "expiresAt": 1638964045850
+      "madeAt": 1652887989276,
+      "expiresAt": 1655479973082
     },
-    "1002401|widdershins>yargs>cliui>string-width>strip-ansi>ansi-regex": {
+    "1070256|ejs": {
       "decision": "ignore",
-      "madeAt": 1636372052422,
-      "expiresAt": 1638964045850
+      "madeAt": 1652887990649,
+      "expiresAt": 1655479973082
     },
-    "1002865|shins>sanitize-html": {
+    "1070030|shins>markdown-it": {
       "decision": "ignore",
-      "madeAt": 1636372053964,
-      "expiresAt": 1638964045850
+      "madeAt": 1652951732905,
+      "expiresAt": 1655543725868
     },
-    "1002866|shins>sanitize-html": {
+    "1068155|shins>markdown-it>sanitize-html": {
       "decision": "ignore",
-      "madeAt": 1636372053964,
-      "expiresAt": 1638964045850
+      "madeAt": 1652887992740,
+      "expiresAt": 1655479973082
     },
-    "1003019|widdershins>yargs>yargs-parser": {
+    "1070260|shins>markdown-it>sanitize-html": {
       "decision": "ignore",
-      "madeAt": 1636372055094,
-      "expiresAt": 1638964045850
+      "madeAt": 1652887993909,
+      "expiresAt": 1655479973082
     },
-    "1004809|widdershins>openapi-sampler>json-pointer": {
+    "1068310|widdershins>oas-resolver>yargs>yargs-parser": {
       "decision": "ignore",
-      "madeAt": 1636956486789,
-      "expiresAt": 1639548471465
+      "madeAt": 1652887994946,
+      "expiresAt": 1655479973082
     },
-    "1004812|widdershins>swagger2openapi>better-ajv-errors>jsonpointer": {
+    "1067946|widdershins>oas-resolver>yargs>yargs-parser>swagger2openapi>oas-validator>ajv": {
       "decision": "ignore",
-      "madeAt": 1636956491233,
-      "expiresAt": 1639548471465
+      "madeAt": 1652887996204,
+      "expiresAt": 1655479973082
     },
-    "1004812|widdershins>swagger2openapi>oas-validator>better-ajv-errors>jsonpointer": {
+    "1070030|widdershins>markdown-it": {
       "decision": "ignore",
-      "madeAt": 1636956491233,
-      "expiresAt": 1639548471465
+      "madeAt": 1652951732905,
+      "expiresAt": 1655543725868
     },
-    "1004854|widdershins>openapi-sampler>json-pointer": {
+    "1067553|swagger2openapi>better-ajv-errors>jsonpointer": {
       "decision": "ignore",
-      "madeAt": 1644227612906,
-      "expiresAt": 1646819457744
+      "madeAt": 1652951735762,
+      "expiresAt": 1655543725868
     },
-    "1004869|widdershins>swagger2openapi>better-ajv-errors>jsonpointer": {
+    "1067946|swagger2openapi>better-ajv-errors>jsonpointer>oas-validator>ajv": {
       "decision": "ignore",
-      "madeAt": 1644227615371,
-      "expiresAt": 1646819457744
+      "madeAt": 1652951738877,
+      "expiresAt": 1655543725868
     },
-    "1004869|widdershins>swagger2openapi>oas-validator>better-ajv-errors>jsonpointer": {
+    "1068310|widdershins>markdown-it>yargs>yargs-parser": {
       "decision": "ignore",
-      "madeAt": 1644227615371,
-      "expiresAt": 1646819457744
-    },
-    "1004946|widdershins>yargs>string-width>strip-ansi>ansi-regex": {
-      "decision": "ignore",
-      "madeAt": 1644227616947,
-      "expiresAt": 1646819457744
-    },
-    "1004946|widdershins>yargs>cliui>string-width>strip-ansi>ansi-regex": {
-      "decision": "ignore",
-      "madeAt": 1644227616947,
-      "expiresAt": 1646819457744
-    },
-    "1005383|shins>sanitize-html": {
-      "decision": "ignore",
-      "madeAt": 1644227618453,
-      "expiresAt": 1646819457744
-    },
-    "1005384|shins>sanitize-html": {
-      "decision": "ignore",
-      "madeAt": 1644227618454,
-      "expiresAt": 1646819457744
-    },
-    "1005534|widdershins>yargs>yargs-parser": {
-      "decision": "ignore",
-      "madeAt": 1644227619978,
-      "expiresAt": 1646819457744
-    },
-    "1006899|widdershins>node-fetch": {
-      "decision": "fix",
-      "madeAt": 1644227510867
-    },
-    "1006846|shins>sanitize-html>postcss": {
-      "decision": "ignore",
-      "madeAt": 1644227621510,
-      "expiresAt": 1646819457744
-    },
-    "1006886|shins>markdown-it": {
-      "decision": "ignore",
-      "madeAt": 1644227622831,
-      "expiresAt": 1646819457744
+      "madeAt": 1652951741588,
+      "expiresAt": 1655543725868
     }
   },
   "rules": {},

package/package.json

@@ -1,101 +1,107 @@
 {
   "name": "@mojaloop/central-services-shared",
-  "version": "15.3.0-snapshot.2",
+  "version": "17.0.1",
   "description": "Shared code for mojaloop central services",
-  "main": "src/index.js",
-  "types": "src/index.d.ts",
-  "scripts": {
-    "pretest": "standard",
-    "standard": "standard",
-    "standard:fix": "standard --fix",
-    "lint": "npm run standard",
-    "lint:fix": "npm run standard:fix",
-    "test": "npm run test:unit",
-    "test:unit": "tape 'test/unit/**/*.test.js' | tap-spec",
-    "test:xunit": "tape 'test/unit/**/*.test.js' | tap-xunit",
-    "test:coverage": "nyc --reporter=lcov --reporter=text-summary tapes -- 'test/unit/**/**.test.js'",
-    "test:coverage-check": "npm run test:coverage && nyc check-coverage",
-    "audit:resolve": "SHELL=sh resolve-audit --production",
-    "audit:check": "SHELL=sh check-audit --production",
-    "dep:check": "npx ncu -e 2",
-    "dep:update": "npx ncu -u",
-    "release": "standard-version --releaseCommitMessageFormat 'chore(release): {{currentTag}} [skip ci]'"
-  },
-  "pre-commit": [
-    "lint",
-    "dep:check",
-    "test"
+  "license": "Apache-2.0",
+  "author": "ModusBox",
+  "contributors": [
+    "ModusBox",
+    "Dwolla"
   ],
+  "homepage": "https://github.com/mojaloop/central-services-shared#readme",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/mojaloop/central-services-shared.git"
   },
+  "bugs": {
+    "url": "https://github.com/mojaloop/central-services-shared/issues"
+  },
   "keywords": [
     "shared",
     "central",
-    "services"
+    "services",
+    "mojaloop"
   ],
-  "author": "ModusBox",
-  "contributors": [
-    "ModusBox",
-    "Dwolla"
+  "main": "src/index.js",
+  "types": "src/index.d.ts",
+  "engines": {
+    "node": "=16.x"
+  },
+  "pre-commit": [
+    "lint",
+    "dep:check",
+    "test"
   ],
-  "license": "Apache-2.0",
-  "bugs": {
-    "url": "https://github.com/mojaloop/central-services-shared/issues"
+  "scripts": {
+    "pretest": "npm run lint",
+    "standard": "npx standard",
+    "standard:fix": "npm run standard -- --fix",
+    "lint": "npm run standard",
+    "lint:fix": "npm run standard:fix",
+    "test": "npm run test:unit",
+    "test:unit": "npx tape 'test/unit/**/*.test.js' | tap-spec",
+    "test:xunit": "npx tape 'test/unit/**/**.test.js' | tap-xunit > ./test/results/xunit.xml",
+    "test:coverage": "npx nyc --reporter=lcov --reporter=text-summary tapes -- 'test/unit/**/**.test.js'",
+    "test:coverage-check": "npm run test:coverage && nyc check-coverage",
+    "audit:resolve": "npx resolve-audit --production",
+    "audit:check": "npx check-audit --production",
+    "dep:check": "npx ncu -e 2",
+    "dep:update": "npx ncu -u",
+    "release": "npx standard-version --no-verify --releaseCommitMessageFormat 'chore(release): {{currentTag}} [skip ci]'",
+    "snapshot": "npx standard-version --no-verify --skip.changelog --prerelease snapshot --releaseCommitMessageFormat 'chore(snapshot): {{currentTag}}'"
   },
-  "homepage": "https://github.com/mojaloop/central-services-shared#readme",
   "dependencies": {
-    "@hapi/catbox": "11.1.1",
+    "@hapi/catbox": "12.0.0",
     "@hapi/catbox-memory": "5.0.1",
-    "axios": "0.25.0",
+    "axios": "0.27.2",
     "clone": "2.1.2",
-    "dotenv": "16.0.0",
+    "dotenv": "16.0.1",
     "env-var": "7.1.1",
     "event-stream": "4.0.1",
     "immutable": "4.0.0",
     "lodash": "4.17.21",
     "mustache": "4.2.0",
-    "openapi-backend": "5.2.0",
-    "raw-body": "2.4.2",
+    "openapi-backend": "5.3.0",
+    "raw-body": "2.5.1",
     "rc": "1.2.8",
     "shins": "2.6.0",
     "uuid4": "2.0.2",
-    "widdershins": "4.0.1",
-    "yaml": "1.10.2"
+    "widdershins": "^4.0.1",
+    "yaml": "2.1.0"
   },
   "devDependencies": {
-    "@hapi/hapi": "20.2.1",
+    "@hapi/hapi": "20.2.2",
     "@hapi/joi": "17.1.1",
-    "@mojaloop/central-services-error-handling": "11.3.0",
-    "@mojaloop/central-services-logger": "10.6.2",
-    "@mojaloop/central-services-metrics": "11.0.0",
-    "@mojaloop/event-sdk": "10.7.1",
-    "@mojaloop/sdk-standard-components": "10.3.2",
-    "ajv": "8.10.0",
+    "@mojaloop/central-services-error-handling": "12.0.1",
+    "@mojaloop/central-services-logger": "11.0.0",
+    "@mojaloop/central-services-metrics": "12.0.2",
+    "@mojaloop/event-sdk": "^11.0.1",
+    "@mojaloop/sdk-standard-components": "17.0.0",
+    "ajv": "8.11.0",
     "ajv-keywords": "5.1.0",
     "base64url": "3.0.1",
     "chance": "1.1.8",
-    "npm-audit-resolver": "2.3.1",
-    "npm-check-updates": "12.2.1",
+    "npm-audit-resolver": "3.0.0-7",
+    "npm-check-updates": "13.0.1",
     "nyc": "15.1.0",
     "pre-commit": "1.2.2",
     "proxyquire": "2.1.3",
+    "replace": "^1.2.1",
     "rewire": "6.0.0",
-    "sinon": "13.0.1",
-    "standard": "16.0.4",
-    "standard-version": "9.3.2",
+    "sinon": "14.0.0",
+    "standard": "17.0.0",
+    "standard-version": "9.5.0",
     "tap-spec": "^5.0.0",
     "tap-xunit": "2.4.1",
-    "tape": "5.5.0",
+    "tape": "5.5.3",
     "tapes": "4.1.0"
   },
   "peerDependencies": {
-    "@mojaloop/central-services-error-handling": "11.3.0",
-    "@mojaloop/central-services-logger": "10.6.2",
-    "@mojaloop/central-services-metrics": "11.0.0",
-    "@mojaloop/event-sdk": "10.7.1",
-    "ajv": "8.10.0",
+    "@mojaloop/central-services-error-handling": "12.0.1",
+    "@mojaloop/central-services-logger": "11.0.0",
+    "@mojaloop/central-services-metrics": "12.0.2",
+    "@mojaloop/event-sdk": "11.0.0",
+    "ajv": "8.11.0",
     "ajv-keywords": "5.1.0"
   },
   "peerDependenciesMeta": {
@@ -123,5 +129,10 @@
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
+  },
+  "standard-version": {
+    "scripts": {
+      "postchangelog": "replace '\\[mojaloop/#(\\d+)\\]\\(https://github.com/mojaloop/(.*)/issues/(\\d+)\\)' '[mojaloop/#$1](https://github.com/mojaloop/project/issues/$1)' CHANGELOG.md"
+    }
   }
 }

package/src/util/hapi/plugins/headerValidation.js

@@ -97,7 +97,8 @@ const plugin = {
           errorMessages.INVALID_CONTENT_TYPE_HEADER
         )
       }
-      if (!supportedProtocolContentVersions.includes(contentType.version)) {
+      // if (!supportedProtocolContentVersions.includes(contentType.version)) {
+      if (!supportedProtocolContentVersions.some(supportedVer => contentType.version === supportedVer)) {
         const supportedVersionExtensionListMap = convertSupportedVersionToExtensionList(supportedProtocolContentVersions)
         throw createFSPIOPError(
           Enums.FSPIOPErrorCodes.UNACCEPTABLE_VERSION,
@@ -107,7 +108,6 @@ const plugin = {
           supportedVersionExtensionListMap
         )
       }
-
       return h.continue
     })
   }

package/src/util/request.js

@@ -86,7 +86,7 @@ const sendRequest = async (url, headers, source, destination, method = enums.Htt
     })
     requestOptions = {
       url,
-      method: method,
+      method,
       headers: transformedHeaders,
       data: payload,
       responseType

package/src/util/streaming/protocol/index.js

@@ -48,7 +48,7 @@ const updateMessageProtocolMetadata = (messageProtocol, metadataType, metadataAc
         id: Uuid(),
         type: metadataType,
         action: metadataAction,
-        state: state
+        state
       }
     }
   } else {
@@ -85,7 +85,7 @@ const createMessage = (id, to, from, metadata, headers, payload, uriParams = und
     type: type || Enum.Http.Headers.DEFAULT.APPLICATION_JSON,
     content: {
       uriParams: uriParams || undefined,
-      headers: headers,
+      headers,
       payload: payload || {}
     },
     metadata

package/.env

@@ -1 +0,0 @@
-LOG_LEVEL = info

package/.ncurc.json

@@ -1,4 +0,0 @@
-{
-  "reject": [
-  ]
-}

package/sonar-project.properties

@@ -1,16 +0,0 @@
-# Required metadata
-sonar.projectKey=central-services-shared
-sonar.projectName=central-services-shared
-sonar.projectVersion=1.0
-
-# Comma-separated paths to directories with sources (required)
-sonar.sources=src,test
-
-# Language
-sonar.language=js
-
-# Encoding of the source files
-sonar.sourceEncoding=UTF-8
-
-# To import the LCOV report
-sonar.javascript.lcov.reportPath=lcov.info