@mohasinac/appkit 4.67.0 → 4.69.0

package/dist/features/homepage/components/MarketplaceHomepageView.js

@@ -19,6 +19,9 @@ import { safeRead } from "../../../errors/safe-read.js";
 import { fetchLiveStats } from "../lib/live-stats.js";
 import { renderSection, AnnouncementBar } from "../lib/section-renderer.js";
 import { gateCarouselSlides } from "../lib/slide-gating.js";
+import { gateHomepageSections } from "../lib/section-gating.js";
+import { closedSurfaceContext, isClosedHref } from "../../../_internal/shared/listing-types/route-gating.js";
+import { getSurfaceCounts } from "../../../_internal/server/features/products/surface-counts.js";
 import { SECTION_COPY } from "../constants/section-copy.js";
 import { homepageSectionsRepository } from "../repository/homepage-sections.repository.js";
 import { isListingTypeEnabled, isCategoryTypeEnabled, isBrowsePageEnabled, } from "../../../_internal/shared/listing-types/feature-flags.js";
@@ -111,7 +114,7 @@ export async function MarketplaceHomepageView({ adSlots, newsletterFormSlot, onB
     // promotional copy for a promotion that does not exist.
     const announcementMessage = siteSettings?.announcementBar?.message?.trim() || SECTION_COPY.announcementFallback;
     const showAnnouncement = siteSettings?.announcementBar?.enabled ?? true;
-    const [allSections, rawFaqItems] = await Promise.all([
+    const [allSections, rawFaqItems, surfaceCounts] = await Promise.all([
         safeRead(() => homepageSectionsRepository.getEnabledSections(), {
             route: "/", key: "homepage.enabledSections", fallback: [],
         }),
@@ -119,7 +122,50 @@ export async function MarketplaceHomepageView({ adSlots, newsletterFormSlot, onB
         safeRead(() => getHomepageFaqsCached(), {
             route: "/", key: "homepage.faqs", fallback: [],
         }),
+        /*
+         * 🛑 The homepage did NOT read these until 2026-10-27, and that was the
+         * whole reason it kept advertising `/art` and `/spares` after both began
+         * answering a real 404: the flag for each was still `true` and only the
+         * measured count said empty. Every other surface on the site — nav,
+         * footer, sitemap, the edge gate — already ANDed the two.
+         *
+         * `getSurfaceCounts` swallows its own failures and returns `undefined`,
+         * which `isListingSurfaceVisible` reads as VISIBLE. So an unmeasured or
+         * unreadable count leaves the homepage as authored rather than stripping
+         * it (Root Cause #72) — which is also why it needs no `safeRead` wrapper.
+         */
+        getSurfaceCounts(),
     ]);
+    /*
+     * One context for every link decision on this page — the carousel slides and
+     * the section configs both consult it, so they cannot disagree about which
+     * destinations are open. Built once because the prefix list is derived work
+     * and the callers are loops over dozens of links.
+     */
+    const closedSurfaces = closedSurfaceContext(siteSettings, surfaceCounts);
+    /*
+     * 🛑 THE ANNOUNCEMENT BAR IS AUTHORED CONTENT TOO, and it is the FIRST thing
+     * on the page — so it was the worst remaining place to advertise a closed
+     * surface. Found by screenshotting the built page rather than by reading the
+     * HTML: the live bar read "… — See Events for codes" and linked `/events`,
+     * which `disabledRoutes` now closes.
+     *
+     * It survived the grep that caught everything else because the bar is
+     * CLIENT-rendered through a portal, so `/events` never appears as an `href`
+     * in the server HTML — it arrives as a prop in the RSC payload. The tell was
+     * in the browser console, not the markup: a `next/link` prefetch of
+     * `/events?_rsc=…` answering **404**.
+     *
+     * Dropping only the LINK is deliberate, and the message is left alone: the
+     * copy is the admin's, this code cannot rewrite English, and a bar that
+     * still reads "See Events for codes" with nothing to click is a smaller
+     * wrong than silently editing someone's promotional copy. The honest fix for
+     * the wording is the admin changing it — which `close-remaining-surfaces.mjs`
+     * now does for the live document.
+     */
+    const announcementLink = isClosedHref(siteSettings?.announcementBar?.link, closedSurfaces)
+        ? undefined
+        : siteSettings?.announcementBar?.link;
     // A homepage section must not advertise a listing type the site does not
     // offer. This gate previously read `featureFlags.{auctions,preOrders,events,
     // blog}`; that group was deleted on 2026-08-29, and only the listing-type
@@ -132,7 +178,7 @@ export async function MarketplaceHomepageView({ adSlots, newsletterFormSlot, onB
     // no product control for "we don't run events", and there never was one that
     // anything but this line read. Those are switched off per-document instead
     // (`enabled: false`), which is the only lever they have.
-    const enabledSections = allSections.filter((section) => {
+    const typeGatedSections = allSections.filter((section) => {
         const type = section.type;
         const gatedListing = HOMEPAGE_SECTION_LISTING_TYPE[type];
         if (gatedListing && !isListingTypeEnabled(gatedListing, siteSettings))
@@ -145,6 +191,22 @@ export async function MarketplaceHomepageView({ adSlots, newsletterFormSlot, onB
             return false;
         return true;
     });
+    /*
+     * The FOURTH gate, and the only one that can see authored content.
+     *
+     * 🛑 All three maps above are keyed on `SectionType`, so none of them can
+     * say anything about a `custom-cards` / `promo-grid` / `banner` / `welcome`
+     * section — one generic type whose only tie to a surface is where its
+     * buttons point. Measured on the live homepage 2026-10-27, that blind spot
+     * was shipping **34 links to the closed `/categories` section** and **3 each
+     * to `/art` and `/spares`, both of which already answered a real 404**, from
+     * four sections the gates above had no opinion about.
+     *
+     * Runs AFTER the type gates, not instead of them: a section the type gate
+     * already dropped must not be walked at all, and the type gates remain the
+     * right answer for a section that IS a surface.
+     */
+    const enabledSections = gateHomepageSections(typeGatedSections, closedSurfaces);
     // Collect live metric requests from all enabled stats sections
     const liveStatRequests = [];
     for (const section of enabledSections) {
@@ -278,6 +340,6 @@ export async function MarketplaceHomepageView({ adSlots, newsletterFormSlot, onB
      * type, so a keyword scan would miss the worse of the two offenders while
      * eating innocent ones. See `slide-gating.ts`.
      */
-    const carouselSlides = gateCarouselSlides(toCarouselSlides(slides), siteSettings);
-    return (_jsx(Main, { children: _jsxs(Div, { className: "relative", children: [showAnnouncement ? (_jsx(TopBannerPortal, { children: _jsx(AnnouncementBar, { message: announcementMessage, link: siteSettings?.announcementBar?.link, onDismiss: onBannerDismiss }) })) : null, orderedSections.map((section) => renderSection(section, adSlots, newsletterFormSlot ?? null, faqItems, carouselSlides, liveStats, sectionData, brand))] }) }));
+    const carouselSlides = gateCarouselSlides(toCarouselSlides(slides), closedSurfaces);
+    return (_jsx(Main, { children: _jsxs(Div, { className: "relative", children: [showAnnouncement ? (_jsx(TopBannerPortal, { children: _jsx(AnnouncementBar, { message: announcementMessage, link: announcementLink, onDismiss: onBannerDismiss }) })) : null, orderedSections.map((section) => renderSection(section, adSlots, newsletterFormSlot ?? null, faqItems, carouselSlides, liveStats, sectionData, brand))] }) }));
 }

package/dist/features/homepage/lib/section-gating.d.ts

@@ -0,0 +1,84 @@
+/**
+ * Homepage SECTION-CONFIG gating — strip authored links that point at a closed
+ * surface, and drop whatever is left with nothing to say.
+ *
+ * ## The gap this closes
+ *
+ * `MarketplaceHomepageView` has three section gates and they are all keyed on
+ * `SectionType`: `HOMEPAGE_SECTION_LISTING_TYPE`,
+ * `HOMEPAGE_SECTION_CATEGORY_TYPE`, `HOMEPAGE_SECTION_BROWSE_PAGE`. They work,
+ * and they are enough for a section that IS a surface — the auctions rail, the
+ * categories rail, the stores rail.
+ *
+ * They cannot see a `custom-cards`, `promo-grid`, `banner`, `welcome` or
+ * `collection-cards` section, because those are one generic type holding
+ * admin-authored content whose only tie to a surface is where its buttons
+ * point. `gateCarouselSlides` is the same realisation for the `carousel` type;
+ * this is the rest of the homepage.
+ *
+ * ## 🛑 Measured on the live homepage, 2026-10-27
+ *
+ * With all four browse pages closed since 2026-10-24, and `art`/`spares`
+ * auto-hidden at count 0 (both already answering a real 404 at the edge), a
+ * production fetch of `/` carried:
+ *
+ * | links | to | state |
+ * |---|---|---|
+ * | **34** | `/categories` + `/categories/{slug}` | section closed |
+ * | 3 | `/art` | **404** |
+ * | 3 | `/spares` | **404** |
+ *
+ * Three ungated sections produced all of it: `section-welcome-hero`
+ * (`secondaryCtaLink`), `section-systems-matrix` (35 category buttons across 4
+ * cards) and `section-generation-promos` (4 category banners). Plus
+ * `section-shop-extras`, whose three cards pointed at `/art`, `/spares` and
+ * `/bundles`.
+ *
+ * A rail that advertises a closed door is worse than an absent rail: the
+ * visitor spends a click to find out, and a crawler spends budget.
+ *
+ * ## The three rules, in order
+ *
+ * 1. **A closed link is removed.** Button, banner, CTA — whatever carries it.
+ * 2. **A container whose links were ALL closed is removed.** A card or banner
+ *    with its CTAs stripped is a picture with no destination; it reads as a
+ *    broken tile, not as a tidied one.
+ * 3. **A section left with no linked content is removed.** This is rule 2 one
+ *    level up, and it is what turns the systems matrix (every one of its 35
+ *    buttons closed) from "four empty cards" into "not rendered".
+ *
+ * 🛑 Rule 3 applies ONLY to sections whose content IS the links. A `welcome`
+ * hero that loses its secondary CTA keeps its heading, its copy and its
+ * primary CTA to `/products`, and must still render — dropping it would blank
+ * the top of the homepage because one of its two buttons was withdrawn. That
+ * is why `LINK_BEARING_SECTIONS` is an explicit allow-list keyed on
+ * `SectionType` rather than "any section with no links left".
+ *
+ * ## Fails OPEN throughout
+ *
+ * Every decision runs through `isClosedHref`, which classifies nothing when
+ * the settings document is missing. A transient Firestore error therefore
+ * leaves the homepage exactly as authored rather than stripping it to the
+ * studs — the same direction as every other gate on this page (Root Cause
+ * #72).
+ *
+ * @tag domain:homepage
+ * @tag layer:shared
+ * @tag access:isomorphic
+ * @tag sideEffects:none
+ */
+import { type ClosedSurfaceContext } from "../../../_internal/shared/listing-types/route-gating";
+import type { HomepageSectionDocument } from "../schemas/firestore";
+/**
+ * Strip closed destinations from one section, or return `null` to drop it.
+ *
+ * Exported for the audit and for direct use; `gateHomepageSections` is the
+ * normal entry point.
+ */
+export declare function gateHomepageSection<T extends HomepageSectionDocument>(section: T, ctx: ClosedSurfaceContext): T | null;
+/**
+ * Apply `gateHomepageSection` across an ordered section list.
+ *
+ * Returns a new array; input is not mutated.
+ */
+export declare function gateHomepageSections<T extends HomepageSectionDocument>(sections: readonly T[], ctx: ClosedSurfaceContext): T[];

package/dist/features/homepage/lib/section-gating.js

@@ -0,0 +1,224 @@
+/**
+ * Homepage SECTION-CONFIG gating — strip authored links that point at a closed
+ * surface, and drop whatever is left with nothing to say.
+ *
+ * ## The gap this closes
+ *
+ * `MarketplaceHomepageView` has three section gates and they are all keyed on
+ * `SectionType`: `HOMEPAGE_SECTION_LISTING_TYPE`,
+ * `HOMEPAGE_SECTION_CATEGORY_TYPE`, `HOMEPAGE_SECTION_BROWSE_PAGE`. They work,
+ * and they are enough for a section that IS a surface — the auctions rail, the
+ * categories rail, the stores rail.
+ *
+ * They cannot see a `custom-cards`, `promo-grid`, `banner`, `welcome` or
+ * `collection-cards` section, because those are one generic type holding
+ * admin-authored content whose only tie to a surface is where its buttons
+ * point. `gateCarouselSlides` is the same realisation for the `carousel` type;
+ * this is the rest of the homepage.
+ *
+ * ## 🛑 Measured on the live homepage, 2026-10-27
+ *
+ * With all four browse pages closed since 2026-10-24, and `art`/`spares`
+ * auto-hidden at count 0 (both already answering a real 404 at the edge), a
+ * production fetch of `/` carried:
+ *
+ * | links | to | state |
+ * |---|---|---|
+ * | **34** | `/categories` + `/categories/{slug}` | section closed |
+ * | 3 | `/art` | **404** |
+ * | 3 | `/spares` | **404** |
+ *
+ * Three ungated sections produced all of it: `section-welcome-hero`
+ * (`secondaryCtaLink`), `section-systems-matrix` (35 category buttons across 4
+ * cards) and `section-generation-promos` (4 category banners). Plus
+ * `section-shop-extras`, whose three cards pointed at `/art`, `/spares` and
+ * `/bundles`.
+ *
+ * A rail that advertises a closed door is worse than an absent rail: the
+ * visitor spends a click to find out, and a crawler spends budget.
+ *
+ * ## The three rules, in order
+ *
+ * 1. **A closed link is removed.** Button, banner, CTA — whatever carries it.
+ * 2. **A container whose links were ALL closed is removed.** A card or banner
+ *    with its CTAs stripped is a picture with no destination; it reads as a
+ *    broken tile, not as a tidied one.
+ * 3. **A section left with no linked content is removed.** This is rule 2 one
+ *    level up, and it is what turns the systems matrix (every one of its 35
+ *    buttons closed) from "four empty cards" into "not rendered".
+ *
+ * 🛑 Rule 3 applies ONLY to sections whose content IS the links. A `welcome`
+ * hero that loses its secondary CTA keeps its heading, its copy and its
+ * primary CTA to `/products`, and must still render — dropping it would blank
+ * the top of the homepage because one of its two buttons was withdrawn. That
+ * is why `LINK_BEARING_SECTIONS` is an explicit allow-list keyed on
+ * `SectionType` rather than "any section with no links left".
+ *
+ * ## Fails OPEN throughout
+ *
+ * Every decision runs through `isClosedHref`, which classifies nothing when
+ * the settings document is missing. A transient Firestore error therefore
+ * leaves the homepage exactly as authored rather than stripping it to the
+ * studs — the same direction as every other gate on this page (Root Cause
+ * #72).
+ *
+ * @tag domain:homepage
+ * @tag layer:shared
+ * @tag access:isomorphic
+ * @tag sideEffects:none
+ */
+import { isClosedHref, } from "../../../_internal/shared/listing-types/route-gating.js";
+/**
+ * Section types whose entire substance is a set of linked tiles, and which are
+ * therefore meaningless once every link is gone.
+ *
+ * 🛑 An explicit allow-list, not a heuristic. `welcome`, `banner` and
+ * `newsletter` all carry links AND standalone copy — a `welcome` hero stripped
+ * of its secondary CTA still has an h1, a description and a primary CTA, so
+ * "no links left" must not drop it. Getting this backwards blanks the top of
+ * the homepage.
+ *
+ * Keyed on `SectionType` so an unlisted type is never dropped by rule 3,
+ * which is the safe default: a section that survives with a missing button is
+ * a visible prompt to go and fix the content, while a section wrongly removed
+ * is invisible.
+ */
+const LINK_BEARING_SECTIONS = new Set([
+    "custom-cards",
+    "promo-grid",
+    "collection-cards",
+]);
+/**
+ * Config keys that hold a single destination, paired with the sibling key that
+ * labels it.
+ *
+ * Both are cleared together: a `secondaryCtaText` with no `secondaryCtaLink`
+ * renders a button that goes nowhere, which is strictly worse than no button.
+ * `banner`/`features` CTAs use `link`, `welcome`/`how-it-works` use
+ * `ctaLink` — all three spellings are live in the seeded configs.
+ */
+const SCALAR_CTA_KEYS = [
+    ["ctaLink", "ctaText"],
+    ["secondaryCtaLink", "secondaryCtaText"],
+    ["learnMoreLink", "learnMoreLabel"],
+    ["ctaUrl", "ctaLabel"],
+];
+/** Keys whose value is an array of `{ href | link | ctaUrl }` objects. */
+const LINK_ARRAY_KEYS = ["buttons", "banners", "cards", "collections", "links", "items"];
+function isDict(v) {
+    return typeof v === "object" && v !== null && !Array.isArray(v);
+}
+/** Every destination spelling an authored object may carry. */
+function destinationOf(node) {
+    for (const key of ["href", "link", "url", "ctaUrl", "ctaLink"]) {
+        const v = node[key];
+        if (typeof v === "string" && v.length > 0)
+            return v;
+    }
+    return undefined;
+}
+/**
+ * Recursively prune closed destinations out of one config value.
+ *
+ * Returns `{ value, hadLinks, keptLinks }` so a caller can tell "this subtree
+ * never advertised anything" from "this subtree advertised only closed
+ * things" — the distinction rules 2 and 3 both turn on, and the one a bare
+ * emptiness test gets wrong. `[].every()` is `true`, so an image-only card
+ * would otherwise be dropped for having no surviving links when it never had
+ * any (the same trap `isCardDisabled` documents in `slide-gating`).
+ */
+function prune(node, ctx) {
+    if (Array.isArray(node)) {
+        let hadLinks = 0;
+        let keptLinks = 0;
+        const out = [];
+        for (const item of node) {
+            const r = prune(item, ctx);
+            hadLinks += r.hadLinks;
+            // Rule 2: a container that advertised only closed destinations goes.
+            if (r.hadLinks > 0 && r.keptLinks === 0)
+                continue;
+            keptLinks += r.keptLinks;
+            out.push(r.value);
+        }
+        return { value: out, hadLinks, keptLinks };
+    }
+    if (!isDict(node))
+        return { value: node, hadLinks: 0, keptLinks: 0 };
+    const out = { ...node };
+    let hadLinks = 0;
+    let keptLinks = 0;
+    // This object's own destination, if it has one.
+    const own = destinationOf(node);
+    if (own !== undefined) {
+        hadLinks += 1;
+        if (isClosedHref(own, ctx)) {
+            for (const key of ["href", "link", "url", "ctaUrl", "ctaLink"])
+                delete out[key];
+        }
+        else {
+            keptLinks += 1;
+        }
+    }
+    // Scalar CTA pairs — cleared with their labels.
+    for (const [linkKey, labelKey] of SCALAR_CTA_KEYS) {
+        const v = node[linkKey];
+        if (typeof v !== "string" || v.length === 0)
+            continue;
+        // Already counted above when it doubled as this object's own destination.
+        const alreadyCounted = own === v;
+        if (!alreadyCounted)
+            hadLinks += 1;
+        if (isClosedHref(v, ctx)) {
+            delete out[linkKey];
+            delete out[labelKey];
+        }
+        else if (!alreadyCounted) {
+            keptLinks += 1;
+        }
+    }
+    // Nested link-bearing arrays.
+    for (const key of LINK_ARRAY_KEYS) {
+        if (!Array.isArray(node[key]))
+            continue;
+        const r = prune(node[key], ctx);
+        out[key] = r.value;
+        hadLinks += r.hadLinks;
+        keptLinks += r.keptLinks;
+    }
+    return { value: out, hadLinks, keptLinks };
+}
+/**
+ * Strip closed destinations from one section, or return `null` to drop it.
+ *
+ * Exported for the audit and for direct use; `gateHomepageSections` is the
+ * normal entry point.
+ */
+export function gateHomepageSection(section, ctx) {
+    const { value, hadLinks, keptLinks } = prune(section.config, ctx);
+    // Rule 3: a section whose whole substance is links, left with none.
+    if (LINK_BEARING_SECTIONS.has(section.type) &&
+        hadLinks > 0 &&
+        keptLinks === 0) {
+        return null;
+    }
+    // Nothing was pruned — return the original object so React sees a stable
+    // reference and the common case allocates nothing.
+    if (hadLinks === keptLinks)
+        return section;
+    return { ...section, config: value };
+}
+/**
+ * Apply `gateHomepageSection` across an ordered section list.
+ *
+ * Returns a new array; input is not mutated.
+ */
+export function gateHomepageSections(sections, ctx) {
+    const kept = [];
+    for (const section of sections) {
+        const gated = gateHomepageSection(section, ctx);
+        if (gated !== null)
+            kept.push(gated);
+    }
+    return kept;
+}

package/dist/features/homepage/lib/slide-gating.d.ts

@@ -1,6 +1,12 @@
 /**
- * Carousel gating — strip slides and cards that advertise a disabled listing
- * type.
+ * Carousel gating — strip slides and cards that advertise a CLOSED surface.
+ *
+ * 🛑 "closed surface", not "disabled listing type". This read the listing-type
+ * flags alone until 2026-10-27, and the two axes it could not see were the two
+ * doing visible damage: a type auto-hidden for being empty (`/art`, `/spares`
+ * — both answering a real 404 while the homepage linked to them), and a closed
+ * browse section (`/categories`, linked 34 times from the live homepage).
+ * `isClosedHref` owns all three axes now; see its docstring.
  *
  * ## The gap this closes
  *
@@ -33,20 +39,14 @@
  * this filter to tidy up after it — this is the safety net for content an
  * admin authors later, where the gap is a visible prompt to go and fix it.
  */
+import { type ClosedSurfaceContext } from "../../../_internal/shared/listing-types/route-gating";
 import type { CarouselSlide } from "../types/index";
-import type { ListingType } from "../../products/types/index";
-interface ListingFlagSnapshot {
-    listings?: {
-        listingTypes?: Partial<Record<ListingType, boolean>>;
-    };
-}
 /**
- * Filter a slide list for the current listing-type flags.
+ * Filter a slide list against the surfaces this site currently has open.
  *
  * Returns a new array; input is not mutated. Fails OPEN — with no settings
- * document every `isListingTypeEnabled` call returns `true` and nothing is
- * removed, which is the right failure for a read that errored (Root Cause
- * #72: an unknown must never be read as "zero").
+ * document `isClosedHref` classifies nothing and nothing is removed, which is
+ * the right failure for a read that errored (Root Cause #72: an unknown must
+ * never be read as "zero").
  */
-export declare function gateCarouselSlides<T extends CarouselSlide>(slides: readonly T[], settings: ListingFlagSnapshot | null | undefined): T[];
-export {};
+export declare function gateCarouselSlides<T extends CarouselSlide>(slides: readonly T[], ctx: ClosedSurfaceContext): T[];

package/dist/features/homepage/lib/slide-gating.js

@@ -1,6 +1,12 @@
 /**
- * Carousel gating — strip slides and cards that advertise a disabled listing
- * type.
+ * Carousel gating — strip slides and cards that advertise a CLOSED surface.
+ *
+ * 🛑 "closed surface", not "disabled listing type". This read the listing-type
+ * flags alone until 2026-10-27, and the two axes it could not see were the two
+ * doing visible damage: a type auto-hidden for being empty (`/art`, `/spares`
+ * — both answering a real 404 while the homepage linked to them), and a closed
+ * browse section (`/categories`, linked 34 times from the live homepage).
+ * `isClosedHref` owns all three axes now; see its docstring.
  *
  * ## The gap this closes
  *
@@ -33,7 +39,7 @@
  * this filter to tidy up after it — this is the safety net for content an
  * admin authors later, where the gap is a visible prompt to go and fix it.
  */
-import { isDisabledListingHref } from "../../../_internal/shared/listing-types/route-gating.js";
+import { isClosedHref, } from "../../../_internal/shared/listing-types/route-gating.js";
 /**
  * Every destination a card offers. A card with no buttons is still clickable
  * through nothing — it has no link of its own — so it is never gated.
@@ -50,11 +56,11 @@ function cardHrefs(card) {
  * That is why the length check is separate rather than folded in — an
  * image-only card advertises no type and must survive.
  */
-function isCardDisabled(card, settings) {
+function isCardDisabled(card, ctx) {
     const hrefs = cardHrefs(card);
     if (hrefs.length === 0)
         return false;
-    return hrefs.every((href) => isDisabledListingHref(href, settings));
+    return hrefs.every((href) => isClosedHref(href, ctx));
 }
 /**
  * A slide is dropped when the thing it is ABOUT is disabled — its overlay CTA
@@ -64,27 +70,27 @@ function isCardDisabled(card, settings) {
  * slide carries `overlay.button.link` AND `link.url`, while a slide can
  * legitimately have only one.
  */
-function isSlideDisabled(slide, settings) {
-    if (isDisabledListingHref(slide.overlay?.button?.link, settings))
+function isSlideDisabled(slide, ctx) {
+    if (isClosedHref(slide.overlay?.button?.link, ctx))
         return true;
-    if (isDisabledListingHref(slide.link?.url, settings))
+    if (isClosedHref(slide.link?.url, ctx))
         return true;
     return false;
 }
 /**
- * Filter a slide list for the current listing-type flags.
+ * Filter a slide list against the surfaces this site currently has open.
  *
  * Returns a new array; input is not mutated. Fails OPEN — with no settings
- * document every `isListingTypeEnabled` call returns `true` and nothing is
- * removed, which is the right failure for a read that errored (Root Cause
- * #72: an unknown must never be read as "zero").
+ * document `isClosedHref` classifies nothing and nothing is removed, which is
+ * the right failure for a read that errored (Root Cause #72: an unknown must
+ * never be read as "zero").
  */
-export function gateCarouselSlides(slides, settings) {
+export function gateCarouselSlides(slides, ctx) {
     const kept = [];
     for (const slide of slides) {
-        if (isSlideDisabled(slide, settings))
+        if (isSlideDisabled(slide, ctx))
             continue;
-        const cards = (slide.cards ?? []).filter((card) => !isCardDisabled(card, settings));
+        const cards = (slide.cards ?? []).filter((card) => !isCardDisabled(card, ctx));
         const hadCards = (slide.cards ?? []).length > 0;
         // A cards-slide that lost ALL its cards renders as a bare background with
         // no copy and no call to action — the exact "renders blank" failure the

package/dist/features/products/components/CardStoreLine.js

@@ -2,6 +2,7 @@
 import { jsxs as _jsxs } from "react/jsx-runtime";
 import { Text } from "../../../ui/components/Typography.js";
 import { safeDisplayName } from "../../../security/pii-redact.js";
+import { useBrowsePageFlags } from "../../../react/hooks/useBrowsePageFlags.js";
 /**
  * `store-beyblade-arena` → `Beyblade Arena`.
  *
@@ -24,6 +25,28 @@ function humanizeStoreSlug(slug) {
         .join(" ");
 }
 export function CardStoreLine({ storeName, storeId, className }) {
+    /*
+     * 🛑 A SELLER BYLINE IS MARKETPLACE CHROME — silent on a single-vendor shop.
+     *
+     * "by LetItRip Official" repeated under every card tells a buyer nothing
+     * when there is only one seller: it is the same six words on every tile,
+     * costing a line of vertical space on all six card variants and implying a
+     * choice that does not exist.
+     *
+     * Keyed on whether the STORE DIRECTORY is open, the same question the
+     * product page's "Sold by" block asks, so the two cannot disagree. This
+     * hook is the client-side reader of that flag (a card is `"use client"`, so
+     * it cannot take the server's settings read).
+     *
+     * 🛑 Fails OPEN while settings load — `useBrowsePageFlags` defaults every
+     * section to open, so a cold paint shows the byline and then removes it
+     * rather than flashing it in. That is the right direction for a marketplace
+     * that still has one; the alternative hides a real seller on every cold
+     * load. Root Cause #72.
+     */
+    const browsePages = useBrowsePageFlags();
+    if (!browsePages.isEnabled("stores"))
+        return null;
     if (!storeId && !storeName)
         return null;
     // `safeDisplayName` also guards the encrypted-value case: a PII-ciphertext

package/dist/features/products/components/ProductDetailPageView.js

@@ -63,6 +63,7 @@ import { getGroupsWithItemsForProduct } from "../../../_internal/server/features
 import { getSiteSettingsGlobal } from "../../admin/utils/getSiteSettingsGlobal.js";
 import { safeRead } from "../../../errors/safe-read.js";
 import { canMakeOffer } from "../../../_internal/shared/listing-types/capabilities.js";
+import { closedSurfaceContext, isClosedHref, } from "../../../_internal/shared/listing-types/route-gating.js";
 import { MessageSellerButton } from "../../messages/components/MessageSellerButton.js";
 import { normalizeListingType } from "../utils/listing-type.js";
 import { DEFAULT_MIN_OFFER_PERCENT, resolveOfferBounds, } from "../../../_internal/shared/features/offers/config.js";
@@ -348,6 +349,32 @@ export async function ProductDetailPageView({ slug, initialProduct, renderOfferA
             : Promise.resolve(null),
     ]);
     const { relatedItems, relatedByBrand, relatedByTags, relatedByStore } = related;
+    /*
+     * 🛑 SELLER IDENTITY IS MARKETPLACE CHROME, and it is wrong on a
+     * single-vendor storefront.
+     *
+     * "Sold by LetItRip Official", a "Visit Store →" button and a "Message
+     * seller" control only mean something when there is more than one seller to
+     * choose between. With `listings.browsePages.stores` closed there is one
+     * vendor, the store page 404s, and the block is a link into a shut door
+     * sitting beside the Buy button.
+     *
+     * Keyed on whether the STORE PAGE is reachable rather than on a new flag of
+     * its own: that is the same question, already answered, and a second switch
+     * is how two controls come to disagree (Root Cause #42). `storeHref` is
+     * `/stores/{slug}`, so `isClosedHref` resolves it through exactly the rule
+     * the nav, footer, sitemap and edge gate all use.
+     *
+     * `counts` is `undefined` on purpose — a browse-page closure is a flag, not
+     * a measurement, so there is nothing for the rollup to contribute here.
+     *
+     * 🛑 Hides the identity, NOT the data. `storeId` still reaches the cart, the
+     * order splitter and the payout path untouched; only the buyer-facing
+     * attribution is withdrawn. Nothing about how an order is routed changes.
+     */
+    const sellerIdentityVisible = !isClosedHref(storeHref, closedSurfaceContext(siteSettings, undefined));
+    const sellerName = sellerIdentityVisible ? safeSeller : null;
+    const sellerHref = sellerIdentityVisible ? storeHref : null;
     return (_jsxs(Main, { children: [_jsx(HistoryTracker, { productId: product.id, productType: "product", snapshot: {
                     title: product.title,
                     /*
@@ -404,9 +431,9 @@ export async function ProductDetailPageView({ slug, initialProduct, renderOfferA
                                         emiAvailable: "EMI Available",
                                         wishlistCount: (n) => `${n} wishlisted`,
                                         categoryProductCount: (n, cat) => `${n} in ${cat}`,
-                                    } }), productFeatures && features.length > 0 && (_jsx(FeatureBadgeList, { productFeatureIds: features, features: productFeatures })), !productFeatures && features.length > 0 && (_jsxs(Div, { border: "subtle", surface: "muted", padding: "inline", rounded: "xl", children: [_jsx(Text, { className: "mb-2 tracking-wide", color: "muted", size: "xs", weight: "semibold", transform: "uppercase", children: "About this product" }), _jsx(Ul, { spacing: "comfortable", size: "sm", color: "primary", children: features.map((f, i) => (_jsxs(Li, { layout: "flex-start", gap: "2", children: [_jsx(Span, { className: "mt-0.5 flex-shrink-0 text-primary-500", children: "\u2022" }), f] }, i))) })] })), descriptionHtml && (_jsx(RichText, { html: descriptionHtml, proseClass: "prose prose-sm max-w-none dark:prose-invert prose-p:my-0", className: "text-[length:var(--appkit-text-sm)] leading-relaxed text-[var(--appkit-color-text-muted)] line-clamp-4" })), safeSeller && (_jsx(Div, { className: `${__P.p3}`, border: "subtle", rounded: "xl", surface: "muted", children: _jsxs(Row, { justify: "between", align: "center", children: [_jsxs(Div, { children: [_jsx(Text, { className: "text-[10px] tracking-wide mb-0.5", color: "faint", transform: "uppercase", children: "Sold by" }), _jsx(Text, { size: "sm", weight: "semibold", color: "primary", children: safeSeller }), typeof p.storeRating === "number" && p.storeRating > 0 && (_jsx(Row, { gap: "xs", align: "center", className: "mt-0.5", children: _jsxs(Text, { size: "xs", color: "muted", children: [_jsx(Span, { className: "text-warning", "aria-hidden": "true", children: "\u2605" }), " ", p.storeRating.toFixed(1), typeof p.storeReviewCount === "number" &&
+                                    } }), productFeatures && features.length > 0 && (_jsx(FeatureBadgeList, { productFeatureIds: features, features: productFeatures })), !productFeatures && features.length > 0 && (_jsxs(Div, { border: "subtle", surface: "muted", padding: "inline", rounded: "xl", children: [_jsx(Text, { className: "mb-2 tracking-wide", color: "muted", size: "xs", weight: "semibold", transform: "uppercase", children: "About this product" }), _jsx(Ul, { spacing: "comfortable", size: "sm", color: "primary", children: features.map((f, i) => (_jsxs(Li, { layout: "flex-start", gap: "2", children: [_jsx(Span, { className: "mt-0.5 flex-shrink-0 text-primary-500", children: "\u2022" }), f] }, i))) })] })), descriptionHtml && (_jsx(RichText, { html: descriptionHtml, proseClass: "prose prose-sm max-w-none dark:prose-invert prose-p:my-0", className: "text-[length:var(--appkit-text-sm)] leading-relaxed text-[var(--appkit-color-text-muted)] line-clamp-4" })), sellerName && (_jsx(Div, { className: `${__P.p3}`, border: "subtle", rounded: "xl", surface: "muted", children: _jsxs(Row, { justify: "between", align: "center", children: [_jsxs(Div, { children: [_jsx(Text, { className: "text-[10px] tracking-wide mb-0.5", color: "faint", transform: "uppercase", children: "Sold by" }), _jsx(Text, { size: "sm", weight: "semibold", color: "primary", children: sellerName }), typeof p.storeRating === "number" && p.storeRating > 0 && (_jsx(Row, { gap: "xs", align: "center", className: "mt-0.5", children: _jsxs(Text, { size: "xs", color: "muted", children: [_jsx(Span, { className: "text-warning", "aria-hidden": "true", children: "\u2605" }), " ", p.storeRating.toFixed(1), typeof p.storeReviewCount === "number" &&
                                                                     p.storeReviewCount > 0 &&
-                                                                    ` · ${p.storeReviewCount} reviews`] }) }))] }), _jsxs(Row, { gap: "xs", align: "center", className: "shrink-0", children: [storeId && _jsx(MessageSellerButton, { storeId: storeId, productId: product.id }), storeHref && (_jsx(Link, { href: storeHref, className: "rounded-lg bg-primary/10 dark:bg-primary/20 px-[var(--appkit-space-3)] py-[var(--appkit-space-1-5)] text-[length:var(--appkit-text-xs)] font-semibold text-primary-700 dark:text-primary-300 hover:bg-primary/20 dark:hover:bg-primary/30 transition-colors", children: "Visit Store \u2192" }))] })] }) }))] })), renderActions: () => (_jsxs(Stack, { className: `${__P.p5}`, border: "subtle", gap: "md", rounded: "xl", surface: "muted", children: [price !== null && (_jsxs(Div, { children: [_jsx(PriceDisplay, { amount: price, originalAmount: originalPrice ?? undefined, currency: currency, variant: "detail" }), siteSettings?.gst?.enabled === true &&
+                                                                    ` · ${p.storeReviewCount} reviews`] }) }))] }), _jsxs(Row, { gap: "xs", align: "center", className: "shrink-0", children: [sellerName && storeId && (_jsx(MessageSellerButton, { storeId: storeId, productId: product.id })), sellerHref && (_jsx(Link, { href: sellerHref, className: "rounded-lg bg-primary/10 dark:bg-primary/20 px-[var(--appkit-space-3)] py-[var(--appkit-space-1-5)] text-[length:var(--appkit-text-xs)] font-semibold text-primary-700 dark:text-primary-300 hover:bg-primary/20 dark:hover:bg-primary/30 transition-colors", children: "Visit Store \u2192" }))] })] }) }))] })), renderActions: () => (_jsxs(Stack, { className: `${__P.p5}`, border: "subtle", gap: "md", rounded: "xl", surface: "muted", children: [price !== null && (_jsxs(Div, { children: [_jsx(PriceDisplay, { amount: price, originalAmount: originalPrice ?? undefined, currency: currency, variant: "detail" }), siteSettings?.gst?.enabled === true &&
                                             typeof p.gstRate === "number" &&
                                             p.gstRate > 0 && (_jsxs(Text, { size: "xs", color: "muted", children: ["Incl. ", p.gstRate, "% GST"] })), _jsx(MarketPriceAnchor, { band: priceBand?.byListingType?.[normalizeListingType(p)] ?? null, windowDays: priceBand?.windowDays ?? null, currency: currency, price: price }), inStock && effectiveStock !== null && effectiveStock <= 3 && (_jsxs(Text, { className: "mt-1 text-warning", size: "xs", children: ["Only ", effectiveStock, " left \u2014 order soon!"] })), inStock && effectiveStock !== null && effectiveStock > 3 && effectiveStock <= 10 && (_jsxs(Text, { className: "mt-1", color: "muted", size: "xs", children: [effectiveStock, " in stock"] })), madeToOrder && (_jsx(Text, { className: "mt-1", color: "muted", size: "xs", children: "Made to order \u2014 printed when you order, so it never runs out." })), partHref && (_jsxs(Text, { className: "mt-1", color: "muted", size: "xs", children: [partSlotLabel ?? "Part", ".", " ", _jsx(Link, { href: partHref, className: "text-primary-600 hover:underline", children: "See what else fits \u2192" }), fitsModels.length > 0 && (_jsxs(_Fragment, { children: [" ", "Fits:", " ", fitsModels.slice(0, 6).map((m, i) => (_jsxs(Text, { as: "span", children: [i > 0 ? ", " : "", m.categoryId ? (_jsx(Link, { href: String(ROUTES.PUBLIC.CATEGORY_DETAIL(m.categoryId)), className: "text-primary-600 hover:underline", children: m.name })) : (m.name)] }, m.id)))] }))] }))] })), _jsxs(Stack, { gap: "sm", ...ctaAnchorProps(), children: [renderPrimaryActions ? (renderPrimaryActions({
                                             productId: product.id,
@@ -443,7 +470,7 @@ export async function ProductDetailPageView({ slug, initialProduct, renderOfferA
                             ? () => (_jsx(ShowGroupSection, { groupId: groupId, currentSlug: String(p.slug ?? product.id), isParent: isGroupParent, groupTitle: groupTitle }))
                             : undefined, renderTabs: () => (_jsx(ProductTabsShell, { partsContent: compositionContent, descriptionContent: descriptionHtml ? (_jsx(RichText, { html: descriptionHtml, proseClass: "prose prose-sm sm:prose max-w-none dark:prose-invert", className: "text-[var(--appkit-color-text-muted)]" })) : undefined, specsContent: allSpecs.length > 0 ? (_jsx(SpecTable, { rows: allSpecs })) : undefined, ingredientsContent: ingredients.length > 0 ? (_jsx(Ul, { spacing: "comfortable", children: ingredients.map((item, i) => (_jsxs(Li, { layout: "flex-start", gap: "2", children: [_jsx(Span, { className: "mt-1 flex-shrink-0 h-1.5 w-1.5 bg-primary-400", rounded: "full" }), item] }, i))) })) : undefined, howToUseContent: howToUse.length > 0 ? (_jsx(Ol, { spacing: "loose", children: howToUse.map((step, i) => (_jsxs(Li, { layout: "flex-start", gap: "3", textSize: "sm", color: "muted", children: [_jsx(Span, { layout: "flex-center", size: "xs", weight: "bold", className: "flex-shrink-0 h-6 w-6 bg-primary-100 dark:bg-primary-900/30 text-primary-700 dark:text-primary-300", rounded: "full", children: i + 1 }), step] }, i))) })) : undefined, reviewsContent: _jsxs(Stack, { gap: "md", children: [_jsx(PurchaseReviewAffordance, { productId: String(product.id), storeId: product.storeId ? String(product.storeId) : undefined }), _jsx(ReviewsListingPanel, { source: { kind: "product", productId: product.id }, stateMode: "local", context: "listing", initialData: initialReviews, emptyLabel: "No reviews yet \u2014 be the first to review this product." })] }), customTabs: toCustomSectionTabs(p.customSections) })), renderBundleSection: bundleMemberships.length > 0
                             ? () => (_jsxs(Div, { className: CLS_BUNDLE_BOX, children: [_jsxs(Row, { className: "mb-3", align: "center", gap: "sm", children: [_jsx(Span, { size: "base", className: CLS_BUNDLE_ICON, "aria-hidden": "true", children: "\uD83D\uDCE6" }), _jsxs(Text, { className: CLS_BUNDLE_TITLE, children: ["Part of ", bundleMemberships.length === 1 ? "a bundle" : `${bundleMemberships.length} bundles`] })] }), _jsx(Stack, { gap: "3", children: bundleMemberships.map((b) => (_jsxs(Div, { className: CLS_BUNDLE_ROW, children: [_jsxs(Div, { className: "min-w-0", children: [_jsx(Text, { className: CLS_BUNDLE_LABEL, children: "Included in bundle" }), _jsx(Text, { className: "truncate", color: "primary", size: "sm", weight: "semibold", children: b.title })] }), _jsx(Link, { href: String(ROUTES.PUBLIC.BUNDLE_DETAIL(b.id)), className: CLS_BUNDLE_CTA, children: "View Bundle \u2192" })] }, b.id))) })] }))
-                            : undefined, renderRelated: () => (_jsxs(Stack, { gap: "xl", children: [_jsx(GroupedListingsCarousel, { groups: groups }), _jsx(RelatedItemsSection, { relatedItems: relatedItems, relatedByBrand: relatedByBrand, relatedByTags: relatedByTags, relatedByStore: relatedByStore, categoryLabel: categoryNames[0] || categoryName || category || undefined, brandLabel: brand || undefined, storeLabel: storeName || undefined })] })) }), renderPrimaryActions
+                            : undefined, renderRelated: () => (_jsxs(Stack, { gap: "xl", children: [_jsx(GroupedListingsCarousel, { groups: groups }), _jsx(RelatedItemsSection, { relatedItems: relatedItems, relatedByBrand: relatedByBrand, relatedByTags: relatedByTags, relatedByStore: relatedByStore, categoryLabel: categoryNames[0] || categoryName || category || undefined, brandLabel: brand || undefined, storeLabel: sellerName ? storeName || undefined : undefined })] })) }), renderPrimaryActions
                         ? renderPrimaryActions({
                             productId: product.id,
                             productSlug: product.slug ?? slug,