@mohasinac/appkit 4.65.0 → 4.67.0

package/dist/features/promotions/actions/promotions-actions.js

@@ -7,6 +7,7 @@
 import { productRepository } from "../../../features/products/repository/products.repository.js";
 import { couponsRepository } from "../repository/coupons.repository.js";
 import { ProductStatusValues } from "../../../features/products/schemas/index.js";
+import { isCouponDisplayable } from "../schemas/index.js";
 /**
  * Fetch all promotions data in parallel:
  * promoted products, featured products, and active/valid coupons.
@@ -17,18 +18,33 @@ export async function getPromotions() {
         productRepository.findFeatured(),
         couponsRepository.getActiveCoupons(),
     ]);
-    const now = new Date();
+    /*
+     * `const now` lived here to feed the hand-inlined coupon validity filter
+     * below. That filter is now `isCouponDisplayable`, which takes its own clock,
+     * so the binding had no remaining reader.
+     */
     const promotedProducts = promotedRaw
         .filter((p) => p.status === ProductStatusValues.PUBLISHED)
         .slice(0, 12);
     const featuredProducts = featuredRaw
         .filter((p) => p.status === ProductStatusValues.PUBLISHED)
         .slice(0, 8);
-    const validCoupons = activeCoupons.filter((c) => {
-        const startOk = !c.validity.startDate || new Date(c.validity.startDate) <= now;
-        const endOk = !c.validity.endDate || new Date(c.validity.endDate) >= now;
-        return startOk && endOk;
-    });
+    /*
+     * 🛑 A HAND-INLINED COPY OF THE VALIDITY RULE, AND IT DISAGREED WITH THE
+     * PAGE IT FEEDS.
+     *
+     * This required `startDate <= now`, so every code published ahead of its
+     * opening date was dropped — while `/api/coupons`, which the page's own
+     * `CouponsIndexListing` fetches from client-side, has never applied that
+     * clause. The result was a page whose server half swore there were no
+     * coupons and whose client half rendered three, and a Coupons tab counted
+     * from the half that was wrong.
+     *
+     * `isCouponDisplayable` is the shared predicate — expired and inactive are
+     * still dropped, not-yet-open is kept. Root Cause #75: one money predicate,
+     * hand-written in several places, is how the copies silently diverge.
+     */
+    const validCoupons = activeCoupons.filter(isCouponDisplayable);
     return {
         promotedProducts,
         featuredProducts,

package/dist/features/promotions/components/AttachedCouponsSection.js

@@ -1,7 +1,10 @@
 "use client";
 import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
 import { useId } from "react";
-import { Badge, Div, Grid, Heading, Stack, Text } from "../../../ui/index.js";
+import { Badge } from "../../../ui/components/Badge.js";
+import { Div } from "../../../ui/components/Div.js";
+import { Grid, Stack } from "../../../ui/components/Layout.js";
+import { Heading, Text } from "../../../ui/components/Typography.js";
 import { formatCurrency } from "../../../utils/number.formatter.js";
 import { CouponCodeCopyRow } from "./CouponCodeCopyRow.js";
 /**
@@ -94,6 +97,6 @@ export function AttachedCouponsSection({ coupons, title = "Coupons", description
                      * configs the winner is decided by emission order rather than by
                      * anything readable here (Root Cause #79).
                      */
-                    return (_jsx(Div, { surface: "card", padding: "card", children: _jsxs(Stack, { gap: "sm", children: [_jsxs(Stack, { gap: "xs", children: [summary ? (_jsx(Div, { children: _jsx(Badge, { variant: "primary", children: summary }) })) : null, _jsx(Text, { weight: "semibold", children: coupon.name }), coupon.description ? (_jsx(Text, { size: "sm", color: "muted", children: coupon.description })) : null] }), _jsx(CouponCodeCopyRow, { code: coupon.code, ariaContext: coupon.name }), conditions ? (_jsx(Text, { size: "xs", color: "muted", children: conditions })) : null] }) }, coupon.id));
+                    return (_jsx(Div, { surface: "card", padding: "card", children: _jsxs(Stack, { gap: "sm", children: [_jsxs(Stack, { gap: "xs", children: [summary ? (_jsx(Div, { children: _jsx(Badge, { variant: "primary", children: summary }) })) : null, coupon.startsAt ? (_jsx(Div, { children: _jsx(Badge, { variant: "warning", children: `Opens ${new Date(coupon.startsAt).toLocaleDateString("en-IN", { day: "numeric", month: "short" })}` }) })) : null, _jsx(Text, { weight: "semibold", children: coupon.name }), coupon.description ? (_jsx(Text, { size: "sm", color: "muted", children: coupon.description })) : null] }), _jsx(CouponCodeCopyRow, { code: coupon.code, ariaContext: coupon.name }), conditions ? (_jsx(Text, { size: "xs", color: "muted", children: conditions })) : null] }) }, coupon.id));
                 }) })] }));
 }

package/dist/features/promotions/components/CouponCard.js

@@ -3,7 +3,14 @@ import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
 import { normalizeError } from "../../../errors/normalize.js";
 import { useState } from "react";
 import { Pencil, Trash2, ToggleLeft, ToggleRight } from "lucide-react";
-import { Badge, BaseListingCard, Button, ConfirmDeleteModal, Div, IconButton, Row, Span, Stack, Text } from "../../../ui/index.js";
+import { Badge } from "../../../ui/components/Badge.js";
+import { BaseListingCard } from "../../../ui/components/BaseListingCard.js";
+import { Button } from "../../../ui/components/Button.js";
+import { ConfirmDeleteModal } from "../../../ui/components/ConfirmDeleteModal.js";
+import { Div } from "../../../ui/components/Div.js";
+import { IconButton } from "../../../ui/components/IconButton.js";
+import { Row, Stack } from "../../../ui/components/Layout.js";
+import { Span, Text } from "../../../ui/components/Typography.js";
 import { useLongPress } from "../../../react/hooks/useLongPress.js";
 import { ACCOUNT_ENDPOINTS } from "../../../constants/api-endpoints.js";
 const CLS_TOGGLE_ON = "h-4 w-4 text-success dark:text-success";

package/dist/features/promotions/components/CouponCodeCopyRow.js

@@ -2,7 +2,8 @@
 import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
 import { useState } from "react";
 import { normalizeError } from "../../../errors/normalize.js";
-import { Code, Row } from "../../../ui/index.js";
+import { Code } from "../../../ui/components/Semantic.js";
+import { Row } from "../../../ui/components/Layout.js";
 import { Button } from "../../../ui/components/Button.js";
 /**
  * The code + "Copy code" row. ONE implementation, shared by `EventOfferCard`

package/dist/features/promotions/components/CouponHelpDetails.js

@@ -1,6 +1,9 @@
 "use client";
 import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
-import { Details, Summary, Stack, Text, Ul, Li, Span } from "../../../ui/index.js";
+import { Details, Summary } from "../../../ui/components/Details.js";
+import { Stack } from "../../../ui/components/Layout.js";
+import { Text, Span } from "../../../ui/components/Typography.js";
+import { Ul, Li } from "../../../ui/components/Semantic.js";
 import { COUPON_HELP } from "../constants/coupon-help.js";
 function HelpSection({ heading, items }) {
     return (_jsxs(Stack, { gap: "dense", children: [_jsx(Text, { size: "sm", weight: "semibold", children: heading }), _jsx(Ul, { marker: "disc", indent: "md", spacing: "tight", size: "sm", children: items.map((item) => (_jsx(Li, { color: "muted", children: item }, item))) })] }));

package/dist/features/promotions/components/CouponsIndexListing.js

@@ -3,7 +3,18 @@ import { jsx as _jsx, jsxs as _jsxs, Fragment as _Fragment } from "react/jsx-run
 import { useState, useCallback, useMemo } from "react";
 import { Search, SlidersHorizontal, X } from "lucide-react";
 import { useUrlTable } from "../../../react/hooks/useUrlTable.js";
-import { Button, DateInput, IconButton, Input, ListingFilterDrawer, Pagination, RadioGroup, SortDropdown, Div, Grid, Row, Span, Stack, Text, Heading, StickyToolbar } from "../../../ui/index.js";
+import { Button } from "../../../ui/components/Button.js";
+import { DateInput } from "../../../ui/components/DateInput.js";
+import { IconButton } from "../../../ui/components/IconButton.js";
+import { Input } from "../../../ui/components/Input.js";
+import { ListingFilterDrawer } from "../../../ui/components/ListingFilterDrawer.js";
+import { Pagination } from "../../../ui/components/Pagination.js";
+import { RadioGroup } from "../../../ui/components/Radio.js";
+import { SortDropdown } from "../../../ui/components/SortDropdown.js";
+import { Div } from "../../../ui/components/Div.js";
+import { Grid, Row, Stack } from "../../../ui/components/Layout.js";
+import { Span, Text, Heading } from "../../../ui/components/Typography.js";
+import { StickyToolbar } from "../../../ui/components/StickyToolbar.js";
 import { usePromotions } from "../hooks/usePromotions.js";
 import { CouponCard } from "./CouponCard.js";
 import { CouponHelpDetails } from "./CouponHelpDetails.js";

package/dist/features/promotions/components/PromotionsView.js

@@ -1,5 +1,8 @@
 import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
-import { Div, Heading, Section, Stack, Text } from "../../../ui/index.js";
+import { Div } from "../../../ui/components/Div.js";
+import { Heading, Text } from "../../../ui/components/Typography.js";
+import { Section } from "../../../ui/components/Semantic.js";
+import { Stack } from "../../../ui/components/Layout.js";
 export function PromotionsViewProductSection({ title, subtitle, renderProducts, hasProducts, }) {
     if (!hasProducts)
         return null;

package/dist/features/promotions/constants/attached-coupons.d.ts

@@ -52,4 +52,18 @@ export interface AttachedCoupon {
     minPurchase?: number;
     /** ISO string — `undefined` means no end date, NOT "expired". */
     endsAt?: string;
+    /**
+     * ISO string — when the code becomes spendable.
+     *
+     * 🛑 CARRIED SO THE CARD CAN SAY "OPENS 6 NOV". Display surfaces now keep
+     * codes that have been published ahead of their opening date
+     * (`isCouponDisplayable`), which is deliberate — the Diwali event publishes
+     * four codes weeks early so readers can save them. But showing a code with
+     * no hint that it is not yet live just relocates the lie: the reader copies
+     * it, tries it, and is refused with no explanation.
+     *
+     * Only meaningful when it is in the FUTURE. A past start date is the normal
+     * case and the renderer says nothing about it.
+     */
+    startsAt?: string;
 }

package/dist/features/promotions/repository/coupons.repository.js

@@ -8,7 +8,7 @@ import { serverLogger } from "../../../monitoring/server-logger.js";
  * Manages coupon creation, validation, and usage tracking
  */
 import { BaseRepository, prepareForFirestore, parseSieveDateValue, } from "../../../providers/db-firebase/index.js";
-import { COUPONS_COLLECTION, COUPON_FIELDS, isValidCouponCode, isCouponValid, canUserUseCoupon, calculateDiscount, createCouponId, } from "../schemas/index.js";
+import { COUPONS_COLLECTION, COUPON_FIELDS, isValidCouponCode, isCouponValid, isCouponDisplayable, canUserUseCoupon, calculateDiscount, createCouponId, } from "../schemas/index.js";
 import { ATTACHED_COUPON_MAX } from "../constants/attached-coupons.js";
 import { USER_COLLECTION } from "../../auth/schemas/index.js";
 import { DatabaseError } from "../../../errors/index.js";
@@ -126,9 +126,39 @@ export class CouponsRepository extends BaseRepository {
                 .where(COUPON_FIELDS.VALIDITY.END_DATE, ">=", now)
                 .orderBy(COUPON_FIELDS.VALIDITY.END_DATE, "asc")
                 .get();
+            /*
+             * 🛑 `isCouponDisplayable`, NOT `isCouponValid` — this line used to carry
+             * the comment "still checks startDate + usage" and that start-date check
+             * was the deepest of FOUR copies of the same rule.
+             *
+             * Both callers of this method are DISPLAY surfaces — `getPromotions()`
+             * for the promotions page and `getHomepageCoupons()` for the homepage
+             * rail. No redemption path reads it (checkout goes through
+             * `validateCouponForCart` / `canUserUseCoupon`, which apply the full
+             * `isCouponValid` themselves). So the repository was enforcing a
+             * checkout rule on behalf of two callers that never redeem anything.
+             *
+             * The effect: the Diwali event's five codes all open on Dhanteras, so
+             * every one was stripped HERE, before the callers could decide. Fixing
+             * the two call sites alone changed nothing, because the rows never
+             * reached them — Root Cause #75, one money predicate hand-written in
+             * several layers until the copies disagree.
+             *
+             * Expired, inactive and exhausted are still dropped. Only "has not
+             * opened yet" is now the caller's business.
+             *
+             * 🛑 KNOWN LATENT GAP, deliberately not changed here: the query above
+             * requires `END_DATE >= now`, and a Firestore inequality EXCLUDES every
+             * document that lacks the field (Root Cause #100). An open-ended coupon
+             * — `validity.endDate` absent, which `isCouponDisplayable` explicitly
+             * treats as "no end date, not expired" — can therefore never appear in
+             * this result at all. Every coupon in the corpus currently carries an
+             * end date, so nothing is missing today; closing it means a second
+             * query or a stored sentinel, not a tweak to this filter.
+             */
             return snapshot.docs
                 .map((doc) => this.mapDoc(doc))
-                .filter((coupon) => isCouponValid(coupon)); // still checks startDate + usage
+                .filter((coupon) => isCouponDisplayable(coupon));
         }
         catch (error) {
             void normalizeError(error);

package/dist/features/promotions/schemas/firestore.d.ts

@@ -201,6 +201,39 @@ export declare function isValidCouponCode(code: string): boolean;
 export declare function sellerCouponCodePrefix(storeSlug: string): string;
 export declare function buildSellerCouponCode(storeSlug: string, sellerCode: string): string;
 export declare function isCouponValid(coupon: CouponDocument): boolean;
+/**
+ * Is this coupon worth SHOWING to a reader? (As distinct from `isCouponValid`,
+ * which asks whether the till will honour it right now.)
+ *
+ * 🛑 THE DIFFERENCE IS ONE CLAUSE — `startDate <= now` — AND IT WAS A REAL,
+ * USER-REPORTED BUG. The Diwali event attaches four codes that open on
+ * Dhanteras. Every display surface filtered them with `isCouponValid`, so
+ * through all of October the event page rendered ONE coupon (its `offerConfig`
+ * headline, which is not filtered) where the event carries five, the homepage
+ * rail would have been empty, and the `/promotions` Coupons tab counted zero
+ * while its own client-side listing happily fetched and rendered them from
+ * `/api/coupons` — which has never applied the start-date clause.
+ *
+ * So three server surfaces disagreed with the one client surface about whether
+ * a published-ahead code exists.
+ *
+ * The event's own copy settles which side is right: *"The code is published now
+ * so you can save it ahead of time."* Publishing a code before it opens is the
+ * intended behaviour, not an accident, and a page that hides it is breaking the
+ * promise the page itself makes.
+ *
+ * 🛑 EXPIRED AND INACTIVE ARE STILL DROPPED, and that half must not be relaxed.
+ * A reader who copies a dead code does the work and is refused at the till —
+ * strictly worse than seeing nothing. "Not yet" is a fact a card can state;
+ * "no longer" is a card that wastes someone's time.
+ *
+ * Use `isCouponValid` wherever the question is "may this be redeemed" —
+ * checkout, validation, `canUserUseCoupon`. Use this one wherever the question
+ * is "should a human see this".
+ */
+export declare function isCouponDisplayable(coupon: CouponDocument): boolean;
+/** Has this coupon been published ahead of its opening date? */
+export declare function isCouponUpcoming(coupon: CouponDocument): boolean;
 export declare function canUserUseCoupon(coupon: CouponDocument, userUsageCount: number): boolean;
 /** One cart line, as much of it as a BOGO calculation needs. */
 export interface DiscountableLine {

package/dist/features/promotions/schemas/firestore.js

@@ -130,6 +130,50 @@ export function isCouponValid(coupon) {
         (coupon.usage.totalLimit === undefined ||
             coupon.usage.currentUsage < coupon.usage.totalLimit));
 }
+/**
+ * Is this coupon worth SHOWING to a reader? (As distinct from `isCouponValid`,
+ * which asks whether the till will honour it right now.)
+ *
+ * 🛑 THE DIFFERENCE IS ONE CLAUSE — `startDate <= now` — AND IT WAS A REAL,
+ * USER-REPORTED BUG. The Diwali event attaches four codes that open on
+ * Dhanteras. Every display surface filtered them with `isCouponValid`, so
+ * through all of October the event page rendered ONE coupon (its `offerConfig`
+ * headline, which is not filtered) where the event carries five, the homepage
+ * rail would have been empty, and the `/promotions` Coupons tab counted zero
+ * while its own client-side listing happily fetched and rendered them from
+ * `/api/coupons` — which has never applied the start-date clause.
+ *
+ * So three server surfaces disagreed with the one client surface about whether
+ * a published-ahead code exists.
+ *
+ * The event's own copy settles which side is right: *"The code is published now
+ * so you can save it ahead of time."* Publishing a code before it opens is the
+ * intended behaviour, not an accident, and a page that hides it is breaking the
+ * promise the page itself makes.
+ *
+ * 🛑 EXPIRED AND INACTIVE ARE STILL DROPPED, and that half must not be relaxed.
+ * A reader who copies a dead code does the work and is refused at the till —
+ * strictly worse than seeing nothing. "Not yet" is a fact a card can state;
+ * "no longer" is a card that wastes someone's time.
+ *
+ * Use `isCouponValid` wherever the question is "may this be redeemed" —
+ * checkout, validation, `canUserUseCoupon`. Use this one wherever the question
+ * is "should a human see this".
+ */
+export function isCouponDisplayable(coupon) {
+    const now = new Date();
+    const endDate = coupon.validity.endDate
+        ? new Date(coupon.validity.endDate)
+        : null;
+    return (coupon.validity.isActive &&
+        (!endDate || endDate >= now) &&
+        (coupon.usage.totalLimit === undefined ||
+            coupon.usage.currentUsage < coupon.usage.totalLimit));
+}
+/** Has this coupon been published ahead of its opening date? */
+export function isCouponUpcoming(coupon) {
+    return new Date(coupon.validity.startDate) > new Date();
+}
 export function canUserUseCoupon(coupon, userUsageCount) {
     if (!isCouponValid(coupon))
         return false;