@mohasinac/appkit 4.63.2 → 4.63.3

package/dist/.build-stamp.json

@@ -1,8 +1,8 @@
 {
   "stampVersion": 1,
-  "version": "4.63.2",
-  "head": "dd37d5175bd7a2f614092da8fe0cc71892f942a1",
+  "version": "4.63.3",
+  "head": "aea6affd6821cc7b43256c25614e42422df7177c",
   "branch": "main",
   "dirty": false,
-  "builtAt": "2026-10-23T08:39:40.479Z"
+  "builtAt": "2026-10-23T10:12:11.248Z"
 }

package/dist/features/shell/SectionForm.js

@@ -209,6 +209,13 @@ export function SectionForm({ sections, values, onChange, onSubmit, submitLabel
     // validator on every render and re-fire the effect below in a loop.
     const onValidationChangeRef = useRef(onValidationChange);
     onValidationChangeRef.current = onValidationChange;
+    /**
+     * The last error map actually HANDED TO the caller.
+     *
+     * 🛑 This is what stops an infinite render loop, and the loop froze the whole
+     * app — see `emitValidation` below.
+     */
+    const lastEmittedRef = useRef(null);
     /**
      * Are two field-error maps the same set of messages?
      *
@@ -232,6 +239,44 @@ export function SectionForm({ sections, values, onChange, onSubmit, submitLabel
             .filter((s) => s.fields?.some((f) => keys.some((k) => k === f || k.startsWith(`${f}.`))))
             .map((s) => s.id);
     }, [ordered]);
+    /**
+     * Hand the result to the caller, but ONLY when it actually changed.
+     *
+     * ## 🛑 The loop this closes froze every admin editor drawer
+     *
+     * `runValidation` runs on EVERY render by design: `values` is a fresh object
+     * each time, so `ordered` → `erroringSectionIds` → `runValidation` are all
+     * new identities and the effect below re-fires. The comment there argues
+     * that is safe, and for this component's OWN state it is — `sameErrors` and
+     * the `forceOpenIds` length check both return the previous object, so React
+     * bails out.
+     *
+     * It was NOT safe for the caller. `onValidationChange` was invoked
+     * unconditionally on every run, and the real call site is
+     * `onValidationChange={() => form.validate(draft)}` — which setStates. So:
+     * render → effect → emit → caller setState → render → … forever. React
+     * reported "Maximum update depth exceeded" ~4x/second.
+     *
+     * The visible symptom was not a validation bug at all. A React tree stuck in
+     * an update loop never commits a transition, and App Router navigation IS a
+     * transition — so with the drawer open, Cancel, the X, the sort dropdown and
+     * even plain nav links all did nothing. Measured on production: `router.replace`
+     * produced ZERO `history.replaceState` calls, no error, no failed request.
+     * The only escape was a full page reload.
+     *
+     * Emitting only on a real change is also what the prop NAME promises; firing
+     * it with an identical map on every render was never meaningful to a caller.
+     */
+    const emitValidation = useCallback((next, index) => {
+        const prev = lastEmittedRef.current;
+        if (prev && sameErrors(prev, next))
+            return;
+        lastEmittedRef.current = next;
+        onValidationChangeRef.current?.(next, index);
+    }, 
+    // `sameErrors` is a pure local helper; `lastEmittedRef`/`onValidationChangeRef`
+    // are refs. Nothing here needs to re-create this callback.
+    []);
     const runValidation = useCallback((nextValues) => {
         const activeSchema = schema ?? inheritedSchema;
         if (!activeSchema)
@@ -243,7 +288,7 @@ export function SectionForm({ sections, values, onChange, onSubmit, submitLabel
         if (parsed.success) {
             setFieldErrors((prev) => (Object.keys(prev).length === 0 ? prev : {}));
             setForceOpenIds((prev) => (prev.length === 0 ? prev : []));
-            onValidationChangeRef.current?.({}, fieldToSectionIndex);
+            emitValidation({}, fieldToSectionIndex);
             return;
         }
         const next = {};
@@ -266,7 +311,7 @@ export function SectionForm({ sections, values, onChange, onSubmit, submitLabel
             const kept = prev.filter((id) => stillBad.has(id));
             return kept.length === prev.length ? prev : kept;
         });
-        onValidationChangeRef.current?.(next, fieldToSectionIndex);
+        emitValidation(next, fieldToSectionIndex);
     }, [schema, inheritedSchema, fieldToSectionIndex, erroringSectionIds]);
     /*
      * 🛑 `values` MUST be a dependency, and leaving it out cost the entire admin

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mohasinac/appkit",
-  "version": "4.63.2",
+  "version": "4.63.3",
   "license": "MIT",
   "publishConfig": {
     "access": "public"