@mohasinac/appkit 4.58.0 → 4.60.0

package/dist/.build-stamp.json

@@ -1,8 +1,8 @@
 {
   "stampVersion": 1,
-  "version": "4.58.0",
-  "head": "978d9ef892ec5d3ef08a87c7f040877faf3c5daa",
+  "version": "4.60.0",
+  "head": "75dbddb0be908315382e2df74f6f9540c469a77d",
   "branch": "main",
   "dirty": false,
-  "builtAt": "2026-10-20T20:29:00.050Z"
+  "builtAt": "2026-10-21T23:51:33.351Z"
 }

package/dist/_internal/client/features/layout/DashboardLayoutClient.js

@@ -146,10 +146,61 @@ function filterGroups(groups, navConfig, permissions) {
     }))
         .filter((group) => group.items.length > 0);
 }
-// Asymmetric padding clears the persistent sidebar rail — right-heavy by
-// default (rail docks left), left-heavy in left-hand mode (rail docks right).
-const DEFAULT_CONTENT_PADDING_RIGHT = "px-[var(--appkit-space-5)] py-[var(--appkit-space-8)] lg:pl-14 lg:pr-6 xl:pl-16 xl:pr-10";
-const DEFAULT_CONTENT_PADDING_LEFT = "px-[var(--appkit-space-5)] py-[var(--appkit-space-8)] lg:pr-14 lg:pl-6 xl:pr-16 xl:pl-10";
+/*
+ * ── Content clearance for the desktop sidebar ───────────────────────────────
+ *
+ * 🛑 THE CLEARANCE IS NOW CONDITIONAL, AND THAT IS THE DOCKING FIX.
+ *
+ * `lg:pl-14` is 3.5rem — enough to clear the COLLAPSED rail (the narrow strip
+ * with the toggle tab) and nothing like the 18rem the panel occupies when
+ * open. So at `lg` the opened sidebar sat ON TOP of the content, and
+ * `AdminSidebar` rendered a BACKDROP at `lg` to make that legible: a
+ * desktop-width drawer that dimmed the page it was navigating.
+ *
+ * 🛑 The comment this replaces called it "the persistent sidebar rail", and
+ * `DashboardLayoutClient`'s own header says "persistent rail on ≥lg". Both are
+ * true of the COLLAPSED strip and misleading about the open panel — which is
+ * why the audit plan measured the public `SidebarLayout`, found no `lg:` docked
+ * state, and concluded dashboards had none either. The dashboard had a desktop
+ * drawer, not a dock.
+ *
+ * Reserving the real width when open makes it a dock: the content narrows
+ * instead of being covered, and the backdrop is no longer needed.
+ *
+ * 🛑 BOTH HALVES SHIP TOGETHER OR NEITHER DOES. Reserving the space without
+ * removing the backdrop leaves a dimmed page beside a sidebar; removing the
+ * backdrop without reserving the space leaves 18rem of content silently
+ * underneath the panel. Half of this change is worse than none, which is why
+ * the plan declined to land it piecemeal.
+ */
+/*
+ * 🛑 ALL FOUR SPELLED OUT IN FULL — never `lg:pl-${width}`.
+ *
+ * Tailwind's content scanner reads these files as PLAIN TEXT, so a class
+ * assembled from a variable is a class it never sees and never generates. It
+ * then emits nothing, silently, and the content sits under the panel with the
+ * code looking correct. Root Cause #67 is this exact failure, and the first
+ * draft of this very function had it: `lg:pl-${near}`.
+ *
+ * Four literals, two axes: hand (which edge the rail is on) × open (how much
+ * to reserve). `14` is 3.5rem, clearing the collapsed rail and its toggle tab;
+ * `[18rem]` is the open panel's own `w-[18rem]`.
+ */
+const CONTENT_PADDING = {
+    "right-closed": "px-[var(--appkit-space-5)] py-[var(--appkit-space-8)] lg:pl-14 lg:pr-6 xl:pl-16 xl:pr-10",
+    "right-open": "px-[var(--appkit-space-5)] py-[var(--appkit-space-8)] lg:pl-[18rem] lg:pr-6 xl:pr-10",
+    "left-closed": "px-[var(--appkit-space-5)] py-[var(--appkit-space-8)] lg:pr-14 lg:pl-6 xl:pr-16 xl:pl-10",
+    "left-open": "px-[var(--appkit-space-5)] py-[var(--appkit-space-8)] lg:pr-[18rem] lg:pl-6 xl:pl-10",
+};
+function contentPaddingFor(hand, desktopOpen) {
+    /*
+     * The key is BUILT from two values but only ever INDEXES this map — the
+     * class strings themselves are literals the scanner has already seen. That
+     * is the distinction: a dynamic key into a static map is safe, a dynamic
+     * class name is not.
+     */
+    return CONTENT_PADDING[`${hand}-${desktopOpen ? "open" : "closed"}`];
+}
 const DEFAULT_CONTENT_MAX_WIDTH = "max-w-screen-2xl";
 export function DashboardLayoutClient({ variant, groups, permissions, activeHref: explicitActiveHref, 
 // audit-dead-underscore-prop-ok: accepted for interface parity, not yet
@@ -197,7 +248,13 @@ responsive: _responsive, crossNav, className, contentPadding, contentSurface, co
     return (_jsxs(_Fragment, { children: [hasBackground && (_jsx(BackgroundRenderer, { mode: theme === "dark" ? "dark" : "light", lightMode: resolvedLightBackground ?? { type: "color", value: "" }, darkMode: resolvedDarkBackground ?? { type: "color", value: "" } })), variant === "admin" && (_jsx(AdminSidebar, { variant: "sidebar", desktopOpen: desktopOpen, mobileOpen: mobileOpen, activePath: activeHref, groups: adminGroups, onCloseMobile: close, onToggle: toggle, className: className, renderFooter: renderCrossNavFooter })), variant === "store" && (_jsx(StoreSidebar, { variant: "sidebar", desktopOpen: desktopOpen, mobileOpen: mobileOpen, activeHref: activeHref, items: [], groups: filteredGroups, onCloseMobile: close, onToggle: toggle, className: className, renderFooter: renderCrossNavFooter })), variant === "user" && (_jsx(UserSidebar, { variant: "sidebar", desktopOpen: desktopOpen, mobileOpen: mobileOpen, items: filteredGroups.flatMap((g) => g.items), groups: filteredGroups, onCloseMobile: close, onToggle: toggle, className: className, renderFooter: renderCrossNavFooter })), _jsx(Div, { className: [
                     "w-full flex-1 flex flex-col min-h-[calc(100dvh-var(--header-height,3.5rem))]",
                     "pb-[var(--appkit-space-16)] lg:pb-[0]", // clears the fixed mobile bottom-nav
-                    contentPadding ?? (hand === "left" ? DEFAULT_CONTENT_PADDING_LEFT : DEFAULT_CONTENT_PADDING_RIGHT),
+                    /*
+                     * 🛑 Reserves the OPEN panel's width when it is open — which is what
+                     * turns a desktop drawer into a dock. A caller-supplied
+                     * `contentPadding` still wins and then owns the clearance itself;
+                     * nothing passes one today.
+                     */
+                    contentPadding ?? contentPaddingFor(hand, desktopOpen),
                     contentSurface,
                 ].filter(Boolean).join(" "), children: _jsx(Div, { className: ["w-full flex-1 mx-auto", contentMaxWidth ?? DEFAULT_CONTENT_MAX_WIDTH].filter(Boolean).join(" "), children: children }) })] }));
 }

package/dist/_internal/client/features/maintenance/views/MaintenanceDashboardView.js

@@ -7,7 +7,7 @@ const card = {
     background: "var(--appkit-color-surface)",
 };
 export function MaintenanceDashboardView({ counts, basePath, }) {
-    return (_jsxs(Div, { style: { padding: "1.5rem", maxWidth: "1200px", margin: "0 auto" }, children: [_jsx(Heading, { level: 1, style: { fontSize: "1.5rem", fontWeight: 600 }, children: "Maintenance" }), _jsx(Text, { as: "p", style: { color: "var(--appkit-color-text-muted)", marginBottom: "1.25rem" }, children: "Errors and failures across the platform \u2014 server, client, and Cloud Functions." }), _jsxs(Div, { style: { display: "grid", gridTemplateColumns: "repeat(auto-fit, minmax(170px, 1fr))", gap: "0.75rem", marginBottom: "1.5rem" }, children: [_jsxs(Div, { style: card, children: [_jsx(Div, { style: { fontSize: "0.78rem", color: "var(--appkit-color-text-muted)" }, children: "Last 24 hours" }), _jsx(Div, { style: { fontSize: "1.75rem", fontWeight: 700 }, children: counts.last24h })] }), _jsxs(Div, { style: card, children: [_jsx(Div, { style: { fontSize: "0.78rem", color: "var(--appkit-color-text-muted)" }, children: "Last 7 days" }), _jsx(Div, { style: { fontSize: "1.75rem", fontWeight: 700 }, children: counts.last7d })] }), _jsxs(Div, { style: card, children: [_jsx(Div, { style: { fontSize: "0.78rem", color: "var(--appkit-color-text-muted)" }, children: "Last 30 days" }), _jsx(Div, { style: { fontSize: "1.75rem", fontWeight: 700 }, children: counts.last30d })] }), _jsxs(Div, { style: card, children: [_jsx(Div, { style: { fontSize: "0.78rem", color: "var(--appkit-color-text-muted)" }, children: "Server (Vercel)" }), _jsx(Div, { style: { fontSize: "1.5rem", fontWeight: 700 }, children: counts.bySource.vercel })] }), _jsxs(Div, { style: card, children: [_jsx(Div, { style: { fontSize: "0.78rem", color: "var(--appkit-color-text-muted)" }, children: "Client" }), _jsx(Div, { style: { fontSize: "1.5rem", fontWeight: 700 }, children: counts.bySource.client })] }), _jsxs(Div, { style: card, children: [_jsx(Div, { style: { fontSize: "0.78rem", color: "var(--appkit-color-text-muted)" }, children: "Cloud Functions" }), _jsx(Div, { style: { fontSize: "1.5rem", fontWeight: 700 }, children: counts.bySource.function })] })] }), _jsxs(Section, { style: { marginBottom: "1.5rem" }, children: [_jsx(Heading, { level: 2, style: { fontSize: "1rem", fontWeight: 600 }, children: "Top codes (30d)" }), _jsx(Ul, { style: { listStyle: "none", padding: 0 }, children: counts.topCodes.length === 0 ? _jsx(Li, { style: { color: "var(--appkit-color-text-muted)" }, children: "No errors recorded." }) :
+    return (_jsxs(Div, { style: { padding: "1.5rem", maxWidth: "1200px", margin: "0 auto" }, children: [_jsx(Heading, { level: 1, style: { fontSize: "1.5rem", fontWeight: 600 }, children: "Maintenance" }), _jsx(Text, { as: "p", style: { color: "var(--appkit-color-text-muted)", marginBottom: "1.25rem" }, children: "Errors and failures across the platform \u2014 server, client, and Cloud Functions." }), _jsxs(Div, { style: { display: "grid", gridTemplateColumns: "repeat(auto-fill, minmax(170px, 1fr))", gap: "0.75rem", marginBottom: "1.5rem" }, children: [_jsxs(Div, { style: card, children: [_jsx(Div, { style: { fontSize: "0.78rem", color: "var(--appkit-color-text-muted)" }, children: "Last 24 hours" }), _jsx(Div, { style: { fontSize: "1.75rem", fontWeight: 700 }, children: counts.last24h })] }), _jsxs(Div, { style: card, children: [_jsx(Div, { style: { fontSize: "0.78rem", color: "var(--appkit-color-text-muted)" }, children: "Last 7 days" }), _jsx(Div, { style: { fontSize: "1.75rem", fontWeight: 700 }, children: counts.last7d })] }), _jsxs(Div, { style: card, children: [_jsx(Div, { style: { fontSize: "0.78rem", color: "var(--appkit-color-text-muted)" }, children: "Last 30 days" }), _jsx(Div, { style: { fontSize: "1.75rem", fontWeight: 700 }, children: counts.last30d })] }), _jsxs(Div, { style: card, children: [_jsx(Div, { style: { fontSize: "0.78rem", color: "var(--appkit-color-text-muted)" }, children: "Server (Vercel)" }), _jsx(Div, { style: { fontSize: "1.5rem", fontWeight: 700 }, children: counts.bySource.vercel })] }), _jsxs(Div, { style: card, children: [_jsx(Div, { style: { fontSize: "0.78rem", color: "var(--appkit-color-text-muted)" }, children: "Client" }), _jsx(Div, { style: { fontSize: "1.5rem", fontWeight: 700 }, children: counts.bySource.client })] }), _jsxs(Div, { style: card, children: [_jsx(Div, { style: { fontSize: "0.78rem", color: "var(--appkit-color-text-muted)" }, children: "Cloud Functions" }), _jsx(Div, { style: { fontSize: "1.5rem", fontWeight: 700 }, children: counts.bySource.function })] })] }), _jsxs(Section, { style: { marginBottom: "1.5rem" }, children: [_jsx(Heading, { level: 2, style: { fontSize: "1rem", fontWeight: 600 }, children: "Top codes (30d)" }), _jsx(Ul, { style: { listStyle: "none", padding: 0 }, children: counts.topCodes.length === 0 ? _jsx(Li, { style: { color: "var(--appkit-color-text-muted)" }, children: "No errors recorded." }) :
                             counts.topCodes.map((c) => (_jsxs(Li, { style: { display: "flex", justifyContent: "space-between", padding: "0.25rem 0", borderBottom: "1px solid var(--appkit-color-border-subtle)" }, children: [_jsx(Span, { style: { fontFamily: "monospace" }, children: c.code }), _jsx(Span, { children: c.count })] }, c.code))) })] }), _jsxs(Section, { style: { marginBottom: "1.5rem" }, children: [_jsx(Heading, { level: 2, style: { fontSize: "1rem", fontWeight: 600 }, children: "Top routes (30d)" }), _jsx(Ul, { style: { listStyle: "none", padding: 0 }, children: counts.topRoutes.length === 0 ? _jsx(Li, { style: { color: "var(--appkit-color-text-muted)" }, children: "No errors recorded." }) :
-                            counts.topRoutes.map((r) => (_jsxs(Li, { style: { display: "flex", justifyContent: "space-between", padding: "0.25rem 0", borderBottom: "1px solid var(--appkit-color-border-subtle)" }, children: [_jsxs(Span, { style: { fontFamily: "monospace" }, children: ["[", r.source, "] ", r.route] }), _jsx(Span, { children: r.count })] }, `${r.source}:${r.route}`))) })] }), _jsxs(Nav, { "aria-label": "Maintenance sections", style: { display: "grid", gridTemplateColumns: "repeat(auto-fit, minmax(200px, 1fr))", gap: "0.5rem" }, children: [_jsxs(Anchor, { href: `${basePath}/server-errors`, tone: "default", underline: "none", style: { ...card }, children: [_jsx(Span, { weight: "bold", children: "Server errors" }), _jsx(Div, { style: { color: "var(--appkit-color-text-muted)", fontSize: "0.85rem" }, children: "Vercel function failures" })] }), _jsxs(Anchor, { href: `${basePath}/client-errors`, tone: "default", underline: "none", style: { ...card }, children: [_jsx(Span, { weight: "bold", children: "Client errors" }), _jsx(Div, { style: { color: "var(--appkit-color-text-muted)", fontSize: "0.85rem" }, children: "window.onerror + unhandledrejection + boundaries" })] }), _jsxs(Anchor, { href: `${basePath}/function-errors`, tone: "default", underline: "none", style: { ...card }, children: [_jsx(Span, { weight: "bold", children: "Function errors" }), _jsx(Div, { style: { color: "var(--appkit-color-text-muted)", fontSize: "0.85rem" }, children: "Cloud Functions handler exceptions" })] }), _jsxs(Anchor, { href: `${basePath}/cloud-logs`, tone: "default", underline: "none", style: { ...card }, children: [_jsx(Span, { weight: "bold", children: "Cloud Logging" }), _jsx(Div, { style: { color: "var(--appkit-color-text-muted)", fontSize: "0.85rem" }, children: "Live stream from Cloud Logging API" })] }), _jsxs(Anchor, { href: `${basePath}/payment-rollbacks`, tone: "default", underline: "none", style: { ...card }, children: [_jsx(Span, { weight: "bold", children: "Payment rollbacks" }), _jsx(Div, { style: { color: "var(--appkit-color-text-muted)", fontSize: "0.85rem" }, children: "PhonePe refund + upstream-unavailable rows" })] }), _jsxs(Anchor, { href: `${basePath}/analysis`, tone: "default", underline: "none", style: { ...card }, children: [_jsx(Span, { weight: "bold", children: "Analysis" }), _jsx(Div, { style: { color: "var(--appkit-color-text-muted)", fontSize: "0.85rem" }, children: "Run the maintenance analyzer + recommendations" })] })] })] }));
+                            counts.topRoutes.map((r) => (_jsxs(Li, { style: { display: "flex", justifyContent: "space-between", padding: "0.25rem 0", borderBottom: "1px solid var(--appkit-color-border-subtle)" }, children: [_jsxs(Span, { style: { fontFamily: "monospace" }, children: ["[", r.source, "] ", r.route] }), _jsx(Span, { children: r.count })] }, `${r.source}:${r.route}`))) })] }), _jsxs(Nav, { "aria-label": "Maintenance sections", style: { display: "grid", gridTemplateColumns: "repeat(auto-fill, minmax(200px, 1fr))", gap: "0.5rem" }, children: [_jsxs(Anchor, { href: `${basePath}/server-errors`, tone: "default", underline: "none", style: { ...card }, children: [_jsx(Span, { weight: "bold", children: "Server errors" }), _jsx(Div, { style: { color: "var(--appkit-color-text-muted)", fontSize: "0.85rem" }, children: "Vercel function failures" })] }), _jsxs(Anchor, { href: `${basePath}/client-errors`, tone: "default", underline: "none", style: { ...card }, children: [_jsx(Span, { weight: "bold", children: "Client errors" }), _jsx(Div, { style: { color: "var(--appkit-color-text-muted)", fontSize: "0.85rem" }, children: "window.onerror + unhandledrejection + boundaries" })] }), _jsxs(Anchor, { href: `${basePath}/function-errors`, tone: "default", underline: "none", style: { ...card }, children: [_jsx(Span, { weight: "bold", children: "Function errors" }), _jsx(Div, { style: { color: "var(--appkit-color-text-muted)", fontSize: "0.85rem" }, children: "Cloud Functions handler exceptions" })] }), _jsxs(Anchor, { href: `${basePath}/cloud-logs`, tone: "default", underline: "none", style: { ...card }, children: [_jsx(Span, { weight: "bold", children: "Cloud Logging" }), _jsx(Div, { style: { color: "var(--appkit-color-text-muted)", fontSize: "0.85rem" }, children: "Live stream from Cloud Logging API" })] }), _jsxs(Anchor, { href: `${basePath}/payment-rollbacks`, tone: "default", underline: "none", style: { ...card }, children: [_jsx(Span, { weight: "bold", children: "Payment rollbacks" }), _jsx(Div, { style: { color: "var(--appkit-color-text-muted)", fontSize: "0.85rem" }, children: "PhonePe refund + upstream-unavailable rows" })] }), _jsxs(Anchor, { href: `${basePath}/analysis`, tone: "default", underline: "none", style: { ...card }, children: [_jsx(Span, { weight: "bold", children: "Analysis" }), _jsx(Div, { style: { color: "var(--appkit-color-text-muted)", fontSize: "0.85rem" }, children: "Run the maintenance analyzer + recommendations" })] })] })] }));
 }

package/dist/_internal/server/features/brands/actions.js

@@ -26,13 +26,47 @@ function brandInputToCategoryFields(input) {
         out.brandCountry = input.country;
     if (input.founded !== undefined)
         out.brandFounded = input.founded;
-    if (input.logoURL !== undefined) {
-        out.display = { coverImage: input.logoURL, showInMenu: false, showInFooter: false };
-    }
+    /*
+     * 🛑 `display` IS NOT WRITTEN HERE ANY MORE — IT WAS DESTRUCTIVE.
+     *
+     * This read `out.display = { coverImage, showInMenu: false, showInFooter:
+     * false }`, and `BaseRepository.update` calls Firestore's `doc().update()`,
+     * which REPLACES a nested map rather than merging into it. So saving a
+     * brand's cover image deleted every other `display` key — `icon`, `color`,
+     * `mosaicImages` — and additionally forced `showInMenu` and `showInFooter`
+     * to `false`, silently removing the brand from the menu and the footer for
+     * anyone who touched its image.
+     *
+     * This is the identical defect Phase 0 found and fixed on the CATEGORY
+     * editor (which sent `display: { showInMenu }` and wiped the cover image,
+     * emoji, colour and a bundle's `mosaicImages` collage on every save). Both
+     * sublisting routes already merged correctly; the category route was fixed;
+     * the BRAND path was never looked at — the same root cause in a third place,
+     * found only because this file was open for an unrelated field.
+     *
+     * The merge now happens in `updateBrandAction`, which has the stored
+     * document in hand. Create still writes the full map, which is correct:
+     * there is nothing to preserve, and the caller's defaults are the record.
+     */
     if (input.isActive !== undefined)
         out.isActive = input.isActive;
     if (input.displayOrder !== undefined)
         out.order = input.displayOrder;
+    /*
+     * 🛑 Both written as TOP-LEVEL arrays, not nested under `display` — so the
+     * replace-vs-merge hazard that this function's `display` note is about does
+     * not apply to them. `update()` replaces an array wholesale, which is the
+     * correct semantics for a list the form submits in full.
+     *
+     * And `!== undefined` rather than a truthiness test: an EMPTY array is a
+     * real instruction ("remove every highlight"), and `if (input.highlights)`
+     * would silently decline to carry it, leaving the admin unable to clear a
+     * list they can see.
+     */
+    if (input.highlights !== undefined)
+        out.highlights = input.highlights;
+    if (input.faqs !== undefined)
+        out.faqs = input.faqs;
     return out;
 }
 export async function createBrandAction(input) {
@@ -77,6 +111,22 @@ export async function createBrandAction(input) {
                 lastUpdated: new Date(),
             },
             seo: { title: parsed.data.name, description: parsed.data.description ?? "", keywords: [parsed.data.name] },
+            /*
+             * Written in FULL here, and that is correct on create: there is no
+             * stored map to preserve, so these defaults ARE the record. The
+             * mapper no longer supplies it — see the note there on why merging
+             * belongs in the update path.
+             *
+             * 🛑 `icon` is deliberately left UNSET rather than given a value.
+             * `resolveTaxonomyVisual` checks `icon` BEFORE `coverImage`, and the
+             * seed convention puts an EMOJI there — so an icon set here would win
+             * over the real logo the admin just uploaded (`brand-rows.ts` trap 2).
+             */
+            display: {
+                coverImage: parsed.data.logoURL,
+                showInMenu: false,
+                showInFooter: false,
+            },
             ancestors: [],
             createdBy: actor.uid,
             createdAt: new Date(),
@@ -92,7 +142,31 @@ export async function updateBrandAction(brandId, input) {
         const parsed = brandUpdateSchema.safeParse(input);
         if (!parsed.success)
             throw new ValidationError(parsed.error.issues[0]?.message ?? "Invalid brand input");
-        return categoriesRepository.update(brandId, brandInputToCategoryFields(parsed.data));
+        const fields = brandInputToCategoryFields(parsed.data);
+        /*
+         * 🛑 `display` MERGED OVER WHAT IS STORED, never replaced. `update()`
+         * replaces a nested map, so a payload carrying a partial `display`
+         * deletes every key it omits — which is how a cover-image save used to
+         * destroy a brand's `icon`, `color` and `mosaicImages` and force it out
+         * of the menu and footer.
+         *
+         * Same shape and same fix as `PATCH /api/admin/categories/[id]`.
+         * Merged rather than written as `display.x` DOT PATHS for the reason
+         * recorded there: `categoriesRepository.update` is typed
+         * `Partial<CategoryDocument>`, which a dot-path key does not satisfy.
+         *
+         * 🛑 The read is only taken when there is something to merge, so a save
+         * that does not touch the image still costs no extra Firestore read —
+         * `assertBrandExists` above does not hand back the document.
+         */
+        if (parsed.data.logoURL !== undefined) {
+            const existing = await categoriesRepository.findById(brandId);
+            fields.display = {
+                ...(existing?.display ?? {}),
+                coverImage: parsed.data.logoURL,
+            };
+        }
+        return categoriesRepository.update(brandId, fields);
     });
 }
 export async function deleteBrandAction(brandId) {

package/dist/_internal/server/features/checkout/actions.d.ts

@@ -31,18 +31,6 @@ export interface CreateCheckoutOrderInput {
      * outbound call on the payment path and is tracked separately.
      */
     selectedShippingQuote?: SelectedShippingQuote;
-    /**
-     * Points the buyer chose to spend on this checkout. 1 point = ₹1.
-     *
-     * 🛑 Requested, never trusted. The server re-reads the balance, re-applies
-     * the 50% cap against the real cart total, and spends the LESSER of the two
-     * — a client that asks for more than it holds gets its request trimmed, not
-     * an error, because the honest reading of "spend 500 when you have 300" is a
-     * stale page rather than an attack. `pointsRepository.redeem` then re-checks
-     * the balance a third time inside its own transaction, which is the check
-     * that actually prevents a negative balance under concurrency.
-     */
-    pointsToRedeem?: number;
     notes?: string;
     excludedProductIds?: string[];
     /** When true this is an admin test order — OTP consent is pre-granted and the order is created paid/processing. */
@@ -63,7 +51,42 @@ export interface CreateCheckoutOrderInput {
  * exact same per-seller shipping fee that order creation charges/records —
  * a single source of truth instead of a third re-implementation.
  */
-export declare function resolveShippingCost(storeId: string | undefined): Promise<{
+export declare function resolveShippingCost(storeId: string | undefined, 
+/**
+ * The cart facts needed to QUOTE rather than merely resolve the policy.
+ *
+ * 🛑 D44 — OMITTING THIS IS TWO MONEY BUGS IN OPPOSITE DIRECTIONS, and until
+ * now every one of the five call sites omitted it.
+ *
+ * `quoteShipping` was called exactly once, here, with `goodsValue: 0` and
+ * `carrierRate: null`. Measured against its own logic
+ * (`shared/features/shipping/mode.ts`):
+ *
+ * 1. **Free-above-threshold can never fire.** The test is
+ *    `goodsValue >= policy.freeAbove`, and `0 >= 999` is false for any
+ *    positive threshold — so a store advertising "free shipping over ₹999"
+ *    **charged its base rate on a ₹5,000 order.** The buyer is OVERCHARGED,
+ *    and the seller's own offer silently does not exist.
+ * 2. **`estimate` mode ships FREE.** No carrier rate returns
+ *    `kind: "unavailable"`, which the mapping below turns into
+ *    `shippingFee: 0` — and `shippingUnavailable` had **zero consumers**, so
+ *    nobody noticed. The platform/seller is UNDERCHARGED, which is what that
+ *    field's own 🛑 warns about: "a zero there would ship every parcel free
+ *    at our expense, silently, until somebody noticed."
+ *
+ * `flat` and `free` modes were unaffected, which is why this survived: the
+ * common cases are correct and only a store with a threshold or an estimate
+ * policy is mispriced.
+ *
+ * Still optional, because the one legitimate caller is the seller-settings
+ * surface that wants the POLICY and has no cart. Every money path passes it.
+ */
+opts?: {
+    /** The group's goods value in decimal rupees, from `lineTotalFor`. */
+    goodsValue?: number;
+    /** A real carrier rate, when one was obtained. `null` = none available. */
+    carrierRate?: number | null;
+}): Promise<{
     shippingFee: number;
     storeOwnerId: string | undefined;
     storeEmiEnabled: boolean;