@mohasinac/appkit 4.53.1 → 4.53.2

package/dist/features/categories/components/CategoryDetailPageView.js

@@ -27,6 +27,7 @@ import { safeRead } from "../../../errors/safe-read.js";
 import { breadcrumbJsonLd, collectionPageJsonLd, faqJsonLd, } from "../../../seo/json-ld.js";
 import { toStoreListItem } from "../../../_internal/server/features/stores/adapters.js";
 import { hidePublicTestData } from "../../../_internal/server/features/tester/visibility.js";
+import { productImageUrls } from "../../products/schemas/firestore.js";
 const __O = {
     hidden: "overflow-hidden",
 };
@@ -170,7 +171,7 @@ export async function CategoryDetailPageView({ slug }) {
         // Four of the ten tabs used to have no count at all and could never hide.
         categoriesIn
             ? listingTabCounts(CATEGORY_PAGE_TABS, { categoriesIn })
-            : Promise.resolve({}),
+            : Promise.resolve({ available: {}, total: {} }),
         // SB-UNI-D — bundles fetched from the categories collection. We pull
         // all active bundle rows; the carousel filters by category affinity.
         categoriesIn
@@ -419,13 +420,22 @@ export async function CategoryDetailPageView({ slug }) {
     // `tabCounts` is keyed by tabSlug and already covers every listing type plus
     // bundles; `stores` is added here because this page resolves its store list
     // eagerly to render the tab body anyway.
-    const counts = { ...tabCounts, stores: storeCount };
+    // Two maps, not one: the BADGE is what the default (available) scope will
+    // render, while HIDING must stay keyed on the total — a tab whose rows have
+    // all ended still has a browsable archive behind the Ended/All scopes.
+    // `stores` is added to both because this page resolves its store list
+    // eagerly to render the tab body anyway, and a store has no availability
+    // scope of its own.
+    const counts = { ...tabCounts.available, stores: storeCount };
+    const totals = { ...tabCounts.total, stores: storeCount };
     // Header pills read the same numbers the tabs do. `?? 0` is safe here (a pill
     // simply doesn't render) — unlike the tab bar, where an unknown count must
     // stay visible rather than collapse to "hide me".
-    const productCount = counts.products ?? category?.metrics?.totalProductCount ?? category?.metrics?.productCount ?? 0;
-    const auctionCount = counts.auctions ?? category?.metrics?.totalAuctionCount ?? category?.metrics?.auctionCount ?? 0;
-    const preOrderCount = counts["pre-orders"] ?? 0;
+    // Header pills read TOTALS, deliberately: "47 products" is a statement about
+    // what this category holds, not about what one scope is currently showing.
+    const productCount = totals.products ?? category?.metrics?.totalProductCount ?? category?.metrics?.productCount ?? 0;
+    const auctionCount = totals.auctions ?? category?.metrics?.totalAuctionCount ?? category?.metrics?.auctionCount ?? 0;
+    const preOrderCount = totals["pre-orders"] ?? 0;
     /*
      * G3b — OWN vs CHILDREN, so one number stops answering two questions.
      *
@@ -465,7 +475,7 @@ export async function CategoryDetailPageView({ slug }) {
     const mosaicImages = hasCover
         ? []
         : (productsResult?.items ?? [])
-            .map((row) => row.mainImage ?? row.images?.[0] ?? null)
+            .map((row) => row.mainImage || productImageUrls(row.images)[0] || null)
             .filter((src) => !!src)
             .slice(0, 5);
     const hasMosaic = mosaicImages.length >= MOSAIC_MIN;
@@ -587,5 +597,5 @@ export async function CategoryDetailPageView({ slug }) {
                                 imageUrl: coverOf(b),
                                 countLabel: countOf(b),
                             } }) }) }));
-            })(), directChildrenWithListings.length > 0 && (_jsx(Section, { border: "subtle", surface: "default", className: "border-b", children: _jsx(Div, { className: __W, padding: "inline", children: _jsxs(Div, { padding: "b-2xs", children: [parentLadder.length > 0 && (_jsx(Div, { padding: "b-2xs", children: _jsx(SubcategoryCardRow, { items: parentLadder, label: "Parent category" }) })), _jsx(SubcategoryCardRow, { items: toSubcategoryItems(directChildrenWithListings, childCategories) })] }) }) })), _jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: _jsx(CategoryDetailTabs, { categorySlug: slug, categoryId: category?.id, initialProductsData: productsResult ?? undefined, initialBundles: bundlesResult ?? [], initialStores: categoryStores, counts: counts, enabledListingTypes: enabledListingTypes(settings), enabledCategoryTypes: enabledCategoryTypes(settings) }) }) }), groupedListings.length > 0 && (_jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: _jsx(GroupedListingsCarousel, { groups: groupedListings }) }) })), relatedCategories.length > 0 && (_jsx(Section, { border: "subtle", surface: "default", className: "border-t", padding: "y-lg", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 2, className: "mb-4", size: "xl", weight: "semibold", children: "Related Categories" }), _jsx(CategoryGrid, { categories: relatedCategories, getHref: (c) => String(ROUTES.PUBLIC.CATEGORY_DETAIL(c.slug)) })] }) }))] }));
+            })(), directChildrenWithListings.length > 0 && (_jsx(Section, { border: "subtle", surface: "default", className: "border-b", children: _jsx(Div, { className: __W, padding: "inline", children: _jsxs(Div, { padding: "b-2xs", children: [parentLadder.length > 0 && (_jsx(Div, { padding: "b-2xs", children: _jsx(SubcategoryCardRow, { items: parentLadder, label: "Parent category" }) })), _jsx(SubcategoryCardRow, { items: toSubcategoryItems(directChildrenWithListings, childCategories) })] }) }) })), _jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: _jsx(CategoryDetailTabs, { categorySlug: slug, categoryId: category?.id, initialProductsData: productsResult ?? undefined, initialBundles: bundlesResult ?? [], initialStores: categoryStores, counts: counts, totals: totals, enabledListingTypes: enabledListingTypes(settings), enabledCategoryTypes: enabledCategoryTypes(settings) }) }) }), groupedListings.length > 0 && (_jsx(Section, { padding: "y-lg", children: _jsx(Container, { size: "xl", children: _jsx(GroupedListingsCarousel, { groups: groupedListings }) }) })), relatedCategories.length > 0 && (_jsx(Section, { border: "subtle", surface: "default", className: "border-t", padding: "y-lg", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 2, className: "mb-4", size: "xl", weight: "semibold", children: "Related Categories" }), _jsx(CategoryGrid, { categories: relatedCategories, getHref: (c) => String(ROUTES.PUBLIC.CATEGORY_DETAIL(c.slug)) })] }) }))] }));
 }

package/dist/features/categories/components/CategoryDetailTabs.d.ts

@@ -17,9 +17,15 @@ export interface CategoryDetailTabsProps {
      * were structurally uncountable and could never hide (Root Cause #61).
      */
     counts?: Record<string, number | undefined>;
+    /**
+     * Every published row per tab, all availability scopes. Drives hide-at-zero
+     * and the "N ended — show all" hint; see `ListingTabCountResult`. Omitted,
+     * it falls back to `counts`, i.e. the pre-split behaviour.
+     */
+    totals?: Record<string, number | undefined>;
     /** Enabled listing types (e.g. ["standard","auction","pre-order"]). When omitted, all tabs shown. */
     enabledListingTypes?: string[];
     /** Enabled category types (e.g. ["category","brand","bundle"]). When omitted, all tabs shown. */
     enabledCategoryTypes?: string[];
 }
-export declare function CategoryDetailTabs({ categorySlug, categoryId, initialProductsData, initialBundles, initialStores, counts, enabledListingTypes, enabledCategoryTypes, }: CategoryDetailTabsProps): React.JSX.Element;
+export declare function CategoryDetailTabs({ categorySlug, categoryId, initialProductsData, initialBundles, initialStores, counts, totals, enabledListingTypes, enabledCategoryTypes, }: CategoryDetailTabsProps): React.JSX.Element;

package/dist/features/categories/components/CategoryDetailTabs.js

@@ -2,6 +2,7 @@
 import { jsx as _jsx, Fragment as _Fragment, jsxs as _jsxs } from "react/jsx-runtime";
 import { useState } from "react";
 import { EmptyState, Tabs, TabsList, TabsTrigger } from "../../../ui/index.js";
+import { AvailabilityScopeHint } from "../../products/components/AvailabilityScopeHint.js";
 import { CategoryProductsListing } from "./CategoryProductsListing.js";
 import { AuctionsIndexListing } from "../../products/components/AuctionsIndexListing.js";
 import { PreOrdersIndexListing } from "../../pre-orders/components/PreOrdersIndexListing.js";
@@ -29,6 +30,21 @@ const TAB_TYPE_MAP = {
     bundles: { kind: "category", type: "bundle" },
     stores: { kind: "entity", type: "stores" },
 };
+/**
+ * The listing types a tab spans, for the availability-scope hint.
+ *
+ * Derived from `TAB_TYPE_MAP` rather than hand-written: that map is already
+ * built from `ALL_LISTING_TYPES`, so a tenth type is covered without a second
+ * enumeration (Root Cause #61). The combined Art & Stickers tab is the one
+ * entry that spans two, and `GENERIC_TAB_LISTING_TYPES` already says so.
+ */
+function typesForTab(id) {
+    const generic = GENERIC_TAB_LISTING_TYPES[id];
+    if (generic)
+        return generic;
+    const mapping = TAB_TYPE_MAP[id];
+    return mapping?.kind === "listing" ? [mapping.type] : [];
+}
 /** Listing types rendered by the shared products listing rather than a dedicated one. */
 const GENERIC_TAB_LISTING_TYPES = {
     [pluginFor("standard").tabSlug]: ["standard"],
@@ -50,8 +66,12 @@ const GENERIC_TAB_LISTING_TYPES = {
      */
     [pluginFor("spares").tabSlug]: ["spares"],
 };
-export function CategoryDetailTabs({ categorySlug, categoryId, initialProductsData, initialBundles = [], initialStores = [], counts, enabledListingTypes, enabledCategoryTypes, }) {
+export function CategoryDetailTabs({ categorySlug, categoryId, initialProductsData, initialBundles = [], initialStores = [], counts, totals, enabledListingTypes, enabledCategoryTypes, }) {
     const countFor = (id) => counts?.[id];
+    // Falls back to the badge when no totals map is supplied, so a caller that
+    // has not been migrated keeps today's hide behaviour rather than hiding
+    // everything.
+    const totalFor = (id) => totals?.[id] ?? counts?.[id];
     const visibleTabs = CATEGORY_PAGE_TABS.filter((t) => {
         const mapping = TAB_TYPE_MAP[t.id];
         if (mapping) {
@@ -64,11 +84,13 @@ export function CategoryDetailTabs({ categorySlug, categoryId, initialProductsDa
                     return false;
             }
         }
-        // Hide a tab only when its count is known and explicitly zero. `undefined`
-        // now means the count query FAILED (every tab is counted), so keeping it
-        // visible is the fail-open choice: an empty tab is a far smaller error than
-        // hiding a tab that holds real listings.
-        const count = countFor(t.id);
+        // 🛑 TOTAL, not the badge. The badge counts what the default (available)
+        // scope renders, and a tab whose rows have all ended badges 0 while still
+        // holding a browsable archive behind the Ended/All scopes — hiding it
+        // would strand that archive. `undefined` still means the count query
+        // FAILED, so the tab stays visible: an empty tab is a far smaller error
+        // than hiding a tab that holds real listings (Root Cause #59).
+        const count = totalFor(t.id);
         return count === undefined || count > 0;
     });
     const firstTabId = (visibleTabs[0]?.id ?? "products");
@@ -78,5 +100,5 @@ export function CategoryDetailTabs({ categorySlug, categoryId, initialProductsDa
     if (visibleTabs.length === 0) {
         return (_jsx(EmptyState, { title: "Nothing listed here yet", description: "This category has no active listings right now. Check back soon." }));
     }
-    return (_jsxs(_Fragment, { children: [_jsx(Tabs, { value: activeTab, onChange: (v) => setActiveTab(v), className: "mb-6", children: _jsx(TabsList, { children: visibleTabs.map((t) => (_jsx(TabsTrigger, { value: t.id, badge: countFor(t.id), children: t.label }, t.id))) }) }), GENERIC_TAB_LISTING_TYPES[activeTab] && (_jsx(CategoryProductsListing, { categorySlug: categorySlug, categoryId: categoryId, listingTypes: GENERIC_TAB_LISTING_TYPES[activeTab], initialData: activeTab === pluginFor("standard").tabSlug ? initialProductsData : undefined })), activeTab === pluginFor("auction").tabSlug && (_jsx(AuctionsIndexListing, { categorySlug: categorySlug })), activeTab === pluginFor("pre-order").tabSlug && (_jsx(PreOrdersIndexListing, { categorySlug: categorySlug })), activeTab === pluginFor("prize-draw").tabSlug && (_jsx(PrizeDrawsIndexListing, { categorySlug: categorySlug })), activeTab === "bundles" && (_jsx(CategoryBundlesListing, { initialBundles: initialBundles })), activeTab === "stores" && (_jsx(CategoryStoresListing, { stores: initialStores }))] }));
+    return (_jsxs(_Fragment, { children: [_jsx(Tabs, { value: activeTab, onChange: (v) => setActiveTab(v), className: "mb-6", children: _jsx(TabsList, { children: visibleTabs.map((t) => (_jsx(TabsTrigger, { value: t.id, badge: countFor(t.id), children: t.label }, t.id))) }) }), _jsx(AvailabilityScopeHint, { total: totalFor(activeTab), available: countFor(activeTab), types: typesForTab(activeTab) }), GENERIC_TAB_LISTING_TYPES[activeTab] && (_jsx(CategoryProductsListing, { categorySlug: categorySlug, categoryId: categoryId, listingTypes: GENERIC_TAB_LISTING_TYPES[activeTab], initialData: activeTab === pluginFor("standard").tabSlug ? initialProductsData : undefined })), activeTab === pluginFor("auction").tabSlug && (_jsx(AuctionsIndexListing, { categorySlug: categorySlug })), activeTab === pluginFor("pre-order").tabSlug && (_jsx(PreOrdersIndexListing, { categorySlug: categorySlug })), activeTab === pluginFor("prize-draw").tabSlug && (_jsx(PrizeDrawsIndexListing, { categorySlug: categorySlug })), activeTab === "bundles" && (_jsx(CategoryBundlesListing, { initialBundles: initialBundles })), activeTab === "stores" && (_jsx(CategoryStoresListing, { stores: initialStores }))] }));
 }

package/dist/features/classified/components/ClassifiedDetailPageView.js

@@ -23,6 +23,7 @@ import { getSiteSettingsGlobal } from "../../admin/utils/getSiteSettingsGlobal.j
 import { safeRead } from "../../../errors/safe-read.js";
 import { DEFAULT_MIN_OFFER_PERCENT, offersEnabledFor, resolveOfferBounds, } from "../../../_internal/shared/features/offers/config.js";
 import { ListingBottomActions } from "../../products/components/ListingBottomActions.js";
+import { productImageUrls } from "../../products/schemas/firestore.js";
 function toDescriptionHtml(raw) {
     if (!raw)
         return "";
@@ -43,7 +44,15 @@ export async function ClassifiedDetailPageView({ slug, initialProduct, renderOff
     const currency = p.currency || getDefaultCurrency();
     const title = String(p.title ?? p.name ?? "Classified Listing");
     const price = typeof p.price === "number" ? p.price : null;
-    const images = Array.isArray(p.images) ? p.images : typeof p.mainImage === "string" ? [p.mainImage] : [];
+    // `images` is `ProductImage[]` since A6 — `productImageUrls` is the one
+    // normaliser (it also accepts the legacy `string[]`). Casting it to
+    // `string[]` handed the gallery objects and rendered a placeholder.
+    const galleryUrls = productImageUrls(p.images);
+    const images = galleryUrls.length > 0
+        ? galleryUrls
+        : typeof p.mainImage === "string"
+            ? [p.mainImage]
+            : [];
     const meta = product.classified;
     const location = meta?.meetupArea ? [meta.meetupArea.locality, meta.meetupArea.city].filter(Boolean).join(", ") : null;
     const category = Array.isArray(p.categorySlugs) && p.categorySlugs.length > 0 ? String(p.categorySlugs[0]) : (typeof p.category === "string" ? p.category : null);

package/dist/features/digital-codes/components/DigitalCodeDetailPageView.js

@@ -21,6 +21,7 @@ import { GroupedListingsCarousel } from "../../grouped/components/GroupedListing
 import { getGroupsWithItemsForProduct } from "../../../_internal/server/features/grouped/data.js";
 import { ReviewsListingPanel } from "../../reviews/components/ReviewsListingPanel.js";
 import { ListingBottomActions } from "../../products/components/ListingBottomActions.js";
+import { productImageUrls } from "../../products/schemas/firestore.js";
 function toDescriptionHtml(raw) {
     if (!raw)
         return "";
@@ -41,7 +42,15 @@ export async function DigitalCodeDetailPageView({ slug, initialProduct, renderPr
     const currency = p.currency || getDefaultCurrency();
     const title = String(p.title ?? p.name ?? "Digital Code");
     const price = typeof p.price === "number" ? p.price : null;
-    const images = Array.isArray(p.images) ? p.images : typeof p.mainImage === "string" ? [p.mainImage] : [];
+    // `images` is `ProductImage[]` since A6 — `productImageUrls` is the one
+    // normaliser (it also accepts the legacy `string[]`). Casting it to
+    // `string[]` handed the gallery objects and rendered a placeholder.
+    const galleryUrls = productImageUrls(p.images);
+    const images = galleryUrls.length > 0
+        ? galleryUrls
+        : typeof p.mainImage === "string"
+            ? [p.mainImage]
+            : [];
     const meta = product.digitalCode;
     const codesLeft = meta?.codesAvailable ?? 0;
     const category = Array.isArray(p.categorySlugs) && p.categorySlugs.length > 0 ? String(p.categorySlugs[0]) : (typeof p.category === "string" ? p.category : null);

package/dist/features/live/components/LiveItemDetailPageView.js

@@ -24,6 +24,7 @@ import { GroupedListingsCarousel } from "../../grouped/components/GroupedListing
 import { getGroupsWithItemsForProduct } from "../../../_internal/server/features/grouped/data.js";
 import { ReviewsListingPanel } from "../../reviews/components/ReviewsListingPanel.js";
 import { ListingBottomActions } from "../../products/components/ListingBottomActions.js";
+import { productImageUrls } from "../../products/schemas/firestore.js";
 function toDescriptionHtml(raw) {
     if (!raw)
         return "";
@@ -44,7 +45,15 @@ export async function LiveItemDetailPageView({ slug, initialProduct, renderActio
     const currency = p.currency || getDefaultCurrency();
     const title = String(p.title ?? p.name ?? "Live Listing");
     const price = typeof p.price === "number" ? p.price : null;
-    const images = Array.isArray(p.images) ? p.images : typeof p.mainImage === "string" ? [p.mainImage] : [];
+    // `images` is `ProductImage[]` since A6 — `productImageUrls` is the one
+    // normaliser (it also accepts the legacy `string[]`). Casting it to
+    // `string[]` handed the gallery objects and rendered a placeholder.
+    const galleryUrls = productImageUrls(p.images);
+    const images = galleryUrls.length > 0
+        ? galleryUrls
+        : typeof p.mainImage === "string"
+            ? [p.mainImage]
+            : [];
     const productVideo = p.video;
     const meta = product.liveItem;
     const jurisdictions = meta?.jurisdictionAllowed ?? [];

package/dist/features/pre-orders/components/PreOrderDetailPageView.js

@@ -27,6 +27,7 @@ import { ProductGalleryClient } from "../../products/components/ProductGalleryCl
 import { ProductFeatureBadges } from "../../products/components/ProductFeatureBadges.js";
 import { isFinalSale } from "../../products/constants/final-sale.js";
 import { FeatureBadgeList } from "../../products/components/FeatureBadge.js";
+import { productImageUrls } from "../../products/schemas/firestore.js";
 import { ShareButton } from "../../products/components/ShareButton.js";
 import { SublistingCarouselSection } from "../../products/components/SublistingCarouselSection.js";
 import { HistoryTracker } from "../../history/components/HistoryTracker.js";
@@ -86,8 +87,12 @@ export async function PreOrderDetailPageView({ id, initialPreOrder, onReserveNow
     const currency = p.currency || getDefaultCurrency();
     const title = String(p.title ?? p.name ?? "Pre-Order Item");
     const price = typeof p.price === "number" ? p.price : null;
-    const images = Array.isArray(p.images)
-        ? p.images
+    // `images` is `ProductImage[]` since A6 — `productImageUrls` is the one
+    // normaliser (it also accepts the legacy `string[]`). Casting it to
+    // `string[]` handed the gallery objects and rendered a placeholder.
+    const galleryUrls = productImageUrls(p.images);
+    const images = galleryUrls.length > 0
+        ? galleryUrls
         : typeof p.mainImage === "string"
             ? [p.mainImage]
             : [];
@@ -153,11 +158,7 @@ export async function PreOrderDetailPageView({ id, initialPreOrder, onReserveNow
     ]);
     return (_jsxs(Main, { children: [_jsx(HistoryTracker, { productId: String(p.id ?? p.slug ?? ""), productType: "preorder", snapshot: {
                     title: typeof p.title === "string" ? p.title : undefined,
-                    thumb: typeof p.mainImage === "string"
-                        ? p.mainImage
-                        : Array.isArray(p.images) && typeof p.images[0] === "string"
-                            ? p.images[0]
-                            : undefined,
+                    thumb: typeof p.mainImage === "string" ? p.mainImage : images[0],
                     price: typeof p.price === "number" ? p.price : undefined,
                     storeId: typeof p.storeId === "string" ? p.storeId : undefined,
                     storeName: typeof p.storeName === "string" ? p.storeName : undefined,

package/dist/features/price-index/components/PriceIndexToolView.d.ts

@@ -79,6 +79,27 @@ export interface PriceIndexToolResponse {
     truncated: boolean;
     minConfidentSamples: number;
 }
+/**
+ * The competitor-crawl band for one leaf. Mirrors `PriceIndexMarketRow`.
+ *
+ * Every field but `median` and `categoryId` is optional because the crawl
+ * genuinely did not measure them everywhere, and an absent figure must render
+ * as absent. See `price-bands.md`: "a band with `n=2` is not evidence".
+ */
+export interface PriceIndexMarketRowView {
+    categoryId: string;
+    median: number;
+    p25?: number;
+    p75?: number;
+    sampleSize?: number;
+    asOf?: string;
+    soldOutShare?: number;
+    source?: string;
+    inherited: boolean;
+    viaCategoryId?: string;
+    viaName?: string;
+    taxBasis: string;
+}
 export interface PriceIndexToolViewProps {
     /** Seeded from `?q=` so a shared link reproduces the lookup. */
     initialQuery?: string;