@mohasinac/appkit 4.52.5 → 4.53.0

package/dist/features/products/components/ListingBottomActions.js

@@ -29,6 +29,10 @@ export function ListingBottomActions({ listingType, anchorId, price, currency, u
             })),
             infoLabel,
             desktop: "after-scroll",
+            // The element the CTA scrolls to IS this page's inline buy panel, so
+            // it doubles as the dock's reveal gate — no extra prop at any of the
+            // five listing types that share this registrar.
+            ctaAnchorId: anchorId,
         });
     return null;
 }

package/dist/features/products/components/ProductDetailPageView.js

@@ -24,6 +24,7 @@ const CLS_BUNDLE_ROW = "flex items-center justify-between gap-[var(--appkit-spac
 const CLS_BUNDLE_LABEL = "text-[length:var(--appkit-text-xs)] text-success dark:text-success font-medium uppercase tracking-wide mb-0.5";
 const CLS_BUNDLE_CTA = "flex-shrink-0 rounded-lg bg-success-solid hover:brightness-110 px-[var(--appkit-space-3)] py-[var(--appkit-space-1-5)] text-[length:var(--appkit-text-xs)] font-semibold text-success-on-solid transition-colors";
 import { ROUTES } from "../../../next/routing/route-map.js";
+import { ctaAnchorProps } from "../../layout/cta-anchor.js";
 import { ContextualTrail } from "../../categories/components/ContextualTrail.js";
 import { productCrumbs, withTrailHead } from "../../categories/utils/breadcrumb-chain.js";
 import { getDefaultCurrency } from "../../../core/baseline-resolver.js";
@@ -319,7 +320,7 @@ export async function ProductDetailPageView({ slug, initialProduct, renderOfferA
                                         categoryProductCount: (n, cat) => `${n} in ${cat}`,
                                     } }), productFeatures && features.length > 0 && (_jsx(FeatureBadgeList, { productFeatureIds: features, features: productFeatures })), !productFeatures && features.length > 0 && (_jsxs(Div, { border: "subtle", surface: "muted", padding: "inline", rounded: "xl", children: [_jsx(Text, { className: "mb-2 tracking-wide", color: "muted", size: "xs", weight: "semibold", transform: "uppercase", children: "About this product" }), _jsx(Ul, { spacing: "comfortable", size: "sm", color: "primary", children: features.map((f, i) => (_jsxs(Li, { layout: "flex-start", gap: "2", children: [_jsx(Span, { className: "mt-0.5 flex-shrink-0 text-primary-500", children: "\u2022" }), f] }, i))) })] })), descriptionHtml && (_jsx(RichText, { html: descriptionHtml, proseClass: "prose prose-sm max-w-none dark:prose-invert prose-p:my-0", className: "text-[length:var(--appkit-text-sm)] leading-relaxed text-[var(--appkit-color-text-muted)] line-clamp-4" })), safeSeller && (_jsx(Div, { className: `${__P.p3}`, border: "subtle", rounded: "xl", surface: "muted", children: _jsxs(Row, { justify: "between", align: "center", children: [_jsxs(Div, { children: [_jsx(Text, { className: "text-[10px] tracking-wide mb-0.5", color: "faint", transform: "uppercase", children: "Sold by" }), _jsx(Text, { size: "sm", weight: "semibold", color: "primary", children: safeSeller }), typeof p.storeRating === "number" && p.storeRating > 0 && (_jsx(Row, { gap: "xs", align: "center", className: "mt-0.5", children: _jsxs(Text, { size: "xs", color: "muted", children: [_jsx(Span, { className: "text-warning", "aria-hidden": "true", children: "\u2605" }), " ", p.storeRating.toFixed(1), typeof p.storeReviewCount === "number" &&
                                                                     p.storeReviewCount > 0 &&
-                                                                    ` · ${p.storeReviewCount} reviews`] }) }))] }), _jsxs(Row, { gap: "xs", align: "center", className: "shrink-0", children: [storeId && _jsx(MessageSellerButton, { storeId: storeId }), storeHref && (_jsx(Link, { href: storeHref, className: "rounded-lg bg-primary/10 dark:bg-primary/20 px-[var(--appkit-space-3)] py-[var(--appkit-space-1-5)] text-[length:var(--appkit-text-xs)] font-semibold text-primary-700 dark:text-primary-300 hover:bg-primary/20 dark:hover:bg-primary/30 transition-colors", children: "Visit Store \u2192" }))] })] }) }))] })), renderActions: () => (_jsxs(Stack, { className: `${__P.p5}`, border: "subtle", gap: "md", rounded: "xl", surface: "muted", children: [price !== null && (_jsxs(Div, { children: [_jsx(PriceDisplay, { amount: price, originalAmount: originalPrice ?? undefined, currency: currency, variant: "detail" }), _jsx(MarketPriceAnchor, { band: priceBand?.byListingType?.[normalizeListingType(p)] ?? null, windowDays: priceBand?.windowDays ?? null, currency: currency, price: price }), inStock && effectiveStock !== null && effectiveStock <= 3 && (_jsxs(Text, { className: "mt-1 text-warning", size: "xs", children: ["Only ", effectiveStock, " left \u2014 order soon!"] })), inStock && effectiveStock !== null && effectiveStock > 3 && effectiveStock <= 10 && (_jsxs(Text, { className: "mt-1", color: "muted", size: "xs", children: [effectiveStock, " in stock"] }))] })), _jsxs(Stack, { gap: "sm", children: [renderPrimaryActions ? (renderPrimaryActions({
+                                                                    ` · ${p.storeReviewCount} reviews`] }) }))] }), _jsxs(Row, { gap: "xs", align: "center", className: "shrink-0", children: [storeId && _jsx(MessageSellerButton, { storeId: storeId, productId: product.id }), storeHref && (_jsx(Link, { href: storeHref, className: "rounded-lg bg-primary/10 dark:bg-primary/20 px-[var(--appkit-space-3)] py-[var(--appkit-space-1-5)] text-[length:var(--appkit-text-xs)] font-semibold text-primary-700 dark:text-primary-300 hover:bg-primary/20 dark:hover:bg-primary/30 transition-colors", children: "Visit Store \u2192" }))] })] }) }))] })), renderActions: () => (_jsxs(Stack, { className: `${__P.p5}`, border: "subtle", gap: "md", rounded: "xl", surface: "muted", children: [price !== null && (_jsxs(Div, { children: [_jsx(PriceDisplay, { amount: price, originalAmount: originalPrice ?? undefined, currency: currency, variant: "detail" }), _jsx(MarketPriceAnchor, { band: priceBand?.byListingType?.[normalizeListingType(p)] ?? null, windowDays: priceBand?.windowDays ?? null, currency: currency, price: price }), inStock && effectiveStock !== null && effectiveStock <= 3 && (_jsxs(Text, { className: "mt-1 text-warning", size: "xs", children: ["Only ", effectiveStock, " left \u2014 order soon!"] })), inStock && effectiveStock !== null && effectiveStock > 3 && effectiveStock <= 10 && (_jsxs(Text, { className: "mt-1", color: "muted", size: "xs", children: [effectiveStock, " in stock"] }))] })), _jsxs(Stack, { gap: "sm", ...ctaAnchorProps(), children: [renderPrimaryActions ? (renderPrimaryActions({
                                             productId: product.id,
                                             productSlug: product.slug ?? slug,
                                             productTitle: product.title,

package/dist/features/products/components/ProductGalleryClient.js

@@ -31,7 +31,7 @@ export function ProductGalleryClient({ images, video, productName }) {
         return (_jsx(Div, { className: `${__O.hidden}`, border: "subtle", rounded: "xl", surface: "muted", children: _jsx(Row, { className: "aspect-square text-[var(--appkit-color-border)] dark:text-[var(--appkit-color-border-subtle)]", align: "center", justify: "center", children: _jsx(PlaceholderSvg, {}) }) }));
     }
     const activeSlide = slides[activeIndex] ?? slides[0];
-    return (_jsxs(Stack, { gap: "3", children: [_jsxs(Div, { rounded: "xl", className: "overflow-hidden border border-[var(--appkit-color-border-subtle)] cursor-zoom-in aspect-square w-full relative", onClick: () => setLightboxIndex(activeIndex), role: "button", tabIndex: 0, onKeyDown: (e) => {
+    return (_jsxs(Stack, { gap: "3", children: [_jsxs(Div, { rounded: "xl", surface: "muted", className: "overflow-hidden border border-[var(--appkit-color-border-subtle)] cursor-zoom-in aspect-square w-full relative", onClick: () => setLightboxIndex(activeIndex), role: "button", tabIndex: 0, onKeyDown: (e) => {
                     if (e.key === "Enter" || e.key === " ")
                         setLightboxIndex(activeIndex);
                 }, "aria-label": activeSlide.kind === "video"
@@ -42,7 +42,7 @@ export function ProductGalleryClient({ images, video, productName }) {
                                 : "Product video"
                             : productName
                                 ? `${productName} — image ${activeIndex + 1}`
-                                : `Product image ${activeIndex + 1}`, size: "gallery", className: "transition-transform duration-300 hover:scale-105" }), activeSlide.kind === "video" && (_jsx(Row, { className: "absolute inset-0 pointer-events-none", align: "center", justify: "center", children: _jsx(Row, { surface: "overlay-sm", rounded: "full", className: "h-16 w-16 text-white", align: "center", justify: "center", children: _jsx(Play, { className: "h-7 w-7 fill-current", "aria-hidden": "true" }) }) }))] }), slides.length > 1 && (_jsx(Div, { layout: "flex", gap: "2", className: `${__O.xAuto}`, padding: "b-2xs", children: slides.map((slide, i) => (_jsxs(Button, { variant: "ghost", type: "button", onClick: () => setActiveIndex(i), rounded: "lg", paddingX: "none", paddingY: "none", className: `relative flex-shrink-0 h-16 w-16 overflow-hidden border-2 transition-all${i === activeIndex
+                                : `Product image ${activeIndex + 1}`, size: "gallery", objectFit: "contain", className: "transition-transform duration-300 hover:scale-105" }), activeSlide.kind === "video" && (_jsx(Row, { className: "absolute inset-0 pointer-events-none", align: "center", justify: "center", children: _jsx(Row, { surface: "overlay-sm", rounded: "full", className: "h-16 w-16 text-white", align: "center", justify: "center", children: _jsx(Play, { className: "h-7 w-7 fill-current", "aria-hidden": "true" }) }) }))] }), slides.length > 1 && (_jsx(Div, { layout: "flex", gap: "2", className: `${__O.xAuto}`, padding: "b-2xs", children: slides.map((slide, i) => (_jsxs(Button, { variant: "ghost", type: "button", onClick: () => setActiveIndex(i), rounded: "lg", paddingX: "none", paddingY: "none", className: `relative flex-shrink-0 h-16 w-16 overflow-hidden border-2 transition-all${i === activeIndex
                         ? " border-primary-500"
                         : " border-transparent opacity-60 hover:opacity-100"}`, "aria-label": slide.kind === "video" ? "View video" : `View image ${i + 1}`, "aria-current": i === activeIndex ? "true" : undefined, children: [_jsx(MediaImage, { src: slide.kind === "video" ? slide.poster : slide.src, alt: slide.kind === "video" ? "Video thumbnail" : `Thumbnail ${i + 1}`, size: "thumbnail" }), slide.kind === "video" && (_jsx(Row, { surface: "overlay-xs", className: "absolute inset-0 pointer-events-none", align: "center", justify: "center", children: _jsx(Play, { className: "h-5 w-5 text-white fill-current", "aria-hidden": "true" }) }))] }, i))) })), slides.length > 1 && (
             // audit-content-alignment-ok: functional image-counter label under the gallery, not page content

package/dist/features/products/components/ProductGrid.js

@@ -165,7 +165,18 @@ function safeHref(href) {
     if (!href)
         return undefined;
     // drop any href that would navigate to a literal "/undefined" segment
-    if (href.includes("/undefined") || href.includes("/null"))
+    /*
+     * A SEGMENT that is literally "undefined"/"null" means an interpolation
+     * produced one — `/products/${maybeUndefined}`.
+     *
+     * Tested with a regex rather than `.includes("/undefined")`, which kills two
+     * birds: a regex literal is not a string Literal node, so the route-literal
+     * rule has nothing to flag and the eslint-disable that used to sit here is
+     * gone; and `.includes` matched any slug CONTAINING the word, so a real
+     * listing at `/products/undefined-sequence-bey` was silently dropped from
+     * the grid. The anchors make it a whole-segment test.
+     */
+    if (/\/(?:undefined|null)(?:\/|$)/.test(href))
         return undefined;
     return href;
 }

package/dist/features/products/components/index.d.ts

@@ -32,8 +32,6 @@ export { FeatureBadge, FeatureBadgeList } from "./FeatureBadge";
 export type { FeatureBadgeProps, FeatureBadgeListProps, } from "./FeatureBadge";
 export { ProductFeaturesProvider, useProductFeatures, } from "./ProductFeaturesContext";
 export type { ProductFeaturesProviderProps } from "./ProductFeaturesContext";
-export { ProductsView } from "./ProductsView";
-export type { ProductsViewProps } from "./ProductsView";
 export { ProductDetailView } from "./ProductDetailView";
 export type { ProductDetailViewProps } from "./ProductDetailView";
 export { AuctionDetailView } from "./AuctionDetailView";

package/dist/features/products/components/index.js

@@ -21,7 +21,6 @@ export { ProductFeaturesSelector } from "./ProductFeaturesSelector.js";
 export { ProductFeatureBadges } from "./ProductFeatureBadges.js";
 export { FeatureBadge, FeatureBadgeList } from "./FeatureBadge.js";
 export { ProductFeaturesProvider, useProductFeatures, } from "./ProductFeaturesContext.js";
-export { ProductsView } from "./ProductsView.js";
 export { ProductDetailView } from "./ProductDetailView.js";
 export { AuctionDetailView } from "./AuctionDetailView.js";
 export { PreOrderDetailView } from "./PreOrderDetailView.js";

package/dist/features/products/config/listing-type-listing-config.d.ts

@@ -11,11 +11,8 @@ export interface ListingTypeListingRow {
     image?: string;
 }
 interface ListingTypeListingResponse {
-    /** Admin route shape. */
     items?: JsonArray;
     total?: number;
-    /** Seller route shape. */
-    products?: JsonArray;
     meta?: {
         total?: number;
     };

package/dist/features/products/config/listing-type-listing-config.js

@@ -55,8 +55,15 @@ export function buildListingTypeListingConfig(type, opts = {}) {
         endpoint: isSeller ? SELLER_ENDPOINTS.PRODUCTS : ADMIN_ENDPOINTS.PRODUCTS,
         // The type's own sort set, not a copy-pasted three-option array.
         sortOptions: [...plugin.sortOptions],
-        // The seller route returns `{ products }`, the admin route `{ items }`.
-        mapRows: (response) => toRecordArray(response.items ?? response.products).map((item, index) => ({
+        mapRows: (response) => 
+        /*
+         * `items` only. The `?? response.products` fallback is gone because both
+         * endpoints this config reads (`/api/admin/products`, `/api/store/products`)
+         * now emit the canonical key — verified before removing it. A defence
+         * against a shape that no longer exists reads as though the shape still
+         * might, which is how two spellings stay alive forever.
+         */
+        toRecordArray(response.items).map((item, index) => ({
             id: toStringValue(item.id, `${type}-${index}`),
             primary: toStringValue(item.title ?? item.productTitle, "Untitled listing"),
             secondary: [
@@ -82,5 +89,23 @@ export function buildListingTypeListingConfig(type, opts = {}) {
         // These are products filtered by listingType — reuse the real product
         // editor rather than leaving rows non-navigable.
         rowHrefTemplate: String(isSeller ? ROUTES.STORE.PRODUCTS_EDIT("{id}") : ROUTES.ADMIN.PRODUCTS_EDIT("{id}")),
+        /*
+         * Create, with THIS type preselected.
+         *
+         * All five pages this factory backs (art, classified, digital-codes, live,
+         * stickers) had no create control of any kind. `?listingType=` is read by
+         * the create page and passed to the editor as `initialListingType`, so an
+         * admin landing from the Art list starts on an art listing rather than on
+         * `standard` — which, on a type-scoped list, would create a row that
+         * immediately vanishes from the page it was created on.
+         *
+         * 🛑 A `primaryAction.href` rather than a `toolbarExtra` node: this is a
+         * `.ts` factory and cannot author JSX, which is the structural reason
+         * these five screens went without.
+         */
+        primaryAction: {
+            label: `Add ${plugin.typeLabel}`,
+            href: `${String(isSeller ? ROUTES.STORE.PRODUCTS_NEW : ROUTES.ADMIN.PRODUCTS_NEW)}?${PRODUCT_FIELDS.LISTING_TYPE}=${encodeURIComponent(type)}`,
+        },
     };
 }

package/dist/features/products/constants/listing-tabs.d.ts

@@ -20,6 +20,7 @@
  * relevant array explicitly — those are genuinely different collections.
  */
 import type { ListingType } from "../types";
+import type { IconKey } from "../../../ui/icons/icon-registry";
 export interface ListingTab {
     id: string;
     label: string;
@@ -31,6 +32,14 @@ export interface ListingTab {
     collection?: "bundles";
     /** Set when the tab queries a non-product entity (e.g. `stores`). */
     entity?: "stores";
+    /**
+     * Leading glyph, carried from `ListingTypePlugin.iconKey`.
+     *
+     * Only set on tabs backed by ONE listing type. The combined Art & Stickers
+     * tab leaves it unset on purpose: it spans two types with two different
+     * glyphs, and picking either would claim the tab is only that one.
+     */
+    iconName?: IconKey;
 }
 /**
  * The types the generic `/products` browse page spans — the GENERAL CATALOGUE,

package/dist/features/products/constants/listing-tabs.js

@@ -58,7 +58,8 @@ export const ART_STICKERS_LISTING_TYPES = ["art", "stickers"];
  * straight into `sieveFilter("listingType", EQ, id)`. Never a display label.
  */
 function chipTab(type) {
-    return { id: type, label: pluginFor(type).chipLabel, listingType: type };
+    const plugin = pluginFor(type);
+    return { id: type, label: plugin.chipLabel, listingType: type, iconName: plugin.iconKey };
 }
 /**
  * A ROUTE-BACKED tab — `id` is the plugin's `tabSlug`, because it doubles as
@@ -67,7 +68,7 @@ function chipTab(type) {
  */
 function pluralTab(type) {
     const plugin = pluginFor(type);
-    return { id: plugin.tabSlug, label: plugin.pluralLabel, listingType: type };
+    return { id: plugin.tabSlug, label: plugin.pluralLabel, listingType: type, iconName: plugin.iconKey };
 }
 /**
  * Art and stickers share the combined `/art` browse page, so category/brand/

package/dist/features/products/hooks/useProducts.js

@@ -57,8 +57,8 @@ export function useProducts(params = {}, opts) {
         sp.set(LISTING_PARAM_NAMES.sorts.long, params.sort);
     if (params.page)
         sp.set("page", String(params.page));
-    if (params.perPage)
-        sp.set("pageSize", String(params.perPage));
+    if (params.pageSize)
+        sp.set("pageSize", String(params.pageSize));
     if (params.featured !== undefined)
         sp.set("featured", String(params.featured));
     if (params.minBid !== undefined)

package/dist/features/products/repository/products.repository.js

@@ -6,7 +6,14 @@ import { increment, serverTimestamp } from "../../../contracts/field-ops.js";
 // classified branch to a generic 500 — Root Cause #53.
 import { DatabaseError } from "../../../errors/index.js";
 import { BaseRepository, prepareForFirestore, parseSieveDateValue, } from "../../../providers/db-firebase/index.js";
-import { cacheManager } from "../../../core/index.js";
+/*
+ * The DEFINING module, not the `core` barrel — Root Cause #18. `core/index.ts`
+ * re-exports `unitOfWork`, which imports this very repository, so reaching
+ * `cacheManager` through the barrel closed a six-module import cycle
+ * (`audit-import-cycles` component 2). `CacheManager.ts` imports nothing from
+ * here, so the deep path has one direction only.
+ */
+import { cacheManager } from "../../../core/CacheManager.js";
 import { serverLogger } from "../../../monitoring/index.js";
 import { generateUniqueId, slugify, generateBarcodeId } from "../../../utils/index.js";
 import { parseSearchTxtQuery } from "../../../utils/search-txt.js";
@@ -1198,6 +1205,11 @@ export class ProductRepository extends BaseRepository {
             baseQuery = baseQuery.where(PRODUCT_FIELDS.STORE_ID, "==", opts.storeId);
         }
         // Longest term first — only ONE may become the array-contains clause.
+        // audit-listing-search-ok: builder, not an entry point. The empty guard is
+        // `if (plan.empty) return emptySearchResult()` in `list()` (~line 1783),
+        // which is one of only two callers of this private method; the other,
+        // `countByListingTypes`, declares no `search` in its opts type and so
+        // structurally cannot pass one.
         const searchTxt = parseSearchTxtQuery(opts?.search ?? "");
         if (searchTxt.length > 0) {
             // Firestore permits a single array operator per query, so when a search

package/dist/features/products/schemas/index.d.ts

@@ -623,7 +623,6 @@ export declare const productListParamsSchema: z.ZodObject<{
     status?: "published" | "draft" | "in_review" | "archived" | undefined;
     page?: number | undefined;
     q?: string | undefined;
-    perPage?: number | undefined;
     listingType?: "classified" | "standard" | "auction" | "pre-order" | "prize-draw" | "digital-code" | "live" | undefined;
     category?: string | undefined;
     storeId?: string | undefined;
@@ -632,12 +631,12 @@ export declare const productListParamsSchema: z.ZodObject<{
     minPrice?: number | undefined;
     maxPrice?: number | undefined;
     inStock?: boolean | undefined;
+    perPage?: number | undefined;
 }, {
     sort?: string | undefined;
     status?: "published" | "draft" | "in_review" | "archived" | undefined;
     page?: number | undefined;
     q?: string | undefined;
-    perPage?: number | undefined;
     listingType?: "classified" | "standard" | "auction" | "pre-order" | "prize-draw" | "digital-code" | "live" | undefined;
     category?: string | undefined;
     storeId?: string | undefined;
@@ -646,4 +645,5 @@ export declare const productListParamsSchema: z.ZodObject<{
     minPrice?: number | undefined;
     maxPrice?: number | undefined;
     inStock?: boolean | undefined;
+    perPage?: number | undefined;
 }>;

package/dist/features/products/types/index.d.ts

@@ -205,7 +205,7 @@ export interface ProductListParams {
     storeId?: string;
     sort?: string;
     page?: number;
-    perPage?: number;
+    pageSize?: number;
     featured?: boolean;
     /** Auction-specific: current bid range */
     minBid?: number;

package/dist/features/promotions/api/route.js

@@ -64,7 +64,7 @@ export async function GET(request) {
             filters,
             sort,
             page,
-            perPage: pageSize,
+            pageSize: pageSize,
         });
         const totalPages = Math.max(1, Math.ceil(result.total / pageSize));
         const body = {

package/dist/features/reviews/actions/review-actions.d.ts

@@ -5,7 +5,7 @@
  * Auth and rate-limit stay in consumer server-action wrappers.
  */
 import type { FirebaseSieveResult } from "../../../providers/db-firebase";
-import type { ReviewDocument } from "../schemas";
+import type { ReviewPlain, ReviewDocument } from "../schemas";
 export interface CreateReviewActionInput {
     productId: string;
     rating: number;
@@ -22,7 +22,7 @@ export interface UpdateReviewActionInput {
     images?: string[];
     videoUrl?: string | null;
 }
-export declare function createReview(userId: string, input: CreateReviewActionInput): Promise<ReviewDocument>;
+export declare function createReview(userId: string, input: CreateReviewActionInput): Promise<ReviewPlain>;
 export declare function updateReview(userId: string, reviewId: string, input: UpdateReviewActionInput): Promise<ReviewDocument | null>;
 export declare function deleteReview(userId: string, reviewId: string): Promise<void>;
 export declare function adminUpdateReview(adminId: string, reviewId: string, input: UpdateReviewActionInput): Promise<ReviewDocument | null>;
@@ -35,13 +35,13 @@ export declare function voteReviewHelpful(reviewId: string, helpful: boolean, us
     counted: boolean;
     helpfulCount: number;
 }>;
-export declare function listReviewsByProduct(productId: string, page?: number, pageSize?: number): Promise<FirebaseSieveResult<ReviewDocument>>;
+export declare function listReviewsByProduct(productId: string, page?: number, pageSize?: number): Promise<FirebaseSieveResult<ReviewPlain>>;
 export declare function listAdminReviews(params?: {
     filters?: string;
     sorts?: string;
     page?: number;
     pageSize?: number;
-}): Promise<FirebaseSieveResult<ReviewDocument>>;
-export declare function listReviewsBySeller(sellerId: string): Promise<ReviewDocument[]>;
-export declare function getHomepageReviews(): Promise<ReviewDocument[]>;
+}): Promise<FirebaseSieveResult<ReviewPlain>>;
+export declare function listReviewsBySeller(sellerId: string): Promise<ReviewPlain[]>;
+export declare function getHomepageReviews(): Promise<ReviewPlain[]>;
 export declare function getReviewById(id: string): Promise<ReviewDocument | null>;

package/dist/features/reviews/actions/review-actions.js

@@ -7,7 +7,6 @@
 import { sortBy } from "@mohasinac/appkit";
 import { AuthorizationError, NotFoundError, ValidationError, } from "../../../errors/index.js";
 import { serverLogger } from "../../../monitoring/index.js";
-import { maskPublicReview } from "../../../security/index.js";
 import { finalizeStagedMediaArray, finalizeStagedMediaUrl, } from "../../media/finalize.js";
 import { reviewRepository } from "../repository/reviews.repository.js";
 import { safeRead } from "../../../errors/safe-read.js";
@@ -29,7 +28,7 @@ export async function createReview(userId, input) {
         uid: userId,
         productId: input.productId,
     });
-    return reviewRepository.create({
+    return reviewRepository.createReview({
         productId: input.productId,
         productTitle: product.title,
         listingType: product.listingType,
@@ -162,10 +161,14 @@ export async function listReviewsByProduct(productId, page = 1, pageSize = 10) {
         page,
         pageSize,
     });
-    return {
-        ...result,
-        items: result.items.map((item) => maskPublicReview(item)),
-    };
+    /*
+     * No second mask. `reviewRepository.listAll` returns `ReviewPlain` already
+     * masked by `maskSieveResult`, so `maskPublicReview` here would mask an
+     * already-masked name — and worse, it was being handed ciphertext before
+     * that method was converted, where `maskName`'s `hasEncPrefix` guard answers
+     * "Anonymous" for every row.
+     */
+    return result;
 }
 export async function listAdminReviews(params) {
     const sieve = {
@@ -199,11 +202,22 @@ export async function listReviewsBySeller(sellerId) {
     return reviewBatches
         .flat()
         .sort((a, b) => new Date(b.createdAt).getTime() - new Date(a.createdAt).getTime())
-        .map((item) => maskPublicReview(item));
+        /*
+         * `maskedReview`, not `maskPublicReview`.
+         *
+         * These come from `findApprovedByStore`, a `find*` method that returns raw
+         * documents — only the three `list*` methods mask. `maskPublicReview`
+         * calls `maskName`, which refuses ciphertext by design and answers
+         * "Anonymous", so this public list showed every reviewer as Anonymous.
+         * `maskedReview` decrypts first, then masks.
+         */
+        .map((item) => reviewRepository.maskedReview(item));
 }
 export async function getHomepageReviews() {
     const reviews = await reviewRepository.findFeatured(18);
-    return reviews.map((item) => maskPublicReview(item));
+    // `findFeatured` returns raw documents — see the note above on why
+    // `maskPublicReview` cannot be used on them.
+    return reviews.map((item) => reviewRepository.maskedReview(item));
 }
 export async function getReviewById(id) {
     return reviewRepository.findById(id);

package/dist/features/reviews/components/ReviewDetailPageView.js

@@ -11,7 +11,19 @@ export async function ReviewDetailPageView({ id }) {
     // become the same `null` a removed review produces, which the "Review not
     // found" branch below already handles.
     const doc = await reviewRepository.findById(id);
-    const review = doc;
+    /*
+     * 🛑 MASKED, not the raw document.
+     *
+     * `findById` returns ciphertext since `mapDoc` stopped decrypting, and
+     * `ReviewDetailShell` calls `maskName(review.userName)` — which refuses
+     * ciphertext by design and answers "Anonymous". So this page rendered every
+     * reviewer as "Anonymous". `maskedReview` decrypts and then masks, which is
+     * what the shell was always assuming it had been handed.
+     *
+     * The `as Review` cast is what hid it: it erased the brand, so nothing in
+     * the type system could object.
+     */
+    const review = (doc ? reviewRepository.maskedReview(doc) : null);
     // storeId === storeSlug for stores in this project (pure slug IDs)
     const storeSlug = doc?.storeId ?? null;
     if (!review || review.status !== "approved") {

package/dist/features/reviews/components/ReviewsIndexPageView.js

@@ -31,20 +31,37 @@ function buildReviewFilters(params) {
         parts.push(sieveFilter("createdAt", SIEVE_OP.GTE, dateFrom));
     if (dateTo)
         parts.push(sieveFilter("createdAt", SIEVE_OP.LTE, dateTo));
-    const q = sp(params, "q");
-    if (q)
-        parts.push(`productTitle@=*${q}`);
+    /*
+     * 🛑 `q` is deliberately NOT a filter clause, and emitting it as one was a
+     * live defect rather than an untidy spelling.
+     *
+     * `productTitle@=*` is a case-insensitive operator the Firebase adapter
+     * THROWS on, and the Sieve processor runs `throwExceptions: false` — so the
+     * throw became silence and **every clause and the sort were discarded with
+     * it**. `/reviews?q=anything` therefore returned the whole table, newest-ish,
+     * ignoring rating, verified, date range and vote filters too.
+     *
+     * `/api/reviews` fixed exactly this and passes `q` to `listAll` as a
+     * `{ search }` OPT (array-contains over `searchTxt`, which Sieve cannot
+     * express). This SSR view queries the same collection and never got the
+     * back-port — Root Cause #99, which says in as many words: when fixing a
+     * filter in an API route, grep for the SSR view that queries the same
+     * collection. It is also why the view could not self-correct: it hands its
+     * result down as `initialData`, and `staleTime: Infinity` freezes an
+     * unfiltered first paint for that query key forever (Root Cause #30).
+     */
     return parts.join(",");
 }
 export async function ReviewsIndexPageView({ searchParams = {} }) {
     const sort = sp(searchParams, "sort") || "-createdAt";
     const page = Number(sp(searchParams, "page")) || 1;
     const filters = buildReviewFilters(searchParams);
+    const q = sp(searchParams, "q");
     // audit-public-test-data-ok: `ReviewDocument` carries no `isTestData` field —
     // tsc rejects the filter outright, which is the honest signal that reviews
     // have no sandbox concept to strip. A review OF a sandbox product is not
     // flagged today; that is a seed-schema gap, not something a cast should hide.
-    const result = await safeRead(() => reviewRepository.listAll({ filters, sorts: sort, page, pageSize: 12 }), { route: "/reviews", key: "reviews.listAll", fallback: null });
+    const result = await safeRead(() => reviewRepository.listAll({ filters, sorts: sort, page, pageSize: 12 }, q ? { search: q } : undefined), { route: "/reviews", key: "reviews.listAll", fallback: null });
     const initialData = result
         ? {
             items: result.items,

package/dist/features/reviews/repository/reviews.repository.d.ts

@@ -1,7 +1,7 @@
 import type { JsonValue } from "../../../schemas/types";
 import type { FirebaseSieveResult, SieveModel } from "../../../providers/db-firebase";
 import { BaseRepository, parseSieveDateValue } from "../../../providers/db-firebase";
-import { type ReviewCreateInput, type ReviewDocument } from "../schemas";
+import { type ReviewCreateInput, type ReviewDocument, type ReviewPlain } from "../schemas";
 import type { ReviewStatus } from "../types";
 export interface ReviewRatingAggregate {
     count: number;
@@ -9,7 +9,7 @@ export interface ReviewRatingAggregate {
 }
 declare class ReviewRepository extends BaseRepository<ReviewDocument> {
     constructor();
-    private decryptSieveResult;
+    private maskSieveResult;
     /**
      * Declared, not hand-rolled.
      *
@@ -24,8 +24,20 @@ declare class ReviewRepository extends BaseRepository<ReviewDocument> {
     protected piiFields: readonly ["userName"];
     protected piiIndexMap: Record<string, string>;
     protected mapDoc<D = ReviewDocument>(snap: import("../../../providers/db-firebase").DocumentSnapshot): D;
-    create(input: ReviewCreateInput): Promise<ReviewDocument>;
-    update(reviewId: string, data: Partial<ReviewDocument>): Promise<ReviewDocument>;
+    /** Plaintext PII. **Opt-in and named** — shows up in review and in a grep. */
+    revealReview(doc: ReviewDocument): ReviewPlain;
+    /** As `revealReview`, for a list read. */
+    revealReviews(docs: readonly ReviewDocument[]): ReviewPlain[];
+    /**
+     * Masked PII — **the default for any public surface.** Decrypts first, then
+     * masks: `maskName` returns "Anonymous" for a ciphertext input by design, so
+     * handing it a stored `userName` would anonymise every reviewer.
+     */
+    maskedReview(doc: ReviewDocument): ReviewPlain;
+    /** As `maskedReview`, for a list read. */
+    maskedReviews(docs: readonly ReviewDocument[]): ReviewPlain[];
+    createReview(input: ReviewCreateInput): Promise<ReviewPlain>;
+    update(reviewId: string, data: Partial<ReviewPlain>): Promise<ReviewDocument>;
     findByProduct(productId: string): Promise<ReviewDocument[]>;
     /**
      * Approved reviews for a product, newest first.
@@ -196,8 +208,8 @@ declare class ReviewRepository extends BaseRepository<ReviewDocument> {
             parseValue: typeof parseSieveDateValue;
         };
     };
-    listForProduct(productId: string, model: SieveModel): Promise<FirebaseSieveResult<ReviewDocument>>;
-    listForStore(storeId: string, model: SieveModel): Promise<FirebaseSieveResult<ReviewDocument>>;
+    listForProduct(productId: string, model: SieveModel): Promise<FirebaseSieveResult<ReviewPlain>>;
+    listForStore(storeId: string, model: SieveModel): Promise<FirebaseSieveResult<ReviewPlain>>;
     /**
      * Derived on every write path via `applyWriteHooks`.
      *
@@ -207,7 +219,7 @@ declare class ReviewRepository extends BaseRepository<ReviewDocument> {
     protected buildSearchTxtFor(data: Record<string, JsonValue>): string[] | null;
     listAll(model: SieveModel, opts?: {
         search?: string;
-    }): Promise<FirebaseSieveResult<ReviewDocument>>;
+    }): Promise<FirebaseSieveResult<ReviewPlain>>;
 }
 declare const reviewRepository: ReviewRepository;
 export { ReviewRepository, reviewRepository };