@mohasinac/appkit 4.5.1 → 4.5.3

package/dist/_internal/client/features/layout/RoleGuard.d.ts

@@ -1,4 +1,4 @@
-import type { ReactNode } from "react";
+import { type ReactNode } from "react";
 import type { LayoutRole } from "../../../shared/features/layout/types";
 export interface RoleGuardProps {
     /** Single role or array. Omit for auth-only (any signed-in user). */

package/dist/_internal/client/features/layout/RoleGuard.js

@@ -12,13 +12,34 @@ import { jsx as _jsx } from "react/jsx-runtime";
  * route overrides. Everything else defaults to appkit's ROUTES.
  */
 import { useRouter } from "next/navigation";
+import { useEffect, useRef, useState } from "react";
 import { ProtectedRoute } from "../../../../features/auth/components/Guards";
 import { useSession } from "../../../../react/contexts/SessionContext";
 import { ROUTES } from "../../../../next/routing/route-map";
 export function RoleGuard({ role, requireAuth = true, loginPath, unauthorizedPath, loadingComponent, children, }) {
-    const { user, loading } = useSession();
+    const { user, loading, refreshUser } = useSession();
     const router = useRouter();
-    return (_jsx(ProtectedRoute, { user: user, loading: loading, requireAuth: requireAuth, requireRole: role, onNavigate: (path) => router.push(path), routes: {
+    // SessionContext only refreshes role/disabled periodically (every 5
+    // minutes) or on a hard reload/re-login — never on ordinary client-side
+    // navigation. A user just approved as a seller, or just un-banned, would
+    // otherwise keep getting redirected to /unauthorized by this exact guard
+    // for up to 5 minutes even though the same check against live Firestore
+    // data would already pass. Force one fresh check per mount (i.e. once per
+    // navigation into a role-gated layout, since Next.js layouts persist
+    // across sibling route changes) before trusting a denial.
+    const hasRefreshedRef = useRef(false);
+    const [verifying, setVerifying] = useState(true);
+    useEffect(() => {
+        if (loading || hasRefreshedRef.current)
+            return;
+        hasRefreshedRef.current = true;
+        if (!user) {
+            setVerifying(false);
+            return;
+        }
+        refreshUser().finally(() => setVerifying(false));
+    }, [loading, user, refreshUser]);
+    return (_jsx(ProtectedRoute, { user: user, loading: loading || verifying, requireAuth: requireAuth, requireRole: role, onNavigate: (path) => router.push(path), routes: {
             loginPath: loginPath ?? String(ROUTES.AUTH.LOGIN),
             unauthorizedPath: unauthorizedPath ?? String(ROUTES.ERRORS.UNAUTHORIZED),
         }, loadingComponent: loadingComponent, children: children }));

package/dist/features/categories/components/BrandDetailTabs.js

@@ -16,20 +16,6 @@ const TAB_TYPE_MAP = {
     bundles: { kind: "category", type: "bundle" },
 };
 export function BrandDetailTabs({ brandName, initialProductsData, initialBundles = [], counts, enabledListingTypes, enabledCategoryTypes, }) {
-    const visibleTabs = CATEGORY_PAGE_TABS.filter((t) => {
-        const mapping = TAB_TYPE_MAP[t.id];
-        if (!mapping)
-            return true;
-        if (mapping.kind === "listing" && enabledListingTypes) {
-            return enabledListingTypes.includes(mapping.type);
-        }
-        if (mapping.kind === "category" && enabledCategoryTypes) {
-            return enabledCategoryTypes.includes(mapping.type);
-        }
-        return true;
-    });
-    const firstTabId = (visibleTabs[0]?.id ?? "products");
-    const [activeTab, setActiveTab] = useState(firstTabId);
     const countFor = (id) => {
         switch (id) {
             case "products": return counts?.products;
@@ -40,5 +26,28 @@ export function BrandDetailTabs({ brandName, initialProductsData, initialBundles
             default: return undefined;
         }
     };
+    const visibleTabs = CATEGORY_PAGE_TABS.filter((t) => {
+        const mapping = TAB_TYPE_MAP[t.id];
+        // This view only has content renderers for the 5 tab ids in
+        // TAB_TYPE_MAP (products/auctions/pre-orders/prize-draws/bundles) — any
+        // other CATEGORY_PAGE_TABS id (stores, classifieds, etc.) has no case in
+        // the render switch below and would show a blank tab, so exclude those
+        // here rather than rely on downstream JSX to silently render nothing.
+        if (!mapping)
+            return false;
+        if (mapping.kind === "listing" && enabledListingTypes) {
+            if (!enabledListingTypes.includes(mapping.type))
+                return false;
+        }
+        if (mapping.kind === "category" && enabledCategoryTypes) {
+            if (!enabledCategoryTypes.includes(mapping.type))
+                return false;
+        }
+        // Hide a tab only when its count is known and explicitly zero.
+        const count = countFor(t.id);
+        return count === undefined || count > 0;
+    });
+    const firstTabId = (visibleTabs[0]?.id ?? "products");
+    const [activeTab, setActiveTab] = useState(firstTabId);
     return (_jsxs(_Fragment, { children: [_jsx(Tabs, { value: activeTab, onChange: (v) => setActiveTab(v), className: "mb-6", children: _jsx(TabsList, { children: visibleTabs.map((t) => (_jsx(TabsTrigger, { value: t.id, badge: countFor(t.id), children: t.label }, t.id))) }) }), activeTab === "products" && (_jsx(CategoryProductsListing, { categorySlug: "", brandName: brandName, initialData: initialProductsData })), activeTab === "auctions" && (_jsx(AuctionsIndexListing, { brandName: brandName })), activeTab === "pre-orders" && (_jsx(PreOrdersIndexListing, { brandName: brandName })), activeTab === "prize-draws" && (_jsx(PrizeDrawsIndexListing, { brandName: brandName })), activeTab === "bundles" && (_jsx(CategoryBundlesListing, { initialBundles: initialBundles, brandName: brandName }))] }));
 }

package/dist/features/categories/components/CategoryDetailTabs.js

@@ -19,22 +19,6 @@ const TAB_TYPE_MAP = {
     stores: { kind: "entity", type: "stores" },
 };
 export function CategoryDetailTabs({ categorySlug, categoryId, initialProductsData, initialBundles = [], initialStores = [], counts, enabledListingTypes, enabledCategoryTypes, }) {
-    const visibleTabs = CATEGORY_PAGE_TABS.filter((t) => {
-        const mapping = TAB_TYPE_MAP[t.id];
-        if (!mapping)
-            return true;
-        if (mapping.kind === "listing" && enabledListingTypes) {
-            return enabledListingTypes.includes(mapping.type);
-        }
-        if (mapping.kind === "category" && enabledCategoryTypes) {
-            return enabledCategoryTypes.includes(mapping.type);
-        }
-        if (mapping.kind === "entity")
-            return true;
-        return true;
-    });
-    const firstTabId = (visibleTabs[0]?.id ?? "products");
-    const [activeTab, setActiveTab] = useState(firstTabId);
     const countFor = (id) => {
         switch (id) {
             case "products": return counts?.products;
@@ -46,5 +30,26 @@ export function CategoryDetailTabs({ categorySlug, categoryId, initialProductsDa
             default: return undefined;
         }
     };
+    const visibleTabs = CATEGORY_PAGE_TABS.filter((t) => {
+        const mapping = TAB_TYPE_MAP[t.id];
+        if (mapping) {
+            if (mapping.kind === "listing" && enabledListingTypes) {
+                if (!enabledListingTypes.includes(mapping.type))
+                    return false;
+            }
+            if (mapping.kind === "category" && enabledCategoryTypes) {
+                if (!enabledCategoryTypes.includes(mapping.type))
+                    return false;
+            }
+        }
+        // Hide a tab only when its count is known and explicitly zero — a tab
+        // whose count was never fetched (undefined) stays visible so we don't
+        // silently hide a listing type this page hasn't wired count-tracking
+        // for yet.
+        const count = countFor(t.id);
+        return count === undefined || count > 0;
+    });
+    const firstTabId = (visibleTabs[0]?.id ?? "products");
+    const [activeTab, setActiveTab] = useState(firstTabId);
     return (_jsxs(_Fragment, { children: [_jsx(Tabs, { value: activeTab, onChange: (v) => setActiveTab(v), className: "mb-6", children: _jsx(TabsList, { children: visibleTabs.map((t) => (_jsx(TabsTrigger, { value: t.id, badge: countFor(t.id), children: t.label }, t.id))) }) }), activeTab === "products" && (_jsx(CategoryProductsListing, { categorySlug: categorySlug, categoryId: categoryId, initialData: initialProductsData })), activeTab === "auctions" && (_jsx(AuctionsIndexListing, { categorySlug: categorySlug })), activeTab === "pre-orders" && (_jsx(PreOrdersIndexListing, { categorySlug: categorySlug })), activeTab === "prize-draws" && (_jsx(PrizeDrawsIndexListing, { categorySlug: categorySlug })), activeTab === "bundles" && (_jsx(CategoryBundlesListing, { initialBundles: initialBundles })), activeTab === "stores" && (_jsx(CategoryStoresListing, { stores: initialStores }))] }));
 }

package/dist/features/stores/components/StoreDetailLayoutView.js

@@ -111,14 +111,24 @@ export async function StoreDetailLayoutView({ storeSlug, activeTab, children, sc
         live: "live",
     };
     const visibleStoreTabs = STORE_PAGE_TABS.filter((tab) => {
-        if (tab.id === "bundles")
-            return isCategoryTypeEnabled("bundle", settings);
+        if (tab.id === "bundles") {
+            if (!isCategoryTypeEnabled("bundle", settings))
+                return false;
+            return listingCounts[tab.id] > 0;
+        }
         // Combined tab — visible if either underlying listing type is enabled.
         if (tab.id === "art") {
-            return isListingTypeEnabled("art", settings) || isListingTypeEnabled("stickers", settings);
+            if (!(isListingTypeEnabled("art", settings) || isListingTypeEnabled("stickers", settings)))
+                return false;
+            return listingCounts[tab.id] > 0;
         }
         const lt = TAB_LISTING_TYPE[tab.id];
-        return lt ? isListingTypeEnabled(lt, settings) : true;
+        if (lt && !isListingTypeEnabled(lt, settings))
+            return false;
+        // A store with zero items of a given listing type shouldn't offer a tab
+        // that leads to an empty page — matches the "hide empty tab" rule below
+        // for coupons/reviews.
+        return listingCounts[tab.id] > 0;
     });
     const dropdownTabs = visibleStoreTabs.map((tab) => ({
         value: tab.id,
@@ -126,8 +136,12 @@ export async function StoreDetailLayoutView({ storeSlug, activeTab, children, sc
         href: STORE_LISTING_HREF[tab.id](storeSlug),
     }));
     const tabs = [
-        { value: "coupons", label: tabLabel("Coupons", couponsCount), href: String(ROUTES.PUBLIC.STORE_COUPONS(storeSlug)) },
-        { value: "reviews", label: tabLabel("Reviews", reviewsCount), href: String(ROUTES.PUBLIC.STORE_REVIEWS(storeSlug)) },
+        ...(couponsCount > 0
+            ? [{ value: "coupons", label: tabLabel("Coupons", couponsCount), href: String(ROUTES.PUBLIC.STORE_COUPONS(storeSlug)) }]
+            : []),
+        ...(reviewsCount > 0
+            ? [{ value: "reviews", label: tabLabel("Reviews", reviewsCount), href: String(ROUTES.PUBLIC.STORE_REVIEWS(storeSlug)) }]
+            : []),
         { value: "about", label: "About", href: String(ROUTES.PUBLIC.STORE_ABOUT(storeSlug)) },
     ];
     return (_jsxs(Main, { children: [_jsx(StoreHeader, { store: store, trust: trust }), _jsxs(Container, { size: "xl", className: "mt-6", children: [_jsx(StoreNavTabs, { dropdownTabs: dropdownTabs, dropdownPlaceholder: "Browse listings", tabs: tabs, activeValue: activeTab }), _jsx(Section, { padding: "t-lg", children: children })] })] }));

package/dist/features/tester/seed-data/tester-checklist-seed-data.js

@@ -128,6 +128,38 @@ const rawTesterChecklistItems = [
                     description: "Verify against the seeded fixtures: \"Test Collectible — Sold Out\" (standard, hidden until \"Show sold\" is on), \"Test Auction — Already Won\" (hidden until \"Show ended\" is on), \"Test Prize Draw — Already Closed\" (hidden until \"Show closed\" is on). All three should be genuinely absent by default, not just from an unrelated broken query.",
                     href: "/products",
                 },
+                {
+                    key: "auctions-show-ended-off-shows-live",
+                    label: "With \"Show ended\" off (the default), the Auctions listing shows LIVE auctions — not empty, and not requiring the toggle to see anything",
+                    description: "Fixed 2026-08-20 — the bounded fetch behind the \"unsafe filter\" workaround used to be sorted by the same field the date filter was about to reject on (auctionEndDate ASC = oldest/most-ended first), so once a store accumulated enough already-ended auctions the entire batch could be all-ended and live ones never got fetched at all — you had to turn \"Show ended\" ON to see anything, including live auctions. Load /products?listingType=auction fresh with the toggle off and confirm live auctions appear without touching the toggle.",
+                    href: "/products",
+                },
+                {
+                    key: "auctions-show-ended-with-nondefault-sort",
+                    label: "Switching the Auctions sort to something other than \"Ending Soon\" (e.g. \"Highest Current Bid\") while \"Show ended\" stays off still shows live auctions, correctly sorted by the chosen field",
+                    description: "Same root cause as auctions-show-ended-off-shows-live, but for the case where the sort field doesn't match the date field being filtered on — a separate code path (in-memory re-sort after filtering) that needs its own check.",
+                    href: "/products",
+                },
+                {
+                    key: "sort-options-per-listing-type",
+                    label: "Every sort dropdown option (Price, Newest, Ending Soon, Highest/Lowest Bid, Most Bids, Delivery Date, etc.) actually reorders the results on Products, Auctions, and Pre-Orders listing pages",
+                    href: "/products",
+                },
+                {
+                    key: "filter-drawer-combines-correctly",
+                    label: "Applying multiple filters together (price range + brand + category + condition) narrows results correctly, and clearing filters restores the full list — on Products, Auctions, and Pre-Orders",
+                    href: "/products",
+                },
+                {
+                    key: "search-filter-sort-combo",
+                    label: "Typing a search query, then applying a filter, then changing sort — all three stay applied together and pagination reflects the combined result count (not just the last action applied)",
+                    href: "/products",
+                },
+                {
+                    key: "listing-toggles-persist-across-pagination",
+                    label: "Toggling \"Show sold\"/\"Show ended\"/\"Show closed\" and then navigating to page 2 keeps the toggle state — page 2 doesn't silently reset back to hiding those items",
+                    href: "/products",
+                },
             ],
         },
         {
@@ -728,6 +760,12 @@ const rawTesterChecklistItems = [
             cases: [
                 { key: "store-directory", label: "The store directory page loads correctly", href: "/stores" },
                 { key: "store-detail-tabs", label: "A store detail page's listing-type dropdown (Products/Auctions/Pre-Orders/Prize Draws/Bundles/Classifieds/Digital Codes/Live Items/Art & Stickers) switches correctly between listing types, and the separate Coupons/Reviews/About tabs next to it all load correctly", description: "The listing-type dropdown is always a dropdown (not just on narrow/mobile widths, unlike category/brand/product/event tabs) since a store can have up to 9 listing types — Coupons, Reviews, and About stay as standalone tabs beside it, never folded into the dropdown." },
+                {
+                    key: "empty-tabs-hidden",
+                    label: "A store/category/brand detail page never shows a tab for a listing type it has zero items of — e.g. a store with no products doesn't show a \"Products\" tab at all, not an empty products page",
+                    description: "Fixed 2026-08-20 — tab visibility now checks the already-fetched per-type count and omits the tab entirely when it's zero, instead of always rendering all tabs regardless of whether they'd show anything. \"About\" always stays visible on store pages (no item-count concept). Verify on a real store/category/brand that's genuinely missing at least one listing type.",
+                    href: "/stores",
+                },
                 { key: "sellers-directory", label: "The sellers directory page loads correctly", href: "/sellers" },
                 { key: "seller-detail-page", label: "An individual seller's public detail page loads correctly" },
                 { key: "scams-registry", label: "The scams registry page and an individual scam detail page load correctly", href: "/scams" },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mohasinac/appkit",
-  "version": "4.5.1",
+  "version": "4.5.3",
   "license": "MIT",
   "publishConfig": {
     "access": "public"