@mohasinac/appkit 4.42.18 → 4.44.0

package/dist/features/products/components/PrizeDrawsSection.js

@@ -34,6 +34,11 @@ export async function PrizeDrawsSection({ config, }) {
         sorts: sortBy(PRODUCT_FIELDS.CREATED_AT, "DESC"),
         page: 1,
         pageSize: config.maxItems ?? 8,
+        // Fixed-size strip that never pages — cap the bounded window instead of
+        // inheriting the 50-document default. Headroom over `pageSize` because
+        // availability and test-data are per-row predicates applied after the fetch.
+        // See `featuredWindow` in features/products/actions/product-actions.ts.
+        windowSize: Math.max((config.maxItems ?? 8) * 2, (config.maxItems ?? 8) + 8),
     });
     const draws = (result?.items ?? []);
     if (draws.length === 0)

package/dist/features/products/components/ProductFilters.d.ts

@@ -37,9 +37,6 @@ export declare const PRODUCT_ADMIN_SORT_OPTIONS: readonly [{
 }, {
     readonly value: string;
     readonly label: "Recently Updated";
-}, {
-    readonly value: string;
-    readonly label: "Most Viewed";
 }];
 export declare const PRODUCT_SELLER_SORT_OPTIONS: readonly [{
     readonly value: string;
@@ -68,9 +65,6 @@ export declare const PRODUCT_SELLER_SORT_OPTIONS: readonly [{
 }, {
     readonly value: string;
     readonly label: "Recently Updated";
-}, {
-    readonly value: string;
-    readonly label: "Most Viewed";
 }];
 export declare const PRODUCT_PUBLIC_SORT_OPTIONS: readonly [{
     readonly value: string;
@@ -90,9 +84,6 @@ export declare const PRODUCT_PUBLIC_SORT_OPTIONS: readonly [{
 }, {
     readonly value: string;
     readonly label: "Name: Z–A";
-}, {
-    readonly value: string;
-    readonly label: "Most Viewed";
 }];
 export declare function getProductFilterKeys(variant: ProductFilterVariant): readonly string[];
 export declare function getProductSortOptions(variant: ProductFilterVariant): ReadonlyArray<{

package/dist/features/products/components/ProductForm.d.ts

@@ -33,6 +33,32 @@ export interface ProductFormProps {
     product: ProductFormValue;
     onChange: (updated: ProductFormValue) => void;
     isReadonly?: boolean;
+    /**
+     * Show the Tax & GST section (`gstRate` + `hsnCode`). **Admin only.**
+     *
+     * 🛑 Defaults to `false`, and the default is the point. LetItRip is the
+     * seller of record and invoices under its OWN GSTIN, so a supplier choosing
+     * the tax rate on goods we invoice is a compliance hole, not a convenience.
+     * The rate is a tax determination: it belongs to the category (via
+     * `productDefaults.taxCodeId`, resolved server-side by `deriveTaxonomy`) and
+     * to the admin who maintains the tax codes.
+     *
+     * There is also a one-click foot-gun behind it. The select renders
+     * `String(gstRate ?? 0)`, so an undetermined rate DISPLAYS as "0%" — and
+     * because `0` is a deliberate exemption while `undefined` means "nobody has
+     * said" (see `ProductDocument.gstRate`), a seller who touches that control
+     * at all, even re-picking the 0% already shown, writes a hard `0` and
+     * **permanently suppresses the category derivation**: `deriveTaxonomy` only
+     * derives when `input.gstRate == null`.
+     *
+     * 🛑 The display default does NOT corrupt the field on its own. `FormField`'s
+     * select fires `onChange` from a real DOM event only, and the draft is
+     * seeded from the stored document — so an untouched save preserves
+     * `undefined`. Verified rather than assumed; an earlier plan revision
+     * asserted every save converted "nobody has said" into "exempt", and that
+     * was not true of this code.
+     */
+    canEditTax?: boolean;
     /**
      * Render a custom rich-text description editor.
      * If omitted, a standard textarea field is used.
@@ -76,5 +102,5 @@ export interface ProductFormProps {
         disabled: boolean;
     }) => React.ReactNode;
 }
-export declare function ProductForm({ product, onChange, isReadonly, renderDescriptionEditor, renderCategorySelector, renderBrandSelector, renderStoreAddressSelector, onMediaAbort, currencyPrefix, renderGroupSettings, renderGroupJoinField, }: ProductFormProps): React.JSX.Element;
+export declare function ProductForm({ product, onChange, isReadonly, canEditTax, renderDescriptionEditor, renderCategorySelector, renderBrandSelector, renderStoreAddressSelector, onMediaAbort, currencyPrefix, renderGroupSettings, renderGroupJoinField, }: ProductFormProps): React.JSX.Element;
 export {};

package/dist/features/products/components/ProductForm.js

@@ -50,7 +50,9 @@ function readFileAsDataUrl(file) {
         reader.readAsDataURL(file);
     });
 }
-export function ProductForm({ product, onChange, isReadonly = false, renderDescriptionEditor, renderCategorySelector, renderBrandSelector, renderStoreAddressSelector, onMediaAbort, currencyPrefix = "", renderGroupSettings, renderGroupJoinField, }) {
+export function ProductForm({ product, onChange, isReadonly = false, 
+/* Defaults to false — the seller path must not reach it. See the prop's docs. */
+canEditTax = false, renderDescriptionEditor, renderCategorySelector, renderBrandSelector, renderStoreAddressSelector, onMediaAbort, currencyPrefix = "", renderGroupSettings, renderGroupJoinField, }) {
     const t = useTranslations("adminProducts");
     const { upload } = useMediaUpload();
     const galleryIndexRef = useRef(0);
@@ -179,17 +181,29 @@ export function ProductForm({ product, onChange, isReadonly = false, renderDescr
                             minOfferPercent: e.target.checked
                                 ? product.minOfferPercent ?? DEFAULT_MIN_OFFER_PERCENT
                                 : undefined,
-                        }), disabled: isReadonly })] }), product.allowOffers && (_jsxs(_Fragment, { children: [_jsx(Alert, { variant: "info", title: t("formAllowOffersHelp"), children: t("formAllowOffersHelp") }), _jsx(FormField, { name: "minOfferPercent", label: t("formMinOfferPercent"), type: "number", value: String(product.minOfferPercent ?? ""), onChange: (value) => update({ minOfferPercent: Number(value) }), disabled: isReadonly, placeholder: String(DEFAULT_MIN_OFFER_PERCENT) })] })), _jsx(Heading, { level: 4, className: "mt-4", children: t("sectionTaxGst") }), _jsxs(FormGroup, { columns: 2, children: [_jsx(FormField, { name: "gstRate", label: t("formGstRate"), type: "select", 
-                        // Unset is semantically "exempt" (see ProductDocument.gstRate JSDoc),
-                        // same as 0% — default the control to 0 so the select stays a fixed
-                        // 5-option enum instead of adding a 6th "unset" placeholder entry.
-                        value: String(product.gstRate ?? 0), onChange: (value) => update({ gstRate: Number(value) }), disabled: isReadonly, options: [
-                            { value: "0", label: "0%" },
-                            { value: "5", label: "5%" },
-                            { value: "12", label: "12%" },
-                            { value: "18", label: "18%" },
-                            { value: "28", label: "28%" },
-                        ] }), _jsx(FormField, { name: "hsnCode", label: t("formHsnCode"), type: "text", value: product.hsnCode ?? "", onChange: (value) => update({ hsnCode: value }), disabled: isReadonly, placeholder: "e.g. 9503" })] }), _jsx(Heading, { level: 4, className: "mt-4", children: t("sectionConditionShipping") }), _jsxs(FormGroup, { columns: 2, children: [_jsx(FormField, { name: "condition", label: t("formCondition"), type: "select", value: product.condition || "new", onChange: (value) => update({
+                        }), disabled: isReadonly })] }), product.allowOffers && (_jsxs(_Fragment, { children: [_jsx(Alert, { variant: "info", title: t("formAllowOffersHelp"), children: t("formAllowOffersHelp") }), _jsx(FormField, { name: "minOfferPercent", label: t("formMinOfferPercent"), type: "number", value: String(product.minOfferPercent ?? ""), onChange: (value) => update({ minOfferPercent: Number(value) }), disabled: isReadonly, placeholder: String(DEFAULT_MIN_OFFER_PERCENT) })] })), canEditTax ? (_jsxs(_Fragment, { children: [_jsx(Heading, { level: 4, className: "mt-4", children: t("sectionTaxGst") }), _jsxs(FormGroup, { columns: 2, children: [_jsx(FormField, { name: "gstRate", label: t("formGstRate"), type: "select", 
+                                /*
+                                 * 🛑 "" is the UNSET option, and it is not cosmetic.
+                                 * `ProductDocument.gstRate` documents that `undefined` and `0`
+                                 * mean different things — zero is a deliberate exemption (live
+                                 * plants and animals), undefined is "nobody has said" — and
+                                 * `deriveTaxonomy` only derives the category's rate while it is
+                                 * `== null`. Collapsing unset to "0%", which this control did
+                                 * until 2026-10-10, made an undetermined rate read as exempt and
+                                 * put a hard `0` one click away.
+                                 */
+                                value: product.gstRate == null ? "" : String(product.gstRate), onChange: (value) => update({
+                                    gstRate: value === ""
+                                        ? undefined
+                                        : Number(value),
+                                }), disabled: isReadonly, options: [
+                                    { value: "", label: t("formGstRateUnset") },
+                                    { value: "0", label: "0%" },
+                                    { value: "5", label: "5%" },
+                                    { value: "12", label: "12%" },
+                                    { value: "18", label: "18%" },
+                                    { value: "28", label: "28%" },
+                                ] }), _jsx(FormField, { name: "hsnCode", label: t("formHsnCode"), type: "text", value: product.hsnCode ?? "", onChange: (value) => update({ hsnCode: value }), disabled: isReadonly, placeholder: "e.g. 9503" })] })] })) : null, _jsx(Heading, { level: 4, className: "mt-4", children: t("sectionConditionShipping") }), _jsxs(FormGroup, { columns: 2, children: [_jsx(FormField, { name: "condition", label: t("formCondition"), type: "select", value: product.condition || "new", onChange: (value) => update({
                             condition: value,
                         }), disabled: isReadonly, options: [
                             { value: "new", label: t("formConditionNew") },

package/dist/features/products/components/ProductsIndexPageView.js

@@ -53,5 +53,5 @@ export async function ProductsIndexPageView({ searchParams = {} }) {
         sorts: DEFAULT_SORT,
         ...defaultAvailabilityForListingTypes(effectiveTypes),
     }));
-    return (_jsxs(Main, { children: [_jsx(Section, { border: "bottom-subtle", paddingY: "b-md", padding: "t-xl", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 1, size: "3xl", weight: "bold", color: "primary", children: "Products" }), _jsx(Text, { className: "mt-1", color: "muted", size: "sm", children: "Discover amazing products and deals" }), _jsx(Div, { className: "mt-3", children: _jsx(TextLink, { variant: "bare", href: String(ROUTES.PUBLIC.AUCTIONS), rounded: "full", paddingX: "sm", paddingY: "2xs", size: "xs", weight: "medium", layout: "inline-flex", align: "center", gap: "sm", className: "border border-primary/30 bg-primary/10 text-primary-700 dark:text-primary-400 hover:bg-primary/15 transition-colors", children: "\uD83C\uDFF7\uFE0F Looking for unique deals? Browse Auctions \u2192" }) })] }) }), _jsxs(Container, { size: "xl", padding: "x-md", children: [_jsx(AdSlot, { id: "listing-sidebar-top", className: "mb-4 mt-4" }), _jsx(ProductsIndexListing, { initialData: products }), _jsx(AdSlot, { id: "listing-sidebar-bottom", className: "mt-8" })] })] }));
+    return (_jsxs(Main, { children: [_jsx(Section, { border: "bottom-subtle", paddingY: "b-md", padding: "t-xl", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 1, size: "3xl", weight: "bold", color: "primary", children: "Products" }), _jsx(Text, { className: "mt-1", color: "muted", size: "sm", children: "Discover amazing products and deals" }), _jsx(Div, { className: "mt-3", children: _jsx(TextLink, { variant: "bare", href: String(ROUTES.PUBLIC.AUCTIONS), rounded: "full", paddingX: "sm", paddingY: "2xs", size: "xs", weight: "medium", layout: "inline-flex", align: "center", gap: "sm", className: "border border-primary/30 bg-primary/10 text-primary-700 dark:text-primary-400 hover:bg-primary/15 transition-colors", children: "\uD83C\uDFF7\uFE0F Looking for unique deals? Browse Auctions \u2192" }) })] }) }), _jsxs(Container, { size: "xl", padding: "x-md", children: [_jsx(AdSlot, { id: "listing-sidebar-top", className: "mb-4 mt-4" }), _jsx(ProductsIndexListing, { initialData: products ?? undefined }), _jsx(AdSlot, { id: "listing-sidebar-bottom", className: "mt-8" })] })] }));
 }

package/dist/features/products/constants/sieve.d.ts

@@ -57,9 +57,6 @@ export declare const STANDARD_SORT_OPTIONS: readonly [{
 }, {
     readonly value: string;
     readonly label: "Recently Updated";
-}, {
-    readonly value: string;
-    readonly label: "Most Viewed";
 }];
 export declare const STANDARD_PUBLIC_SORT_OPTIONS: readonly [{
     readonly value: string;
@@ -79,9 +76,6 @@ export declare const STANDARD_PUBLIC_SORT_OPTIONS: readonly [{
 }, {
     readonly value: string;
     readonly label: "Name: Z–A";
-}, {
-    readonly value: string;
-    readonly label: "Most Viewed";
 }];
 export declare const AUCTION_SORT_OPTIONS: readonly [{
     readonly value: string;

package/dist/features/products/constants/sieve.js

@@ -68,7 +68,31 @@ export const STANDARD_SORT_OPTIONS = [
     { value: sortBy(PRODUCT_FIELDS.FEATURED), label: "Featured First" },
     { value: sortBy(PRODUCT_FIELDS.IS_PROMOTED), label: "Promoted First" },
     { value: sortBy(PRODUCT_FIELDS.UPDATED_AT), label: "Recently Updated" },
-    { value: sortBy(PRODUCT_FIELDS.VIEW_COUNT), label: "Most Viewed" },
+    /*
+     * 🛑 "Most Viewed" REMOVED 2026-10-10 — it returned zero products, always.
+     *
+     * It sorted by `viewCount`, and **no document has that field**: measured on
+     * production, 0 of 72 published products and 0 of 58 categories carry it.
+     * Nothing writes it either — `incrementViewCount` was removed from the
+     * render path on 2026-08-31 (correctly: a Firestore write per render) and
+     * both repositories' copies have had zero callers since.
+     *
+     * A Firestore `orderBy` EXCLUDES every document that lacks the ordering
+     * field, so this was Root Cause #100 verbatim. Confirmed against the real
+     * query shape — `status==published` + `listingType==standard`:
+     *
+     *     no sort            -> 16 rows
+     *     orderBy title      -> 16 rows
+     *     orderBy viewCount  ->  0 rows      <- and the index EXISTS
+     *
+     * So it was not a missing index. It was a served query, costing a real
+     * round trip, guaranteed to return nothing — and picking it emptied the
+     * catalogue with no error anywhere.
+     *
+     * Real view counts arrive from the `pageViews` collection (already
+     * collected on ~30 surfaces) as `metrics.views7d`/`views30d`, rolled up by
+     * the daily job. A sort can come back then, against a field that exists.
+     */
 ];
 export const STANDARD_PUBLIC_SORT_OPTIONS = [
     STANDARD_SORT_OPTIONS[0],
@@ -77,7 +101,16 @@ export const STANDARD_PUBLIC_SORT_OPTIONS = [
     STANDARD_SORT_OPTIONS[3],
     STANDARD_SORT_OPTIONS[4],
     STANDARD_SORT_OPTIONS[5],
-    STANDARD_SORT_OPTIONS[9],
+    /*
+     * 🛑 `STANDARD_SORT_OPTIONS[9]` removed — it WAS "Most Viewed", and its
+     * presence here means the zero-result sort was offered on the PUBLIC
+     * products page, not only in admin. A shopper picking it emptied the
+     * catalogue.
+     *
+     * Indices 6–8 (Featured First / Promoted First / Recently Updated) are
+     * omitted deliberately and always have been — this list is a curated public
+     * subset, not a prefix.
+     */
 ];
 // ---------------------------------------------------------------------------
 // Auctions — auction-specific base puts auctionEndDate primary

package/dist/features/products/repository/products.repository.d.ts

@@ -45,8 +45,123 @@ export declare class ProductRepository extends BaseRepository<ProductDocument> {
      * (Root Cause #6/#18) — a raw collection read has neither problem.
      */
     private deriveTaxonomy;
+    /**
+     * Resolve the GST rate floor, and gross up an ex-tax price if the seller
+     * authors that way.
+     *
+     * ## The rate resolution order, in full
+     *
+     *  1. the product's own `gstRate`, if a human set one — including `0`, a
+     *     deliberate exemption;
+     *  2. the CATEGORY's rate via `taxCodeId` → `taxCodes`, applied just above
+     *     by `applyCategoryDefaults`. **This is the mechanism**, and the ~330-node
+     *     forest carries a tax code on every listing branch, so it answers for
+     *     effectively the whole catalogue;
+     *  3. `DEFAULT_GST_RATE` — a floor, warned about, never a feature.
+     *
+     * 🛑 Step 3 fires only when steps 1 and 2 both came up empty, which means
+     * the category has no tax code — and THAT is the defect to fix. The measure
+     * of success is that this warning never appears. It exists because the
+     * alternative fails asymmetrically: with prices tax-inclusive, treating an
+     * unrated item as 0% hands the seller the full amount and leaves us owing
+     * tax on money already paid out, which is C0's bug in miniature.
+     *
+     * ## The gross-up
+     *
+     * A store with `pricesIncludeGst: false` types EX-TAX prices, so the typed
+     * number is converted ONCE here and stored tax-inclusive like every other
+     * price. No money path branches on the flag; see `taxableFromInclusive`.
+     *
+     * Gated on the write actually carrying a price, so a stock decrement or a
+     * status flip pays nothing for this — the same discipline `update` already
+     * applies to the taxonomy derivation itself.
+     */
+    private applyInclusivePricing;
+    /**
+     * Hand down what the category declares: the tax code, the spec rows, the
+     * in-the-box list, the inherited features and the SEO templates.
+     *
+     * ## 🛑 Why this is server-side and not a form default
+     *
+     * GST is tax CORRECTNESS. A client-side default is bypassable by all ~14
+     * write paths, and the defect this closes is recorded in our own source:
+     * *"0 of 40 live orders had a `gstAmount`, and the order page's Tax row had
+     * never rendered."* The rate has to be applied where every path funnels, and
+     * that is here.
+     *
+     * ## 🛑 The three behaviours are different, and the difference is the design
+     *
+     *   WRITTEN     tax, specifications, inTheBox, features — written when the
+     *               product omits them.
+     *   FILL-BLANK  seo* — fills only an empty field, never overwrites a
+     *               seller's own words.
+     *   ADVISORY    priceGuidance — NEVER touched here. It renders as a hint
+     *               beside the price input and nothing else. Writing a suggested
+     *               price onto `price` would be the platform setting a seller's
+     *               price, which is not a default, it is a decision.
+     *
+     * ## 🛑 Resolution is PER FIELD across the ancestor chain
+     *
+     * Not "the nearest category that declares a `productDefaults` object wins".
+     * B5's named-model leaves carry `defaultFeatures` (the blader, the battle
+     * type, the spin) while the tax code, the spec rows and the price band live
+     * on the tier-3 LINE above them. An object-level "nearest wins" would hand a
+     * Dragoon G its blader and NO TAX CODE — silently deriving no GST, which is
+     * the quiet under-charging failure the whole tax-code indirection exists to
+     * prevent.
+     *
+     * ## Cost
+     *
+     * One `getAll` over at most four ancestors, fired only when the leaf leaves
+     * something unresolved, plus one read for the tax code. With the leaf+brand
+     * read that is three round trips worst case against Rule #6's ~3 budget —
+     * and `update` only re-derives when a write names a taxonomy field, so a
+     * stock decrement or a status flip pays none of it.
+     */
+    private applyCategoryDefaults;
     /** The keys whose presence means a write could change the product's taxonomy. */
     private static readonly TAXONOMY_KEYS;
+    /**
+     * Keep `availableQuantity` in step when a seller edits `stockQuantity`.
+     *
+     * 🛑 THE BUG THIS CLOSES: A SELLER COULD NOT RESTOCK.
+     *
+     * There are two stock numbers. `stockQuantity` is seller-authored and is the
+     * only one any of the three product forms exposes. `availableQuantity` is
+     * system-owned, seeded from `stockQuantity` **once, at create**, and
+     * thereafter driven by checkout decrements and timeout restores.
+     *
+     * Nothing re-synced them. `updateProduct` is a bare spread, and grep for
+     * `availableQuantity` across `src/app/api/store/products/**` and
+     * `seller-actions.ts` returns ZERO. So: a product sells out
+     * (`availableQuantity: 0`), the seller edits `stockQuantity` 0 → 10, and the
+     * product STAYS UNBUYABLE — purchasability gates on `availableQuantity > 0`
+     * in three independent places (`service.ts`, the cart route, and the public
+     * list filter). The only field the seller can reach is the one that does not
+     * control availability.
+     *
+     * With 76–93% of competitor catalogues sold out, restock is the main
+     * lifecycle event, not an edge case.
+     *
+     * WHY A DELTA AND NOT `availableQuantity = stockQuantity`: the difference
+     * between the two IS the outstanding reservation — units held by placed-but-
+     * unpaid orders. Overwriting would hand those units back to the shelf and
+     * oversell them. So carry the reservation forward:
+     *
+     *     reserved = prevStock - prevAvailable        (clamped at 0)
+     *     available = nextStock - reserved            (clamped at 0)
+     *
+     * Examples: 10 stock / 10 available, edit to 12 → 12. 10 stock / 7 available
+     * (3 reserved), edit to 12 → 9. Sold out at 0/0, edit to 10 → 10.
+     *
+     * 🛑 Returns `{}` — not a value — whenever the write does not name
+     * `stockQuantity`, or names `availableQuantity` explicitly. The second case
+     * is what keeps the checkout decrement, the stock-restore job and
+     * `updateAvailableQuantity` authoritative: they write `availableQuantity`
+     * directly and must never have it recomputed from a stale `stockQuantity`
+     * underneath them.
+     */
+    private static resyncAvailableQuantity;
     update(id: string, data: Partial<ProductDocument>): Promise<ProductDocument>;
     create(input: ProductCreateInput): Promise<ProductDocument>;
     findByStore(storeId: string): Promise<ProductDocument[]>;
@@ -403,7 +518,6 @@ export declare class ProductRepository extends BaseRepository<ProductDocument> {
         categoriesIn?: string[];
         brandName?: string;
     }): Promise<Record<string, number | undefined>>;
-    incrementViewCount(productId: string): Promise<void>;
     /**
      * Cloud Functions: find published auctions whose end date has already passed.
      * Used by the auction settlement job to finalize expired auctions.