@mohasinac/appkit 4.42.16 → 4.42.18

package/dist/_internal/server/features/checkout/locked-lines.js

@@ -22,6 +22,7 @@
  * @tag sideEffects:firestore-write
  */
 import { offerRepository } from "../../../../features/seller/repository/offer.repository";
+import { cartRepository } from "../../../../features/cart/repository/cart.repository";
 import { bidRepository } from "../../../../repositories";
 import { OfferStatusValues } from "../../../../features/seller/schemas";
 import { BID_COLLECTION } from "../../../../features/auctions/schemas/firestore";
@@ -199,7 +200,31 @@ export async function assertLockedLinesStillValid(items, buyerUid) {
             continue;
         const offer = await offerRepository.findById(item.offerId);
         if (!offer) {
-            throw new ValidationError("The offer for one of your items no longer exists. Remove it and try again.");
+            /*
+             * 🛑 PRUNE IT, do not just refuse. This used to throw "Remove it and
+             * try again" — an instruction the buyer cannot follow, because
+             * `cartRepository.removeItem` rejects any `locked` line and the cart
+             * page renders no remove control for one. Three guards then disagreed
+             * about one fact and trapped the buyer between them: checkout said
+             * remove it, remove said the line requires payment, and
+             * `assertCanAddNewItems` said settle the offer lane first — so the
+             * whole cart, including unrelated standard items, became unbuyable
+             * with no way out. Measured on production: three real items stranded
+             * behind one tombstone line.
+             *
+             * At THIS point the lock protects nothing. The lock exists so a buyer
+             * cannot walk away from a committed purchase; an offer record that no
+             * longer exists is not a commitment to anything, and the line can never
+             * be fulfilled. `removeItemsByOfferId` is the same path admin
+             * cancellation already uses, so it is allowed to clear a locked line.
+             *
+             * Still a ValidationError rather than a silent continue: the buyer's
+             * total just changed, and a checkout that quietly drops a line and
+             * charges a different amount than the screen showed is its own defect.
+             * They retry once and it goes through.
+             */
+            await cartRepository.removeItemsByOfferId(buyerUid, item.offerId);
+            throw new ValidationError("One item was removed because its offer no longer exists. Please review your cart and try again.");
         }
         if (offer.buyerUid !== buyerUid) {
             throw new ValidationError("This offer belongs to a different account.");

package/dist/features/seller/components/SellerBidsView.js

@@ -6,6 +6,7 @@ import { sortBy } from "@mohasinac/appkit/client";
 import { useState, useCallback } from "react";
 import { Badge, Button, Div, FilterChipGroup, RecordDetailModal, Span, Text, useToast } from "../../../ui";
 import { buildBidDetailFields, bidStatusBadge } from "../../auctions/components/bid-detail-fields";
+import { RecordStatusTimeline } from "../../status-history/components/RecordStatusTimeline";
 import { SELLER_ENDPOINTS } from "../../../constants/api-endpoints";
 import { ACTIONS } from "../../../_internal/shared/actions/action-registry";
 import { buildBulkAction } from "../../../_internal/shared/actions/bulk-helpers";
@@ -113,6 +114,9 @@ export function SellerBidsView({ endpoint = SELLER_ENDPOINTS.BIDS }) {
             bidAmount: Number(item.bidAmount ?? 0),
             status: toStringValue(item.status, "active"),
             bidDate: toRelativeDate(item.bidDate ?? item.createdAt),
+            // The one cast, at the JSON -> document boundary where it belongs, so
+            // that every CONSUMER of `raw` typechecks for real.
+            raw: item,
         })),
         getTotal: (response, mappedRows) => (typeof response.total === "number" ? response.total : mappedRows.length),
         buildFilters: (state) => (state.status ? sieveFilter("status", SIEVE_OP.EQ, state.status) : undefined),
@@ -145,8 +149,14 @@ export function SellerBidsView({ endpoint = SELLER_ENDPOINTS.BIDS }) {
         },
     };
     const detailBadge = detail ? bidStatusBadge(detail.status) : null;
-    return (_jsxs(_Fragment, { children: [_jsx(DataListingView, { config: config }), _jsx(RecordDetailModal, { isOpen: detail !== null, onClose: () => setDetail(null), title: detail?.productTitle || "Bid", badges: detailBadge ? [{ label: detailBadge.label }] : undefined, fields: detail ? buildBidDetailFields(detail, "seller") : undefined, footer: detail ? (
+    return (_jsxs(_Fragment, { children: [_jsx(DataListingView, { config: config }), _jsx(RecordDetailModal, { isOpen: detail !== null, onClose: () => setDetail(null), title: detail?.productTitle || "Bid", badges: detailBadge ? [{ label: detailBadge.label }] : undefined, fields: detail ? buildBidDetailFields(detail.raw, "seller") : undefined, footer: detail ? (
                 // The full page — a modal cannot be linked, bookmarked or reloaded
                 // into, which is the whole reason the page exists.
-                _jsx(TextLink, { href: String(ROUTES.STORE.BID_DETAIL(detail.id)), children: "Open full page \u2192" })) : undefined })] }));
+                _jsx(TextLink, { href: String(ROUTES.STORE.BID_DETAIL(detail.id)), children: "Open full page \u2192" })) : undefined, extra: 
+                // Present on the seller's full page and absent from this modal until
+                // 2026-10-04, which is a label the two surfaces disagreed about —
+                // exactly what the modal-vs-page case exists to catch. Mirrors
+                // AdminBidsView: absent history renders the empty label, never a
+                // step invented from `updatedAt`.
+                _jsx(RecordStatusTimeline, { entries: detail?.raw?.statusHistory, truncatedCount: detail?.raw?.statusHistoryTruncated }) })] }));
 }

package/dist/features/tester/seed-data/authored/buying__product-detail.js

@@ -40,8 +40,20 @@ export const authored = {
             "Read the current bid, the minimum increment and the bid panel.",
         ],
         expectedBehaviour: "The twin of the guest case above — the bid figures and the working bid form are exactly what the gate must not cost a signed-in buyer.",
-        expectedUiState: "'Current bid ₹15,000.00' is shown, a minimum increment of ₹1,000.00 is stated, and the bid panel carries a real amount input and a submit button. Neither 'Sign in to see the current bid' nor 'Bidding is for members' appears anywhere on the page.",
-        expectedData: { currentBid: 15000, minIncrement: 1000 },
+        expectedUiState: 
+        /*
+         * Literals corrected 2026-10-04 to the auction this case actually opens.
+         * They read '₹15,000.00' and a '₹1,000.00' increment, which are the
+         * numbers of a DIFFERENT fixture — `auction-money-flows-closing`, seeded
+         * by fixtures/money-flows__auction-win-to-payment.mjs at
+         * startingBid/currentBid 15000 with a 1000 increment, because its own
+         * case enters 16000 against it. This case's startPage is
+         * auction-beyblade-original-dragoon-storm, seeded startingBid 2999 /
+         * currentBid 3499 / buyNowPrice 5999, and the page renders exactly that.
+         * The product was never wrong; the expectation named another auction.
+         */
+        "'Current bid ₹3,499.00' is shown with its bid count, a 'min increment ₹200.00' is stated, a Buy Now price of ₹5,999.00 is offered, and the bid panel carries a real amount input and a 'Place bid' submit button. Neither 'Sign in to see price' nor any other gate prompt appears anywhere on the page.",
+        expectedData: { currentBid: 3499, minIncrement: 200 },
         endResult: "Nothing persists unless a bid is actually submitted, which this case does not do.",
     },
     "checklist-buying-product-detail-bundle-purchase": {

package/dist/seed/products-live-items-seed-data.js

@@ -55,6 +55,27 @@ const _rawproductsLiveItemsSeedData = [
             seedPhoto("live-image-golden-retriever-1-20260816", 900, 900),
             seedPhoto("live-image-golden-retriever-2-20260816", 900, 900),
         ],
+        /*
+         * 🛑 A LIVE LISTING WITHOUT A VIDEO IS NOT A LISTING THE PRODUCT WOULD ACCEPT.
+         *
+         * `/store/live/new` refuses to save one — "a buyer purchasing an animal or
+         * plant needs to see it move" — so a seeded live fixture carrying only
+         * stills is data no seller could have created through the form, and every
+         * case written against the real creation flow then asserts against a
+         * fixture that contradicts it. Found 2026-10-04 driving
+         * `live-item-detail`, whose expectation that the gallery strip offers a
+         * "View video" entry was correct about the product and wrong about the
+         * data: the page shipped `video: undefined` and rendered 2 image slides.
+         *
+         * `url` stays RAW and unwrapped (Root Cause #27) — the media proxy is
+         * image-only and 400s on video/mp4 — while `thumbnailUrl` is wrapped,
+         * because a poster frame IS an image and should carry the watermark.
+         */
+        video: {
+            url: "/demo-media/sample-video.mp4",
+            thumbnailUrl: seedPhoto("live-video-thumb-golden-retriever-20261004", 800, 450),
+            duration: 15,
+        },
         status: PRODUCT_FIELDS.STATUS_VALUES.PUBLISHED,
         condition: PRODUCT_FIELDS.CONDITION_VALUES.NEW,
         listingType: "live",
@@ -102,6 +123,12 @@ const _rawproductsLiveItemsSeedData = [
         isSold: false,
         mainImage: seedPhoto("live-image-bearded-dragon-1-20260817", 900, 900),
         images: [seedPhoto("live-image-bearded-dragon-1-20260817", 900, 900)],
+        // Required for a live listing — see the note on the retriever above.
+        video: {
+            url: "/demo-media/sample-video.mp4",
+            thumbnailUrl: seedPhoto("live-video-thumb-bearded-dragon-20261004", 800, 450),
+            duration: 15,
+        },
         status: PRODUCT_FIELDS.STATUS_VALUES.PUBLISHED,
         condition: PRODUCT_FIELDS.CONDITION_VALUES.NEW,
         listingType: "live",
@@ -153,6 +180,12 @@ const _rawproductsLiveItemsSeedData = [
             seedPhoto("live-image-bonsai-juniper-1-20260818", 900, 900),
             seedPhoto("live-image-bonsai-juniper-2-20260818", 900, 900),
         ],
+        // Required for a live listing — see the note on the retriever above.
+        video: {
+            url: "/demo-media/sample-video.mp4",
+            thumbnailUrl: seedPhoto("live-video-thumb-bonsai-juniper-20261004", 800, 450),
+            duration: 15,
+        },
         status: PRODUCT_FIELDS.STATUS_VALUES.PUBLISHED,
         condition: PRODUCT_FIELDS.CONDITION_VALUES.NEW,
         listingType: "live",
@@ -203,6 +236,15 @@ const _rawproductsLiveItemsSeedData = [
         images: [
             seedPhoto("live-image-juniper-bonsai-sold-1-20260824", 900, 900),
         ],
+        // Required for a live listing — see the note on the retriever above. A SOLD
+        // fixture needs it just as much: it is the row the "Sold & Ended" scope
+        // renders, and a sold listing that could never have been created is no
+        // more representative than an available one.
+        video: {
+            url: "/demo-media/sample-video.mp4",
+            thumbnailUrl: seedPhoto("live-video-thumb-juniper-bonsai-sold-20261004", 800, 450),
+            duration: 15,
+        },
         status: PRODUCT_FIELDS.STATUS_VALUES.PUBLISHED,
         condition: PRODUCT_FIELDS.CONDITION_VALUES.NEW,
         listingType: "live",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mohasinac/appkit",
-  "version": "4.42.16",
+  "version": "4.42.18",
   "license": "MIT",
   "publishConfig": {
     "access": "public"