@mohasinac/appkit 4.41.7 → 4.41.9

package/dist/_internal/server/jobs/core/onOrderCreate.js

@@ -77,7 +77,21 @@ export async function handleOrderCreate(input, ctx) {
     const firstItem = items[0];
     const firstItemName = firstItem?.productTitle ?? "an item";
     const additionalItemCount = Math.max(0, items.length - 1);
-    const buyerName = order.userName ?? "A customer";
+    /*
+     * 🛑 DECRYPT. This handler receives the RAW Firestore snapshot — the type
+     * above says so — so it never passes through the repository's `mapDoc`, and
+     * `userName` is PII, stored as `enc:v1:…`.
+     *
+     * Undecrypted, the ciphertext was interpolated straight into the announcement
+     * body and PERSISTED there, so every admin alert read
+     * "🛍️ New order! enc:v1:67Mn0rITjTWGsZZE:… purchased …". Measured on
+     * production: 383 such rows. The message is baked at write time, so the
+     * damage is permanent per row — decrypting on read would not repair them.
+     *
+     * `decryptPii` was already imported in this file and used for the store
+     * owner's phone eleven lines up; the buyer's name was simply missed.
+     */
+    const buyerName = decryptPii(order.userName) ?? order.userName ?? "A customer";
     const message = buildPurchaseAnnouncementMessage({
         buyerName,
         firstItemName,

package/dist/features/admin/components/AdminViewCards.js

@@ -54,14 +54,24 @@ function AdminCardItem({ row, view, selected, onToggleSelect, onRowClick, render
         return (_jsxs(Row, { gap: "sm", className: [
                 "px-[var(--appkit-space-4)] py-[var(--appkit-space-3)] cursor-pointer transition-colors hover:bg-surface-hover",
                 selected ? "bg-primary-50/40 dark:bg-primary-900/10" : "",
-            ].filter(Boolean).join(" "), onClick: handleClick, role: onRowClick ? "button" : undefined, children: [onToggleSelect && (_jsx(Div, { "data-no-row-click": true, className: "shrink-0", onClick: (e) => { e.stopPropagation(); onToggleSelect(row.id); }, children: _jsx(Checkbox, { bare: true, checked: selected, onChange: () => onToggleSelect(row.id), className: "h-4 w-4 rounded border-zinc-300 text-primary accent-primary cursor-pointer", "aria-label": `Select ${row.primary}` }) })), _jsx(RowAvatar, { image: row.image, alt: row.primary, icon: resourceIcon }), _jsxs(Stack, { gap: "none", className: "flex-1 min-w-0", children: [_jsx(Text, { size: "sm", weight: "semibold", className: "truncate", color: "primary", children: row.primary }), _jsx(Text, { size: "xs", color: "muted", className: "truncate", children: row.secondary }), row.barcodeId && (_jsx(Text, { size: "xs", color: "faint", className: "truncate font-mono", children: row.barcodeId }))] }), flags.length > 0 && (_jsx(Row, { gap: "xs", className: "hidden sm:flex shrink-0", children: flags.map(({ key, label, tone }) => (_jsx(Span, { padding: "pill-2xs", weight: "medium", className: `inline-flex text-[10px] ${STATUS_TONE_CLASSES[tone]}`, rounded: "full", children: label }, key))) })), _jsx(StatusBadge, { status: row.status }), _jsx(Span, { size: "xs", color: "muted", className: "hidden sm:block shrink-0 w-24", align: "end", children: row.updatedAt }), renderRowActions && (_jsx(Div, { "data-no-row-click": true, className: "shrink-0", onClick: (e) => e.stopPropagation(), children: renderRowActions(row) }))] }));
+            ].filter(Boolean).join(" "), onClick: handleClick, role: onRowClick ? "button" : undefined, children: [onToggleSelect && (_jsx(Div, { "data-no-row-click": true, className: "shrink-0", onClick: (e) => {
+                        e.stopPropagation();
+                        if (e.target === e.currentTarget)
+                            onToggleSelect(row.id);
+                    }, children: _jsx(Checkbox, { bare: true, checked: selected, onChange: () => onToggleSelect(row.id), className: "h-4 w-4 rounded border-zinc-300 text-primary accent-primary cursor-pointer", "aria-label": `Select ${row.primary}` }) })), _jsx(RowAvatar, { image: row.image, alt: row.primary, icon: resourceIcon }), _jsxs(Stack, { gap: "none", className: "flex-1 min-w-0", children: [_jsx(Text, { size: "sm", weight: "semibold", className: "truncate", color: "primary", children: row.primary }), _jsx(Text, { size: "xs", color: "muted", className: "truncate", children: row.secondary }), row.barcodeId && (_jsx(Text, { size: "xs", color: "faint", className: "truncate font-mono", children: row.barcodeId }))] }), flags.length > 0 && (_jsx(Row, { gap: "xs", className: "hidden sm:flex shrink-0", children: flags.map(({ key, label, tone }) => (_jsx(Span, { padding: "pill-2xs", weight: "medium", className: `inline-flex text-[10px] ${STATUS_TONE_CLASSES[tone]}`, rounded: "full", children: label }, key))) })), _jsx(StatusBadge, { status: row.status }), _jsx(Span, { size: "xs", color: "muted", className: "hidden sm:block shrink-0 w-24", align: "end", children: row.updatedAt }), renderRowActions && (_jsx(Div, { "data-no-row-click": true, className: "shrink-0", onClick: (e) => e.stopPropagation(), children: renderRowActions(row) }))] }));
     }
     return (_jsxs(Div, { rounded: "xl", className: [
             "border overflow-hidden cursor-pointer transition-all hover:shadow-md hover:-translate-y-0.5",
             selected
                 ? "border-primary ring-1 ring-primary/20 bg-primary-50/30 dark:bg-primary-900/10"
                 : " border-[var(--appkit-color-border)] bg-[var(--appkit-color-surface)]",
-        ].filter(Boolean).join(" "), onClick: handleClick, role: onRowClick ? "button" : undefined, children: [onToggleSelect && (_jsxs(Row, { gap: "xs", "data-no-row-click": true, paddingY: "t-sm", padding: "x-sm", onClick: (e) => { e.stopPropagation(); onToggleSelect(row.id); }, children: [_jsx(Checkbox, { bare: true, checked: selected, onChange: () => onToggleSelect(row.id), className: "h-4 w-4 rounded border-zinc-300 text-primary accent-primary cursor-pointer", "aria-label": `Select ${row.primary}` }), flags.length > 0 && (_jsx(Row, { gap: "xs", wrap: true, children: flags.map(({ key, label, tone }) => (_jsx(Span, { padding: "pill-2xs", weight: "medium", className: `inline-flex text-[10px] ${STATUS_TONE_CLASSES[tone]}`, rounded: "full", children: label }, key))) }))] })), _jsxs(Stack, { gap: "xs", className: `${__P.p3}.5`, children: [_jsxs(Row, { gap: "sm", align: "center", children: [_jsx(RowAvatar, { image: row.image, alt: row.primary, icon: resourceIcon, size: "12" }), _jsxs(Stack, { gap: "none", className: "min-w-0 flex-1", children: [_jsx(Text, { size: "sm", weight: "semibold", className: "line-clamp-2 leading-snug", color: "primary", children: row.primary }), _jsx(Text, { size: "xs", color: "muted", className: "truncate", children: row.secondary })] })] }), row.barcodeId && (_jsx(Text, { size: "xs", color: "faint", className: "truncate font-mono", children: row.barcodeId })), _jsxs(Row, { justify: "between", gap: "xs", children: [_jsx(StatusBadge, { status: row.status }), _jsx(Span, { color: "muted", className: "text-[11px] shrink-0", children: row.updatedAt })] }), renderRowActions && (_jsx(Row, { "data-no-row-click": true, justify: "end", gap: "xs", className: "border-t border-[var(--appkit-color-border)] -mx-[var(--appkit-space-3)] -mb-[var(--appkit-space-3)] mt-[var(--appkit-space-1)] px-[var(--appkit-space-3)] py-[var(--appkit-space-2)]", onClick: (e) => e.stopPropagation(), children: renderRowActions(row) }))] })] }));
+        ].filter(Boolean).join(" "), onClick: handleClick, role: onRowClick ? "button" : undefined, children: [onToggleSelect && (_jsxs(Row, { gap: "xs", "data-no-row-click": true, paddingY: "t-sm", padding: "x-sm", 
+                // Same double-toggle guard as the compact row above — see that comment.
+                onClick: (e) => {
+                    e.stopPropagation();
+                    if (e.target === e.currentTarget)
+                        onToggleSelect(row.id);
+                }, children: [_jsx(Checkbox, { bare: true, checked: selected, onChange: () => onToggleSelect(row.id), className: "h-4 w-4 rounded border-zinc-300 text-primary accent-primary cursor-pointer", "aria-label": `Select ${row.primary}` }), flags.length > 0 && (_jsx(Row, { gap: "xs", wrap: true, children: flags.map(({ key, label, tone }) => (_jsx(Span, { padding: "pill-2xs", weight: "medium", className: `inline-flex text-[10px] ${STATUS_TONE_CLASSES[tone]}`, rounded: "full", children: label }, key))) }))] })), _jsxs(Stack, { gap: "xs", className: `${__P.p3}.5`, children: [_jsxs(Row, { gap: "sm", align: "center", children: [_jsx(RowAvatar, { image: row.image, alt: row.primary, icon: resourceIcon, size: "12" }), _jsxs(Stack, { gap: "none", className: "min-w-0 flex-1", children: [_jsx(Text, { size: "sm", weight: "semibold", className: "line-clamp-2 leading-snug", color: "primary", children: row.primary }), _jsx(Text, { size: "xs", color: "muted", className: "truncate", children: row.secondary })] })] }), row.barcodeId && (_jsx(Text, { size: "xs", color: "faint", className: "truncate font-mono", children: row.barcodeId })), _jsxs(Row, { justify: "between", gap: "xs", children: [_jsx(StatusBadge, { status: row.status }), _jsx(Span, { color: "muted", className: "text-[11px] shrink-0", children: row.updatedAt })] }), renderRowActions && (_jsx(Row, { "data-no-row-click": true, justify: "end", gap: "xs", className: "border-t border-[var(--appkit-color-border)] -mx-[var(--appkit-space-3)] -mb-[var(--appkit-space-3)] mt-[var(--appkit-space-1)] px-[var(--appkit-space-3)] py-[var(--appkit-space-2)]", onClick: (e) => e.stopPropagation(), children: renderRowActions(row) }))] })] }));
 }
 export function AdminViewCards({ rows, view, isLoading, emptyLabel = "No items found", onRowClick, selectedIdSet, onToggleSelect, renderRowActions, resourceIcon, }) {
     if (isLoading) {

package/dist/features/seller/components/SellerProductShell.js

@@ -15,7 +15,6 @@ import { DEFAULT_MIN_OFFER_PERCENT } from "../../../_internal/shared/features/of
 import { PRODUCT_MAX_IMAGES, PRODUCT_MAX_VIDEOS, PRODUCT_IMAGE_INDEX_MAX, } from "../../../_internal/shared/media/limits";
 import { isFinalSale } from "../../products/constants/final-sale";
 import { normalizeError } from "../../../errors/normalize";
-import { toUserMessage } from "../../../errors/error-display-map";
 /**
  * "bundle" is a categoryType, not a ListingType, so it can't live in
  * LISTING_TYPE_REGISTRY — this is the single, explicit escape hatch that
@@ -351,6 +350,29 @@ const EDIT_SECTIONS = [
     { id: "publish", label: "Publish" },
 ];
 // ── Main SellerProductShell ───────────────────────────────────────────────
+/**
+ * The message for a failed save.
+ *
+ * 🛑 "Fix the highlighted errors" may ONLY be said when something is actually
+ * highlighted. `toUserMessage` short-circuits to its `fallback` whenever no
+ * translator is passed (`if (!t) return generic`), so passing that sentence as
+ * the fallback rendered it for EVERY failure code — an authorization or
+ * not-found refusal was reported to the seller as a validation problem, with
+ * nothing marked and nothing to act on.
+ *
+ * With no issues we say so plainly and quote the CODE. A code is a stable
+ * identifier, not server text, so this does not reintroduce the raw-message
+ * leak Rule #9 §6 forbids — it is the same reasoning that puts the error digest
+ * in front of users (Root Cause #78): an opaque handle they can quote beats an
+ * explanation that is wrong.
+ */
+function saveFailureMessage(code, issueCount) {
+    if (issueCount > 0)
+        return "Fix the highlighted errors and try again.";
+    return code
+        ? `Could not save — the server refused this change (${code}). Nothing was changed.`
+        : "Could not save — the server refused this change. Nothing was changed.";
+}
 export function SellerProductShell({ mode, listingType = "standard", initialValues, 
 /*
  * `productId` was declared on the props interface and NEVER DESTRUCTURED —
@@ -426,9 +448,7 @@ productId, onSave, onPublish, onDiscard, isLoading = false, storeSlug, renderCat
             }
             applyZodIssues(result.issues ?? [], setFieldError);
             if (!silent) {
-                showToast(toUserMessage(result.code, undefined, {
-                    fallback: "Fix the highlighted errors and try again.",
-                }), "error");
+                showToast(saveFailureMessage(result.code, (result.issues ?? []).length), "error");
             }
         }
         catch (err) {
@@ -469,9 +489,7 @@ productId, onSave, onPublish, onDiscard, isLoading = false, storeSlug, renderCat
                 return;
             }
             applyZodIssues(result.issues ?? [], setFieldError);
-            showToast(toUserMessage(result.code, undefined, {
-                fallback: "Fix the highlighted errors and try again.",
-            }), "error");
+            showToast(saveFailureMessage(result.code, (result.issues ?? []).length), "error");
         }
         catch (err) {
             void normalizeError(err);

package/dist/index.d.ts

@@ -3040,7 +3040,7 @@ export { formatMonthYear } from "./utils/date.formatter";
 export { generateMediaFilename } from "./utils/id-generators";
 export { deriveContextTypeFromFilename } from "./utils/id-generators";
 export type { MediaFilenameContext } from "./utils/id-generators";
-export { resolveMediaUrl, resolveVideoUrl, FIREBASE_STORAGE_HOST, GCS_HOST, isStoredMediaRef, MEDIA_PROXY_PREFIX, MEDIA_URL_MAX_LENGTH, MEDIA_URL_MESSAGE, APPROVED_MEDIA_DOMAINS, } from "./utils/media-url";
+export { resolveMediaUrl, resolveVideoUrl, FIREBASE_STORAGE_HOST, GCS_HOST, isStoredMediaRef, getYouTubeVideoId, MEDIA_PROXY_PREFIX, MEDIA_URL_MAX_LENGTH, MEDIA_URL_MESSAGE, APPROVED_MEDIA_DOMAINS, } from "./utils/media-url";
 export { generateFAQId } from "./utils/id-generators";
 export type { GenerateFAQIdInput } from "./utils/id-generators";
 export { generateCroppedImageFilename } from "./utils/id-generators";

package/dist/index.js

@@ -5401,7 +5401,7 @@ export { formatCurrency, formatFileSize } from "./utils/number.formatter";
 export { formatMonthYear } from "./utils/date.formatter";
 export { generateMediaFilename } from "./utils/id-generators"; // generateProductImageFilename already exported from "./utils/id-generators";
 export { deriveContextTypeFromFilename } from "./utils/id-generators";
-export { resolveMediaUrl, resolveVideoUrl, FIREBASE_STORAGE_HOST, GCS_HOST, isStoredMediaRef, MEDIA_PROXY_PREFIX, MEDIA_URL_MAX_LENGTH, MEDIA_URL_MESSAGE, APPROVED_MEDIA_DOMAINS, } from "./utils/media-url";
+export { resolveMediaUrl, resolveVideoUrl, FIREBASE_STORAGE_HOST, GCS_HOST, isStoredMediaRef, getYouTubeVideoId, MEDIA_PROXY_PREFIX, MEDIA_URL_MAX_LENGTH, MEDIA_URL_MESSAGE, APPROVED_MEDIA_DOMAINS, } from "./utils/media-url";
 export { generateFAQId } from "./utils/id-generators";
 export { generateCroppedImageFilename } from "./utils/id-generators";
 // D5 + VC7 buyer↔seller conversations were deleted 2026-08-31 (W11/D16). The

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mohasinac/appkit",
-  "version": "4.41.7",
+  "version": "4.41.9",
   "license": "MIT",
   "publishConfig": {
     "access": "public"