@mohasinac/appkit 4.41.15 → 4.41.17

package/dist/features/events/actions/event-actions.d.ts

@@ -64,6 +64,32 @@ export declare function listPublicEvents(params?: string | {
     page?: number;
     pageSize?: number;
 }): Promise<FirebaseSieveResult<EventDocument>>;
+/**
+ * 🛑 ONLY `draft` IS HIDDEN. Every other status is public history.
+ *
+ * This read `status !== "active"`, which collapsed four distinct states into
+ * "this event does not exist":
+ *
+ *   ended     a finished raffle — the thing people come back to read, and the
+ *             only place `raffleWinnerDisplayName` is ever shown. The seeded
+ *             `event-won-original-set-raffle` has a real recorded winner and
+ *             its page answered 404.
+ *   cancelled should say it was cancelled. Vanishing tells a visitor holding
+ *             the link that they misremembered it, not that it was called off.
+ *   paused    temporarily not accepting entries, which is not the same as gone.
+ *   draft     genuinely not published yet — the one case 404 is right for.
+ *
+ * The rendering layer was ALREADY built for this: `events/[id]/layout.tsx`
+ * computes `eventStatus`, derives `isActive`, and gates `showParticipateTab`
+ * on it. Participation is refused by that gate, not by hiding the page — so
+ * this filter was the only thing standing between a visitor and content the
+ * UI knew how to show.
+ *
+ * The API (`GET /api/events/[id]`) already returned cancelled and ended events
+ * with 200 while the page 404'd them, so the two layers disagreed about what
+ * exists. Measured live before the fix:
+ *   active 200/renders · cancelled 200/404 · ended 200/404 · paused 404/404
+ */
 export declare function getPublicEventById(id: string): Promise<EventDocument | null>;
 export declare function getEventLeaderboard(eventId: string): Promise<import("../types").LeaderboardEntry[]>;
 /**

package/dist/features/events/actions/event-actions.js

@@ -140,9 +140,35 @@ export async function listPublicEvents(params) {
     // PUBLIC by name — it backs the homepage strip and /events.
     return { ...result, items: hidePublicTestData(result.items) };
 }
+/**
+ * 🛑 ONLY `draft` IS HIDDEN. Every other status is public history.
+ *
+ * This read `status !== "active"`, which collapsed four distinct states into
+ * "this event does not exist":
+ *
+ *   ended     a finished raffle — the thing people come back to read, and the
+ *             only place `raffleWinnerDisplayName` is ever shown. The seeded
+ *             `event-won-original-set-raffle` has a real recorded winner and
+ *             its page answered 404.
+ *   cancelled should say it was cancelled. Vanishing tells a visitor holding
+ *             the link that they misremembered it, not that it was called off.
+ *   paused    temporarily not accepting entries, which is not the same as gone.
+ *   draft     genuinely not published yet — the one case 404 is right for.
+ *
+ * The rendering layer was ALREADY built for this: `events/[id]/layout.tsx`
+ * computes `eventStatus`, derives `isActive`, and gates `showParticipateTab`
+ * on it. Participation is refused by that gate, not by hiding the page — so
+ * this filter was the only thing standing between a visitor and content the
+ * UI knew how to show.
+ *
+ * The API (`GET /api/events/[id]`) already returned cancelled and ended events
+ * with 200 while the page 404'd them, so the two layers disagreed about what
+ * exists. Measured live before the fix:
+ *   active 200/renders · cancelled 200/404 · ended 200/404 · paused 404/404
+ */
 export async function getPublicEventById(id) {
     const event = await eventRepository.findByIdOrSlug(id);
-    if (!event || event.status !== "active")
+    if (!event || event.status === "draft")
         return null;
     return event;
 }

package/dist/features/seller/components/SellerProductsView.js

@@ -252,11 +252,27 @@ export function SellerProductsView({ onDeleteProduct, onCreateClick, }) {
                         .filter(Boolean)
                         .join(" · ")
                     : "";
+                /*
+                 * 🛑 THE STATUS GOES IN THE VISIBLE LINE, NOT ONLY IN `status`.
+                 *
+                 * `status` is mapped correctly and the API does emit it (measured:
+                 * "published" on every row) — but this view's right-hand slot holds
+                 * Edit / Duplicate / Delete, so unlike the admin table there is no
+                 * status chip and the value was never rendered anywhere. A seller
+                 * could not tell which of their listings were live without opening
+                 * each one, and a checklist case that begins "find a listing whose
+                 * status reads Published" had nothing to read.
+                 *
+                 * Same family as Root Cause #52: the data was already on the row and
+                 * the UI simply never presented it.
+                 */
+                const statusLabel = toStringValue(item.status, "draft");
+                const secondaryBase = auctionSecondary || toStringValue(item.condition, "");
                 return {
                     id: toStringValue(item.id, `product-${index}`),
                     primary: toStringValue(item.title ?? item.name, "Untitled product"),
-                    secondary: auctionSecondary || toStringValue(item.condition, ""),
-                    status: toStringValue(item.status, "draft"),
+                    secondary: [secondaryBase, statusLabel].filter(Boolean).join(" · "),
+                    status: statusLabel,
                     updatedAt: toRelativeDate(item.updatedAt ?? item.createdAt),
                     imageUrl: toStringValue(item.mainImage ?? item.images?.[0], undefined),
                     image: toStringValue(item.mainImage ?? item.images?.[0], undefined),

package/dist/features/tester/seed-data/authored/account-auth__signup-login.js

@@ -74,7 +74,26 @@ export const authored = {
         steps: [
             "Open /auth/register.",
             "Type QA Signup Tester in the 'Full name' field.",
-            "Type qa-signup-1@mailnull.com in the 'Email address' field — if that address already has an account from a previous run, increment the number and use qa-signup-2@mailnull.com, and so on.",
+            /*
+             * 🛑 SUBSTITUTE THE RUN ID — this is the one input in the catalogue that
+             * is deliberately not literal.
+             *
+             * `users` is PRESERVE tier: it survives every catalogue wipe, so an
+             * account created here is permanent and the harness cannot clean it up.
+             * The previous instruction ("increment the number if it already exists")
+             * made that explicit and unbounded — one more dead account per run,
+             * forever.
+             *
+             * A run-stamped address under `letitrip-qa.test` fixes both halves:
+             * the address is unique per run so signup never collides, and
+             * `.test` is an RFC 2606 reserved TLD that can never be registered and
+             * can never receive mail — so no real person can ever hold one, which is
+             * what makes `tester/scripts/purge-qa-signups.mjs` safe to point at the
+             * PRESERVE tier at all.
+             *
+             * Run that purge after the run to remove exactly these accounts.
+             */
+            "Type qa-signup+<runId>@letitrip-qa.test in the 'Email address' field, substituting the current run id — e.g. qa-signup+run-1789483929743@letitrip-qa.test.",
             "Type TestPass123! in the 'Password' field.",
             "Type TestPass123! in the 'Confirm password' field.",
             "Tick the 'I accept the terms' checkbox.",
@@ -83,7 +102,7 @@ export const authored = {
         ],
         inputs: {
             fullName: "QA Signup Tester",
-            email: "qa-signup-1@mailnull.com",
+            email: "qa-signup+<runId>@letitrip-qa.test",
             password: "TestPass123!",
         },
         expectedBehaviour: "A Firebase Auth record and a matching Firestore user document are created, keyed on the Auth uid rather than on a generated user-* slug. A verification email is dispatched. The browser is signed in and moved off /auth/register.",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mohasinac/appkit",
-  "version": "4.41.15",
+  "version": "4.41.17",
   "license": "MIT",
   "publishConfig": {
     "access": "public"