@mohasinac/appkit 4.41.11 → 4.41.13

package/dist/features/admin/components/AdminOrdersView.js

@@ -141,9 +141,35 @@ export function AdminOrdersView({ children, ...props }) {
                     ? `${title}${extraCount > 0 ? ` +${extraCount} more` : ""}`
                     : `Order ${orderId}`,
                 secondary: [
-                    toStringValue(item.buyerName ?? item.customerName, "Unknown buyer"),
-                    toCurrency(item.totalAmount ?? item.total ?? item.amount),
-                    orderId.slice(0, 14),
+                    /*
+                     * 🛑 `userName` and `totalPrice` FIRST — they are the document's
+                     * real field names (OrderDocument, and the live response of
+                     * GET /api/admin/orders).
+                     *
+                     * This read `buyerName ?? customerName` and
+                     * `totalAmount ?? total ?? amount`: five names, not one of which
+                     * the order document has ever carried. So every row rendered
+                     * "Unknown buyer · -", on all 25 rows, for as long as the view has
+                     * existed — and the `??` chains made it look like considered
+                     * defensive coding rather than a guess. A fallback spelled three
+                     * ways is the tell that nobody checked which one was real.
+                     *
+                     * The aliases are GONE rather than demoted to fallbacks: nothing
+                     * declares them (the client `Order` type has no such fields) and
+                     * nothing emits them (no adapter renames to them). Keeping a
+                     * fallback with no producer only preserves the ambiguity that
+                     * hid the bug.
+                     */
+                    toStringValue(item.userName, "Unknown buyer"),
+                    toCurrency(item.totalPrice),
+                    /*
+                     * Not `.slice(0, 14)` — that cut mid-date, so
+                     * `order-1-20260822-aucwon` and `order-1-20260821-prizedr` both
+                     * rendered as "order-1-202608". A truncation that destroys
+                     * uniqueness is worse than a long string, because the id is the
+                     * one thing on the row an admin searches by.
+                     */
+                    orderId,
                     paymentReviewLabel(item),
                 ]
                     .filter(Boolean)

package/dist/features/seller/components/SellerOrdersView.js

@@ -366,13 +366,37 @@ export function SellerOrdersView({ orderDetailApiBase = SELLER_ENDPOINTS.ORDERS,
             const loc = item.physicalLocation;
             return {
                 id: toStringValue(item.id, `order-${index}`),
-                primary: `Order ${toStringValue(item.id, "-").slice(0, 14)}`,
-                secondary: toStringValue(item.buyerName ?? item.buyerDisplayName, "Unknown buyer"),
+                /*
+                 * 🛑 The row says WHAT WAS SOLD, not the id repeated.
+                 *
+                 * This was `Order ${id.slice(0, 14)}` — a raw id, truncated
+                 * mid-date, so two different orders rendered identically. The title
+                 * was available the whole time: `items[0].productTitle` is
+                 * denormalised onto every order precisely so a list never needs a
+                 * second fetch (Root Cause #52), and it is already read three lines
+                 * below as `itemTitle`.
+                 */
+                primary: (() => {
+                    const title = typeof firstItem.productTitle === "string" ? firstItem.productTitle : "";
+                    if (!title)
+                        return `Order ${toStringValue(item.id, "-")}`;
+                    const extra = itemsArr.length - 1;
+                    return extra > 0 ? `${title} +${extra} more` : title;
+                })(),
+                /*
+                 * `userName` / `totalPrice` are the document's real field names.
+                 * `buyerName`/`buyerDisplayName`/`totalAmount`/`total` are four
+                 * spellings the order document has never carried, so every seller's
+                 * order list showed "Unknown buyer" and ₹0 — see AdminOrdersView for
+                 * the full writeup. They are removed rather than demoted: nothing
+                 * declares them and nothing emits them.
+                 */
+                secondary: toStringValue(item.userName, "Unknown buyer"),
                 status: toStringValue(item.status, "PENDING"),
                 updatedAt: toRelativeDate(item.updatedAt ?? item.orderDate ?? item.createdAt),
                 itemCount: itemsArr.length,
-                totalAmount: Number(item.totalAmount ?? item.total ?? 0),
-                buyerName: toStringValue(item.buyerName ?? item.buyerDisplayName, "Unknown buyer"),
+                totalAmount: Number(item.totalPrice ?? 0),
+                buyerName: toStringValue(item.userName, "Unknown buyer"),
                 itemImage: typeof firstItem.image === "string" ? firstItem.image : undefined,
                 itemTitle: typeof firstItem.productTitle === "string" ? firstItem.productTitle : undefined,
                 physicalLocation: loc && typeof loc.zone === "string"

package/dist/features/tester/seed-data/authored/admin__admin-detail-round-trips.js

@@ -117,12 +117,12 @@ export const authored = {
         startPage: "/admin/orders",
         steps: [
             "Sign in as admin@letitrip.in / TempPass123!.",
-            "Open /admin/orders and open the row drawer for order-1-20260721-11joon.",
+            "Open /admin/orders and open the row drawer for order-1-20251107-11joon.",
             "Write down the item titles, the shipping address, the payment method and the status.",
             "Close the drawer and use that row's Open full page action.",
             "Read the same four things on the full page.",
         ],
-        inputs: { orderId: "order-1-20260721-11joon" },
+        inputs: { orderId: "order-1-20251107-11joon" },
         expectedBehaviour: "The drawer and the full page are two renderings of one record, so they must agree. Where they differ, one of them is reading a field the other is not — and the full page is the bookmarkable one an admin will send to somebody else.",
         expectedUiState: "Item titles, address, payment method and status are identical in both, and the full page is at a real bookmarkable URL rather than a modal over the list.",
         expectedData: { drawerAndPageAgree: true },

package/dist/features/tester/seed-data/authored/buying__order-detail-actions.js

@@ -42,12 +42,12 @@ export const authored = {
         startPage: "/user/orders",
         steps: [
             "Sign in as karthik.new@gmail.com / TempPass123!, a seeded buyer who owns no seeded orders.",
-            "Navigate directly to /api/user/orders/order-1-20260721-11joon/invoice — a seeded order belonging to a different persona.",
+            "Navigate directly to /api/user/orders/order-1-20251107-11joon/invoice — a seeded order belonging to a different persona.",
             "Read the response.",
-            "Now navigate to /user/orders/order-1-20260721-11joon.",
+            "Now navigate to /user/orders/order-1-20251107-11joon.",
             "Read that page.",
         ],
-        inputs: { foreignOrderId: "order-1-20260721-11joon" },
+        inputs: { foreignOrderId: "order-1-20251107-11joon" },
         expectedBehaviour: "An order id is short and guessable, so ownership is checked on every hit rather than relied upon to be secret. Answering 403 instead of 404 would confirm that an order with that id exists, which is a membership oracle over the id space.",
         expectedUiState: "Neither the invoice nor the order page shows any of that order's contents. No item titles, no address, no amounts.",
         expectedData: { foreignInvoiceServed: false },
@@ -74,14 +74,14 @@ export const authored = {
         startPage: "/user/orders",
         steps: [
             "Sign in as vivaan.kapoor@gmail.com / TempPass123! — this persona owns the seeded DELIVERED orders, and a return can only be requested on one.",
-            "Open /user/orders and open order-1-20260721-11joon, which is delivered.",
+            "Open /user/orders and open order-1-20251107-11joon, which is delivered.",
             "Use the Return action.",
             "Give the reason: item not as described.",
             "Submit the request.",
             "Reload the order.",
             "Open /user/returns and look for it.",
         ],
-        inputs: { orderId: "order-1-20260721-11joon", reason: "item not as described" },
+        inputs: { orderId: "order-1-20251107-11joon", reason: "item not as described" },
         expectedBehaviour: "A return request moves the order into Return Requested and appears on the returns surface. That status is deliberately an ACTIVE one — it is the seller's next action item, not a closed state — so the order must not disappear from the active list.",
         expectedUiState: "The order's status reads Return Requested, and the same order is listed under /user/returns.",
         expectedData: { statusAfterReturn: "return_requested" },
@@ -92,12 +92,12 @@ export const authored = {
         startPage: "/user/orders",
         steps: [
             "Sign in as rehan.sheikh@gmail.com / TempPass123! — this persona owns the seeded SHIPPED order.",
-            "Open /user/orders and open order-1-20260718-aevnlw.",
+            "Open /user/orders and open order-1-20251104-aevnlw.",
             "Use the Track action.",
             "Read every step on the timeline and note which carry a date and which do not.",
             "Compare the dates shown against the order's own placed and shipped dates.",
         ],
-        inputs: { orderId: "order-1-20260718-aevnlw" },
+        inputs: { orderId: "order-1-20251104-aevnlw" },
         expectedBehaviour: "Each timeline step shows the date actually recorded for it. A step with no recorded date renders an em-dash rather than a guess — an invented or estimated date is worse than a blank, because it cannot be told apart from a real one.",
         expectedUiState: "The placed and shipped steps carry dates matching the order. Steps the order has not reached show no date rather than today's.",
         expectedData: { fabricatedDatesShown: false },
@@ -108,14 +108,14 @@ export const authored = {
         startPage: "/user/orders",
         steps: [
             "Sign in as karthik.new@gmail.com / TempPass123!, a seeded buyer who owns no seeded orders.",
-            "Navigate to /user/orders/order-1-20260721-11joon/track.",
-            "Navigate to /user/orders/order-1-20260721-11joon/invoice.",
-            "Navigate to /user/orders/order-1-20260721-11joon/return.",
-            "Navigate to /user/orders/order-1-20260721-11joon/cancel.",
-            "Navigate to /user/orders/order-1-20260721-11joon/payment.",
+            "Navigate to /user/orders/order-1-20251107-11joon/track.",
+            "Navigate to /user/orders/order-1-20251107-11joon/invoice.",
+            "Navigate to /user/orders/order-1-20251107-11joon/return.",
+            "Navigate to /user/orders/order-1-20251107-11joon/cancel.",
+            "Navigate to /user/orders/order-1-20251107-11joon/payment.",
             "Read each page in turn.",
         ],
-        inputs: { foreignOrderId: "order-1-20260721-11joon" },
+        inputs: { foreignOrderId: "order-1-20251107-11joon" },
         expectedBehaviour: "Ownership is enforced on EVERY subroute, not only on the order page that links to them. A subroute that checks nothing is reachable by typing a URL, and these five carry the address, the amounts and the payment details.",
         expectedUiState: "All five show a not-found page. None shows an item title, an address, an amount or a tracking number belonging to that order.",
         expectedData: { subroutesLeakingData: 0 },
@@ -126,11 +126,11 @@ export const authored = {
         startPage: "/user/orders",
         steps: [
             "Open a private window with no session.",
-            "Navigate to /user/orders/order-1-20260721-11joon/track.",
+            "Navigate to /user/orders/order-1-20251107-11joon/track.",
             "Read the page.",
             "Navigate to /user/orders and read that page too.",
         ],
-        inputs: { foreignOrderId: "order-1-20260721-11joon" },
+        inputs: { foreignOrderId: "order-1-20251107-11joon" },
         expectedBehaviour: "A signed-out visitor is sent to sign in. Being blocked IS the expected result here — the failure to look for is the page rendering its content for a moment before redirecting, which is enough to read and enough for a crawler to capture.",
         expectedUiState: "The sign-in page, or the orders page in its signed-out state. At no point does any order content appear, not even briefly.",
         expectedData: { orderContentVisibleToGuest: false },

package/dist/seed/orders-seed-data.js

@@ -448,11 +448,54 @@ const cashOrderVerified = {
     createdAt: daysAgo(4),
     updatedAt: daysAgo(2),
 };
+/*
+ * 🛑 DERIVES `items[]` FROM THE FLAT FIELDS WHEN A FIXTURE OMITS IT.
+ *
+ * `items[]` is the canonical shape and every orders surface reads
+ * `items[0].productTitle` for its row label (Root Cause #52). The generator
+ * below was taught to emit it — and that fix was NARROWER THAN THE DEFECT:
+ * measured after it shipped, 14 of the 50 seeded orders still had none,
+ * because the hand-written fixtures never go through the generator.
+ *
+ * That is Root Cause #84's shape — a fix scoped to the population you happened
+ * to be looking at. Patching those 14 by hand would leave the 15th to whoever
+ * writes it next, so the derivation lives here instead, on the path EVERY
+ * fixture already takes.
+ *
+ * It only ever fills a gap: a fixture that declares its own `items[]` (the
+ * multi-line ones, where the flat fields cannot express two products) is
+ * passed through untouched.
+ */
+function withOrderItems(order) {
+    if (Array.isArray(order.items) && order.items.length > 0)
+        return order;
+    if (!order.productId)
+        return order;
+    const quantity = order.quantity ?? 1;
+    const unitPrice = order.unitPrice ?? 0;
+    return {
+        ...order,
+        items: [
+            {
+                productId: order.productId,
+                productTitle: order.productTitle ?? order.productId,
+                listingType: "standard",
+                quantity,
+                unitPrice,
+                // Prefer the order's own total: on a single-line order it is the
+                // authoritative figure, and re-deriving it would silently drop any
+                // fixture that deliberately encodes a locked or negotiated price.
+                totalPrice: order.totalPrice ?? unitPrice * quantity,
+            },
+        ],
+    };
+}
 // Backfills image/imageUrls (see orderItemImage() above) on every fixture
 // regardless of which shape it uses (multi-item `items[]` vs the legacy
 // single-item top-level fields), so no seeded order silently renders without
 // a thumbnail the way real pre-2026-08-20 orders do.
-function withOrderImages(order) {
+function withOrderImages(input) {
+    const order = withOrderItems(input);
     return {
         ...order,
         imageUrls: order.imageUrls ?? (order.productId ? [orderItemImage(order.productId)] : undefined),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mohasinac/appkit",
-  "version": "4.41.11",
+  "version": "4.41.13",
   "license": "MIT",
   "publishConfig": {
     "access": "public"