@mohasinac/appkit 4.41.10 → 4.41.12

package/dist/features/tester/seed-data/authored/admin__admin-detail-round-trips.js

@@ -117,12 +117,12 @@ export const authored = {
         startPage: "/admin/orders",
         steps: [
             "Sign in as admin@letitrip.in / TempPass123!.",
-            "Open /admin/orders and open the row drawer for order-1-20260721-11joon.",
+            "Open /admin/orders and open the row drawer for order-1-20251107-11joon.",
             "Write down the item titles, the shipping address, the payment method and the status.",
             "Close the drawer and use that row's Open full page action.",
             "Read the same four things on the full page.",
         ],
-        inputs: { orderId: "order-1-20260721-11joon" },
+        inputs: { orderId: "order-1-20251107-11joon" },
         expectedBehaviour: "The drawer and the full page are two renderings of one record, so they must agree. Where they differ, one of them is reading a field the other is not — and the full page is the bookmarkable one an admin will send to somebody else.",
         expectedUiState: "Item titles, address, payment method and status are identical in both, and the full page is at a real bookmarkable URL rather than a modal over the list.",
         expectedData: { drawerAndPageAgree: true },

package/dist/features/tester/seed-data/authored/buying__order-detail-actions.js

@@ -42,12 +42,12 @@ export const authored = {
         startPage: "/user/orders",
         steps: [
             "Sign in as karthik.new@gmail.com / TempPass123!, a seeded buyer who owns no seeded orders.",
-            "Navigate directly to /api/user/orders/order-1-20260721-11joon/invoice — a seeded order belonging to a different persona.",
+            "Navigate directly to /api/user/orders/order-1-20251107-11joon/invoice — a seeded order belonging to a different persona.",
             "Read the response.",
-            "Now navigate to /user/orders/order-1-20260721-11joon.",
+            "Now navigate to /user/orders/order-1-20251107-11joon.",
             "Read that page.",
         ],
-        inputs: { foreignOrderId: "order-1-20260721-11joon" },
+        inputs: { foreignOrderId: "order-1-20251107-11joon" },
         expectedBehaviour: "An order id is short and guessable, so ownership is checked on every hit rather than relied upon to be secret. Answering 403 instead of 404 would confirm that an order with that id exists, which is a membership oracle over the id space.",
         expectedUiState: "Neither the invoice nor the order page shows any of that order's contents. No item titles, no address, no amounts.",
         expectedData: { foreignInvoiceServed: false },
@@ -74,14 +74,14 @@ export const authored = {
         startPage: "/user/orders",
         steps: [
             "Sign in as vivaan.kapoor@gmail.com / TempPass123! — this persona owns the seeded DELIVERED orders, and a return can only be requested on one.",
-            "Open /user/orders and open order-1-20260721-11joon, which is delivered.",
+            "Open /user/orders and open order-1-20251107-11joon, which is delivered.",
             "Use the Return action.",
             "Give the reason: item not as described.",
             "Submit the request.",
             "Reload the order.",
             "Open /user/returns and look for it.",
         ],
-        inputs: { orderId: "order-1-20260721-11joon", reason: "item not as described" },
+        inputs: { orderId: "order-1-20251107-11joon", reason: "item not as described" },
         expectedBehaviour: "A return request moves the order into Return Requested and appears on the returns surface. That status is deliberately an ACTIVE one — it is the seller's next action item, not a closed state — so the order must not disappear from the active list.",
         expectedUiState: "The order's status reads Return Requested, and the same order is listed under /user/returns.",
         expectedData: { statusAfterReturn: "return_requested" },
@@ -92,12 +92,12 @@ export const authored = {
         startPage: "/user/orders",
         steps: [
             "Sign in as rehan.sheikh@gmail.com / TempPass123! — this persona owns the seeded SHIPPED order.",
-            "Open /user/orders and open order-1-20260718-aevnlw.",
+            "Open /user/orders and open order-1-20251104-aevnlw.",
             "Use the Track action.",
             "Read every step on the timeline and note which carry a date and which do not.",
             "Compare the dates shown against the order's own placed and shipped dates.",
         ],
-        inputs: { orderId: "order-1-20260718-aevnlw" },
+        inputs: { orderId: "order-1-20251104-aevnlw" },
         expectedBehaviour: "Each timeline step shows the date actually recorded for it. A step with no recorded date renders an em-dash rather than a guess — an invented or estimated date is worse than a blank, because it cannot be told apart from a real one.",
         expectedUiState: "The placed and shipped steps carry dates matching the order. Steps the order has not reached show no date rather than today's.",
         expectedData: { fabricatedDatesShown: false },
@@ -108,14 +108,14 @@ export const authored = {
         startPage: "/user/orders",
         steps: [
             "Sign in as karthik.new@gmail.com / TempPass123!, a seeded buyer who owns no seeded orders.",
-            "Navigate to /user/orders/order-1-20260721-11joon/track.",
-            "Navigate to /user/orders/order-1-20260721-11joon/invoice.",
-            "Navigate to /user/orders/order-1-20260721-11joon/return.",
-            "Navigate to /user/orders/order-1-20260721-11joon/cancel.",
-            "Navigate to /user/orders/order-1-20260721-11joon/payment.",
+            "Navigate to /user/orders/order-1-20251107-11joon/track.",
+            "Navigate to /user/orders/order-1-20251107-11joon/invoice.",
+            "Navigate to /user/orders/order-1-20251107-11joon/return.",
+            "Navigate to /user/orders/order-1-20251107-11joon/cancel.",
+            "Navigate to /user/orders/order-1-20251107-11joon/payment.",
             "Read each page in turn.",
         ],
-        inputs: { foreignOrderId: "order-1-20260721-11joon" },
+        inputs: { foreignOrderId: "order-1-20251107-11joon" },
         expectedBehaviour: "Ownership is enforced on EVERY subroute, not only on the order page that links to them. A subroute that checks nothing is reachable by typing a URL, and these five carry the address, the amounts and the payment details.",
         expectedUiState: "All five show a not-found page. None shows an item title, an address, an amount or a tracking number belonging to that order.",
         expectedData: { subroutesLeakingData: 0 },
@@ -126,11 +126,11 @@ export const authored = {
         startPage: "/user/orders",
         steps: [
             "Open a private window with no session.",
-            "Navigate to /user/orders/order-1-20260721-11joon/track.",
+            "Navigate to /user/orders/order-1-20251107-11joon/track.",
             "Read the page.",
             "Navigate to /user/orders and read that page too.",
         ],
-        inputs: { foreignOrderId: "order-1-20260721-11joon" },
+        inputs: { foreignOrderId: "order-1-20251107-11joon" },
         expectedBehaviour: "A signed-out visitor is sent to sign in. Being blocked IS the expected result here — the failure to look for is the page rendering its content for a moment before redirecting, which is enough to read and enough for a crawler to capture.",
         expectedUiState: "The sign-in page, or the orders page in its signed-out state. At no point does any order content appear, not even briefly.",
         expectedData: { orderContentVisibleToGuest: false },

package/dist/seed/orders-seed-data.js

@@ -40,6 +40,33 @@ import { withOrderSearchTxt } from "./_helpers/search-txt-wrappers";
 import { seedPhoto } from "./_helpers/media";
 const NOW = new Date();
 const daysAgo = (n) => new Date(NOW.getTime() - n * 86400000);
+/**
+ * The anchor the order IDs are built from — fixed, never `NOW`.
+ *
+ * 🛑 An ID may not contain a value that moves. `generateOrderId` embeds a
+ * `yyyymmdd` derived from its anchor, so with `NOW` every order's id changed on
+ * every calendar day: `appkit-seed load` CREATED 50 fresh documents instead of
+ * upserting the same 50, and `status`/`delete` computed ids that had never been
+ * written.
+ *
+ * Measured immediately after a successful `load --collections orders` that
+ * reported "created 50, errors 0": `appkit-seed status` answered
+ * **`orders 50 seed / 0 in db`**. Both numbers were right; they were about
+ * different sets of ids.
+ *
+ * This is exactly the case Recurrent Root Cause #25 names — "`Date.now()` used
+ * as an ID component (as opposed to just a display timestamp)". The
+ * distinction is the whole fix:
+ *
+ *   - **IDs** anchor to `SEED_EPOCH`, so they are reproducible forever.
+ *   - **Display timestamps** (`orderDate`, `createdAt`, shipping dates) keep
+ *     using `daysAgo()` off `NOW`, so a reseeded catalogue still looks recent
+ *     and time-bound fixtures re-arm, which is what the tester window needs.
+ *
+ * It also broke every checklist case that names an order by id: they were
+ * authored against one day's ids and could never resolve afterwards.
+ */
+const SEED_EPOCH = new Date("2026-01-01T00:00:00.000Z");
 // Deterministic per-product thumbnail — picsum.photos returns a stable image
 // for any seed string, so this doesn't need to match the real product seed's
 // own image, just be present and consistent across reseeds. Backfills the
@@ -64,7 +91,9 @@ function seededSuffix(seed) {
     return (hash >>> 0).toString(36).padStart(6, "0").slice(0, 6);
 }
 const generateOrderId = (itemCount, daysBack, seed) => {
-    const date = new Date(NOW.getTime() - daysBack * 86400000);
+    // SEED_EPOCH, not NOW — see the block comment on SEED_EPOCH. An id that
+    // moves with the calendar is an id that never upserts.
+    const date = new Date(SEED_EPOCH.getTime() - daysBack * 86400000);
     const yyyymmdd = date.toISOString().split("T")[0].replace(/-/g, "");
     const rand = seededSuffix(`${itemCount}-${daysBack}-${seed}`);
     return `order-${itemCount}-${yyyymmdd}-${rand}`;
@@ -419,11 +448,54 @@ const cashOrderVerified = {
     createdAt: daysAgo(4),
     updatedAt: daysAgo(2),
 };
+/*
+ * 🛑 DERIVES `items[]` FROM THE FLAT FIELDS WHEN A FIXTURE OMITS IT.
+ *
+ * `items[]` is the canonical shape and every orders surface reads
+ * `items[0].productTitle` for its row label (Root Cause #52). The generator
+ * below was taught to emit it — and that fix was NARROWER THAN THE DEFECT:
+ * measured after it shipped, 14 of the 50 seeded orders still had none,
+ * because the hand-written fixtures never go through the generator.
+ *
+ * That is Root Cause #84's shape — a fix scoped to the population you happened
+ * to be looking at. Patching those 14 by hand would leave the 15th to whoever
+ * writes it next, so the derivation lives here instead, on the path EVERY
+ * fixture already takes.
+ *
+ * It only ever fills a gap: a fixture that declares its own `items[]` (the
+ * multi-line ones, where the flat fields cannot express two products) is
+ * passed through untouched.
+ */
+function withOrderItems(order) {
+    if (Array.isArray(order.items) && order.items.length > 0)
+        return order;
+    if (!order.productId)
+        return order;
+    const quantity = order.quantity ?? 1;
+    const unitPrice = order.unitPrice ?? 0;
+    return {
+        ...order,
+        items: [
+            {
+                productId: order.productId,
+                productTitle: order.productTitle ?? order.productId,
+                listingType: "standard",
+                quantity,
+                unitPrice,
+                // Prefer the order's own total: on a single-line order it is the
+                // authoritative figure, and re-deriving it would silently drop any
+                // fixture that deliberately encodes a locked or negotiated price.
+                totalPrice: order.totalPrice ?? unitPrice * quantity,
+            },
+        ],
+    };
+}
 // Backfills image/imageUrls (see orderItemImage() above) on every fixture
 // regardless of which shape it uses (multi-item `items[]` vs the legacy
 // single-item top-level fields), so no seeded order silently renders without
 // a thumbnail the way real pre-2026-08-20 orders do.
-function withOrderImages(order) {
+function withOrderImages(input) {
+    const order = withOrderItems(input);
     return {
         ...order,
         imageUrls: order.imageUrls ?? (order.productId ? [orderItemImage(order.productId)] : undefined),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mohasinac/appkit",
-  "version": "4.41.10",
+  "version": "4.41.12",
   "license": "MIT",
   "publishConfig": {
     "access": "public"