@mohasinac/appkit 4.41.1 → 4.41.3

package/dist/features/admin/components/AdminCarouselView.js

@@ -17,6 +17,16 @@ import { apiClient } from "../../../http";
 const PAGE_SIZE = 50;
 const FILTER_KEYS = ["active"];
 const DEFAULT_SORT = "order";
+function extractCarouselRows(response) {
+    if (Array.isArray(response))
+        return response;
+    if (!response || typeof response !== "object")
+        return undefined;
+    const obj = response;
+    if (Array.isArray(obj.data))
+        return obj.data;
+    return Array.isArray(obj.items) ? obj.items : undefined;
+}
 export function AdminCarouselView({ children, onBulkDelete, ...props }) {
     const hasChildren = React.Children.count(children) > 0;
     const [draggingId, setDraggingId] = useState(null);
@@ -30,7 +40,7 @@ export function AdminCarouselView({ children, onBulkDelete, ...props }) {
         queryKey: ["admin", "carousel", "listing"],
         endpoint: `${HOMEPAGE_ENDPOINTS.CAROUSEL}?includeInactive=true`,
         mapRows: (response) => {
-            const sourceItems = Array.isArray(response.data) ? response.data : response.items;
+            const sourceItems = extractCarouselRows(response);
             return toRecordArray(sourceItems)
                 .sort((a, b) => (a.order ?? 0) - (b.order ?? 0))
                 .map((item, index) => {
@@ -50,7 +60,13 @@ export function AdminCarouselView({ children, onBulkDelete, ...props }) {
                 };
             });
         },
-        getTotal: (response, mappedRows) => typeof response.total === "number" ? response.total : mappedRows.length,
+        getTotal: (response, mappedRows) => {
+            if (Array.isArray(response) || !response || typeof response !== "object") {
+                return mappedRows.length;
+            }
+            const total = response.total;
+            return typeof total === "number" ? total : mappedRows.length;
+        },
         buildFilters: (filterState) => {
             const activeRaw = filterState.active;
             if (activeRaw === "true")

package/dist/features/admin/components/AdminCategoriesView.js

@@ -9,6 +9,24 @@ import { toRecordArray, toRelativeDate, toStringValue, } from "../hooks/useAdmin
 import { DataListingView } from "./DataListingView";
 import { AdminCategoryEditorView } from "./AdminCategoryEditorView";
 import { ADMIN_BULK_ACTIONS, ROW_ACTION_META } from "../../products/constants/action-defs";
+/** Rows, whichever of the three shapes the endpoint returns. */
+function extractCategoryRows(response) {
+    if (Array.isArray(response))
+        return response;
+    if (!response || typeof response !== "object")
+        return undefined;
+    const obj = response;
+    if (Array.isArray(obj.data))
+        return obj.data;
+    return Array.isArray(obj.items) ? obj.items : undefined;
+}
+/** `total` only exists on the object shapes; a bare array has none. */
+function extractCategoryTotal(response) {
+    if (Array.isArray(response) || !response || typeof response !== "object")
+        return undefined;
+    const total = response.total;
+    return typeof total === "number" ? total : undefined;
+}
 const COLUMNS = [
     {
         key: "primary",
@@ -46,7 +64,7 @@ const ADMIN_CATEGORIES_CONFIG = {
     ],
     columns: COLUMNS,
     mapRows: (response) => {
-        const sourceItems = Array.isArray(response.data) ? response.data : response.items;
+        const sourceItems = extractCategoryRows(response);
         return toRecordArray(sourceItems).map((item, index) => ({
             id: toStringValue(item.id, `category-${index}`),
             primary: toStringValue(item.name, "Untitled category"),
@@ -59,7 +77,7 @@ const ADMIN_CATEGORIES_CONFIG = {
             updatedAt: toRelativeDate(item.updatedAt ?? item.createdAt),
         }));
     },
-    getTotal: (response, mappedRows) => typeof response.total === "number" ? response.total : mappedRows.length,
+    getTotal: (response, mappedRows) => extractCategoryTotal(response) ?? mappedRows.length,
     buildFilters: (state) => {
         const parts = [];
         if (state.isActive)

package/dist/features/homepage/components/FeaturedBundlesSection.js

@@ -38,7 +38,7 @@ function FeaturedBundleCard({ bundle, showSavingsBadge = true, onBuyNow, }) {
     const cover = bundle.display?.coverImage;
     const href = String(ROUTES.PUBLIC.BUNDLE_DETAIL?.(bundle.slug) ?? "#");
     const discount = computeBundleDiscount(bundle.bundlePrice, bundle.bundleOriginalTotal);
-    return (_jsxs(Stack, { gap: "none", surface: "default", rounded: "xl", border: "default", children: [_jsxs(Link, { href: href, className: "group block p-[var(--appkit-space-3)] hover:no-underline", children: [_jsxs(Div, { className: `relative mb-2 aspect-square ${__O.hidden}`, rounded: "lg", surface: "subtle", children: [cover ? (_jsx(MediaImage, { src: cover, alt: bundle.name, size: "card", className: "transition-transform group-hover:scale-105" })) : (_jsx(Row, { textSize: "3xl", className: "h-full w-full", align: "center", justify: "center", children: PLACEHOLDER_EMOJI })), showSavingsBadge && discount && (_jsx(Badge, { variant: "success", className: "absolute left-2 top-2", children: BUNDLE_COPY.detail.discountBadge(discount.percent) }))] }), _jsx(Text, { className: "line-clamp-2", size: "sm", weight: "semibold", children: bundle.name }), _jsxs(Row, { gap: "sm", align: "center", className: "mt-1", wrap: true, children: [_jsx(Text, { size: "sm", weight: "bold", children: _jsx(GatedPrice, { label: "Sign in to see the bundle price", children: bundle.bundlePrice
+    return (_jsxs(Stack, { gap: "none", surface: "default", rounded: "xl", border: "default", children: [_jsxs(Link, { href: href, className: "group block p-[var(--appkit-space-3)] hover:no-underline", children: [_jsxs(Div, { className: `relative mb-2 aspect-square ${__O.hidden}`, rounded: "lg", surface: "subtle", children: [cover ? (_jsx(MediaImage, { src: cover, alt: bundle.name, size: "card", className: "transition-transform group-hover:scale-105" })) : (_jsx(Row, { textSize: "3xl", className: "h-full w-full", align: "center", justify: "center", children: PLACEHOLDER_EMOJI })), showSavingsBadge && discount && (_jsx(PricesOnly, { children: _jsx(Badge, { variant: "success", className: "absolute left-2 top-2", children: BUNDLE_COPY.detail.discountBadge(discount.percent) }) }))] }), _jsx(Text, { className: "line-clamp-2", size: "sm", weight: "semibold", children: bundle.name }), _jsxs(Row, { gap: "sm", align: "center", className: "mt-1", wrap: true, children: [_jsx(Text, { size: "sm", weight: "bold", children: _jsx(GatedPrice, { label: "Sign in to see the bundle price", children: bundle.bundlePrice
                                         ? formatCurrency(bundle.bundlePrice, "INR")
                                         : BUNDLE_COPY.featured.priceFallback }) }), discount && (_jsx(PricesOnly, { children: _jsx(Text, { size: "xs", color: "muted", className: "line-through", children: formatCurrency(discount.originalTotal, "INR") }) })), _jsxs(Text, { size: "xs", color: "muted", children: ["\u00B7 ", BUNDLE_COPY.featured.itemCount(memberCount)] }), stock !== "in_stock" && (_jsx(Badge, { variant: BUNDLE_STOCK_VARIANT[stock], children: BUNDLE_COPY.stockBadge.listVariantOutOfStock }))] })] }), onBuyNow && (_jsx(Div, { border: "subtle", className: `border-t ${__P.p3}`, padding: "t-xs", children: _jsx(BundleBuyNowCta, { bundleSlug: bundle.slug, outOfStock: stock === "out_of_stock", onBuyNow: onBuyNow, compact: true }) }))] }));
 }

package/dist/features/products/components/MarketplaceBundleCard.js

@@ -10,7 +10,7 @@ const CLS_BUNDLE_PILL = "inline-flex items-center rounded-full bg-violet-600 px-
 const CLS_STOCK_OK = "bg-success-solid text-success-on-solid";
 // audit-content-alignment-ok: button label text, not page content — buttons are universally center-labeled
 const CLS_VIEW_BTN = "mt-2 w-full cursor-pointer rounded-md bg-violet-600 py-[var(--appkit-space-1-5)] text-center text-[length:var(--appkit-text-xs)] font-semibold text-white transition-colors hover:bg-violet-700 active:scale-[0.98]";
-import { BaseListingCard, Div, GatedPrice, Row, Span, Stack, Text, TextLink } from "../../../ui";
+import { BaseListingCard, Div, GatedPrice, PricesOnly, Row, Span, Stack, Text, TextLink } from "../../../ui";
 import { MediaImage } from "../../media/MediaImage";
 import { computeBundleDiscount } from "../../../_internal/shared/features/categories/bundle-pricing";
 import { BUNDLE_COPY } from "../../../_internal/shared/features/categories/bundle-copy";
@@ -49,7 +49,7 @@ export function MarketplaceBundleCard({ bundle, className = "", variant = "grid"
         }
         router.push(String(detailHref));
     }, [detailHref, onNavigate, router]);
-    return (_jsxs(BaseListingCard, { isSelected: isSelected, variant: variant, className: className, onMouseDown: !isSelected ? longPress.onMouseDown : undefined, onMouseUp: !isSelected ? longPress.onMouseUp : undefined, onMouseLeave: !isSelected ? longPress.onMouseLeave : undefined, onTouchStart: !isSelected ? longPress.onTouchStart : undefined, onTouchEnd: !isSelected ? longPress.onTouchEnd : undefined, onTouchCancel: !isSelected ? longPress.onTouchCancel : undefined, children: [_jsxs(BaseListingCard.Hero, { aspect: "square", variant: variant, children: [_jsx(TextLink, { href: String(detailHref), className: "absolute inset-0 block", children: showCollage ? (_jsx(Div, { layout: "grid", className: `h-full w-full gap-[0.125rem] bg-[var(--appkit-color-surface-muted)] ${collageTiles.length === 2 ? "grid-cols-2 grid-rows-1" : "grid-cols-2 grid-rows-2"}`, children: collageTiles.map((tile, i) => (_jsxs(Div, { className: "relative overflow-hidden bg-[var(--appkit-color-surface-muted)]", children: [_jsx(MediaImage, { src: tile.imageURL, alt: tile.title ?? `${bundle.name} item ${i + 1}`, size: "card" }), i === collageTiles.length - 1 && overflow > 0 && (_jsxs(Row, { textWeight: "semibold", textSize: "sm", surface: "overlay-md", className: "absolute inset-0 text-white", align: "center", justify: "center", children: ["+", overflow] }))] }, `${tile.productId}-${i}`))) })) : cover ? (_jsx(Div, { className: "absolute inset-0 bg-[var(--appkit-color-surface-muted)]", children: _jsx(MediaImage, { src: cover, alt: bundle.name, size: "card" }) })) : (_jsx(Row, { className: "absolute inset-0 bg-[var(--appkit-color-surface-muted)]", align: "center", justify: "center", children: _jsx(Text, { className: "text-[var(--appkit-color-text-muted)]", size: "xs", children: "No image" }) })) }), discount && (_jsx(Span, { size: "xs", weight: "bold", className: "absolute left-2 top-2 bg-success-solid text-success-on-solid", rounded: "full", padding: "pill-xs", children: BUNDLE_COPY.detail.discountBadge(discount.percent) })), _jsxs(Stack, { className: "absolute right-2 top-2", align: "end", gap: "xs", children: [_jsx(Span, { size: "xs", weight: "medium", className: CLS_BUNDLE_PILL, children: mergedLabels.bundleBadge }), _jsx(Span, { layout: "inline-flex", color: "inverse", className: `${stock === "out_of_stock" ? "bg-neutral-500 " : CLS_STOCK_OK}`, rounded: "full", padding: "pill-xs", size: "xs", weight: "medium", children: stock === "out_of_stock" ? mergedLabels.outOfStockBadge : mergedLabels.inStockBadge })] }), stock === "out_of_stock" && (_jsx(Row, { surface: "overlay-xs", className: "absolute inset-0", align: "center", justify: "center", children: _jsx(Span, { color: "inverse", size: "xs", weight: "bold", className: "bg-neutral-900/80 tracking-wider", rounded: "default", padding: "pill-md", transform: "uppercase", children: mergedLabels.outOfStockBadge }) })), onSelect && (_jsx(BaseListingCard.Checkbox, { selected: isSelected, onSelect: (event) => {
+    return (_jsxs(BaseListingCard, { isSelected: isSelected, variant: variant, className: className, onMouseDown: !isSelected ? longPress.onMouseDown : undefined, onMouseUp: !isSelected ? longPress.onMouseUp : undefined, onMouseLeave: !isSelected ? longPress.onMouseLeave : undefined, onTouchStart: !isSelected ? longPress.onTouchStart : undefined, onTouchEnd: !isSelected ? longPress.onTouchEnd : undefined, onTouchCancel: !isSelected ? longPress.onTouchCancel : undefined, children: [_jsxs(BaseListingCard.Hero, { aspect: "square", variant: variant, children: [_jsx(TextLink, { href: String(detailHref), className: "absolute inset-0 block", children: showCollage ? (_jsx(Div, { layout: "grid", className: `h-full w-full gap-[0.125rem] bg-[var(--appkit-color-surface-muted)] ${collageTiles.length === 2 ? "grid-cols-2 grid-rows-1" : "grid-cols-2 grid-rows-2"}`, children: collageTiles.map((tile, i) => (_jsxs(Div, { className: "relative overflow-hidden bg-[var(--appkit-color-surface-muted)]", children: [_jsx(MediaImage, { src: tile.imageURL, alt: tile.title ?? `${bundle.name} item ${i + 1}`, size: "card" }), i === collageTiles.length - 1 && overflow > 0 && (_jsxs(Row, { textWeight: "semibold", textSize: "sm", surface: "overlay-md", className: "absolute inset-0 text-white", align: "center", justify: "center", children: ["+", overflow] }))] }, `${tile.productId}-${i}`))) })) : cover ? (_jsx(Div, { className: "absolute inset-0 bg-[var(--appkit-color-surface-muted)]", children: _jsx(MediaImage, { src: cover, alt: bundle.name, size: "card" }) })) : (_jsx(Row, { className: "absolute inset-0 bg-[var(--appkit-color-surface-muted)]", align: "center", justify: "center", children: _jsx(Text, { className: "text-[var(--appkit-color-text-muted)]", size: "xs", children: "No image" }) })) }), discount && (_jsx(PricesOnly, { children: _jsx(Span, { size: "xs", weight: "bold", className: "absolute left-2 top-2 bg-success-solid text-success-on-solid", rounded: "full", padding: "pill-xs", children: BUNDLE_COPY.detail.discountBadge(discount.percent) }) })), _jsxs(Stack, { className: "absolute right-2 top-2", align: "end", gap: "xs", children: [_jsx(Span, { size: "xs", weight: "medium", className: CLS_BUNDLE_PILL, children: mergedLabels.bundleBadge }), _jsx(Span, { layout: "inline-flex", color: "inverse", className: `${stock === "out_of_stock" ? "bg-neutral-500 " : CLS_STOCK_OK}`, rounded: "full", padding: "pill-xs", size: "xs", weight: "medium", children: stock === "out_of_stock" ? mergedLabels.outOfStockBadge : mergedLabels.inStockBadge })] }), stock === "out_of_stock" && (_jsx(Row, { surface: "overlay-xs", className: "absolute inset-0", align: "center", justify: "center", children: _jsx(Span, { color: "inverse", size: "xs", weight: "bold", className: "bg-neutral-900/80 tracking-wider", rounded: "default", padding: "pill-md", transform: "uppercase", children: mergedLabels.outOfStockBadge }) })), onSelect && (_jsx(BaseListingCard.Checkbox, { selected: isSelected, onSelect: (event) => {
                             event.stopPropagation();
                             onSelect(bundle.id, !isSelected);
                         }, className: selectable || isSelected

package/dist/features/seller/schemas/coupon-form.d.ts

@@ -15,9 +15,9 @@ import { z } from "zod";
 export declare const couponFormBase: z.ZodObject<{
     code: z.ZodString;
     type: z.ZodEnum<["percentage", "fixed", "free_shipping"]>;
-    value: z.ZodEffects<z.ZodString, string, string>;
+    value: z.ZodOptional<z.ZodEffects<z.ZodString, string, string>>;
     minPurchase: z.ZodEffects<z.ZodString, string, string>;
-    maxDiscount: z.ZodEffects<z.ZodString, string, string>;
+    maxDiscount: z.ZodOptional<z.ZodEffects<z.ZodString, string, string>>;
     totalLimit: z.ZodEffects<z.ZodString, string, string>;
     perUserLimit: z.ZodEffects<z.ZodString, string, string>;
     startDate: z.ZodString;
@@ -26,31 +26,31 @@ export declare const couponFormBase: z.ZodObject<{
     applicableProducts: z.ZodArray<z.ZodString, "many">;
     applicableCategories: z.ZodArray<z.ZodString, "many">;
 }, "strip", z.ZodTypeAny, {
-    value: string;
     code: string;
     type: "fixed" | "percentage" | "free_shipping";
     isActive: boolean;
     endDate: string;
-    maxDiscount: string;
     minPurchase: string;
     applicableProducts: string[];
     applicableCategories: string[];
     totalLimit: string;
     perUserLimit: string;
     startDate: string;
+    value?: string | undefined;
+    maxDiscount?: string | undefined;
 }, {
-    value: string;
     code: string;
     type: "fixed" | "percentage" | "free_shipping";
     isActive: boolean;
     endDate: string;
-    maxDiscount: string;
     minPurchase: string;
     applicableProducts: string[];
     applicableCategories: string[];
     totalLimit: string;
     perUserLimit: string;
     startDate: string;
+    value?: string | undefined;
+    maxDiscount?: string | undefined;
 }>;
 /**
  * The cross-field rules both editors need. Shared for the same reason the
@@ -59,7 +59,7 @@ export declare const couponFormBase: z.ZodObject<{
  */
 export declare function refineCouponCommon(v: {
     type: string;
-    value: string;
+    value?: string;
     startDate: string;
     endDate: string;
     totalLimit: string;
@@ -68,9 +68,9 @@ export declare function refineCouponCommon(v: {
 export declare const sellerCouponFormSchema: z.ZodEffects<z.ZodObject<{
     code: z.ZodString;
     type: z.ZodEnum<["percentage", "fixed", "free_shipping"]>;
-    value: z.ZodEffects<z.ZodString, string, string>;
+    value: z.ZodOptional<z.ZodEffects<z.ZodString, string, string>>;
     minPurchase: z.ZodEffects<z.ZodString, string, string>;
-    maxDiscount: z.ZodEffects<z.ZodString, string, string>;
+    maxDiscount: z.ZodOptional<z.ZodEffects<z.ZodString, string, string>>;
     totalLimit: z.ZodEffects<z.ZodString, string, string>;
     perUserLimit: z.ZodEffects<z.ZodString, string, string>;
     startDate: z.ZodString;
@@ -79,57 +79,57 @@ export declare const sellerCouponFormSchema: z.ZodEffects<z.ZodObject<{
     applicableProducts: z.ZodArray<z.ZodString, "many">;
     applicableCategories: z.ZodArray<z.ZodString, "many">;
 }, "strip", z.ZodTypeAny, {
-    value: string;
     code: string;
     type: "fixed" | "percentage" | "free_shipping";
     isActive: boolean;
     endDate: string;
-    maxDiscount: string;
     minPurchase: string;
     applicableProducts: string[];
     applicableCategories: string[];
     totalLimit: string;
     perUserLimit: string;
     startDate: string;
+    value?: string | undefined;
+    maxDiscount?: string | undefined;
 }, {
-    value: string;
     code: string;
     type: "fixed" | "percentage" | "free_shipping";
     isActive: boolean;
     endDate: string;
-    maxDiscount: string;
     minPurchase: string;
     applicableProducts: string[];
     applicableCategories: string[];
     totalLimit: string;
     perUserLimit: string;
     startDate: string;
+    value?: string | undefined;
+    maxDiscount?: string | undefined;
 }>, {
-    value: string;
     code: string;
     type: "fixed" | "percentage" | "free_shipping";
     isActive: boolean;
     endDate: string;
-    maxDiscount: string;
     minPurchase: string;
     applicableProducts: string[];
     applicableCategories: string[];
     totalLimit: string;
     perUserLimit: string;
     startDate: string;
+    value?: string | undefined;
+    maxDiscount?: string | undefined;
 }, {
-    value: string;
     code: string;
     type: "fixed" | "percentage" | "free_shipping";
     isActive: boolean;
     endDate: string;
-    maxDiscount: string;
     minPurchase: string;
     applicableProducts: string[];
     applicableCategories: string[];
     totalLimit: string;
     perUserLimit: string;
     startDate: string;
+    value?: string | undefined;
+    maxDiscount?: string | undefined;
 }>;
 export type SellerCouponFormValues = z.infer<typeof sellerCouponFormSchema>;
 /**
@@ -183,9 +183,9 @@ export declare function couponDraftToPayload(draft: SellerCouponFormValues): Sel
  */
 export declare const adminCouponFormSchema: z.ZodEffects<z.ZodObject<{
     code: z.ZodString;
-    value: z.ZodEffects<z.ZodString, string, string>;
+    value: z.ZodOptional<z.ZodEffects<z.ZodString, string, string>>;
     minPurchase: z.ZodEffects<z.ZodString, string, string>;
-    maxDiscount: z.ZodEffects<z.ZodString, string, string>;
+    maxDiscount: z.ZodOptional<z.ZodEffects<z.ZodString, string, string>>;
     totalLimit: z.ZodEffects<z.ZodString, string, string>;
     perUserLimit: z.ZodEffects<z.ZodString, string, string>;
     startDate: z.ZodString;
@@ -197,90 +197,90 @@ export declare const adminCouponFormSchema: z.ZodEffects<z.ZodObject<{
     type: z.ZodEnum<["percentage", "fixed", "free_shipping", "buy_x_get_y"]>;
     name: z.ZodString;
     description: z.ZodUnion<[z.ZodOptional<z.ZodString>, z.ZodLiteral<"">]>;
-    buyQuantity: z.ZodEffects<z.ZodString, string, string>;
-    getQuantity: z.ZodEffects<z.ZodString, string, string>;
+    buyQuantity: z.ZodOptional<z.ZodEffects<z.ZodString, string, string>>;
+    getQuantity: z.ZodOptional<z.ZodEffects<z.ZodString, string, string>>;
     currentUsage: z.ZodOptional<z.ZodNumber>;
     firstTimeUserOnly: z.ZodBoolean;
     appliesToAuctions: z.ZodBoolean;
 }, "strip", z.ZodTypeAny, {
-    value: string;
     code: string;
     type: "fixed" | "percentage" | "free_shipping" | "buy_x_get_y";
     name: string;
     isActive: boolean;
     endDate: string;
     firstTimeUserOnly: boolean;
-    maxDiscount: string;
     minPurchase: string;
-    buyQuantity: string;
-    getQuantity: string;
     applicableProducts: string[];
     applicableCategories: string[];
     totalLimit: string;
     perUserLimit: string;
     startDate: string;
     appliesToAuctions: boolean;
+    value?: string | undefined;
     description?: string | undefined;
     currentUsage?: number | undefined;
+    maxDiscount?: string | undefined;
+    buyQuantity?: string | undefined;
+    getQuantity?: string | undefined;
 }, {
-    value: string;
     code: string;
     type: "fixed" | "percentage" | "free_shipping" | "buy_x_get_y";
     name: string;
     isActive: boolean;
     endDate: string;
     firstTimeUserOnly: boolean;
-    maxDiscount: string;
     minPurchase: string;
-    buyQuantity: string;
-    getQuantity: string;
     applicableProducts: string[];
     applicableCategories: string[];
     totalLimit: string;
     perUserLimit: string;
     startDate: string;
     appliesToAuctions: boolean;
+    value?: string | undefined;
     description?: string | undefined;
     currentUsage?: number | undefined;
+    maxDiscount?: string | undefined;
+    buyQuantity?: string | undefined;
+    getQuantity?: string | undefined;
 }>, {
-    value: string;
     code: string;
     type: "fixed" | "percentage" | "free_shipping" | "buy_x_get_y";
     name: string;
     isActive: boolean;
     endDate: string;
     firstTimeUserOnly: boolean;
-    maxDiscount: string;
     minPurchase: string;
-    buyQuantity: string;
-    getQuantity: string;
     applicableProducts: string[];
     applicableCategories: string[];
     totalLimit: string;
     perUserLimit: string;
     startDate: string;
     appliesToAuctions: boolean;
+    value?: string | undefined;
     description?: string | undefined;
     currentUsage?: number | undefined;
+    maxDiscount?: string | undefined;
+    buyQuantity?: string | undefined;
+    getQuantity?: string | undefined;
 }, {
-    value: string;
     code: string;
     type: "fixed" | "percentage" | "free_shipping" | "buy_x_get_y";
     name: string;
     isActive: boolean;
     endDate: string;
     firstTimeUserOnly: boolean;
-    maxDiscount: string;
     minPurchase: string;
-    buyQuantity: string;
-    getQuantity: string;
     applicableProducts: string[];
     applicableCategories: string[];
     totalLimit: string;
     perUserLimit: string;
     startDate: string;
     appliesToAuctions: boolean;
+    value?: string | undefined;
     description?: string | undefined;
     currentUsage?: number | undefined;
+    maxDiscount?: string | undefined;
+    buyQuantity?: string | undefined;
+    getQuantity?: string | undefined;
 }>;
 export type AdminCouponFormValues = z.infer<typeof adminCouponFormSchema>;

package/dist/features/seller/schemas/coupon-form.js

@@ -70,7 +70,10 @@ export const couponFormBase = z
      * `when` carries what the editor held as JSX conditionals, so a field the
      * form hides is one the payload cannot carry — see `couponDraftToPayload`.
      */
-    value: annotate(numericString("The discount value"), {
+    // Optional for the same reason as buyQuantity/getQuantity below: this field
+    // is `when`-gated, so visibleValues() strips it on a free-shipping coupon.
+    // refineCouponCommon still requires it for every other type.
+    value: annotate(numericString("The discount value").optional(), {
         section: "basics", quick: true, order: 3, row: "pair",
         when: (v) => v.type !== "free_shipping",
     }),
@@ -83,7 +86,9 @@ export const couponFormBase = z
      * cap typed while the type was "percentage" persisted after switching to
      * free shipping, invisibly.
      */
-    maxDiscount: annotate(numericString("Maximum discount"), {
+    // `when`-gated to percentage only, so it is stripped for fixed and
+    // free-shipping coupons — optional, or those two types cannot be saved.
+    maxDiscount: annotate(numericString("Maximum discount").optional(), {
         section: "limits", order: 2, row: "pair",
         when: (v) => v.type === "percentage",
     }),
@@ -121,8 +126,9 @@ export function refineCouponCommon(v, ctx) {
         // a percentage above 100 is not a discount — it is the store paying the
         // customer. Nothing bounded this before.
         if (v.type !== "free_shipping") {
-            const amount = Number(v.value);
-            if (v.value.trim() === "")
+            const rawValue = v.value ?? "";
+            const amount = Number(rawValue);
+            if (rawValue.trim() === "")
                 issue("value", "A discount value is required.");
             else if (amount <= 0)
                 issue("value", "The discount must be greater than zero.");
@@ -205,11 +211,28 @@ export const adminCouponFormSchema = couponFormBase
     description: annotate(z.string().max(500).optional().or(z.literal("")), {
         section: "basics", order: 5, row: "full", kind: "textarea",
     }),
-    buyQuantity: annotate(numericString("Buy quantity"), {
+    /*
+     * 🛑 A `when`-gated field MUST be optional, or the form cannot be submitted
+     * at all while the condition is false.
+     *
+     * `visibleValues()` strips every field whose `when` is false before the
+     * submit path parses the draft — that is its whole job, so a hidden input
+     * cannot smuggle a stale value into the payload. But a stripped key is
+     * `undefined` to Zod, and these were required strings, so editing any
+     * ordinary percentage coupon produced exactly two "This field is required"
+     * issues for the two buy-x-get-y inputs that are not on screen. The summary
+     * rendered them as "Coupon: This field is required" twice, naming the
+     * section rather than any field, and no PATCH was ever issued.
+     *
+     * Optional here is not a loosening: the superRefine below still demands a
+     * whole number of one or more whenever the type IS buy_x_get_y, which is
+     * the only time either field is real.
+     */
+    buyQuantity: annotate(numericString("Buy quantity").optional(), {
         section: "basics", order: 6, row: "pair", kind: "number",
         when: (v) => v.type === "buy_x_get_y",
     }),
-    getQuantity: annotate(numericString("Get quantity"), {
+    getQuantity: annotate(numericString("Get quantity").optional(), {
         section: "basics", order: 7, row: "pair", kind: "number",
         when: (v) => v.type === "buy_x_get_y",
     }),
@@ -235,8 +258,13 @@ export const adminCouponFormSchema = couponFormBase
     // A buy-x-get-y with a zero on either side is not an offer.
     if (v.type === "buy_x_get_y") {
         for (const key of ["buyQuantity", "getQuantity"]) {
-            const n = Number(v[key]);
-            if (v[key].trim() === "" || !Number.isFinite(n) || n < 1) {
+            // `?? ""` because the field is optional now — see the note on its
+            // declaration. When the type IS buy_x_get_y the input is on screen, so
+            // an absent value here means the admin left it blank, which this
+            // rejects exactly as it did before.
+            const raw = v[key] ?? "";
+            const n = Number(raw);
+            if (raw.trim() === "" || !Number.isFinite(n) || n < 1) {
                 ctx.addIssue({
                     code: z.ZodIssueCode.custom,
                     path: [key],

package/dist/schemas/registry.d.ts

@@ -4755,9 +4755,9 @@ export declare const SCHEMAS: {
         readonly sellerCoupon: import("zod").ZodEffects<import("zod").ZodObject<{
             code: import("zod").ZodString;
             type: import("zod").ZodEnum<["percentage", "fixed", "free_shipping"]>;
-            value: import("zod").ZodEffects<import("zod").ZodString, string, string>;
+            value: import("zod").ZodOptional<import("zod").ZodEffects<import("zod").ZodString, string, string>>;
             minPurchase: import("zod").ZodEffects<import("zod").ZodString, string, string>;
-            maxDiscount: import("zod").ZodEffects<import("zod").ZodString, string, string>;
+            maxDiscount: import("zod").ZodOptional<import("zod").ZodEffects<import("zod").ZodString, string, string>>;
             totalLimit: import("zod").ZodEffects<import("zod").ZodString, string, string>;
             perUserLimit: import("zod").ZodEffects<import("zod").ZodString, string, string>;
             startDate: import("zod").ZodString;
@@ -4766,57 +4766,57 @@ export declare const SCHEMAS: {
             applicableProducts: import("zod").ZodArray<import("zod").ZodString, "many">;
             applicableCategories: import("zod").ZodArray<import("zod").ZodString, "many">;
         }, "strip", import("zod").ZodTypeAny, {
-            value: string;
             code: string;
             type: "fixed" | "percentage" | "free_shipping";
             isActive: boolean;
             endDate: string;
-            maxDiscount: string;
             minPurchase: string;
             applicableProducts: string[];
             applicableCategories: string[];
             totalLimit: string;
             perUserLimit: string;
             startDate: string;
+            value?: string | undefined;
+            maxDiscount?: string | undefined;
         }, {
-            value: string;
             code: string;
             type: "fixed" | "percentage" | "free_shipping";
             isActive: boolean;
             endDate: string;
-            maxDiscount: string;
             minPurchase: string;
             applicableProducts: string[];
             applicableCategories: string[];
             totalLimit: string;
             perUserLimit: string;
             startDate: string;
+            value?: string | undefined;
+            maxDiscount?: string | undefined;
         }>, {
-            value: string;
             code: string;
             type: "fixed" | "percentage" | "free_shipping";
             isActive: boolean;
             endDate: string;
-            maxDiscount: string;
             minPurchase: string;
             applicableProducts: string[];
             applicableCategories: string[];
             totalLimit: string;
             perUserLimit: string;
             startDate: string;
+            value?: string | undefined;
+            maxDiscount?: string | undefined;
         }, {
-            value: string;
             code: string;
             type: "fixed" | "percentage" | "free_shipping";
             isActive: boolean;
             endDate: string;
-            maxDiscount: string;
             minPurchase: string;
             applicableProducts: string[];
             applicableCategories: string[];
             totalLimit: string;
             perUserLimit: string;
             startDate: string;
+            value?: string | undefined;
+            maxDiscount?: string | undefined;
         }>;
         readonly customRole: import("zod").ZodObject<{
             name: import("zod").ZodString;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mohasinac/appkit",
-  "version": "4.41.1",
+  "version": "4.41.3",
   "license": "MIT",
   "publishConfig": {
     "access": "public"