@mohasinac/appkit 4.37.1 → 4.39.0

package/dist/features/stores/api/[storeSlug]/reviews/route.js

@@ -7,15 +7,27 @@
  * export { storeReviewsGET as GET } from "@mohasinac/feat-stores";
  * ```
  *
- * Aggregates approved reviews from up to 20 published products in a store.
+ * Aggregates every approved review filed against a store, by `storeId`.
  * Returns: reviews[], averageRating, totalReviews, ratingDistribution.
  *
+ * It used to aggregate "up to 20 published products by itemsSold" and fan out a
+ * review query per product — and since no product carries `itemsSold`, that
+ * `orderBy` matched nothing and the endpoint returned zero reviews for every
+ * store. See the block comment at the query for the full account.
+ *
  * Requires `db` registered in providers.config via `registerProviders()`.
  * Collections: "stores", "products", "reviews"
  */
 import { NextResponse } from "next/server.js";
 import { getProviders } from "../../../../../contracts";
 import { normalizeError } from "../../../../../errors/normalize";
+/**
+ * Upper bound on the reviews scanned to build a store's aggregate. The average
+ * rating and the distribution are computed over this window, so it must be
+ * generous — but it is still a bound, because the alternative is an unbounded
+ * read on a public, cacheable endpoint (Rule #6).
+ */
+const STORE_REVIEW_SCAN_CAP = 500;
 // --- GET /api/stores/[storeSlug]/reviews --------------------------------------
 export async function GET(request, context) {
     try {
@@ -44,40 +56,53 @@ export async function GET(request, context) {
         if (!store) {
             return NextResponse.json({ success: false, error: "Store not found" }, { status: 404 });
         }
-        // Fetch up to 20 published products for this seller
-        const productsRepo = db.getRepository("products");
-        const productsResult = await productsRepo.findAll({
-            filters: `storeId==${store.id},status==published`,
-            sort: "itemsSold",
-            order: "desc",
-            perPage: 20,
-        });
-        const products = productsResult.data;
-        // Fetch approved reviews for each product in parallel (cap 50 per product)
+        /*
+         * 🛑 REVIEWS ARE FETCHED BY `storeId`, IN ONE QUERY. Do not route this back
+         * through products.
+         *
+         * It used to select "the store's top 20 products by `itemsSold`" and then
+         * fan out one review query per product. Two independent defects, and the
+         * second hid the first:
+         *
+         *  - **`orderBy("itemsSold")` silently drops every document that lacks the
+         *    field**, exactly like the documented `!=` trap. Measured on production
+         *    2026-09-14: **0 of 95 products carry `itemsSold`**, so that query
+         *    returned an empty array — and therefore so did the whole endpoint.
+         *    Every store's reviews tab had been empty since it shipped, answering
+         *    HTTP 200 with `totalReviews: 0` while 79 approved reviews sat in
+         *    Firestore. Nothing errored; there was no symptom to report beyond "this
+         *    store has no reviews yet", which reads as a fact about the store.
+         *  - Even populated, a 20-product window is a SAMPLE, not the store: 14
+         *    distinct products carry reviews here and the store has 65 listings, so
+         *    an arbitrary slice would under-report the average rating and the
+         *    distribution — the two numbers buyers actually judge a seller by.
+         *
+         * `ReviewDocument` carries `storeId` (74/79 here belong to this store), so
+         * the store's reviews are one equality away. This also turns 21 Firestore
+         * queries into 1, well inside Rule #6's ~3-round-trip budget.
+         */
         const reviewsRepo = db.getRepository("reviews");
-        const reviewArrays = await Promise.all(products.map((p) => reviewsRepo
-            .findAll({
-            filters: `productId==${p.id},status==approved`,
+        const reviewsResult = await reviewsRepo.findAll({
+            filters: `storeId==${store.id},status==approved`,
             sort: "createdAt",
             order: "desc",
-            perPage: 50,
-        })
-            .then((r) => r.data)));
+            perPage: STORE_REVIEW_SCAN_CAP,
+        });
+        const allFlat = reviewsResult.data;
         // Compute aggregate metrics from ALL reviews (unfiltered)
         const ratingDistribution = { 1: 0, 2: 0, 3: 0, 4: 0, 5: 0 };
         let ratingSum = 0;
         let totalReviews = 0;
-        for (const reviews of reviewArrays) {
-            for (const review of reviews) {
-                totalReviews++;
-                ratingSum += review.rating;
-                ratingDistribution[review.rating] = (ratingDistribution[review.rating] ?? 0) + 1;
-            }
+        for (const review of allFlat) {
+            totalReviews++;
+            ratingSum += review.rating;
+            ratingDistribution[review.rating] = (ratingDistribution[review.rating] ?? 0) + 1;
         }
         const averageRating = totalReviews > 0 ? ratingSum / totalReviews : 0;
-        // Flatten all reviews
-        const productMap = new Map(products.map((p) => [p.id, p]));
-        const allFlat = reviewArrays.flat();
+        // Titles and images are enriched further down, from only the products the
+        // reviews on the CURRENT PAGE name. Every review already carries a
+        // denormalised `productTitle`, so a miss still renders a usable card.
+        const productsRepo = db.getRepository("products");
         // Apply sort
         const sorted = [...allFlat].sort((a, b) => {
             if (sort === "createdAt" || sort === "+createdAt") {
@@ -99,10 +124,20 @@ export async function GET(request, context) {
         // Apply search
         if (q) {
             filtered = filtered.filter((r) => {
-                const title = (r.title ?? "").toLowerCase();
-                const body = (r.body ?? "").toLowerCase();
+                const rv = r;
+                const title = (rv.title ?? "").toLowerCase();
+                /*
+                 * `comment` FIRST. The stored field is `comment` — verified against all
+                 * 79 production review documents, none of which has a `body`. This read
+                 * `body` alone, so searching a store's reviews only ever matched the
+                 * title or the product name, never a word the reviewer actually wrote.
+                 * `body` is kept as a fallback because it is what CLAUDE.md's reviews
+                 * row and several types call it; the two spellings have drifted and only
+                 * the data settles which is real.
+                 */
+                const text = (rv.comment ?? rv.body ?? "").toLowerCase();
                 const pt = (r.productTitle ?? "").toLowerCase();
-                return title.includes(q) || body.includes(q) || pt.includes(q);
+                return title.includes(q) || text.includes(q) || pt.includes(q);
             });
         }
         // Apply date range
@@ -124,7 +159,31 @@ export async function GET(request, context) {
         const totalFiltered = filtered.length;
         const totalPages = Math.max(1, Math.ceil(totalFiltered / pageSize));
         const pageSlice = filtered.slice((page - 1) * pageSize, page * pageSize);
-        // Enrich with product title + main image
+        // Enrich with product title + main image — only the ids on this page.
+        const pageProductIds = [...new Set(pageSlice.map((r) => r.productId).filter(Boolean))];
+        /*
+         * 🛑 DOCUMENT GETS, not a filter. The generic `findAll` on this provider
+         * parses a clause as `.where(field, op, coerceValue(value))` and has no
+         * pipe-join OR handling — so `id==a|b|c` would query for the LITERAL string
+         * "a|b|c" and match nothing, silently, which is the exact defect class this
+         * whole route is being fixed for. (Pipe-joins are a `sieveQuery` feature;
+         * this repository is not that path.) `id` is also not a stored field.
+         *
+         * Bounded by `pageSize`, capped at 50 above and typically ~12.
+         */
+        const productMap = new Map();
+        const fetched = await Promise.all(pageProductIds.map((id) => productsRepo.findById(id).catch((err) => {
+            // Named and logged, not swallowed: enrichment is genuinely optional
+            // (every review carries a denormalised productTitle), but a silent
+            // null here is indistinguishable from "that product was deleted" —
+            // Root Cause #59's shape, which is what this whole route was fixed for.
+            void normalizeError(err);
+            console.warn(`[feat-stores] products.findById failed for ${id}`);
+            return null;
+        })));
+        for (const p of fetched)
+            if (p)
+                productMap.set(p.id, p);
         const reviewsWithProduct = pageSlice.map((review) => ({
             ...review,
             productTitle: productMap.get(review.productId)?.title ?? review.productTitle,

package/dist/features/stores/components/StoresIndexPageView.js

@@ -13,7 +13,23 @@ export async function StoresIndexPageView({ searchParams = {} }) {
     const sort = sp(searchParams, "sort") || "-createdAt";
     const page = Number(sp(searchParams, "page")) || 1;
     const pageSize = Number(sp(searchParams, "pageSize")) || 24;
-    const result = await safeRead(() => storeRepository.listStores({ page, pageSize, sorts: sort }, true), { route: "/stores", key: "stores.listStores", fallback: null });
+    /*
+     * 🛑 `q` MUST be read here, and passed as the third argument exactly as
+     * /api/stores does — `listStores(model, true, { search })`.
+     *
+     * It was not, so /stores?q=anything rendered the FULL store list: measured
+     * live, `?q=zzzznope` returned two real store cards and no empty state. The
+     * search box looked like it worked because a real term also returns rows —
+     * only a nonsense term exposes a filter that is not filtering.
+     *
+     * And it could not self-correct on the client: this result is handed to
+     * <StoresIndexListing initialData=...>, and every public listing hook sets
+     * `staleTime: Infinity` when given SSR data, so the unfiltered first paint is
+     * frozen for that query key. Root Cause #30 — the SSR builder has to compute
+     * the same filters the client would, because it never gets a second chance.
+     */
+    const q = sp(searchParams, "q").trim();
+    const result = await safeRead(() => storeRepository.listStores({ page, pageSize, sorts: sort }, true, q ? { search: q } : undefined), { route: "/stores", key: "stores.listStores", fallback: null });
     /*
      * The API already filters this; the SSR page called the repository directly
      * and did not, so the first paint rendered a card for `store-tester-sandbox`

package/dist/features/tester/seed-data/authored/admin__users-trust.js

@@ -213,7 +213,7 @@ export const authored = {
     },
     "checklist-admin-users-trust-support-tickets-triage-admin": {
         roles: ["admin"],
-        startPage: "/admin/support",
+        startPage: "/admin/support-tickets",
         steps: [
             "Sign in as admin@letitrip.in / TempPass123!.",
             "Open the admin support tickets surface and read every column.",

package/dist/features/tester/seed-data/authored/buying__bidding.js

@@ -130,9 +130,10 @@ export const authored = {
         endResult: "After reload the same rows appear in the same order. An empty list here immediately after placing a bid means the bid was written without a buyer reference.",
     },
     "checklist-buying-bidding-bid-history-auction-detail-pagination": {
-        roles: ["guest"],
+        roles: ["buyer"],
         startPage: "/auctions/auction-beyblade-metal-lightning-l-drago",
         steps: [
+            "Sign in as a buyer — bid amounts are hidden from signed-out visitors, so this case cannot read them as a guest.",
             "Open /auctions/auction-beyblade-metal-lightning-l-drago.",
             "Click the 'Bid History' control to expand it.",
             "Read the amounts on the first page, top to bottom.",
@@ -350,16 +351,16 @@ export const authored = {
         endResult: "Reloading the auction still shows ₹15,000.00 and 1 bid, and the row is still on /user/bids.",
     },
     "checklist-buying-bidding-place-bid-live-other-viewer": {
-        roles: ["buyer", "guest"],
+        roles: ["buyer"],
         startPage: "/auctions/auction-tester-sandbox-cycle-2",
         steps: [
             "In window A, sign in as rehan.sheikh@gmail.com / TempPass123! and open /auctions/auction-tester-sandbox-cycle-2.",
-            "In window B, open the same auction signed out, and read the current bid and bid count.",
+            "In window B, sign in as a DIFFERENT buyer (vivaan.kapoor@gmail.com / TempPass123!) and open the same auction; read the current bid and bid count.",
             "In window A, click 'Place a bid', select the 'Minimum' preset at ₹15,000.00, and click 'Place Bid'.",
             "Switch to window B and watch for up to 10 seconds without reloading.",
         ],
         inputs: { bidAmount: 15000 },
-        expectedBehaviour: "Bid updates are relayed over SSE from the server, which is why a signed-out viewer sees them at all — the underlying realtime node is not client-readable, so the browser never reads it directly.",
+        expectedBehaviour: "Bid updates are relayed over SSE from the server — the underlying realtime node is not client-readable, so the browser never reads it directly. Window B is a SECOND SIGNED-IN BUYER, not a signed-out visitor: bid figures are now hidden from guests, so a signed-out window B would show 'Sign in to see the current bid' before and after and could never demonstrate the stream at all.",
         expectedUiState: "Window B moves to 'Current bid ₹15,000.00' and '1 bid' within about 10 seconds, with no reload and no interaction. Figures that only change on refresh mean the stream is not connected.",
         expectedData: { currentBid: 15000, bidCount: 1 },
         endResult: "Reloading window B shows the same figures it had already updated to.",

package/dist/features/tester/seed-data/authored/buying__browsing-search.js

@@ -58,25 +58,26 @@ export const authored = {
     },
     "checklist-buying-browsing-search-auctions-show-ended-off-shows-live": {
         roles: ["guest"],
-        startPage: "/products",
+        startPage: "/auctions",
         steps: [
-            "Open /products.",
-            "Click 'Filters', tick only 'Auctions', click 'Apply'.",
+            "Open /auctions.",
+            "Read the availability tab bar and the grid.",
         ],
-        expectedBehaviour: "Live auctions appear on the Available tab without the 'Ended' toggle being turned on. The page is not empty.",
-        expectedUiState: "At least one auction card marked 'Live' is visible (e.g. 'Beyblade Burst B-100 Cho-Z Achilles' or 'Metal Fight Beyblade BB-99 Lightning L-Drago'). The grid is not empty and no error toast appears.",
+        expectedBehaviour: "Live auctions appear on the Available tab, which is selected on arrival. The page is not empty. This case used to start on /products with the Auctions chip ticked; auctions now live only on their own page.",
+        expectedUiState: "At least one live auction card is visible (e.g. 'Beyblade Burst B-100 Cho-Z Achilles' or 'Metal Fight Beyblade BB-99 Lightning L-Drago'). The middle tab reads 'Ended' and is NOT selected. The grid is not empty and no error toast appears.",
         endResult: "Nothing is persisted.",
     },
     "checklist-buying-browsing-search-auctions-show-ended-with-nondefault-sort": {
-        roles: ["guest"],
-        startPage: "/products",
+        roles: ["buyer"],
+        startPage: "/auctions",
         steps: [
-            "Open /products.",
-            "Click 'Filters', tick only 'Auctions', click 'Apply'.",
+            "Sign in as a buyer.",
+            "Open /auctions.",
             "Open the 'Sort by' dropdown and select 'Highest Current Bid'.",
+            "Read the order of the current-bid figures on the cards.",
         ],
-        expectedBehaviour: "Sorting by 'Highest Current Bid' while 'Show ended' is off still returns only live auctions, sorted correctly by current bid descending. The grid is not empty.",
-        expectedUiState: "The grid shows live auction cards sorted from highest current bid to lowest. No ended auction cards are visible. No 'No products found' message appears.",
+        expectedBehaviour: "Sorting by 'Highest Current Bid' on the Available tab still returns only live auctions, ordered by current bid descending, and the grid is not empty. The role is BUYER, not guest: 'Highest Current Bid' is a money sort and is not offered to signed-out visitors, because ordering by bid ranks every hidden amount on the page.",
+        expectedUiState: "The grid shows live auction cards whose current-bid figures descend from top-left to bottom-right. No ended auction cards are visible. No 'No products found' message appears.",
         endResult: "Nothing is persisted.",
     },
     "checklist-buying-browsing-search-browse-categories": {
@@ -146,9 +147,10 @@ export const authored = {
         endResult: "Nothing is persisted.",
     },
     "checklist-buying-browsing-search-filter-drawer-combines-correctly": {
-        roles: ["guest"],
+        roles: ["buyer"],
         startPage: "/products",
         steps: [
+            "Sign in as a buyer — the Price Range facet is hidden from signed-out visitors.",
             "Open /products.",
             "Note the initial result count.",
             "Click 'Filters'.",
@@ -199,9 +201,10 @@ export const authored = {
         endResult: "The Left-hand mode preference persists in the user's profile across sessions.",
     },
     "checklist-buying-browsing-search-filters": {
-        roles: ["guest"],
+        roles: ["buyer"],
         startPage: "/products",
         steps: [
+            "Sign in as a buyer — the Price Range facet is hidden from signed-out visitors.",
             "Open /products.",
             "Note the result count shown in pagination.",
             "Click 'Filters'.",
@@ -369,19 +372,22 @@ export const authored = {
         expectedUiState: "After clicking Page 2: the pagination bar highlights Page 2 and the URL contains 'page=2'. After Next: the next page loads with different cards. After Previous: the previous page loads. No page shows 'No products found' unless the total results genuinely fit on one page.",
         endResult: "Nothing is persisted to the server. The page parameter is URL state.",
     },
-    "checklist-buying-browsing-search-pre-orders-reachable-from-products": {
+    "checklist-buying-browsing-search-every-listing-type-reachable-from-nav-or-products": {
         roles: ["guest"],
         startPage: "/products",
         steps: [
-            "Open /products.",
-            "Click 'Filters'.",
-            "Tick 'Pre-Orders' under Listing type.",
-            "Click 'Apply'.",
-            "Scan the grid cards for type badges.",
+            "Open /products and read the main navigation bar.",
+            "Click 'Auctions' in the nav and confirm at least one auction card is shown.",
+            "Click 'Pre-Orders' in the nav and confirm at least one pre-order card is shown.",
+            "Click 'Prize Draws' in the nav and confirm at least one prize-draw card is shown.",
+            "Click 'Art & Stickers' in the nav and confirm at least one art or sticker card is shown.",
+            "Return to /products, click 'Filters', tick 'Classifieds', click 'Apply', and read the grid.",
+            "Click 'Filters', untick 'Classifieds', tick 'Digital Codes', click 'Apply', and read the grid.",
+            "Click 'Filters', untick 'Digital Codes', tick 'Live Items', click 'Apply', and read the grid.",
         ],
-        expectedBehaviour: "The grid is filtered to show only pre-order items. At least one pre-order card with a 'Pre-Order' badge is visible.",
-        expectedUiState: "Every visible card shows a 'Pre-Order' badge. At least one card is shown — e.g. 'Beyblade X BX-08 Booster — Next Wave'. No card shows a type badge other than 'Pre-Order'.",
-        endResult: "Nothing is persisted to the server.",
+        expectedBehaviour: "All nine listing types are reachable without typing a URL. Five reach their own page from the main nav; the remaining four — Standard, Classifieds, Digital Codes, Live Items — are reached through the /products Listing type filter, because they have no nav entry of their own.",
+        expectedUiState: "Each nav click lands on the matching page with at least one real card: /auctions, /pre-orders, /prize-draws, /art. Each /products filter selection narrows the grid to that type with at least one card and no 'No products found' state — Classifieds shows 'Classified' badges, Digital Codes shows 'Digital Code' badges, Live Items shows 'Live Item' badges.",
+        endResult: "Nothing is persisted to the server. A type that can be reached from neither the nav nor the /products filter is the regression this case exists for.",
     },
     "checklist-buying-browsing-search-product-filter-status-labels": {
         roles: ["admin"],
@@ -403,48 +409,45 @@ export const authored = {
         steps: [
             "Open /products.",
             "Click 'Filters'.",
-            "Tick only 'Auctions' under Listing type.",
+            "Tick only 'Classifieds' under Listing type.",
             "Read the contents of the drawer below the Listing type checkboxes, without pressing Apply.",
-            "Click the 'Full Auctions filters →' link.",
+            "Click the 'Full Classifieds filters →' link.",
             "Navigate back to /products.",
-            "Click 'Filters', untick 'Auctions', tick only 'Pre-Orders', and read for a similar link.",
+            "Click 'Filters', untick 'Classifieds', tick only 'Digital Codes', and read for a similar link.",
             "Navigate back to /products.",
-            "Click 'Filters', tick 'Auctions' and 'Pre-Orders' both, and read for a link.",
+            "Click 'Filters', tick 'Classifieds' and 'Digital Codes' both, and read for a link.",
             "Navigate back to /products.",
             "Click 'Filters', untick all, and read for a link.",
+            "Click 'Filters', tick only 'Standard', and read for a link.",
         ],
-        expectedBehaviour: "When exactly one type that has its own browse page is ticked, a 'Full <type> filters →' link appears in the drawer below the Listing type section (before pressing Apply). The link navigates to that type's dedicated page. With two types ticked or none ticked, the link does not appear.",
-        expectedUiState: "Auctions only: 'Full Auctions filters →' link is visible; clicking it lands on /auctions. Pre-Orders only: 'Full Pre-Orders filters →' link is visible. Both ticked: no link visible. None ticked: no link visible.",
+        expectedBehaviour: "When exactly one type that has its own browse page is ticked, a 'Full <type> filters →' link appears in the drawer below the Listing type section (before pressing Apply). The link navigates to that type's dedicated page, which carries facets this generic page cannot. With two types ticked or none ticked, no link appears. Standard is the exception: its 'dedicated page' IS /products, so offering a link would point the page at itself.",
+        expectedUiState: "Classifieds only: 'Full Classifieds filters →' link is visible; clicking it lands on /classified. Digital Codes only: 'Full Digital Codes filters →' link is visible. Both ticked: no link visible. None ticked: no link visible. Standard only: NO link is visible — in particular no 'Full Products filters →' link pointing back at /products.",
         endResult: "Nothing is persisted to the server.",
     },
     "checklist-buying-browsing-search-product-type-chip-drives-sort-options": {
         roles: ["guest"],
         startPage: "/products",
         steps: [
-            "Open /products.",
-            "Click 'Filters', tick only 'Auctions', click 'Apply'.",
-            "Open the 'Sort by' dropdown and read the available options.",
-            "Click 'Filters', untick 'Auctions', tick only 'Pre-Orders', click 'Apply'.",
-            "Open the 'Sort by' dropdown and read the available options.",
-            "Click 'Filters', tick 'Auctions' as well (both Auctions and Pre-Orders now ticked), click 'Apply'.",
-            "Open the 'Sort by' dropdown and read the available options.",
-        ],
-        expectedBehaviour: "With only Auctions selected, 'Ending Soon' appears in Sort. With only Pre-Orders, 'Earliest Delivery' appears. With both selected, only shared sorts (Newest, Price, Name) remain — 'Ending Soon' and 'Earliest Delivery' are both absent.",
-        expectedUiState: "Auctions only: Sort dropdown includes 'Ending Soon'. Pre-Orders only: Sort dropdown includes 'Earliest Delivery'; 'Ending Soon' is absent. Both: Sort dropdown contains only generic options like 'Newest First', 'Price low to high', 'Price high to low'.",
+            "Sign in as a buyer (price sorts are hidden from signed-out visitors).",
+            "Open /auctions and open the 'Sort by' dropdown; read the available options.",
+            "Open /pre-orders and open the 'Sort by' dropdown; read the available options.",
+            "Open /products and open the 'Sort by' dropdown; read the available options.",
+        ],
+        expectedBehaviour: "Each listing type offers the sorts that make sense for it, and only those. An auction sorts by how soon it ends; a pre-order by when it is delivered; the general catalogue by neither, because neither field means anything for a standard product. This used to be exercised by ticking Auctions and Pre-Orders on /products; those types now live only on their own pages, so the contrast is read across pages instead.",
+        expectedUiState: "/auctions: the Sort dropdown includes 'Ending Soon'. /pre-orders: it includes 'Earliest Delivery' and does NOT include 'Ending Soon'. /products: it includes neither 'Ending Soon' nor 'Earliest Delivery', offering generic options such as 'Newest First' and the two price sorts.",
         endResult: "Nothing is persisted to the server.",
     },
     "checklist-buying-browsing-search-product-type-chip-sort-resets-no-empty-page": {
         roles: ["guest"],
         startPage: "/products",
         steps: [
-            "Open /products.",
-            "Click 'Filters', tick only 'Auctions', click 'Apply'.",
-            "Open the 'Sort by' dropdown and select 'Ending Soon'.",
-            "Click 'Filters', untick 'Auctions', tick 'Standard', click 'Apply'.",
-            "Open the 'Sort by' dropdown and read the selected option.",
+            "Open /products?sort=auctionEndDate:asc directly in the address bar — an auction-only sort that the general catalogue cannot satisfy.",
+            "Read the 'Sort by' dropdown and the grid.",
+            "Open /products?listingType=auction directly in the address bar.",
+            "Read the URL the browser settles on and the page heading.",
         ],
-        expectedBehaviour: "Switching from the Auctions-only selection to Standard resets the sort to a generic option (Newest First). The grid repopulates with Standard products and is not empty.",
-        expectedUiState: "After switching to Standard: the Sort dropdown reads 'Newest First' (or another generic sort, not 'Ending Soon'). The grid shows Standard product cards. No 'No products found' state and no error is shown.",
+        expectedBehaviour: "A sort or a listing type that /products does not offer must degrade visibly, never silently. An unsupported sort falls back to the default rather than running a query Firestore rejects, which would surface as a bare empty grid with no error. A URL naming only out-of-catalogue types redirects to the page that owns them, rather than quietly showing the whole general catalogue as though the filter had been honoured.",
+        expectedUiState: "First URL: the Sort dropdown reads 'Newest First', the grid shows product cards, and there is no 'No products found' state and no error. Second URL: the browser lands on /auctions and the page heading reads Auctions — it does NOT stay on /products showing unfiltered results.",
         endResult: "Nothing is persisted to the server.",
     },
     "checklist-buying-browsing-search-product-type-chips-cover-all-types": {
@@ -456,8 +459,8 @@ export const authored = {
             "Count every checkbox under the 'Listing type' heading.",
             "Read each checkbox label.",
         ],
-        expectedBehaviour: "Exactly nine listing-type checkboxes are present. All nine are: Standard, Auctions, Pre-Orders, Prize Draws, Classifieds, Digital Codes, Live Items, Art, Stickers. No checkbox labelled 'Bundles' is present.",
-        expectedUiState: "The Listing type section shows nine checkboxes: Standard, Auctions, Pre-Orders, Prize Draws, Classifieds, Digital Codes, Live Items, Art, Stickers. No 'Bundles' checkbox is present.",
+        expectedBehaviour: "Exactly four listing-type checkboxes are present: Standard, Classifieds, Digital Codes, Live Items. Those are the four types with no dedicated entry in the main nav, so /products is their only discovery path. Auctions, Pre-Orders, Prize Draws, Art and Stickers are NOT offered here — each owns a dedicated page reachable from the main nav. No checkbox labelled 'Bundles' is present; a bundle is a category, not a listing type.",
+        expectedUiState: "BEFORE: nine checkboxes, including Auctions, Pre-Orders, Prize Draws, Art and Stickers. AFTER: the Listing type section shows exactly four — Standard, Classifieds, Digital Codes, Live Items. No 'Auctions', 'Pre-Orders', 'Prize Draws', 'Art', 'Stickers' or 'Bundles' checkbox is present.",
         endResult: "Nothing is persisted.",
     },
     "checklist-buying-browsing-search-product-type-chips-multi-select": {
@@ -466,17 +469,17 @@ export const authored = {
         steps: [
             "Open /products.",
             "Click 'Filters'.",
-            "Tick 'Auctions'.",
-            "Tick 'Pre-Orders' without unticking 'Auctions'.",
+            "Tick 'Classifieds'.",
+            "Tick 'Digital Codes' without unticking 'Classifieds'.",
             "Click 'Apply'.",
             "Click 'Filters' again to reopen the drawer.",
             "Read which boxes are ticked.",
             "Click 'Close'.",
-            "Untick both 'Auctions' and 'Pre-Orders' in the drawer.",
+            "Untick both 'Classifieds' and 'Digital Codes' in the drawer.",
             "Click 'Apply'.",
         ],
-        expectedBehaviour: "Both checkboxes remain ticked after Apply. The grid shows a mix of Auction and Pre-Order cards. After unticking both and applying, the grid returns to showing all types.",
-        expectedUiState: "After first Apply: the Filters badge count is 2; the grid shows cards labelled 'Auction' and 'Pre-Order'. Reopening drawer: both Auctions and Pre-Orders are ticked. After second Apply with none ticked: badge count returns to 0 and cards of multiple types reappear.",
+        expectedBehaviour: "Both checkboxes remain ticked after Apply. The grid shows a mix of Classified and Digital Code cards. After unticking both and applying, the grid returns to showing every type the general catalogue spans.",
+        expectedUiState: "After first Apply: the Filters badge count is 2; the grid shows cards labelled 'Classified' and 'Digital Code'. Reopening drawer: both Classifieds and Digital Codes are ticked. After second Apply with none ticked: badge count returns to 0 and cards of multiple types reappear.",
         endResult: "Nothing is persisted to the server. Filter state is URL state.",
     },
     "checklist-buying-browsing-search-product-type-chips-none-means-all": {
@@ -488,8 +491,8 @@ export const authored = {
             "Click 'Close'.",
             "Scan the badges on the first page of cards.",
         ],
-        expectedBehaviour: "With no Listing type filter applied the grid shows items of multiple types — at least two different type badges are visible on the first page.",
-        expectedUiState: "At least two different type badges are visible on page 1, for example an 'Auction' card alongside a 'Digital Code' card or a 'Pre-Order' alongside a 'Classified'.",
+        expectedBehaviour: "With no Listing type filter applied the grid shows every type the GENERAL CATALOGUE spans — not every type in the system. At least two different type badges are visible on the first page, and none of them is a type that owns a dedicated nav page.",
+        expectedUiState: "At least two different type badges are visible on page 1, drawn only from Classified / Digital Code / Live Item / no-badge (Standard) — for example a 'Classified' card alongside a 'Digital Code' card. NO 'Auction', 'Pre-Order', 'Prize Draw', 'Art Print' or 'Sticker Sheet' badge appears.",
         endResult: "Nothing is persisted.",
     },
     "checklist-buying-browsing-search-product-type-filter-counts-in-badge": {
@@ -498,7 +501,7 @@ export const authored = {
         steps: [
             "Open /products.",
             "Click 'Filters'.",
-            "Tick 'Auctions'.",
+            "Tick 'Classifieds'.",
             "Click 'Apply'.",
             "Note the new number on the Filters badge.",
             "Click 'Filters' again.",
@@ -506,8 +509,8 @@ export const authored = {
             "Click 'Apply'.",
             "Note the Filters badge number and the grid content.",
         ],
-        expectedBehaviour: "Ticking one Listing type box and pressing Apply increases the Filters badge by 1. 'Reset all' unticks every type box and restores the badge to 0, and the grid repopulates with all listing types.",
-        expectedUiState: "After ticking Auctions and applying: badge shows 1 (or higher if defaults add to it). After Reset all and Apply: badge shows 0 and the grid contains mixed listing types.",
+        expectedBehaviour: "Ticking one Listing type box and pressing Apply increases the Filters badge by 1. 'Reset all' unticks every type box and restores the badge to 0, and the grid repopulates with every type the general catalogue spans.",
+        expectedUiState: "After ticking Classifieds and applying: badge shows 1 (or higher if defaults add to it). After Reset all and Apply: badge shows 0 and the grid contains mixed listing types.",
         endResult: "Nothing is persisted to the server.",
     },
     "checklist-buying-browsing-search-product-type-filter-lives-in-drawer": {
@@ -530,16 +533,16 @@ export const authored = {
             "Open /products with no filters applied.",
             "Note the types of cards visible in the grid.",
             "Click 'Filters'.",
-            "Tick 'Auctions' and watch the grid behind the open drawer.",
+            "Tick 'Classifieds' and watch the grid behind the open drawer.",
             "Click 'Apply'.",
             "Note the grid now.",
             "Click 'Filters' again.",
-            "Tick 'Art'.",
+            "Tick 'Live Items'.",
             "Click the X (Close) button on the drawer — do not click Apply.",
             "Click 'Filters' again to reopen and read which boxes are ticked.",
         ],
         expectedBehaviour: "Ticking a box does not change the grid until Apply is pressed. Closing with X discards pending changes — the grid and the ticked state both revert to what was applied before.",
-        expectedUiState: "While drawer is open with Auctions ticked: grid behind the drawer still shows mixed types. After Apply: grid shows only Auction cards. After ticking Art and closing with X: grid still shows only Auction cards (Art was discarded). Reopening drawer: only Auctions is ticked; Art is unticked.",
+        expectedUiState: "While drawer is open with Classifieds ticked: grid behind the drawer still shows mixed types. After Apply: grid shows only Classified cards. After ticking Live Items and closing with X: grid still shows only Classified cards (Live Items was discarded). Reopening drawer: only Classifieds is ticked; Live Items is unticked.",
         endResult: "Nothing is persisted to the server.",
     },
     "checklist-buying-browsing-search-product-type-selection-survives-reload": {
@@ -547,7 +550,7 @@ export const authored = {
         startPage: "/products",
         steps: [
             "Open /products.",
-            "Click 'Filters', tick 'Auctions' and 'Art', click 'Apply'.",
+            "Click 'Filters', tick 'Classifieds' and 'Live Items', click 'Apply'.",
             "Copy the current URL from the address bar.",
             "Open the copied URL in a new browser tab.",
             "Click 'Filters' in the new tab and read which boxes are ticked.",
@@ -555,24 +558,22 @@ export const authored = {
             "Press the browser Back button in the original tab.",
             "Click 'Filters' in the original tab and read which boxes are ticked.",
         ],
-        expectedBehaviour: "The applied listing types are encoded in the URL. Opening the URL in a new tab shows the same filtered grid with Auctions and Art ticked. Pressing Back restores the previous selection.",
-        expectedUiState: "New tab: grid shows Auction and Art cards; Filters drawer shows Auctions and Art ticked. After Back: the previous filter state (before the Auctions + Art selection) is restored.",
+        expectedBehaviour: "The applied listing types are encoded in the URL. Opening the URL in a new tab shows the same filtered grid with Classifieds and Live Items ticked. Pressing Back restores the previous selection.",
+        expectedUiState: "New tab: grid shows Classified and Live Item cards; Filters drawer shows Classifieds and Live Items ticked. After Back: the previous filter state (before the Classifieds + Live Items selection) is restored.",
         endResult: "Nothing is persisted to the server. Filter state is URL state.",
     },
     "checklist-buying-browsing-search-product-type-toggles-follow-selection": {
         roles: ["guest"],
         startPage: "/products",
         steps: [
-            "Open /products.",
-            "Click 'Filters', tick only 'Auctions', click 'Apply'.",
-            "Read the label of the middle availability tab above the grid.",
-            "Click that middle tab.",
-            "Click 'Filters', untick 'Auctions', tick only 'Standard', click 'Apply'.",
-            "Read the label of the middle availability tab.",
-            "Click that middle tab.",
-        ],
-        expectedBehaviour: "With only Auctions selected, the middle tab is labelled 'Ended'. With only Standard selected, the middle tab is labelled 'Sold'. Clicking the tab in each case shows the respective unavailable items of that type.",
-        expectedUiState: "Auctions only: middle tab reads 'Ended'; clicking it shows ended auction cards. Standard only: middle tab reads 'Sold'; clicking it shows sold-out product cards.",
+            "Open /products and read the label of the middle availability tab above the grid.",
+            "Click that middle tab and read the cards.",
+            "Open /auctions and read the label of its middle availability tab.",
+            "Click that middle tab and read the cards.",
+            "Open /prize-draws and read the label of its middle availability tab.",
+        ],
+        expectedBehaviour: "The middle availability tab is named for how that listing type stops being available: a product runs out, an auction ends, a prize draw closes. This used to be read by ticking Auctions on /products; auctions now live only on their own page, so the three wordings are read across the three pages.",
+        expectedUiState: "/products: the middle tab reads 'Sold'; clicking it shows sold-out product cards. /auctions: it reads 'Ended'; clicking it shows ended auction cards. /prize-draws: it reads 'Closed'. In all three the first tab is 'Available' and is selected on arrival.",
         endResult: "Nothing is persisted to the server.",
     },
     "checklist-buying-browsing-search-search": {
@@ -598,15 +599,15 @@ export const authored = {
         steps: [
             "Open /products.",
             "Type 'Beyblade' in the search field and click 'Search'.",
-            "Click 'Filters', tick 'Auctions', click 'Apply'.",
-            "Open the 'Sort by' dropdown and select 'Ending Soon'.",
+            "Click 'Filters', tick 'Classifieds', click 'Apply'.",
+            "Open the 'Sort by' dropdown and select 'Name: A–Z'.",
             "Read the URL.",
             "Click 'Page 2' in the pagination bar if available.",
             "Read the URL and note the result count.",
         ],
-        inputs: { query: "Beyblade", listingType: "Auctions", sort: "Ending Soon" },
-        expectedBehaviour: "All three — search query, listing type filter, and sort — stay applied together. Pagination reflects the combined narrowed result count, not the unfiltered total.",
-        expectedUiState: "The URL contains the search term, the listing-type parameter, and the sort parameter together. The grid shows only auction cards whose title includes 'Beyblade', sorted by ending soonest. Page 2 (if navigated) continues this filtered/sorted set, not the unfiltered set.",
+        inputs: { query: "Beyblade", listingType: "Classifieds", sort: "Name: A–Z" },
+        expectedBehaviour: "All three — search query, listing type filter, and sort — stay applied together. Pagination reflects the combined narrowed result count, not the unfiltered total. The sort used here is deliberately a non-money one: price sorts are not offered to signed-out visitors.",
+        expectedUiState: "The URL contains the search term, the listing-type parameter, and the sort parameter together. The grid shows only Classified cards whose title includes 'Beyblade', ordered A–Z by title. Page 2 (if navigated) continues this filtered/sorted set, not the unfiltered set.",
         endResult: "Nothing is persisted to the server. State is URL-encoded.",
     },
     "checklist-buying-browsing-search-show-sold-toggle-reveals-items": {
@@ -631,23 +632,22 @@ export const authored = {
         endResult: "Nothing is persisted. Tab state is URL state only.",
     },
     "checklist-buying-browsing-search-sort-options-per-listing-type": {
-        roles: ["guest"],
+        roles: ["buyer"],
         startPage: "/products",
         steps: [
+            "Sign in as a buyer — price sorts are not offered to signed-out visitors.",
             "Open /products with no type filter.",
             "Open the 'Sort by' dropdown and select 'Price low to high'.",
             "Note the order of cards (cheapest first).",
             "Open the 'Sort by' dropdown and select 'Price high to low'.",
             "Note the order of cards (most expensive first).",
-            "Click 'Filters', tick only 'Auctions', click 'Apply'.",
-            "Open Sort and select 'Ending Soon'.",
+            "Open /auctions, open Sort and select 'Ending Soon'.",
             "Note the order of auction cards.",
-            "Click 'Filters', untick 'Auctions', tick only 'Pre-Orders', click 'Apply'.",
-            "Open Sort and select 'Earliest Delivery'.",
+            "Open /pre-orders, open Sort and select 'Earliest Delivery'.",
             "Note the order of pre-order cards.",
         ],
-        expectedBehaviour: "Each sort option genuinely reorders the visible results. Price sorts change the order by price. Ending Soon reorders auctions by end date. Earliest Delivery reorders pre-orders by delivery date.",
-        expectedUiState: "Price low to high: cheapest card first (e.g. ₹149 before ₹1,299). Price high to low: most expensive first. Ending Soon: auctions with soonest end date appear first. Earliest Delivery: pre-orders with earliest expected delivery appear first.",
+        expectedBehaviour: "Each sort option genuinely reorders the visible results. Price sorts change the order by price. Ending Soon reorders auctions by end date. Earliest Delivery reorders pre-orders by delivery date. The auction and pre-order legs run on their own pages, because those types are no longer selectable on /products.",
+        expectedUiState: "Price low to high: cheapest card first (e.g. ₹149 before ₹1,299). Price high to low: most expensive first. Ending Soon on /auctions: auctions with soonest end date appear first. Earliest Delivery on /pre-orders: pre-orders with earliest expected delivery appear first.",
         endResult: "Nothing is persisted.",
     },
 };