@mohasinac/appkit 4.35.3 → 4.36.0

package/dist/features/tester/seed-data/authored/index.js

@@ -34,6 +34,7 @@ import { authored as a_admin__catalog_listings } from "./admin__catalog-listings
 import { authored as a_admin__orders_fulfillment } from "./admin__orders-fulfillment";
 import { authored as a_admin__users_trust } from "./admin__users-trust";
 import { authored as a_admin__site_system } from "./admin__site-system";
+import { authored as a_admin__bug_hunter_rewards } from "./admin__bug-hunter-rewards";
 import { authored as a_admin__category_brand_authoring } from "./admin__category-brand-authoring";
 import { authored as a_admin__uncovered_admin_pages } from "./admin__uncovered-admin-pages";
 import { authored as a_admin__bans_and_trust } from "./admin__bans-and-trust";
@@ -119,6 +120,8 @@ import { authored as a_selling__seller_orders } from "./selling__seller-orders";
 import { authored as a_selling__seller_marketing_extras } from "./selling__seller-marketing-extras";
 import { authored as a_selling__listing_a_product } from "./selling__listing-a-product";
 import { authored as a_selling__seller_listing_types } from "./selling__seller-listing-types";
+import { authored as a_selling__product_upload_details } from "./selling__product-upload-details";
+import { authored as a_selling__quick_add_minimum_details } from "./selling__quick-add-minimum-details";
 import { authored as a_seo__canonical_and_host } from "./seo__canonical-and-host";
 import { authored as a_seo__sitemap_and_robots } from "./seo__sitemap-and-robots";
 import { authored as a_seo__page_metadata } from "./seo__page-metadata";
@@ -141,6 +144,7 @@ export const AUTHORED_CASES = {
     ...a_admin__orders_fulfillment,
     ...a_admin__users_trust,
     ...a_admin__site_system,
+    ...a_admin__bug_hunter_rewards,
     ...a_admin__category_brand_authoring,
     ...a_admin__uncovered_admin_pages,
     ...a_admin__bans_and_trust,
@@ -226,6 +230,8 @@ export const AUTHORED_CASES = {
     ...a_selling__seller_marketing_extras,
     ...a_selling__listing_a_product,
     ...a_selling__seller_listing_types,
+    ...a_selling__product_upload_details,
+    ...a_selling__quick_add_minimum_details,
     ...a_seo__canonical_and_host,
     ...a_seo__sitemap_and_robots,
     ...a_seo__page_metadata,

package/dist/features/tester/seed-data/authored/public-pages__auth-error-pages.js

@@ -36,6 +36,8 @@ export const authored = {
         endResult: "The account exists and persists. This case creates a real row that teardown does not remove, which is why the address is numbered rather than fixed.",
     },
     "checklist-public-pages-auth-error-pages-forgot-reset-password-pages": {
+        requiresHumanChannel: true,
+        humanChannelReason: "real email inbox",
         roles: ["guest"],
         startPage: "/auth/forgot-password",
         steps: [
@@ -58,6 +60,8 @@ export const authored = {
         endResult: "The password is back at TempPass123! by the final step. This case shares divya.funko@gmail.com with the single-use-link case in signup-login and with nothing else, deliberately — the seeder never resets an existing password, so a changed one outlives every future re-seed.",
     },
     "checklist-public-pages-auth-error-pages-verify-email-page": {
+        requiresHumanChannel: true,
+        humanChannelReason: "real email inbox",
         roles: ["guest"],
         startPage: "/auth/register",
         steps: [

package/dist/features/tester/seed-data/authored/selling__listing-a-product.js

@@ -168,22 +168,6 @@ export const authored = {
         expectedUiState: "Every preview shows its picture at the same size as its neighbours, at both widths. An empty white or bordered box where a photo should be is the failure, and it hits every clickable image tile in the app at once.",
         endResult: "Leave the editor without saving.",
     },
-    "checklist-selling-listing-a-product-media-upload-images-capped-at-5": {
-        roles: ["seller"],
-        startPage: "/store/products/new",
-        steps: [
-            "Sign in as tyson@beybladearena.in / TempPass123!.",
-            "Open /store/products/new and read the stated image limit before uploading anything.",
-            "Upload public/test-media/sample-image.png repeatedly, counting the previews after each.",
-            "Continue until an upload is refused.",
-            "Read the message and the preview count at that point.",
-            "Compare the count against the limit the form stated.",
-        ],
-        inputs: { image: "public/test-media/sample-image.png" },
-        expectedBehaviour: "The number the form STATES is the number it enforces. This case exists to catch a disagreement between them: a label saying five against a limit of ten, or the reverse, is a promise the form does not keep — and the checklist label itself says five while the shared limits module is the authority.",
-        expectedUiState: "Uploads are accepted up to the stated limit and the next is refused with a readable message. The refusal count equals the stated limit exactly. If the two disagree, record BOTH numbers — which one is wrong is a judgement for the reader, not for the tester.",
-        endResult: "Leave the editor without saving.",
-    },
     "checklist-selling-listing-a-product-media-upload-video-duration": {
         roles: ["seller"],
         startPage: "/store/products/new",

package/dist/features/tester/seed-data/authored/selling__product-upload-details.d.ts

@@ -0,0 +1,2 @@
+import type { AuthoredCase } from "./_types";
+export declare const authored: Record<string, AuthoredCase>;

package/dist/features/tester/seed-data/authored/selling__product-upload-details.js

@@ -0,0 +1,150 @@
+/*
+ * WHY: Authored six-part procedures for the selling/product-upload-details page.
+ * WHAT: 6 case(s), keyed by full checklist id.
+ *
+ * The seller product form has THREE separate media controls and they are easy to
+ * conflate. Grounded in SellerProductShell.tsx `StepMedia` (:342-497):
+ *
+ *   Main image    ImageUpload,      label "Main Image", enableAdvancedCrop,
+ *                                   cropAspectRatio 1, max 10 MB, index 1
+ *   Gallery       MediaUploadList,  label "Gallery (up to 10 images + 1 video)",
+ *                                   maxItems 11, maxImages 10, maxVideos 1,
+ *                                   maxSizeMB 50, indices 2..11
+ *   Video panel   MediaUploadField, YouTube / external URL / trim / poster
+ *
+ * The existing pages already cover the CAPS (selling/media-limits: 10th uploads,
+ * 11th refused, second video refused) and the basics (selling/listing-a-product:
+ * upload, preview, remove, crop, multiple). This page covers what neither does:
+ * refusal copy, type refusal, ordering, index collision, and the video path that
+ * was returning a 500 until 2026-09.
+ *
+ * @tag domain:tester
+ * @tag layer:seed
+ * @tag pattern:none
+ * @tag access:server-only
+ * @tag consumers:seed-data/authored/index.ts
+ * @tag sideEffects:none
+ */
+import { MEDIA_ENDPOINTS } from "../../../../constants/api-endpoints";
+/*
+ * The endpoint comes from the registry, not a literal.
+ *
+ * These cases genuinely need to name it — the tester is told to open the
+ * network panel and read that exact request, and "the signing request" would be
+ * too vague for R8, which requires literal values. But a pasted copy of the path
+ * is a second definition that silently rots the day the route moves, leaving a
+ * tester hunting a request that no longer exists and reporting a bug that is
+ * really a stale case. Interpolating keeps it precise AND single-sourced.
+ */
+const SIGN = MEDIA_ENDPOINTS.SIGN;
+const SIGN_IN_SELLER = "Sign in as tyson@beybladearena.in / TempPass123!.";
+export const authored = {
+    "checklist-selling-product-upload-details-main-image-crop-applies": {
+        roles: ["seller"],
+        startPage: "/store/products/new",
+        steps: [
+            SIGN_IN_SELLER,
+            "Open /store/products/new and click 'Show all fields (advanced)' to reach the sectioned form.",
+            "Open the Media section and choose public/test-media/sample-image.png for 'Main Image'.",
+            "Wait for the crop dialog to appear and note the shape of the crop box.",
+            "Drag the crop box to cover clearly only the LEFT half of the picture, then confirm.",
+            "Read the thumbnail that appears afterwards and compare what it shows against the original.",
+        ],
+        inputs: { image: "public/test-media/sample-image.png" },
+        expectedBehaviour: "The crop is applied to the bytes that are uploaded, not merely previewed. A cropper that shows a selection and then stores the original is worse than no cropper — the seller believes they framed the photo and the marketplace shows something else. The box is locked square because the main image is rendered square on every card.",
+        expectedUiState: "A crop dialog opens before any upload begins, and its box is square and stays square when dragged. The resulting thumbnail shows the LEFT half that was selected, not the whole picture.",
+        expectedData: { cropAspectRatio: 1 },
+        endResult: "Leave without saving. Re-open the form: no half-uploaded image is left attached to a draft.",
+    },
+    "checklist-selling-product-upload-details-oversize-image-refused-client-side": {
+        roles: ["seller"],
+        startPage: "/store/products/new",
+        steps: [
+            SIGN_IN_SELLER,
+            "Open /store/products/new and switch to the advanced form.",
+            "Open the Media section and read the size limit stated next to 'Main Image'.",
+            "Choose public/test-media/oversized.png for the Main Image and start a timer. (The batch generates this file — it is >10 MB of incompressible noise and deliberately not committed.)",
+            "Read the message that appears and note how long it took.",
+            `Open the browser network panel and check whether any request to ${SIGN} was made.`,
+        ],
+        inputs: { image: "public/test-media/oversized.png", limitMb: 10 },
+        expectedBehaviour: "A file over the limit is refused BEFORE any bytes leave the browser. The point is the seller's time: a 12 MB upload that travels, then finalises, then fails validation has taken a minute to tell them something the form already knew when they picked the file. The limit is also stated up front rather than only in the refusal.",
+        expectedUiState: `The refusal is immediate (well under a second) and reads 'File size must be less than 10MB', naming the actual size. No ${SIGN} request appears in the network panel. The field keeps whatever image it had before.`,
+        expectedData: { signRequestsMade: 0 },
+        endResult: "Leave without saving; nothing was uploaded.",
+    },
+    "checklist-selling-product-upload-details-disallowed-type-refused": {
+        roles: ["seller"],
+        startPage: "/store/products/new",
+        steps: [
+            SIGN_IN_SELLER,
+            "Open /store/products/new and switch to the advanced form.",
+            "Open the Media section and choose public/test-media/sample-vector.svg for the Main Image.",
+            "Read the message that appears.",
+            "Now choose public/test-media/sample-image.png for the same field.",
+            "Read whether it is accepted.",
+        ],
+        inputs: { rejected: "public/test-media/sample-vector.svg", accepted: "public/test-media/sample-image.png" },
+        expectedBehaviour: "SVG is deliberately outside the allowed image types — it is a document format that can carry script, and it is served from our own origin. The refusal happens on type, not on extension alone, and the control recovers: refusing one file must not leave the field wedged.",
+        expectedUiState: "The SVG is refused with a message naming the accepted types. Immediately afterwards the PNG uploads normally in the same field — no reload needed.",
+        endResult: "Leave without saving.",
+    },
+    "checklist-selling-product-upload-details-gallery-order-persists": {
+        roles: ["seller"],
+        startPage: "/store/products/new",
+        steps: [
+            SIGN_IN_SELLER,
+            "Open /store/products/new and switch to the advanced form.",
+            "Open the Media section and add three gallery images one at a time: public/test-media/sample-image.png, then public/test-media/sample-image-2.png, then public/test-media/sample-image-3.png.",
+            "Note the order the three thumbnails appear in, left to right.",
+            "Drag the THIRD thumbnail to the first position.",
+            "Fill Title 'Gallery Order Probe', Description 'Checking that gallery ordering survives a save and reload.', Category 'Beyblade Burst', Price 499, then Publish.",
+            "Re-open the product for editing and read the gallery order again.",
+        ],
+        inputs: {
+            images: "public/test-media/sample-image.png + sample-image-2.png + sample-image-3.png",
+            title: "Gallery Order Probe",
+            price: 499,
+        },
+        expectedBehaviour: "Gallery order is the seller's editorial decision about which angle a buyer sees second, so it is stored, not just displayed. Order that survives in the form but resets on reload means the array is being rebuilt from upload time rather than from the arrangement.",
+        expectedUiState: "After the drag the moved image is first. After publish and re-open it is STILL first, in the same order as before the save.",
+        expectedData: { firstGalleryImage: "public/test-media/sample-image-3.png" },
+        endResult: "The published product's gallery order matches what was arranged. Delete the product afterwards.",
+    },
+    "checklist-selling-product-upload-details-main-image-does-not-collide-with-gallery": {
+        roles: ["seller"],
+        startPage: "/store/products/new",
+        steps: [
+            SIGN_IN_SELLER,
+            "Open /store/products/new and switch to the advanced form.",
+            "Open the Media section and set the Main Image to public/test-media/sample-image.png, accepting the crop.",
+            "Add public/test-media/sample-image-2.png as the first GALLERY image.",
+            "Read both previews and confirm they show different pictures.",
+            "Publish with Title 'Slot Collision Probe', Description 'Main image and first gallery image must not overwrite each other.', Category 'Beyblade Burst', Price 499.",
+            "Open the product's public page and read the main image and the first gallery thumbnail.",
+        ],
+        inputs: { mainImage: "public/test-media/sample-image.png", firstGalleryImage: "public/test-media/sample-image-2.png", price: 499 },
+        expectedBehaviour: "The main image occupies index 1 and the gallery starts at index 2. Filenames here are content-derived with no timestamp, so two uploads that computed the same index would write the same storage path and the second would silently overwrite the first — the seller would see one of their two pictures simply vanish.",
+        expectedUiState: "The main image and the first gallery thumbnail show DIFFERENT pictures, both in the form and on the published page. Neither is blank.",
+        expectedData: { distinctImages: 2 },
+        endResult: "Both images survive a reload of the public page. Delete the product afterwards.",
+    },
+    "checklist-selling-product-upload-details-video-upload-succeeds": {
+        roles: ["seller"],
+        startPage: "/store/products/new",
+        steps: [
+            SIGN_IN_SELLER,
+            "Open /store/products/new and switch to the advanced form.",
+            "Open the Media section and open the video panel's 'Upload' tab.",
+            "Choose public/test-media/sample-video.mp4 and wait for it to finish.",
+            `Open the browser network panel and read the status of the ${SIGN} request.`,
+            "Read whether a poster frame and a duration appear.",
+            "Publish with Title 'Video Upload Probe', Description 'Checking the seller video upload path end to end.', Category 'Beyblade Burst', Price 499, then open the public page and play the video.",
+        ],
+        inputs: { video: "public/test-media/sample-video.mp4", price: 499 },
+        expectedBehaviour: "The dedicated video panel uploads through the same signed-URL flow as the gallery. This path returned HTTP 500 until 2026-09 because the panel omitted the category from the upload context and the filename generator threw on it — so every seller video upload from this panel failed while the gallery path worked. This case is that defect's regression test.",
+        expectedUiState: `${SIGN} returns 200, not 400 or 500. A poster frame and a duration appear. The published page plays the video.`,
+        expectedData: { signStatus: 200 },
+        endResult: "The video survives a reload of the public page. Delete the product afterwards.",
+    },
+};

package/dist/features/tester/seed-data/authored/selling__quick-add-minimum-details.d.ts

@@ -0,0 +1,2 @@
+import type { AuthoredCase } from "./_types";
+export declare const authored: Record<string, AuthoredCase>;

package/dist/features/tester/seed-data/authored/selling__quick-add-minimum-details.js

@@ -0,0 +1,154 @@
+/*
+ * WHY: Authored six-part procedures for the selling/quick-add-minimum-details page.
+ * WHAT: 6 case(s), keyed by full checklist id.
+ *
+ * 🛑 THE QUICK FORM AND "THE FIELDS VISIBLE ON WHATSAPP" ARE THE SAME SET. That is
+ * what makes this one page rather than two.
+ *
+ * `/store/products/new` does NOT open the sectioned form. SellerProductShell.tsx
+ * :1339 picks `formMode = "quick"` whenever mode is create and listingType is
+ * standard, so the default is QuickProductForm — six fields: title*, category*,
+ * price*, mainImage*, description, stockQuantity. The sectioned form is behind
+ * "Show all fields (advanced)".
+ *
+ * And the WhatsApp catalog push (catalog-sync/route.ts:70-86) sends exactly
+ * title, price, mainImage, condition and stockQuantity plus a derived slug and
+ * link. That is the quick form's field set. A seller who fills only the short
+ * form has, by construction, filled everything a WhatsApp buyer will ever see.
+ *
+ * 🛑 TWO CASES HERE ARE EXPECTED TO FAIL, and their expectations are written as
+ * the CORRECT behaviour rather than the current one. A case that documents a bug
+ * as intended passes forever and locks the defect in. Both are known:
+ *
+ *   condition-options-are-all-saveable  the form offers Like New / Good / Fair
+ *                                       (SellerProductShell.tsx:228-235) but
+ *                                       productBaseSchema accepts only new /
+ *                                       used / refurbished / broken
+ *                                       (request-schemas.ts:155)
+ *   description-requirement-is-honest   QuickProductForm labels description
+ *                                       "Brief description (optional)" and never
+ *                                       validates it, while the server requires
+ *                                       >= 20 characters (:122-128)
+ *
+ * @tag domain:tester
+ * @tag layer:seed
+ * @tag pattern:none
+ * @tag access:server-only
+ * @tag consumers:seed-data/authored/index.ts
+ * @tag sideEffects:none
+ */
+const SIGN_IN_SELLER = "Sign in as tyson@beybladearena.in / TempPass123!.";
+export const authored = {
+    "checklist-selling-quick-add-minimum-details-quick-form-is-the-default": {
+        roles: ["seller"],
+        startPage: "/store/products/new",
+        steps: [
+            SIGN_IN_SELLER,
+            "Open /store/products/new without clicking anything else.",
+            "Read the heading and count the input fields on screen.",
+            "List the field labels in order.",
+            "Read whether a control offering the full form is present, and read its label.",
+            "Open /store/art/new and count its fields for comparison.",
+        ],
+        expectedBehaviour: "Creating an ordinary product opens the SHORT form, because most listings need six fields and the sectioned form asks for thirty. The full form stays one click away rather than being the default. Non-standard types (art, auctions) open the sectioned form directly, since they carry type-specific fields the short form has no room for.",
+        expectedUiState: "Six fields: Product Name, Category, Price, Product Image, Description, Stock Quantity — and a control reading 'Show all fields (advanced)'. /store/art/new shows the sectioned form instead.",
+        expectedData: { quickFormFields: 6 },
+        endResult: "Read-only; leave without saving.",
+    },
+    "checklist-selling-quick-add-minimum-details-publish-with-the-minimum": {
+        roles: ["seller"],
+        startPage: "/store/products/new",
+        steps: [
+            SIGN_IN_SELLER,
+            "Open /store/products/new.",
+            "Enter Product Name 'Minimum Details Probe'.",
+            "Pick Category 'Beyblade Burst'.",
+            "Enter Price 499.",
+            "Upload public/test-media/sample-image.png as the Product Image.",
+            "Enter Description 'A short-form listing created with only the required fields present.'",
+            "Click Publish and read what happens.",
+            "Open the product's public page and read the title, price and image.",
+        ],
+        inputs: {
+            title: "Minimum Details Probe",
+            category: "Beyblade Burst",
+            price: 499,
+            image: "public/test-media/sample-image.png",
+            description: "A short-form listing created with only the required fields present.",
+        },
+        expectedBehaviour: "The short form can produce a real, published, buyable listing on its own. If it cannot, it is a decoy: the seller fills it, is refused, and has to learn the long form anyway — having already done the work twice.",
+        expectedUiState: "Publish succeeds with no inline errors and no error toast. The public page renders the title, ₹499 and the uploaded image.",
+        expectedData: { published: true },
+        endResult: "The listing survives a reload of the public page and appears in /store/products. Delete it afterwards.",
+    },
+    "checklist-selling-quick-add-minimum-details-whatsapp-shows-the-same-fields": {
+        roles: ["seller"],
+        startPage: "/store/whatsapp",
+        steps: [
+            SIGN_IN_SELLER,
+            "Publish 'Minimum Details Probe' from /store/products/new as in the previous case, with Price 499.",
+            "Open /store/whatsapp and find the catalog preview.",
+            "Locate the tile for 'Minimum Details Probe'.",
+            "Read every piece of information the tile shows.",
+            "Compare that list against the fields the quick form asked for.",
+        ],
+        inputs: { title: "Minimum Details Probe", price: 499 },
+        expectedBehaviour: "What WhatsApp shows is a subset of what the short form collects — title, price, image, condition and stock. This is the reason the short form is the right shape: a seller who fills only it has already supplied everything a WhatsApp buyer will see, so nothing is missing from the channel most of them arrive through.",
+        expectedUiState: "The tile shows the image, the name and ₹499. Nothing on it is blank or a placeholder, and nothing it shows was absent from the quick form.",
+        endResult: "Read-only against the catalog preview. Delete the probe listing afterwards.",
+    },
+    "checklist-selling-quick-add-minimum-details-advanced-flip-keeps-values": {
+        roles: ["seller"],
+        startPage: "/store/products/new",
+        steps: [
+            SIGN_IN_SELLER,
+            "Open /store/products/new.",
+            "Enter Product Name 'Flip Probe', Price 750, and Description 'Checking that switching to the full form keeps what was already typed.'",
+            "Pick Category 'Beyblade Burst'.",
+            "Click 'Show all fields (advanced)'.",
+            "Read the Title, Price, Description and Category fields in the sectioned form.",
+            "Read whether any value is blank that was filled a moment ago.",
+        ],
+        inputs: { title: "Flip Probe", price: 750, category: "Beyblade Burst" },
+        expectedBehaviour: "The flip changes the presentation, not the draft. Losing typed values on the way to the full form punishes the seller for outgrowing the short one, and teaches them to start with the long form every time — which defeats the point of having a short one.",
+        expectedUiState: "Title reads 'Flip Probe', Price 750, Category 'Beyblade Burst' and the description is intact in the sectioned form's Basic and Pricing sections.",
+        expectedData: { valuesPreserved: 4 },
+        endResult: "Leave without saving.",
+    },
+    "checklist-selling-quick-add-minimum-details-condition-options-are-all-saveable": {
+        roles: ["seller"],
+        startPage: "/store/products/new",
+        steps: [
+            SIGN_IN_SELLER,
+            "Open /store/products/new and click 'Show all fields (advanced)'.",
+            "Open the Basic section and read every option in the Condition dropdown, writing them all down.",
+            "Fill Title 'Condition Probe', Description 'Checking that every condition the form offers can actually be saved.', Category 'Beyblade Burst', Price 499 and a Main Image.",
+            "Select Condition 'Like New' and click Publish.",
+            "Read the result — inline error, toast, or success.",
+            "Repeat with 'Good', then with 'Fair', then with 'New', reading the result each time.",
+        ],
+        inputs: { title: "Condition Probe", price: 499, conditions: "Like New, Good, Fair, New" },
+        expectedBehaviour: "Every option the dropdown offers can be saved. A select that lists a value the server rejects is a trap with no way out — the seller picks the option that describes their item honestly and is refused, with nothing on screen saying which options are real.",
+        expectedUiState: "Publishing succeeds for EVERY option in the list, including Like New, Good and Fair. Any option that produces a validation failure is the finding — record which ones and quote the message.",
+        expectedData: { saveableConditions: "all options listed in the dropdown" },
+        endResult: "Each successful publish is visible on the public page with the chosen condition. Delete the listings afterwards.",
+    },
+    "checklist-selling-quick-add-minimum-details-description-requirement-is-honest": {
+        roles: ["seller"],
+        startPage: "/store/products/new",
+        steps: [
+            SIGN_IN_SELLER,
+            "Open /store/products/new.",
+            "Read the Description field's label and note exactly whether it says required or optional.",
+            "Fill Product Name 'Short Description Probe', Category 'Beyblade Burst', Price 499 and a Product Image.",
+            "Type exactly 'Nice bey' in Description — eight characters.",
+            "Click Publish and read what happens, and WHERE it appears.",
+            "If it was refused, read whether the message appeared on the Description field itself or somewhere else.",
+        ],
+        inputs: { title: "Short Description Probe", description: "Nice bey", price: 499 },
+        expectedBehaviour: "The form tells the truth about what it requires, and it tells it at the field. Either the description really is optional and a short one publishes, or it is required and the label says so with the minimum length stated. What must not happen is a field marked optional being refused by the server after the seller commits — that is the form making a promise the save does not keep.",
+        expectedUiState: "Label and behaviour agree. If a minimum length applies, the label states it and a short entry is caught inline on the Description field BEFORE publishing. A toast appearing after Publish, with the field itself showing no error, is the failure.",
+        expectedData: { errorShownInline: true },
+        endResult: "Either the listing publishes, or nothing is created and the form still holds what was typed. Delete anything created.",
+    },
+};

package/dist/features/tester/seed-data/authored/selling__seller-orders.js

@@ -176,6 +176,8 @@ export const authored = {
         endResult: "Read-only; nothing persists.",
     },
     "checklist-selling-seller-orders-seller-new-order-notification-reaches-seller": {
+        requiresHumanChannel: true,
+        humanChannelReason: "real email inbox",
         roles: ["buyer", "seller"],
         startPage: "/products/product-beyblade-burst-valkyrie",
         steps: [

package/dist/features/tester/seed-data/tester-checklist-seed-data.js

@@ -62,6 +62,25 @@ function group(groupKey, groupLabel, pages, opts) {
                 expectedUiState: c.expectedUiState ?? authored?.expectedUiState,
                 expectedData: c.expectedData ?? authored?.expectedData,
                 endResult: c.endResult ?? authored?.endResult,
+                /*
+                 * 🛑 This mapping is HAND-PICKED, so a field the overlay carries but
+                 * nobody lists here dies right at this line — Root Cause #38, which the
+                 * header of this very file warns about.
+                 *
+                 * `needsReview`/`reviewNote` were exactly that, from the day they were
+                 * added until 2026-09-13: `fetch-cases.mjs` reads them off the Firestore
+                 * item, SKILL.md documents them, and `record-verdicts.mjs` renders
+                 * "the case's own author flagged it for review" in the report — but
+                 * nothing ever put them ON the document, so the flag was permanently
+                 * false and that report line had never printed once. Four hops correct,
+                 * one hop missing, no error anywhere.
+                 *
+                 * When adding a field to AuthoredCase, add it HERE in the same commit.
+                 */
+                needsReview: c.needsReview ?? authored?.needsReview,
+                reviewNote: c.reviewNote ?? authored?.reviewNote,
+                requiresHumanChannel: c.requiresHumanChannel ?? authored?.requiresHumanChannel,
+                humanChannelReason: c.humanChannelReason ?? authored?.humanChannelReason,
                 // Every case gets a link: its own href, or the page's default —
                 // guarantees "Go test this ->" always has somewhere real to send
                 // the tester, even for cases nobody bothered to link individually.
@@ -2107,12 +2126,24 @@ const rawTesterChecklistItems = [
                     description: "Fixed 2026-08-21 — a fresh upload can briefly 404 while the Firestore doc and Storage object finish propagating; the thumbnail now retries with backoff instead of latching a permanent broken-image placeholder. Try uploading 2-3 images back-to-back on a slower connection to see the retry in action.",
                     href: "/store/products/new",
                 },
-                {
-                    key: "media-upload-images-capped-at-5",
-                    label: "The product gallery upload UI caps at 5 images (not 10) and its label reads \"up to 5\"",
-                    description: "Fixed 2026-08-21 — the UI previously advertised/allowed up to 10 images while the server schema only ever accepted 5, so a 6th+ image silently failed validation with no clear reason.",
-                    href: "/store/products/new",
-                },
+                /*
+                 * REMOVED 2026-09-11 — `media-upload-images-capped-at-5`.
+                 *
+                 * It asserted the gallery caps at "5 images (not 10)". The cap was
+                 * raised to 10 (`PRODUCT_MAX_IMAGES`, shared/media/limits.ts:37) and the
+                 * `selling/media-limits` page asserts the opposite in its own label:
+                 * "The 10th gallery image uploads — the 5th used to fail with a 400".
+                 *
+                 * So this case documented the OLD behaviour as the expectation. It
+                 * would fail against correct code, and anyone "fixing" the product to
+                 * satisfy it would re-break ten-image support. Its id encoded the wrong
+                 * number too, so correcting the label alone would still mislead.
+                 *
+                 * The invariant it really tested — the stated limit equals the enforced
+                 * limit — survives in `media-eleventh-image-refused-client-side`, which
+                 * requires the refusal to name the limit ("You can upload up to 10
+                 * images."). Nothing was lost.
+                 */
                 {
                     key: "media-upload-video-duration",
                     label: "Attaching a directly-uploaded video file during listing captures its duration automatically and saves without a validation error; attaching a YouTube or external video URL also saves fine without needing a duration",
@@ -2605,6 +2636,80 @@ const rawTesterChecklistItems = [
                 },
             ],
         },
+        {
+            pageKey: "product-upload-details",
+            pageLabel: "Product media — crop, refusals, ordering and the video path",
+            href: "/store/products/new",
+            cases: [
+                {
+                    key: "main-image-crop-applies",
+                    label: "The main-image crop is applied to what gets UPLOADED, not just previewed",
+                    description: "BEFORE: a cropper that shows a selection and stores the original is worse than none — the seller believes they framed the photo and the marketplace shows something else. AFTER: crop to the left half, confirm, and the stored thumbnail shows the left half.",
+                },
+                {
+                    key: "oversize-image-refused-client-side",
+                    label: "An image over 10 MB is refused BEFORE any bytes leave the browser",
+                    description: "BEFORE: a 12 MB upload that travels, finalises and then fails validation has taken a minute to say what the form knew when the file was picked. AFTER: immediate refusal reading the size limit, and no /api/media/sign request at all.",
+                },
+                {
+                    key: "disallowed-type-refused",
+                    label: "An SVG is refused, and the field still works immediately afterwards",
+                    description: "SVG is outside the allowed image types on purpose — a document format that can carry script, served from our own origin. Refusing one file must not wedge the control: the next PNG has to upload without a reload.",
+                },
+                {
+                    key: "gallery-order-persists",
+                    label: "Re-ordering gallery images survives Publish and re-opening the editor",
+                    description: "Gallery order is the seller decision about which angle a buyer sees second, so it is stored rather than merely displayed. Order that holds in the form and resets on reload means the array is rebuilt from upload time instead of from the arrangement.",
+                },
+                {
+                    key: "main-image-does-not-collide-with-gallery",
+                    label: "The main image and the first gallery image do not overwrite each other",
+                    description: "Filenames are content-derived with no timestamp, so two uploads computing the same index write the same storage path and the second silently replaces the first — the seller watches one of their two pictures vanish. Main image is index 1; the gallery starts at 2.",
+                },
+                {
+                    key: "video-upload-succeeds",
+                    label: "A video uploaded from the dedicated video panel saves and plays",
+                    description: "BEFORE: /api/media/sign returned 500 because the panel omitted the category from the upload context and the filename generator threw on it — every seller video upload from this panel failed while the gallery path worked. AFTER: sign returns 200, a poster frame and duration appear, and the published page plays it.",
+                },
+            ],
+        },
+        {
+            pageKey: "quick-add-minimum-details",
+            pageLabel: "Quick add — the short form, and what WhatsApp shows",
+            href: "/store/products/new",
+            cases: [
+                {
+                    key: "quick-form-is-the-default",
+                    label: "Creating an ordinary product opens the SHORT form, with the full form one click away",
+                    description: "Most listings need six fields and the sectioned form asks for thirty. /store/products/new opens Quick add; Show all fields (advanced) reaches the rest. Non-standard types open the sectioned form directly because they carry fields the short form has no room for.",
+                },
+                {
+                    key: "publish-with-the-minimum",
+                    label: "The short form alone can publish a real, buyable listing",
+                    description: "If it cannot, it is a decoy: the seller fills it, is refused, and has to learn the long form anyway — having done the work twice.",
+                },
+                {
+                    key: "whatsapp-shows-the-same-fields",
+                    label: "Everything WhatsApp shows was already asked for by the short form",
+                    description: "The catalog push sends title, price, image, condition and stock. That is the quick form field set, which is why the short form is the right shape — a seller who fills only it has supplied everything a WhatsApp buyer will see.",
+                },
+                {
+                    key: "advanced-flip-keeps-values",
+                    label: "Switching to the full form keeps everything already typed",
+                    description: "Losing values on the way to the full form punishes the seller for outgrowing the short one, and teaches them to start with the long form every time — which defeats the point of having a short one.",
+                },
+                {
+                    key: "condition-options-are-all-saveable",
+                    label: "Every Condition option the form offers can actually be saved",
+                    description: "BEFORE: the dropdown lists Like New, Good and Fair while the server accepts only new/used/refurbished/broken, so picking the option that honestly describes the item is refused with nothing on screen saying which options are real. AFTER: every listed option publishes.",
+                },
+                {
+                    key: "description-requirement-is-honest",
+                    label: "The Description field label agrees with what the save actually requires",
+                    description: "BEFORE: the field reads Brief description (optional) and is never validated client-side, while the server demands 20+ characters — so a field marked optional is refused after the seller commits, as a toast, with no error on the field. AFTER: label and behaviour agree and a short entry is caught inline.",
+                },
+            ],
+        },
         {
             pageKey: "media-limits",
             pageLabel: "Media \u2014 ten images and one video, on every listing type",

package/dist/react/contexts/SessionContext.d.ts

@@ -95,6 +95,19 @@ export interface SessionProviderProps {
 }
 export declare function SessionProvider({ children, initialUser, endpoints: endpointOverrides, onSignOutInvalidate, signOutInvalidationKeys, }: SessionProviderProps): React.JSX.Element;
 export declare function useSession(): SessionContextValue;
+/**
+ * The session if a provider is mounted, `null` if not — never throws.
+ *
+ * `useSession` throwing is right for a component that genuinely cannot work
+ * signed-out. It is wrong for library code that merely wants to ADJUST for the
+ * viewer, because requiring a provider there turns an optional refinement into a
+ * breaking contract change for every consumer (Root Cause #20).
+ *
+ * Use this only where "no provider" has a sensible, fail-closed answer — e.g.
+ * `useProducts`, which treats an absent session as "not a tester" and keeps the
+ * public cached view.
+ */
+export declare function useOptionalSession(): SessionContextValue | null;
 export declare function useAuth(): {
     user: SessionUser | null;
     loading: boolean;

package/dist/react/contexts/SessionContext.js

@@ -394,6 +394,21 @@ export function useSession() {
     }
     return context;
 }
+/**
+ * The session if a provider is mounted, `null` if not — never throws.
+ *
+ * `useSession` throwing is right for a component that genuinely cannot work
+ * signed-out. It is wrong for library code that merely wants to ADJUST for the
+ * viewer, because requiring a provider there turns an optional refinement into a
+ * breaking contract change for every consumer (Root Cause #20).
+ *
+ * Use this only where "no provider" has a sensible, fail-closed answer — e.g.
+ * `useProducts`, which treats an absent session as "not a tester" and keeps the
+ * public cached view.
+ */
+export function useOptionalSession() {
+    return useContext(SessionContext) ?? null;
+}
 export function useAuth() {
     const { user, loading, refreshUser } = useSession();
     return { user, loading, refreshUser };

package/dist/ui/components/ImageLightbox.js

@@ -83,7 +83,26 @@ export function ImageLightbox({ images, activeIndex, onClose, onNavigate, showTh
         adjustZoom(e.deltaY < 0 ? ZOOM_STEP : -ZOOM_STEP);
     }, [adjustZoom]);
     const handleKeyDown = useCallback((e) => {
+        /*
+         * Escape unwinds ONE level: fullscreen first, the lightbox second.
+         *
+         * Unconditionally calling `onClose()` meant Escape in fullscreen tore the
+         * whole lightbox down while the browser was natively exiting fullscreen at
+         * the same moment — the user asked to leave fullscreen and lost the image
+         * they were looking at. The Exit-fullscreen BUTTON behaved correctly, which
+         * is what made this read as a keyboard quirk rather than a bug.
+         *
+         * Exiting explicitly rather than relying on the browser's own handling: the
+         * `fullscreenchange` listener above is what clears `isFullscreen`, so going
+         * through the same path keeps the button label and this state in agreement
+         * whichever way the user leaves.
+         */
         if (e.key === "Escape") {
+            if (isFullscreen) {
+                const doc = document;
+                (document.exitFullscreen?.() ?? doc.webkitExitFullscreen?.())?.catch?.(() => { });
+                return;
+            }
             onClose();
             return;
         }
@@ -112,7 +131,11 @@ export function ImageLightbox({ images, activeIndex, onClose, onNavigate, showTh
             setRotation(0);
             return;
         }
-    }, [onClose, navigate, adjustZoom]);
+    }, 
+    // `isFullscreen` is a real dependency now — Escape branches on it, and a
+    // stale closure would send the user back to the pre-fix behaviour exactly
+    // when they are in fullscreen.
+    [onClose, navigate, adjustZoom, isFullscreen]);
     // Focus overlay on open for keyboard to work
     useEffect(() => {
         if (isOpen)