@mohasinac/appkit 4.32.1 → 4.32.3

package/dist/_internal/server/features/bundles/data.js

@@ -149,9 +149,11 @@ export async function resolveBundleCategorySlugs(productIds) {
  */
 export const listFeaturedBundles = cache(async (limit = 8, _opts) => {
     void _opts;
-    const all = await categoriesRepository
-        .listByType("bundle", { activeOnly: true, limit })
-        .catch(() => []);
+    const all = await safeRead(() => categoriesRepository.listByType("bundle", { activeOnly: true, limit }), {
+        route: "bundles/getFeaturedBundles",
+        key: "categories.listByType(bundle)",
+        fallback: [],
+    });
     return all;
 });
 /**
@@ -163,8 +165,13 @@ export const listFeaturedBundles = cache(async (limit = 8, _opts) => {
  * detail pages had no related section at all before this.
  */
 export const getRelatedBundles = cache(async (bundle, limit = 8) => {
-    const all = await categoriesRepository
-        .listByType("bundle", { activeOnly: true, limit: limit + 1 })
-        .catch(() => []);
+    const all = await safeRead(() => categoriesRepository.listByType("bundle", {
+        activeOnly: true,
+        limit: limit + 1,
+    }), {
+        route: "bundles/getRelatedBundles",
+        key: "categories.listByType(bundle)",
+        fallback: [],
+    });
     return all.filter((b) => b.id !== bundle.id).slice(0, limit);
 });

package/dist/_internal/server/features/products/list-public.js

@@ -442,6 +442,21 @@ export async function listPublicProducts(input, opts) {
         ? unavailableClausesFor(types).find((c) => c.op === "lt" && c.sortField === requestedSortField)
         : undefined;
     if (pushdown) {
+        /*
+         * 🛑 This branch keeps a POST-pagination sandbox filter, knowingly.
+         *
+         * It exists to give the ended-listing archive real, unbounded-depth
+         * Firestore pagination, which is incompatible with the over-fetch the
+         * window path uses. So an anonymous page here can come back a row or two
+         * SHORT when a sandbox fixture lands in it — bounded by the ~25 fixtures
+         * that exist, and nothing like the empty page the default view produced,
+         * because real ended listings dominate this scope.
+         *
+         * Falling through to Path C instead would fix the short page and cost every
+         * anonymous visitor the deep pagination this branch was written for. The
+         * short page is the better trade; it is recorded here so the next reader
+         * knows it was weighed rather than missed.
+         */
         const filters = sieveAnd(safeFilters, clauseToSieve(pushdown, now));
         const result = await runQuery(executor, {
             filters,
@@ -558,7 +573,28 @@ export async function listPublicProducts(input, opts) {
     const hasTypeFacet = Object.keys(input.typeFacets ?? {}).length > 0;
     /** Multi-value `tags`/`features` — no `array-contains-any`, so per-row. */
     const hasArrayMultiSelect = (input.tags?.length ?? 0) > 1 || (input.features?.length ?? 0) > 1;
-    const inMemory = wantAvailable || hasTypeFacet || hasArrayMultiSelect || (hasDateRange && !canPushDate);
+    /*
+     * 🛑 The tester-sandbox filter must run BEFORE the page is sliced.
+     *
+     * It used to run only in `finish()`, which receives an already-paginated
+     * page — so a page whose rows were ALL sandbox fixtures came back empty with
+     * a non-zero `total`. That is not hypothetical: the fixtures carry
+     * `Date.now()`-relative dates by design (they have to re-arm on every
+     * reseed), so immediately after a seed load they are the newest rows in the
+     * collection and fill the whole first page of the default `-createdAt` sort.
+     * The public catalogue returned `items: []` alongside `total: 79`.
+     *
+     * So an anonymous viewer forces the bounded-window path, where the filter is
+     * one more per-row predicate applied before the slice. That is already the
+     * default for public browsing (`wantAvailable`), so this widens the window
+     * path only for the non-default scopes.
+     */
+    const hidesTestData = filterTestDataForViewer([{ isTestData: true }], opts?.viewer).length === 0;
+    const inMemory = wantAvailable ||
+        hasTypeFacet ||
+        hasArrayMultiSelect ||
+        hidesTestData ||
+        (hasDateRange && !canPushDate);
     // When a date range stays in memory, fetch in whichever direction front-loads
     // the rows that will PASS it: `dateFrom` (">=", still live) wants the most
     // future dates first; `dateTo` ("<=", ends by) wants the earliest first.
@@ -597,6 +633,10 @@ export async function listPublicProducts(input, opts) {
             return wanted.some((w) => raw.includes(w));
         };
         const filtered = items.filter((item) => {
+            // Before the slice — see the note on `hidesTestData` above.
+            if (hidesTestData && item.isTestData === true) {
+                return false;
+            }
             if (wantAvailable && !isListingRowAvailable(item, now))
                 return false;
             if (hasArrayMultiSelect) {

package/dist/_internal/server/features/stores/data.js

@@ -3,6 +3,7 @@ import { cache } from "react";
 import { storeRepository } from "../../../../repositories";
 import { STORES_PRODUCTS_PAGE_SIZE, STORES_SITEMAP_LIMIT, } from "../../../shared/features/stores/config";
 import { makeGetStoreListingsInitial } from "../shared/listing-data-factory";
+import { safeRead } from "../../../../errors/safe-read";
 /** Full store document by slug — deduped per request via React.cache(). */
 export const getStoreForDetail = cache(async (slug) => {
     return (await storeRepository.findBySlug(slug)) ?? null;
@@ -13,8 +14,10 @@ export const listStoreAuctionsInitial = makeGetStoreListingsInitial("auction", S
 export const listStorePreOrdersInitial = makeGetStoreListingsInitial("pre-order", STORES_PRODUCTS_PAGE_SIZE);
 /** Stores for sitemap generation. */
 export const listSitemapStores = cache(async () => {
-    const result = await storeRepository
-        .listStores({ filters: "status==active", sorts: "-updatedAt", page: 1, pageSize: STORES_SITEMAP_LIMIT }, true)
-        .catch(() => null);
+    /*
+     * The SITEMAP. A swallowed failure here publishes a sitemap missing every
+     * store — which is not an error to any crawler, just a smaller site.
+     */
+    const result = await safeRead(() => storeRepository.listStores({ filters: "status==active", sorts: "-updatedAt", page: 1, pageSize: STORES_SITEMAP_LIMIT }, true), { route: "sitemap/stores", key: "stores.listStores", fallback: null });
     return (result?.items ?? []).map(({ storeSlug, updatedAt }) => ({ storeSlug, updatedAt }));
 });

package/dist/features/auctions/actions/bid-actions.js

@@ -28,6 +28,7 @@ import { getDefaultCurrency } from "../../../core/baseline-resolver";
 import { cartRepository } from "../../cart/repository/cart.repository";
 import { AUCTION_BUYOUT_WINDOW_MINUTES, AUCTION_BUYOUT_WINDOW_MS, AUCTION_CHECKOUT_URL, } from "../../../_internal/shared/checkout/lanes";
 import { resolveDate } from "../../../utils";
+import { safeRead } from "../../../errors/safe-read";
 // --- Domain Functions ----------------------------------------------------------
 /**
  * Load the bidder's profile and refuse if they carry an active `place_bids`
@@ -110,9 +111,9 @@ export async function placeBid(userId, userEmail, input) {
                 : BID_ERROR_CODES.TOO_LOW,
         });
     }
-    const previousWinner = await bidRepository
-        .getWinningBid(productId)
-        .catch(() => null);
+    // A failure here is not "no previous winner" — it silently uncaps the
+    // auto-bid ceiling below, which is a money path.
+    const previousWinner = await safeRead(() => bidRepository.getWinningBid(productId), { route: "bid-actions/placeBid", key: "bids.getWinningBid", fallback: null });
     const prevCap = previousWinner?.data
         ? (previousWinner.data.autoMaxBid ?? previousWinner.data.bidAmount ?? baseBid)
         : baseBid;

package/dist/features/auctions/components/AuctionDetailPageView.js

@@ -132,9 +132,11 @@ export async function AuctionDetailPageView({ id, initialAuction, onPlaceBid, on
         : [];
     const descriptionHtml = toDescriptionHtml(p.description);
     const sublistingCategoryId = typeof p.sublistingCategoryId === "string" ? p.sublistingCategoryId : null;
-    const relatedDocs = await productRepository
-        .findByCategory(String(p.category ?? ""))
-        .catch(() => []);
+    const relatedDocs = (await safeRead(() => productRepository.findByCategory(String(p.category ?? "")), {
+        route: "/auctions/[slug]",
+        key: "products.findByCategory",
+        fallback: [],
+    }));
     const [{ relatedItems, relatedByBrand, relatedByTags, relatedByStore }, groups, siteSettings] = await Promise.all([
         computeRelatedItems(product),
         getGroupsWithItemsForProduct(product.id),

package/dist/features/blog/components/BlogIndexPageView.js

@@ -3,6 +3,7 @@ import { blogRepository } from "../../../repositories";
 import { Container, Heading, Main, Section } from "../../../ui";
 import { AdSlot } from "../../homepage/components/AdSlot";
 import { BlogIndexListing } from "./BlogIndexListing";
+import { safeRead } from "../../../errors/safe-read";
 function sp(params, key) {
     const v = params[key];
     return Array.isArray(v) ? v[0] ?? "" : v ?? "";
@@ -12,9 +13,7 @@ export async function BlogIndexPageView({ searchParams = {} }) {
     const page = Number(sp(searchParams, "page")) || 1;
     const pageSize = Number(sp(searchParams, "pageSize")) || 24;
     const category = sp(searchParams, "category");
-    const sieveResult = await blogRepository
-        .listPublished({ ...(category ? { category } : {}) }, { sorts: sort, page, pageSize })
-        .catch(() => null);
+    const sieveResult = await safeRead(() => blogRepository.listPublished({ ...(category ? { category } : {}) }, { sorts: sort, page, pageSize }), { route: "/blog", key: "blogPosts.listPublished", fallback: null });
     const initialData = sieveResult
         ? {
             posts: sieveResult.items,

package/dist/features/categories/components/BundlesListView.js

@@ -3,6 +3,7 @@ import { categoriesRepository } from "../../../repositories";
 import { Container, Heading, Main, Section, Text } from "../../../ui";
 import { AdSlot } from "../../homepage/components/AdSlot";
 import { CategoryBundlesListing } from "./CategoryBundlesListing";
+import { safeRead } from "../../../errors/safe-read";
 const DEFAULT_LIMIT = 200;
 function sp(params, key) {
     const v = params[key];
@@ -17,9 +18,10 @@ function sp(params, key) {
  */
 export async function BundlesListView({ searchParams = {}, onBuyNow, }) {
     const storeId = sp(searchParams, "storeId");
-    const all = await categoriesRepository
-        .listByType("bundle", { activeOnly: true, limit: DEFAULT_LIMIT })
-        .catch(() => []);
+    const all = await safeRead(() => categoriesRepository.listByType("bundle", {
+        activeOnly: true,
+        limit: DEFAULT_LIMIT,
+    }), { route: "/bundles", key: "categories.listByType(bundle)", fallback: [] });
     const bundles = storeId
         ? all.filter((c) => c.createdByStoreId === storeId)
         : all;

package/dist/features/reviews/components/ReviewsIndexPageView.js

@@ -4,6 +4,7 @@ import { reviewRepository } from "../../../repositories";
 import { Container, Heading, Main, Section } from "../../../ui";
 import { AdSlot } from "../../homepage/components/AdSlot";
 import { ReviewsIndexListing } from "./ReviewsIndexListing";
+import { safeRead } from "../../../errors/safe-read";
 function sp(params, key) {
     const v = params[key];
     return Array.isArray(v) ? v[0] ?? "" : v ?? "";
@@ -39,9 +40,7 @@ export async function ReviewsIndexPageView({ searchParams = {} }) {
     const sort = sp(searchParams, "sort") || "-createdAt";
     const page = Number(sp(searchParams, "page")) || 1;
     const filters = buildReviewFilters(searchParams);
-    const result = await reviewRepository
-        .listAll({ filters, sorts: sort, page, pageSize: 12 })
-        .catch(() => null);
+    const result = await safeRead(() => reviewRepository.listAll({ filters, sorts: sort, page, pageSize: 12 }), { route: "/reviews", key: "reviews.listAll", fallback: null });
     const initialData = result
         ? {
             items: result.items,

package/dist/features/stores/components/StoreBundlesPageView.js

@@ -2,6 +2,7 @@ import { jsx as _jsx } from "react/jsx-runtime";
 import { categoriesRepository } from "../../../repositories";
 import { getStoreBySlug } from "./StoreDetailLayoutView";
 import { CategoryBundlesListing } from "../../categories/components/CategoryBundlesListing";
+import { safeRead } from "../../../errors/safe-read";
 /**
  * Public store → Bundles tab.
  *
@@ -16,9 +17,12 @@ export async function StoreBundlesPageView({ storeSlug, onBuyNow, }) {
     if (!storeId) {
         return null;
     }
-    const bundles = await categoriesRepository
+    const bundles = await safeRead(() => categoriesRepository
         .listByType("bundle", { activeOnly: true, limit: 50 })
-        .then((rows) => rows.filter((c) => c.createdByStoreId === storeId))
-        .catch(() => []);
+        .then((rows) => rows.filter((c) => c.createdByStoreId === storeId)), {
+        route: "/stores/[storeSlug]/bundles",
+        key: "categories.listByType(bundle)",
+        fallback: [],
+    });
     return _jsx(CategoryBundlesListing, { initialBundles: bundles, onBuyNow: onBuyNow });
 }

package/dist/features/stores/components/StoresIndexPageView.js

@@ -3,6 +3,7 @@ import { storeRepository } from "../../../repositories";
 import { Container, Heading, Main, Section } from "../../../ui";
 import { AdSlot } from "../../homepage/components/AdSlot";
 import { StoresIndexListing } from "./StoresIndexListing";
+import { safeRead } from "../../../errors/safe-read";
 function sp(params, key) {
     const v = params[key];
     return Array.isArray(v) ? v[0] ?? "" : v ?? "";
@@ -11,8 +12,6 @@ export async function StoresIndexPageView({ searchParams = {} }) {
     const sort = sp(searchParams, "sort") || "-createdAt";
     const page = Number(sp(searchParams, "page")) || 1;
     const pageSize = Number(sp(searchParams, "pageSize")) || 24;
-    const result = await storeRepository
-        .listStores({ page, pageSize, sorts: sort }, true)
-        .catch(() => null);
+    const result = await safeRead(() => storeRepository.listStores({ page, pageSize, sorts: sort }, true), { route: "/stores", key: "stores.listStores", fallback: null });
     return (_jsx(Main, { children: _jsx(Section, { padding: "y-2xl", children: _jsxs(Container, { size: "xl", children: [_jsx(Heading, { level: 1, className: "mb-8", color: "primary", size: "3xl", weight: "semibold", children: "Stores" }), _jsx(AdSlot, { id: "listing-sidebar-top", className: "mb-6" }), _jsx(StoresIndexListing, { initialData: result ?? undefined }), _jsx(AdSlot, { id: "listing-sidebar-bottom", className: "mt-8" })] }) }) }));
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mohasinac/appkit",
-  "version": "4.32.1",
+  "version": "4.32.3",
   "license": "MIT",
   "publishConfig": {
     "access": "public"