@mohasinac/appkit 4.30.19 → 4.31.0

package/dist/features/seller/actions/offer-actions.js

@@ -14,12 +14,10 @@ import { storeRepository } from "../../stores/repository/store.repository";
 import { cartRepository } from "../../cart/repository/cart.repository";
 import { maskOfferForSeller } from "../../../security";
 import { ERROR_MESSAGES, AuthorizationError, ValidationError, NotFoundError, OFFER_ERROR_CODES, } from "../../../errors";
-import { siteSettingsRepository } from "../../admin/repository/site-settings.repository";
-import { safeRead } from "../../../errors/safe-read";
 import { canMakeOffer } from "../../../_internal/shared/listing-types/capabilities";
 import { normalizeListingType } from "../../products/utils/listing-type";
 import { OfferStatusValues } from "../schemas";
-import { DEFAULT_MIN_OFFER_PERCENT, minOfferAmount, } from "../../../_internal/shared/features/offers/config";
+import { DEFAULT_MIN_OFFER_PERCENT, offerIsOnlyPurchasePath, offersEnabledFor, resolveOfferBounds, } from "../../../_internal/shared/features/offers/config";
 /**
  * How long an accepted offer stays claimable at its locked price. Shared by the
  * seller-accept path, the buyer-accepts-counter path, and the expiry sweep so
@@ -32,38 +30,59 @@ const ERR_NOT_AUTHORISED = "Not authorized";
 export async function makeOffer(userId, userEmail, input) {
     const { productId, offerAmount, buyerNote } = input;
     /**
-     * Three independent gates, checked in widening-to-narrowing order. Only
-     * `makeOffer` is guarded — switching the site flag off must stop NEW offers
-     * without stranding in-flight ones, so accept/decline/counter/withdraw and
-     * `checkoutOffer` deliberately stay open.
+     * Two independent gates, checked in widening-to-narrowing order: the listing
+     * type's `canMakeOffer` capability, then the seller's own `allowOffers`
+     * opt-in.
+     *
+     * There was a third — the site-wide `featureFlags.offers` kill switch — which
+     * cost a Firestore singleton read on every offer attempt. It went with the
+     * rest of that group on 2026-08-29. The two that remain are the ones somebody
+     * actually sets: a per-type capability and a per-listing choice by the seller
+     * who owns the item.
+     *
+     * Both now go through `offersEnabledFor` / `resolveOfferBounds`, which the
+     * buyer's form reads too — the whole point of moving the rule into the shared
+     * config. A second copy here is how the form came to advertise a 50% floor
+     * this function then rejected (see the config's own header).
      */
-    // Fails OPEN — a settings read that dies must not block offers site-wide. But
-    // `null` here is indistinguishable from "the flag is on", so it is recorded.
-    const settings = await safeRead(() => siteSettingsRepository.getSingleton(), {
-        route: "offers.makeOffer", key: "makeOffer.siteSettings", fallback: null,
-    });
-    if (settings?.featureFlags?.offers === false) {
-        throw new ValidationError(ERROR_MESSAGES.OFFER.DISABLED, {
-            code: OFFER_ERROR_CODES.DISABLED,
-        });
-    }
     const product = await productRepository.findById(productId);
     if (!product)
         throw new NotFoundError(ERROR_MESSAGES.PRODUCT.NOT_FOUND);
+    const listingType = normalizeListingType(product);
     // Some listing types cannot be negotiated at all — an auction already has
     // bidding, a prize-draw sells fixed-price entries. This was never checked, so
     // an offer could be (and in seed data was) attached to an auction, producing
     // a cart line that claims `listingType: "standard"` in the offer lane.
-    if (!canMakeOffer(normalizeListingType(product))) {
+    if (!canMakeOffer(listingType)) {
         throw new ValidationError("Offers aren't available for this kind of listing.");
     }
-    if (!product.allowOffers)
+    if (!offersEnabledFor(listingType, product.allowOffers))
         throw new ValidationError("This product does not accept offers.");
-    const minAllowed = minOfferAmount(product.price, product.minOfferPercent);
-    if (offerAmount < minAllowed)
-        throw new ValidationError(`Minimum offer is ₹${minAllowed} (${product.minOfferPercent ?? DEFAULT_MIN_OFFER_PERCENT}% of listing price).`);
-    if (offerAmount >= product.price)
-        throw new ValidationError("Your offer must be below the listed price. Use Add to Cart instead.");
+    const bounds = resolveOfferBounds({
+        listingType,
+        listedPrice: product.price,
+        minOfferPercent: product.minOfferPercent,
+        allowOffers: product.allowOffers,
+    });
+    if (bounds.isBuyRequest) {
+        // No cart on this type and the seller has not opted into haggling, so the
+        // asking price is the only legal amount. Naming that plainly beats a
+        // "minimum offer is ₹X" message where X happens to equal the price.
+        if (offerAmount !== bounds.max)
+            throw new ValidationError(`This seller is not taking lower offers — send a request to buy at ₹${bounds.max}.`);
+    }
+    else {
+        if (offerAmount < bounds.min)
+            throw new ValidationError(`Minimum offer is ₹${bounds.min} (${product.minOfferPercent ?? DEFAULT_MIN_OFFER_PERCENT}% of listing price).`);
+        if (offerAmount > bounds.max)
+            throw new ValidationError(
+            // Deliberately NOT "use Add to Cart instead" unconditionally: on a
+            // listing whose only purchase path is an offer there is no cart button,
+            // so that advice named a control the page does not have.
+            offerIsOnlyPurchasePath(listingType)
+                ? `Your offer cannot exceed the asking price of ₹${product.price}.`
+                : "Your offer must be below the listed price. Use Add to Cart instead.");
+    }
     const offerCount = await offerRepository.countByBuyerAndProduct(userId, productId, product.updatedAt);
     if (offerCount >= 3)
         throw new ValidationError(ERROR_MESSAGES.OFFER.LIMIT_REACHED);

package/dist/features/seller/actions/seller-actions.js

@@ -9,7 +9,7 @@
  * (src/actions/seller.actions.ts) alongside the other seller server actions.
  */
 import { serverLogger } from "../../../monitoring";
-import { isAdminUser, isSellerUser } from "../../auth/role-predicates";
+import { isAdminUser, isStrictSellerUser, isTesterUser } from "../../auth/role-predicates";
 import { ApiError, AuthorizationError, NotFoundError, ValidationError, } from "../../../errors";
 import { userRepository } from "../../auth/repository/user.repository";
 import { storeRepository } from "../../stores/repository/store.repository";
@@ -53,16 +53,40 @@ function maskAccountNumber(accountNumber) {
 // --- Become Seller ------------------------------------------------------------
 export async function becomeSeller(userId) {
     const profile = await userRepository.findById(userId);
-    if (profile && (isSellerUser(profile) || isAdminUser(profile))) {
+    const isTester = isTesterUser(profile);
+    /*
+     * 🛑 `isStrictSellerUser`, not `isSellerUser`.
+     *
+     * `isSellerUser` now answers true for the `tester` role — testers own real
+     * stores and must clear every seller gate. But that makes it the WRONG test
+     * here: a brand-new tester has role `tester` from the moment they are
+     * flagged, so an early return keyed on it would send them straight back with
+     * `storeStatus: "pending"` and they would never reach the auto-approve below.
+     * The tester sandbox depends on that approval.
+     *
+     * A tester who HAS already onboarded is caught by the `storeStatus` clause,
+     * so this stays idempotent for them.
+     */
+    const alreadyOnboarded = profile &&
+        (isStrictSellerUser(profile) ||
+            isAdminUser(profile) ||
+            (isTester && Boolean(profile.storeStatus)));
+    if (alreadyOnboarded) {
         return {
             alreadySeller: true,
             storeStatus: profile.storeStatus ??
                 "pending",
         };
     }
-    const storeStatus = profile?.isTester ? "approved" : "pending";
+    const storeStatus = isTester ? "approved" : "pending";
     await userRepository.update(userId, {
-        role: "seller",
+        // 🛑 A tester must NOT be demoted to `seller` here. `tester` is a peer of
+        // `seller` in the hierarchy and already clears every seller gate
+        // (`isSellerUser` returns true for it), so overwriting the role would
+        // silently strip their tester identity — and with it the Tester Hub and
+        // the test-data visibility their whole programme depends on — the first
+        // time they opened a store.
+        ...(isTester ? {} : { role: "seller" }),
         storeStatus,
     });
     serverLogger.info("becomeSeller: application submitted", { userId, storeStatus });
@@ -83,7 +107,7 @@ export async function createStore(userId, userName, input) {
         storeSlug = `${baseSlug.slice(0, 80 - suffix.length)}${suffix}`;
     }
     const profile = await userRepository.findById(userId);
-    const isTester = profile?.isTester === true;
+    const isTester = isTesterUser(profile);
     const store = await storeRepository.create({
         storeSlug,
         ownerId: userId,

package/dist/features/seller/components/CategoryChipPicker.d.ts

@@ -0,0 +1,9 @@
+import React from "react";
+export interface CategoryChipPickerProps {
+    selected: string[];
+    onSelectedChange: (next: string[]) => void;
+    /** Copy under the control. Defaults to the coupon wording. */
+    emptyHint?: string;
+    allowCreate?: boolean;
+}
+export declare function CategoryChipPicker({ selected, onSelectedChange, emptyHint, allowCreate, }: CategoryChipPickerProps): React.JSX.Element;

package/dist/features/seller/components/CategoryChipPicker.js

@@ -0,0 +1,12 @@
+"use client";
+import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
+import { IconButton, Row, Span, Stack, Text } from "../../../ui";
+import { CategoryInlineSelect } from "./CategoryInlineSelect";
+export function CategoryChipPicker({ selected, onSelectedChange, emptyHint = "Leave empty to apply to every category.", allowCreate = false, }) {
+    const add = (id) => {
+        if (!id || selected.includes(id))
+            return;
+        onSelectedChange([...selected, id]);
+    };
+    return (_jsxs(Stack, { gap: "xs", children: [_jsx(CategoryInlineSelect, { value: "", onChange: add, allowCreate: allowCreate, placeholder: "Add a category\u2026" }), selected.length > 0 && (_jsx(Row, { wrap: true, gap: "sm", padding: "t-2xs", children: selected.map((cid) => (_jsxs(Span, { layout: "inline-flex", gap: "xs", border: "strong", padding: "pill-sm", rounded: "full", surface: "muted", color: "primary", size: "xs", children: [cid, _jsx(IconButton, { "aria-label": `Remove ${cid}`, variant: "ghost", size: "sm", onClick: () => onSelectedChange(selected.filter((c) => c !== cid)), icon: "\u00D7" })] }, cid))) })), _jsx(Text, { size: "xs", color: "muted", children: emptyHint })] }));
+}

package/dist/features/seller/components/SellerAddressesView.js

@@ -146,5 +146,9 @@ export function SellerAddressesView({ apiBase = SELLER_ENDPOINTS.STORE_ADDRESSES
     return (_jsxs(Div, { className: "min-h-screen", children: [_jsx(StickyToolbar, { offset: "header", tone: "default", border: true, padding: "md", children: _jsxs(Row, { justify: "between", children: [_jsxs(Stack, { gap: "none", children: [_jsx(Heading, { level: 2, size: "base", weight: "semibold", color: "primary", children: "Pickup Addresses" }), _jsx(Text, { size: "xs", color: "muted", className: "mt-0.5", children: "Manage your store's pickup and return locations" })] }), _jsxs(Row, { gap: "sm", align: "center", children: [_jsx(TextLink, { href: String(ROUTES.STORE.ADDRESSES_NEW), children: "Open full page \u2192" }), _jsxs(Button, { gap: "sm", size: "sm", onClick: openAdd, children: [_jsx(Plus, { className: "h-4 w-4" }), _jsx(Span, { children: "Add Address" })] })] })] }) }), _jsxs(Div, { paddingX: "x-md-lg", className: "max-w-2xl", padding: "y-lg", children: [errorMessage && (_jsx(Div, { textSize: "sm", className: "mb-4 border border-error/20", color: "error", surface: "danger-surface", padding: "inline", rounded: "xl", children: errorMessage })), isLoading ? (_jsx(Row, { justify: "center", padding: "y-4xl", children: _jsx(Div, { className: "h-6 w-6 animate-spin border-2 border-[var(--appkit-color-primary)] border-t-transparent", rounded: "full" }) })) : addresses.length === 0 ? (_jsxs(Stack, { border: "default", className: "border-2 border-dashed", padding: "y-4xl", align: "center", gap: "3", rounded: "xl", children: [_jsx(MapPin, { className: "h-8 w-8 text-[var(--appkit-color-text-muted)]" }), _jsx(Text, { size: "sm", color: "muted", children: "No pickup addresses yet" }), _jsx(Button, { size: "sm", variant: "outline", onClick: openAdd, children: "Add your first address" })] })) : (_jsxs(_Fragment, { children: [_jsxs(Row, { justify: "end", className: "mb-2", children: [_jsx(Button, { size: "sm", variant: listView === "table" ? "primary" : "ghost", onClick: () => setListView("table"), children: "Table" }), _jsx(Button, { size: "sm", variant: listView === "cards" ? "primary" : "ghost", onClick: () => setListView("cards"), children: "Cards" })] }), listView === "cards" ? (_jsx(Grid, { gap: "sm", children: addresses.map((addr) => (_jsx(Div, { className: deletingId === addr.id ? "opacity-50 pointer-events-none" : "", children: _jsx(AddressCard, { address: addr, onEdit: () => openEdit(addr), onDelete: () => handleDelete(addr) }) }, addr.id))) })) : (_jsx(Div, { className: `${__O.xAuto}`, rounded: "lg", border: "default", children: _jsxs(Table, { size: "sm", children: [_jsx(Thead, { surface: "muted", children: _jsxs(Tr, { children: [_jsx(Th, { className: "text-left", padding: "sm", weight: "semibold", children: "Label" }), _jsx(Th, { className: "text-left", padding: "sm", weight: "semibold", children: "Name" }), _jsx(Th, { className: "text-left", padding: "sm", weight: "semibold", children: "City" }), _jsx(Th, { className: "text-left", padding: "sm", weight: "semibold", children: "Phone" }), _jsx(Th, { className: "text-right", padding: "sm", weight: "semibold", children: "Actions" })] }) }), _jsx(Tbody, { children: addresses.map((addr) => {
                                                 const isBanned = addr.banStatus === "banned";
                                                 return (_jsxs(Tr, { className: `border-t border-[var(--appkit-color-border)] ${deletingId === addr.id ? "opacity-50" : ""}`, children: [_jsx(Td, { padding: "sm", children: _jsxs(Row, { gap: "xs", align: "center", children: [_jsx(Span, { children: addr.label }), isBanned && _jsx(Badge, { variant: "danger", size: "sm", children: "Banned" })] }) }), _jsx(Td, { padding: "sm", children: addr.fullName }), _jsxs(Td, { padding: "sm", children: [addr.city, ", ", addr.state] }), _jsx(Td, { className: "tabular-nums", padding: "sm", children: addr.phone }), _jsx(Td, { className: "text-right", padding: "sm", children: isBanned ? (_jsx(Span, { size: "xs", color: "muted", title: "Contact support to resolve address ban", children: "Contact support" })) : (_jsxs(Row, { justify: "end", gap: "xs", children: [_jsx(Button, { size: "sm", variant: "ghost", onClick: () => openEdit(addr), children: ROW_ACTION_META[ROW_ACTION_ID.EDIT].label }), _jsx(Button, { size: "sm", variant: "ghost", onClick: () => handleDelete(addr), children: ROW_ACTION_META[ROW_ACTION_ID.DELETE].label })] })) })] }, addr.id));
-                                            }) })] }) }))] }))] }), _jsx(SideDrawer, { isOpen: drawerOpen, onClose: closeDrawer, title: editingId ? "Edit Address" : "Add Address", footer: _jsxs(Row, { gap: "xs", children: [_jsx(Button, { variant: "outline", onClick: closeDrawer, className: "flex-1", children: "Cancel" }), _jsx(Button, { onClick: handleSave, disabled: saving, className: "flex-1", children: saving ? "Saving…" : editingId ? "Save Changes" : "Add Address" })] }), children: _jsxs(Stack, { gap: "md", padding: "y-2xs", children: [saveError && (_jsx(Div, { textSize: "sm", className: "border border-error/20", color: "error", surface: "danger-surface", padding: "inlineSm", rounded: "lg", children: saveError })), _jsx(FieldInput, { name: "label", label: "Label *", hint: "e.g. Warehouse, Shop, Home", type: "text", value: draft.label, onChange: setField("label"), placeholder: "Warehouse", maxLength: 60 }), _jsxs(Grid, { cols: 2, gap: "sm", children: [_jsx(FieldInput, { name: "fullName", label: "Full Name *", type: "text", value: draft.fullName, onChange: setField("fullName"), placeholder: "Ravi Kumar", maxLength: 100 }), _jsx(FieldInput, { name: "phone", label: "Phone *", type: "tel", value: draft.phone, onChange: setField("phone"), placeholder: "+91 98765 43210", maxLength: 20 })] }), _jsx(FieldInput, { name: "addressLine1", label: "Address Line 1 *", type: "text", value: draft.addressLine1, onChange: setField("addressLine1"), placeholder: "Shop 12, Main Market", maxLength: 200 }), _jsx(FieldInput, { name: "addressLine2", label: "Address Line 2", type: "text", value: draft.addressLine2, onChange: setField("addressLine2"), placeholder: "Building / Floor (optional)", maxLength: 200 }), _jsx(FieldInput, { name: "landmark", label: "Landmark", type: "text", value: draft.landmark, onChange: setField("landmark"), placeholder: "Near metro station (optional)", maxLength: 100 }), _jsxs(Grid, { cols: 2, gap: "sm", children: [_jsx(FieldInput, { name: "city", label: "City *", type: "text", value: draft.city, onChange: setField("city"), placeholder: "Mumbai", maxLength: 100 }), _jsx(FieldInput, { name: "state", label: "State *", type: "text", value: draft.state, onChange: setField("state"), placeholder: "Maharashtra", maxLength: 100 })] }), _jsxs(Grid, { cols: 2, gap: "sm", children: [_jsx(FieldInput, { name: "postalCode", label: "Postal Code *", type: "text", value: draft.postalCode, onChange: setField("postalCode"), placeholder: "400001", maxLength: 10 }), _jsx(FieldInput, { name: "country", label: "Country *", type: "text", value: draft.country, onChange: setField("country"), placeholder: "India", maxLength: 60 })] }), _jsx(FieldCheckbox, { name: "isDefault", label: "Set as default pickup address", checked: draft.isDefault, onChange: (c) => set("isDefault", c) })] }) }), deleteTargetAddr && (_jsx(ConfirmDeleteModal, { isOpen: true, title: "Delete Address", message: `Delete address "${deleteTargetAddr.label}"? This cannot be undone.`, onConfirm: () => { deleteById(deleteTargetAddr.id); setDeleteTargetAddr(null); }, onClose: () => setDeleteTargetAddr(null), isDeleting: deletingId === deleteTargetAddr.id }))] }));
+                                            }) })] }) }))] }))] }), _jsx(SideDrawer, { isOpen: drawerOpen, onClose: closeDrawer, title: editingId ? "Edit Address" : "Add Address", footer: 
+                /* Bare buttons — the SideDrawer footer slot supplies the ActionRow.
+                   The `flex-1` these carried would have beaten its sizing under
+                   `important: true`. */
+                _jsxs(_Fragment, { children: [_jsx(Button, { variant: "outline", onClick: closeDrawer, children: "Cancel" }), _jsx(Button, { onClick: handleSave, disabled: saving, children: saving ? "Saving…" : editingId ? "Save Changes" : "Add Address" })] }), children: _jsxs(Stack, { gap: "md", padding: "y-2xs", children: [saveError && (_jsx(Div, { textSize: "sm", className: "border border-error/20", color: "error", surface: "danger-surface", padding: "inlineSm", rounded: "lg", children: saveError })), _jsx(FieldInput, { name: "label", label: "Label *", hint: "e.g. Warehouse, Shop, Home", type: "text", value: draft.label, onChange: setField("label"), placeholder: "Warehouse", maxLength: 60 }), _jsxs(Grid, { cols: 2, gap: "sm", children: [_jsx(FieldInput, { name: "fullName", label: "Full Name *", type: "text", value: draft.fullName, onChange: setField("fullName"), placeholder: "Ravi Kumar", maxLength: 100 }), _jsx(FieldInput, { name: "phone", label: "Phone *", type: "tel", value: draft.phone, onChange: setField("phone"), placeholder: "+91 98765 43210", maxLength: 20 })] }), _jsx(FieldInput, { name: "addressLine1", label: "Address Line 1 *", type: "text", value: draft.addressLine1, onChange: setField("addressLine1"), placeholder: "Shop 12, Main Market", maxLength: 200 }), _jsx(FieldInput, { name: "addressLine2", label: "Address Line 2", type: "text", value: draft.addressLine2, onChange: setField("addressLine2"), placeholder: "Building / Floor (optional)", maxLength: 200 }), _jsx(FieldInput, { name: "landmark", label: "Landmark", type: "text", value: draft.landmark, onChange: setField("landmark"), placeholder: "Near metro station (optional)", maxLength: 100 }), _jsxs(Grid, { cols: 2, gap: "sm", children: [_jsx(FieldInput, { name: "city", label: "City *", type: "text", value: draft.city, onChange: setField("city"), placeholder: "Mumbai", maxLength: 100 }), _jsx(FieldInput, { name: "state", label: "State *", type: "text", value: draft.state, onChange: setField("state"), placeholder: "Maharashtra", maxLength: 100 })] }), _jsxs(Grid, { cols: 2, gap: "sm", children: [_jsx(FieldInput, { name: "postalCode", label: "Postal Code *", type: "text", value: draft.postalCode, onChange: setField("postalCode"), placeholder: "400001", maxLength: 10 }), _jsx(FieldInput, { name: "country", label: "Country *", type: "text", value: draft.country, onChange: setField("country"), placeholder: "India", maxLength: 60 })] }), _jsx(FieldCheckbox, { name: "isDefault", label: "Set as default pickup address", checked: draft.isDefault, onChange: (c) => set("isDefault", c) })] }) }), deleteTargetAddr && (_jsx(ConfirmDeleteModal, { isOpen: true, title: "Delete Address", message: `Delete address "${deleteTargetAddr.label}"? This cannot be undone.`, onConfirm: () => { deleteById(deleteTargetAddr.id); setDeleteTargetAddr(null); }, onClose: () => setDeleteTargetAddr(null), isDeleting: deletingId === deleteTargetAddr.id }))] }));
 }

package/dist/features/seller/components/SellerAnalyticsAlertsView.js

@@ -1,27 +1,44 @@
 "use client";
 import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
 import { useApiMutation } from "@mohasinac/appkit/client";
-import { useState, useCallback } from "react";
+import React, { useState, useCallback } from "react";
 import { useQuery, useQueryClient } from "@tanstack/react-query";
-import { Alert, Badge, Button, Div, Form, FormActions, Heading, Input, Row, Section, Select, Stack, Text, Toggle, useToast } from "../../../ui";
+import { Alert, Badge, Button, Div, Heading, Row, Section, Stack, Text, Toggle, useToast } from "../../../ui";
 import { apiClient } from "../../../http";
 import { SELLER_ENDPOINTS } from "../../../constants/api-endpoints";
-import { analyticsAlertCreateSchema } from "../../store-extensions/schemas/analytics-forms";
+import { analyticsAlertCreateSchema, ANALYTICS_ALERT_OPERATORS, } from "../../store-extensions/schemas/analytics-forms";
 import { FormErrorSummary } from "../../../ui/forms/FormErrorSummary";
-import { ValidationError } from "../../../errors/validation-error";
+import { FormShellContext, useFormShellState } from "../../../ui/forms/FormShell";
+import { applyZodIssues } from "../../../ui/forms/apply-zod-issues";
+import { buildSectionsFromSchema, visibleValues } from "../../shell/build-sections";
+import { SectionForm, useSectionFormNav } from "../../shell/SectionForm";
+import { ACTIONS } from "../../../_internal/shared/actions/action-registry";
 const __P = {
     p5: "p-[var(--appkit-space-5)]",
 };
 // ---------------------------------------------------------------------------
 // Config
 // ---------------------------------------------------------------------------
-const OPERATOR_OPTIONS = [
-    { value: ">", label: "Greater than (>)" },
-    { value: "<", label: "Less than (<)" },
-    { value: ">=", label: "≥" },
-    { value: "<=", label: "≤" },
-    { value: "==", label: "Equals (==)" },
-];
+/**
+ * Operators, DERIVED from the schema's own list.
+ *
+ * The hand-written array had five of the six — `!=` was missing, so "not equal
+ * to" could never be chosen although `ALERT_OPERATOR_MAP` declares it and the
+ * route accepts it. That map is a `Record<AlertOperator, true>` precisely so
+ * the union cannot drift; the drift moved into the UI copy instead.
+ */
+const OPERATOR_LABELS = {
+    ">": "Greater than (>)",
+    "<": "Less than (<)",
+    ">=": "At least (≥)",
+    "<=": "At most (≤)",
+    "==": "Equals (==)",
+    "!=": "Not equal to (≠)",
+};
+const OPERATOR_OPTIONS = ANALYTICS_ALERT_OPERATORS.map((value) => ({
+    value,
+    label: OPERATOR_LABELS[value] ?? value,
+}));
 const METRIC_OPTIONS = [
     { value: "daily_revenue", label: "Daily Revenue (₹)" },
     { value: "daily_orders", label: "Daily Orders" },
@@ -57,7 +74,7 @@ function AlertCard({ alert, onToggle, onDelete, }) {
     const metricLabel = METRIC_OPTIONS.find((m) => m.value === alert.metric)?.label ?? alert.metric;
     const opLabel = OPERATOR_OPTIONS.find((o) => o.value === alert.operator)?.label ?? alert.operator;
     const windowLabel = WINDOW_OPTIONS.find((w) => w.value === String(alert.windowHours))?.label ?? `${alert.windowHours}h`;
-    return (_jsxs(Row, { surface: "card", padding: "sm", align: "start", justify: "between", gap: "md", children: [_jsxs(Div, { className: "flex-1 min-w-0", children: [_jsxs(Row, { className: "mb-1", gap: "sm", wrap: true, children: [_jsx(Text, { size: "sm", weight: "medium", color: "primary", children: alert.label }), _jsx(Badge, { variant: alert.isActive ? "success" : "default", children: alert.isActive ? "Active" : "Paused" })] }), _jsxs(Text, { className: "mb-1", color: "muted", size: "xs", children: [metricLabel, " ", opLabel, " ", alert.threshold, " \u00B7 ", windowLabel] }), _jsx(Row, { gap: "xs", wrap: true, children: alert.notifyChannels.map((ch) => (_jsx(Badge, { variant: OPERATOR_BADGE[alert.operator] ?? "default", children: ch }, ch))) }), alert.lastTriggeredAt && (_jsxs(Text, { className: "mt-1", color: "faint", size: "xs", children: ["Last triggered: ", new Date(alert.lastTriggeredAt).toLocaleString("en-IN")] }))] }), _jsxs(Row, { className: "shrink-0", align: "center", gap: "sm", children: [_jsx(Toggle, { checked: alert.isActive, onChange: (v) => onToggle(alert.id, v), size: "sm" }), _jsx(Button, { variant: "ghost", size: "sm", onClick: () => onDelete(alert.id), className: "text-error hover:text-error", children: "Delete" })] })] }));
+    return (_jsxs(Row, { surface: "card", padding: "sm", align: "start", justify: "between", gap: "md", children: [_jsxs(Div, { className: "flex-1 min-w-0", children: [_jsxs(Row, { className: "mb-1", gap: "sm", wrap: true, children: [_jsx(Text, { size: "sm", weight: "medium", color: "primary", children: alert.label }), _jsx(Badge, { variant: alert.isActive ? "success" : "default", children: alert.isActive ? "Active" : "Paused" })] }), _jsxs(Text, { className: "mb-1", color: "muted", size: "xs", children: [metricLabel, " ", opLabel, " ", alert.threshold, " \u00B7 ", windowLabel] }), _jsx(Row, { gap: "xs", wrap: true, children: alert.notifyChannels.map((ch) => (_jsx(Badge, { variant: OPERATOR_BADGE[alert.operator] ?? "default", children: ch }, ch))) }), alert.lastTriggeredAt && (_jsxs(Text, { className: "mt-1", color: "faint", size: "xs", children: ["Last triggered: ", new Date(alert.lastTriggeredAt).toLocaleString("en-IN")] }))] }), _jsxs(Row, { className: "shrink-0", align: "center", gap: "sm", children: [_jsx(Toggle, { checked: alert.isActive, onChange: (v) => onToggle(alert.id, v), size: "sm" }), _jsx(Button, { variant: "ghost", size: "sm", action: ACTIONS.STORE["delete-analytics-alert"], onClick: () => onDelete(alert.id), className: "text-error hover:text-error" })] })] }));
 }
 const EMPTY_DRAFT = {
     label: "",
@@ -66,7 +83,17 @@ const EMPTY_DRAFT = {
     threshold: "",
     windowHours: "24",
     notifyChannels: ["in-app"],
+    isActive: true,
 };
+/**
+ * The delivery-channel chips.
+ *
+ * Module level rather than an inline renderer — an inline one's handler sits
+ * six braces deep inside `useMemo`, which is DEEP_NESTING's whole subject.
+ */
+function ChannelChips({ selected, onToggle, }) {
+    return (_jsxs(Stack, { gap: "xs", children: [_jsx(Text, { color: "muted", size: "xs", weight: "medium", children: "Notify via" }), _jsx(Row, { gap: "sm", wrap: true, children: CHANNEL_OPTIONS.map((ch) => (_jsx(Button, { variant: selected.includes(ch.value) ? "primary" : "outline", type: "button", onClick: () => onToggle(ch.value), rounded: "full", paddingX: "sm", paddingY: "xs", textSize: "xs", children: ch.label }, ch.value))) })] }));
+}
 export function SellerAnalyticsAlertsView({ labels = {}, }) {
     const queryClient = useQueryClient();
     const { showToast } = useToast();
@@ -82,31 +109,7 @@ export function SellerAnalyticsAlertsView({ labels = {}, }) {
     const alerts = data ?? [];
     const createMutation = useApiMutation({
         errorMessage: "Failed to create alert",
-        mutationFn: async () => {
-            /*
-             * Parsed against the SAME schema the route uses, before the request.
-             *
-             * This form used to hand-build its payload and included `scope: "seller"`
-             * — a field the route pins from the session and the schema does not
-             * declare. Once that schema became `.strict()`, every "Create Alert"
-             * became a 400, and nothing local could have caught it: the client had
-             * no schema to check against. Parsing here is the structural fix, not
-             * the deletion of one key.
-             */
-            const parsed = analyticsAlertCreateSchema.safeParse({
-                label: draft.label,
-                metric: draft.metric,
-                operator: draft.operator,
-                threshold: draft.threshold,
-                windowHours: draft.windowHours,
-                notifyChannels: draft.notifyChannels,
-                isActive: true,
-            });
-            if (!parsed.success) {
-                throw new ValidationError(parsed.error.issues[0]?.message ?? "Invalid alert", parsed.error.issues);
-            }
-            return apiClient.post(SELLER_ENDPOINTS.ANALYTICS_ALERTS, parsed.data);
-        },
+        mutationFn: async (values) => apiClient.post(SELLER_ENDPOINTS.ANALYTICS_ALERTS, values),
         onSuccess: () => {
             showToast("Alert created", "success");
             void queryClient.invalidateQueries({ queryKey: ["seller", "analytics-alerts"] });
@@ -137,10 +140,47 @@ export function SellerAnalyticsAlertsView({ labels = {}, }) {
                 : [...d.notifyChannels, ch],
         }));
     }, []);
-    return (_jsxs(Stack, { gap: "lg", children: [_jsxs(Row, { justify: "between", children: [_jsx(Heading, { level: 2, size: "base", weight: "semibold", color: "primary", children: labels.title ?? "Analytics Alerts" }), _jsx(Button, { size: "sm", onClick: () => setShowForm((v) => !v), children: showForm ? "Cancel" : "+ New Alert" })] }), _jsx(Text, { size: "sm", color: "muted", children: "Get notified when a key metric crosses a threshold. Alerts check the metric over the selected window and fire through your chosen channels." }), showForm && (_jsxs(Section, { className: `${__P.p5} space-y-[1rem]`, rounded: "xl", border: "default", children: [_jsx(Heading, { level: 3, size: "sm", weight: "semibold", color: "primary", children: "Create Alert" }), _jsxs(Form, { schema: analyticsAlertCreateSchema, onSubmit: (e) => {
-                            e.preventDefault();
-                            createMutation.mutate();
-                        }, children: [_jsxs(Div, { layout: "grid", gap: "4", className: "sm:grid-cols-2", children: [_jsx(Input, { label: "Alert label", value: draft.label, onChange: (e) => setDraft((d) => ({ ...d, label: e.target.value })), placeholder: "e.g. Low daily orders", required: true }), _jsx(Select, { label: "Metric", value: draft.metric, onValueChange: (v) => setDraft((d) => ({ ...d, metric: v })), options: METRIC_OPTIONS }), _jsx(Select, { label: "Operator", value: draft.operator, onValueChange: (v) => setDraft((d) => ({ ...d, operator: v })), options: OPERATOR_OPTIONS }), _jsx(Input, { label: "Threshold", type: "number", value: draft.threshold, onChange: (e) => setDraft((d) => ({ ...d, threshold: e.target.value })), placeholder: "e.g. 10", required: true }), _jsx(Select, { label: "Check window", value: draft.windowHours, onValueChange: (v) => setDraft((d) => ({ ...d, windowHours: v })), options: WINDOW_OPTIONS })] }), _jsxs(Div, { className: "mt-3", children: [_jsx(Text, { className: "mb-2", color: "muted", size: "xs", weight: "medium", children: "Notify via" }), _jsx(Row, { gap: "sm", wrap: true, children: CHANNEL_OPTIONS.map((ch) => (_jsx(Button, { variant: "outline", type: "button", onClick: () => toggleChannel(ch.value), rounded: "full", paddingX: "sm", paddingY: "xs", textSize: "xs", className: draft.notifyChannels.includes(ch.value)
-                                                ? "bg-[var(--appkit-color-primary)] text-white border-transparent"
-                                                : "bg-[var(--appkit-color-surface)] text-[var(--appkit-color-text-muted)] border-[var(--appkit-color-border)]", children: ch.label }, ch.value))) })] }), _jsx(FormErrorSummary, {}), _jsx(FormActions, { align: "right", className: "mt-4", children: _jsx(Button, { type: "submit", isLoading: createMutation.isPending, children: createMutation.isPending ? "Creating…" : "Create Alert" }) })] })] })), isLoading && (_jsx(Stack, { gap: "sm", children: [1, 2, 3].map((i) => (_jsx(Div, { className: "h-16 animate-pulse", surface: "subtle", rounded: "lg" }, i))) })), !isLoading && alerts.length === 0 && !showForm && (_jsx(Alert, { variant: "info", children: "No alerts configured. Create an alert to get notified when a key metric crosses a threshold." })), !isLoading && alerts.length > 0 && (_jsx(Stack, { gap: "3", children: alerts.map((alert) => (_jsx(AlertCard, { alert: alert, onToggle: (id, isActive) => toggleMutation.mutate({ id, isActive }), onDelete: (id) => deleteMutation.mutate(id) }, alert.id))) }))] }));
+    const sections = React.useMemo(() => buildSectionsFromSchema(analyticsAlertCreateSchema, {
+        options: {
+            metric: METRIC_OPTIONS,
+            operator: OPERATOR_OPTIONS,
+            windowHours: WINDOW_OPTIONS,
+        },
+        renderers: {
+            notifyChannels: ({ values }) => (_jsx(ChannelChips, { selected: values.notifyChannels, onToggle: toggleChannel })),
+        },
+    }), [toggleChannel]);
+    const nav = useSectionFormNav(sections, draft, { scope: "store:analytics-alert" });
+    const { shellCtx, setFieldError, clearErrors } = useFormShellState(analyticsAlertCreateSchema, {
+        sections: nav.sectionMeta,
+        onGoToSection: nav.goToSection,
+        fieldToSectionIndex: nav.fieldToSectionIndex,
+    });
+    const submitAlert = () => {
+        clearErrors();
+        /*
+         * Parsed against the SAME schema the route uses, before the request.
+         *
+         * This form used to hand-build its payload and included `scope: "seller"`
+         * — a field the route pins from the session and the schema does not
+         * declare. Once that schema became `.strict()`, every "Create Alert"
+         * became a 400, and nothing local could have caught it: the client had no
+         * schema to check against. The parse is the structural fix; what changed
+         * here is only that its issues now reach the fields instead of being
+         * flattened into one thrown message.
+         */
+        const parsed = analyticsAlertCreateSchema.safeParse(visibleValues(analyticsAlertCreateSchema, draft));
+        if (!parsed.success) {
+            applyZodIssues(parsed.error.issues, setFieldError);
+            return;
+        }
+        createMutation.mutate(parsed.data);
+    };
+    return (_jsxs(Stack, { gap: "lg", children: [_jsxs(Row, { justify: "between", children: [_jsx(Heading, { level: 2, size: "base", weight: "semibold", color: "primary", children: labels.title ?? "Analytics Alerts" }), _jsx(Button, { size: "sm", onClick: () => setShowForm((v) => !v), children: showForm ? "Cancel" : "+ New Alert" })] }), _jsx(Text, { size: "sm", color: "muted", children: "Get notified when a key metric crosses a threshold. Alerts check the metric over the selected window and fire through your chosen channels." }), showForm && (_jsxs(Section, { className: `${__P.p5} space-y-[1rem]`, rounded: "xl", border: "default", children: [_jsx(Heading, { level: 3, size: "sm", weight: "semibold", color: "primary", children: "Create Alert" }), _jsxs(FormShellContext.Provider, { value: shellCtx, children: [_jsx(FormErrorSummary, {}), _jsx(SectionForm, { sections: sections, values: draft, onChange: (partial) => setDraft((prev) => ({ ...prev, ...partial })), onSubmit: submitAlert, schema: analyticsAlertCreateSchema, openIds: nav.openIds, onOpenChange: nav.setOpenIds, isLoading: createMutation.isPending, submitLabel: "Create alert", onCancel: () => setShowForm(false), 
+                                /*
+                                 * This panel is one card inside a longer analytics page, not the
+                                 * page's own form — a viewport-pinned Save would claim the
+                                 * bottom tier for a control the reader may have scrolled past.
+                                 */
+                                bottomBar: false })] })] })), isLoading && (_jsx(Stack, { gap: "sm", children: [1, 2, 3].map((i) => (_jsx(Div, { className: "h-16 animate-pulse", surface: "subtle", rounded: "lg" }, i))) })), !isLoading && alerts.length === 0 && !showForm && (_jsx(Alert, { variant: "info", children: "No alerts configured. Create an alert to get notified when a key metric crosses a threshold." })), !isLoading && alerts.length > 0 && (_jsx(Stack, { gap: "3", children: alerts.map((alert) => (_jsx(AlertCard, { alert: alert, onToggle: (id, isActive) => toggleMutation.mutate({ id, isActive }), onDelete: (id) => deleteMutation.mutate(id) }, alert.id))) }))] }));
 }

package/dist/features/seller/components/SellerArtView.d.ts

@@ -1,8 +1,15 @@
+/**
+ * SellerArtView — seller browse/manage of art print listings.
+ *
+ * A named wrapper, kept so the page, the barrel and every existing import path
+ * stay unchanged. All behaviour is `SellerListingTypeView`; everything this
+ * type does differently is one entry in `SELLER_LISTING_TYPE_SPECS`.
+ *
+ * This file was 194 lines of a component that four siblings also contained
+ * verbatim — see that file's header for why the duplication mattered rather
+ * than merely being untidy.
+ */
 import React from "react";
-export interface SellerArtViewProps {
-    onCreateClick?: () => void;
-    onEditClick?: (id: string) => void;
-    onDelete?: (id: string) => Promise<void>;
-    onBulkDelete?: (ids: string[]) => Promise<void>;
-}
-export declare function SellerArtView({ onCreateClick, onEditClick, onDelete, onBulkDelete, }: SellerArtViewProps): React.JSX.Element;
+import { type SellerListingTypeViewProps } from "./SellerListingTypeView";
+export type SellerArtViewProps = SellerListingTypeViewProps;
+export declare function SellerArtView(props: SellerArtViewProps): React.JSX.Element;

package/dist/features/seller/components/SellerArtView.js

@@ -1,121 +1,6 @@
 "use client";
-import { jsx as _jsx, Fragment as _Fragment, jsxs as _jsxs } from "react/jsx-runtime";
-/**
- * SellerArtView — seller browse/manage of art print listings
- * (EMI/art-stickers session). Mirrors SellerClassifiedView's pattern.
- */
-import { Badge, sortBy } from "@mohasinac/appkit/client";
-import { useState, useCallback } from "react";
-import { useEntityDelete } from "../../../react/hooks/useEntityDelete";
-import { ConfirmDeleteModal, RowActionMenu, Text } from "../../../ui";
-import { SELLER_ENDPOINTS } from "../../../constants/api-endpoints";
-import { ACTIONS } from "../../../_internal/shared/actions/action-registry";
-import { ROUTES } from "../../../constants/index";
-import { toRecordArray, toRelativeDate, toCurrency, toStringValue, } from "../../admin/hooks/useAdminListingData";
-import { DataListingView } from "../../admin/components/DataListingView";
-import { SELLER_BULK_ACTIONS, ROW_ACTION_META } from "../../products/constants/action-defs";
-import { useAvailabilityScope } from "../../products/hooks/useAvailabilityScope";
-const LISTING_TYPES = ["art"];
-const COLUMNS = [
-    { key: "title", header: "Listing", render: (row) => _jsx(Text, { size: "sm", weight: "medium", children: row.title }) },
-    { key: "price", header: "Price", render: (row) => _jsx(Text, { className: "tabular-nums", size: "sm", children: row.price }) },
-    {
-        key: "size",
-        header: "Size",
-        render: (row) => _jsx(Text, { className: "text-[var(--appkit-color-text-muted)]", size: "sm", children: row.size || "—" }),
-    },
-    {
-        key: "status",
-        header: "Status",
-        render: (row) => (_jsx(Badge, { variant: row.status === "active" ? "active" : "inactive", size: "xs", className: "capitalize", children: row.status })),
-    },
-    {
-        key: "createdAt",
-        header: "Created",
-        render: (row) => _jsx(Text, { className: "text-[var(--appkit-color-text-muted)]", size: "sm", children: row.createdAt }),
-    },
-];
-export function SellerArtView({ onCreateClick, onEditClick, onDelete, onBulkDelete, }) {
-    const [deleteTargetId, setDeleteTargetId] = useState(null);
-    const { deletingId, handleDelete: performDelete } = useEntityDelete({
-        endpoint: SELLER_ENDPOINTS.PRODUCT_BY_ID,
-        deleteFn: onDelete,
-        successMessage: "Listing deleted.",
-        fetchOptions: { credentials: "include" },
-    });
-    const handleDelete = useCallback(async (id) => {
-        await performDelete(id);
-        setDeleteTargetId(null);
-    }, [performDelete]);
-    const handleEdit = useCallback((id) => {
-        if (onEditClick)
-            onEditClick(id);
-        else
-            window.location.href = String(ROUTES.STORE.ART_EDIT(id));
-    }, [onEditClick]);
-    const handleCreate = useCallback(() => {
-        if (onCreateClick)
-            onCreateClick();
-        else
-            window.location.href = String(ROUTES.STORE.ART_NEW);
-    }, [onCreateClick]);
-    const scope = useAvailabilityScope(LISTING_TYPES);
-    const config = {
-        portal: "seller",
-        title: "Art",
-        searchPlaceholder: "Search art prints...",
-        emptyLabel: "No art listings yet — list your first print",
-        filterKeys: [],
-        defaultSort: sortBy("createdAt", "DESC"),
-        queryKey: ["seller", "art"],
-        endpoint: SELLER_ENDPOINTS.PRODUCTS,
-        sortOptions: [
-            { value: sortBy("createdAt", "DESC"), label: "Newest" },
-            { value: sortBy("createdAt", "ASC"), label: "Oldest" },
-            { value: "title", label: "Name A–Z" },
-            { value: sortBy("price", "ASC"), label: "Price: Low–High" },
-            { value: sortBy("price", "DESC"), label: "Price: High–Low" },
-        ],
-        columns: COLUMNS,
-        mapRows: (response) => toRecordArray(response.products).map((item, index) => {
-            const printMeta = (item.printMeta ?? {});
-            return {
-                id: toStringValue(item.id, `art-${index}`),
-                title: toStringValue(item.productTitle ?? item.title, "Untitled"),
-                price: toCurrency(item.price),
-                size: toStringValue(printMeta.size, ""),
-                status: toStringValue(item.status, "draft"),
-                createdAt: toRelativeDate(item.createdAt),
-            };
-        }),
-        getTotal: (response, mappedRows) => typeof response.meta?.total === "number" ? response.meta.total : mappedRows.length,
-        buildFilters: () => "listingType==art",
-        buildExtraParams: () => scope.extraParams,
-        renderAboveContent: scope.renderAboveContent,
-        primaryAction: { label: "New Art Print", onClick: () => handleCreate() },
-        // Mirrors the "Edit" row action below so table rows and cards both navigate on click.
-        onRowClick: (row) => handleEdit(row.id),
-        // Rule #7: bulk-action array sourced from the SELLER_BULK_ACTIONS preset.
-        buildBulkActions: onBulkDelete
-            ? (selection) => SELLER_BULK_ACTIONS.art.map((id) => ({
-                id,
-                label: ROW_ACTION_META[id].label,
-                destructive: ROW_ACTION_META[id].destructive,
-                onClick: async () => {
-                    await onBulkDelete(selection.selectedIds);
-                    selection.clearSelection();
-                },
-            }))
-            : undefined,
-        renderRowActions: (row) => (_jsx(RowActionMenu, { actions: [
-                { label: ACTIONS.STORE["edit-listing"].label, onClick: () => handleEdit(row.id) },
-                {
-                    label: ACTIONS.STORE["delete-listing"].label,
-                    destructive: true,
-                    onClick: () => setDeleteTargetId(row.id),
-                    disabled: deletingId === row.id,
-                },
-            ] })),
-    };
-    return (_jsxs(_Fragment, { children: [_jsx(DataListingView, { config: config }), deleteTargetId && (_jsx(ConfirmDeleteModal, { isOpen: true, title: "Delete Art Listing", message: "Are you sure you want to delete this art listing? This cannot be undone.", onConfirm: () => handleDelete(deleteTargetId), onClose: () => setDeleteTargetId(null), isDeleting: deletingId === deleteTargetId }))] }));
+import { jsx as _jsx } from "react/jsx-runtime";
+import { SellerListingTypeView, } from "./SellerListingTypeView";
+export function SellerArtView(props) {
+    return _jsx(SellerListingTypeView, { type: "art", ...props });
 }

package/dist/features/seller/components/SellerClassifiedView.d.ts

@@ -1,8 +1,15 @@
+/**
+ * SellerClassifiedView — seller browse/manage of classified listings.
+ *
+ * A named wrapper, kept so the page, the barrel and every existing import path
+ * stay unchanged. All behaviour is `SellerListingTypeView`; everything this
+ * type does differently is one entry in `SELLER_LISTING_TYPE_SPECS`.
+ *
+ * This file was 208 lines of a component that four siblings also contained
+ * verbatim — see that file's header for why the duplication mattered rather
+ * than merely being untidy.
+ */
 import React from "react";
-export interface SellerClassifiedViewProps {
-    onCreateClick?: () => void;
-    onEditClick?: (id: string) => void;
-    onDelete?: (id: string) => Promise<void>;
-    onBulkDelete?: (ids: string[]) => Promise<void>;
-}
-export declare function SellerClassifiedView({ onCreateClick, onEditClick, onDelete, onBulkDelete, }: SellerClassifiedViewProps): React.JSX.Element;
+import { type SellerListingTypeViewProps } from "./SellerListingTypeView";
+export type SellerClassifiedViewProps = SellerListingTypeViewProps;
+export declare function SellerClassifiedView(props: SellerClassifiedViewProps): React.JSX.Element;