@mohasinac/appkit 4.30.18 → 4.31.0

package/dist/_internal/client/hand-mode/HandModeProvider.js

@@ -54,6 +54,8 @@ export function HandModeProvider({ initialHand, children }) {
             }
         }
         catch (_err) {
+            // localStorage unavailable (private-browse) — fall through to the value
+            // readHandPreference() already resolved; there is no preference to honour.
             void normalizeError(_err);
         }
         return stored;

package/dist/_internal/server/features/auctions/actions.js

@@ -1,5 +1,6 @@
 "use server";
 import { wrapAction } from "@mohasinac/appkit/server";
+import { safeRead } from "../../../../errors/safe-read";
 import { bidRepository, productRepository, userRepository, siteSettingsRepository } from "../../../../repositories";
 import { requireRoleUser } from "../../../../providers/auth-firebase/helpers";
 import { placeBidActionSchema } from "../../../shared/features/auctions/schema";
@@ -16,10 +17,20 @@ export async function placeBidAction(input) {
         assertNotAuctionOwner(product, user.uid);
         const settings = await siteSettingsRepository.getSingleton();
         assertBidAmount(product, amount, settings.auctionConfig?.bidIncrementTiers ?? []);
-        const profile = await userRepository.findById(user.uid).catch(() => null);
+        const profile = await safeRead(() => userRepository.findById(user.uid), {
+            route: "auction:placeBid",
+            key: "auctions.placeBid.bidderProfile",
+            fallback: null,
+        });
         const userName = profile?.displayName ?? user.name ?? "Anonymous";
-        // Mark all current bids for this auction as outbid, then set new winning bid
-        await bidRepository.setWinningBid("__placeholder__", auctionId).catch(() => null);
+        // (Removed: a `setWinningBid("__placeholder__", auctionId)` call whose
+        // rejection was swallowed. It accomplished NOTHING. setWinningBid builds a
+        // single batch — mark every bid for the product `outbid`, then update the
+        // winning bid's own doc — and `__placeholder__` is not a real bid id, so
+        // `batch.commit()` always threw and DISCARDED the whole batch, outbid
+        // marking included. It cost a full-collection query and an exception per
+        // bid placed, and the real `setWinningBid(bid.id, …)` below already marks
+        // every other bid for this product as outbid.)
         const bid = await bidRepository.create({
             productId: auctionId,
             productTitle: product.title ?? auctionId,

package/dist/_internal/server/features/auctions/service.js

@@ -4,7 +4,7 @@ import { AuctionNotFoundError, AuctionEndedError, BidTooLowError, BidOnOwnAuctio
 import { AUCTION_SNIPING_WINDOW_SECONDS, AUCTION_DEFAULT_EXTENSION_MINUTES, resolveMinBid, } from "../../../shared/features/auctions/config";
 /** Assert an auction exists, is published, and is still active. Returns the product. */
 export async function assertAuctionActive(auctionId) {
-    const product = await productRepository.findByIdOrSlug(auctionId).catch(() => null);
+    const product = await productRepository.findByIdOrSlug(auctionId);
     if (!product || !isAuctionListing(product))
         throw new AuctionNotFoundError(auctionId);
     const endDate = product.auctionEndDate instanceof Date

package/dist/_internal/server/features/auth/permissions.d.ts

@@ -26,6 +26,8 @@ export declare function checkAnyPermission(resolved: ResolvedPermissions, requir
 type GetUser = () => Promise<{
     uid: string;
     role: string;
+    permissions?: readonly string[] | null;
+    /** @deprecated Legacy tester flags; still read during the migration window. */
     isTester?: boolean;
     canTestAdmin?: boolean;
 } | null>;

package/dist/_internal/server/features/auth/permissions.js

@@ -60,8 +60,9 @@ export function makeAdminSectionLayout(permission, opts) {
             redirect(opts.loginPath ?? String(ROUTES.AUTH.LOGIN));
             return null;
         }
-        // admin role, or a tester explicitly flagged to test admin areas
-        // (isTester && canTestAdmin), passes without a permission check
+        // Admin role, or a tester cleared for admin surfaces (the `tester` role
+        // plus `tester:admin-surfaces`, or the legacy isTester/canTestAdmin pair),
+        // passes without a permission check.
         if (isEffectiveAdminUser(user))
             return children;
         // non-employee non-admin roles have no business in /admin

package/dist/_internal/server/features/blog/data.js

@@ -1,8 +1,8 @@
 import { cache } from "react";
 import { blogRepository } from "../../../../repositories";
 export const getBlogPostForDetail = cache(async (slug) => {
-    return (await blogRepository.findBySlug(slug).catch(() => undefined)) ?? null;
+    return (await blogRepository.findBySlug(slug)) ?? null;
 });
 export const getBlogPostById = cache(async (id) => {
-    return (await blogRepository.findById(id).catch(() => undefined)) ?? null;
+    return (await blogRepository.findById(id)) ?? null;
 });

package/dist/_internal/server/features/blog/service.js

@@ -1,14 +1,14 @@
 import { blogRepository } from "../../../../repositories";
 import { BlogPostNotFoundError, BlogSlugConflictError } from "../../../shared/features/blog/errors";
 export async function assertBlogPostExists(slugOrId) {
-    const post = await blogRepository.findBySlug(slugOrId).catch(() => null)
-        ?? await blogRepository.findById(slugOrId).catch(() => null);
+    const post = await blogRepository.findBySlug(slugOrId)
+        ?? await blogRepository.findById(slugOrId);
     if (!post)
         throw new BlogPostNotFoundError(slugOrId);
     return post;
 }
 export async function assertBlogSlugUnique(slug) {
-    const existing = await blogRepository.findBySlug(slug).catch(() => null);
+    const existing = await blogRepository.findBySlug(slug);
     if (existing)
         throw new BlogSlugConflictError(slug);
 }

package/dist/_internal/server/features/brands/data.js

@@ -6,7 +6,7 @@ import { categoriesRepository } from "../../../../repositories";
  * `BrandDetailPageView` consume the same `CategoryDocument` shape.
  */
 export const getBrandForDetail = cache(async (slug) => {
-    return categoriesRepository.findBySlugAndType(slug, "brand").catch(() => null);
+    return categoriesRepository.findBySlugAndType(slug, "brand");
 });
 /**
  * @deprecated Identical to getBrandForDetail after SB-UNI-C. Kept as an

package/dist/_internal/server/features/brands/service.js

@@ -1,14 +1,14 @@
 import { categoriesRepository } from "../../../../repositories";
 import { BrandNotFoundError, BrandSlugConflictError } from "../../../shared/features/brands/errors";
 export async function assertBrandExists(slugOrId) {
-    const brand = (await categoriesRepository.findBySlugAndType(slugOrId, "brand").catch(() => null)) ??
-        (await categoriesRepository.findById(slugOrId).catch(() => null));
+    const brand = (await categoriesRepository.findBySlugAndType(slugOrId, "brand")) ??
+        (await categoriesRepository.findById(slugOrId));
     if (!brand || brand.categoryType !== "brand")
         throw new BrandNotFoundError(slugOrId);
     return brand;
 }
 export async function assertBrandSlugUnique(slug) {
-    const existing = await categoriesRepository.findBySlugAndType(slug, "brand").catch(() => null);
+    const existing = await categoriesRepository.findBySlugAndType(slug, "brand");
     if (existing)
         throw new BrandSlugConflictError(slug);
 }

package/dist/_internal/server/features/bundles/actions.js

@@ -13,6 +13,7 @@
  * helpers can fan out stock decrements to member products.
  */
 import { NotFoundError, ValidationError } from "../../../../errors";
+import { safeRead } from "../../../../errors/safe-read";
 import { categoriesRepository } from "../../../../repositories";
 import { cartRepository } from "../../../../features/cart/repository/cart.repository";
 import { assertCanAddNewItems } from "../../../../features/cart/actions/cart-actions";
@@ -55,7 +56,11 @@ quantity = 1) {
     // treating that as a stock quantity would silently change how much a
     // prize-draw member decrements, which the stock fan-out has never done.
     const memberIds = bundle.bundleProductIds ?? [];
-    const memberDocs = await Promise.all(memberIds.map((id) => productRepository.findById(id).catch(() => null)));
+    const memberDocs = await Promise.all(memberIds.map((id) => safeRead(() => productRepository.findById(id), {
+        route: "/bundles",
+        key: "bundles.addBundleToCart.member",
+        fallback: null,
+    })));
     const groupMembers = memberDocs
         .filter((p) => p !== null)
         .map((p) => ({

package/dist/_internal/server/features/bundles/data.js

@@ -8,6 +8,7 @@
 import { cache } from "react";
 import { categoriesRepository } from "../../../../repositories";
 import { productRepository } from "../../../../repositories";
+import { safeRead } from "../../../../errors/safe-read";
 /**
  * Fetch a single bundle by slug for the public detail page. Returns null
  * when the slug is empty or no matching `categoryType:"bundle"` row exists.
@@ -43,7 +44,11 @@ export const listBundleMembers = cache(async (bundle, _opts) => {
     const ids = resolveBundleMemberIds(bundle);
     if (ids.length === 0)
         return [];
-    const results = await Promise.all(ids.map((id) => productRepository.findById(id).catch(() => null)));
+    const results = await Promise.all(ids.map((id) => safeRead(() => productRepository.findById(id), {
+        route: "/bundles",
+        key: "bundles.listBundleMembers.member",
+        fallback: null,
+    })));
     return results.filter((p) => p !== null);
 });
 /**
@@ -58,7 +63,11 @@ export const listBundleMembers = cache(async (bundle, _opts) => {
 export async function resolveBundleOriginalTotal(productIds) {
     if (productIds.length === 0)
         return undefined;
-    const results = await Promise.all(productIds.map((id) => productRepository.findById(id).catch(() => null)));
+    const results = await Promise.all(productIds.map((id) => safeRead(() => productRepository.findById(id), {
+        route: "/bundles",
+        key: "bundles.resolveBundleOriginalTotal.member",
+        fallback: null,
+    })));
     const prices = [];
     for (const p of results) {
         if (!p || typeof p.price !== "number")
@@ -89,7 +98,11 @@ export async function resolveBundleOriginalTotal(productIds) {
 export async function findBundleMemberStores(productIds) {
     if (productIds.length === 0)
         return [];
-    const results = await Promise.all(productIds.map((id) => productRepository.findById(id).catch(() => null)));
+    const results = await Promise.all(productIds.map((id) => safeRead(() => productRepository.findById(id), {
+        route: "/bundles",
+        key: "bundles.findBundleMemberStores.member",
+        fallback: null,
+    })));
     const stores = new Set();
     for (const p of results) {
         // An unresolvable member says nothing about seller spread — the price
@@ -118,7 +131,11 @@ export async function findBundleMemberStores(productIds) {
 export async function resolveBundleCategorySlugs(productIds) {
     if (productIds.length === 0)
         return [];
-    const results = await Promise.all(productIds.map((id) => productRepository.findById(id).catch(() => null)));
+    const results = await Promise.all(productIds.map((id) => safeRead(() => productRepository.findById(id), {
+        route: "/bundles",
+        key: "bundles.resolveBundleCategorySlugs.member",
+        fallback: null,
+    })));
     const slugs = new Set();
     for (const p of results) {
         for (const slug of p?.categorySlugs ?? [])

package/dist/_internal/server/features/cart/data.js

@@ -1,5 +1,7 @@
 import { cache } from "react";
 import { cartRepository } from "../../../../repositories";
 export const getCartForUser = cache(async (userId) => {
-    return (await cartRepository.findByUserId(userId).catch(() => undefined)) ?? null;
+    // No catch: this cart IS the page. Degrading a Firestore failure to null
+    // renders an EMPTY CART to someone whose cart is full — money path.
+    return (await cartRepository.findByUserId(userId)) ?? null;
 });

package/dist/_internal/server/features/cart/service.js

@@ -1,8 +1,13 @@
 import { cartRepository } from "../../../../repositories";
 import { CART_MAX_ITEMS } from "../../../shared/features/cart/config";
 import { CartFullError, CartQuantityError } from "../../../shared/features/cart/errors";
+import { normalizeError } from "../../../../errors/normalize";
+import { serverLogger } from "../../../../monitoring/server-logger";
 export async function assertCartCapacity(userId, addingQty) {
-    const cart = await cartRepository.findByUserId(userId).catch(() => null);
+    // No catch. Swallowing to null made `currentItemCount` 0, so a Firestore
+    // failure silently DISABLED the cart cap and let the add through — a guard
+    // that fails open. A throw is caught by the action envelope and recorded.
+    const cart = await cartRepository.findByUserId(userId);
     const currentItemCount = cart ? (cart.items ?? []).length : 0;
     if (currentItemCount + addingQty > CART_MAX_ITEMS) {
         throw new CartFullError(CART_MAX_ITEMS);
@@ -20,6 +25,12 @@ export async function upsertCartItem(userId, item) {
 }
 export async function mergeGuestItems(userId, guestItems) {
     for (const item of guestItems) {
-        await cartRepository.addItem(userId, item).catch(() => null);
+        // A WRITE, not a read — safeRead does not apply. Guest-merge is
+        // best-effort per item so one bad line cannot lose the whole cart, but a
+        // dropped item must be visible rather than silent.
+        await cartRepository.addItem(userId, item).catch((err) => {
+            void normalizeError(err);
+            serverLogger.warn("cart.mergeGuestCart: item dropped", { userId, err });
+        });
     }
 }

package/dist/_internal/server/features/categories/data.js

@@ -1,17 +1,33 @@
 "use server";
 import { cache } from "react";
 import { categoriesRepository } from "../../../../repositories";
+import { safeRead } from "../../../../errors/safe-read";
 import { CATEGORIES_FEATURED_LIMIT, CATEGORIES_MENU_LIMIT, CATEGORIES_SITEMAP_LIMIT } from "../../../shared/features/categories/config";
 /** Full category document by slug — deduped per request via React.cache(). */
 export const getCategoryForDetail = cache(async (slug) => {
-    const category = (await categoriesRepository.getCategoryBySlug(slug).catch(() => undefined)) ?? null;
-    if (category)
-        void categoriesRepository.incrementViewCount(category.id);
-    return category;
+    /*
+     * 🛑 No view-count write here — deleted 2026-08-31.
+     *
+     * This fired `incrementViewCount` on every render, which was two defects at
+     * once. It is a Firestore WRITE on the render path (Rule #6), and product
+     * and category detail were being counted TWICE by two systems that key
+     * differently: this one on the document by id, and the client
+     * `PageViewTracker` into `pageViews` by slug. They can never reconcile —
+     * they disagree on bots, on prefetch, and on JS-disabled clients — so the
+     * two numbers were guaranteed to drift and neither could be trusted.
+     *
+     * `pageViews` is the single counter now. `viewCount` on the document stays
+     * for historical rows; nothing increments it.
+     */
+    return (await categoriesRepository.getCategoryBySlug(slug)) ?? null;
 });
 /** Flat list of all categories at tier 1 (roots) — for nav/sitemap. */
 export const listRootCategories = cache(async () => {
-    return categoriesRepository.getCategoriesByTier(1).catch(() => []);
+    return safeRead(() => categoriesRepository.getCategoriesByTier(1), {
+        route: "/categories",
+        key: "categories.listRootCategories",
+        fallback: [],
+    });
 });
 /** Featured categories for homepage display (showOnHomepage: true). */
 export const listFeaturedCategories = cache(async () => {
@@ -29,7 +45,11 @@ export const listMenuCategories = cache(async () => {
 });
 /** Full category tree rooted at a given rootId — for sidebar navigation. */
 export const getCategoryTree = cache(async (rootId) => {
-    return categoriesRepository.buildTree(rootId).catch(() => []);
+    return safeRead(() => categoriesRepository.buildTree(rootId), {
+        route: "/categories",
+        key: "categories.getCategoryTree",
+        fallback: [],
+    });
 });
 /** Flat category list for sitemap generation. */
 export const listSitemapCategories = cache(async () => {

package/dist/_internal/server/features/classified/index.d.ts

@@ -1,5 +1,4 @@
 export * from "./data";
-export * from "./actions";
 export * from "./adapters";
 export * from "./metadata";
 export * from "./og";

package/dist/_internal/server/features/classified/index.js

@@ -1,5 +1,4 @@
 export * from "./data";
-export * from "./actions";
 export * from "./adapters";
 export * from "./metadata";
 export * from "./og";

package/dist/_internal/server/features/digital-code/index.d.ts

@@ -1,5 +1,4 @@
 export * from "./data";
 export * from "./adapters";
-export * from "./actions";
 export * from "./metadata";
 export * from "./og";

package/dist/_internal/server/features/digital-code/index.js

@@ -1,5 +1,4 @@
 export * from "./data";
 export * from "./adapters";
-export * from "./actions";
 export * from "./metadata";
 export * from "./og";

package/dist/_internal/server/features/events/actions.js

@@ -6,6 +6,8 @@ import { eventInputSchema, eventUpdateSchema, registerForEventSchema } from "../
 import { assertEventActive } from "./service";
 import { AlreadyRegisteredError, EventNotFoundError } from "../../../shared/features/events/errors";
 import { ValidationError } from "../../../shared/errors/index";
+import { normalizeError } from "../../../../errors/normalize";
+import { serverLogger } from "../../../../monitoring/server-logger";
 export async function createEventAction(input) {
     return wrapAction(async () => {
         const user = await requireRoleUser(["admin", "moderator"]);
@@ -23,7 +25,7 @@ export async function createEventAction(input) {
 export async function updateEventAction(eventId, input) {
     return wrapAction(async () => {
         await requireRoleUser(["admin", "moderator"]);
-        const event = await eventRepository.findById(eventId).catch(() => null);
+        const event = await eventRepository.findById(eventId);
         if (!event)
             throw new EventNotFoundError(eventId);
         const parsed = eventUpdateSchema.safeParse(input);
@@ -52,15 +54,26 @@ export async function registerForEventAction(input) {
             reviewStatus: "pending",
             submittedAt: new Date(),
         });
-        // Increment entry count
-        await eventRepository.incrementTotalEntries(eventId).catch(() => null);
+        // Increment entry count. The entry document is already written and is the
+        // authoritative record, so a failed counter bump must not fail the
+        // registration — but it leaves `stats.totalEntries` under-reporting, and
+        // the capacity check in assertEventActive reads that mirror, so it has to
+        // be visible to an operator rather than dropped (Root Cause #42).
+        await eventRepository.incrementTotalEntries(eventId).catch((err) => {
+            void normalizeError(err);
+            serverLogger.warn("events: incrementTotalEntries failed — stats.totalEntries is now stale", {
+                eventId,
+                error: err instanceof Error ? err.message : String(err),
+            });
+            return null;
+        });
         return entry;
     });
 }
 export async function cancelEventRegistrationAction(entryId) {
     return wrapAction(async () => {
         const user = await requireRoleUser(["buyer", "seller", "admin"]);
-        const entry = await eventEntryRepository.findById(entryId).catch(() => null);
+        const entry = await eventEntryRepository.findById(entryId);
         if (!entry || entry.userId !== user.uid) {
             throw new ValidationError("Registration not found or does not belong to you");
         }

package/dist/_internal/server/features/events/data.js

@@ -1,5 +1,5 @@
 import { cache } from "react";
 import { eventRepository } from "../../../../repositories";
 export const getEventForDetail = cache(async (id) => {
-    return eventRepository.findById(id).catch(() => null);
+    return eventRepository.findById(id);
 });

package/dist/_internal/server/features/events/service.js

@@ -1,7 +1,7 @@
 import { eventRepository } from "../../../../repositories";
 import { EventNotFoundError, EventNotActiveError, EventEndedError, EventFullError, } from "../../../shared/features/events/errors";
 export async function assertEventActive(eventId) {
-    const event = await eventRepository.findById(eventId).catch(() => null);
+    const event = await eventRepository.findById(eventId);
     if (!event)
         throw new EventNotFoundError(eventId);
     const status = event.status;

package/dist/_internal/server/features/grouped/data.js

@@ -1,6 +1,7 @@
 import { cache } from "react";
 import { getAdminDb } from "../../../../providers/db-firebase";
 import { normalizeError } from "../../../../errors/normalize";
+import { safeRead } from "../../../../errors/safe-read";
 import { serverLogger } from "../../../../monitoring/server-logger";
 import { GROUPED_LISTINGS_COLLECTION, } from "../../../../features/grouped/schemas/firestore";
 import { productRepository, groupedListingsRepository } from "../../../../repositories";
@@ -70,7 +71,7 @@ export const getGroupedListingWithItems = cache(async (slug) => {
         return null;
     const items = [];
     for (const productId of doc.productIds) {
-        const product = await productRepository.findByIdOrSlug(productId).catch(() => null);
+        const product = await safeRead(() => productRepository.findByIdOrSlug(productId), { route: "/groups", key: "grouped.getGroupedListingWithItems.member", fallback: null });
         if (product)
             items.push(product);
     }
@@ -128,7 +129,11 @@ export const getGroupsWithItemsForProduct = cache(async (productId) => {
     const groups = await getGroupsForProduct(productId);
     return Promise.all(groups.map(async (group) => {
         const otherIds = group.productIds.filter((id) => id !== productId);
-        const items = await Promise.all(otherIds.map((id) => productRepository.findByIdOrSlug(id).catch(() => null)));
+        const items = await Promise.all(otherIds.map((id) => safeRead(() => productRepository.findByIdOrSlug(id), {
+            route: "/products",
+            key: "grouped.getGroupsWithItemsForProduct.member",
+            fallback: null,
+        })));
         return { ...group, items: items.filter((p) => p !== null) };
     }));
 });

package/dist/_internal/server/features/item-requests/data.js

@@ -16,5 +16,5 @@ export const getItemRequestForDetail = cache(async (id, _opts) => {
     void _opts;
     if (!id)
         return null;
-    return (await itemRequestsRepository.findById(id).catch(() => null)) ?? null;
+    return (await itemRequestsRepository.findById(id)) ?? null;
 });

package/dist/_internal/server/features/live/index.d.ts

@@ -1,5 +1,4 @@
 export * from "./data";
 export * from "./adapters";
-export * from "./actions";
 export * from "./metadata";
 export * from "./og";

package/dist/_internal/server/features/live/index.js

@@ -1,5 +1,4 @@
 export * from "./data";
 export * from "./adapters";
-export * from "./actions";
 export * from "./metadata";
 export * from "./og";

package/dist/_internal/server/features/lottery/actions.js

@@ -39,7 +39,7 @@ export async function submitLotteryPullAction(input) {
         // Load the event/product to get the lotteryConfig
         let lotteryConfig;
         if (data.sourceType === "event") {
-            const event = await eventRepository.findById(sourceId).catch(() => null);
+            const event = await eventRepository.findById(sourceId);
             if (!event || event.type !== "lottery") {
                 throw new LotteryError("LOTTERY_WINDOW_CLOSED", "Lottery event not found or not of type lottery.");
             }
@@ -52,7 +52,7 @@ export async function submitLotteryPullAction(input) {
             lotteryConfig = event.lotteryConfig;
         }
         else {
-            const product = await productRepository.findById(sourceId).catch(() => null);
+            const product = await productRepository.findById(sourceId);
             if (!product || product.listingType !== "prize-draw") {
                 throw new LotteryError("LOTTERY_WINDOW_CLOSED", "Prize-draw product not found.");
             }

package/dist/_internal/server/features/lottery/data.js

@@ -4,7 +4,7 @@ import { lotteryEntryRepository } from "../../../../features/lottery/repository/
 import { toClientLotteryConfig } from "./adapters";
 /** Fetch a lottery-type event with price/weight stripped for client use. */
 export const getLotteryEventCached = cache(async (id) => {
-    const event = await eventRepository.findById(id).catch(() => null);
+    const event = await eventRepository.findById(id);
     if (!event || event.type !== "lottery")
         return null;
     return {

package/dist/_internal/server/features/orders/actions.js

@@ -53,7 +53,7 @@ export async function updateOrderStatusAction(input) {
         const parsed = updateOrderStatusSchema.safeParse(input);
         if (!parsed.success)
             throw new ValidationError(parsed.error.issues[0]?.message ?? "Invalid input");
-        const order = await orderRepository.findById(parsed.data.orderId).catch(() => null);
+        const order = await orderRepository.findById(parsed.data.orderId);
         if (!order)
             throw new OrderNotFoundError(parsed.data.orderId);
         if (!isAdminUser(user) && order.storeId !== user.uid) {
@@ -126,7 +126,7 @@ function notifyAdminsOfPaymentProof(order) {
 export async function attachPaymentProofAction(orderId, proof) {
     return wrapAction(async () => {
         const user = await requireRoleUser(["buyer", "seller", "admin"]);
-        const order = await orderRepository.findById(orderId).catch(() => null);
+        const order = await orderRepository.findById(orderId);
         if (!order)
             throw new OrderNotFoundError(orderId);
         if (!isAdminUser(user) && order.userId !== user.uid)
@@ -187,7 +187,7 @@ export async function adminVerifyPaymentAction(orderId) {
         if (!isAdminUser(user) && !isModeratorUser(user)) {
             throw new ValidationError("Only admin or moderator can verify payments");
         }
-        const order = await orderRepository.findById(orderId).catch(() => null);
+        const order = await orderRepository.findById(orderId);
         if (!order)
             throw new OrderNotFoundError(orderId);
         if (order.paymentStatus === "paid")
@@ -226,7 +226,7 @@ export async function adminRequestProofReuploadAction(orderId, note) {
         }
         if (!note.trim())
             throw new ValidationError(REASON_REQUIRED_MSG);
-        const order = await orderRepository.findById(orderId).catch(() => null);
+        const order = await orderRepository.findById(orderId);
         if (!order)
             throw new OrderNotFoundError(orderId);
         if (order.paymentStatus === "paid") {
@@ -275,7 +275,7 @@ export async function adminRejectPaymentAsFraudAction(orderId, note) {
         }
         if (!note.trim())
             throw new ValidationError(REASON_REQUIRED_MSG);
-        const order = await orderRepository.findById(orderId).catch(() => null);
+        const order = await orderRepository.findById(orderId);
         if (!order)
             throw new OrderNotFoundError(orderId);
         if (order.paymentStatus === "paid") {
@@ -317,13 +317,13 @@ export async function raiseOrderDisputeAction(orderId, reason) {
         const user = await requireRoleUser(["buyer", "seller", "admin"]);
         if (!reason.trim())
             throw new ValidationError(REASON_REQUIRED_MSG);
-        const order = await orderRepository.findById(orderId).catch(() => null);
+        const order = await orderRepository.findById(orderId);
         if (!order)
             throw new OrderNotFoundError(orderId);
         const isBuyer = order.userId === user.uid;
         let isSeller = false;
         if (!isBuyer && !isAdminUser(user) && !isModeratorUser(user) && order.storeId) {
-            const store = await storeRepository.findById(order.storeId).catch(() => null);
+            const store = await storeRepository.findById(order.storeId);
             isSeller = store?.ownerId === user.uid;
         }
         if (!isBuyer && !isSeller && !isAdminUser(user) && !isModeratorUser(user)) {

package/dist/_internal/server/features/orders/data.d.ts

@@ -7,4 +7,4 @@ export declare const getOrdersForBuyer: (userId: string, page?: number, pageSize
     totalPages: number;
     hasMore: boolean;
 }>;
-export declare const getRecentOrdersForBuyer: (userId: string) => Promise<never[] | import("../../../..").OrderDocument[]>;
+export declare const getRecentOrdersForBuyer: (userId: string) => Promise<import("../../../..").OrderDocument[]>;

package/dist/_internal/server/features/orders/data.js

@@ -1,7 +1,12 @@
 import { cache } from "react";
 import { orderRepository } from "../../../../repositories";
+import { safeRead } from "../../../../errors/safe-read";
 export const getOrderForDetail = cache(async (orderId) => {
-    return (await orderRepository.findById(orderId).catch(() => undefined)) ?? null;
+    // No catch: this order IS the page. Swallowing a Firestore failure to null
+    // renders "order not found" for a datastore outage — the caller cannot tell
+    // the two apart, which is Root Cause #59 on the money path. A throw reaches
+    // the route/error boundary and is now recorded.
+    return (await orderRepository.findById(orderId)) ?? null;
 });
 export const getOrdersForBuyer = cache(async (userId, page = 1, pageSize = 20) => {
     return orderRepository.listForUser(userId, { page, pageSize }).catch(() => ({
@@ -14,5 +19,12 @@ export const getOrdersForBuyer = cache(async (userId, page = 1, pageSize = 20) =
     }));
 });
 export const getRecentOrdersForBuyer = cache(async (userId) => {
-    return orderRepository.findRecentByUser(userId).catch(() => []);
+    // Optional: a recent-orders rail. Degrading to empty is right, but it must
+    // be VISIBLE — safeRead records a DEGRADED_READ row instead of returning a
+    // value indistinguishable from "no recent orders".
+    return safeRead(() => orderRepository.findRecentByUser(userId), {
+        route: "/user/orders",
+        key: "orders.findRecentByUser",
+        fallback: [],
+    });
 });

package/dist/_internal/server/features/orders/service.js

@@ -2,7 +2,7 @@ import { orderRepository } from "../../../../repositories";
 import { OrderNotFoundError, OrderCancelError, OrderOwnershipError, OrderReturnWindowError, } from "../../../shared/features/orders/errors";
 import { ORDER_CANCELLABLE_STATUSES, ORDER_RETURN_WINDOW_MS, } from "../../../shared/features/orders/config";
 export async function assertOrderOwnership(orderId, userId) {
-    const order = await orderRepository.findById(orderId).catch(() => null);
+    const order = await orderRepository.findById(orderId);
     if (!order)
         throw new OrderNotFoundError(orderId);
     if (order.userId !== userId)

package/dist/_internal/server/features/pre-orders/service.js

@@ -4,7 +4,7 @@ import { roundRupees } from "../../../../utils/number.formatter";
 import { PreOrderNotFoundError, PreOrderSoldOutError, PreOrderNotOpenError, } from "../../../shared/features/pre-orders/errors";
 /** Assert a pre-order exists, is published, and has remaining capacity. */
 export async function assertPreOrderAvailable(preOrderId, requestedQty = 1) {
-    const product = await productRepository.findByIdOrSlug(preOrderId).catch(() => null);
+    const product = await productRepository.findByIdOrSlug(preOrderId);
     if (!product || !isPreOrderListing(product))
         throw new PreOrderNotFoundError(preOrderId);
     if (product.status !== "published")

package/dist/_internal/server/features/prize-draws/actions.js

@@ -9,7 +9,7 @@ export async function enterPrizeDrawAction(input) {
         const { prizeDrawId } = input;
         if (!prizeDrawId)
             throw new Error("prizeDrawId is required.");
-        const product = await productRepository.findByIdOrSlug(prizeDrawId).catch(() => null);
+        const product = await productRepository.findByIdOrSlug(prizeDrawId);
         if (!product)
             throw new Error("Prize draw not found.");
         assertPrizeDrawOpen(product);