@mohasinac/appkit 4.29.0 → 4.29.1

package/dist/_internal/server/jobs/handlers/_helpers.d.ts

@@ -10,5 +10,27 @@ export { getAdminRealtimeDb };
  * Query docs tagged isTestData:true in a collection. `cutoff: null` returns every
  * tester-sandbox doc regardless of expiry (manual force-purge); a real Date returns
  * only the ones past testDataExpiresAt (the scheduled 7-day sweep).
+ *
+ * ## 🛑 `isTestData` without `testDataExpiresAt` means PERMANENT, never purge
+ *
+ * The flag has two uses, and only one of them is a sandbox fixture:
+ *
+ *   · a fixture — `isTestData: true` PLUS `testDataExpiresAt`. Disposable,
+ *     swept on the 7-day cycle. Every doc in `features/tester/seed-data/` is
+ *     this shape; the invariant was checked across all six files.
+ *   · permanently hidden — `isTestData: true` and NO expiry. Real, permanent
+ *     content that simply must not reach the public or the sitemap.
+ *     `store-tester-qa-seller` is the case that forced this distinction.
+ *
+ * The scheduled path already separates them: `testDataExpiresAt <= cutoff`
+ * excludes docs lacking the field. The FORCE path did not — `cutoff: null`
+ * drops that clause and returned everything, so `tester:purge-sandbox --force`
+ * would have deleted a permanent seed store. Hence the filter below.
+ *
+ * Filtered in memory rather than as a query clause: a Firestore inequality on
+ * `testDataExpiresAt` would exclude every doc missing it, which is the trap
+ * documented in CLAUDE.md's anti-pattern table — correct here by luck, wrong
+ * the moment someone reuses the shape. In-memory keeps the intent legible, and
+ * the read is already bounded at 200.
  */
 export declare function getTestDataRefs(db: FirebaseFirestore.Firestore, collection: string, cutoff: Date | null): Promise<FirebaseFirestore.DocumentReference[]>;

package/dist/_internal/server/jobs/handlers/_helpers.js

@@ -22,6 +22,28 @@ export { getAdminRealtimeDb };
  * Query docs tagged isTestData:true in a collection. `cutoff: null` returns every
  * tester-sandbox doc regardless of expiry (manual force-purge); a real Date returns
  * only the ones past testDataExpiresAt (the scheduled 7-day sweep).
+ *
+ * ## 🛑 `isTestData` without `testDataExpiresAt` means PERMANENT, never purge
+ *
+ * The flag has two uses, and only one of them is a sandbox fixture:
+ *
+ *   · a fixture — `isTestData: true` PLUS `testDataExpiresAt`. Disposable,
+ *     swept on the 7-day cycle. Every doc in `features/tester/seed-data/` is
+ *     this shape; the invariant was checked across all six files.
+ *   · permanently hidden — `isTestData: true` and NO expiry. Real, permanent
+ *     content that simply must not reach the public or the sitemap.
+ *     `store-tester-qa-seller` is the case that forced this distinction.
+ *
+ * The scheduled path already separates them: `testDataExpiresAt <= cutoff`
+ * excludes docs lacking the field. The FORCE path did not — `cutoff: null`
+ * drops that clause and returned everything, so `tester:purge-sandbox --force`
+ * would have deleted a permanent seed store. Hence the filter below.
+ *
+ * Filtered in memory rather than as a query clause: a Firestore inequality on
+ * `testDataExpiresAt` would exclude every doc missing it, which is the trap
+ * documented in CLAUDE.md's anti-pattern table — correct here by luck, wrong
+ * the moment someone reuses the shape. In-memory keeps the intent legible, and
+ * the read is already bounded at 200.
  */
 export async function getTestDataRefs(db, collection, cutoff) {
     let q = db
@@ -30,5 +52,7 @@ export async function getTestDataRefs(db, collection, cutoff) {
     if (cutoff)
         q = q.where("testDataExpiresAt", "<=", cutoff);
     const snap = await q.limit(200).get();
-    return snap.docs.map((d) => d.ref);
+    return snap.docs
+        .filter((d) => cutoff !== null || d.get("testDataExpiresAt") != null)
+        .map((d) => d.ref);
 }

package/dist/seed/stores-seed-data.js

@@ -178,6 +178,24 @@ const _rawstoresSeedData = [
         },
         isPublic: true,
         isVacationMode: false,
+        /*
+         * Reachable, but never advertised to search engines.
+         *
+         * This is a QA store — real enough for a tester to exercise seller flows
+         * against, and not something that belongs in Google's index. `isTestData`
+         * is what the codebase already uses to express that: the sitemap's store
+         * fetcher filters it out (it has no viewer), public store listings hide
+         * it, and `canViewTestData()` keeps it visible to testers and admins — so
+         * the checklist case linking to `/stores/store-tester-qa-seller` still
+         * resolves.
+         *
+         * 🛑 NOTE the deliberate absence of `testDataExpiresAt`. Every sandbox
+         * FIXTURE carries one; this store is permanent. `getTestDataRefs` skips
+         * docs without an expiry on the force-purge path precisely so
+         * `tester:purge-sandbox --force` cannot delete it. Do not add an expiry
+         * here — that would put a permanent seed store in range of the sweep.
+         */
+        isTestData: true,
         stats: { totalProducts: 0, itemsSold: 0, totalReviews: 0, averageRating: 0 },
         capabilities: ["host_preorders", "verified_seller", "create_coupons"],
         createdAt: daysAgo(1),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mohasinac/appkit",
-  "version": "4.29.0",
+  "version": "4.29.1",
   "license": "MIT",
   "publishConfig": {
     "access": "public"